Context Navigation

← Previous Period
Next Period →

Timeline

Nov 24, 2009:

11:32 PM Changeset in webkit [51377] by bweinstein@apple.com

20 edits
2 copies in trunk

Un-roll out the roll out that was committed in r51376 because it didn't help the Windows bots,
even though it seemed to in my testing. Sorry.

11:04 PM Changeset in webkit [51376] by bweinstein@apple.com

20 edits
2 deletes in trunk

Roll out r51354, r51460, and r51461 to see if removing them will fix
the Windows test bots, which are currently not very happy.

10:04 PM Changeset in webkit [51375] by cmarrin@apple.com

2 edits in trunk/WebKit/win

Another Windows build fix

Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING

10:01 PM Changeset in webkit [51374] by dimich@chromium.org

8 edits
10 adds in trunk/WebCore

Initial implementation of WebKitSharedScript and SharedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=31569

Reviewed by David Levin.

No new tests since there are no bindings yet (soon to come).

DerivedSources.make: Add WebKitSharedScript and SharedScriptContext to a list of idl files.
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::detach): Notify WebKitSharedScriptRepository that document is detaching.

dom/EventTarget.cpp: Add new casting methods, since the new types are EventTargets.

(WebCore::EventTarget::toWebKitSharedScript):
(WebCore::EventTarget::toSharedScriptContext):

dom/EventTarget.h: Ditto
dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isSharedScriptContext): New virtual method, since there is a new type of context.

SharedScript/SharedScriptContext.cpp: Added. Similar to WorkerContext, but w/o threading.

(WebCore::SharedScriptContext::SharedScriptContext):
(WebCore::SharedScriptContext::~SharedScriptContext):
(WebCore::SharedScriptContext::clearScript):
(WebCore::SharedScriptContext::virtualURL):
(WebCore::SharedScriptContext::virtualCompleteURL):
(WebCore::SharedScriptContext::reportException):
(WebCore::SharedScriptContext::addMessage):
(WebCore::SharedScriptContext::resourceRetrievedByXMLHttpRequest):
(WebCore::SharedScriptContext::scriptImported):
(WebCore::SharedScriptContext::matches):
(WebCore::SharedScriptContext::addToDocumentsList):
(WebCore::SharedScriptContext::destructionTimerFired):
(WebCore::SharedScriptContext::removeFromDocumentList):
(WebCore::SharedScriptContext::load):
(WebCore::SharedScriptContext::postTask):
(WebCore::SharedScriptContext::eventTargetData):
(WebCore::SharedScriptContext::ensureEventTargetData):
(WebCore::SharedScriptContext::scriptExecutionContext):

SharedScript/SharedScriptContext.h: Added.

(WebCore::SharedScriptContext::create):
(WebCore::SharedScriptContext::isSharedScriptContext):
(WebCore::SharedScriptContext::userAgent):
(WebCore::SharedScriptContext::toSharedScriptContext):
(WebCore::SharedScriptContext::self):
(WebCore::SharedScriptContext::script):
(WebCore::SharedScriptContext::loaded):
(WebCore::SharedScriptContext::name):
(WebCore::SharedScriptContext::refEventTarget):
(WebCore::SharedScriptContext::derefEventTarget):
(WebCore::SharedScriptContext::refScriptExecutionContext):
(WebCore::SharedScriptContext::derefScriptExecutionContext):

SharedScript/SharedScriptContext.idl: Added.

SharedScript/SharedScriptController.h:

Added. Empty implementation of a ScriptController, will come later as part of bindings. Needed to compile.

SharedScript/WebKitSharedScript.cpp: Added. EventTarget-based DOM object.

(WebCore::WebKitSharedScript::WebKitSharedScript):
(WebCore::WebKitSharedScript::~WebKitSharedScript):
(WebCore::WebKitSharedScript::setContext):
(WebCore::LoadEventTask::create): Fires asynchronous 'load' event when underlying SharedScriptContext is initialized.
(WebCore::LoadEventTask::performTask):
(WebCore::LoadEventTask::LoadEventTask):
(WebCore::WebKitSharedScript::scheduleLoadEvent):

SharedScript/WebKitSharedScript.h: Added.

(WebCore::WebKitSharedScript::create):
(WebCore::WebKitSharedScript::scriptExecutionContext):
(WebCore::WebKitSharedScript::toWebKitSharedScript):
(WebCore::WebKitSharedScript::context):
(WebCore::WebKitSharedScript::refEventTarget):
(WebCore::WebKitSharedScript::derefEventTarget):
(WebCore::WebKitSharedScript::eventTargetData):
(WebCore::WebKitSharedScript::ensureEventTargetData):

SharedScript/WebKitSharedScript.idl: Added.

SharedScript/WebKitSharedScriptRepository.cpp: Added. Implements a list of running SharedScriptContexts.

(WebCore::ScriptLoader::ScriptLoader): The helper class to load an initial script of SharedScriptContext.
(WebCore::ScriptLoader::load):
(WebCore::ScriptLoader::notifyFinished):
(WebCore::WebKitSharedScriptRepository::instance): Repository has a static global instance.
(WebCore::WebKitSharedScriptRepository::connect):
(WebCore::WebKitSharedScriptRepository::documentDetached): Called from Document::detach().
(WebCore::WebKitSharedScriptRepository::removeSharedScriptContext): Called from ~SharedScriptContext().
(WebCore::WebKitSharedScriptRepository::connectToSharedScript):
(WebCore::WebKitSharedScriptRepository::getSharedScriptContext):

SharedScript/WebKitSharedScriptRepository.h: Added.

(WebCore::WebKitSharedScriptRepository::WebKitSharedScriptRepository):

9:38 PM Changeset in webkit [51373] by dimich@chromium.org

16 edits in trunk

Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31444

Reviewed by Eric Seidel.

configure.ac:

JavaScriptCore:

Configurations/FeatureDefines.xcconfig:
wtf/Platform.h:

WebCore:

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
WebCore.pro:

WebKit:

chromium/features.gypi:

WebKit/chromium:

features.gypi:

WebKit/mac:

Configurations/FeatureDefines.xcconfig:

WebKitTools:

Scripts/build-webkit:

9:22 PM Changeset in webkit [51372] by cmarrin@apple.com

2 edits in trunk/WebKit/win

Fixed Windows build

Got rid of QuartzCore.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING

8:29 PM Changeset in webkit [51371] by cmarrin@apple.com

19 edits
8 adds in trunk

Implement accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=27314

Initial implementation, but disabled in this checkin.
To enable ENABLE_3D_RENDERING and USE_ACCELERATED_COMPOSITING
must be turned on. Also d3d9.lib and d3d9x.lib must be added
to the build.

7:13 PM Changeset in webkit [51370] by cmarrin@apple.com

5 edits
2 adds in trunk

Do error checking of parameter to createShader
https://bugs.webkit.org/show_bug.cgi?id=31808

6:45 PM Changeset in webkit [51369] by eric@webkit.org

3 edits
3 adds in trunk

2009-11-24 Jason Smith <dark.panda@gmail.com>

Reviewed by Alexey Proskuryakov.

RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689

LayoutTests/fast/js/regexp-in-and-foreach-handling.html: Added.
LayoutTests/fast/js/script-tests/regexp-in-and-foreach-handling.js: Added.
LayoutTests/fast/js/regexp-in-and-foreach-handling-expected.txt: Added.

2009-11-24 Jason Smith <dark.panda@gmail.com>

Reviewed by Alexey Proskuryakov.

RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689

JavaScriptCore/runtime/RegExpConstructor.cpp: ensure that undefined values are added to the returned RegExpMatchesArray

6:16 PM Changeset in webkit [51368] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-24 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Ignore line-height CSS property specified to a search field on
Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=31820

LayoutTests/fast/forms/control-restrict-line-height.html checks that the
following controls should ignore line-height CSS property.

<select>
<input type=button>
<input type=search>

This change addresses the <input type=search> issue with Chromium/Windows
and Chromium/Linux.

rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle): Implement this to ignore line-height.
rendering/RenderThemeChromiumSkia.h: Declare adjustSearchFieldStyle().

5:22 PM Changeset in webkit [51367] by Simon Fraser

2 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

No review.

Stylistic fix: indent the member var initialisation.

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::GraphicsLayerCA):

4:24 PM Changeset in webkit [51366] by Simon Fraser

2 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.

SVGUseElement::toClipPath can crash
<rdar://problem/7385270>

Null-test m_shadowTreeRootElement again, because the call to buildPendingResource() may not
actually initialize it.

svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):

4:06 PM Changeset in webkit [51365] by snej@chromium.org

2 edits in trunk

Add Chromium's gyp-generated Xcode projects to the .gitignore file.

3:46 PM Changeset in webkit [51364] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-24 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

Linux Chromium sends too many click events
https://bugs.webkit.org/show_bug.cgi?id=31841

Manually count number of clicks for double/triple click events. This
makes us match Firefox on http://www.quirksmode.org/js/events_mouse.html
Chromium side of this patch is here:
http://codereview.chromium.org/431031/show

src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseEvent):

3:43 PM Changeset in webkit [51363] by barraclough@apple.com

15 edits in trunk/WebCore

Bug 31848 - Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.

Reviewed by Geoff Garen.

These methods get the world from the global data rather than from an execstate.
If the current world is always read from an exec state then it can be read
from the global object, and world entry can become automagical, rather than
being explicitly set by an EnterDOMWrapperWorld.

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

bindings/js/JSDOMBinding.cpp:

(WebCore::currentWorld):
(WebCore::DOMObjectWrapperMapFor):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::getCachedDOMObjectWrapper):
(WebCore::cacheDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapper):
(WebCore::getCachedDOMNodeWrapper):
(WebCore::cacheDOMNodeWrapper):

bindings/js/JSDOMBinding.h:

(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
(WebCore::createDOMNodeWrapper):
(WebCore::getDOMNodeWrapper):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):

bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):
(WebCore::toJS):

bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJS):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):
(WebCore::createWrapper):
(WebCore::toJS):

bindings/js/JSSVGPathSegCustom.cpp:

(WebCore::toJS):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::toJS):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

3:19 PM Changeset in webkit [51362] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queries_unittest.py should test command output
https://bugs.webkit.org/show_bug.cgi?id=31845

Scripts/modules/commands/queries_unittest.py:
- Capture stdout and stderr and compare with expected strings.

2:41 PM Changeset in webkit [51361] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Also, don't include the wrong one!

2:34 PM Changeset in webkit [51360] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Include the proper WKSI header.

2:32 PM Changeset in webkit [51359] by Simon Fraser

2 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Windows build fix.

page/win/FrameCGWin.cpp: (WebCore::imageFromRect): (WebCore::imageFromSelection):

2:21 PM Changeset in webkit [51358] by eric.carlson@apple.com

8 edits in trunk/WebCore

2009-11-24 Eric Carlson <eric.carlson@apple.com>

Not reviewed. Revert r51351 until a new WebKitSupportLibrary is available.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
platform/graphics/win/QTMovieWin.cpp:
platform/graphics/win/QTMovieWin.h:
rendering/RenderMediaControls.cpp:
rendering/RenderThemeWin.cpp:
rendering/RenderThemeWin.h:

2:16 PM Changeset in webkit [51357] by Simon Fraser

2 edits in trunk/WebKitTools

2009-11-24 Simon Fraser <Simon Fraser>

No Review.

Fix spelling error ("depenedencies").

Scripts/build-webkit:

2:05 PM Changeset in webkit [51356] by mrowe@apple.com

2 edits in trunk/WebKitTools

Land the configuration that includes the two debug GTK Linux builders.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:54 PM Changeset in webkit [51355] by Simon Fraser

7 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Find highlight is drawn incorrectly on pages with compositing layers
<rdar://problem/7413925>

Part 2: Add a new bit to the PaintBehavior flags, PaintBehaviorFlattenCompositingLayers,
and pass that down when painting into an image.

When set, it forces painting of compositing layers to go down a software paint path
when all layers are painted, irrespective of compositing status, and where
3d transforms are flattened to 2d. When doing this, we also need to use temporary
clip rects for layers which are normally composited.

page/FrameView.h: (WebCore::FrameView::paintBehavior):
page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::renderableTransform): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer):
rendering/RenderLayer.h: (WebCore::RenderLayer::paintsWithTransparency): (WebCore::RenderLayer::paintsWithTransform):
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
rendering/RenderObject.h:

1:50 PM Changeset in webkit [51354] by ap@apple.com

20 edits
2 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=31844
SocketStreamHandleCFNet should support CONNECT proxy credentials

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/network/CredentialStorage.h:
platform/network/mac/CredentialStorageMac.mm: Added. (WebCore::CredentialStorage::getFromPersistentStorage):
platform/network/cf/CredentialStorageCFNet.cpp: Added. (WebCore::CredentialStorage::getFromPersistentStorage): Add support for fetching credentials from persistent storage (CFNet version is currently a stub).

bindings/js/JSWebSocketCustom.cpp: Removed an unneeded include.

platform/network/cf/SocketStreamHandle.h:
platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::createStreams): (WebCore::getStoredCONNECTProxyCredentials): (WebCore::authenticationSchemeFromAuthenticationMethod): (WebCore::SocketStreamHandle::addCONNECTCredentials): (WebCore::SocketStreamHandle::readStreamCallback): Check if connection attempt was resulted in 407, and try stored credentials if it did.

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
WebCore.base.exp: Updated WKSI.

1:44 PM Changeset in webkit [51353] by Simon Fraser

10 edits in trunk/WebCore

2009-11-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Find highlight is drawn incorrectly on pages with compositing layers
<rdar://problem/7413925>

Part 1: Rename PaintRestriction to PaintBehavior, and make it a bitmask, in
preparation for adding a new flag related to painting into an image.

PaintBehaviorSelectionOnly and PaintBehaviorForceBlackText are now separate flags.

page/FrameView.cpp: (WebCore::FrameView::reset): (WebCore::FrameView::paintContents): (WebCore::FrameView::setPaintBehavior):
page/FrameView.h:
page/mac/FrameMac.mm: (WebCore::Frame::selectionImage):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
rendering/RenderLayerBacking.h:
rendering/RenderObject.h:
rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):

1:41 PM Changeset in webkit [51352] by oliver@apple.com

2 edits in trunk/JavaScriptCore

JSON.stringify performance on undefined is very poor
https://bugs.webkit.org/show_bug.cgi?id=31839

Reviewed by Alexey Proskuryakov.

Switch from a UString to a Vector<UChar> when building
the JSON string, allowing us to safely remove the substr-copy
we otherwise did when unwinding an undefined property.

Also turns out to be a ~5% speedup on stringification.

1:31 PM Changeset in webkit [51351] by eric.carlson@apple.com

8 edits in trunk/WebCore

2009-11-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7409331> Windows: Support closed caption in <video> element

Enable closed captions in QuickTime/Windows media engine.

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::hasClosedCaptions): (QTMovieWin::setClosedCaptionsVisible):
platform/graphics/win/QTMovieWin.h:
rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
rendering/RenderThemeWin.h:

1:22 PM Changeset in webkit [51350] by darin@chromium.org

6 edits
4 adds in trunk

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

Test: http/tests/cache/subresource-failover-to-network.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use the originalRequest when inheriting cache policy. This matches SubresourceLoader::create.

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

This test verifies that a synchronous XMLHttpRequest, generated from a
page that is the result of a form submission, loads properly when the
user navigates back to the page.

When navigating back to a page that resulted from a form submission,
the page is loaded with the ReturnCacheDataDontLoad cache policy. It
is important that subresources (including XMLHttpRequest instances) do
not inherit this cache policy.

http/tests/cache/resources/echo-no-store.cgi: Added.
http/tests/cache/resources/subresource-failover-to-network.cgi: Added.
http/tests/cache/subresource-failover-to-network-expected.txt: Added.
http/tests/cache/subresource-failover-to-network.html: Added.

2009-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest): Assign ReturnCacheDataDontLoad cache policy at the last moment to match Safari. This way the cache policy does not get stored in DocumentLoader's originalRequest preventing it from being inherited by subresource requests.
src/ResourceHandle.cpp: (WebCore::ResourceHandle::willLoadFromCache): Remove assignment of ReturnCacheDataDontLoad cache policy so that it doesn't end up applying to the DocumentLoader's originalRequest.

12:18 PM Changeset in webkit [51349] by cmarrin@apple.com

2 adds in trunk/WebCore/html/canvas

Didn't add these files to http://trac.webkit.org/changeset/51348

12:04 PM Changeset in webkit [51348] by cmarrin@apple.com

33 edits in trunk

Change get... calls to latest spec
https://bugs.webkit.org/show_bug.cgi?id=30091

Removed old versions of get calls on WebGLRenderingContext and
added new ones per spec returning "any". New code simplifies
GraphicsContext3D and fixes previously unimplemented routines.
Added custom JS and V8 bindings. Added exhaustive test case
exercising all new code paths. Updated preexisting test cases for
new APIs. Fixed preexisting bugs in WebKit's and Chrome's WebGL
implementations.

Ran WebGL layout tests in WebKit (clean) and Chrome (couple of
preexisting known failures) and manual WebGL tests in both
browsers.

11:51 AM Changeset in webkit [51347] by sfalken@apple.com

2 edits in trunk/WebCore

Windows build fix.

WebCore.vcproj/QTMovieWin.vcproj: Add additional search path for QuickTime SDK.

11:50 AM Changeset in webkit [51346] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/31840> bisect-builds broke after r50080

Reviewed by Dan Bernstein.

Scripts/bisect-builds:

(mountAndRunNightly): Switched back to using backticks to run
the hdiutil command since exec() will terminate the existing
script, which is not what we want. Store the output of
File::Spec->devnull() in a variable for use in the hdiutil
detach commands.

11:38 AM Changeset in webkit [51345] by pfeldman@chromium.org

2 edits in trunk/WebKit/chromium

2009-11-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Chromium: Expose method for reporting user stats
to the host. Also includes drive-by default implementation.

https://bugs.webkit.org/show_bug.cgi?id=31830

public/WebKitClient.h:

11:33 AM Changeset in webkit [51344] by dimich@chromium.org

2 edits
1 add
5 deletes in trunk/LayoutTests

Convert fast/table/row-height-recalc2.html to be 'dumpAsText()'
https://bugs.webkit.org/show_bug.cgi?id=31816

Reviewed by Eric Seidel.

fast/table/row-height-recalc2-expected.txt: Added.
fast/table/row-height-recalc2.html:
platform/mac/fast/table/row-height-recalc2-expected.checksum: Removed.
platform/mac/fast/table/row-height-recalc2-expected.png: Removed.
platform/mac/fast/table/row-height-recalc2-expected.txt: Removed.
platform/qt/fast/table/row-height-recalc2-expected.checksum: Removed.
platform/qt/fast/table/row-height-recalc2-expected.png: Removed.
platform/qt/fast/table/row-height-recalc2-expected.txt: Removed.
platform/win/fast/table/row-height-recalc2-expected.checksum: Removed.
platform/win/fast/table/row-height-recalc2-expected.png: Removed.

10:55 AM Changeset in webkit [51343] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
https://bugs.webkit.org/show_bug.cgi?id=26354

Implemented MediaPlayerPrivate::isAvailable by checking the
presence of the playbin2 GStreamer element.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::isAvailable):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

10:47 AM Changeset in webkit [51342] by eric@webkit.org

4 edits in trunk

2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

When building up the pango layout from text boxes, only append a
newline char after verifying there are no more boxes on this line.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):

2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

When building up the pango layout from text boxes, only append a
newline char after verifying there are no more boxes on this line.

tests/testatk.c (test_webkit_atk_get_text_at_offset_newlines): (main):

9:53 AM Changeset in webkit [51341] by Joseph Pecoraro

4 edits in trunk/WebCore

2009-11-24 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Keyboard Shortcut to Clear Console Messages
https://bugs.webkit.org/show_bug.cgi?id=31780

All Platforms: Ctrl+L = Clear Console Messages
Mac Only: Cmd+K = Clear Console Messages

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): create shortcuts (WebInspector.ConsoleView.prototype._promptKeyDown): handle shortcuts
inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.makeKey): convenience conversion of "a-z" character to keyCode
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): style fixes for keyboard shortcuts

9:20 AM Changeset in webkit [51340] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touch inspector controller in order to
kick win bot inspector deploy. rs=aroben.

inspector/InspectorController.cpp:

9:15 AM Changeset in webkit [51339] by pfeldman@chromium.org

7 edits in trunk

2009-11-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement expandable compartments on timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=31796

inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordListRow.prototype.dispose): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelineRecordGraphRow.prototype._onClick): (WebInspector.TimelineRecordGraphRow.prototype.dispose):
inspector/front-end/inspector.css:

8:15 AM Changeset in webkit [51338] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-24 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Fix DOM storage layout tests
https://bugs.webkit.org/show_bug.cgi?id=31833

The issue is, essentially, that this code assumes that
SecurityOrigin::createString can re-create a SecurityOrigin given
the string produced from SecurityOrigin::toString. This is a bogus
assumption in a number of corner cases (e.g., document.domain,
@sandbox). A recent patch (http://trac.webkit.org/changeset/51294)
make this assumption further invalid in the case of of file:// URLs.

The correct fix is for this code to use WebSecurityOrigin objects
(and not strings) to represent SecurityOrigin objects. However, the
expert on this code is on vacation, and I don't want to do major
surgery here without his involvement. This patch is a temporary fix
to get these tests passing again. We'll do the right fix once
jorlow gets back from vacation.

Tests: Covered by a number of existing DOM storage tests.

src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespaceImpl::createStorageArea):

2:21 AM Changeset in webkit [51337] by mrowe@apple.com

8 edits in trunk

Fix production builds where the source tree may be read-only.

Nov 23, 2009:

8:25 PM Changeset in webkit [51336] by Laszlo Gombos

19 edits in trunk

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

wtf/unicode/UTF8.cpp:
wtf/unicode/glib/UnicodeGLib.cpp:
wtf/unicode/wince/UnicodeWince.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

GEN_DOMObject.cpp:
WebScriptObject.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

WebKitSupport/DragClientWx.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

No new tests as there is no new functionality.

platform/graphics/win/IntPointWin.cpp:
platform/graphics/win/IntRectWin.cpp:
platform/graphics/win/IntSizeWin.cpp:
platform/network/chromium/ResourceRequest.cpp:
platform/win/PlatformMouseEventWin.cpp:

2009-11-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792

DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
DumpRenderTree/qt/jsobjects.cpp:
DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

6:33 PM Changeset in webkit [51335] by jianli@chromium.org

5 edits in trunk

WebCore: * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

platform/graphics/GraphicsContext3D.h:

Reviewed by NOBODY (Chromium build fix).

WebKit/chromium: * src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::createShader):

Reviewed by NOBODY (Chromium build fix).

6:30 PM Changeset in webkit [51334] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

Streamlined some Math functions where we expect or know the result not
to be representable as an int.

Reviewed by Oliver Hunt.

SunSpider says 0.6% faster.

runtime/JSNumberCell.h:

(JSC::JSValue::JSValue):

runtime/JSValue.h:

(JSC::JSValue::):
(JSC::jsDoubleNumber):
(JSC::JSValue::JSValue): Added a function for making a numeric JSValue
and skipping the "can I encode this as an int?" check, avoiding the
overhead of int <-> double roundtripping and double <-> double comparison
and branching.

runtime/MathObject.cpp:

(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan): For these functions, which we expect or know
to produce results not representable as ints, call jsDoubleNumber instead
of jsNumber.

6:24 PM Changeset in webkit [51333] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Unreviewed. Unbreak the regression tests after r51329.

API/JSBase.cpp:

(JSEvaluateScript): Null-check clientData before dereferencing it.

API/JSObjectRef.cpp:

(JSObjectCallAsFunction): Ditto.

5:31 PM Changeset in webkit [51332] by bweinstein@apple.com

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Add exported functions to fix the Windows build.

5:07 PM Changeset in webkit [51331] by agolden@apple.com

4 edits in trunk/WebCore

Prevent ResourceHandleMac's version of ResourceHandle::receivedCredential from stripping
identity and certificate information from a WebCore::Credential when receivedCredential
needs to modify the credential's persistence.

Reviewed by Alexey Proskuryakov.

4:55 PM Changeset in webkit [51330] by barraclough@apple.com

10 edits in trunk/WebCore

Part 2/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world

Reviewed by Geoff Garen.

Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
and for this to automagically cause execution to take place in the world associated with the
global object associated with the ExecState (JSContextRef) passed. However this is not how
things work - the world must be explicitly set within WebCore.

Making this work just for API calls to evaluate & call will be a far from perfect solution,
since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
A better solution would be to make this all work automagically all throughout WebCore, but this
will require more refactoring.

Add references from the JSDOMWindowShell and the JSDOMGlobalObject to the world that owns them,
so that we can get to the world from the lexical global object of an ExecState. In the long-term
we should switch over to using this approach for all cases we want to get a world from an exec state.

bindings/js/JSDOMBinding.cpp:

(WebCore::WebCoreJSClientData::beginningExecution):
(WebCore::WebCoreJSClientData::completedExecution):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::world):
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):

bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::JSDOMWindowShell):

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::world):

bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::JSWorkerContextBase):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):

4:54 PM Changeset in webkit [51329] by barraclough@apple.com

6 edits in trunk/JavaScriptCore

Part 1/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world

Reviewed by Geoff Garen.

Since the API is in JSC but worlds only exist in WebCore, add callbacks on the JSGlobalData::ClientData
to allow it to update the current world on entry/exit via the JSC API. This is temporary duck
tape, and should be removed once the current world no longer needs to be explicitly tracked.

API/JSBase.cpp:

(JSEvaluateScript):

API/JSObjectRef.cpp:

(JSObjectCallAsFunction):

JavaScriptCore.exp:
runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::ClientData::beginningExecution):
(JSC::JSGlobalData::ClientData::completedExecution):

runtime/JSGlobalData.h:

4:35 PM Changeset in webkit [51328] by cmarrin@apple.com

1 edit in trunk/WebCore/html/canvas/WebGLRenderingContext.cpp

Forgot one file for https://bugs.webkit.org/show_bug.cgi?id=31239

4:33 PM Changeset in webkit [51327] by cmarrin@apple.com

15 edits
4 adds in trunk

Add range checks to rendering calls in WebGL
https://bugs.webkit.org/show_bug.cgi?id=31239

I am now tracking the size of the data in each CanvasBuffer object
and keeping track of the buffer size of each active vertex attrib.
In drawArrays and drawElements I make sure no attempt is made to
access elements outside the valid buffer ranges. The test at:

http://cs.helsinki.fi/u/ilmarihe/c3d/functions/drawArraysOutOfBounds.html

no longer crashes.

I also added all the WebGL enumerations to GraphicsContext3D to use them in the validation checks

4:30 PM Changeset in webkit [51326] by arv@chromium.org

6 edits
10 adds in trunk

2009-11-23 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

JSC bindings for HasIndexGetter generates incorrect code (affects
MediaList and CSSStyleDeclaration).
This cleans up the edge cases for indexing out of range for style and
computed style objects to return an empty string according to the spec.
MediaList now returns null when indexed out of range.
https://bugs.webkit.org/show_bug.cgi?id=31683

fast/dom/CSSStyleDeclaration/css-computed-style-item-expected.txt: Added.
fast/dom/CSSStyleDeclaration/css-computed-style-item.html: Added.
fast/dom/CSSStyleDeclaration/css-style-item-expected.txt: Added.
fast/dom/CSSStyleDeclaration/css-style-item.html: Added.
fast/dom/CSSStyleDeclaration/script-tests/css-computed-style-item.js: Added.
fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js: Added.
fast/dom/StyleSheet/css-medialist-item-expected.txt: Added.
fast/dom/StyleSheet/css-medialist-item.html: Added.
fast/dom/StyleSheet/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/backgrounds/repeat/script-tests/TEMPLATE.html.
fast/dom/StyleSheet/script-tests/css-medialist-item.js: Added.

2009-11-23 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

JSC bindings for HasIndexGetter generates incorrect code (affects
MediaList and CSSStyleDeclaration).
This cleans up the edge cases for indexing out of range for style and
computed style objects to return an empty string according to the spec.
MediaList now returns null when indexed out of range.
https://bugs.webkit.org/show_bug.cgi?id=31683

Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html

fast/dom/CSSStyleDeclaration/css-style-item.html
fast/dom/StyleSheet/css-medialist-item.html

bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then

we do not check the length before calling the item function.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::item):
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::item):
css/CSSStyleDeclaration.idl:

4:16 PM Changeset in webkit [51325] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed. Skip new test added in r51324.

platform/qt/Skipped: Added editing/selection/trransformed-selection-rects.html

3:30 PM Changeset in webkit [51324] by Simon Fraser

15 edits
4 adds in trunk

2009-11-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

DocumentMarkers need to be educated about transforms
https://bugs.webkit.org/show_bug.cgi?id=31751

Find highlight is incorrect with transforms
<rdar://problem/6358394>

Allow callers to specify that Frame::selectionTextRects() takes transforms into account
when computing the set of rects that encompass a selection. For transformed elemenets, the
selection rect will be the bounding box of the selected content.

Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.

Test: editing/selection/transformed-selection-rects.html

WebCore.base.exp: Frame::selectionTextRects() has a new parameter.

dom/Document.cpp: (WebCore::Document::setRenderedRectForMarker):
dom/Document.h: Pass the marker as a const reference.

dom/Range.h:
dom/Range.cpp: (WebCore::Range::textQuads): Add a new method, textQuads(), which returns a list of quads, respecting transforms.

page/Frame.h:
page/Frame.cpp: (WebCore::Frame::selectionTextRects): Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad method to get quads for ranges, and then take their bounding boxes.

rendering/InlineTextBox.h:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers): (WebCore::InlineTextBox::textPos): (WebCore::InlineTextBox::offsetForPosition):

Pass DocumentMarkers as a const references.
Convert the argument to setRenderedRectForMarker() into absolute coordinates.

rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds):

2:55 PM Changeset in webkit [51323] by eric@webkit.org

1 edit
2 adds in trunk/JavaScriptCore

2009-11-23 Steve Block <steveblock@google.com>

Reviewed by Dmitry Titov.

Adds MainThreadAndroid.cpp with Android-specific WTF threading functions.
https://bugs.webkit.org/show_bug.cgi?id=31807

wtf/android: Added.
wtf/android/MainThreadAndroid.cpp: Added. (WTF::timeoutFired): (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):

2:36 PM Changeset in webkit [51322] by krit@webkit.org

2 edits in trunk/WebCore

2009-11-23 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

[Cairo] support blurred test-shadow
https://bugs.webkit.org/show_bug.cgi?id=31797

Support for blurred text-shadows on Cairo. This patch
reuses the code of blurred box-shadows, introduced in
bug 26102. For a full textshadow support, a filters enabled
build is needed.

platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

2:25 PM Changeset in webkit [51321] by snej@chromium.org

6 edits in trunk/WebCore

Change incorrect calls to the constructor "EventNames()" to the correct accessor
"eventNames()". This saves ~100 AtomicString lookups each time.
https://bugs.webkit.org/show_bug.cgi?id=31811

Reviewed by Geoffrey Garen.

dom/EventNames.h: Make constructor private to prevent this from happening again.
history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): EventNames() --> eventNames()

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity): EventNames() --> eventNames()

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading): EventNames() --> eventNames()
(WebCore::FrameLoader::pageHidden): EventNames() --> eventNames()

page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingUnloadEvents): EventNames() --> eventNames()

2:22 PM Changeset in webkit [51320] by kov@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

Implement new required function to pass test we used to pass. This
change is required since r51294.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):

2:10 PM Changeset in webkit [51319] by agl@chromium.org

2 edits in trunk/WebCore

2009-11-23 Adam Langley <agl@google.com>

Reviewed by Dmitry Titov.

Chromium Linux: Limit the stroke width and mitre limit.

Limit the stroke width and mitre limit that we'll pass into Skia to
avoid overflowing Skia's uint16_t glyph widths.

http://code.google.com/p/chromium/issues/detail?id=28250
https://bugs.webkit.org/show_bug.cgi?id=31747

platform/graphics/skia/PlatformContextSkia.cpp: (scalarBound): (PlatformContextSkia::setupPaintForStroking):

1:57 PM Changeset in webkit [51318] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed. Skip new tests.

platform/qt/Skipped:

1:53 PM Changeset in webkit [51317] by ap@apple.com

3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=31812
WebSocket code uses RefPtr::get() where it shouldn't

No change in funcitonality, just coding style correction.

websockets/WebSocket.cpp: (WebCore::WebSocket::~WebSocket):
websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail):

1:48 PM Changeset in webkit [51316] by eric@webkit.org

4 edits in trunk

2009-11-23 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

platform/qt/Skipped:

2009-11-23 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::dumpHistoryItem):

1:28 PM Changeset in webkit [51315] by ap@apple.com

2 edits in trunk/WebCore

Build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): pacExecutionCallbackMainThread is static, so it can't use member variables directly.

1:00 PM Changeset in webkit [51314] by ap@apple.com

5 edits in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=31748
Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport

platform/network/cf/SocketStreamHandle.h: Removed names from some void* arguments, since they didn't carry useful information.

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): When we need an http-style URL, we actually always need https. (WebCore::SocketStreamHandle::scheduleStreams): Factored out from constructor, since streams only get scheduled after PAC is fetched and executed asynchronously. (WebCore::SocketStreamHandle::copyPACExecutionDescription): Return a description for event source. (WebCore::MainThreadPACCallbackInfo::MainThreadPACCallbackInfo): Forward callback to main thread. (WebCore::SocketStreamHandle::pacExecutionCallback): Ditto. (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): Ditto. To avoid code duplication, we make the call even on Mac. (WebCore::SocketStreamHandle::executePACFileURL): Make an async call to CFNetworkExecuteProxyAutoConfigurationURL. (WebCore::SocketStreamHandle::removePACRunLoopSource): Once PAC execution is done or aborted, we need to get rid of the event source. (WebCore::SocketStreamHandle::chooseProxy): Use stored m_httpsURL.get. (WebCore::SocketStreamHandle::chooseProxyFromArray): Factored out from chooseProxy - the array may come directly from system configuration, or from PAC. (WebCore::SocketStreamHandle::chooseProxy): Tiger version of this function is now completely separate. (WebCore::SocketStreamHandle::~SocketStreamHandle): Run loop source should be destroyed before we get to the destructor. (WebCore::SocketStreamHandle::platformClose): Destroy the run loop source, if PAC execution is still in progress.

12:10 PM Changeset in webkit [51313] by oliver@apple.com

2 edits in trunk/WebCore

Don't leak the CGImage we create when drawing a sub image.

Reviewed by Geoff Garen.

11:12 AM Changeset in webkit [51312] by abarth@webkit.org

3 edits in trunk/WebCore

2009-11-23 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Don't crash when OOM in creating isolated world
https://bugs.webkit.org/show_bug.cgi?id=31805

We need to add some more null checks to avoid crashing. No new tests
because we don't have a good way to test out-of-memory bugs.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId):
bindings/v8/V8Proxy.h:

11:07 AM Changeset in webkit [51311] by bweinstein@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

8:15 AM Changeset in webkit [51310] by krit@webkit.org

28 edits in trunk/WebCore

2009-11-23 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is the implementation of the filterRes attribute. It
helps the SVG developer to set the quality of a filter by
giving the width or height of filter.
This patch also sets the filter resolution to lower values
if a intermediate ImageBuffer size is bigger than the given
maximal size.
The maximal size is set to 5000x5000 by default. This is a
subjectiv decission. Everthing greater than this values gets
sensible slower. Values of 10000x10000 crashed on WebKitGtk.
For mobil devices a maximum size of 100x100 or 200x200 seems
to be reasonable.
The important fact on filter resolution is, that the output
size is still the size given by the <filter> element.

Tests: svg/filters/big-sized-filter-2.svg

svg/filters/big-sized-filter.svg
svg/filters/filterRes.svg

platform/graphics/FloatRect.cpp: (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
platform/graphics/FloatRect.h: (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for calculation.
platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern calculations.
platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
platform/graphics/filters/Filter.h: Add the abbility to change the quality of a filter output. (WebCore::Filter::filterResolution): (WebCore::Filter::setFilterResolution): (WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion as well as the scaledSubRegion. It also searches for the biggest effect size. We have to change the filter resolution, if one intermediate ImageBuffer size doesn't fit in the maximal image size.
platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get the right part of a previous effect result. (WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get the right part of a previous effect result. (WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create a new intermediate ImageBuffer for the result of the current effect.
platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the filter effect. (WebCore::FilterEffect::setScaledSubRegion): (WebCore::FilterEffect::effectBoundaries): The original values of the EffectElement for a second subRegion calculation. (WebCore::FilterEffect::setEffectBoundaries):
platform/graphics/filters/ImageBufferFilter.cpp: (WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
platform/graphics/filters/ImageBufferFilter.h: (WebCore::ImageBufferFilter::maxImageSize): (WebCore::ImageBufferFilter::calculateEffectSubRegion):
platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect intern calculations.
platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect intern calculations.
svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute. (WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current filterResolution.
svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save values to effectBoundaries of the filter effect
svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::shouldProcessFilter): Return signal if a neccessary value is zero. (WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size fits into the maximal image size, modifys scale factors if not and return a bool: fits. (WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to filterResolution (given by FilterElement or calculated on to big image sizes). Set the scale level to SVGFilter. (WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter is wrong.
svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement. (WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides a FilterResolution? (WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal. (WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations. Kernel values are scaled to current filter resolution too.
svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests, scaledSubRegion according to the current filterResolution and get the maximal image size.
svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement. (WebCore::SVGFilter::filterRegion): Use virtual for clarification. (WebCore::SVGFilter::sourceImageRect): Use virtual for clarification. (WebCore::SVGFilter::maxImageSize): Get the maximal image size.

8:05 AM Changeset in webkit [51309] by kdecker@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Adam Roben.

<rdar://problem/7401503>

Added a workaround for plug-ins not drawing immediately.

Plugins/WebBaseNetscapePluginView.mm: Added new constant. (-[WebBaseNetscapePluginView _clearSubstituteImage]): Added. (-[WebBaseNetscapePluginView resumeFromHalt]): Call above new method.

7:27 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

7:17 AM Changeset in webkit [51308] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-11-23 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Updated the QWebElement documentation with links to examples and
external resources.
Fixed the project file for the webelement snippet and tidied up the
markers used for quoting the code.

Api/qwebelement.cpp:
docs/webkitsnippets/webelement/main.cpp: (findAll):
docs/webkitsnippets/webelement/webelement.pro:

7:02 AM QtBackLog edited by zecke@selfish.org

Mention QtPlugin bug (diff)

7:00 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

6:37 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:31 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:25 AM QtWebKitJournal edited by Simon Hausmann

(diff)

5:04 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

5:02 AM Changeset in webkit [51307] by Simon Hausmann

2 edits in trunk/JavaScriptCore

[Symbian] Fix lastIndexOf() for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31773

Patch by Laszlo Gombos <Laszlo Gombos> on 2009-11-23
Reviewed by Kenneth Rohde Christiansen.

Symbian soft floating point library has problems with operators
comparing NaN to numbers. Without a workaround lastIndexOf()
function does not work.

Patch developed by David Leong.

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLastIndexOf):Add an extra test
to check for NaN for Symbian.

4:58 AM Changeset in webkit [51306] by eric@webkit.org

5 edits in trunk

2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.

https://bugs.webkit.org/show_bug.cgi?id=31681

Before using a cached instance, verify that its wrapped QObject is
still alive.

bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getQtInstance):
bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::hashKey):

2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.

https://bugs.webkit.org/show_bug.cgi?id=31681

Added a unit-test to verify that wrapping a QObject with the
same identity as a previously but now dead object works.

tests/qwebframe/tst_qwebframe.cpp:

3:29 AM Changeset in webkit [51305] by steveblock@google.com

2 edits in trunk/JavaScriptCore

Android port lacks implementation of atomicIncrement and atomicDecrement

Nov 22, 2009:

10:21 PM Changeset in webkit [51304] by eric@webkit.org

12 edits
2 adds in trunk

2009-11-22 Chris Fleizach <Chris Fleizach>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762

platform/mac/accessibility/aria-flowto-expected.txt: Added.
platform/mac/accessibility/aria-flowto.html: Added.

2009-11-22 Chris Fleizach <Chris Fleizach>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762

Test: platform/mac/accessibility/aria-flowto.html

accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaOwnsElements): (WebCore::AccessibilityObject::supportsARIAFlowTo): (WebCore::AccessibilityObject::ariaFlowToElements):
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::linkedUIElements): (WebCore::AccessibilityRenderObject::supportsARIAFlowTo): (WebCore::AccessibilityRenderObject::ariaFlowToElements):
accessibility/AccessibilityRenderObject.h:
html/HTMLAttributeNames.in:

2009-11-22 Chris Fleizach <Chris Fleizach>

Reviewed by Oliver Hunt.

ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762

DumpRenderTree/AccessibilityUIElement.cpp: (ariaFlowToElementAtIndexCallback): (AccessibilityUIElement::getJSClass):
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex):
DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaFlowToElementAtIndex):
DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex):

8:27 PM Changeset in webkit [51303] by mitz@apple.com

4 edits in trunk/WebKitLibraries

Updated WebKitSystemInterface.

Reviewed by Eric Carlson.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

7:45 PM Changeset in webkit [51302] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2009-11-22 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Sort source lists and remove obsolete comments
from the build system.

JavaScriptCore.pri:

5:38 PM HighLevelOverview edited by chris.jerdonek@gmail.com

Added information about JavaScriptGlue (diff)

5:33 PM Changeset in webkit [51301] by eric@webkit.org

1 edit
10 adds in trunk/LayoutTests

2009-11-22 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Tests to the filterRes implementation for SVG Filters
https://bugs.webkit.org/show_bug.cgi?id=6021

big-sized-filter: tests if filter quality is scaled down on a too

big SourceImage (SourceGraphic, SourceAlpha)

big-sized-filter-2: tests if the filter quality is scaled down

on a too big filter effect size.

filterRes: Various tests of SVG Filters with different values for

filterRes attributes. Checks

that kernel values (if present) are scaled with the filterRes
subRegion calculation is correct for effects with deeper dependencies.

platform/mac/svg/filters/big-sized-filter-2-expected.txt: Added.
platform/mac/svg/filters/big-sized-filter-expected.checksum: Added.
platform/mac/svg/filters/big-sized-filter-expected.png: Added.
platform/mac/svg/filters/big-sized-filter-expected.txt: Added.
platform/mac/svg/filters/filterRes-expected.checksum: Added.
platform/mac/svg/filters/filterRes-expected.png: Added.
platform/mac/svg/filters/filterRes-expected.txt: Added.
svg/filters/big-sized-filter-2.svg: Added.
svg/filters/big-sized-filter.svg: Added.
svg/filters/filterRes.svg: Added.

5:29 PM Changeset in webkit [51300] by Nikolas Zimmermann

3 edits in trunk/WebCore

Not reviewed. Build fix for WML enabled builds.
Adopt WebCore API changes.

3:14 PM Changeset in webkit [51299] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

[Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
https://bugs.webkit.org/show_bug.cgi?id=31638

Reviewed by Kenneth Christiansen.

Unfreeze WorkQueue after each test execution.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

2:29 PM Changeset in webkit [51298] by eric@webkit.org

5 edits in trunk

2009-11-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
https://bugs.webkit.org/show_bug.cgi?id=31783

Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.

platform/qt/Skipped:

2009-11-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
https://bugs.webkit.org/show_bug.cgi?id=31783

Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::NetworkAccessManager::NetworkAccessManager): (WebCore::NetworkAccessManager::sslErrorsEncountered): (WebCore::WebPage::WebPage):
DumpRenderTree/qt/DumpRenderTree.h:

12:54 PM BuildingQtOnLinux edited by faw217@gmail.com

libxslt is no longer required (diff)

12:05 PM Changeset in webkit [51297] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-11-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce sidebar background on timeline panel in order
to prevent it from flickering on scroll.

https://bugs.webkit.org/show_bug.cgi?id=31789

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._scheduleRefresh):
inspector/front-end/inspector.css:

10:25 AM Changeset in webkit [51296] by pfeldman@chromium.org

9 edits
2 adds in trunk

2009-11-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Reimplement TimelinePanel to make it fast:

Extract grid and overview into separate files
Make timeline create only divs for visible rows

https://bugs.webkit.org/show_bug.cgi?id=31784

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.set calculator):
inspector/front-end/TimelineGrid.js: Added. (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addEventDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
inspector/front-end/TimelineOverviewPane.js: Added. (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked): (WebInspector.TimelineOverviewPane.prototype.update): (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth): (WebInspector.TimelineOverviewPane.prototype.reset): (WebInspector.TimelineOverviewPane.prototype._resizeWindow): (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._windowDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._setWindowPosition): (WebInspector.TimelineOverviewPane.prototype._endWindowDragging): (WebInspector.TimelineOverviewCalculator): (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineOverviewCalculator.prototype.reset): (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries): (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan): (WebInspector.TimelineOverviewCalculator.prototype.formatValue): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.resize): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.prototype._adjustScrollPosition): (WebInspector.TimelineCategory): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:

9:22 AM Changeset in webkit [51295] by abarth@webkit.org

3 edits in trunk

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329

Updates the test to make sure it is disabling universal access for
file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.

fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Disable universal access for file:/// URLs (if API available). Run the real test in an iframe without universal access.

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329

Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.

Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

page/SecurityOrigin.cpp: Deny access to directory listings. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canRequest):

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329

Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.

DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):

9:22 AM Changeset in webkit [51294] by abarth@webkit.org

12 edits
1 copy in trunk

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Updates the test to make sure it is disabling universal access for
file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.

fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Disable universal access for file:/// URLs (if API available). Run the real test in an iframe without universal access.

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.

Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html

page/SecurityOrigin.cpp: Deny access to directory listings. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canRequest):

2009-11-22 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.

DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):
DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs):

7:16 AM Changeset in webkit [51293] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the timeout of fast/frames/frame-navigation.html
https://bugs.webkit.org/show_bug.cgi?id=31638

The test is timeouting, because it uses the WorkQueue to load a document in one
of the child frames and once the loading is finished, the DRT does not dump the
tree. This is because it waits for the QWebFrame::loadFinished() signal from
the main frame, while it should connect to QWebPage::loadFinished().

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

2:04 AM Changeset in webkit [51292] by mitz@apple.com

4 edits in trunk/WebKitLibraries

Fixed a leak in WKDrawMediaUIPart().

Reviewed by Cameron Zwarich.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

Nov 21, 2009:

7:39 PM Changeset in webkit [51291] by Joseph Pecoraro

2 edits in trunk/WebCore

2009-11-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
https://bugs.webkit.org/show_bug.cgi?id=31400

Handle the following when on a Mac:

Ctrl+P = Previous (like Up arrow)
Ctrl+N = Next (like Down arrow)

No longer rerun autocompletion when just pushing a modifier key
like Control, Alt, Shift, or Meta.

Improved arrow key behavior with Multiline code in the Console, with the following behavior:

Up = Previous Command if on First Line (caret moves to the end of the first line)

otherwise default caret movement in text.

Down = Next Command if on Last Line (caret naturally moves to the end)

otherwise default caret movement in text.

inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line (WebInspector.TextPrompt.prototype._upKeyPressed): (WebInspector.TextPrompt.prototype._downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):

7:04 PM Changeset in webkit [51290] by jberlin@webkit.org

2 edits in trunk/WebCore

Adds a tooltip containing the full url of the resource to each element
in the Resources panel so that it is possible to quickly see the query
parameters.
https://bugs.webkit.org/show_bug.cgi?id=19103

Reviewed by Timothy Hatcher.

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.refresh):
Set the tooltip to be the resource's url.

4:18 PM Changeset in webkit [51289] by Simon Fraser

5 edits in trunk

2009-11-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
https://bugs.webkit.org/show_bug.cgi?id=31588

In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
so that findRule() and deleteRule() work with these keywords.

css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::findRuleIndex):

3:13 PM Changeset in webkit [51288] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-21 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
https://bugs.webkit.org/show_bug.cgi?id=31753

wtf/Platform.h:

1:34 PM Changeset in webkit [51287] by eric@webkit.org

8 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool --help spews way too much text
https://bugs.webkit.org/show_bug.cgi?id=31771

Scripts/bugzilla-tool:
- Remove self.cached_scm initialization hack.
Scripts/modules/buildbot.py:
- Make default_host accessible to callers.
Scripts/modules/commands/download.py:
- Phrase help for all commands consistently and remove spurious help text punctuation.
Scripts/modules/commands/queries.py: Ditto.
Scripts/modules/commands/queues.py: Ditto.
Scripts/modules/commands/upload.py: Ditto.
Scripts/modules/multicommandtool.py:
- Add HelpPrintingOptionParser.format_epilog to replace NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
- Make --help only show a list of commands like "svn help" and "git help" do -- previously --help was listing all commands and options.
- Sort list of commands alphabetically.

1:32 PM Changeset in webkit [51286] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>

Windows build fix. Unreviewed.

Interfaces/IWebSerializedJSValue.idl:

1:26 PM Changeset in webkit [51285] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-21 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31647

Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

No functionality was changed. So, no new tests.

dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::~KeyboardEvent):
dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr. (WebCore::KeyboardEvent::keyEvent):

1:12 PM Changeset in webkit [51284] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <eric@webkit.org>

No review. Fixing a typo from the previous patch for bug 31767.

AbstractQueue.run_bugzilla_tool throws an exception
https://bugs.webkit.org/show_bug.cgi?id=31769

Scripts/modules/commands/queues.py:

7:50 AM Changeset in webkit [51283] by eric@webkit.org

5 edits in trunk/WebKitTools

2009-11-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
https://bugs.webkit.org/show_bug.cgi?id=31767

What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.

Scripts/bugzilla-tool:
- Add a path() implementation to expose bugzilla-tool's file path to commit-queue.
Scripts/modules/commands/queues.py:
- Use tool.path() instead of file.
Scripts/modules/multicommandtool.py:
- Add a new path() method to MultiComandTool.
Scripts/modules/multicommandtool_unittest.py:
- Provide a path() method. Little point in testing this mock implementation.

7:37 AM Changeset in webkit [51282] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-21 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.

Scripts/modules/commands/download.py:

7:29 AM Changeset in webkit [51281] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert check-style to use LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31763

Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.

Scripts/modules/commands/download.py:

12:53 AM Web Inspector Update.ja edited by keishi@webkit.org

(diff)

12:52 AM WebKit nightlies support HTML5 noreferrer link relation.ja created by keishi@webkit.org

12:50 AM Web Inspector Update.ja edited by keishi@webkit.org

(diff)

12:48 AM Surfin' Safari Translations edited by keishi@webkit.org

(diff)

Nov 20, 2009:

8:50 PM Changeset in webkit [51280] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

DOMElement::tagName() is unimplemented

https://bugs.webkit.org/show_bug.cgi?id=31746

Reviewed by Darin Adler.

DOMCoreClasses.cpp:

(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.

8:50 PM Changeset in webkit [51279] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

DOMNode::childNodes() is unimplemented

https://bugs.webkit.org/show_bug.cgi?id=31745

Reviewed by Darin Adler.

DOMCoreClasses.cpp:

(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.

8:06 PM Changeset in webkit [51278] by abarth@webkit.org

2 edits
2 copies in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test query commands
https://bugs.webkit.org/show_bug.cgi?id=31755

These tests are pretty rough, but hopefully they'll grow.

Scripts/modules/commands/queries_unittest.py: Added.
Scripts/modules/mock_bugzillatool.py: Added.
Scripts/run-webkit-unittests:

7:53 PM Changeset in webkit [51277] by abarth@webkit.org

6 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
https://bugs.webkit.org/show_bug.cgi?id=31758

Scripts/modules/multicommandtool.py:
- Allow passing of explicit commands to MultiCommandTool.init
Scripts/modules/multicommandtool_unittest.py:
- Use new Command.name naming system.
- Test Command auto-discovery.
Scripts/modules/workqueue.py:
- bug_id no longer exists, use patchbug_id instead.
Scripts/modules/workqueue_unittest.py:
- WorkQueues require names now.
- should_proceed_with_work_item must return a patch object.

7:29 PM Changeset in webkit [51276] by Chris Fleizach

13 edits
2 adds in trunk

WAI-ARIA: add support for aria-owns
https://bugs.webkit.org/show_bug.cgi?id=31702

Reviewed by Beth Dakin.

WebCore:

Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.

Test: platform/mac/accessibility/aria-owns.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsARIAOwns):
(WebCore::AccessibilityObject::ariaOwnsElements):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::supportsARIAOwns):

accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

html/HTMLAttributeNames.in:

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(ariaOwnsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::ariaOwnsElementAtIndex):

LayoutTests:

platform/mac/accessibility/aria-owns-expected.txt: Added.
platform/mac/accessibility/aria-owns.html: Added.

7:14 PM Changeset in webkit [51275] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix exception thrown when running the commit-queue.

Scripts/modules/statusbot.py: patch is optional.
Scripts/modules/workqueue.py: WorkQUeue requires a name.

6:54 PM Changeset in webkit [51274] by hyatt@apple.com

4 edits in trunk/WebKit/win

Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.

Reviewed by Jon Honeycutt.

Fix a typo in serialize() caused when fixing build bustage (put a ! back in).

Interfaces/IWebSerializedJSValue.idl:
WebSerializedJSValue.cpp:

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):

WebSerializedJSValue.h:

6:36 PM Changeset in webkit [51273] by bweinstein@apple.com

7 edits in trunk/WebKit/win

Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.

Reviewed by Dave Hyatt.

Interfaces/IWebSerializedJSValue.idl:
Interfaces/JavaScriptCoreAPITypes.idl:
WebKit.vcproj/Interfaces.vcproj:
WebSerializedJSValue.cpp:

(WebSerializedJSValue::deserialize):

WebSerializedJSValue.h:

6:07 PM Changeset in webkit [51272] by hyatt@apple.com

2 edits in trunk/WebKit/mac

Make sure to export WebSerializedJSValue.

Reviewed by Darin Adler.

WebKit.exp:

5:54 PM Changeset in webkit [51271] by bweinstein@apple.com

5 edits
1 add in trunk/WebKit/win

Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.

Reviewed by Dave Hyatt.

Interfaces/IWebFrameLoadDelegate.idl:
Interfaces/IWebSerializedJSValue.idl:
Interfaces/JavaScriptCoreAPITypes.idl: Added.
Interfaces/WebKit.idl:
WebKit.vcproj/Interfaces.vcproj:

5:44 PM Changeset in webkit [51270] by eric.carlson@apple.com

12 edits in trunk

2009-11-20 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

css/mediaControls.css:

Define closed caption toggle button.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):

Create closed caption toggle button in display order.

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.

2009-11-20 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

2009-11-20 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

Remove closed captions test from skipped list.

platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:

5:34 PM Changeset in webkit [51269] by jianli@chromium.org

3 edits in trunk/WebKit/chromium

Not reviewed. Fix chromium build.

public/WebAccessibilityRole.h:

(WebKit::):

src/AssertMatchingEnums.cpp:

5:18 PM Changeset in webkit [51268] by Joseph Pecoraro

2 edits in trunk/WebCore

2009-11-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Running code in the Console that ends with a
single line comment no longer produces a parse error.

inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn):

5:17 PM Changeset in webkit [51267] by hyatt@apple.com

6 edits
5 adds in trunk/WebKit

Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.

Reviewed by Oliver Hunt and Jon Honeycutt.

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebView/WebSerializedJSValue.h: Added.
WebView/WebSerializedJSValue.mm: Added.

(-[WebSerializedJSValue initWithValue:context:]):
(-[WebSerializedJSValue deserialize:]):
(-[WebSerializedJSValue dealloc]):

WebKit/win:

Interfaces/IWebSerializedJSValue.idl: Added.
Interfaces/WebKit.idl:
WebKit.vcproj/WebKit.vcproj:
WebSerializedJSValue.cpp: Added.

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):

WebSerializedJSValue.h: Added.

5:15 PM Changeset in webkit [51266] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754

Scripts/modules/workqueue.py: Another typo.

5:09 PM Changeset in webkit [51265] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754

Scripts/modules/commands/queues.py: Fix silly typo.

5:02 PM Changeset in webkit [51264] by eric@webkit.org

7 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754

CommitQueueStatus/index.yaml:
- Add indices required for the new queries.
CommitQueueStatus/queue_status.py:
- Add a patch-status page and move update_status to update-status.
- Only display "commit-queue" status records for the commit-queue.
- Add support for a queue_name property on status records.
- Fix _int_from_request to actually work.
CommitQueueStatus/update_status.html:
- Add support for a queue_name on status records.
- Remove unused list of bug ids.
- Scripts/modules/commands/queues.py
  - Make the queues pass the patch instead of the bug_id to StatusBot.
Scripts/modules/statusbot.py:
- Support passing the queue_name to the status updates.
- Support fetching patch status with patch_status().
Scripts/modules/workqueue.py:
- Pass the patch to the StatusBot instead of the bug_id.
- Let WorkQueues have a name.

4:15 PM Changeset in webkit [51263] by abarth@webkit.org

2 edits
7 adds in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move bugzilla-tool commands into their own file
https://bugs.webkit.org/show_bug.cgi?id=31752

This will let us write unit tests.

Scripts/bugzilla-tool:
Scripts/modules/commands/init.py: Added.
Scripts/modules/commands/download.py: Added.
Scripts/modules/commands/queries.py: Added.
Scripts/modules/commands/queues.py: Added.
Scripts/modules/commands/upload.py: Added.
Scripts/modules/grammar.py: Added.

4:00 PM Changeset in webkit [51262] by eric@webkit.org

12 edits in trunk

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706

platform/mac/accessibility/aria-grouping-roles-expected.txt:
platform/mac/accessibility/aria-grouping-roles.html:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706

accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:

2009-11-20 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):

2:54 PM Changeset in webkit [51261] by abarth@webkit.org

1 edit in trunk/WebKitTools/ChangeLog

Fix ChangeLog

2:52 PM Changeset in webkit [51260] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.
Reviewed by Eric Seidel.

BuildQueue should check if the tree is currently buildable
https://bugs.webkit.org/show_bug.cgi?id=31744

Scripts/bugzilla-tool:
Scripts/modules/landingsequence.py:
Scripts/modules/webkitlandingscripts.py:

2:51 PM Changeset in webkit [51259] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move prepare_clean_working_directory into the LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31743

Scripts/bugzilla-tool:
Scripts/modules/landingsequence.py:

2:34 PM Changeset in webkit [51258] by yael.aharon@nokia.com

3 edits in trunk/LayoutTests

Unreviewed fix.

Fix file names in the skipped list, for files added in http://trac.webkit.org/changeset/51257.

1:40 PM Changeset in webkit [51257] by yael.aharon@nokia.com

7 edits
4 adds in trunk

NPN_ReloadPlugins does not reload the page even if reloadPages is true.
https://bugs.webkit.org/show_bug.cgi?id=30460

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
It already refreshes plugins and reloads pages when necessary.

Tests: plugins/reloadplugins-and-pages.html

plugins/reloadplugins-no-pages.html

plugins/PluginInfoStore.cpp:

(WebCore::refreshPlugins):

WebKitTools:

Added code for calling NPN_ReloadPlugins with reloadPages true and false.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginInvoke):

LayoutTests:

Added tests for calling NPN_ReloadPlugins with reloadPages being true and false.

1:32 PM Changeset in webkit [51256] by oliver@apple.com

4 edits in trunk/WebCore

<rdar://7409188> WebKit needs to be able to serialize and deserialize objects.

Reviewed by Dave Hyatt.

Expose WebCore object serialization to WebKit.

1:29 PM Changeset in webkit [51255] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/31741>.
Web Inspector: User Entered Data on the console should show up no matter what filters.

Reviewed by Tim Hatcher.

Always show .console-user-command-result, no matter what the filter say
we should do with the other classes.

inspector/front-end/inspector.css:

1:29 PM Changeset in webkit [51254] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25381
Needs test: jQuery animation crashing Safari

Adding a regression test for a bug that doesn't reproduce in ToT.

fast/dynamic/jQuery-animation-crash-expected.txt: Added.
fast/dynamic/jQuery-animation-crash.html: Added.

1:03 PM Changeset in webkit [51253] by abarth@webkit.org

5 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Pass the port information to the child process
https://bugs.webkit.org/show_bug.cgi?id=31736

We need to do this so the child process knows what to build!

Scripts/bugzilla-tool:
Scripts/modules/landingsequence.py:
Scripts/modules/webkitport.py:
Scripts/modules/webkitport_unittest.py:

12:26 PM Changeset in webkit [51252] by ap@apple.com

2 edits in trunk/LayoutTests

WebSocket tests still don't work on Windows, disabling for futher invesigation.

platform/win/Skipped:

11:55 AM Changeset in webkit [51251] by bweinstein@apple.com

1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Fix a closing tag issue in the vcproj and remove tabs.

11:51 AM Changeset in webkit [51250] by bweinstein@apple.com

7 edits in trunk/WebCore

Fixes <http://webkit.org/b/31700>.
Web Inspector: isMac should be in one central location + Cached.

Reviewed by Tim Hatcher.

We should cache the value of isMac, and make the indexOf call in one
single location, because we are calling it from multiple places, and saving
the result can save us time, and make the call sites simpler.

inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):
(WebInspector.isMac):

11:31 AM Changeset in webkit [51249] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support Qt port in build-queue
https://bugs.webkit.org/show_bug.cgi?id=31733

Scripts/bugzilla-tool:

11:22 AM Changeset in webkit [51248] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a build-queue
https://bugs.webkit.org/show_bug.cgi?id=31725

Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.

Scripts/bugzilla-tool:

11:22 AM Changeset in webkit [51247] by ap@apple.com

2 edits in trunk/LayoutTests

Enabling WebSocket tests on Windows - let's see if they pass after the recent fixes.

platform/win/Skipped:

11:19 AM Changeset in webkit [51246] by Joseph Pecoraro

1 edit
1 delete in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Removed .DS_Store accidentally added in last (r51245).

11:11 AM Changeset in webkit [51245] by Joseph Pecoraro

12 edits
3 adds in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Add Console Only Layout Mode
https://bugs.webkit.org/show_bug.cgi?id=30282

Adds a Console Panel, which allows for a Full size Console. This
extends the Drawer to the size of a Panel. This also fixes previous
resize issues with the Drawer.

inspector/front-end/ConsolePanel.js: added. (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide):
inspector/front-end/Drawer.js: (WebInspector.Drawer): (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console. (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide.animationFinished): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full (WebInspector.Drawer.prototype.enterPanelMode): (WebInspector.Drawer.prototype.exitPanelMode): (WebInspector.Drawer.prototype.immediatelyExitPanelMode): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._animationDuration): (WebInspector.Drawer.prototype._startStatusBarDragging): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):

Miscellaneous changes and cleanup.

English.lproj/localizedStrings.js: "Console" toolbar title.
inspector/front-end/ConsoleView.js: removed unnecessary element reordering
inspector/front-end/Images/consoleIcon.png: added.
inspector/front-end/inspector.css: added icon.
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector._createPanels): create console panel (WebInspector.windowResize): resize drawer if necessary (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode (WebInspector.animateStyle): start animation interval, returns the interval key (WebInspector.toggleAttach): resize drawer if necessary (WebInspector.showConsolePanel): restore the panel when the inspector restarts (WebInspector.showProfileForURL): style fix

Restore the panel when the inspector restarts.

inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):

Build files.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/WebKit.qrc:

11:06 AM Changeset in webkit [51244] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make commit-queue and style-queue show up in help
https://bugs.webkit.org/show_bug.cgi?id=31724

We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.

Scripts/bugzilla-tool:

10:57 AM Changeset in webkit [51243] by eric@webkit.org

4 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement bugzilla-tool build-attachment
https://bugs.webkit.org/show_bug.cgi?id=31722

This command builds an attachment from bugzilla. It leaves the built
patch in the working copy.

Scripts/bugzilla-tool:
Scripts/modules/landingsequence.py:
Scripts/modules/webkitlandingscripts.py:

10:40 AM Changeset in webkit [51242] by bweinstein@apple.com

7 edits in trunk/WebCore

Fixes <http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().

Reviewed by Tim Hatcher.

Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.

inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

inspector/front-end/inspector.js:

(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):

9:53 AM Changeset in webkit [51241] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-11-20 Victor Wang <victorw@chromium.org>

Reviewed by Darin Adler.

Add expected pixel result for layout test input-file-re-render

https://bugs.webkit.org/show_bug.cgi?id=31696

platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
platform/mac/fast/forms/input-file-re-render-expected.png: Added.

9:49 AM Changeset in webkit [51240] by krit@webkit.org

8 edits in trunk/WebCore

2009-11-20 Dirk Schulze <krit@webkit.org>

Unreviewed build fix for filters enabled builds.

platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::applyFilter):
svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

9:45 AM Changeset in webkit [51239] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT release event does not create the state correctly
https://bugs.webkit.org/show_bug.cgi?id=31717

WebKitTools/DumpRenderTree/gtk/EventSender.cpp:

9:27 AM Changeset in webkit [51238] by eric.carlson@apple.com

7 edits in trunk

2009-11-20 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7389945> QTKit based media engine should not claim to support
fullscreen on Leopard

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsFullscreen):

Only return true on SnowLeopard for now.

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

No need to special case MediaFullscreenButtonPart as the default implementation
asks the media engine if it supports fullscreen.

2009-11-20 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7389945> QTKit based media engine should not claim to support fullscreen on Leopard

Update test results.

platform/mac/media/audio-controls-rendering-expected.checksum:
platform/mac/media/audio-controls-rendering-expected.png:
platform/mac/media/audio-controls-rendering-expected.txt:

6:54 AM Changeset in webkit [51237] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

MultiCommandTool should find Command objects automatically instead of with a manual list
https://bugs.webkit.org/show_bug.cgi?id=31710

Scripts/bugzilla-tool:
Scripts/modules/multicommandtool.py:
- Use some wild python-fu to crawl all the known subclasses of Command.

6:45 AM Changeset in webkit [51236] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Added missing import.

Scripts/bugzilla-tool:

6:44 AM Changeset in webkit [51235] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. I failed to update LandingSequence.test
properly.

Scripts/modules/landingsequence.py:

6:21 AM QtWebKitBackportingFixes created by Simon Hausmann

5:47 AM QtWebKitContrib edited by Simon Hausmann

(diff)

4:29 AM QtWebKitJournal edited by Simon Hausmann

(diff)

3:18 AM Changeset in webkit [51234] by Girish Ramakrishnan

4 edits in trunk/WebCore

[Qt] Implement support for rendering plugins on Qt/Mac when a page is used
without a QWebView or when inside QGraphicsWebView.

Reviewed by Simon Hausmann.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and

Girish Ramakrishnan <Girish Ramakrishnan>

Currently, the code provides the cgcontext of the PlatformPluginWidget to
the plugin. This approach does not work when we are printing, or using
QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
of the QPaintDevice's context.

To solve all cases and keep the code simple, we render the plugin to an
offscreen pixmap in all cases. This way, the plugin always renders to the
CGContext of the pixmap and we then use QPainter to blit the pixmap into
the QPaintDevice. We also create a fake window and set it's WindowRef in
NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.

Now, that's the theory. In practice, ATM, mouse events do not work when using
the fake window. So, setPlatformPluginWidget() is still called when using QWebView
so that there are no regressions after this patch. Once we get mouse events
working, setPlatformPluginWidget will be removed.

https://bugs.webkit.org/show_bug.cgi?id=31183

1:01 AM Changeset in webkit [51233] by eric@webkit.org

2 edits
2 adds in trunk/WebKitTools

2009-11-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Create LandingSequence as the all-sing, all-dance landing class
https://bugs.webkit.org/show_bug.cgi?id=31709

Client can inherit from this class to carefully control exactly which
steps they wish to have happen in the landing sequence.

Scripts/bugzilla-tool:
Scripts/modules/landingsequence.py: Added.
Scripts/modules/webkitlandingscripts.py: Added.

Nov 19, 2009:

11:01 PM Changeset in webkit [51232] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
https://bugs.webkit.org/show_bug.cgi?id=31707

This is to help when we implement build-attachment.

Scripts/bugzilla-tool:

10:43 PM Changeset in webkit [51231] by eric@webkit.org

3 edits
2 copies in trunk/WebKitTools

2009-11-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support Qt port in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31701

Now we support building with Qt!

Scripts/bugzilla-tool:
Scripts/modules/webkitport.py: Added.
Scripts/modules/webkitport_unittest.py: Added.
Scripts/run-webkit-unittests:

10:20 PM Changeset in webkit [51230] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-19 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Adam Barth.

Remove inserting stderr into patch in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=29914

Modify SCM python module's run_command function to avoid return of stderr
by default, so stderr won't be inserted into the patches.
Modify the related unit test.

Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:

10:17 PM Changeset in webkit [51229] by Joseph Pecoraro

2 edits in trunk/WebCore

2009-11-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Resync Resources Backend and Frontend
https://bugs.webkit.org/show_bug.cgi?id=31705

inspector/front-end/Resource.js: resync enum values with backend (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases

10:03 PM Changeset in webkit [51228] by eric@webkit.org

4 edits in trunk

2009-11-19 Steve Block <steveblock@google.com>

Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671

wtf/Platform.h: Modified. Added Android-specific configuration.

2009-11-19 Steve Block <steveblock@google.com>

Reviewed by Darin Fisher.

Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671

Build change only. No new tests possible.

config.h: Modified. Added Android-specific configuration.

9:44 PM Changeset in webkit [51227] by rolandsteiner@chromium.org

3 edits
2 adds in trunk

2009-11-20 Roland Steiner <rolandsteiner@chromium.org>

WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)

Reviewed by Darin Adler.

Test: fast/ruby/ruby-text-indent.html

css/html.css: reset text-indent on <ruby> and <rt> elements

LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)

Reviewed by Darin Adler.

fast/ruby/ruby-text-indent-expected.txt: Added.
fast/ruby/ruby-text-indent.html: Added.

6:18 PM Changeset in webkit [51226] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs per-command help
https://bugs.webkit.org/show_bug.cgi?id=31697

Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.

Scripts/modules/multicommandtool.py:
Scripts/modules/multicommandtool_unittest.py:

6:12 PM Changeset in webkit [51225] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.

Reviewed by Darin Adler.

Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

5:09 PM Changeset in webkit [51224] by eric@webkit.org

12 edits in trunk/WebKit/chromium

2009-11-19 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Make chromium/webkit/glue/FormFieldValues use the WebKit API

https://bugs.webkit.org/show_bug.cgi?id=31650

public/WebElement.h:
public/WebFormElement.h:
public/WebInputElement.h: (WebKit::WebInputElement::):
public/WebNode.h:
src/AssertMatchingEnums.cpp:
src/DOMUtilitiesPrivate.cpp: (WebKit::nameOfInputElement):
src/DOMUtilitiesPrivate.h:
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill): (WebKit::EditorClientImpl::doAutofill):
src/WebFormElement.cpp: (WebKit::WebFormElement::name): (WebKit::WebFormElement::method): (WebKit::WebFormElement::getNamedElements): (WebKit::WebFormElement::getInputElements):
src/WebInputElement.cpp: (WebKit::WebInputElement::isEnabledFormControl): (WebKit::WebInputElement::inputType): (WebKit::WebInputElement::formControlType): (WebKit::WebInputElement::value): (WebKit::WebInputElement::dispatchFormControlChangeEvent): (WebKit::WebInputElement::setSelectionRange): (WebKit::WebInputElement::name): (WebKit::WebInputElement::nameForAutofill):
src/WebNode.cpp: (WebKit::WebNode::frame):

4:55 PM Changeset in webkit [51223] by eric@webkit.org

3 edits
2 adds in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move MultiCommandTool and Command into a separate file and add some basic unit tests
https://bugs.webkit.org/show_bug.cgi?id=31695

Scripts/bugzilla-tool:
Scripts/modules/multicommandtool.py: Added.
Scripts/modules/multicommandtool_unittest.py: Added.
Scripts/run-webkit-unittests:

4:53 PM Changeset in webkit [51222] by ap@apple.com

13 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows

WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.

platform/network/ResourceHandle.h: Removed loaderRunLoop().

platform/network/cf/LoaderRunLoopCF.cpp: Added. (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::loaderRunLoop):
platform/network/cf/LoaderRunLoopCF.h: Added. Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because it's needed for more than just resource loading.

platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.

platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.

platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to main thread.
platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of inoperable main run loop.

(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.

4:47 PM Changeset in webkit [51221] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-19 Avi Drissman <avi@chromium.org>

Reviewed by Darin Adler.

Quick style fix.
https://bugs.webkit.org/show_bug.cgi?id=27777

platform/graphics/cg/PDFDocumentImage.cpp:

4:30 PM Changeset in webkit [51220] by bweinstein@apple.com

2 edits
1 delete in trunk/LayoutTests/platform/win/fast/table

Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.

4:25 PM Changeset in webkit [51219] by Beth Dakin

3 edits in trunk/WebCore

Build fix. No review needed.

platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaButton):

4:02 PM Changeset in webkit [51218] by Beth Dakin

2 edits in trunk/WebCore

Build fix. No review needed.

rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

3:58 PM Changeset in webkit [51217] by Beth Dakin

3 edits in trunk/WebCore

Build fix. No review needed.

platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

platform/graphics/qt/StillImageQt.h:

3:53 PM Changeset in webkit [51216] by Beth Dakin

2 edits in trunk/WebCore

Build fix. No review needed.

rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

3:50 PM Changeset in webkit [51215] by Beth Dakin

2 edits in trunk/WebCore

Build fix. No review needed.

plugins/PluginView.cpp:

(WebCore::PluginView::paintMissingPluginIcon):

3:46 PM Changeset in webkit [51214] by Beth Dakin

2 edits in trunk/WebCore

Build fix. No review needed.

platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

3:38 PM Changeset in webkit [51213] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

No review, just adding a FIXME.

Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688

Scripts/bugzilla-tool: Add an extra comment about current design failures.

3:36 PM Changeset in webkit [51212] by Beth Dakin

42 edits
9 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
color-correction work with untagged images

Reviewed by Darin Adler.

Image's draw(), drawPattern(), and fillWithSolidColor() functions
now take a ColorSpace. A bunch of classes inherit from Image, so
draw() and drawPattern() functions there must also take a
ColorSpace.

platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):

platform/graphics/Image.h:
platform/graphics/BitmapImage.h:
platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::draw):
(WebCore::GeneratedImage::drawPattern):

platform/graphics/GeneratedImage.h:
platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

platform/graphics/cg/PDFDocumentImage.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

svg/graphics/SVGImage.h:

All of the drawImage() functions and drawTiled() functions of
GraphicsContext now take a ColorSpace.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):

platform/graphics/GraphicsContext.h:

This is where the actual work is done.

platform/graphics/cg/ImageCG.cpp:

(WebCore::imageWithColorSpace): New static function that returns a
copy of the given image in the given ColorSpace *IF* we should use
the given ColorSpace. We will ignore the color space if the image
is tagged and return 0.
(WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
call imageWithColorSpace().
(WebCore::Image::drawPattern): Same.

Attempt to keep all ports building.

platform/graphics/cairo/ImageCairo.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

platform/graphics/haiku/ImageHaiku.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

platform/graphics/qt/ImageQt.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):

platform/graphics/skia/BitmapImageSingleFrameSkia.h:
platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

platform/graphics/wx/ImageWx.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::drawPattern):

Callers of GraphicsContext's drawImage() and drawTiled() functions
now need to send a ColorSpace.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::apply):

platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::apply):

platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::apply):

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintResizer):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

svg/graphics/SVGPaintServerPattern.cpp:

(WebCore::SVGPaintServerPattern::setup):

svg/graphics/SVGResourceFilter.cpp:

(WebCore::SVGResourceFilter::applyFilter):

svg/graphics/filters/SVGFEMerge.cpp:

(WebCore::FEMerge::apply):

svg/graphics/filters/SVGFEOffset.cpp:

(WebCore::FEOffset::apply):

svg/graphics/filters/SVGFETile.cpp:

(WebCore::FETile::apply):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31321 Make
-webkit-color-correction work with untagged images

Reviewed by Darin Adler.

fast/css/color-correction-on-background-image.html: Added.
fast/css/color-correction-untagged-images.html: Added.
fast/css/resources/purple-noprofile.png: Added.
platform/mac/fast/css/color-correction-on-background-image-expected.checksum: Added.
platform/mac/fast/css/color-correction-on-background-image-expected.png: Added.
platform/mac/fast/css/color-correction-on-background-image-expected.txt: Added.
platform/mac/fast/css/color-correction-untagged-images-expected.checksum: Added.
platform/mac/fast/css/color-correction-untagged-images-expected.png: Added.
platform/mac/fast/css/color-correction-untagged-images-expected.txt: Added.

3:32 PM Changeset in webkit [51211] by dimich@chromium.org

2 edits in trunk/JavaScriptCore

isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
https://bugs.webkit.org/show_bug.cgi?id=31693

Reviewed by David Levin.

wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.

3:30 PM Changeset in webkit [51210] by Michelangelo De Simone

3 edits in trunk/LayoutTests

2009-11-19 Michelangelo De Simone <Michelangelo De Simone>

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>
Files missed when landing patch.

platform/qt/Skipped:
platform/win/Skipped:

3:28 PM Changeset in webkit [51209] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688

Scripts/bugzilla-tool:
- Add new MultiCommandTool class to contain option parsing and help printing logic.
- Rename private methods to use _ pattern.
- MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. -

3:21 PM Changeset in webkit [51208] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Re-factor help printing to use modern python idioms
https://bugs.webkit.org/show_bug.cgi?id=31685

Scripts/bugzilla-tool:

3:12 PM Changeset in webkit [51207] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-19 Avi Drissman <avi@chromium.org>

Reviewed by Darin Adler.

Properly create a CGImageRef on non-PLATFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=27777

platform/graphics/cg/ImageSourceCG.cpp: (WebCore::sharedBufferGetBytesAtPosition): (WebCore::sharedBufferRelease): (WebCore::ImageSource::setData):
platform/graphics/cg/ImageSourceCG.h:
platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged):

2:16 PM Changeset in webkit [51206] by ap@apple.com

2 edits in trunk/LayoutTests

Trying to enable WebSocket tests on Tiger again, as the bot seems to behave now.

platform/mac-tiger/Skipped:

2:04 PM Changeset in webkit [51205] by oliver@apple.com

2 edits
1 add in trunk/WebCore

-webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
https://bugs.webkit.org/show_bug.cgi?id=31656

Reviewed Dave Hyatt

Make sure we're a child of the painting root before drawing overflow features.

1:29 PM Changeset in webkit [51204] by dimich@chromium.org

2 edits in trunk/WebCore

Not reviewed, attempt to fix Chromium build.

rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.

1:02 PM Changeset in webkit [51203] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

commit-queue empty queue logs twice
https://bugs.webkit.org/show_bug.cgi?id=31679

Scripts/bugzilla-tool:

12:28 PM Changeset in webkit [51202] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

bugzilla-tool's reviewer/committer rejection message should be clearer
https://bugs.webkit.org/show_bug.cgi?id=31126

Add more explanatory prose to bugzilla-tool's flag permission rejection message.

Scripts/modules/bugzilla.py:

12:25 PM Changeset in webkit [51201] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Darin Adler.

Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652

fast/lists/ol-start-roman.html: Added.
platform/mac/fast/lists/ol-start-roman-expected.txt: Added.

2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Darin Adler.

Do not assert when a high number is used for roman numerals in lists.
https://bugs.webkit.org/show_bug.cgi?id=31652

Test: fast/lists/ol-start-roman.html

rendering/RenderListMarker.cpp: (WebCore::toRoman): Increase the char array size.

12:14 PM Changeset in webkit [51200] by kov@webkit.org

2 edits in trunk/WebCore

Rubber-stamped by Oliver Hunt.

Add translatable strings to cover validationMessage, after
r51172. Already covered by existing test.

platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

12:12 PM Changeset in webkit [51199] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(STRING_H) guard from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31668

config.h:
runtime/UString.cpp:

11:59 AM Changeset in webkit [51198] by dumi@chromium.org

2 edits in trunk/JavaScriptCore

Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.

Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=31657

wtf/MessageQueue.h:

(WTF::MessageQueue::removeIf):

11:54 AM Changeset in webkit [51197] by eric@webkit.org

9 edits in trunk

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661

JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.

runtime/DatePrototype.cpp: Remove include directive for float.h as it is included in MathExtras.h already.
runtime/Operations.cpp: Ditto.
runtime/UString.cpp: Ditto.
wtf/dtoa.cpp: Ditto.
wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
wtf/Platform.h: Ditto.

2009-11-19 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661

WebCore has a dependency on float.h, there is
no need to guard float.h.

No new tests as there is no functional change.

html/HTMLInputElement.cpp: Remove include directive for float.h as it is included in MathExtras.h already.

11:41 AM Changeset in webkit [51196] by eric@webkit.org

6 edits in trunk

2009-11-19 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Updated timeline paint test to ignore width and height. GTK+ testing
uses a different top level window size than other platforms.

https://bugs.webkit.org/show_bug.cgi?id=31402

inspector/timeline-paint-expected.txt:
inspector/timeline-test.js:
platform/win/Skipped:

2009-11-19 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Forces a WM_PAINT event on calling layoutTestController.display()
in order to enable the timeline-paint.html test on Windows.
::UpdateWindow() does not force an event becaue the window is
not visible.

https://bugs.webkit.org/show_bug.cgi?id=31402

DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView):

11:28 AM Changeset in webkit [51195] by eric@webkit.org

8 edits
2 adds in trunk

2009-11-19 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

WAI-ARIA roles not supported on image map <area>
https://bugs.webkit.org/show_bug.cgi?id=31525

accessibility/aria-used-on-image-maps-expected.txt: Added.
accessibility/aria-used-on-image-maps.html: Added.
platform/gtk/Skipped:
platform/win/Skipped:

11:03 AM Changeset in webkit [51194] by Simon Fraser

2 edits in trunk/WebCore

2009-11-19 Simon Fraser <Simon Fraser>

Reviewed by Pavel Feldman.

Instrumentation should account for painting in compositing layers
https://bugs.webkit.org/show_bug.cgi?id=31674

Add calls to InspectorTimelineAgent for painting into compositing layers,
which is not accounted for in FrameView::paintContents().

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Avoid fetching the FrameView multiple times.

(WebCore::inspectorTimelineAgent):
(WebCore::RenderLayerBacking::paintContents):

10:21 AM Changeset in webkit [51193] by Michelangelo De Simone

2 edits in trunk/WebKitTools

2009-11-19 Michelangelo De Simone <Michelangelo De Simone>

No review needed.

Added myself to committers list.

Scripts/modules/committers.py:

10:16 AM Changeset in webkit [51192] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Bugzilla-tool command classes should match command names
https://bugs.webkit.org/show_bug.cgi?id=31666

I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.

Scripts/bugzilla-tool:

10:14 AM Changeset in webkit [51191] by eric.carlson@apple.com

49 edits
3 adds in trunk

2009-11-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

Test: media/media-captions.html

WebCore.base.exp:
accessibility/AccessibilityMediaControls.cpp: (WebCore::AccessibilityMediaControl::controlTypeName):

Define ShowClosedCaptionsButton and HideClosedCaptionsButton.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

Add MediaToggleClosedCaptionsButtonPart.

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):

Define and match mediaControlsToggleClosedCaptionsButton.

css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

Define and match PseudoMediaControlsToggleClosedCaptions.

css/CSSValueKeywords.in:

Define and use media-toggle-closed-captions-button.

css/mediaControls.css:
css/mediaControlsQuickTime.css:

Add webkit-media-controls-toggle-closed-captions-button.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):

Initialize m_closedCaptionsVisible.

(WebCore::HTMLMediaElement::loadInternal):

Set m_closedCaptionsVisible to false.

(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::closedCaptionsVisible):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):

New, captions internal methods.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
(WebCore::HTMLMediaElement::webkitHasClosedCaptions):

New, captions DOM API.

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:

Declare methods needed for captions API.

platform/ThemeTypes.h:

Add MediaToggleClosedCaptionsButtonPart.

platform/android/LocalizedStringsAndroid.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):

Add empty implmentations.

platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::hasClosedCaptions): (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):

New, empty implementations of media engine closed caption functions.

(WebCore::MediaPlayer::hasClosedCaptions):
(WebCore::MediaPlayer::setClosedCaptionsVisible):

New, call media engine closed caption functions.

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions): (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):

Declare new media engine methods.

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::hasClosedCaptions): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):

New, QTKit implementation of closed caption methods.

platform/gtk/LocalizedStringsGtk.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):

Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.

rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement):

Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):

New, implement the closed caption toggle button,

rendering/MediaControlElements.h:

Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
declare MediaControlToggleClosedCaptionsButtonElement.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): (WebCore::RenderMedia::createToggleClosedCaptionsButton): (WebCore::RenderMedia::createStatusDisplay): (WebCore::RenderMedia::updateControls): (WebCore::RenderMedia::forwardEvent):
rendering/RenderMedia.h:

Deal with m_toggleClosedCaptionsButton.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint):

Deal with MediaToggleClosedCaptionsButtonPart.

rendering/RenderTheme.h:
rendering/RenderThemeMac.h:

Declare paintMediaToggleClosedCaptionsButton.

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):

New.

(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

Don't render captions toggle button unless we are using the new theme, the
movie has captions, and the movie is in a <video> element since we currently
rely on QTKit to render the captions.

rendering/style/RenderStyleConstants.h:

Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.

2009-11-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

media/media-captions-expected.txt: Added.
media/media-captions.html: Added.
media/content/counting-captioned.mov: Added.

platform/gtk/Skipped:
platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:
platform/win/Skipped:

Skipped on platforms that don't support closed captions yet.

2009-11-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

English.lproj/Localizable.strings:

Add strings for toggle captions button.

2009-11-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

Add QTMovieHasClosedCaptions and QTMovieSetShowClosedCaptions.

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaControlElementString:]): (-[WebViewFactory localizedMediaControlElementHelpText:]):

Add accessibility help strings for media controller closed caption button.

2009-11-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText):

Add accessibility help strings for media controller closed caption button.

2009-11-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7035231>
Support closed caption in <video> element

WebKitSystemInterface.h:

Add prototypes for WKQTMovieHasClosedCaptions and WKQTMovieSetShowClosedCaptions,
define WKMediaUIPartToggleClosedCaptionsButton.

10:10 AM Changeset in webkit [51190] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix. Add missing header.

9:43 AM Changeset in webkit [51189] by ap@apple.com

3 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31634
Ignore realm for proxy protection spaces

Only affects WebSocket proxy authentication, cannot be tested in DRT.

platform/network/ProtectionSpace.cpp: (WebCore::operator==):
platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):

9:42 AM Changeset in webkit [51188] by eric@webkit.org

7 edits in trunk

2009-11-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

https://bugs.webkit.org/show_bug.cgi?id=31669

platform/gtk/Skipped:

2009-11-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

https://bugs.webkit.org/show_bug.cgi?id=31669

webkit/webkitwebinspector.cpp: (webkit_web_inspector_show):
webkit/webkitwebinspector.h:

2009-11-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Gustavo Noronha Silva.

Web Inspector: Implement "show inspector" in WebKit GTK
API and enable console tests.

https://bugs.webkit.org/show_bug.cgi?id=31669

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector):

6:23 AM Changeset in webkit [51187] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Minor refactoring + more documentation.

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::clearHistory):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

6:12 AM Changeset in webkit [51186] by eric@webkit.org

2 edits
3 adds in trunk/WebKit/qt

2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add instantiation tests for QWebInspector.

tests/qwebinspector/qwebinspector.pro: Added.
tests/qwebinspector/tst_qwebinspector.cpp: Added. (tst_QWebInspector::attachAndDestroy):
tests/tests.pro:

6:04 AM Changeset in webkit [51185] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-11-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix QWebInspector destruction problem.
https://bugs.webkit.org/show_bug.cgi?id=31664

Api/qwebpage.cpp: (QWebPage::~QWebPage):

5:47 AM Changeset in webkit [51184] by Simon Hausmann

9 edits in trunk

[Qt] Normalize signal and slot signatures.

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2009-11-19
Reviewed by Simon Hausmann.

WebCore:

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):

WebKit/qt:

Api/qgraphicswebview.cpp:

(QGraphicsWebView::setPage):

Api/qwebview.cpp:

(QWebView::setPage):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):

docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

tests/qwebframe/tst_qwebframe.cpp:
tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::modified):
(tst_QWebPage::database):

5:46 AM Changeset in webkit [51183] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Build fix for 32-bit Sparc machines: these machines are big-endian.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2009-11-19
Reviewed by Simon Hausmann.

wtf/Platform.h:

5:03 AM Changeset in webkit [51182] by eric@webkit.org

7 edits in trunk/WebCore

2009-11-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Store cookie domains in the WebInspector object

The cookie domains have been moved from StoragePanel into WebInspector.
Also, the document URLs are now passed inside the WebInspector.addResource()
payload rather than pushed directly from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=31627

inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didFinishLoading):
inspector/InspectorFrontend.cpp:
inspector/InspectorFrontend.h:
inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addCookieDomain):
inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.addCookieDomain): (WebInspector.reset):

4:32 AM Changeset in webkit [51181] by hamaji@chromium.org

5 edits
4 adds
15 deletes in trunk/LayoutTests

2009-11-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Some tests in fast/css-generated-content can be dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=31663

fast/css-generated-content/absolute-position-inside-inline-expected.txt: Added.
fast/css-generated-content/absolute-position-inside-inline.html:
fast/css-generated-content/hit-test-generated-content-expected.txt: Added.
fast/css-generated-content/hit-test-generated-content.html:
fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Added.
fast/css-generated-content/positioned-background-hit-test-crash.html:
fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
fast/css-generated-content/spellingToolTip-assert.html:
platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.checksum: Removed.
platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.png: Removed.
platform/mac/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
platform/mac/fast/css-generated-content/hit-test-generated-content-expected.checksum: Removed.
platform/mac/fast/css-generated-content/hit-test-generated-content-expected.png: Removed.
platform/mac/fast/css-generated-content/hit-test-generated-content-expected.txt: Removed.
platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.checksum: Removed.
platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.png: Removed.
platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.checksum: Removed.
platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.png: Removed.
platform/mac/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.
platform/qt/fast/css-generated-content/absolute-position-inside-inline-expected.txt: Removed.
platform/qt/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt: Removed.
platform/qt/fast/css-generated-content/spellingToolTip-assert-expected.txt: Removed.

2:41 AM Changeset in webkit [51180] by ukai@chromium.org

2 edits in trunk/WebKitTools

2009-11-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Ignore websocket tests when --no-http is specified.
https://bugs.webkit.org/show_bug.cgi?id=31662

Scripts/run-webkit-tests:

1:34 AM Changeset in webkit [51179] by zoltan@webkit.org

10 edits in trunk/WebCore

Allow custom memory allocation control for the other part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31585

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class RegularExpression - instantiated at: WebCore/page/Frame.cpp:415
class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
class Path - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
class FontPlatformData - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class Cursors - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
class NetworkStateNotifier - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71

class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119

platform/graphics/MediaPlayerPrivate.h:
platform/graphics/Path.h:
platform/graphics/qt/FontPlatformData.h:
platform/graphics/transforms/TransformationMatrix.h:
platform/image-decoders/ImageDecoder.h:
platform/network/NetworkStateNotifier.h:
platform/network/ResourceRequestBase.h:
platform/qt/CursorQt.cpp:
platform/text/RegularExpression.h:

12:15 AM Changeset in webkit [51178] by mitz@apple.com

5 edits in trunk/LayoutTests

Update the test fast/overflow/004.html to make it match the test
description and expected results.
https://bugs.webkit.org/show_bug.cgi?id=31455

Patch by Kinuko Yasuda <kinuko@google.com> on 2009-11-19
Reviewed by Dan Bernstein.

fast/overflow/004.html:
platform/mac/fast/overflow/004-expected.checksum:
platform/mac/fast/overflow/004-expected.png:
platform/mac/fast/overflow/004-expected.txt:

Nov 18, 2009:

11:18 PM Changeset in webkit [51177] by Laszlo Gombos

2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r51172.

platform/qt/Localizations.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

10:18 PM Changeset in webkit [51176] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Normalize ' and " in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31655

We decided " is better than ' and we should be consistent.

Scripts/bugzilla-tool:

10:17 PM Changeset in webkit [51175] by mitz@apple.com

4 edits
4 adds in trunk

WebCore: Fixed <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

Tests: fast/layers/clip-rects-transformed-2.html

fast/layers/clip-rects-transformed.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
that is either transformed or composited. During painting and hit
testing, when a transformed or composited layer is hit, it becomes the
new root layer, which ultimately gets passed to calculateRects().
(WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
root layer to calculateRects(), and return the bounding box of the
transformed rectangle.
(WebCore::RenderLayer::selfClipRect): Ditto.

rendering/RenderLayer.h:

LayoutTests: Test for <rdar://problem/7398987> Assertion failure in
RenderLayer::updateClipRects when a plug-in’s enclosing layer is
enclosed by a transformed layer

Reviewed by Simon Fraser.

fast/layers/clip-rects-transformed-2-expected.txt: Added.
fast/layers/clip-rects-transformed-2.html: Added.
fast/layers/clip-rects-transformed-expected.txt: Added.
fast/layers/clip-rects-transformed.html: Added.

10:03 PM Changeset in webkit [51174] by Laszlo Gombos

36 edits
6 deletes in trunk

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

JavaScriptCore.pro:
jsc.pro:
wtf/unicode/qt4/UnicodeQt4.h:

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

Api/qcookiejar.cpp: Removed.
Api/qcookiejar.h: Removed.
Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
Api/qwebframe.cpp: (QWebFrame::load):
Api/qwebframe.h:
Api/qwebkitglobal.h:
Api/qwebnetworkinterface.cpp: Removed.
Api/qwebnetworkinterface.h: Removed.
Api/qwebnetworkinterface_p.h: Removed.
Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::acceptNavigationRequest): (QWebPage::acceptNavigationRequest): (QWebPage::action): (QWebPage::userAgentForUrl):
Api/qwebpage.h:
Api/qwebpage_p.h:
Api/qwebview.cpp: (QWebView::load): (QWebView::event):
Api/qwebview.h:
QtLauncher/main.cpp: (MainWindow::print): (MainWindow::setupUI): (main):
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createPlugin):

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

No new tests as there is no change if compiled with
Qt v4.4 or later version.

WebCore.pro:
dom/XMLTokenizerQt.cpp: (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::startDocument): (WebCore::XMLTokenizer::parseDtd):
platform/graphics/qt/FontQt.cpp:
platform/graphics/qt/FontQt43.cpp: Removed.
platform/graphics/qt/ImageQt.cpp:
platform/network/ResourceHandleInternal.h:
platform/network/qt/QNetworkReplyHandler.cpp:
platform/network/qt/QNetworkReplyHandler.h:
platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::setDefersLoading):
platform/network/qt/ResourceRequest.h:
platform/network/qt/ResourceRequestQt.cpp:
platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::clearData):
platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
platform/text/qt/TextBoundaries.cpp:
platform/text/qt/TextBreakIteratorQt.cpp:
plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/ImageDiff.pro:

9:47 PM Changeset in webkit [51173] by hamaji@chromium.org

2 edits in trunk/WebKitTools

2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

GitTest.test_create_binary_patch fails if /tmp is symlink
https://bugs.webkit.org/show_bug.cgi?id=31536

Scripts/modules/scm_unittest.py:

9:38 PM Changeset in webkit [51172] by tkent@chromium.org

28 edits
3 adds in trunk

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

fast/dom/domListEnumeration-expected.txt: updated with new property
fast/dom/script-tests/domListEnumeration.js: ditto
fast/forms/script-tests/validationMessage.js: Added.
fast/forms/validationMessage-expected.txt: Added.
fast/forms/validationMessage.html: Added.
platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

Test: fast/forms/validationMessage.html

html/HTMLButtonElement.idl: validationMessage attribute
html/HTMLFieldSetElement.idl: validationMessage attribute
html/HTMLFormControlElement.cpp:
html/HTMLFormControlElement.h:
html/HTMLInputElement.idl: validationMessage attribute
html/HTMLSelectElement.idl: validationMessage attribute
html/HTMLTextAreaElement.idl: validationMessage attribute
html/ValidityState.cpp: new method to retrieve pertinent localized text
html/ValidityState.h:
page/mac/WebCoreViewFactory.h:
platform/LocalizedStrings.h:
platform/android/LocalizedStringsAndroid.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/haiku/LocalizedStringsHaiku.cpp:
platform/mac/LocalizedStringsMac.mm:
platform/wx/LocalizedStringsWx.cpp:

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

English.lproj/Localizable.strings: new localizable strings

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

src/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory validationMessageValueMissingText]): (-[WebViewFactory validationMessageTypeMismatchText]): (-[WebViewFactory validationMessagePatternMismatchText]): (-[WebViewFactory validationMessageTooLongText]): (-[WebViewFactory validationMessageRangeUnderflowText]): (-[WebViewFactory validationMessageRangeOverflowText]): (-[WebViewFactory validationMessageStepMismatchText]):

2009-11-18 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.

WebCoreLocalizedStrings.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

9:09 PM Changeset in webkit [51171] by Laszlo Gombos

2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

Fix a typo. Remove the trailing semicolon
from an include directive after r51137.

No new tests as there is no functional change.

platform/qt/QWebPageClient.h:

8:52 PM Changeset in webkit [51170] by Laszlo Gombos

2 edits in trunk/WebCore

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r51159.

Include float.h for DBL_MANT_DIG. Not sure why this
is not a problem for other ports.

html/HTMLInputElement.cpp:

7:15 PM Changeset in webkit [51169] by rolandsteiner@chromium.org

4 edits
2 adds in trunk

WebCore: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Cause of the bug:
1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
4.) this triggers the special handling of child removal in RenderRubyRun that

causes it to destroy itself

5.) On returning from all this the renderer crashes when accessing a member

or virtual function on this now illegal object.

I therefore added a flag that tracks if the ruby run is being destroyed.
If so, avoid doing the special handling in removeChild that caused this.
It's not the most elegant solution, but the easiest to implement without
touching unrelated code. Also, it's self-documenting.

Test: fast/ruby/ruby-remove.html

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::destroy):
(WebCore::RenderRubyRun::removeChild):

rendering/RenderRubyRun.h:

LayoutTests: Bug 31574 - Crashing bug when removing <ruby> element
(https://bugs.webkit.org/show_bug.cgi?id=31574)

Reviewed by Darin Adler.

Layout test to verify it no longer crashes when the <ruby> element
is being removed.

fast/ruby/ruby-remove-expected.txt: Added.
fast/ruby/ruby-remove.html: Added.

7:12 PM Changeset in webkit [51168] by tkent@chromium.org

7 edits in trunk/JavaScriptCore

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
https://bugs.webkit.org/show_bug.cgi?id=31330

Introduce new function createRep(const char*, unsigned) and UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
Fix a bug that dtoa() doesn't update *rve if the input value is NaN or Infinity.

No new tests because this doesn't change the behavior.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/UString.cpp: (JSC::createRep): (JSC::UString::UString): (JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
runtime/UString.h:
wtf/dtoa.cpp: (WTF::dtoa): Fix a bug about rve. (WTF::append): A helper for doubleToStringInJavaScriptFormat(). (WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
wtf/dtoa.h:

6:53 PM Changeset in webkit [51167] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-18 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Adler.

Configuration for Chromium Build Slaves.

https://bugs.webkit.org/show_bug.cgi?id=31442

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

6:46 PM Changeset in webkit [51166] by eric@webkit.org

4 edits in trunk

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643

JavaScriptCore.pro:

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643

No new tests as there is no functional change.

WebCore.pro:

6:38 PM Changeset in webkit [51165] by eric@webkit.org

1 edit
1 add in trunk/WebCore

2009-11-18 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBoundaries for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371

platform/text/wince/TextBoundariesWince.cpp: Added.

6:30 PM Changeset in webkit [51164] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2009-11-18 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Implement TextBreakIterator for WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=27371

platform/text/wince/TextBreakIteratorWince.cpp: Added.

6:15 PM Changeset in webkit [51163] by tkent@chromium.org

5 edits
18 adds in trunk

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Tests for ValidityState.typeMismatch for the following types of INPUT element:

date, datetime, datetime-local, month, time and week

https://bugs.webkit.org/show_bug.cgi?id=31342

fast/forms/ValidityState-typeMismatch-date-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-date.html: Added.
fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-datetime.html: Added.
fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-datetimelocal.html: Added.
fast/forms/ValidityState-typeMismatch-month-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-month.html: Added.
fast/forms/ValidityState-typeMismatch-time-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-time.html: Added.
fast/forms/ValidityState-typeMismatch-week-expected.txt: Added.
fast/forms/ValidityState-typeMismatch-week.html: Added.
fast/forms/script-tests/ValidityState-typeMismatch-date.js: Added.
fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Added.
fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Added.
fast/forms/script-tests/ValidityState-typeMismatch-month.js: Added.
fast/forms/script-tests/ValidityState-typeMismatch-time.js: Added.
fast/forms/script-tests/ValidityState-typeMismatch-week.js: Added.

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add support for ValidityState.typeMismatch for the following INPUT types:

date datetime datetime-local month time week

https://bugs.webkit.org/show_bug.cgi?id=31342

Tests: fast/forms/ValidityState-typeMismatch-date.html

fast/forms/ValidityState-typeMismatch-datetime.html
fast/forms/ValidityState-typeMismatch-datetimelocal.html
fast/forms/ValidityState-typeMismatch-month.html
fast/forms/ValidityState-typeMismatch-time.html
fast/forms/ValidityState-typeMismatch-week.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToISODateTime): Check the type validity of the specified type and string using the ISODateTime class.
html/HTMLInputElement.h:
html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): Check the type validity for date, datetime, datetime-local, month, time and week with HTMLInputElemtn::formStringToISODateTime()

6:13 PM Changeset in webkit [51162] by mjs@apple.com

4 edits in trunk/WebCore

2009-11-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
https://bugs.webkit.org/show_bug.cgi?id=31237

Also speeds up Dromaeo DOM Core tests by 1.31x.

bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^{2) behavior. The subtree
mark bit was no longer effective; instead I changed things so only a node that has no ancestors
with wrappers would do marking; there should be only one in the typical case (the root of the
detached subtree).}
dom/Node.cpp: (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
dom/Node.h: ditto

6:07 PM Changeset in webkit [51161] by Darin Adler

7 edits in trunk/WebCore

Get rid of the redundant strokeType and fillType data members on
a GraphicsContext as well as the FillOrStrokeType enum. Use
null pointers instead.

Reviewed by Sam Weinig.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor): Null out the pattern
and gradient.
(WebCore::GraphicsContext::setFillColor): Ditto.
(WebCore::GraphicsContext::setStrokePattern): Null out the graident.
(WebCore::GraphicsContext::setFillPattern): Ditto.
(WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
(WebCore::GraphicsContext::setFillGradient): Ditto.

platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::setPlatformFill): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::setPlatformStroke): Ditto.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
(WebCore::GraphicsContext::applyFillPattern): Ditto.
(WebCore::calculateDrawingMode): Use fillPattern and strokePattern
to see if there is a pattern instead of fillType and strokeType.
(WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
fillPattern, and strokePattern instead of fillType and strokeType.
(WebCore::GraphicsContext::fillPath): Added FIXME about color space that
is used in the pattern and gradient case probably erroneously. Moved
gradient code inside an if statement. Streamlined pattern code and
use an if statement. No switch any more.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.
(WebCore::GraphicsContext::strokeRect): Ditto.

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
fillGraident instead of a switch statement.
(WebCore::GraphicsContext::strokePath): Ditto.
(WebCore::GraphicsContext::fillRect): Ditto.

platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
(WebCore::GraphicsContext::fillRect): Ditto.

6:01 PM Changeset in webkit [51160] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

workqueue.py results in totally broken commit-queue UI
https://bugs.webkit.org/show_bug.cgi?id=31645

Scripts/bugzilla-tool:
- Remove unneeded use of PatchCollection.
- Grab a new copy of the cq'd patches every run of the queue.

5:48 PM Changeset in webkit [51159] by eric@webkit.org

9 edits
12 adds in trunk

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for ValidityState.stepMismatch.
https://bugs.webkit.org/show_bug.cgi?id=31331

fast/forms/ValidityState-stepMismatch-number-expected.txt: Added.
fast/forms/ValidityState-stepMismatch-number.html: Added.
fast/forms/ValidityState-stepMismatch-range-expected.txt: Added.
fast/forms/ValidityState-stepMismatch-range.html: Added.
fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Added.
fast/forms/ValidityState-stepMismatch-unsupported.html: Added.
fast/forms/input-step-expected.txt: Added.
fast/forms/input-step.html: Added.
fast/forms/script-tests/ValidityState-stepMismatch-number.js: Added.
fast/forms/script-tests/ValidityState-stepMismatch-range.js: Added.
fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Added.
fast/forms/script-tests/input-step.js: Added.

2009-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Support for step attribute and ValidityStae.stepMismatch for
type=number and range. stepMismatch will be false if the
difference between the current value and a multiple of the step
value is very small.

Change the behavior of RenderSlider so that it always has a value
rounded to the step attribute value.

https://bugs.webkit.org/show_bug.cgi?id=31331

Tests: fast/forms/ValidityState-stepMismatch-number.html

fast/forms/ValidityState-stepMismatch-range.html
fast/forms/ValidityState-stepMismatch-unsupported.html
fast/forms/input-step.html

html/HTMLAttributeNames.in: Add "step".
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getStepParameters): (WebCore::HTMLInputElement::getAllowedValueStep):
html/HTMLInputElement.h:
html/HTMLInputElement.idl: Add "step".
html/ValidityState.cpp: (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
html/ValidityState.h:
rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): (WebCore::SliderRange::clampValue):

5:27 PM Changeset in webkit [51158] by dimich@chromium.org

2 edits in trunk/WebCore

Need to ASSERT(isMainThread()) in ThreadShared methods.
https://bugs.webkit.org/show_bug.cgi?id=31637

Reviewed by Darin Adler.

Added ASSERT(IsMainThread()) to all following methods:

platform/TreeShared.h:

(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::~TreeShared):
(WebCore::TreeShared::ref):
(WebCore::TreeShared::deref):
(WebCore::TreeShared::setParent):
(WebCore::TreeShared::parent):

5:00 PM Changeset in webkit [51157] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-18 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Eric Seidel.

Add plugin visibility manual test

https://bugs.webkit.org/show_bug.cgi?id=31542

manual-tests/plugins/windowed.html:
manual-tests/plugins/windowless.html:

4:52 PM Changeset in webkit [51156] by eric@webkit.org

2 edits
1 add in trunk/WebCore

2009-11-18 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Pavel Feldman.

Web Inspector - remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552

Manual test added

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.showScript): (WebInspector.ScriptsPanel.prototype.showResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
manual-tests/inspector/remember-last-script.html: Added.

4:43 PM Changeset in webkit [51155] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
https://bugs.webkit.org/show_bug.cgi?id=31258

Create bounded transparency layers instead of just clipping.

No new tests because this is just a performance improvement.

platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):

4:35 PM Changeset in webkit [51154] by eric@webkit.org

8 edits in trunk

2009-11-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Update expected result after Qt4.6 upgrade.
https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

platform/qt/editing/deleting/5408255-expected.txt:

2009-11-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

WebCore.qrc:
platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap):

2009-11-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Add support for displaying deleteButton.
https://bugs.webkit.org/show_bug.cgi?id=31560

Test: LayoutTests/editing/deleting/5408255.html

Api/qwebsettings.cpp: (graphics):
Api/qwebsettings.h:

4:26 PM Changeset in webkit [51153] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Eric Seidel.

Fix Qt build without JavaScript debugger.

https://bugs.webkit.org/show_bug.cgi?id=31575

page/Console.idl:

4:18 PM Changeset in webkit [51152] by eric@webkit.org

2 edits in trunk/WebKitSite

2009-11-18 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Make 80 patches a formal requirement for reviewership
https://bugs.webkit.org/show_bug.cgi?id=31313
Per discussion on the webkit-reviewers list:
http://lists.webkit.org/mailman/private.cgi/webkit-reviewers/2009-November/000795.html

coding/commit-review-policy.html:

4:05 PM Changeset in webkit [51151] by dbates@webkit.org

3 edits
10 adds in trunk

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Fixes an issue where setting the height of a table row programmatically
(via JavaScript) causes the table to be improperly rendered because the
height of each row in the table is not recalculated with respect to the
CSS height property.

In particular, programmatically setting the height of some table row causes
the rows of that table to be rendered with a height equal to the minimum
height required by the cells in that row, regardless of any specified cell
heights. Instead, when RenderTableSection::recalcCells is called, the height
of each row should be set to the CSS height property just as we do in
RenderTableSection::addChild.

Test: fast/table/row-height-recalc2.html

rendering/RenderTableSection.cpp: (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added. (WebCore::RenderTableSection::addChild): Moved code that set row height into method WebCore::setRowHeightToRowStyleHeightIfNotRelative. (WebCore::RenderTableSection::recalcCells): Modified to call WebCore::setRowHeightToRowStyleHeightIfNotRelative.

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24971
And
<rdar://problem/7138265>

Tests that setting the height of a table row programmatically (via JavaScript)
recalculates the height of the rows in the table.

fast/table/row-height-recalc2.html: Added.
platform/mac/fast/table/row-height-recalc2-expected.checksum: Added.
platform/mac/fast/table/row-height-recalc2-expected.png: Added.
platform/mac/fast/table/row-height-recalc2-expected.txt: Added.
platform/qt/fast/table/row-height-recalc2-expected.checksum: Added.
platform/qt/fast/table/row-height-recalc2-expected.png: Added.
platform/qt/fast/table/row-height-recalc2-expected.txt: Added.
platform/win/fast/table/row-height-recalc2-expected.checksum: Added.
platform/win/fast/table/row-height-recalc2-expected.png: Added.
platform/win/fast/table/row-height-recalc2-expected.txt: Added.

3:57 PM Changeset in webkit [51150] by jparent@chromium.org

2 edits in trunk/LayoutTests

Reduce flakiness in zero-duration-with-non-zero-delay-end.html by
increasing a timeout.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31646

transitions/zero-duration-with-non-zero-delay-end.html:

3:47 PM Changeset in webkit [51149] by zoltan@webkit.org

11 edits in trunk/WebCore

Allow custom memory allocation control for the part of platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31473

Reviewed by Darin Adler.

Inherits the following classes from FastAllocBase because these are
instantiated by 'new':

class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
struct Length - instantiated at WebCore/platform/Length.cpp:103
class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and no need to be copyable:

class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53

platform/ContextMenuItem.h:
platform/DeprecatedPtrList.h:
platform/DeprecatedPtrListImpl.cpp:
platform/Length.h:
platform/PlatformKeyboardEvent.h:
platform/animation/AnimationList.h:
platform/graphics/Color.h:
platform/graphics/FontCache.h:
platform/graphics/GraphicsContextPrivate.h:
platform/graphics/MediaPlayer.cpp:

3:46 PM Changeset in webkit [51148] by eric@webkit.org

10 edits in trunk

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
dom/Document.cpp: (WebCore::Document::setFocusedNode):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31186

Changes associated with renaming RenderTextControl::isUserEdited.

DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited. (DOMHTMLTextAreaElement::isUserEdited): Ditto.

3:44 PM Changeset in webkit [51147] by weinig@apple.com

8 edits
3 deletes in trunk

Make the Mac Geolocation API async.

Reviewed by Anders Carlsson.

WebKit:

WebKit.xcodeproj/project.pbxproj: Remove WebGeolocation.

WebKit/mac:

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::requestGeolocationPermissionForFrame):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
Add WebGeolocationPolicyListener implementation of the new WebGeolocationPolicyListener
protocol and use if to implement requestGeolocationPermissionForFrame using the new async
API.

WebCoreSupport/WebGeolocation.mm: Removed.
WebCoreSupport/WebGeolocationInternal.h: Removed.
WebCoreSupport/WebGeolocationMock.mm: Remove bogus include.
WebCoreSupport/WebGeolocationPrivate.h: Removed.
WebView/WebUIDelegatePrivate.h: Remove requestGeolocationPermission and add

WebGeolocationPolicyListener protocol and decidePolicyForGeolocationRequestFromOrigin delegate
method.

WebKitTools:

Update DRT to use the new async Mac Geolocation API.

DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):

3:36 PM Changeset in webkit [51146] by eric@webkit.org

3 edits
1 delete in trunk/WebCore

2009-11-18 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
https://bugs.webkit.org/show_bug.cgi?id=31499

No new tests, just a build cleanup.

WebCore.gypi:
bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
bindings/v8/custom/V8CustomBinding.h:

3:29 PM Changeset in webkit [51145] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-18 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Add and option to toggle HTML5 datalist support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31599

Scripts/build-webkit:

3:25 PM Changeset in webkit [51144] by Nate Chapin

4 edits in trunk

2009-11-18 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Remove Chromium's unnecessary dependency on wtf's tcmalloc files.

https://bugs.webkit.org/show_bug.cgi?id=31648

JavaScriptCore.gyp/JavaScriptCore.gyp:

3:23 PM Applications using WebKit edited by blythe_yee@apple.com

(diff)

3:18 PM Changeset in webkit [51143] by kevino@webkit.org

15 edits in trunk

Reviewed by Kevin Ollivier.

Enable wx plugin support using the Windows implementation as a base.

https://bugs.webkit.org/show_bug.cgi?id=31636

3:10 PM Changeset in webkit [51142] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-18 Evan Stade <estade@chromium.org>

Reviewed by Darin Fisher.

Menu button shows wrong content in Chromium
https://bugs.webkit.org/show_bug.cgi?id=31448

Make context menu button (VK_APPS) show context menu for node that has
keyboard focus. This affects both the content and the positioning.

src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):

3:02 PM Changeset in webkit [51141] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-18 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Gavin Barraclough.

[Qt] Implement symbol hiding for JSC's JIT functions.

These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
https://bugs.webkit.org/show_bug.cgi?id=30864

jit/JITStubs.cpp:

2:49 PM Changeset in webkit [51140] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

2009-11-18 Andrei Popescu <andreip@google.com>

Reviewed by Dimitri Glazkov.

[Android] Add shared timer and sound utilities to platform/android
https://bugs.webkit.org/show_bug.cgi?id=31584

No new tests required, this is platform specific code.

platform/android/SharedTimerAndroid.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
platform/android/SoundAndroid.cpp: Added. (WebCore::systemBeep):

2:41 PM Changeset in webkit [51139] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Fix profile tree nodes loss after focus / restore actions.

Focusing on a node is currently implemented via nodes reattaching
with some caching involved. It seems that not all code was updated
to handle this scenario correctly.

https://bugs.webkit.org/show_bug.cgi?id=31553

inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._restore): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGridNode.prototype._detach): (WebInspector.DataGridNode.prototype.savePosition): (WebInspector.DataGridNode.prototype.restorePosition):
inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.restore):

2:37 PM Changeset in webkit [51138] by dbates@webkit.org

2 edits in trunk/WebKitSite

2009-11-18 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31610

Adds property "min-width" to #title so that the width of the title
element on each page is at least 790px. In particular, this makes
the page <http://webkit.org/security/security-group-members.html>
consistent, in appearance, to the rest of the site.

css/main.css:

2:33 PM Changeset in webkit [51137] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-18 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPageClient.h needs in some cases QCursor, but it does not
include it
https://bugs.webkit.org/show_bug.cgi?id=31527

No new tests as this is just a coding style fix that affects the
build of some not yet submitted patches (i.e. for bug 30173).

platform/qt/QWebPageClient.h:

2:25 PM Changeset in webkit [51136] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-18 Nicolas Roard <nicolas@roard.com>

Reviewed by Dimitri Glazkov.

InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=31504

inspector/InspectorTimelineAgent.h:Added the guard.

2:08 PM Changeset in webkit [51135] by snej@chromium.org

2 edits in trunk/WebCore

Build fix to my previous checkin, for Windows Chromium

svg/SVGAnimatedProperty.h:

(WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.

2:05 PM Changeset in webkit [51134] by Joseph Pecoraro

5 edits in trunk/WebCore

2009-11-18 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Directly Access <head> Instead of Searching for It
https://bugs.webkit.org/show_bug.cgi?id=31641

Changed old access of the head element (document.getElementsByTagName)
to just use the document.head accessor.

inspector/front-end/FontView.js: (WebInspector.FontView):
inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
inspector/front-end/inspector.js: (windowLoaded):

2:04 PM Changeset in webkit [51133] by weinig@apple.com

3 edits in trunk/WebCore

Fix two Geolocation assertions.

Reviewed by Anders Carlsson.

page/Chrome.cpp:

(WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
is not called from JS.

page/Geolocation.cpp:

(WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
a RefPtr first.

2:02 PM Changeset in webkit [51132] by ap@apple.com

2 edits in trunk/WebCore

Case sensitive file system build fix.

platform/network/Credential.h: It's not WTF, just wtf.

1:54 PM Changeset in webkit [51131] by agolden@apple.com

4 edits in trunk/WebCore

Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
objects and WebCore::Credential objects without losing certificate information.

Reviewed by Alexey Proskuryakov

1:49 PM Changeset in webkit [51130] by darin@chromium.org

5 edits in trunk/WebKit/chromium

2009-11-17 Darin Fisher <darin@chromium.org>

Reviewed by Dmitry Titov.

Minor cleanup in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31616

public/WebFormElement.h: Add missing WEBKIT_API prefix.
public/WebNode.h: Add missing WEBKIT_API prefix.
src/WebFormElement.cpp: (WebKit::WebFormElement::action): Make action getter const.
src/WebNode.cpp: (WebKit::WebNode::frame): Utilize WebFrameImpl::fromFrame.

1:31 PM Changeset in webkit [51129] by oliver@apple.com

2 edits in trunk/LayoutTests

Update expected results of fixed test.

12:46 PM Changeset in webkit [51128] by oliver@apple.com

4 edits in trunk

Interpreter may do an out of range access when throwing an exception in the profiler.
https://bugs.webkit.org/show_bug.cgi?id=31635

Reviewed by Alexey Proskuryakov.

Add bounds check.

12:25 PM Changeset in webkit [51127] by dimich@chromium.org

4 edits in trunk/WebCore

Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
https://bugs.webkit.org/show_bug.cgi?id=31615

Reviewed by Eric Seidel.

dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask):
(WebCore::Document::postTask):

dom/ScriptExecutionContext.cpp:
dom/ScriptExecutionContext.h:

12:09 PM Changeset in webkit [51126] by ap@apple.com

2 edits in trunk/LayoutTests

Disabling WebSocket tests on Tiger back, they still hang.

platform/mac-tiger/Skipped:

11:57 AM Changeset in webkit [51125] by snej@chromium.org

9 edits in trunk/WebCore

Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
by causing the right v8-to-WebCore conversion function to be called for every parameter.
This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
To enforce correctness, I added a mode that disables implicit
String-->AtomicString conversions while compiling the generated bindings.
https://bugs.webkit.org/show_bug.cgi?id=31168

Reviewed by Darin Adler.

bindings/scripts/CodeGeneratorV8.pm: Generate usage of V8Parameter class.
bindings/v8/DerivedSourcesAllInOne.cpp: Enable NO_IMPLICIT_ATOMICSTRING.
bindings/v8/V8Binding.h: Add V8Parameter class.
css/WebKitCSSKeyframesRule.h: Make AtomicString conversions explicit.
dom/Document.idl: Remove obsolete [HintAtomic] annotation.
platform/text/AtomicString.h: Added NO_IMPLICIT_ATOMICSTRING option.
svg/SVGAnimatedTemplate.h: Change some return types to String to avoid implicit conversion.
svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.

11:49 AM Changeset in webkit [51124] by Darin Adler

3 edits in trunk/WebCore

Move FillOrStrokeType out of public header.

Reviewed by Dan Bernstein.

platform/graphics/GraphicsContext.h: Updated copyright date to cover

some years we published Apple changes, sorted forward declarations,
removed FillOrStrokeType enum.

platform/graphics/GraphicsContextPrivate.h: Updated copyright date

to cover some years we published Apple changes, sorted includes,
moved FillOrStrokeType enum here.

11:37 AM Changeset in webkit [51123] by Csaba Osztrogonác

2 edits in trunk/JavaScriptCore

Fix the clobber list of cacheFlush for ARM and Thumb2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=31631

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-18
Reviewed by Darin Adler.

jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

11:23 AM Changeset in webkit [51122] by cmarrin@apple.com

17 edits in trunk

Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
https://bugs.webkit.org/show_bug.cgi?id=31601

These are used to debug accelerated compositing layers. I removed
the platform specific code from GraphicsLayerCA.mm and added calls
to GraphicsLayerClient to get it from the higher levels. The values
now get cached in RenderLayerCompositing and are queried from there
by RenderLayerBacking (which implements the GraphicsLayerClient interface).

10:26 AM Changeset in webkit [51121] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of metrics and properties sidebars'
flickering.

https://bugs.webkit.org/show_bug.cgi?id=31629

inspector/front-end/MetricsSidebarPane.js:
inspector/front-end/PropertiesSidebarPane.js:

10:21 AM Changeset in webkit [51120] by jparent@chromium.org

2 edits in trunk/LayoutTests

Eliminate flakiness in file-URL-with-port-number by removing a setTimeout.
The timeout caused the test to fail about 2% of the time on the Chromium builders.
The timeout exists to catch cases where the iframe does not load, but the test
framework already will handle this (albeit with a longer timeout).

Reviewed by Dmitry Titov.

fast/loader/file-URL-with-port-number.html:

10:12 AM Changeset in webkit [51119] by bweinstein@apple.com

3 edits in trunk/WebCore

Fixes <http://webkit.org/b/31606>.
Web Inspector: Enter/Return key should enter edit mode for Editable Fields.

Reviewed by Pavel Feldman.

This implements Enter starting editing mode in an editable DataGrid. If the
DataGrid is editable and the user hits return, startEditing the first child
of the selected node. Also refactored some editing functions to take an
event target instead of the event itself, because the functions only needed
the target. Lastly, added had return in editing mode stop propogation, because
when enter was hit to confirm text, it would propagate back to the datagrid
and try to start editing again.

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick):
(WebInspector.DataGrid.prototype._startEditing):
(WebInspector.DataGrid.prototype.handleKeyEvent):
(WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
(WebInspector.DataGrid.prototype._mouseDownInDataTable):
(WebInspector.DataGrid.prototype._clickInDataTable):

inspector/front-end/inspector.js:

(WebInspector.startEditing.element.handleKeyEvent):
(WebInspector.startEditing):

9:57 AM Changeset in webkit [51118] by benm@google.com

3 edits
3 adds in trunk

HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
https://bugs.webkit.org/show_bug.cgi?id=31593

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.

LayoutTests:

fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-whitespace.js: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-whitespace-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html: Added.

9:38 AM Changeset in webkit [51117] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Touch InspectorController so that frontend
JS files are deployed on Windows.

inspector/InspectorController.cpp:

9:30 AM Changeset in webkit [51116] by ap@apple.com

2 edits in trunk/LayoutTests

Trying to enable WebSocket tests on Tiger again, now that bug 31603 is fixed.

platform/mac-tiger/Skipped:

9:25 AM Changeset in webkit [51115] by pfeldman@chromium.org

3 edits in trunk

2009-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clone timeline records array instead of
copying reference on invalidate all.

https://bugs.webkit.org/show_bug.cgi?id=31596

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):

8:38 AM Changeset in webkit [51114] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Change the initialization order so that the controllers
will be created before exporting them to the JS DOM window.

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

8:17 AM QtWebKitAPI edited by Simon Hausmann

(diff)

8:16 AM Changeset in webkit [51113] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Fix a code copy and paste error. m_page should be page.

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::createWindow):

8:15 AM QtWebKitAPI edited by Simon Hausmann

(diff)

8:14 AM QtWebKitAPI edited by Simon Hausmann

(diff)

8:05 AM QtWebKitAPI created by Simon Hausmann

7:49 AM QtWebKitContrib edited by Simon Hausmann

(diff)

7:02 AM Changeset in webkit [51112] by Simon Fraser

2 edits in trunk/WebCore

2009-11-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Elements don't drop out of compositing layers when animation ends
https://bugs.webkit.org/show_bug.cgi?id=31613
<rdar://problem/7402913>

Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
are compositing anyway for other reasons. Doing so can cause those layers
to stay in compositing mode even after animations finish, because needsToBeComposited()
continues to return true.

No new tests because it's not possible to determine which elements are in
compositing layers from DRT output.

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):

6:27 AM Changeset in webkit [51111] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Make the QWebElement::render() test pass when pixmaps aren't 32 bit.

Patch by Paul Olav Tvete <paul.tvete@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

5:22 AM Changeset in webkit [51110] by Simon Hausmann

2 edits in trunk/JavaScriptCore

[Qt] Fix detection of linux-g++

Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

Never use "linux-g++*" to check for linux-g++, since this will break embedded
builds which use linux-arm-g++ and friends. Use 'linux*-g++*' to check for any
g++ on linux mkspec.

JavaScriptCore.pri:

5:20 AM Changeset in webkit [51109] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Properly localize documentation strings for the tab-key-cycles-through-elements property.

5:20 AM Changeset in webkit [51108] by kov@webkit.org

4 edits in trunk

Ensure that tabKeyCyclesThroughElements is true by default.

5:19 AM Changeset in webkit [51107] by Simon Hausmann

2 edits in trunk/WebKit/qt

Clarify and simplify the legal section in the overview documentation,
after review with our legal team.

Reviewed by Tor Arne Vestbø.

docs/qtwebkit.qdoc:

4:58 AM Changeset in webkit [51106] by vestbo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] Add QtLauncher support for opening links in the default browser

Reviewed by Simon Hausmann.

This can be triggered by either the context menu or by clicking a link
while holding down the Alt key. Opening a link in a new windows is
triggered by holding down Shift.

QtLauncher/main.cpp:

4:53 AM Changeset in webkit [51105] by Girish Ramakrishnan

3 edits in trunk/WebCore

[Qt] Mac Plugins: Remove null timer

Reviewed by Tor Arne Vestbø.

A null timer was used to send mouse move events. Instead, we now use
move events to send nullEvent. This brings down CPU usage by 20-30%.

https://bugs.webkit.org/show_bug.cgi?id=31624

4:48 AM Changeset in webkit [51104] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] Failing test media/video-document-types.html
https://bugs.webkit.org/show_bug.cgi?id=31352

Match what Mac has been doing since r36001: cancel the main load,
and handle failures caused by 'will be handled by plugin' errors.

Covered by test media/video-document-types.html

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::committedLoad):
(WebKit::FrameLoaderClient::shouldFallBack):

2:29 AM Changeset in webkit [51103] by Simon Hausmann

3 edits
4 adds in trunk

[Qt] WebKit crashes when loading certain SVG images

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-18
Reviewed by Simon Hausmann.

WebCore:

Check if the familly exist before creating the PlatformData from it.

https://bugs.webkit.org/show_bug.cgi?id=29443

Test: svg/text/text-font-invalid.html

platform/graphics/qt/FontFallbackListQt.cpp:

(WebCore::FontFallbackList::fontDataAt):

LayoutTests:

Added a test for a crash of QtWebkit when loading SVG images.

https://bugs.webkit.org/show_bug.cgi?id=29443

svg/text/resources/text-font-invalid.svg: Added.
svg/text/text-font-invalid-expected.txt: Added.
svg/text/text-font-invalid.html: Added.

Nov 17, 2009:

10:51 PM Changeset in webkit [51102] by darin@chromium.org

2 edits in trunk/WebCore

2009-11-17 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
after navigation.
https://bugs.webkit.org/show_bug.cgi?id=31609

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal): Set parent for external dropdowns, so that |PopupListBox::hidePopup()| can successfully notify its parent's client.

9:19 PM Changeset in webkit [51101] by tkent@chromium.org

4 edits
3 adds in trunk

2009-11-17 Hayato Ito <hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
https://bugs.webkit.org/show_bug.cgi?id=30651

fast/parser/block-nesting-cap-table-expected.txt: Added.
fast/parser/block-nesting-cap-table.html: Added.
fast/parser/script-tests/block-nesting-cap-table.js: Added.

2009-11-17 Hayato Ito <hayato@google.com>

Reviewed by Darin Adler.

Avoid infinite mutual recursion when deeply nested tags are loaded
https://bugs.webkit.org/show_bug.cgi?id=30651

Test: fast/parser/block-nesting-cap-table.html

html/HTMLParser.cpp: (WebCore::HTMLParser::parseToken): (WebCore::tagPriorityOfNode): (WebCore::HTMLParser::limitBlockDepth): (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth): (WebCore::HTMLParser::insertNode):
html/HTMLParser.h:

8:18 PM Changeset in webkit [51100] by jhoneycutt@apple.com

2 edits in trunk/JavaScriptCore

Add JSContextRefPrivate.h to list of copied files.

Reviewed by Mark Rowe.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

5:12 PM Changeset in webkit [51099] by mrowe@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X

Reviewed by Alexey Proskuryakov.

pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.

This prevents symlinks from confusing the descendant check.

5:08 PM Changeset in webkit [51098] by bfulgham@webkit.org

2 edits in trunk/WebCore

Rubber-stamped by Alexey Proskuryakov.

Final clean-ups for minor coding standard violations.
https://bugs.webkit.org/show_bug.cgi?id=26102.

platform/graphics/cairo/GraphicsContextCairo.cpp:

4:35 PM Changeset in webkit [51097] by dimich@chromium.org

5 edits
2 adds in trunk

WebCore: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

dom/ScriptElement.cpp:

(WebCore::ScriptElementData::shouldExecuteAsJavaScript):

LayoutTests: In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
Change the original test to pure js test, and test the situation about script tags which have text or language attribute.
https://bugs.webkit.org/show_bug.cgi?id=31567

Patch by Johnny Ding <jnd@chromium.org> on 2009-11-17
Reviewed by Darin Adler.

fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html:
fast/dom/HTMLScriptElement/script-tests: Added.
fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Added.

(ScriptForAttributeExecute):

4:31 PM Changeset in webkit [51096] by mrowe@apple.com

3 edits
2 adds in trunk

<http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run

Reviewed by Alexey Proskuryakov.

WebKitTools:

If the WebSocket server fails to start have DRT load an error page in place of tests that require the
server to be up rather than having run-webkit-tests abort immediately.

Scripts/run-webkit-tests:

LayoutTests:

websocket/resources/server-failed-to-start.html: Error page that will be loaded in place of websocket

tests when the server fails to start.

4:24 PM Changeset in webkit [51095] by dimich@chromium.org

2 edits in trunk/WebKit/chromium

Revert r50887, it regressed handling of cmd-left when a text box is focused.
https://bugs.webkit.org/show_bug.cgi?id=31566

Patch by Nicolas Weber <thakis@chromium.org> on 2009-11-17
Reviewed by Darin Fisher, Dmitry Titov.

src/mac/WebInputEventFactory.mm:

(WebKit::WebInputEventFactory::keyboardEvent):

4:08 PM CommitQueue edited by thakis@chromium.org

(diff)

3:38 PM Changeset in webkit [51094] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

Implement DOMHTMLInputElement::replaceCharactersInRange().

https://bugs.webkit.org/show_bug.cgi?id=31492

Reviewed by Dan Bernstein.

DOMHTMLClasses.cpp:

(DOMHTMLInputElement::replaceCharactersInRange):
Get the text of the input field. Replace the given range with the
replacement text, and set this new string as the input element's value.
Select from index to the end of the field. This matches the
implementation in the Obj-C bindings.

3:37 PM Changeset in webkit [51093] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

DOMHTMLOptionElement is missing some functionality.

https://bugs.webkit.org/show_bug.cgi?id=31491

Reviewed by Dan Bernstein.

DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
Cast m_element to an HTMLOptionElement, and call its text() function.
(DOMHTMLOptionElement::label):
Ditto, for label().

3:37 PM Changeset in webkit [51092] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

DOMHTMLSelectElement is missing some implementation.

https://bugs.webkit.org/show_bug.cgi?id=31489

Reviewed by Dan Bernstein.

DOMHTMLClasses.cpp:

(DOMHTMLSelectElement::options):
Cast m_element to an HTMLSelectElement. If it has no options, return
E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
options, and return it.
(DOMHTMLSelectElement::activateItemAtIndex):
If the index is out of bounds, return E_FAIL. Otherwise, select the
item.

3:37 PM Changeset in webkit [51091] by jhoneycutt@apple.com

3 edits in trunk/WebKit/win

DOMHTMLOptionsCollection is missing some implementation.

https://bugs.webkit.org/show_bug.cgi?id=31488

Reviewed by Dan Bernstein.

DOMHTMLClasses.cpp:

(DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
Initialize m_collection.
(DOMHTMLOptionsCollection::createInstance):
Create a DOMHTMLOptionsCollection. If we fail to query for
IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
the result.
(DOMHTMLOptionsCollection::length):
(DOMHTMLOptionsCollection::item):
Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
(DOMHTMLOptionsCollection::namedItem):
Correct the signature of this function.

DOMHTMLClasses.h:

Declare DOMHTMLOptionsCollection::createInstance(). Correct the
signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
member to DOMHTMLOptionsCollection to hold the WebCore object.

3:37 PM Changeset in webkit [51090] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

DOMHTMLInputElement::rectOnScreen() returns the wrong rect

https://bugs.webkit.org/show_bug.cgi?id=31487

Reviewed by Darin Adler.

DOMHTMLClasses.cpp:

(DOMHTMLInputElement::rectOnScreen):
Return the rect on screen, not the rect in the window.

2:07 PM Changeset in webkit [51089] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Pavel Feldman.

Skip inspector tests that are flaky on Windows Release - this is being tracked by:
https://bugs.webkit.org/show_bug.cgi?id=31596.

platform/win/Skipped:

1:40 PM Changeset in webkit [51088] by jparent@chromium.org

4 edits in trunk/LayoutTests

Eliminate flakiness in char-encoding tests by removing setTimeout,
that was working around an old issue.
https://bugs.webkit.org/show_bug.cgi?id=31571

Reviewed by Darin Adler.

fast/encoding/char-encoding-mac.html:
fast/encoding/char-encoding.html:
fast/encoding/resources/char-encoding-utils.js:

1:30 PM Changeset in webkit [51087] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Unreviewed buildbot fix.

Revert part of earlier patch and add comment, as it
was causing timeouts on the buildbot.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::notifyDone):

12:38 PM Changeset in webkit [51086] by eric@webkit.org

3 edits in trunk/JavaScriptCore

2009-11-17 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Adam Barth.

[GTK] Style cleanup for GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=31506

Remove forward declaration in GOwnPtr and do some style cleanup.

wtf/GOwnPtr.cpp:
wtf/GOwnPtr.h: (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::outPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr): (WTF::freeOwnedGPtr):

12:11 PM Changeset in webkit [51085] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-17 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

commit-queue is failing to set reviewer in ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=31592

Scripts/bugzilla-tool: Clarify the "applying" log message.
Scripts/modules/bugzilla.py:
- Add a new _validate_committer_and_reviewer function as a temporary solution until we can make a real Attachment object which knows how to fill in its committer/reviewer fields automatically.

12:05 PM Changeset in webkit [51084] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Make the timeout 15 sec as for the other DRT's and make
it print out the same output when a test timeout.

Reviewed by Oliver Hunt.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):
(LayoutTestController::timerEvent):

11:56 AM Changeset in webkit [51083] by yael.aharon@nokia.com

2 edits in trunk/WebKit/qt

[Qt] QGLLauncher does not support drag&drop of local files
https://bugs.webkit.org/show_bug.cgi?id=31057

Reviewed by Kenneth Rohde Christiansen.

Enable accepting files in QGraphicsWebView.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::dragEnterEvent):

11:33 AM Changeset in webkit [51082] by bfulgham@webkit.org

2 edits in trunk/WebKit/win

Correct build error in Debug_Cairo target after @49705.

Reviewed by NOBODY - Build Fix.

WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib dependency to have proper "_debug" suffix needed by the Debug_Cairo target.

11:27 AM Web Inspector edited by timothy@apple.com

(diff)

11:26 AM WebInspector created by timothy@apple.com

Copied from Web Inspector

11:11 AM Changeset in webkit [51081] by bweinstein@apple.com

1 edit in trunk/WebCore/inspector/InspectorController.cpp

Touch InspectorController to force the Inspector HTML and JS files to be
updated.

10:57 AM Changeset in webkit [51080] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Not reviewed, follow up to r51072: rename skipped entries

platform/qt/Skipped:

10:52 AM Changeset in webkit [51079] by Joseph Pecoraro

2 edits in trunk/WebKitTools

2009-11-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Fixed typos in comments.

Scripts/modules/committers.py:

10:42 AM Changeset in webkit [51078] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Crashing tests after updating to Qt-4.6.0
https://bugs.webkit.org/show_bug.cgi?id=31591

Reviewed by Kenneth Rohde Christiansen.

platform/qt/Skipped: Put tests into skiplist temporarily.

10:37 AM Changeset in webkit [51077] by bweinstein@apple.com

4 edits in trunk/WebKit/win

Touch files to try to fix the build.

Reviewed by NOBODY - Build Fix.

Interfaces/IWebInspector.idl:
Interfaces/WebKit.idl:
WebKit.vcproj/Interfaces.vcproj:

9:55 AM Changeset in webkit [51076] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] better test coverage for ErrorPageExtension
https://bugs.webkit.org/show_bug.cgi?id=31583

Reviewed by Kenneth Christiansen.

Improved the coverage of current ErrorPageExtension tests by
adding autotests involving frameset and iframes.

tests/qwebpage/tst_qwebpage.cpp:

(ErrorPage::extension): Make the ErrorPageExtension
to work for all frames, not only the main frame.
(tst_QWebPage::errorPageExtension): Stop using
the 'frameset.html' resouce in this method since
an autotest specific for frameset's is being added.
(tst_QWebPage::errorPageExtensionInIFrames): Added.
(tst_QWebPage::errorPageExtensionInFrameset): Added.

6:14 AM Changeset in webkit [51075] by pfeldman@chromium.org

1 edit
6 moves
2 adds in trunk/LayoutTests

2009-11-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, tests fix. Follow up to r51072: move
platform-specific results for fast/inspector into
fast/inspector-support.

platform/mac/fast/inspector-support/matchedrules-expected.checksum: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.checksum.
platform/mac/fast/inspector-support/matchedrules-expected.png: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.png.
platform/mac/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/matchedrules-expected.txt.
platform/mac/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/mac/fast/inspector/style-expected.txt.
platform/qt/fast/inspector-support/matchedrules-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/matchedrules-expected.txt.
platform/qt/fast/inspector-support/style-expected.txt: Renamed from LayoutTests/platform/qt/fast/inspector/style-expected.txt.

5:54 AM Changeset in webkit [51074] by kov@webkit.org

2 edits in trunk/LayoutTests

Actually skip the inspector console tests while the problem
discussed in https://bugs.webkit.org/show_bug.cgi?id=31472 is
fixed.

5:38 AM Changeset in webkit [51073] by pfeldman@chromium.org

5 edits in trunk

2009-11-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, build fix. Follow up to r51072: rename skipped entries
for the tests that were moved. Also skipped console tests on GTK
while investigating and touched Interfaces.vcproj to clobber win bot.

platform/gtk/Skipped:
platform/qt/Skipped:

5:11 AM Changeset in webkit [51072] by pfeldman@chromium.org

37 edits
10 moves
2 adds in trunk

2009-11-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make DRT show web inspector for tests in inspector/ folder.

Updated DRT to show/close inspector for all tests under /inspector
Introduced LayoutTestController::setTimelineProfilingEnabled and WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
Removed reload on each inspector test
Renamed fast/inspector to fast/inspector-support in order not to trigger inspector for those.
Reimplemented timeline tests in order to get rid of reload there.
Moved tests that don't require harness into the fast group.

https://bugs.webkit.org/show_bug.cgi?id=31472

WebCore:

WebCore.Inspector.exp:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord):

WebKitTools:

DumpRenderTree/LayoutTestController.cpp: (setTimelineProfilingEnabledCallback): (closeWebInspectorCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTimelineProfilingEnabled):
DumpRenderTree/mac/DumpRenderTree.mm: (shouldOpenWebInspector): (runTest):
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTimelineProfilingEnabled):
DumpRenderTree/win/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTimelineProfilingEnabled):

LayoutTests:

fast/inspector-support/cssURLQuotes-expected.txt: Renamed from LayoutTests/fast/inspector/cssURLQuotes-expected.txt.
fast/inspector-support/cssURLQuotes.html: Renamed from LayoutTests/fast/inspector/cssURLQuotes.html.
fast/inspector-support/matchedrules.html: Renamed from LayoutTests/fast/inspector/matchedrules.html.
fast/inspector-support/style.html: Renamed from LayoutTests/fast/inspector/style.html.
fast/inspector-support/uncaught-dom1-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom1-exception-expected.txt.
fast/inspector-support/uncaught-dom1-exception.html: Renamed from LayoutTests/inspector/uncaught-dom1-exception.html.
fast/inspector-support/uncaught-dom3-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom3-exception-expected.txt.
fast/inspector-support/uncaught-dom3-exception.html: Renamed from LayoutTests/inspector/uncaught-dom3-exception.html.
fast/inspector-support/uncaught-dom8-exception-expected.txt: Renamed from LayoutTests/inspector/uncaught-dom8-exception-expected.txt.
fast/inspector-support/uncaught-dom8-exception.html: Renamed from LayoutTests/inspector/uncaught-dom8-exception.html.
inspector/inspector-test.js: (onload): (evaluateInWebInspector): (notifyDone):
inspector/resources/timeline-iframe-data.html: Added.
inspector/timeline-layout-expected.txt:
inspector/timeline-layout.html:
inspector/timeline-mark-timeline.html:
inspector/timeline-paint.html:
inspector/timeline-parse-html-expected.txt:
inspector/timeline-parse-html.html:
inspector/timeline-recalculate-styles-expected.txt:
inspector/timeline-recalculate-styles.html:
inspector/timeline-script-tag-1-expected.txt:
inspector/timeline-script-tag-1.html:
inspector/timeline-script-tag-2-expected.txt:
inspector/timeline-script-tag-2.html:
inspector/timeline-script-tag-2.js:
inspector/timeline-test.js: (printTimelineRecords): (): (dumpTimelineRecords): (printProps): (frontend_getTimelineResults):

WebKit/mac:

WebInspector/WebInspector.h:
WebInspector/WebInspector.mm: (-isTimelineProfilingEnabled): (-setTimelineProfilingEnabled:):

WebKit/win:

Interfaces/IWebInspector.idl:
WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled): (WebInspector::setTimelineProfilingEnabled):
WebInspector.h:

WebKit/gtk:

webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init): (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):

4:40 AM Changeset in webkit [51071] by benm@google.com

1 edit
4 adds in trunk/WebCore

[Android] Android is missing the implementation of the GeolocationService iface.
https://bugs.webkit.org/show_bug.cgi?id=31554

Patch by Andrei Popescu <andreip@google.com> on 2009-11-17
Reviewed by Dimitri Glazkov.

No new tests required as this is platform specific code.

platform/android/GeolocationServiceAndroid.cpp: Added.

(WebCore::GeolocationServiceAndroid::create):
(WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::startUpdating):
(WebCore::GeolocationServiceAndroid::stopUpdating):
(WebCore::GeolocationServiceAndroid::suspend):
(WebCore::GeolocationServiceAndroid::resume):
(WebCore::GeolocationServiceAndroid::newPositionAvailable):
(WebCore::GeolocationServiceAndroid::newErrorAvailable):
(WebCore::GeolocationServiceAndroid::timerFired):
(WebCore::GeolocationServiceAndroid::isPositionMovement):
(WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
(WebCore::GeolocationServiceAndroid::isPositionMoreTimely):

platform/android/GeolocationServiceAndroid.h: Added.

(WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
(WebCore::GeolocationServiceAndroid::lastPosition):
(WebCore::GeolocationServiceAndroid::lastError):

platform/android/GeolocationServiceBridge.cpp: Added.

(WebCore::):
(WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
(WebCore::GeolocationServiceBridge::start):
(WebCore::GeolocationServiceBridge::stop):
(WebCore::GeolocationServiceBridge::setEnableGps):
(WebCore::GeolocationServiceBridge::newLocationAvailable):
(WebCore::GeolocationServiceBridge::newErrorAvailable):
(WebCore::GeolocationServiceBridge::toGeoposition):
(WebCore::GeolocationServiceBridge::startJavaImplementation):
(WebCore::GeolocationServiceBridge::stopJavaImplementation):

platform/android/GeolocationServiceBridge.h: Added.

1:36 AM Changeset in webkit [51070] by hamaji@chromium.org

7 edits
1 add in trunk/LayoutTests

2009-11-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Fix http tests so that they do not submit a GET form to about:blank.

Original tests expected that submitting an empty form to <about:blank> navigates
the browser to <about:blank?>, not <about:blank>. However, some other browsers
do not act like Safari, and in fact the layout test runner of Chromium was
failing to run these tests.

Prior to this patch, a test that only checks this behavior was added, so now
we can remove the dependency on it from these tests.

Some HTTP tests submit a GET form to about:blank
https://bugs.webkit.org/show_bug.cgi?id=30423

http/tests/navigation/onload-navigation-iframe-2-expected.txt:
http/tests/navigation/onload-navigation-iframe-2.html:
http/tests/navigation/onload-navigation-iframe-expected.txt:
http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
http/tests/navigation/onload-navigation-iframe-timeout.html:
http/tests/navigation/onload-navigation-iframe.html:
http/tests/navigation/resources/blank.txt: Added.

1:27 AM Changeset in webkit [51069] by hamaji@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-11-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Add a test to check the behavior of submitting a GET form to <about:blank>.

Currently Safari redirects the browser to <about:blank?>, while some other
browsers do not (including Firefox and Chromium). The objective of this test is
to express the current behavior of Safari and to become ready to remove
unintentional dependency on it from several tests.

Some HTTP tests submit a GET form to about:blank
https://bugs.webkit.org/show_bug.cgi?id=30423

fast/forms/get-forms-to-about-blank-expected.txt: Added.
fast/forms/get-forms-to-about-blank.html: Added.

12:41 AM Changeset in webkit [51068] by oliver@apple.com

6 edits in trunk

Incorrect use of JavaScriptCore API in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=31577

Reviewed by Maciej Stachowiak

Return undefined rather than a literal null.

Nov 16, 2009:

11:16 PM Changeset in webkit [51067] by zoltan@webkit.org

4 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-16
Reviewed by Gavin Barraclough.

Minor fixes for JSVALUE32_64: branchConvertDoubleToInt32
failed on a CortexA8 CPU, but not on a simulator; and
JITCall.cpp modifications was somehow not committed to mainline.

assembler/ARMAssembler.h:

(JSC::ARMAssembler::fmrs_r):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

10:31 PM Changeset in webkit [51066] by tkent@chromium.org

3 edits in trunk/WebCore

2009-11-16 Kent Tamura <tkent@chromium.org>

Unreviewd build fix.

Fix typo in WebCore.vcproj.
Intlude limits.h for INT_MAX.
Enclose with parenthesis to suspress warning.

WebCore.vcproj/WebCore.vcproj:
html/ISODateTime.cpp: (WebCore::ISODateTime::addDay):

9:50 PM Changeset in webkit [51065] by kevino@webkit.org

6 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Make sure wx scrollbar drawing code factors in transforms when switching backends,
fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.

https://bugs.webkit.org/show_bug.cgi?id=31570

9:39 PM Changeset in webkit [51064] by Girish Ramakrishnan

1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Add myself to commiters.py

9:13 PM Changeset in webkit [51063] by tkent@chromium.org

7 edits
2 adds in trunk/WebCore

2009-11-16 Kent Tamura <tkent@chromium.org>

Reviewed by David Levin.

Introduce WebCore::ISODateTime class.
https://bugs.webkit.org/show_bug.cgi?id=31340

This class represents a value of date/time types of the HTML5 INPUT
element, and has some parsing methods for ISO 8601.

This change has no tests because the class is not used yet.

GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
WebCore.gypi: ditto.
WebCore.pro: ditto.
WebCore.vcproj/WebCore.vcproj: ditto.
WebCore.xcodeproj/project.pbxproj: ditto.
WebCoreSources.bkl: ditto.
html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class. (WebCore::isLeapYear): (WebCore::maxDayOfMonth): (WebCore::dayOfWeek): (WebCore::ISODateTime::maxWeekNumberInYear): (WebCore::countDigits): (WebCore::toInt): (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek(). (WebCore::ISODateTime::addDay): Private helper for parseTimeZone(). (WebCore::ISODateTime::addMinute): ditto. (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime(). (WebCore::ISODateTime::parseMonth): Parser for <input type=month>. (WebCore::ISODateTime::parseDate): Parser for <input type=date>. (WebCore::ISODateTime::parseWeek): Parser for <input type=week>. (WebCore::ISODateTime::parseTime): Parser for <input type=time>. (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>. (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
html/ISODateTime.h: Added. Declare WebCore::ISODateTime class. (WebCore::ISODateTime::ISODateTime): (WebCore::ISODateTime::millisecond): (WebCore::ISODateTime::second): (WebCore::ISODateTime::minute): (WebCore::ISODateTime::hour): (WebCore::ISODateTime::monthDay): (WebCore::ISODateTime::month): (WebCore::ISODateTime::fullYear): (WebCore::ISODateTime::week):

7:05 PM BuildingQtOnLinux edited by dbates@webkit.org

Added missing "libsqlite3-dev" dependency for Ubuntu (diff)

4:09 PM Changeset in webkit [51062] by ap@apple.com

2 edits in trunk/WebCore

Fix a typo in previous commit.

platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.

4:04 PM Changeset in webkit [51061] by ap@apple.com

2 edits in trunk/WebCore

Fix a typo in previous commit.

platform/network/cf/SocketStreamHandleCFNet.cpp:

3:57 PM Changeset in webkit [51060] by ap@apple.com

2 edits in trunk/WebCore

Tiger build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named differently in Tiger CFNetwork.

3:32 PM Changeset in webkit [51059] by ap@apple.com

3 edits in trunk/LayoutTests

Disabling WebSocket tests on Tiger and Windows again, as they still time out.

platform/mac-tiger/Skipped:
platform/win/Skipped:

3:08 PM Changeset in webkit [51058] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-11-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

[KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.

Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.

Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html

platform/KURLGoogle.cpp: (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.

2:58 PM Changeset in webkit [51057] by ap@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Jon Honeycutt.

A better Windows build fix

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Use a macro that inserts declspec(dllimport) when appropriate for CFNetwork imports.

2:57 PM Changeset in webkit [51056] by yael.aharon@nokia.com

5 edits in trunk/WebCore

Rename protocolIsValid to isValidProtocol.
https://bugs.webkit.org/show_bug.cgi?id=31503

Reviewed by Darin Adler.

This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.

No new tests since no new functionality was introduced.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setProtocol):

platform/KURL.cpp:

(WebCore::isValidProtocol):

platform/KURL.h:
platform/KURLGoogle.cpp:

(WebCore::isValidProtocol):

2:41 PM Changeset in webkit [51055] by Chris Fleizach

8 edits
2 adds in trunk

AX: aria-labelledby duplicates some of its WAI-ARIA label
https://bugs.webkit.org/show_bug.cgi?id=31565

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/aria-labelledby-overrides-label.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasTextAlternative):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

accessibility/AccessibilityRenderObject.h:

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(titleUIElementCallback):
(getIsValidCallback):
(AccessibilityUIElement::getJSClass):

LayoutTests:

accessibility/aria-labelledby-overrides-label-expected.txt: Added.
accessibility/aria-labelledby-overrides-label.html: Added.
platform/gtk/Skipped:
platform/win/Skipped:

2:40 PM Changeset in webkit [51054] by Nate Chapin

2 edits in trunk/WebCore

2009-11-16 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Handle the case of a null NPObject* in NPN_SetException in
the V8 bindings. This allow out of process plugins calling
NPN_SetException to just send null instead of sending an
NPObject* that would be an address in a different
process's memory space.

https://bugs.webkit.org/show_bug.cgi?id=31561

bindings/v8/NPV8Object.cpp: (_NPN_SetException): Allow null NPObject* and just throw a general error.

2:30 PM Changeset in webkit [51053] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams): Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.

2:21 PM Changeset in webkit [51052] by yael.aharon@nokia.com

3 edits in trunk/WebCore

[Qt] ASSERT failure while running DRT
https://bugs.webkit.org/show_bug.cgi?id=30978

Reviewed by Kenneth Rohde Christiansen.

Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObjectImp::createStructure):

bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMethod::createStructure):

1:51 PM Changeset in webkit [51051] by mrowe@apple.com

1 edit
1 add in trunk/WebCore

Attempt to fix the build. Land a file that was missing from r51049.

bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.

(WebCore::setWebGLArrayFromArray):

1:31 PM Changeset in webkit [51050] by kenneth@webkit.org

3 edits in trunk/WebKitTools

r50942 broke output from created windows. Make the
m_enableTextOutput a member of the DRT and not the
WebPage.

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::javaScriptAlert):
(WebCore::WebPage::javaScriptConsoleMessage):
(WebCore::WebPage::javaScriptConfirm):
(WebCore::WebPage::javaScriptPrompt):
(WebCore::WebPage::acceptNavigationRequest):
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::createWindow):

DumpRenderTree/qt/DumpRenderTree.h:

(WebCore::DumpRenderTree::setTextOutputEnabled):
(WebCore::DumpRenderTree::isTextOutputEnabled):
(WebCore::WebPage::shouldInterruptJavaScript):
(WebCore::WebPage::isTextOutputEnabled):
(WebCore::WebPage::setViewGeometry):

1:30 PM Changeset in webkit [51049] by cmarrin@apple.com

53 edits in trunk

Update API of WebGLArray and friends
https://bugs.webkit.org/show_bug.cgi?id=31175

1:28 PM Changeset in webkit [51048] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".

1:28 PM Changeset in webkit [51047] by Simon Hausmann

4 edits in trunk/WebKit/qt

API documentation fixes.

Reviewed by Kenneth Rohde Christiansen.

Api/qgraphicswebview.cpp: Removed duplicate docs.
Api/qwebelement.cpp: Added missing docs.
Api/qwebsettings.cpp: Ditto.

1:01 PM Changeset in webkit [51046] by bfulgham@webkit.org

2 edits in trunk/WebCore

Enable support for webkit-box-shadow in Cairo builds.
https://bugs.webkit.org/show_bug.cgi?id=26102.

Reviewed by Oliver Hunt.

Covered by existing fast/box-shadow tests.

platform/graphics/cairo/GraphicsContextCairo.cpp: Add support for fillRect shadows.

12:36 PM Changeset in webkit [51045] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not in WebKitSupportLibrary.

12:05 PM Changeset in webkit [51044] by kenneth@webkit.org

3 edits
4 moves
4 adds in trunk/WebKitTools

Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
as the implementation is being used by at least Qt and Gtk+.

Reviewed by Gustavo Noronha Silva.

Update buildsystems as well.

DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
GNUmakefile.am:

11:08 AM Changeset in webkit [51043] by weinig@apple.com

2 edits in trunk/WebKitSite

Update Security Group Members list.

Reviewed by Anders Carlsson.

security/security-group-members.html:

10:58 AM Changeset in webkit [51042] by weinig@apple.com

2 edits in trunk/WebKitSite

Update Security Group Members list.

Reviewed by Adele Peterson.

security/security-group-members.html:

10:40 AM Changeset in webkit [51041] by ap@apple.com

5 edits in trunk

WebKitTools:
2009-11-16 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Disable wss until all platforms support pyOpenSSL

https://bugs.webkit.org/show_bug.cgi?id=31479

Scripts/run-webkit-tests:

LayoutTests:

Re-enabling WebSocket tests on Tiger and Windows, now that SSL is disabled.

platform/mac-tiger/Skipped:
platform/win/Skipped:

9:59 AM Changeset in webkit [51040] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31494
Add unauthenticated proxy support to SocketStreamHandleCFNet

Cannot be tested in DRT.

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS. (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.

8:54 AM WebKit Team edited by keishi@webkit.org

(diff)

8:51 AM Changeset in webkit [51039] by keishi@webkit.org

1 edit in trunk/WebKitTools/Scripts/modules/committers.py

Adding myself to committers.py.

7:38 AM Changeset in webkit [51038] by tonikitoo@webkit.org

8 edits
2 adds in trunk

[Qt] Broken back/forward after using ErrorPageExtension to set error page
https://bugs.webkit.org/show_bug.cgi?id=30573

Reviewed by Antti Koivisto.

WebCore:

Make FrameLoader::checkLoadCompleteForThisFrame method
to check for any working DocumentLoader instance (through
activeDocumentLoader()) instead of only checking for
'm_provisionalDocumentLoader' in order to decide to if
it is going to reset of not the back and forward history.
after an error page has been loaded.

Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKit/qt:

Implemented autotests for covering the back/forward
reset problem involving error pages.

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::errorPageExtension):

LayoutTests:

Skipped fast/history/back-forward-reset-after-error-handling.html
in mac, gtk and win DRT, because their DRT do not support yet
error pages handling.

fast/history/back-forward-reset-after-error-handling.html:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/win/Skipped:

7:37 AM Changeset in webkit [51037] by tonikitoo@webkit.org

5 edits in trunk/WebKitTools

[Qt] Implement load error pages support for Qt's DRT.
https://bugs.webkit.org/show_bug.cgi?id=31509

Reviewed by Kenneth Christiansen.

For now, it will not be a default feature, and layout tests
that want to make use of this have to explicitily call
'handleErrorPages();' for the test source.

Any of the other DumpRenderTree's (mac, win and gtk)
support handling error pages. Qt's will be the first.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::supportsExtension):
(WebCore::WebPage::extension):

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::reset):

DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::shouldHandleErrorPages):
(LayoutTestController::handleErrorPages):

7:05 AM QtWebKitContrib edited by Simon Hausmann

(diff)

6:59 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:58 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:30 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:26 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:24 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:18 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:12 AM QtWebKit edited by kenneth@webkit.org

(diff)

6:06 AM QtWebKitJournal edited by Simon Hausmann

(diff)

6:05 AM QtWebKit edited by kenneth@webkit.org

(diff)

6:04 AM QtWebKit edited by Simon Hausmann

(diff)

5:59 AM QtWebKitJournal edited by Simon Hausmann

(diff)

5:47 AM Changeset in webkit [51036] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
https://bugs.webkit.org/show_bug.cgi?id=31549

Renamed --commit-queue to --non-interactive in most places
and remove the code in land-patches which is no longer needed.

Scripts/bugzilla-tool:

5:43 AM Changeset in webkit [51035] by kenneth@webkit.org

1 edit
4 adds in trunk/LayoutTests

Rubberstamped by Simon Hausmann.

Added new Qt expected results for animation tests.

platform/qt/animations/change-transform-in-end-event-expected.txt: Added.
platform/qt/animations/state-at-end-event-expected.txt: Added.
platform/qt/animations/state-at-end-event-transform-expected.txt: Added.

5:34 AM Changeset in webkit [51034] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

The commit-queue should use land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31548

Scripts/bugzilla-tool:

5:25 AM Changeset in webkit [51033] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547

Also fixes a bug in workqueue and adds a test!

Scripts/bugzilla-tool:
Scripts/modules/workqueue.py:
Scripts/modules/workqueue_unittest.py:

5:20 AM Changeset in webkit [51032] by Simon Hausmann

3 edits in trunk/JavaScriptCore

Fix Qt build on Windows CE 6.

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-11-16
Reviewed by Simon Hausmann.

JavaScriptCore.pri: Add missing include path.
wtf/Platform.h: Include ce_time.h for Windows CE 6.

5:05 AM Changeset in webkit [51031] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert CommitQueue over to PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31547

Also fixes a bug in workqueue and adds a test!

Scripts/bugzilla-tool:
Scripts/modules/workqueue.py:
Scripts/modules/workqueue_unittest.py:

4:29 AM Changeset in webkit [51030] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move StyleQueue over to using PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31544

That's what the class it's for.

Scripts/bugzilla-tool:
Scripts/modules/patchcollection.py:
Scripts/modules/patchcollection_unittest.py:

4:11 AM Changeset in webkit [51029] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
https://bugs.webkit.org/show_bug.cgi?id=31543

Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.

Scripts/bugzilla-tool:

4:04 AM Changeset in webkit [51028] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Disable the style queue from posting to the commit queue status page.

Scripts/bugzilla-tool:

3:54 AM Changeset in webkit [51027] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

Scripts/modules/patchcollection.py: Added.
Scripts/modules/patchcollection_unittest.py: Added.
Scripts/run-webkit-unittests:

3:47 AM Changeset in webkit [51026] by abarth@webkit.org

2 edits
1 copy
1 add in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31541

This class holds a set of patches and lets clients iterate through
them. Optionally, clients can install a filter.

Scripts/modules/patchcollection.py: Added.
Scripts/modules/patchcollection_unittest.py: Added.
Scripts/run-webkit-unittests:

3:31 AM Changeset in webkit [51025] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool check-style should work with attachment ids instead of bug ids
https://bugs.webkit.org/show_bug.cgi?id=31540

Scripts/bugzilla-tool:

3:04 AM Changeset in webkit [51024] by eric@webkit.org

4 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WorkQueue is the only place that should know about special exit codes
https://bugs.webkit.org/show_bug.cgi?id=31534

Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
and add tests for handling exit codes.
I also cleaned up workqueue_unittest.py more.

Scripts/bugzilla-tool:
Scripts/modules/workqueue.py:
Scripts/modules/workqueue_unittest.py:

3:02 AM Changeset in webkit [51023] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Re-factor workqueue_unittest to allow for more than one test.
https://bugs.webkit.org/show_bug.cgi?id=31535

Scripts/modules/workqueue_unittest.py:

3:00 AM Changeset in webkit [51022] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532

Scripts/bugzilla-tool: fix a couple obvious typos.

2:50 AM Changeset in webkit [51021] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

land-patches needs to be re-factored into smaller chunks
https://bugs.webkit.org/show_bug.cgi?id=31532

The next patch will move these methods into WebKitLandingScripts.

Scripts/bugzilla-tool:
- Split out _land_patch and _close_bug_if_no_active_patches.

2:45 AM Changeset in webkit [51020] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix silly copy-and-paste code. I am a terrible coder.

Scripts/modules/bugzilla.py:

2:34 AM Changeset in webkit [51019] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement a StyleQueue
https://bugs.webkit.org/show_bug.cgi?id=31537

The first iteration of the style queue only produces output locally.
There is also a limit of 10 patches because it's not that useful to
iterate through the entire review queue at this point. We can remove
the limit later.

Scripts/bugzilla-tool:
Scripts/modules/bugzilla.py:

1:25 AM Changeset in webkit [51018] by abarth@webkit.org

5 edits
1 add in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Unit test WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=31531

Adds basic unit testing for WorkQueue. Just runs through one cycle.

Scripts/bugzilla-tool:
Scripts/modules/statusbot.py:
Scripts/modules/workqueue.py:
Scripts/modules/workqueue_unittest.py: Added.
Scripts/run-webkit-unittests:

12:49 AM Changeset in webkit [51017] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=31530

Scripts/bugzilla-tool:

12:39 AM Changeset in webkit [51016] by eric@webkit.org

4 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs apply-attachment
https://bugs.webkit.org/show_bug.cgi?id=31528

Scripts/bugzilla-tool:
- Add ApplyAttachment command.
- Abstract applying code into WebKitApplyingScripts.
- Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
Scripts/modules/bugzilla.py:
- Add fetch_attachment and bug_id_for_attachment_id.
Scripts/modules/bugzilla_unittest.py:
- Add test for new parsing.
- Fix previous parsing test which broke with Adam's check-style patch (bug 31515).

12:38 AM Changeset in webkit [51015] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Document check-style's use of force_clean.

Scripts/bugzilla-tool:
Scripts/modules/scm.py:

12:28 AM Changeset in webkit [51014] by abarth@webkit.org

3 edits
1 add in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move WorkQueue to its own file
https://bugs.webkit.org/show_bug.cgi?id=31529

WorkQueue and WorkQueueDelegate are separate concerns from
bugzilla-tool. Also added a missing include to logging.py.

Scripts/bugzilla-tool:
Scripts/modules/logging.py:
Scripts/modules/workqueue.py:

12:11 AM Changeset in webkit [51013] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Siedel.

Move OutputTee to logging.py.

Scripts/bugzilla-tool:
Scripts/modules/logging.py:

12:07 AM Changeset in webkit [51012] by abarth@webkit.org

2 edits in trunk/WebKitTools

2009-11-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor bugzilla-tool to allow for multiple queues
https://bugs.webkit.org/show_bug.cgi?id=31513

Divide the commit queue class into three class to make creating
additional queues easier.

Scripts/bugzilla-tool:

Nov 15, 2009:

10:19 PM Changeset in webkit [51011] by Chris Fleizach

3 edits in trunk/LayoutTests

Fixing broken layout test.

Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516

Lists are not supported on Leopard or Tiger, so the test for this
bug needs to be skipped.

platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:

10:02 PM Changeset in webkit [51010] by hamaji@chromium.org

3 edits in trunk/WebKitTools

2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

svn-apply may not handle git patches created by bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31457

Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:

8:44 PM Changeset in webkit [51009] by Dimitri Glazkov

2 edits in trunk/WebKit/chromium

2009-11-15 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Correct an error in the previous commit

public/WebAccessibilityRole.h: It should be WebAccessibilityRoleDirectory, not WebAccessibilityDirectoryRole.

7:48 PM Changeset in webkit [51008] by Dimitri Glazkov

3 edits in trunk/WebKit/chromium

2009-11-15 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Bring WebAccessibilityRole up to sync after
http://trac.webkit.org/changeset/51007.

public/WebAccessibilityRole.h: Added WebAccessibilityRoleDirectory.
src/AssertMatchingEnums.cpp: Added a match between DirectoryRole and WebAccessibilityRoleDirectory.

6:05 PM Changeset in webkit [51007] by Chris Fleizach

10 edits
2 adds in trunk

Need to implement ARIA role="directory"
https://bugs.webkit.org/show_bug.cgi?id=31516

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-directory.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isOrderedList):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::createARIARoleMap):

WebKit/mac:

Fix a spelling error in the comment of a localized (accessibility) string.

WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

LayoutTests:

platform/mac/accessibility/aria-directory-expected.txt: Added.
platform/mac/accessibility/aria-directory.html: Added.

3:34 PM Changeset in webkit [51006] by abarth@webkit.org

2 edits in trunk/WebCore

2009-11-15 Dave Tapuska <dtapuska@rim.com>

Reviewed by George Staikos.

Compare UChars single unit at a time as opposed to the uint32_t
approach as casting to unaligned addresses may cause a bus failure
on ARMv5 and below. This change replicates the same defines that
exists in AtomicString.cpp

https://bugs.webkit.org/show_bug.cgi?id=31475

platform/text/StringHash.h: (WebCore::StringHash::equal):

3:32 PM Changeset in webkit [51005] by abarth@webkit.org

3 edits in trunk/WebKitTools

2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

bugzilla-tool should post git binary diff
https://bugs.webkit.org/show_bug.cgi?id=31458

Add --binary option to Git.create_patch.

Scripts/modules/scm.py:
Scripts/modules/scm_unittest.py:

3:29 PM Changeset in webkit [51004] by abarth@webkit.org

2 edits in trunk/WebCore

2009-11-15 Evan Martin <evan@chromium.org>

Reviewed by Adam Barth.

Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.

https://bugs.webkit.org/show_bug.cgi?id=31490

bindings/v8/V8DOMWrapper.cpp:

3:28 PM Changeset in webkit [51003] by abarth@webkit.org

2 edits in trunk/WebCore

2009-11-15 Maxime Simon <Maxime Simon>

Reviewed by Adam Barth.

[Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.

platform/haiku/FileChooserHaiku.cpp:

3:26 PM Changeset in webkit [51002] by abarth@webkit.org

2 edits in trunk/WebCore

2009-11-15 Maxime Simon <Maxime Simon>

Reviewed by Adam Barth.

[Haiku] Build fix. ColorSpace name had a wrong CamelCase.

platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):

3:24 PM Changeset in webkit [51001] by abarth@webkit.org

4 edits in trunk/WebKitTools

2009-11-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add bugzilla-tool check-style
https://bugs.webkit.org/show_bug.cgi?id=31515

Scripts/bugzilla-tool:
Scripts/modules/bugzilla.py:

3:15 PM Changeset in webkit [51000] by dbates@webkit.org

8 edits in trunk/WebCore

2009-11-15 Daniel Bates <dbates@webkit.org>

No review, rolling out r50999.
http://trac.webkit.org/changeset/50999

Need to fix some issues in the Windows build. Missed some places where
RenderTextControl::isEdited is called.

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
dom/Document.cpp: (WebCore::Document::setFocusedNode):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setUserEdited): (WebCore::RenderTextControl::subtreeHasChanged):
rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited): (WebCore::RenderTextControl::isUserEdited):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

2:55 PM Changeset in webkit [50999] by dbates@webkit.org

8 edits in trunk/WebCore

2009-11-15 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31186

Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
These are more descriptive names so as to clear an ambiguity surrounding
their usage. Also, renames associated setters and getters so that they
coincide with the renamed fields.

No functionality was changed. So, no tests were included.

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]):
dom/Document.cpp: (WebCore::Document::setFocusedNode):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited. (WebCore::RenderTextControl::subtreeHasChanged):
rendering/RenderTextControl.h: (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited. (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited. (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):

Nov 14, 2009:

12:55 PM Changeset in webkit [50998] by adele@apple.com

11 edits
5 adds in trunk

WebCore: Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp

Reviewed by Dan Bernstein.

Test: fast/overflow/line-clamp.html

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):

Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
if there is anchor as the last child box, still allow adding the ellipsis.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
(WebCore::RenderLayer::scrollRectToVisible): ditto.

WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
rendering/style/LineClampValue.h: Added.

(WebCore::LineClampValue::LineClampValue):
(WebCore::LineClampValue::value):
(WebCore::LineClampValue::isPercentage):
(WebCore::LineClampValue::isNone):
(WebCore::LineClampValue::operator==):
(WebCore::LineClampValue::operator!=):

rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.

rendering/style/RenderStyle.h: Use LineClampValue.

(WebCore::InheritedFlags::lineClamp):
(WebCore::InheritedFlags::setLineClamp):
(WebCore::InheritedFlags::initialLineClamp):

rendering/style/StyleRareNonInheritedData.h:

LayoutTests: Test for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp

Reviewed by Dan Bernstein.

fast/overflow/line-clamp.html: Added.
platform/mac/fast/overflow/line-clamp-expected.checksum: Added.
platform/mac/fast/overflow/line-clamp-expected.png: Added.
platform/mac/fast/overflow/line-clamp-expected.txt: Added.

12:24 PM QtBackLog edited by zecke@selfish.org

Mention individual commits (diff)

9:53 AM Changeset in webkit [50997] by eric.carlson@apple.com

8 edits in trunk

2009-11-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme

WebCore.base.exp: Export wkMediaControllerThemeAvailable
platform/mac/WebCoreSystemInterface.h: Ditto.
platform/mac/WebCoreSystemInterface.mm: Ditto.

rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.

2009-11-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/7287487>
Do not use QuickTime version to detect media controller theme

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkMediaControllerThemeAvailable.

7:21 AM Changeset in webkit [50996] by tkent@chromium.org

4 edits
3 adds in trunk

2009-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for reading/writing .type property of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=29004

fast/forms/input-type-change3-expected.txt: Added.
fast/forms/input-type-change3.html: Added.
fast/forms/script-tests/input-type-change3.js: Added.

2009-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Recognizes date/datetime/datetime-local/month/time/week types of INPUT element. They have no dedicated UI and no type validation for now.
Clean up setInputType() and formControlType() of HTMLInputElement. https://bugs.webkit.org/show_bug.cgi?id=29004

Test: fast/forms/input-type-change3.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissing): (WebCore::HTMLInputElement::patternMismatch): (WebCore::HTMLInputElement::tooLong): (WebCore::createTypeMap): Initializer for a static local variable. (WebCore::HTMLInputElement::setInputType): (WebCore::createFormControlTypes): Initializer for a static local variable. (WebCore::HTMLInputElement::formControlType): (WebCore::HTMLInputElement::saveFormControlState): (WebCore::HTMLInputElement::restoreFormControlState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::isTextField): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::isRequiredFormControl): (WebCore::HTMLInputElement::dataList):
html/HTMLInputElement.h: Add new values to InputType enum, and define numberOfTypes.

6:08 AM Changeset in webkit [50995] by kov@webkit.org

2 edits in trunk/LayoutTests

Skip new test that needs new DRT infrastructure, with bug filled.

Nov 13, 2009:

10:24 PM Changeset in webkit [50994] by Chris Fleizach

5 edits
2 adds in trunk

WAI-ARIA: checkbox does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=31456

Reviewed by Darin Adler.

WebCore:

Test: accessibility/aria-checkbox-text.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

LayoutTests:

accessibility/aria-checkbox-text.html: Added.
platform/gtk/Skipped:
platform/mac/accessibility/aria-checkbox-text-expected.txt: Added.
platform/win/Skipped:

8:54 PM Changeset in webkit [50993] by Dimitri Glazkov

7 edits in trunk

WebCore:

2009-11-13 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
This is just enough changes to unbreak the port.

bindings/v8/ScriptController.cpp: (WebCore::mainThreadNormalWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::initContextIfNeeded):
loader/FrameLoaderClient.h:

WebKit/chromium:

2009-11-13 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Rename windowObjectCleared to dispatchDidClearWindowObjectInWorld
to catch up http://trac.webkit.org/changeset/50973.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
src/FrameLoaderClientImpl.h:

7:34 PM Changeset in webkit [50992] by aa@chromium.org

2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <aa@chromium.org>

Unreviewed fix for Chromium build.

loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld): Provide an empty implementation of this method because I don't know what it is supposed to do on Chromium.

7:11 PM Changeset in webkit [50991] by aa@chromium.org

2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <aa@chromium.org>

Unreviewed fix for Chromium build.

loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds() public, as Chromium's V8Proxy calls it.

6:58 PM Changeset in webkit [50990] by aa@chromium.org

2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <aa@chromium.org>

Unreviewed fix to Chromium build.

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::getAllWorlds):

6:45 PM Changeset in webkit [50989] by aa@chromium.org

2 edits in trunk/WebCore

2009-11-13 Aaron Boodman <aa@chromium.org>

Unreviewed fix for Chromium build.

platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.

6:29 PM Changeset in webkit [50988] by abarth@webkit.org

4 edits in trunk/WebCore

2009-11-13 Adam Barth <abarth@webkit.org>

Unreviewed partial build fix for Chromium. Should fix failure #4.

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::getAllWorlds):
bindings/v8/ScriptController.h:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::initContextIfNeeded):

6:18 PM Changeset in webkit [50987] by abarth@webkit.org

2 edits in trunk/WebCore

2009-11-13 Adam Barth <abarth@webkit.org>

Unreviewed partial build fix for Chromium.

bindings/v8/ScriptController.h: (WebCore::ScriptController::getAllWorlds):

5:47 PM Changeset in webkit [50986] by ap@apple.com

2 edits in trunk/LayoutTests

Disable websocket tests on Tiger, as they time out.

Filed <https://bugs.webkit.org/show_bug.cgi?id=31501> to investigate this issue.

platform/mac-tiger/Skipped:

5:40 PM Changeset in webkit [50985] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-13 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium WebKit Port to compile as dynamic lib

https://bugs.webkit.org/show_bug.cgi?id=31478

WebKit.gyp:

5:33 PM Changeset in webkit [50984] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix after r50923 change to externalRepresentation.

5:22 PM Changeset in webkit [50983] by aa@chromium.org

4 edits in trunk/WebKit/chromium

woo

5:07 PM Changeset in webkit [50982] by zoltan@webkit.org

3 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-13
Reviewed by Gavin Barraclough.

Adding optimization support for mode JSVALUE32_64
on ARM systems.

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

4:44 PM Changeset in webkit [50981] by zoltan@webkit.org

8 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=31050

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-14
Reviewed by Gavin Barraclough.

Adding JSVALUE32_64 support for ARM (but not turning it
on by default). All optimizations must be disabled, since
this patch is only the first of a series of patches.

During the work, a lot of x86 specific code revealed and
made platform independent.
See revisions: 50531 50541 50593 50594 50595

assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::fdivd_r):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::set8):
(JSC::MacroAssemblerARM::setTest8):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::zeroDouble):

jit/JIT.cpp:
jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

jit/JITStubs.cpp:
wtf/StdLibExtras.h:

4:39 PM Changeset in webkit [50980] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-13 Eric Seidel <eric@webkit.org>

No review, build fix only.

Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.

Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468

WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries

4:27 PM Changeset in webkit [50979] by jorlow@chromium.org

5 edits in trunk

2009-11-12 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dmitry Titov.

LocalStorage quota should include key sizes in its count
https://bugs.webkit.org/show_bug.cgi?id=31451

storage/StorageMap.cpp: (WebCore::StorageMap::setItem):

Count keys in the quota when adding a new item.

(WebCore::StorageMap::removeItem):

Remove the key's length from the quota if we're removing the item.

(WebCore::StorageMap::importItem):

Assume that we're adding things for the first time.
Count keys in the quota.

2009-11-12 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dmitry Titov.

Now that we're tracking key size in the quota, we can't fit as much in.
https://bugs.webkit.org/show_bug.cgi?id=31451

storage/domstorage/quota-expected.txt:
storage/domstorage/script-tests/quota.js: (testQuota):

4:25 PM Changeset in webkit [50978] by eric@webkit.org

2 edits in trunk/WebKitSite

2009-11-13 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added to the WebKit Coding Style Guidelines not to use
"using namespace" statements in header files.

coding/coding-style.html:

4:09 PM Changeset in webkit [50977] by eric@webkit.org

8 edits
1 move in trunk

2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468

Adding isAlphanumeric abstraction, required
by TextBoundaries.cpp.

wtf/unicode/glib/UnicodeGLib.h: (WTF::Unicode::isAlphanumeric):
wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isAlphanumeric):

2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468

Moving TextBoundariesICU.cpp to TextBoundaries.cpp
by removing the direct ICU dependency and replacing it
with WTF functions and WebCore's own TextBreakIterator
abstractions.

GNUmakefile.am:
platform/graphics/gtk/SimpleFontDataGtk.cpp:
platform/text/TextBoundaries.cpp: Added. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
platform/text/TextBoundariesICU.cpp: Removed.
platform/text/TextBreakIterator.h:
platform/text/TextBreakIteratorICU.cpp: (WebCore::textBreakLast): (WebCore::textBreakPrevious):

4:07 PM Changeset in webkit [50976] by hamaji@chromium.org

4 edits in trunk

2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

WebCore::externalRepresentation should update layout before getting render object
https://bugs.webkit.org/show_bug.cgi?id=31459

Before this change, the render tree output for this test was wrong.
Note that #FF0000 (red) becomes #008000 (green) now.

platform/mac/svg/custom/gradient-stop-style-change-expected.txt:

2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

WebCore::externalRepresentation should update layout before getting render object
https://bugs.webkit.org/show_bug.cgi?id=31459

rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):

4:06 PM Changeset in webkit [50975] by andersca@apple.com

5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Dan Bernstein.

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

3:56 PM Changeset in webkit [50974] by Adam Roben

2 edits in trunk/WebKit/win

Build fix

Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.

3:49 PM Changeset in webkit [50973] by Adam Roben

45 edits
2 adds in trunk

Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared

Fixes <http://webkit.org/b/31124>.

Reviewed by Dave Hyatt.

WebCore:

Tell FrameLoaderClient when window objects in isolated worlds are
cleared

Test: http/tests/security/isolatedWorld/didClearWindowObject.html

bindings/js/JSDOMBinding.h:

(WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
worlds in m_worldSet to the passed-in Vector.

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds): Added. Calls through to
WebCoreJSClientData.
(WebCore::ScriptController::initScript): Changed to call
FrameLoader::dispatchDidClearWindowObjectInWorld.

bindings/js/ScriptController.h: Added getAllWorlds.

loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Updated for FrameLoaderClient change.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::begin):
Changed to call dispatchDidClearWindowObjectsInAllWorlds.

(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
Added. Retrieves all the worlds, then calls through to
dispatchDidClearWindowObjectInWorld for each one.
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
dispatchWindowObjectAvailable. Calls up to the client, then, if the
world is the mainThreadNormalWorld(), tells the Inspector about it,
too.

loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with

dispatchDidClearWindowObjectInWorld. Added
dispatchDidClearWindowObjectsInAllWorlds.

loader/FrameLoaderClient.h: Replaced windowObjectCleared with

dispatchDidClearWindowObjectForWorld.

WebKit:

Add WebFrameLoadDelegatePrivat.h to WebKit.xcodeproj

WebKit.xcodeproj/project.pbxproj: Added

WebFrameLoadDelegatePrivate.h, which already existed.

WebKit/gtk:

Update for changes to FrameLoaderClient

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):

WebCoreSupport/FrameLoaderClientGtk.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKit/haiku:

Update for changes to FrameLoaderClient

WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::dispatchDidClearWindowObjectInWorld):

WebCoreSupport/FrameLoaderClientHaiku.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Replaced windowObjectCleared with this function. If the delegate
implements it, call
-webView:didClearWindowObjectForFrame:inScriptWorld:. Otherwise, if
the passed-in world is the mainThreadNormalWorld(), call
-webView:didClearWindowObject:forFrame:.

WebView/WebDelegateImplementationCaching.h: Added a new entry in the

frame load delegate implementation cache for the new delegate method.

WebView/WebFrameLoadDelegatePrivate.h:
WebView/WebScriptWorld.mm:

(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(-[WebScriptWorld initWithWorld:]): Add ourselves to allWorlds().
(-[WebScriptWorld dealloc]): Remove ourselves from allWorlds().
(+[WebScriptWorld findOrCreateWorld:]): Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.

WebView/WebScriptWorldInternal.h: Declared +findOrCreateWorld:.

WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]): Cache the
implementation of the new frame load delegate method.

WebKit/qt:

Update for changes to FrameLoaderClient

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):

WebCoreSupport/FrameLoaderClientQt.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKit/win:

Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added

didClearWindowObjectForFrameInScriptWorld.

WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

WebFrame.h:

Replaced windowObjectCleared with this function. If the delegate
implements IWebFrameLoadDelegatePrivate2, call
didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
world is the mainThreadNormalWorld(), call
didClearWindowObjectForFrame.

WebScriptWorld.cpp:

(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
(WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
(WebScriptWorld::standardWorld): Added this non-COM getter for the
standard world, which the COM getter now calls through to.
(WebScriptWorld::findOrCreateWorld): Added. Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.

WebScriptWorld.h: Added new standardWorld overload, made one

overload of createInstance private, and added findOrCreateWorld.

WebKit/wx:

Update for changes to FrameLoaderClient

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::dispatchDidClearWindowObjectInWorld):

WebKitSupport/FrameLoaderClientWx.h:

Replaced windowObjectCleared with this function. Does nothing if the
passed-in world is not the mainThreadNormalWorld().

WebKitTools:

Add support for
http/tests/security/isolatedWorld/didClearWindowObject.html

DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.

DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
Added. Moved code here from -webView:didClearWindowObject:forFrame:.
(-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
Added. Sets a worldID property on the global object whose value is
the ID of this world.
(-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
Respond to this new delegate callback by calling through to one of the
above new methods.

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID for this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.

DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.

DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didClearWindowObject): Moved code from hear to
didClearWindowObjectForFrameInStandardWorld.
(FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
Respond to this new delegate callback by calling through to one of the
below new methods.
(FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
Added. Sets a worldID property on the gobal object whose value is
the ID of this world.
(FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
Added. Moved code here from didClearWindowObject.

DumpRenderTree/win/FrameLoadDelegate.h: Added the

didClearWindowObjectForFrame* functions.

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(worldMap): Added. Returns a HashMap containing all the worlds we've
created.
(worldIDForWorld): Added. Returns the ID of this world, or 0 if we
haven't kept track of this world.
(LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
instead of declaring our own.

LayoutTests:

Test that delegates can modify global objects in isolated worlds

http/tests/security/isolatedWorld/didClearWindowObject-expected.txt: Added.
http/tests/security/isolatedWorld/didClearWindowObject.html: Added.

Tests that the global object in the normal world does not have a
worldID property, and that the global object in isolated worlds has
a worldID property whose value is equal to the world's ID.

3:46 PM Changeset in webkit [50972] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix SVG context assignment for pod types.
https://bugs.webkit.org/show_bug.cgi?id=31497

I broke this in r50958.

Tested by svg/custom/viewport-update2.svg.

bindings/scripts/CodeGeneratorV8.pm:

3:38 PM Changeset in webkit [50971] by dimich@chromium.org

12 edits in trunk/WebCore

Bring the platform/android files inline with Android 2.0
https://bugs.webkit.org/show_bug.cgi?id=31423

Patch by Andrei Popescu <andreip@google.com> on 2009-11-13
Reviewed by Dmitry Titov.

No new tests required: these are all Android-specific files.

platform/android/ClipboardAndroid.cpp:

(WebCore::ClipboardAndroid::files):

platform/android/ClipboardAndroid.h:
platform/android/FileChooserAndroid.cpp:

(WebCore::FileChooser::basenameForWidth):
(WebCore::fileButtonChooseFileLabel):

platform/android/KeyEventAndroid.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

platform/android/LocalizedStringsAndroid.cpp:

(WebCore::contextMenuItemTagOpenLinkInNewWindow):
(WebCore::contextMenuItemTagDownloadLinkToDisk):
(WebCore::contextMenuItemTagCopyLinkToClipboard):
(WebCore::contextMenuItemTagOpenImageInNewWindow):
(WebCore::contextMenuItemTagDownloadImageToDisk):
(WebCore::contextMenuItemTagCopyImageToClipboard):
(WebCore::contextMenuItemTagOpenFrameInNewWindow):
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagReload):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagNoGuessesFound):
(WebCore::contextMenuItemTagIgnoreSpelling):
(WebCore::contextMenuItemTagLearnSpelling):
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::contextMenuItemTagOpenLink):
(WebCore::contextMenuItemTagIgnoreGrammar):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckSpelling):
(WebCore::contextMenuItemTagCheckSpellingWhileTyping):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagFontMenu):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
(WebCore::contextMenuItemTagOutline):
(WebCore::contextMenuItemTagWritingDirectionMenu):
(WebCore::contextMenuItemTagTextDirectionMenu):
(WebCore::contextMenuItemTagDefaultDirection):
(WebCore::contextMenuItemTagLeftToRight):
(WebCore::contextMenuItemTagRightToLeft):
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
(WebCore::searchableIndexIntroduction):
(WebCore::resetButtonDefaultLabel):
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):

platform/android/RenderThemeAndroid.cpp:

(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeAndroid::baselinePosition):
(WebCore::RenderThemeAndroid::paintButton):
(WebCore::adjustMenuListStyleCommon):
(WebCore::RenderThemeAndroid::paintCombo):

platform/android/ScreenAndroid.cpp:
platform/android/ScrollViewAndroid.cpp:

(WebCore::ScrollView::platformOffscreenContentRectangle):

platform/android/TemporaryLinkStubs.cpp:

(JSC::Bindings::dispatchJNICall):

platform/android/WidgetAndroid.cpp:

(WebCore::Widget::setFrameRect):

3:33 PM UsingGitWithWebKit edited by eric@webkit.org

(diff)

3:21 PM Changeset in webkit [50970] by eric@webkit.org

4 edits in trunk

2009-11-13 Norbert Leser <norbert.leser&nokia.com>

Reviewed by Eric Seidel.

Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).

JavaScriptCore.pri:

2009-11-13 Norbert Leser <norbert.leser&nokia.com>

Reviewed by Eric Seidel.

Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).

WebCore.pro:

3:20 PM Changeset in webkit [50969] by dumi@chromium.org

2 edits in trunk/LayoutTests

Remove the unnecessary call to dumpDatabaseCallbacks().

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31495

storage/hash-change-with-xhr.html:

1:51 PM Changeset in webkit [50968] by dimich@chromium.org

23 edits
5 adds in trunk

Implement composition events introduced in DOM Level 3.
This change adds a new IDL which defines the composition events, adds a class which
implements the composition events, and sends the composition events according to
the specification.
https://bugs.webkit.org/show_bug.cgi?id=26310

Patch by Hironori Bono <hbono@chromium.org> on 2009-11-13
Reviewed by Oliver Hunt.

WebCore:

Test: fast/events/ime-composition-events-001.html

DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
WebCore.gypi: ditto.
WebCore.pro: ditto
WebCore.vcproj/WebCore.vcproj: ditto.
WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
bindings/js/JSEventCustom.cpp:

(WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.

bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.

(WebCore::V8DOMWrapper::convertEventToV8Object):

bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
dom/CompositionEvent.cpp: Implements the CompositionEvent class.

(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::~CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):
(WebCore::CompositionEvent::isCompositionEvent):

dom/CompositionEvent.h: Declares the CompositionEvent class.

(WebCore::CompositionEvent::create):
(WebCore::CompositionEvent::data):

dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
dom/Event.cpp:

(WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.

dom/Event.h:
dom/EventNames.h: Added composition{start,update,end} to eventNames.
editing/Editor.cpp:

(WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
(WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.

LayoutTests:

fast/events/ime-composition-events-001-expected.txt: Added.
fast/events/ime-composition-events-001.html: Added.
platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
platform/qt/Skipped: ditto.
platform/win/Skipped: ditto.

1:26 PM Changeset in webkit [50967] by snej@chromium.org

2 edits in trunk/WebCore

Fix a link error in unofficial GCC 4.4 builds on Linux.
https://bugs.webkit.org/show_bug.cgi?id=31477

Reviewed by Dimitri Glazkov.

bindings/v8/V8Binding.cpp: Add explicit instantiations of v8StringToWebCoreString template.

12:55 PM Changeset in webkit [50966] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-13 Eric Seidel <eric@webkit.org>

No review, build fix only.

Fix Debug build after http://trac.webkit.org/changeset/50960.

The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
https://bugs.webkit.org/show_bug.cgi?id=31213

rendering/CounterNode.cpp: (WebCore::showTreeAndMark):
rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):

12:50 PM Changeset in webkit [50965] by kenneth@webkit.org

3 edits
1 add in trunk

WebKitTools: Make the Qt Linux only --valgrind feature, suppress errors
defined in the SuppressedValgrindErrors file.

Reviewed by Simon Hausmann.

Scripts/run-webkit-tests:

LayoutTests: Add a file for suppressing invalid valgrind errors (Qt / Linux only)

Reviewed by Simon Hausmann.

platform/qt/SuppressedValgrindErrors: Added.

12:42 PM Changeset in webkit [50964] by oliver@apple.com

4 edits in trunk/JavaScriptCore

JSValueProtect and JSValueUnprotect don't protect API wrapper values
https://bugs.webkit.org/show_bug.cgi?id=31485

Reviewed by Geoff Garen.

Make JSValueProtect/Unprotect use a new 'toJS' function, 'toJSForGC' that
does not attempt to to strip out API wrapper objects.

12:35 PM Changeset in webkit [50963] by krit@webkit.org

2 edits in trunk/WebCore

2009-11-13 Dirk Schulze <krit@webkit.org>

Reviewed by Gustavo Noronha.

[CAIRO] shadow support for Canvas and SVG
https://bugs.webkit.org/show_bug.cgi?id=30960

We currently fill a path with solid color instead of filling
a clipping path. This causes problems on some composite operators,
since Cairo modifies the area outside the path.
This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html

Thanks to Benjamin Otte for tracking the bug down.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill):

12:29 PM Changeset in webkit [50962] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-13 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Antti Koivisto.

Fix typo, ce_time.cpp should be ce_time.c

JavaScriptCore.pri:

12:25 PM Changeset in webkit [50961] by dumi@chromium.org

11 edits
1 add in trunk

Adding Chromium's DatabaseTracker implementation.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31440

WebCore:

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
storage/DatabaseTracker.h:
storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

storage/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::updateDatabaseSize):

storage/chromium/QuotaTracker.h:

WebKit/chromium:

WebKit.gyp:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::exceededDatabaseQuota):

src/DatabaseObserver.cpp: Added.

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

src/WebDatabase.cpp:

(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):

src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::toString):
(WebKit::WebSecurityOrigin::databaseIdentifier):

12:21 PM Changeset in webkit [50960] by eric@webkit.org

7 edits in trunk/WebCore

2009-11-13 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
https://bugs.webkit.org/show_bug.cgi?id=31213
Added tree navigation methods that permit full implementation of CSS2.1
counter feature without using recursion proportional to the counter
tree depth.
No new tests because I did not find any bug that is fixed by this
commit yet, this just reduces the size of the patch for 11031 and
helps respond to some concerns regarding that patch.

rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode):

(WebCore::CounterNode::nextInPreOrderAfterChildren):
(WebCore::CounterNode::nextInPreOrder):
Added to support non-recursive tree traversal necessary for
efficient full implementation of CSS2.1 counters.

(WebCore::CounterNode::lastDescendant):
(WebCore::CounterNode::previousInPreOrder):
Moved this methods such that they occupy a place similar to that of
identically named methods on the render tree. This allows for their
broader use needed in full implementation of CSS2.1 counters.

(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
Changed such that insertion/removal of a counter, triggers not only
recalculation of PrefixWidths, but also reassesment of values in
counter nodes. This is the basis full implementation of CSS2.1
counters. It does not change current behavior by much because of
changes needed to the recalculation algorithm, but those are comming
in the patch for 11031.
(WebCore::showTreeAndMark):

rendering/CounterNode.h:
rendering/RenderCounter.cpp: (WebCore::counter): Only changed argument type to prepare for implementation of Darin Adler's recommendation for the patch to 11031.

(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeChildren):
(WebCore::RenderCounter::destroyCounterNodes):

rendering/RenderCounter.h:
rendering/RenderObjectChildList.cpp: (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters):
rendering/RenderObjectChildList.h: Added the ability to restrict invalidation to counters with a given identifier. Also invalidated counters that are on the child container itself which were missed by the previous algorithm, but were a valid case.

12:04 PM Changeset in webkit [50959] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Set the locale to C and not to the current one in use on the system.

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

11:56 AM Changeset in webkit [50958] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Protect SVG animated properties from destruction in bindings.
https://bugs.webkit.org/show_bug.cgi?id=31474

See http://crbug.com/26719.

Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
under Valgrind.

Made sure we keep a reference to SVG properties while setting a
context:

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Proxy.h: (WebCore::V8Proxy::withSVGContext):

11:30 AM Changeset in webkit [50957] by ap@apple.com

2 edits in trunk/LayoutTests

Disable websocket tests on Windows, as the server cannot start on buildbot.

Filed <https://bugs.webkit.org/show_bug.cgi?id=31479> to investigate this issue.

platform/win/Skipped:

11:21 AM Changeset in webkit [50956] by bfulgham@webkit.org

2 edits in trunk/WebCore

[CAIRO] shadow support for Canvas and SVG.
https://bugs.webkit.org/show_bug.cgi?id=30960

Reviewed by Alexey Proskuryakov.

Incorporate Benjamin Otte's recommendations to avoid
a buffer overrun, and small performance improvement.

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::copyContextProperties): Correctly size output

storage for cairo_get_dash to avoid buffer overrun.

(WebCore::drawPathShadow): Prefer cairo_fill_extents

to slower cairo_stroke_extents when not drawing shadows.

11:19 AM Changeset in webkit [50955] by ap@apple.com

1 edit in trunk/WebCore/ChangeLog

Restoring parst of ChangeLog that were somehow deleted with my latest commit.

11:14 AM Changeset in webkit [50954] by dumi@chromium.org

4 edits in trunk/WebCore

Do not register Chromium's HTML5 DB VFS as the default
VFS. Otherwise, other sqlite DB users in the same process will
stop working.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31462

platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

10:51 AM Changeset in webkit [50953] by ap@apple.com

2 edits in trunk/WebCore

Windows build fix

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags, avoiding a sign mismatch warning.

10:47 AM Changeset in webkit [50952] by ap@apple.com

2 edits in trunk/WebCore

Release build fix.

platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): (WebCore::SocketStreamHandle::writeStreamCallback): Use ASSERT_UNUSED for unused stream parameter.

10:14 AM Changeset in webkit [50951] by ap@apple.com

7 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31441
Implement SocketStreamHandleCFNet

Existing WebSocket tests now pass on Mac. No proxy support yet.

platform/network/SocketStreamHandleClient.h:
platform/network/cf/SocketStreamHandle.h: (WebCore::SocketStreamHandle::shouldUseSSL): (WebCore::SocketStreamHandle::refAuthenticationClient): (WebCore::SocketStreamHandle::derefAuthenticationClient): (WebCore::SocketStreamHandle::):
platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::chooseProxy): (WebCore::SocketStreamHandle::createStreams): (WebCore::SocketStreamHandle::copyCFStreamDescription): (WebCore::SocketStreamHandle::readStreamCallback): (WebCore::SocketStreamHandle::writeStreamCallback): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):

10:07 AM Changeset in webkit [50950] by dimich@chromium.org

2 edits in trunk/LayoutTests

Fix worker-timeout.html layout test that fails in Chromium harness.
https://bugs.webkit.org/show_bug.cgi?id=31452

Reviewed by Darin Adler.

fast/workers/worker-timeout.html:

Stop logging timer messages at the same time as calling NotifyDone() because
in test harness Chromium uses for workers it does not capture the output immediately.

9:51 AM Changeset in webkit [50949] by bfulgham@webkit.org

2 edits in trunk/WebKitLibraries

Build correction. No review.

The WinCairo build requires ENABLE_FILTERS to work properly.

win/tools/vsprops/WinCairo.vsprops:

9:50 AM Changeset in webkit [50948] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-13 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling Chromium dependencies to match Chromium revision 31834.

https://bugs.webkit.org/show_bug.cgi?id=31445

DEPS:

9:26 AM Changeset in webkit [50947] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: preload status bar button glyphs
in order to prevent them from flickering (take 2).

https://bugs.webkit.org/show_bug.cgi?id=31439

inspector/front-end/inspector.js: (preloadImages):

9:10 AM Changeset in webkit [50946] by pfeldman@chromium.org

3 edits
2 deletes in trunk

2009-11-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Adam Barth.

Chromium: [REGRESSION] Crash while stopping on a breakpoint.
Rolling back r50890.

https://bugs.webkit.org/show_bug.cgi?id=31467

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):

9:10 AM Changeset in webkit [50945] by Adam Roben

2 edits in trunk/WebKit/win

Build fix

Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they

are order-dependent!

9:05 AM Changeset in webkit [50944] by Adam Roben

2 edits in trunk/WebKit/win

Touch WebKit.idl to fix the Windows build

Interfaces/WebKit.idl: Sorted #includes.

8:58 AM Changeset in webkit [50943] by Adam Roben

10 edits in trunk

Finish replacing worldIDs with world objects

The only remaining use of worldIDs was in a method only used by DRT
for the isolated worlds tests.

Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects

Reviewed by Mark Rowe.

WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

WebView/WebFramePrivate.h:

Renamed from
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGobalObject:FromString:.
Now takes a WebScriptWorld instead of a worldID, so we don't need to
maintain a map of worldID -> world anymore.

WebKit/win:

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

WebFrame.h:

Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
IWebScriptWorld instead of a worldID, so we don't need to maintain a
map of worldID -> world anymore.

WebKitTools:

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::evaluateScriptInIsolatedWorld):

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):
Updated for changes to WebFrame. Now holds the map of worldID -> world
at this level instead of making WebKit do it.

8:43 AM Changeset in webkit [50942] by vestbo@webkit.org

3 edits in trunk/WebKitTools

[Qt] Ensure the DRT does not output anything until first test is run

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:
DumpRenderTree/qt/DumpRenderTree.h:

8:11 AM Changeset in webkit [50941] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Clear the undo stack in before each new test run.

Reviewed by Tor Arne Vestbø.

Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

7:06 AM Changeset in webkit [50940] by vestbo@webkit.org

6 edits in trunk/WebKit/qt

Update documentation for the Qt API

Reviewed by Simon Hausmann.

Api/qgraphicswebview.cpp:
Api/qwebelement.cpp:
Api/qwebframe.cpp:
Api/qwebsettings.cpp:
Api/qwebview.cpp:

6:57 AM Changeset in webkit [50939] by krit@webkit.org

4 edits in trunk

2009-11-13 Dirk Schulze <krit@webkit.org>

Reviewed by Gustavo Noronha.

[CAIRO] shadow support for Canvas and SVG
https://bugs.webkit.org/show_bug.cgi?id=30960

This is the fix of a regression, caused by the shadow patch
from the bug above. Reinserted the save and restore calls
that were accidently removed by the previous patch.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke):

Skip fast/canvas/canvas-shadow.html we need to enable filters
on cairo to pass this test.

platform/gtk/Skipped:

5:49 AM Changeset in webkit [50938] by eric@webkit.org

5 edits in trunk

2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable Page Cache if setMaximumPagesInCache needs it.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31266.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setMaximumPagesInCache):

2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::resetSettings):
DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):

5:21 AM Changeset in webkit [50937] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-11-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix initial QWebView focus behavior.

focusController->setFocused(true) was not always called.
https://bugs.webkit.org/show_bug.cgi?id=31466

Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent):

5:12 AM Changeset in webkit [50936] by vestbo@webkit.org

2 edits in trunk/WebKit/qt

Use correct install-path when running qdoc3

Reviewed by Simon Hausmann.

docs/docs.pri:

2:45 AM Changeset in webkit [50935] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-13 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Reverting r50908 since it makes inspector tests
time out.

https://bugs.webkit.org/show_bug.cgi?id=31439

inspector/front-end/inspector.js:

2:21 AM Changeset in webkit [50934] by kov@webkit.org

2 edits in trunk/LayoutTests

Skip one new test.

1:51 AM Changeset in webkit [50933] by pfeldman@chromium.org

5 edits
1 add in trunk/WebCore

2009-11-13 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Enable 'console.profile()' and 'console.profileEnd()'
regardless of JAVASCRIPT_DEBUGGER.

https://bugs.webkit.org/show_bug.cgi?id=31293

WebCore.gypi:
bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8CustomBinding.h:
page/Console.idl:

1:34 AM Changeset in webkit [50932] by levin@chromium.org

2 edits in trunk/WebCore

Chromium build fix.

Reviewed by NOBODY.

bindings/v8/ScriptController.h:

(WebCore::ScriptController::evaluateInWorld): Add a dummy

method which isn't called in chromium to make things compile.

12:11 AM Changeset in webkit [50931] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update committers.py based on svn records
https://bugs.webkit.org/show_bug.cgi?id=31366

This list was generated using validate-committer-lists from
https://bugs.webkit.org/show_bug.cgi?id=30970
and makes committers.py current for committers who have
committed in the last 3 years.

Scripts/modules/committers.py:

Nov 12, 2009:

11:52 PM Changeset in webkit [50930] by mitz@apple.com

4 edits in trunk/WebKit/mac

When exiting full-screen video, rather than resetting the system UI
mode, restore it to what it was when full-screen mode was entered.

Reviewed by Adele Peterson.

WebView/WebVideoFullscreenController.h: Cleaned up style, removed

unnecessary imports, and added _savedUIMode and _savedUIOptions ivars.

WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController delegate]): Cleaned up style.
(-[WebVideoFullscreenController setDelegate:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Restore the
system UI mode.
(-[WebVideoFullscreenController windowDidEnterFullscreen]): Save the
system UI mode.

WebView/WebView.mm: Added now-necessary import.

10:42 PM Changeset in webkit [50929] by eric@webkit.org

7 edits in trunk

2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The document-html and window-html tests don't use a setTimeout to notify that the
test is completed. The layout test plugin now issues the notifyDone call via
javascript.

https://bugs.webkit.org/show_bug.cgi?id=31067

plugins/document-open.html:
plugins/window-open.html:

2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance, which causes a crash when the plugin stream
dereferences an invalid m_client pointer which points to the PluginView instance which
is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
and check for the same.

https://bugs.webkit.org/show_bug.cgi?id=31067

plugins/PluginStream.cpp: (WebCore::PluginStream::stop): (WebCore::PluginStream::destroyStream):

2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance. The pluginLog function in the layout test
plugin attempts to retrieve the window script object on a torn down plugin instance
which crashed consistently on windows in the debugger. The functions which issue
these logs already have a valid window script object. We now have variants of the pluginLog
function which take in a window script object with and without variable arguments.

https://bugs.webkit.org/show_bug.cgi?id=31067

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLogWithWindowObject): (pluginLogWithWindowObjectVariableArgs): (pluginLog): (notifyTestCompletion): (testDocumentOpen): (testWindowOpen):

9:17 PM Changeset in webkit [50928] by dumi@chromium.org

5 edits in trunk

Renaming some parameters passed to DB-related methods to better
indicate their purpose.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31449

WebCore:

platform/chromium/ChromiumBridge.h:

WebKit/chromium:

public/WebKitClient.h:
src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):

9:08 PM Changeset in webkit [50927] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-12 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by Adam Barth.

Calculate the time offset only if we were able to parse
the date string. This saves an IPC in Chromium for
invalid date strings.
https://bugs.webkit.org/show_bug.cgi?id=31416

wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): (JSC::parseDateFromNullTerminatedCharacters):

8:59 PM Changeset in webkit [50926] by eric@webkit.org

3 edits in trunk/LayoutTests

2009-11-12 Kinuko Yasuda <kinuko@google.com>

Reviewed by Adam Barth.

Makes the output of fast/events/mouse-click-events.html independent
of the window size.
https://bugs.webkit.org/show_bug.cgi?id=31405

fast/events/mouse-click-events-expected.txt:
fast/events/script-tests/mouse-click-events.js:

8:36 PM Changeset in webkit [50925] by Simon Fraser

3 edits
4 adds in trunk

2009-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Transformed reflected elements are clipped inside element with opacity
https://bugs.webkit.org/show_bug.cgi?id=30957

transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
each clip rect into painting space before taking the unions. This, however, did not work
correctly with combinations of reflections and transforms. Fixed by unioning the
clipRect and mapping through transforms along the way.

Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
where the transparency layers are.

Test: fast/reflections/opacity-reflection-transform.html

rendering/RenderLayer.cpp: (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers):

7:17 PM QtWebKitPlugins edited by yael.aharon@nokia.com

(diff)

7:05 PM Changeset in webkit [50924] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-12 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Improve SecurityOrigin::toString comment
https://bugs.webkit.org/show_bug.cgi?id=31041

page/SecurityOrigin.h:

6:37 PM Changeset in webkit [50923] by hamaji@chromium.org

12 edits in trunk

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

WebCore.base.exp:
rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
rendering/RenderTreeAsText.h:

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

webkit/webkitwebframe.cpp: (webkit_web_frame_dump_render_tree):

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentation]):

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

Api/qwebframe.cpp: (QWebFrame::renderTreeDump):

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

No new tests as this is just a refactoring.

WebFrame.cpp: (WebFrame::renderTreeAsExternalRepresentation):

6:22 PM Changeset in webkit [50922] by benm@google.com

3 edits
1 delete in trunk/WebCore

[Android] The Android specific files in page/Android are out of date.
https://bugs.webkit.org/show_bug.cgi?id=31437

Reviewed by Dimitri Glazkov.

No tests required.

page/android/DragControllerAndroid.cpp:

(WebCore::DragController::dragOperation): Added.
(WebCore::DragController::cleanupAfterSystemDrag):

page/android/EventHandlerAndroid.cpp:

(WebCore::EventHandler::accessKeyModifiers): Added.

page/android/InspectorControllerAndroid.cpp: Removed.

5:59 PM Changeset in webkit [50921] by eric@webkit.org

9 edits
2 adds in trunk

2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument

Added testing support for AtkDocument implementation.

accessibility/document-attributes.html: Added.
accessibility/document-attributes-expected.txt: Added.
platform/mac/Skipped:
platform/win/Skipped:

2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument

Added testing support.

DumpRenderTree/AccessibilityUIElement.cpp:
DumpRenderTree/AccessibilityUIElement.h: (getDocumentEncodingCallback): (getDocumentURICallback): (AccessibilityUIElement::getJSClass):
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
DumpRenderTree/mac/AccessibilityUIElementMac.mm:
DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::documentEncoding): (AccessibilityUIElement::documentURI):

5:47 PM Changeset in webkit [50920] by bfulgham@webkit.org

10 edits
5 adds in trunk

WebCore: [CAIRO] shadow support for Canvas and SVG.
https://bugs.webkit.org/show_bug.cgi?id=30960

Reviewed by Simon Fraser.

Implement Canvas/SVG shadow support for Cairo. This patch
uses the filter code from SVG Filters. That means that it is
necessary to activate filters to see the shadows.

Test: fast/canvas/canvas-shadow.html

GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(GraphicsContext::calculateShadowBufferDimensions): New helper routine.
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::copyContextProperties):
(WebCore::drawPathShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::createPlatformShadow):

platform/graphics/cairo/ImageCairo.cpp:

(WebCore::BitmapImage::draw): Add filter effect.

platform/graphics/filters/Filter.h: Correct 'const' signatures.
platform/graphics/filters/ImageBufferFilter.cpp: Added.
platform/graphics/filters/ImageBufferFilter.h: Added.
svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.

LayoutTests: Some tests for canvas shadow.

Patch by Dirk Schulze <krit@webkit.org> on 2009-11-11
Reviewed by Simon Fraser.

fast/canvas/canvas-shadow-expected.txt: Added.
fast/canvas/canvas-shadow.html: Added.
fast/canvas/script-tests/canvas-shadow.js: Added.

5:12 PM Changeset in webkit [50919] by dimich@chromium.org

4 edits in trunk/WebCore

Add postTaskToMainThread to ScriptExecutionContext.
Move the code to post task to the main thread into a new method on ScriptExecutionContext,
to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
contexts that live on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=31427

Reviewed by Alexey Proskuryakov.

No new tests - simply moving the code.

dom/Document.cpp:

(WebCore::Document::postTask):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskData::PerformTaskData):
(WebCore::PerformTaskData::performTask):
(WebCore::ScriptExecutionContext::postTaskToMainThread):

dom/ScriptExecutionContext.h:

4:44 PM Changeset in webkit [50918] by Simon Fraser

2 edits in trunk/WebCore

2009-11-12 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Fix crash when removing compositing layers when GC is enabled
https://bugs.webkit.org/show_bug.cgi?id=31429

Workaround <rdar://problem/7390716> by special-casing the removal
of all sublayers when GC is enabled.

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::safeSetSublayers): (WebCore::GraphicsLayerCA::updateSublayerList): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

4:38 PM Changeset in webkit [50917] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Steve Falkenburg.

Add failing tests to Skipped list.

platform/win/Skipped:

4:28 PM Changeset in webkit [50916] by oliver@apple.com

4 edits in trunk/JavaScriptCore

Rollout r50896 until i can work out why it causes failures.

4:23 PM Changeset in webkit [50915] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Remove LIBRARY directive from def file to fix Debug_All target.

Reviewed by Stephanie Lewis.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

4:17 PM Changeset in webkit [50914] by snej@chromium.org

4 edits in trunk/WebCore

The last of the V8 binding optimizations.

Replace string-valued element accessors with a shared getter/setter function.
Change error handling flow of control to avoid extra branches and function calls.

https://bugs.webkit.org/show_bug.cgi?id=31443

Reviewed by Dimitri Glazkov.

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Binding.cpp:

(WebCore::getElementStringAttr): Body of string-valued Element getter function.
(WebCore::setElementStringAttr): Body of string-valued Element setter function.

bindings/v8/V8Binding.h:

3:48 PM Changeset in webkit [50913] by kov@webkit.org

2 edits in trunk/LayoutTests

Skipping tests that fail intermitently.

3:46 PM Changeset in webkit [50912] by kov@webkit.org

1 edit in trunk/JavaScriptCore/ChangeLog

Add ChangeLog entry to the last commit

3:39 PM Changeset in webkit [50911] by kov@webkit.org

1 edit in trunk/JavaScriptCore/wtf/FastMalloc.h

Revert "Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix"

This reverts commit d3f6ad156fc2ba883fdff85e7121bee9537cd021.

Conflicts:

JavaScriptCore/ChangeLog

3:21 PM Changeset in webkit [50910] by weinig@apple.com

3 edits
3 adds in trunk

WebCore: Fix for <rdar://problem/7267951>
Canvas methods should reject uses of NaN and Infinity.

Reviewed by Oliver Hunt.

Test: fast/canvas/canvas-with-illegal-args.html

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):

LayoutTests: Test for <rdar://problem/7267951>
Canvas methods should reject uses of NaN and Infinity.

Reviewed by Oliver Hunt.

fast/canvas/canvas-with-illegal-args-expected.txt: Added.
fast/canvas/canvas-with-illegal-args.html: Added.
fast/canvas/script-tests/canvas-with-illegal-args.js: Added.

3:07 PM Changeset in webkit [50909] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: profile timeline panel, fix obvious problems.

https://bugs.webkit.org/show_bug.cgi?id=31432

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.refresh):
inspector/front-end/utilities.js: (Element.prototype.hasStyleClass):

3:04 PM Changeset in webkit [50908] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: preload status bar button glyphs
in order to prevent them from flickering.

https://bugs.webkit.org/show_bug.cgi?id=31439

inspector/front-end/inspector.js: (preloadImages):

2:41 PM Changeset in webkit [50907] by Adam Roben

36 edits
6 adds in trunk

Replace worldIDs with world objects

Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
user scripts/stylesheets and isolated worlds

Reviewed by Sam Weinig.

WebCore:

Covered by existing tests.

WebCore.base.exp: Update exported symbols to match what now exists

and is needed by WebKit.

bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute): Updated for function rename.

bindings/js/ScriptController.cpp: Removed code that dealt with

worldIDs.
(WebCore::ScriptController::createWorld): Added. Returns a new world
suitable for use on the main thread.
(WebCore::ScriptController::executeScriptInWorld): Renamed from
executeScriptInIsolatedWorld, since this works just fine with a
"normal" world.

bindings/js/ScriptController.h: Added createWorld, removed functions

that took worldIDs, renamed executeScriptInIsolatedWorld to
executeScriptInWorld.

page/Frame.cpp:

(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
Updated for changes to UserScriptMap and ScriptController.

page/Frame.h: Changed injectUserScriptsForWorld to take a

DOMWrapperWorld* instead of a worldID.

page/PageGroup.cpp:

(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):

page/PageGroup.h:

Changed these functions to take a DOMWrapperWorld* instead of a
worldID. Also updated for changes to UserScript and UserStyleSheet.

page/UserScript.h:
page/UserStyleSheet.h: Changed not to hold a worldID, since it was

never used.

page/UserScriptTypes.h:
page/UserStyleSheetTypes.h: Changed UserScriptMap and

UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
worldID as their key type.

WebKit:

WebKit.xcodeproj/project.pbxproj: Added WebScriptWorld to the project.

WebKit/mac:

WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in -[WebFrame
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:],
but that will change soon.

WebKit.exp: Export WebScriptWorld.

WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:]):
Moved the bizarre world caching/creation logic that DRT depends on
here from the findWorld function in ScriptController.cpp. Updated to
use ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
(-[WebFrame _contextForWorld:]): Renamed from contextForWorldID:. Now
takes a WebScriptWorld.

WebView/WebFramePrivate.h: Replaced contextForWorldID: with

_contextForWorld:.

WebView/WebScriptWorld.h: Added.
WebView/WebScriptWorld.mm: Added.

(-[WebScriptWorld initWithWorld:]): Store the passed-in world in our
_private member.
(-[WebScriptWorld init]): Create a new DOMWrapperWorld and pass it to
-initWithWorld:.
(-[WebScriptWorld dealloc]): Release _private.
(+[WebScriptWorld standardWorld]): Returns a shared instance that
represents WebCore's mainThreadNormalWorld().
(+[WebScriptWorld world]): Returns a new instance.
(core): Returns the DOMWrapperWorld for this WebScriptWorld.

WebView/WebScriptWorldInternal.h: Added.

WebView/WebView.mm:

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):

WebView/WebViewPrivate.h:

Changed these functions to take a WebScriptWorld instead of a worldID.

WebKit/win:

WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in
IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
that will change soon.

ForEachCoClass.h: Added WebScriptWorld.

Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with

contextForWorld.

Interfaces/IWebScriptWorld.idl: Added.

Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet

functions to take an IWebScriptWorld instead of a worldID.

Interfaces/WebKit.idl: Added WebScriptWorld.

WebFrame.cpp:

(WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
an IWebScriptWorld.
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
bizarre world caching/creation logic that DRT depends on here from the
findWorld function in ScriptController.cpp. Updated to use
ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.

WebFrame.h: Replaced contextForWorldID with contextForWorld.

WebScriptWorld.cpp: Added.

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
(WebScriptWorld::createInstance):
(WebScriptWorld::AddRef):
(WebScriptWorld::Release):
(WebScriptWorld::QueryInterface):
Standard COM class implementations.

(WebScriptWorld::standardWorld): Returns a shared instance that represents
WebCore's mainThreadNormalWorld().

WebScriptWorld.h: Added.

(WebScriptWorld::world): Simple getter.

WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.

WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.

WebKitClassFactory.cpp: Added WebScriptWorld.

WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):

WebView.h:

Changed these functions to take an IWebScriptWorld instead of a worldID.

WebKitTools:

DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Changed these functions to create a new WebJSWorld each time they're
called and to pass that world to WebKit.

2:40 PM Changeset in webkit [50906] by Adam Roben

2 edits in trunk/WebKit/win

Small clean-up in WebView's user content functions

Preparation for <http://webkit.org/b/31414> Implement new SPI for
dealing with user scripts/stylesheets and isolated worlds

Reviewed by Dave Hyatt.

WebView.cpp:

(toString):
(toKURL):
Added these helper functions to convert BSTRs to WebCore types.

(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
Use the new helper functions.

2:24 PM Changeset in webkit [50905] by bweinstein@apple.com

3 edits in trunk/WebCore

Fixes <http://webkit.org/b/31260>.
Web Inspector: Main Resources Other than HTML are mis-detected.

Reviewed by Tim Hatcher.

Even if the resource is a main resource, look at its CachedResource type,
because it might be an image, stylesheet, or JavaScript file, and we
want to show them all correctly.

inspector/InspectorResource.cpp:

(WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
(WebCore::InspectorResource::type):

inspector/InspectorResource.h:

2:13 PM Changeset in webkit [50904] by mrowe@apple.com

3 edits in trunk/LayoutTests

Skip an accessibility test that covers functionality not available on Tiger or Leopard.

platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:

2:07 PM Changeset in webkit [50903] by kov@webkit.org

2 edits in trunk/LayoutTests

Skipping one more new test, and a number of other tests, with bugs
filled.

1:33 PM Changeset in webkit [50902] by mrowe@apple.com

1 delete in trunk/LayoutTests/platform/mac-snowleopard/accessibility

Remove a now-empty directory that I missed.

1:32 PM Changeset in webkit [50901] by mrowe@apple.com

2 edits in trunk/LayoutTests

Fix results for fast/dom/Window/window-properties.html after r50893.

fast/dom/Window/window-properties-expected.txt:

1:32 PM Changeset in webkit [50900] by mrowe@apple.com

1 edit
2 moves in trunk/LayoutTests

Move a misplaced accessibility test from platform/mac-snowleopard/accessibility to accessibility,
and the results from platform/mac-snowleopard/accessibility to platform/mac/accessibility.

Rubber-stamped by Anders Carlsson.

accessibility/aria-list-and-listitem.html: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem.html.
platform/mac/accessibility/aria-list-and-listitem-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt.

1:32 PM Changeset in webkit [50899] by mrowe@apple.com

3 edits
2 copies
4 adds in trunk/LayoutTests

Land updated results for file-url-mimetypes-2.html and file-url-mimetypes-3.html.

Rubber-stamped by Brady Eidson.

platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:

1:28 PM Changeset in webkit [50898] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-11-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skipped new tests, a test that keeps failing despite
not failing locally, and a new DnD test.

platform/gtk/Skipped:

1:17 PM Changeset in webkit [50897] by snej@chromium.org

6 edits in trunk/WebCore

Table-driven setup for V8 binding template callback functions. 100k in code savings.
https://bugs.webkit.org/show_bug.cgi?id=31420

Reviewed by Dimitri Glazkov.

bindings/scripts/CodeGeneratorV8.pm: Change generated ConfigureXXXTemplate fn

to call configureTemplate().

bindings/v8/V8Binding.cpp:

(WebCore::configureTemplate): New function; does all the standard configuration work.
(WebCore::createCallback): De-inlined wrapper for FunctionTemplate creation.

bindings/v8/V8Binding.h:
bindings/v8/V8Proxy.cpp:

(WebCore::batchConfigureAttributes): Just wrapped the very long fn parameter list.
(WebCore::batchConfigureCallbacks): New function, used by configureTemplate.
(WebCore::batchConfigureConstants): Just wrapped the very long fn parameter list.

bindings/v8/V8Proxy.h:

1:07 PM Changeset in webkit [50896] by oliver@apple.com

4 edits in trunk/JavaScriptCore

Start unifying entry logic for function and eval code.

Reviewed by Gavin Barraclough.

Eval now uses a ret instruction to end execution, and sets up
a callframe more in line with what we do for function entry.

1:03 PM Changeset in webkit [50895] by dumi@chromium.org

2 edits in trunk/WebCore

Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.

platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

1:02 PM Changeset in webkit [50894] by eric.carlson@apple.com

5 edits in trunk/LayoutTests

2009-11-12 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Skipped tests need path relative to LayoutTests folder, not just
test name.

platform/gtk/Skipped:
platform/mac-leopard/Skipped:
platform/mac-tiger/Skipped:
platform/win/Skipped:

12:23 PM Changeset in webkit [50893] by eric.carlson@apple.com

13 edits
5 adds in trunk

2009-11-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7388969> Add DOM API for fullscreen video

DOM API for fullscreen <video>.

Tests: media/media-fullscreen-inline.html

media/media-fullscreen-not-in-document.html

dom/EventNames.h:

Add webkitbeginfullscreen and webkitendfullscreen.

html/HTMLAttributeNames.in:

Add onwebkitbeginfullscreen and onwebkitendfullscreen.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute):

Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.

(WebCore::HTMLMediaElement::enterFullscreen):

Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
actually do enter fullscreen.

(WebCore::HTMLMediaElement::exitFullscreen):

Schedule webkitendfullscreenEvent event.

(WebCore::HTMLMediaElement::webkitEnterFullScreen):
(WebCore::HTMLMediaElement::webkitExitFullScreen):
(WebCore::HTMLMediaElement::webkitSupportsFullscreen):
(WebCore::HTMLMediaElement::webkitDisplayingFullscreen):

New, access to fullscreen properties and methods.

html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:

Declare methods needed for fullscreen API.

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::supportsFullscreen):

Return false if a movie does not have video.

page/DOMWindow.h:

Add webkitbeginfullscreen and webkitendfullscreen.

2009-11-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7388969> Add DOM API for fullscreen video

Tests for fullscreen <video> DOM API.

media/media-fullscreen-inline-expected.txt: Added.
media/media-fullscreen-inline.html: Added.
media/media-fullscreen-not-in-document-expected.txt: Added.
media/media-fullscreen-not-in-document.html: Added.
media/media-fullscreen.js: Added.

platform/gtk/Skipped:
platform/mac-tiger/Skipped:
platform/win/Skipped:

Skipped on platforms that don't support fullscreen yet.

12:16 PM Changeset in webkit [50892] by ap@apple.com

9 edits in trunk/LayoutTests

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=31426
Some WebSocket tests don't properly listen to close event

websocket/tests/script-tests/handshake-error.js:
websocket/tests/script-tests/simple.js: Made the tests clear second-chance timer on finish, avoiding confusing output when running them in Safari.

websocket/tests/script-tests/frame-length-longer-than-buffer.js:
websocket/tests/script-tests/frame-length-skip.js:
websocket/tests/frame-length-longer-than-buffer-expected.txt:
websocket/tests/frame-length-skip-expected.txt: These tests now finish properly.

websocket/tests/handshake-error-expected.txt:
websocket/tests/simple-expected.txt: I'm getting an extra empty line for these tests, which is surprising. But since I didn't change anything, I assume that it should be there.

12:03 PM Changeset in webkit [50891] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-12 Adam Barth <abarth>

Reviewed by Dimitri Glazkov.

[Chromium] reload-subframe-object.html fails
https://bugs.webkit.org/show_bug.cgi?id=31398

More closely match FrameLoaderClient.mm. Turns out we don't want to
use MIMETypeRegistry::getMIMETypeForPath because we can't distinguish
between application/octet-stream and lack of knowledge of the MIME
type.

Covered by reload-subframe-object.html.

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::objectContentType):

11:56 AM Changeset in webkit [50890] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394

Test that we're using the calling security context in a simple case.

http/tests/security/calling-versus-current-expected.txt: Added.
http/tests/security/calling-versus-current.html: Added.

2009-11-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394

Test: http/tests/security/calling-versus-current.html

We're supposed to use the calling context for security checks. In JSC
land, this is the lexicalGlobalObject.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::canAccessPrivate):

11:24 AM Changeset in webkit [50889] by Nate Chapin

3 edits in trunk/WebKit/chromium

2009-11-12 Nate Chapin <Nate Chapin>

Unreviewed, Chromium build fix.

Add new accessibility enum values to Chromium enums from
http://trac.webkit.org/changeset/50865 and
http://trac.webkit.org/changeset/50883.

https://bugs.webkit.org/show_bug.cgi?id=31424

public/WebAccessibilityRole.h: (WebKit::):
src/AssertMatchingEnums.cpp:

11:21 AM Changeset in webkit [50888] by dbates@webkit.org

5 edits in trunk

2009-11-12 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30291

Fixes an issue where the returned drop effect is incorrect when
effectAllowed == "uninitialized".

According to section 7.9.2 of the HTML 5 spec.
<http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
when effectAllowed = "uninitialized" the resulting dropEffect should be the
user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
other case.

No test cases are included because we have an existing test case from
bug #24731.

dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".

2009-11-12 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30291

Rebased results for existing test case fast/events/drag-and-drop.html
from bug #24731.

Now, we can run the part of the test when effectAllowed == "uninitialized".

fast/events/drag-and-drop-expected.txt: Rebased results.
fast/events/drag-and-drop.html: Removed notice about this bug (#30291).

10:46 AM Changeset in webkit [50887] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-12 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Send |keypress()| events for keys with cmd down, like safari.
Test: Hit cmd-shift-a on unixpapa.com/js/testkey.html , should show a
keypress() event.

src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::keyboardEvent):

10:35 AM Changeset in webkit [50886] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not highlight node on refresh.

https://bugs.webkit.org/show_bug.cgi?id=31419

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):

10:23 AM Changeset in webkit [50885] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Minor timeline fixes.

https://bugs.webkit.org/show_bug.cgi?id=31417

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype._updateDetails): (WebInspector.TimelineRecordTreeElement.prototype.refresh):

9:44 AM Changeset in webkit [50884] by ap@apple.com

2 edits in trunk/WebCore

SnowLeopard build fix.

Renamed initWithClient to initWithAuthenticationClient.

platform/network/mac/AuthenticationMac.mm: (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]): (WebCore::AuthenticationChallenge::setAuthenticationClient):

9:37 AM Changeset in webkit [50883] by eric@webkit.org

10 edits
2 adds in trunk

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

platform/mac/accessibility/aria-alerts-expected.txt: Added.
platform/mac/accessibility/aria-alerts.html: Added.

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

Test: platform/mac/accessibility/aria-alerts.html

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:
accessibility/mac/AccessibilityObjectWrapper.mm:

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:

2009-11-12 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):

9:18 AM Changeset in webkit [50882] by ap@apple.com

8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=31386
Make Mac AuthenticationChallenge usable from cross-platform code

No change in behavior, so no tests.

platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication):
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge is identical.

platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to be already set.

platform/network/mac/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the best of my understanding. (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent confusion with "mac" and "web" challenges in ResourceHandleInternal.

platform/network/mac/AuthenticationMac.mm: (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient, making it possible to use the latter with NSURLAuthenticationChallenge. (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge -> m_nsChallenge renaming. (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and set it as sender (or unset, if client is null).

platform/network/mac/ResourceHandleMac.mm: (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as authentication challenge sender. (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an authentication sheet. (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge using the new setAuthenticationClient() method. (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion. Since didCancelAuthenticationChallenge is called by connection, the passed challenge is the original Mac one, not the one we created for use with authentication sheet. I don't know when a connection would cancel authentication in practice, so I haven't tested this.

9:08 AM Changeset in webkit [50881] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: breakpoint sidebar entries should allow click over entire list item
https://bugs.webkit.org/show_bug.cgi?id=31411

No new tests; no new functionality, small usability change.

inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):

9:00 AM Changeset in webkit [50880] by eric@webkit.org

2 edits
1 add in trunk/WebCore

2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: breakpoints in named evals are not restored after a reload
https://bugs.webkit.org/show_bug.cgi?id=31375

Manual test added

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):
manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.

7:14 AM BuildingGtk edited by zundel@google.com

(diff)

6:37 AM Changeset in webkit [50879] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358

Reviewed by Jan Alonzo.

QWebPage's constructor docs are mentioning "QWebView":
"Constructs an empty QWebView with parent".

Api/qwebpage.cpp:

6:13 AM Changeset in webkit [50878] by zoltan@webkit.org

416 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-12
[Qt] Update outdated metrics in layout tests after change to Qt 4.6 on the buildbot.

platform/qt/css1/basic/class_as_selector-expected.txt:
platform/qt/css1/basic/comments-expected.txt:
platform/qt/css1/basic/containment-expected.txt:
platform/qt/css1/basic/contextual_selectors-expected.txt:
platform/qt/css1/basic/grouping-expected.txt:
platform/qt/css1/basic/id_as_selector-expected.txt:
platform/qt/css1/basic/inheritance-expected.txt:
platform/qt/css1/box_properties/acid_test-expected.txt:
platform/qt/css1/box_properties/border-expected.txt:
platform/qt/css1/box_properties/border_bottom-expected.txt:
platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
platform/qt/css1/box_properties/border_bottom_width-expected.txt:
platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
platform/qt/css1/box_properties/border_color-expected.txt:
platform/qt/css1/box_properties/border_color_inline-expected.txt:
platform/qt/css1/box_properties/border_inline-expected.txt:
platform/qt/css1/box_properties/border_left-expected.txt:
platform/qt/css1/box_properties/border_left_inline-expected.txt:
platform/qt/css1/box_properties/border_left_width-expected.txt:
platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
platform/qt/css1/box_properties/border_right-expected.txt:
platform/qt/css1/box_properties/border_right_inline-expected.txt:
platform/qt/css1/box_properties/border_right_width-expected.txt:
platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
platform/qt/css1/box_properties/border_style-expected.txt:
platform/qt/css1/box_properties/border_style_inline-expected.txt:
platform/qt/css1/box_properties/border_top-expected.txt:
platform/qt/css1/box_properties/border_top_inline-expected.txt:
platform/qt/css1/box_properties/border_top_width-expected.txt:
platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
platform/qt/css1/box_properties/border_width-expected.txt:
platform/qt/css1/box_properties/border_width_inline-expected.txt:
platform/qt/css1/box_properties/clear-expected.txt:
platform/qt/css1/box_properties/clear_float-expected.txt:
platform/qt/css1/box_properties/float-expected.txt:
platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
platform/qt/css1/box_properties/float_margin-expected.txt:
platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
platform/qt/css1/box_properties/height-expected.txt:
platform/qt/css1/box_properties/margin-expected.txt:
platform/qt/css1/box_properties/margin_bottom-expected.txt:
platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
platform/qt/css1/box_properties/margin_inline-expected.txt:
platform/qt/css1/box_properties/margin_left-expected.txt:
platform/qt/css1/box_properties/margin_left_inline-expected.txt:
platform/qt/css1/box_properties/margin_right-expected.txt:
platform/qt/css1/box_properties/margin_right_inline-expected.txt:
platform/qt/css1/box_properties/margin_top-expected.txt:
platform/qt/css1/box_properties/margin_top_inline-expected.txt:
platform/qt/css1/box_properties/padding-expected.txt:
platform/qt/css1/box_properties/padding_bottom-expected.txt:
platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
platform/qt/css1/box_properties/padding_inline-expected.txt:
platform/qt/css1/box_properties/padding_left-expected.txt:
platform/qt/css1/box_properties/padding_left_inline-expected.txt:
platform/qt/css1/box_properties/padding_right-expected.txt:
platform/qt/css1/box_properties/padding_right_inline-expected.txt:
platform/qt/css1/box_properties/padding_top-expected.txt:
platform/qt/css1/box_properties/padding_top_inline-expected.txt:
platform/qt/css1/box_properties/width-expected.txt:
platform/qt/css1/cascade/cascade_order-expected.txt:
platform/qt/css1/cascade/important-expected.txt:
platform/qt/css1/classification/display-expected.txt:
platform/qt/css1/classification/list_style-expected.txt:
platform/qt/css1/classification/list_style_image-expected.txt:
platform/qt/css1/classification/list_style_position-expected.txt:
platform/qt/css1/classification/list_style_type-expected.txt:
platform/qt/css1/classification/white_space-expected.txt:
platform/qt/css1/color_and_background/background-expected.txt:
platform/qt/css1/color_and_background/background_attachment-expected.txt:
platform/qt/css1/color_and_background/background_color-expected.txt:
platform/qt/css1/color_and_background/background_image-expected.txt:
platform/qt/css1/color_and_background/background_position-expected.txt:
platform/qt/css1/color_and_background/background_repeat-expected.txt:
platform/qt/css1/color_and_background/color-expected.txt:
platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
platform/qt/css1/font_properties/font-expected.txt:
platform/qt/css1/font_properties/font_family-expected.txt:
platform/qt/css1/font_properties/font_size-expected.txt:
platform/qt/css1/font_properties/font_style-expected.txt:
platform/qt/css1/font_properties/font_variant-expected.txt:
platform/qt/css1/font_properties/font_weight-expected.txt:
platform/qt/css1/formatting_model/canvas-expected.txt:
platform/qt/css1/formatting_model/floating_elements-expected.txt:
platform/qt/css1/formatting_model/height_of_lines-expected.txt:
platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
platform/qt/css1/formatting_model/inline_elements-expected.txt:
platform/qt/css1/formatting_model/replaced_elements-expected.txt:
platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
platform/qt/css1/pseudo/anchor-expected.txt:
platform/qt/css1/pseudo/firstletter-expected.txt:
platform/qt/css1/pseudo/firstline-expected.txt:
platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
platform/qt/css1/text_properties/letter_spacing-expected.txt:
platform/qt/css1/text_properties/line_height-expected.txt:
platform/qt/css1/text_properties/text_align-expected.txt:
platform/qt/css1/text_properties/text_decoration-expected.txt:
platform/qt/css1/text_properties/text_indent-expected.txt:
platform/qt/css1/text_properties/text_transform-expected.txt:
platform/qt/css1/text_properties/vertical_align-expected.txt:
platform/qt/css1/text_properties/word_spacing-expected.txt:
platform/qt/css1/units/color_units-expected.txt:
platform/qt/css1/units/length_units-expected.txt:
platform/qt/css1/units/percentage_units-expected.txt:
platform/qt/css1/units/urls-expected.txt:
platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
platform/qt/css2.1/t040103-case-00-b-expected.txt:
platform/qt/css2.1/t040103-case-01-c-expected.txt:
platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
platform/qt/css2.1/t040103-ident-00-c-expected.txt:
platform/qt/css2.1/t040103-ident-01-c-expected.txt:
platform/qt/css2.1/t040103-ident-02-c-expected.txt:
platform/qt/css2.1/t040103-ident-03-c-expected.txt:
platform/qt/css2.1/t040103-ident-04-c-expected.txt:
platform/qt/css2.1/t040103-ident-05-c-expected.txt:
platform/qt/css2.1/t040103-ident-06-c-expected.txt:
platform/qt/css2.1/t040103-ident-07-c-expected.txt:
platform/qt/css2.1/t040103-ident-08-c-expected.txt:
platform/qt/css2.1/t040103-ident-09-c-expected.txt:
platform/qt/css2.1/t040103-ident-10-c-expected.txt:
platform/qt/css2.1/t040103-ident-11-c-expected.txt:
platform/qt/css2.1/t040103-ident-12-c-expected.txt:
platform/qt/css2.1/t040103-ident-13-c-expected.txt:
platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
platform/qt/css2.1/t040105-import-00-b-expected.txt:
platform/qt/css2.1/t040105-import-01-b-expected.txt:
platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
platform/qt/css2.1/t1202-counter-00-b-expected.txt:
platform/qt/css2.1/t1202-counter-01-b-expected.txt:
platform/qt/css2.1/t1202-counter-02-b-expected.txt:
platform/qt/css2.1/t1202-counter-03-b-expected.txt:
platform/qt/css2.1/t1202-counter-04-b-expected.txt:
platform/qt/css2.1/t1202-counter-05-b-expected.txt:
platform/qt/css2.1/t1202-counter-06-b-expected.txt:
platform/qt/css2.1/t1202-counter-07-b-expected.txt:
platform/qt/css2.1/t1202-counter-08-b-expected.txt:
platform/qt/css2.1/t1202-counter-09-b-expected.txt:
platform/qt/css2.1/t1202-counter-11-b-expected.txt:
platform/qt/css2.1/t1202-counter-12-b-expected.txt:
platform/qt/css2.1/t1202-counter-13-b-expected.txt:
platform/qt/css2.1/t1202-counter-14-b-expected.txt:
platform/qt/css2.1/t1202-counter-15-b-expected.txt:
platform/qt/css2.1/t1202-counter-16-f-expected.txt:
platform/qt/css2.1/t1202-counters-00-b-expected.txt:
platform/qt/css2.1/t1202-counters-01-b-expected.txt:
platform/qt/css2.1/t1202-counters-02-b-expected.txt:
platform/qt/css2.1/t1202-counters-03-b-expected.txt:
platform/qt/css2.1/t1202-counters-05-b-expected.txt:
platform/qt/css2.1/t1202-counters-06-b-expected.txt:
platform/qt/css2.1/t1202-counters-07-b-expected.txt:
platform/qt/css2.1/t1202-counters-08-b-expected.txt:
platform/qt/css2.1/t1202-counters-09-b-expected.txt:
platform/qt/css2.1/t1202-counters-11-b-expected.txt:
platform/qt/css2.1/t1202-counters-12-b-expected.txt:
platform/qt/css2.1/t1202-counters-13-b-expected.txt:
platform/qt/css2.1/t1202-counters-14-b-expected.txt:
platform/qt/css2.1/t1202-counters-15-b-expected.txt:
platform/qt/css2.1/t1202-counters-16-c-expected.txt:
platform/qt/css2.1/t1202-counters-17-d-expected.txt:
platform/qt/css2.1/t1202-counters-18-f-expected.txt:
platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
platform/qt/fast/backgrounds/001-expected.txt:
platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt:
platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
platform/qt/fast/backgrounds/background-origin-root-element-expected.txt:
platform/qt/fast/backgrounds/background-position-1-expected.txt:
platform/qt/fast/backgrounds/background-position-rounding-expected.txt:
platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
platform/qt/fast/backgrounds/mask-composite-expected.txt:
platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
platform/qt/fast/backgrounds/size/zero-expected.txt:
platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
platform/qt/fast/backgrounds/svg-as-background-1-expected.txt:
platform/qt/fast/backgrounds/svg-as-background-2-expected.txt:
platform/qt/fast/backgrounds/svg-as-background-3-expected.txt:
platform/qt/fast/backgrounds/svg-as-background-4-expected.txt:
platform/qt/fast/backgrounds/svg-as-background-5-expected.txt:
platform/qt/fast/backgrounds/svg-as-background-6-expected.txt:
platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
platform/qt/fast/borders/border-radius-constraints-expected.txt:
platform/qt/fast/borders/border-radius-split-inline-expected.txt:
platform/qt/fast/box-shadow/basic-shadows-expected.txt:
platform/qt/fast/box-shadow/inset-expected.txt:
platform/qt/fast/box-shadow/transform-fringing-expected.txt:
platform/qt/fast/canvas/canvas-before-css-expected.txt:
platform/qt/fast/canvas/canvas-composite-expected.txt:
platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt:
platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
platform/qt/fast/canvas/canvas-zoom-expected.txt:
platform/qt/fast/canvas/drawImage-expected.txt:
platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt:
platform/qt/fast/canvas/image-pattern-rotate-expected.txt:
platform/qt/fast/canvas/shadow-offset-1-expected.txt:
platform/qt/fast/canvas/shadow-offset-2-expected.txt:
platform/qt/fast/canvas/shadow-offset-3-expected.txt:
platform/qt/fast/canvas/shadow-offset-4-expected.txt:
platform/qt/fast/canvas/shadow-offset-5-expected.txt:
platform/qt/fast/canvas/shadow-offset-6-expected.txt:
platform/qt/fast/canvas/shadow-offset-7-expected.txt:
platform/qt/fast/css/attribute-selector-dynamic-expected.txt:
platform/qt/fast/css/font-smoothing-expected.txt:
platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt:
platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
platform/qt/fast/css/nth-child-dynamic-expected.txt:
platform/qt/fast/css/pseudo-cache-stale-expected.txt:
platform/qt/fast/css/rem-dynamic-scaling-expected.txt:
platform/qt/fast/css/rem-units-on-root-expected.txt:
platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/qt/fast/css/text-rendering-expected.txt:
platform/qt/fast/doctypes/001-expected.txt:
platform/qt/fast/doctypes/002-expected.txt:
platform/qt/fast/doctypes/004-expected.txt:
platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
platform/qt/fast/dynamic/anchor-lock-expected.txt:
platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
platform/qt/fast/dynamic/window-scrollbars-test-expected.txt:
platform/qt/fast/forms/basic-buttons-expected.txt:
platform/qt/fast/forms/basic-inputs-expected.txt:
platform/qt/fast/forms/button-style-color-expected.txt:
platform/qt/fast/forms/isindex-placeholder-expected.txt:
platform/qt/fast/forms/menulist-style-color-expected.txt:
platform/qt/fast/forms/search-vertical-alignment-expected.txt:
platform/qt/fast/forms/text-style-color-expected.txt:
platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
platform/qt/fast/frames/frame-navigation-expected.txt:
platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
platform/qt/fast/frames/frameset-style-recalc-expected.txt:
platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
platform/qt/fast/gradients/crash-on-zero-radius-expected.txt:
platform/qt/fast/history/clicked-link-is-visited-expected.txt:
platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
platform/qt/fast/images/image-in-map-expected.txt:
platform/qt/fast/images/svg-as-background-expected.txt:
platform/qt/fast/images/svg-width-100p-as-background-expected.txt:
platform/qt/fast/lists/ol-start-parsing-expected.txt:
platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
platform/qt/fast/text/international/hindi-whitespace-expected.txt:
platform/qt/fast/text/international/khmer-selection-expected.txt:
platform/qt/fast/text/shadow-translucent-fill-expected.txt:
platform/qt/fast/text/text-letter-spacing-expected.txt:
platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
platform/qt/fast/xsl/document-function-expected.txt:
platform/qt/plugins/netscape-dom-access-expected.txt:
platform/qt/svg/custom/createImageElement2-expected.txt:
platform/qt/svg/filters/feComposite-expected.txt:
platform/qt/svg/filters/sourceAlpha-expected.txt:
platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
platform/qt/tables/mozilla/bugs/bug196870-expected.txt:
platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/qt/tables/mozilla/other/slashlogo-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:

6:05 AM Changeset in webkit [50877] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-12 Richard Moe Gustavsen <richard.gustavsen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable pthread_setname_np.

This allows Qt builds on Mac from 10.6 to run on earlier version
where this symbol is not present.
https://bugs.webkit.org/show_bug.cgi?id=31403

wtf/Platform.h:

5:52 AM Changeset in webkit [50876] by eric@webkit.org

7 edits in trunk

2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042

This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.

page/PrintContext.cpp: (WebCore::PrintContext::begin):
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h:

2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042

This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

5:28 AM Changeset in webkit [50875] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Resource errors/warnings not shown in the Resource tree.

Error/Warning bubbles are not displayed next to the resource in the
Resources panel if those occur before the resource is attached to the tree.
https://bugs.webkit.org/show_bug.cgi?id=31404

Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.removeItem):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.onattach):

4:44 AM Changeset in webkit [50874] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-12 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix linking on Linux 32-bit.

It was missing the ".text" directive at the top of the file,
indicating that code would follow. Without it, the assembler created
"NOTYPE" symbols, which would result in linker errors.
https://bugs.webkit.org/show_bug.cgi?id=30863

jit/JITStubs.cpp:

2:39 AM Changeset in webkit [50873] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

Follow-up of r50726, don't block the UI thread when calling
gst_element_get_state(). Also fixed a compilation warning and some
static casts.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::playbackPosition): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setRate):

2:32 AM Changeset in webkit [50872] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

don't pause pipeline if already paused, same for play()

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause):

1:03 AM Changeset in webkit [50871] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-12 Kinuko Yasuda <kinuko@google.com>

Reviewed by David Levin.

Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
Chromium too.
https://bugs.webkit.org/show_bug.cgi?id=31292

No new tests. (Corresponding test for Gtk+ is
platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)

page/EventHandler.cpp:
page/chromium/EventHandlerChromium.cpp:

12:37 AM Changeset in webkit [50870] by hamaji@chromium.org

4 edits in trunk/LayoutTests

2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed test fix by skipping a new test introduced in
https://bugs.webkit.org/show_bug.cgi?id=22249

platform/gtk/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

12:15 AM Changeset in webkit [50869] by hamaji@chromium.org

6 edits
4 adds in trunk

2009-11-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Prevent text inside a multi-column block from being split into columns.

If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.

CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

fast/multicol/single-line.html: Added.
fast/multicol/single-line-expected.checksum: Added.
fast/multicol/single-line-expected.png: Added.
fast/multicol/single-line-expected.txt: Added.

2009-11-12 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Prevent text inside a multi-column block from being split into columns.

If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.

CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

Test: fast/multicol/single-line.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns):
rendering/RenderBlock.h:
rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
rendering/RenderView.h: (WebCore::RenderView::setTruncatedAt): (WebCore::RenderView::setMinimumColumnHeight): (WebCore::RenderView::minimumColumnHeight):

Nov 11, 2009:

10:43 PM Changeset in webkit [50868] by tkent@chromium.org

6 edits
2 adds in trunk

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

A test for a bug that RenderFileUploadControl isn't initialized with
multiple files. This test is skipped on ports which have no
eventSender.beginDragWithFiles().
https://bugs.webkit.org/show_bug.cgi?id=31195

fast/forms/input-file-re-render.html: Added.
platform/gtk/Skipped:
platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
platform/mac/fast/forms/input-file-re-render-expected.png: Added.
platform/mac/fast/forms/input-file-re-render-expected.txt: Added.
platform/qt/Skipped:
platform/win/Skipped:

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
https://bugs.webkit.org/show_bug.cgi?id=31195

Test: fast/forms/input-file-re-render.html

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl):

9:58 PM Changeset in webkit [50867] by dumi@chromium.org

2 edits in trunk/WebCore

Fixing Chromium's POSIX VFS implementation, by adding the required
"used file descriptors" logic.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31275

platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

9:46 PM Changeset in webkit [50866] by dbates@webkit.org

3 edits in trunk/LayoutTests

2009-11-11 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31326

Makes the output for test fast/events/drag-and-drop.html pretty.
Now, it is easier to read for a human to read understand the results.

fast/events/drag-and-drop-expected.txt: Rebased result.
fast/events/drag-and-drop.html: Modified to make the output pretty.

9:26 PM Changeset in webkit [50865] by Chris Fleizach

20 edits
4 adds in trunk

need to implement aria tree roles
https://bugs.webkit.org/show_bug.cgi?id=31284

Reviewed by Oliver Hunt.

WebCore:

Tests: platform/mac/accessibility/aria-multiselectable.html

platform/mac/accessibility/aria-tree.html

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):

accessibility/AccessibilityObject.h:

(WebCore::):
(WebCore::AccessibilityObject::isTree):
(WebCore::AccessibilityObject::isTreeItem):
(WebCore::AccessibilityObject::setIsExpanded):
(WebCore::AccessibilityObject::canSetExpandedAttribute):
(WebCore::AccessibilityObject::hierarchicalLevel):
(WebCore::AccessibilityObject::setSelectedRows):
(WebCore::AccessibilityObject::performDefaultAction):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hierarchicalLevel):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isExpanded):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::isSelected):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::createARIARoleMap):
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
(WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):

accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(RoleEntry::):
(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):

html/HTMLAttributeNames.in:

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(disclosedRowAtIndexCallback):
(selectedRowAtIndexCallback):
(isEqualCallback):
(isAttributeSettableCallback):
(isActionSupportedCallback):
(disclosedByRowCallback):
(hierarchicalLevelCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement::isEqual):

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::disclosedByRow):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::hierarchicalLevel):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::disclosedByRow):

LayoutTests:

accessibility/aria-readonly-expected.txt:
accessibility/aria-readonly.html:
platform/mac/accessibility/aria-multiselectable-expected.txt: Added.
platform/mac/accessibility/aria-multiselectable.html: Added.
platform/mac/accessibility/aria-tree-expected.txt: Added.
platform/mac/accessibility/aria-tree.html: Added.
platform/mac/accessibility/content-editable-expected.txt:
platform/mac/accessibility/radio-button-group-members-expected.txt:

8:31 PM Changeset in webkit [50864] by bfulgham@webkit.org

3 edits in trunk/WebCore

Build fix after @r50760 with ENABLE_FILTERS.

platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.

svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument to fillRect.

8:19 PM Changeset in webkit [50863] by hamaji@chromium.org

4 edits in trunk/WebKitTools

2009-11-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

svn-apply can not handle git binary diffs
https://bugs.webkit.org/show_bug.cgi?id=26830

Support "literal" type git binary diffs.

Scripts/VCSUtils.pm:
Scripts/modules/scm_unittest.py:
Scripts/svn-apply:

8:17 PM Changeset in webkit [50862] by ukai@chromium.org

3 edits
8 adds in trunk

2009-11-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocket frame parser of frame_type with high-order bit set.
https://bugs.webkit.org/show_bug.cgi?id=30668

websocket/tests/frame-length-longer-than-buffer-expected.txt: Added.
websocket/tests/frame-length-longer-than-buffer.html: Added.
websocket/tests/frame-length-longer-than-buffer_wsh.py: Added.
websocket/tests/frame-length-skip-expected.txt: Added.
websocket/tests/frame-length-skip.html: Added.
websocket/tests/frame-length-skip_wsh.py: Added.
websocket/tests/script-tests/frame-length-longer-than-buffer.js: Added.
websocket/tests/script-tests/frame-length-skip.js: Added.

2009-11-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocket frame parser of frame_type with high-order bit set.
https://bugs.webkit.org/show_bug.cgi?id=30668

If buffer is smaller than frame's length, it should break the loop
instead of reading next byte.

Tests: websocket/tests/frame-length-longer-than-buffer.html

websocket/tests/frame-length-skip.html

websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):

8:03 PM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

7:38 PM Changeset in webkit [50861] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Put tests into skiplist added in r50830 and r50839 because
layoutTestController.showWebInspector() is unimplemented now.

platform/qt/Skipped:

7:20 PM Changeset in webkit [50860] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358

Reviewed by Kenneth Christiansen.

Fixed wrong documentation: item's dimensions do fit to Web page
content by default.

Kenneth agreed to land this as a followup patch to the
just landed documentation patch.

Api/qgraphicswebview.cpp:

7:20 PM Changeset in webkit [50859] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-11 Yusuke Sato <yusukes@chromium.org>

Reviewed by Adam Barth.

[chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
https://bugs.webkit.org/show_bug.cgi?id=31345

Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.

platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx(). (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call. (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.

7:20 PM Changeset in webkit [50858] by tonikitoo@webkit.org

3 edits in trunk/WebKit/qt

[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31323

Patch by David Boddie <dboddie@trolltech.com> on 2009-11-11
Reviewed by Kenneth Christiansen.

Fixed and synchronized QWebView related documentation.

Api/qgraphicswebview.cpp:
Api/qwebview.cpp:

7:02 PM Changeset in webkit [50857] by eric@webkit.org

3 edits
1 delete in trunk/LayoutTests

2009-11-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dmitry Titov.

Rewrite the test to run on a wider variety of screen configurations
(and pixel depths).

https://bugs.webkit.org/show_bug.cgi?id=31373

fast/dom/Window/window-screen-properties-expected.txt:
fast/dom/Window/window-screen-properties.html:
platform/win/fast/dom/Window/window-screen-properties-expected.txt: Removed.

6:31 PM Changeset in webkit [50856] by Beth Dakin

2 edits in trunk/WebKit/win

Build fix. No review needed.

WebKitGraphics.cpp:

(WebDrawText):

6:30 PM Changeset in webkit [50855] by Beth Dakin

2 edits in trunk/WebCore

Build fix. No review needed.

platform/graphics/gtk/FontGtk.cpp:

(WebCore::Font::drawComplexText):

6:19 PM Changeset in webkit [50854] by Beth Dakin

2 edits in trunk/WebCore

Build fix. No review needed.

platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):

6:13 PM Changeset in webkit [50853] by Beth Dakin

2 edits in trunk/WebCore

Windows build fix. No review needed.

platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

5:51 PM Changeset in webkit [50852] by Beth Dakin

19 edits
8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
Make -webkit-color-correction work with shadows

Reviewed by Simon Fraser.

From canvas, just send DeviceColorSpace to setShadow() for now.
Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):

setShadow() and setPlatformShadow() now take a ColorSpace.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setShadow):

platform/graphics/GraphicsContext.h:
platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::createCGColorWithColorSpace): New helper to create a
color in a ColorSpace.
(WebCore::setCGFillColor): Call new helper.
(WebCore::setCGStrokeColor): Call new helper.
(WebCore::GraphicsContext::setPlatformShadow): Call new helper.

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

Send appropriate ColorSpace to setShadow().

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintTextDecorations):

rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paintDecoration):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintCharacters):

rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

Attempt to keep ports building.

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31382
Make -webkit-color-correction work with shadows

Reviewed by Simon Fraser.

fast/css/color-correction-on-box-shadow.html: Added.
fast/css/color-correction-on-text-shadow.html: Added.
platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
platform/mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
platform/mac/fast/css/color-correction-on-box-shadow-expected.txt: Added.
platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum: Added.
platform/mac/fast/css/color-correction-on-text-shadow-expected.png: Added.
platform/mac/fast/css/color-correction-on-text-shadow-expected.txt: Added.

5:46 PM Changeset in webkit [50851] by eric@webkit.org

18 edits in trunk

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Print the file text of a file upload control in DumpRenderTree for ease of tests.
https://bugs.webkit.org/show_bug.cgi?id=31195

platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
platform/mac/fast/forms/box-shadow-override-expected.txt:
platform/mac/fast/forms/file-input-direction-expected.txt:
platform/mac/fast/forms/file-input-disabled-expected.txt:
platform/mac/fast/forms/form-element-geometry-expected.txt:
platform/mac/fast/forms/hidden-input-file-expected.txt:
platform/mac/fast/forms/input-appearance-height-expected.txt:
platform/mac/fast/forms/input-value-expected.txt:
platform/win/fast/forms/box-shadow-override-expected.txt:
platform/win/fast/forms/file-input-disabled-expected.txt:
platform/win/fast/forms/input-appearance-height-expected.txt:
platform/win/fast/forms/input-value-expected.txt:

2009-11-11 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Print the file text of a file upload control in DumpRenderTree for ease of tests.
https://bugs.webkit.org/show_bug.cgi?id=31195

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::fileTextValue):
rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::isFileUploadControl): (WebCore::toRenderFileUploadControl):
rendering/RenderObject.h: (WebCore::RenderObject::isFileUploadControl):
rendering/RenderTreeAsText.cpp: (WebCore::operator<<):

5:36 PM QtBackLog edited by zecke@selfish.org

(diff)

5:00 PM Changeset in webkit [50850] by barraclough@apple.com

8 edits in trunk/WebCore

DOM Wrappers for some nodes may not be marked.
https://bugs.webkit.org/show_bug.cgi?id=31380

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-11
Reviewed by Sam Weinig.

Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
the wrapper for the current world only. This means that wrappers may be GC'ed
prematurely, and properties lost.

Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.

bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::markChildren):

bindings/js/JSDOMBinding.cpp:

(WebCore::markDOMNodeWrapper):

bindings/js/JSDOMBinding.h:
bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::markChildren):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::markChildren):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::markChildren):

4:55 PM Changeset in webkit [50849] by jorlow@chromium.org

2 edits in trunk/WebKit/chromium

Not reviewed. Build fix. Will be cleaned up in subsequent patch once we know exaclty what's going on.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-11

src/WebBindings.cpp:

4:39 PM Changeset in webkit [50848] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-11 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
https://bugs.webkit.org/show_bug.cgi?id=31384

No functionality change so no tests required.

bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.

4:19 PM Changeset in webkit [50847] by dimich@chromium.org

2 edits in trunk/WebKitTools

Not reviewed, removing duplicate entry for myself in committers.py.

Scripts/modules/committers.py:

4:11 PM Changeset in webkit [50846] by snej@chromium.org

4 edits in trunk/WebCore

The Big De-Inlining. 450k code size reduction (32-bit x86.)

Various inline functions in V8Binding.h made non-inline.
Some renaming for consistency.
New function createRawTemplate().

https://bugs.webkit.org/show_bug.cgi?id=31383

Reviewed by Dimitri Glazkov.

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Binding.cpp:

(WebCore::v8DOMWrapperToNative):
(WebCore::v8ValueToWebCoreString):
(WebCore::v8ValueToAtomicWebCoreString):
(WebCore::toInt32):
(WebCore::toWebCoreString):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toAtomicWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::isUndefinedOrNull):
(WebCore::v8Boolean):
(WebCore::v8UndetectableString):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
(WebCore::v8StringToWebCoreString):
(WebCore::v8ExternalString):
(WebCore::createRawTemplate): New function.

bindings/v8/V8Binding.h:

(WebCore::v8DOMWrapperTo):
(WebCore::v8DOMWrapperToNode):
(WebCore::v8StringToWebCoreString):
(WebCore::v8StringToAtomicWebCoreString):

3:56 PM Changeset in webkit [50845] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Dmitri Titov.

Fix layout test to not call onload on the wrong window after image has
been dropped onto the iframe.
https://bugs.webkit.org/show_bug.cgi?id=30893

editing/selection/drag-to-contenteditable-iframe.html:

3:12 PM WebKit Team edited by dimich@chromium.org

(diff)

2:54 PM Changeset in webkit [50844] by snej@chromium.org

4 edits in trunk/WebCore

More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
event-listener setter into a new subroutine transferHiddenDependency().
https://bugs.webkit.org/show_bug.cgi?id=31377

Reviewed by Dimitri Glazkov.

bindings/scripts/CodeGeneratorV8.pm: Replace boilerplate with call to transferHiddenDependency().
bindings/v8/V8Utilities.cpp:

(WebCore::transferHiddenDependency): New.

bindings/v8/V8Utilities.h: Declaration of transferHiddenDependency.

2:49 PM Changeset in webkit [50843] by bweinstein@apple.com

4 edits in trunk

WebCore: If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
because there is a CG bug preventing this from working.

Reviewed by Beth Dakin.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):

LayoutTests: Unskip the webkit-color-correction tests because the workaround of using
the deviceRGBColorSpace allows the tests to pass on Windows.

Reviewed by Beth Dakin.

platform/win/Skipped:

2:07 PM Changeset in webkit [50842] by ap@apple.com

2 edits in trunk/WebKitTools

Reviewed by Darin Adler and Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=31200
Tests in http/tests/security/mixedContent start to fail when new tests are added

DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.

1:57 PM Changeset in webkit [50841] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Skip the webkit-color-correction tests because they crash on Windows
due to a CoreGraphics bug.

Reviewed by Darin Adler.

platform/win/Skipped:

1:37 PM Changeset in webkit [50840] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Check that if Storage panel exists before calling its methods

https://bugs.webkit.org/show_bug.cgi?id=31343

inspector/front-end/inspector.js: (WebInspector.addDatabase): (WebInspector.addCookieDomain): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage):

1:35 PM Changeset in webkit [50839] by eric@webkit.org

1 edit
10 adds in trunk/LayoutTests

2009-11-11 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Timeline tests for records generated for
Layout, Paint, ParseHTML, MarkTimeline, and Style Recalculation

https://bugs.webkit.org/show_bug.cgi?id=31361

inspector/timeline-layout-expected.txt: Added.
inspector/timeline-layout.html: Added.
inspector/timeline-mark-timeline-expected.txt: Added.
inspector/timeline-mark-timeline.html: Added.
inspector/timeline-paint-expected.txt: Added.
inspector/timeline-paint.html: Added.
inspector/timeline-parse-html-expected.txt: Added.
inspector/timeline-parse-html.html: Added.
inspector/timeline-recalculate-styles-expected.txt: Added.
inspector/timeline-recalculate-styles.html: Added.

1:23 PM Changeset in webkit [50838] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2009-11-11 Drew Wilson <atwilson@chromium.org>

Reviewed by Dimitri Glazkov.

SharedWorkerRepository.connect() does not call WebSharedWorkerRepository
https://bugs.webkit.org/show_bug.cgi?id=31371

Test: Unit tests can be enabled downstream when this lands.

src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::connect): Added missing call to WebSharedWorkerRepository.addSharedWorker().

1:10 PM Changeset in webkit [50837] by kov@webkit.org

2 edits in trunk/WebKitTools

Create, and display a window for the inspector, for inspector tests.

1:10 PM Changeset in webkit [50836] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2009-11-11 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Tiny path fixes in Chromium API includes.

https://bugs.webkit.org/show_bug.cgi?id=31369

public/linux/WebSandboxSupport.h: Fixed path.
src/WebBindings.cpp: Fixed path.

1:09 PM Changeset in webkit [50835] by snej@chromium.org

3 edits in trunk/WebCore

De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
times in the generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=31368

Reviewed by Dimitri Glazkov.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertNodeToV8Object): Moved body here from .h file

bindings/v8/V8DOMWrapper.h: Removed inline method body.

12:20 PM Changeset in webkit [50834] by jberlin@webkit.org

3 edits
2 adds in trunk

WebCore: Display the correct summary in the web inspector for the shorthands
border-color, border-width, border-style, margin, and padding.
https://bugs.webkit.org/show_bug.cgi?id=7987

Reviewed by Timothy Hatcher.

Test: fast/css/shorthands-four-values.html

css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::get4Values):
Display the summary information in the same way the shorthand would be
specified in a css rule.

LayoutTests:

fast/css/shorthands-four-values-expected.txt: Added.
fast/css/shorthands-four-values.html: Added.

12:00 PM Changeset in webkit [50833] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Refactor multiple JavaScriptCore threads
https://bugs.webkit.org/show_bug.cgi?id=31328

Remove the id field from the PlatformThread structure
as it is not used.

runtime/Collector.cpp: (JSC::getCurrentPlatformThread): (JSC::suspendThread): (JSC::resumeThread): (JSC::getPlatformThreadRegisters):

11:57 AM Changeset in webkit [50832] by kenneth@webkit.org

4 edits in trunk

WebKit/qt: Unreviewed buildbot fix.

Export a method to the DRT to know if the document has a
document element.

Api/qwebframe.cpp:

(qt_drt_hasDocumentElement):

WebKitTools: Unreviewed Qt buildbot fix.

My previous fix was wrong, so revert that change and fix it by
returning when the document of the frame has no document element.
Idea is borrowed from mac and win DRT.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::dumpFramesAsText):

11:53 AM Changeset in webkit [50831] by snej@chromium.org

2 edits in trunk/WebCore

Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
meaning to the caller, saves code, and appears to save a few cycles at runtime too.
https://bugs.webkit.org/show_bug.cgi?id=31367

Reviewed by Dimitri Glazkov.

bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"

11:51 AM Changeset in webkit [50830] by eric@webkit.org

3 edits
1 copy
2 adds in trunk/LayoutTests

2009-11-11 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Added a test of an externally loaded script tag for Inspector
timeline records.
Fixed identity comparisons.

https://bugs.webkit.org/show_bug.cgi?id=31365

inspector/timeline-script-tag-1.html:
inspector/timeline-script-tag-2-expected.txt: Added.
inspector/timeline-script-tag-2.html: Added.
inspector/timeline-script-tag-2.js: Added.
inspector/timeline-test.js: (): (timelineAgentTypeToString):

11:46 AM Changeset in webkit [50829] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-11 Eric Seidel <eric@webkit.org>

Reviewed byg Kenneth Rohde Christiansen.

Update Kenneth's committer record to include the email he
uses on lists.webkit.org.

Scripts/modules/committers.py:

11:23 AM Changeset in webkit [50828] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-11 Eric Seidel <eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

Several committers use separate email addresses for bugzilla and svn.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=31364

Update records for existing committers to include email addresses
used in svn.webkit.org and lists.webkit.org.
Most committers use the same email address in all 3 places, but some use
separate addresses. committers.py needs record of each of these addresses.

Scripts/modules/committers.py:

11:21 AM Changeset in webkit [50827] by tonikitoo@webkit.org

2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Christiansen.

Grouping some of the current skipped plugin tests that fail
due to the same reason: no support for objective-c functions.

platform/qt/Skipped:

11:19 AM Changeset in webkit [50826] by snej@chromium.org

6 edits in trunk/WebCore

Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.

Reviewed by Dimitri Glazkov.

bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrent): Moved getCurrentMainThread to MainThreadDOMData::getCurrent

so it can be inlined by its caller.

bindings/v8/DOMData.h:
bindings/v8/MainThreadDOMData.cpp:

(WebCore::MainThreadDOMData::getCurrent): Moved here from DOMData.cpp.
(WebCore::MainThreadDOMData::getMainThreadStore): Added UNLIKELY macro to improve codegen.
(WebCore::MainThreadDOMData::getCurrentMainThreadStore): Combination of getCurrentMainThread

and getStore, which inline both calls together.

bindings/v8/MainThreadDOMData.h:

(WebCore::MainThreadDOMData::getStore): Broke out nonvirtual getMainThreadStore for inlineability.

bindings/v8/V8DOMMap.cpp:

(WebCore::getDOMNodeMap): Call new getCurrentMainThreadStore, which is faster.

11:04 AM Changeset in webkit [50825] by dbates@webkit.org

3 edits in trunk/LayoutTests

2009-11-11 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31334

We should skip the test case /fast/events/drag-and-drop-fire-drag-dragover.html
on both the Qt and GTK builds since there are issues with drag-and-drop support
in these builds.

For Qt: https://bugs.webkit.org/show_bug.cgi?id=31332
For GTK: https://bugs.webkit.org/show_bug.cgi?id=30576

platform/gtk/Skipped: Skip test case /fast/events/drag-and-drop-fire-drag-dragover.html since there are issues with drag-and-drop support in both GTK and Qt.
platform/qt/Skipped: Ditto.

10:45 AM Changeset in webkit [50824] by kenneth@webkit.org

2 edits in trunk/WebKitTools

If the frame has no innerText don't append it, and
do not add a newline which breaks some cross platform
results.

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::dumpFramesAsText):

10:44 AM Changeset in webkit [50823] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Fix a crash in the layout test plugins/document-open.html

Reviewed by Simon Hausmann.

Api/qwebframe.cpp:

(QWebFrame::toPlainText):

10:43 AM Changeset in webkit [50822] by eric@webkit.org

5 edits in trunk/WebKit/qt

2009-11-11 Liang QI <liang.qi@nokia.com>

[Qt] Fix tst_qwebpage and tst_qwebframe compilation on Symbian.

tests/qwebframe/qwebframe.pro:
tests/qwebframe/tst_qwebframe.cpp:
tests/qwebpage/qwebpage.pro:
tests/qwebpage/tst_qwebpage.cpp:

10:39 AM Changeset in webkit [50821] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-11 Eric Seidel <eric@webkit.org>

No review, adding second email address for an existing committer.

Add Yong Li's second bugzilla account to his committer record.
See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27

Scripts/modules/committers.py:

10:36 AM Changeset in webkit [50820] by Nate Chapin

3 edits in trunk/WebKit/chromium

2009-11-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

http://trac.webkit.org/changeset/50811 removed some methods from
platform/network/SocketStreamHandleClient.h, so remove them
here too.

https://bugs.webkit.org/show_bug.cgi?id=31360

public/WebSocketStreamHandleClient.h:
src/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::send):

10:32 AM Changeset in webkit [50819] by Nate Chapin

2 edits in trunk/WebCore

2009-11-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.

https://bugs.webkit.org/show_bug.cgi?id=31357

platform/KURLGoogle.cpp: (WebCore::isSchemeFirstChar): (WebCore::isSchemeChar): (WebCore::KURL::hasPort): (WebCore::KURL::removePort): (WebCore::protocolIsValid):

10:31 AM Changeset in webkit [50818] by Simon Hausmann

3 edits in trunk/WebKit/qt

[Qt] Regression: Preserve the parent of plugin objects when using
QtWebKit with only a QWebPage.

Reviewed by Tor Arne Vestbø.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin): Don't reparent
plugins to 0.

tests/qwebpage/tst_qwebpage.cpp:

(PluginCounterPage::PluginCounterPage): Initialize m_pluginParent to 0.
(PluginCounterPage::~PluginCounterPage): Delete the plugin parent later
(after the page)
(PluginTracerPage::createPlugin): Assign a dummy parent to the plugin.
(PluginTracerPage::PluginTracerPage): Set up the plugin parent.
(tst_QWebPage::createViewlessPlugin): Verify that for viewless pages the
plugin parent remains unchanged.

10:21 AM Changeset in webkit [50817] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-11-11 David Boddie <dboddie@trolltech.com>

[Qt] Doc: Added internal or hidden placeholder documentation.

Api/qwebpage.cpp:

10:15 AM Changeset in webkit [50816] by bfulgham@webkit.org

2 edits in trunk/WebCore

Build fix, no reviewed.

Correct setPlatformFillColor and setPlatformStrokeColor calls
to match new ColorSpace-supporting signatures.

platform/graphics/win/GraphicsContextCairoWin.cpp: Add the color space to the set[...]Color calls.

10:14 AM Changeset in webkit [50815] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-11-11 Martin Smith <msmith@trolltech.com>

[Qt] doc: Changed Trolltech to Nokia

Api/qwebview.cpp:

10:06 AM Changeset in webkit [50814] by Nate Chapin

3 edits in trunk/WebKit/chromium

2009-11-11 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

Remove some additional references to dragSourceMovedTo() not
needed after http://trac.webkit.org/changeset/50786.

https://bugs.webkit.org/show_bug.cgi?id=31354

public/WebView.h:
src/WebViewImpl.h:

9:51 AM Changeset in webkit [50813] by eric@webkit.org

2 edits
1 add
3 deletes in trunk/LayoutTests

2009-11-11 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Convert LayoutTests/fast/inline/dirtyLinesForInline.html into dumpAsText.

This test checks if the browser crashes after some operations. It doesn't test
any other interesting features, so we can safely make it a dumpAsText test.

https://bugs.webkit.org/show_bug.cgi?id=31335

fast/inline/dirtyLinesForInline-expected.txt: Added.
fast/inline/dirtyLinesForInline.html: Added dumpAsText().
platform/mac/fast/inline/dirtyLinesForInline-expected.checksum: Removed.
platform/mac/fast/inline/dirtyLinesForInline-expected.png: Removed.
platform/mac/fast/inline/dirtyLinesForInline-expected.txt: Removed.

9:33 AM Changeset in webkit [50812] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Implement missing functionality in the Gtk/Qt TestNetscapePlugin.

Reviewed by Simon Hausmann.

DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_destroy_stream):

9:22 AM Changeset in webkit [50811] by ap@apple.com

4 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=31327
Clean up SocketStreamHandleClient interface

No change in behavior.

platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData. (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by the only client (WebSocketChannel), and it's not clear what this callback's semantics should be. (WebCore::SocketStreamHandleClient::willSendData): Ditto. (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced. For ResourceHandle, this method is called when the user cancels authentication sheet, not when something happens with the stream.

websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.

websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related callbacks have no real implementation yet.

9:06 AM Changeset in webkit [50810] by zoltan@webkit.org

11 edits in trunk/WebCore

Allow custom memory allocation control for the part of page directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31350

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class DragController - instantiated at: WebCore/page/Page.cpp:107
class FocusController - instantiated at: WebCore/page/Page.cpp:109
class Settings - instantiated at: WebCore/page/Page.cpp:116
class PluginHalter - instantiated at: WebCore/page/Page.cpp:160
struct ScheduledEvent - instantiated at: WebCore/page/FrameView.cpp:1275
class UserScript - instantiated at: WebCore/page/PageGroup.cpp:208
struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
class XSSAuditor - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
class UserStyleSheet - instantiated at: WebCore/page/PageGroup.cpp:222

Inherits PropertyWrapperBase class from Noncopyable because (its child class)
PropertyWrapper is instantiated by 'new' in
WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.

page/DragController.h:
page/EventHandler.h:
page/FocusController.h:
page/FrameView.cpp:
page/PluginHalter.h:
page/Settings.h:
page/UserScript.h:
page/UserStyleSheet.h:
page/XSSAuditor.h:
page/animation/AnimationBase.cpp:

9:05 AM Changeset in webkit [50809] by eric@webkit.org

2 edits
3 adds in trunk/LayoutTests

2009-11-11 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test that dumps the timeline data for a simple script tag.

https://bugs.webkit.org/show_bug.cgi?id=31204

inspector/inspector-test.js: (onload):
inspector/timeline-script-tag-1-expected.txt: Added.
inspector/timeline-script-tag-1.html: Added.
inspector/timeline-test.js: Added. (retrieveTimelineData): (): (dumpTimelineRecords): (printTimelineRecordProperties): (isNonDeterministicProp): (printProps): (isTimelineOverheadRecord): (markTimelineRecordAsOverhead): (timelineAgentTypeToString): (frontend_startTimelineProfiler.window.WebInspector.addRecordToTimeline): (frontend_startTimelineProfiler): (frontend_getTimelineResults): (frontend_setup):

9:03 AM Changeset in webkit [50808] by Nate Chapin

2 edits in trunk/WebKit/chromium

2009-11-11 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Remove WebViewImpl::dragSourceMovedTo(), as it is no longer
needed after http://trac.webkit.org/changeset/50786.

https://bugs.webkit.org/show_bug.cgi?id=31354

src/WebViewImpl.cpp:

8:02 AM Changeset in webkit [50807] by vestbo@webkit.org

1 edit in trunk/JavaScriptCore/jsc.pro

Qt build fix on Mac OS X

6:45 AM Changeset in webkit [50806] by eric@webkit.org

4 edits in trunk

2009-11-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31323
Fix a few compiler warnings

No new tests as there is no new functionality.

editing/htmlediting.cpp: (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings

2009-11-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31323
Fix a few compiler warnings

tests/qwebframe/tst_qwebframe.cpp: Add extra brackets to make it explicit where the else case belongs

6:19 AM Changeset in webkit [50805] by vestbo@webkit.org

3 edits in trunk/WebKitTools

[Qt] Force -graphicssystem raster and -style windows when running DRT

Reviewed by Simon Hausmann.

DumpRenderTree/qt/main.cpp:
Scripts/run-webkit-tests:

6:11 AM Changeset in webkit [50804] by kenneth@webkit.org

4 edits in trunk

WebCore: Set m_hasPendingGeometryChange to true by default, so that
at least one call to NPP_SetWindow is executed, which is
needed by the DRT plugin testing framework.

Reviewed by Mark Rowe.

plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

WebKitTools: Implement the functionality needed by plugins/window-open.html

Reviewed by Mark Rowe.

DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
(webkit_test_plugin_set_window):

6:00 AM Changeset in webkit [50803] by Csaba Osztrogonác

2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31348
[Qt] Remove unnecessary LUT creator from WebCore.pro

WebCore.pro:

5:31 AM Changeset in webkit [50802] by vestbo@webkit.org

2 edits in trunk/WebKitTools

Compute correct library paths for Qt

Reviewed by Simon Hausmann.

Scripts/webkitdirs.pm:

5:19 AM Changeset in webkit [50801] by Simon Hausmann

6 edits in trunk

WebCore: Introduce a function for querying the input method status
in QWebPageClient.

Reviewed by Tor Arne Vestbø.

platform/qt/QWebPageClient.h:

WebKit/qt: Fix enabling of software input panel when activating editable elements
in QGraphicsWebView.

Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::inputMethodEnabled): Implement method to
query for input method support.

Api/qwebpage.cpp:

(QWebPageWidgetClient::inputMethodEnabled): Ditto for QWidget.
(QWebPagePrivate::handleSoftwareInputPanel): Don't use view() to
test for input method support. Instead query using QWebPageClient
and send the SIPR event to the ownerWidget() instead of the view().
The latter is null for QGraphicsWebView.

tests/qwebpage/tst_qwebpage.cpp:

(EventSpy::EventSpy):
(EventSpy::eventFilter):
(tst_QWebPage::inputMethods): Modify the test to verify that SIPR
events are dispatched when activating focusable content.

4:57 AM Changeset in webkit [50800] by kov@webkit.org

2 edits in trunk/LayoutTests

Unreviewed. Skipping new tests.

4:44 AM Changeset in webkit [50799] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Holger Freyther.

Should not print javascript console messages to stdout
https://bugs.webkit.org/show_bug.cgi?id=31346

webkit/webkitwebview.cpp:

(webkit_web_view_real_console_message): Print console messages to
stderr instead, using the recommended method (a g_log variant).

4:34 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

3:24 AM Changeset in webkit [50798] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-11 Benjamin Otte <otte@gnome.org>

Reviewed by Jan Alonzo.

[GTK] Black artifacts in youtube.com/html5

Paint the video to the given size. It's the job of the callers to keep
track of aspect ratio. RenderVideo.cpp does it for the <video>
element.
https://bugs.webkit.org/show_bug.cgi?id=30925

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):

3:17 AM Changeset in webkit [50797] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30901
[Gtk] Need to de-lint the Atk a11y code

Cleaned up some missed capitalization style-guideline violations.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

1:38 AM Changeset in webkit [50796] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Eric Seidel.

[Qt] Make the default style background color valid.
Currently the color is transparent but invalid, this causes
list boxes in QtWebKit to be drawn with a black background
since r49242.
https://bugs.webkit.org/show_bug.cgi?id=31295

rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialBackgroundColor):
rendering/style/StyleBackgroundData.cpp: (WebCore::StyleBackgroundData::StyleBackgroundData):

1:23 AM Changeset in webkit [50795] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2009-11-11 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Levin.

Add a test for web socket handshake error.

https://bugs.webkit.org/show_bug.cgi?id=31336

websocket/tests/handshake-error-expected.txt: Added.
websocket/tests/handshake-error.html: Added.
websocket/tests/handshake-error_wsh.py: Added.
websocket/tests/script-tests/handshake-error.js: Added. (endTest): (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):

12:45 AM Changeset in webkit [50794] by eric@webkit.org

5 edits
8 adds in trunk/LayoutTests

2009-11-11 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Levin.

Add a simple web socket test. This tests basic features of Web Socket.
This also serves as an example of Web Socket tests.

https://bugs.webkit.org/show_bug.cgi?id=27492

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
websocket/tests/resources/simple.js: Added. (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):
websocket/tests/simple-expected.txt: Added.
websocket/tests/simple.html: Added.
websocket/tests/simple_wsh.py: Added.

12:36 AM Changeset in webkit [50793] by eric@webkit.org

4 edits in trunk

2009-11-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30221
[GTK] fails to load media embedded in iframe element

platform/gtk/Skipped: Unskip fixed tests.

2009-11-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30221
[GTK] fails to load media embedded in iframe element

The FrameLoader can show Media if the audio/video support is
enabled at compile time.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::canShowMIMEType):

Nov 10, 2009:

11:56 PM Changeset in webkit [50792] by barraclough@apple.com

8 edits in trunk/WebCore

Simplify the ownership model for worlds - rather than having a pair of weak references
between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
ref pointer to the former. This reduces complexity & cost of the caching entries in the
back forward cache.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-10
Reviewed by Geoff Garen.

WebCore.base.exp:
bindings/js/JSDOMBinding.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

bindings/js/JSDOMBinding.h:

(WebCore::DOMWrapperWorld::forgetDocument):

bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

bindings/js/ScriptCachedFrameData.h:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):

bindings/js/ScriptController.h:

11:30 PM Changeset in webkit [50791] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Linux build fix: Added an #include for UINT_MAX.

runtime/WeakRandom.h:

11:27 PM Changeset in webkit [50790] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

JavaScriptGlue build fix: Marked a file 'private' instead of 'project'.

JavaScriptCore.xcodeproj/project.pbxproj:

11:22 PM Changeset in webkit [50789] by ggaren@apple.com

8 edits
1 add in trunk/JavaScriptCore

Faster Math.random, based on GameRand.

Reviewed by Gavin "avGni arBalroguch" Barraclough.

SunSpider says 1.4% faster.

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj: Added the header to the project.

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h: Use an object to track random number generation

state, initialized to the current time.

runtime/MathObject.cpp:

(JSC::MathObject::MathObject):
(JSC::mathProtoFuncRandom): Use the new hotness.

runtime/WeakRandom.h: Added.

(JSC::WeakRandom::WeakRandom):
(JSC::WeakRandom::get):
(JSC::WeakRandom::advance): The new hotness.

9:51 PM Changeset in webkit [50788] by rolandsteiner@chromium.org

1 edit
49 adds in trunk/LayoutTests

Re-baselined layout test results for Windows for tests in fast/ruby.
(see https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Eric Seidel.

platform/win/fast/ruby: Added.
platform/win/fast/ruby/ruby-empty-rt-expected.checksum: Added.
platform/win/fast/ruby/ruby-empty-rt-expected.png: Added.
platform/win/fast/ruby/ruby-empty-rt-expected.txt: Added.
platform/win/fast/ruby/ruby-length-expected.checksum: Added.
platform/win/fast/ruby/ruby-length-expected.png: Added.
platform/win/fast/ruby/ruby-length-expected.txt: Added.
platform/win/fast/ruby/ruby-run-break-expected.checksum: Added.
platform/win/fast/ruby/ruby-run-break-expected.png: Added.
platform/win/fast/ruby/ruby-run-break-expected.txt: Added.
platform/win/fast/ruby/ruby-runs-expected.checksum: Added.
platform/win/fast/ruby/ruby-runs-expected.png: Added.
platform/win/fast/ruby/ruby-runs-expected.txt: Added.
platform/win/fast/ruby/ruby-runs-spans-expected.checksum: Added.
platform/win/fast/ruby/ruby-runs-spans-expected.png: Added.
platform/win/fast/ruby/ruby-runs-spans-expected.txt: Added.
platform/win/fast/ruby/ruby-simple-expected.checksum: Added.
platform/win/fast/ruby/ruby-simple-expected.png: Added.
platform/win/fast/ruby/ruby-simple-expected.txt: Added.
platform/win/fast/ruby/ruby-simple-rp-expected.checksum: Added.
platform/win/fast/ruby/ruby-simple-rp-expected.png: Added.
platform/win/fast/ruby/ruby-simple-rp-expected.txt: Added.
platform/win/fast/ruby/ruby-trailing-expected.checksum: Added.
platform/win/fast/ruby/ruby-trailing-expected.png: Added.
platform/win/fast/ruby/ruby-trailing-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
platform/win/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.

7:08 PM Changeset in webkit [50787] by hamaji@chromium.org

2 edits in trunk/WebCore

2009-11-10 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

rename counter to makeCounterNode in RenderCounter.cpp
https://bugs.webkit.org/show_bug.cgi?id=31289

No new test because this is just a small refactoring.

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText):

6:52 PM Changeset in webkit [50786] by dbates@webkit.org

12 edits
2 adds in trunk

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Patch 2 of 2.

Removed method EventHandler::dragSourceMovedTo, since it is no longer
needed. This method fired a drag event whenever the mouse moved, but
section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
model independent of when the mouse moves. See "Among other changes..."
in the change log for patch 1 for more details.

WebCore.DragSupport.exp:
page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo. (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
page/EventHandler.h:

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Removed method draggedImage:movedTo:

WebView/WebFrame.mm:
WebView/WebFrameInternal.h:
WebView/WebHTMLView.mm:

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.

WebDropSource.cpp: (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Patch 1 of 2.

As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
the drag event should always fire before the dragover event.

In fixing this bug, this patch also makes our drag processing model
conform to the HTML 5 spec.

Among the changes, this patch ensures that the drag event isn't fired outside
of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
Currently, the drag event is fired whenever the mouse button is down and the OS
detects the mouse moved. But, as per the spec, the drag event should
fire approx. every 350ms so long as the mouse button is down.

Test: fast/events/drag-and-drop-fire-drag-dragover.html

page/EventHandler.cpp: (WebCore::EventHandler::clear): (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget. Modified to determine when we are in the correct instance of EventHandler to service the drag and drop operation. (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo into this method. (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop): (WebCore::EventHandler::clearDragState):
page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether we should fire both drag and dragover events or only the dragover event.

2009-11-10 Daniel Bates <dbates@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=30754

Tests that the drag event always fires before the dragover event.

Also, re-bases the result for test fast/events/drag-in-frames.html, since
we now conform to the HTML 5 spec.

fast/events/drag-and-drop-fire-drag-dragover-expected.txt: Added.
fast/events/drag-and-drop-fire-drag-dragover.html: Added.
fast/events/drag-in-frames-expected.txt: Rebased result.

6:15 PM Changeset in webkit [50785] by eric@webkit.org

6 edits
2 adds in trunk

2009-11-10 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
https://bugs.webkit.org/show_bug.cgi?id=31301

fast/xpath/xpath-detached-iframe-resolver-crash-expected.txt: Added.
fast/xpath/xpath-detached-iframe-resolver-crash.html: Added.

2009-11-10 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
https://bugs.webkit.org/show_bug.cgi?id=31301

Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.

Allowed passing V8Proxy for the calling JS context:

bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getXPathNSResolver):
bindings/v8/custom/V8CustomXPathNSResolver.cpp: (WebCore::V8CustomXPathNSResolver::create): (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
bindings/v8/custom/V8CustomXPathNSResolver.h:
bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

6:07 PM Changeset in webkit [50784] by eric@webkit.org

10 edits
24 adds in trunk

2009-11-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Timothy Hatcher.

Implement URL decomposition IDL attributes for HTMLAnchorElement.
https://bugs.webkit.org/show_bug.cgi?id=29972

Testcases for setting and getting different parts of the URL.

fast/dom/HTMLAnchorElement: Added.
fast/dom/HTMLAnchorElement/script-tests: Added.
fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-port.js: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Added.
fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-host.html: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-port.html: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
fast/dom/HTMLAnchorElement/set-href-attribute-search.html: Added.

2009-11-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Timothy Hatcher.

Implement URL decomposition IDL attributes for HTMLAnchorElement.
https://bugs.webkit.org/show_bug.cgi?id=29972.

Add methods for setting different parts of the URL in href attribute.

Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html

fast/dom/HTMLAnchorElement/set-href-attribute-host.html
fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
fast/dom/HTMLAnchorElement/set-href-attribute-port.html
fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
fast/dom/HTMLAnchorElement/set-href-attribute-search.html

bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setPort):
html/HTMLAnchorElement.cpp: (WebCore::parsePortFromStringPosition): (WebCore::HTMLAnchorElement::setHash): (WebCore::HTMLAnchorElement::setHost): (WebCore::HTMLAnchorElement::setHostname): (WebCore::HTMLAnchorElement::setPathname): (WebCore::HTMLAnchorElement::setPort): (WebCore::HTMLAnchorElement::setProtocol): (WebCore::HTMLAnchorElement::setSearch):
html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:
loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL):
platform/KURL.cpp: (WebCore::KURL::removePort): (WebCore::KURL::setPort): (WebCore::KURL::prettyURL): (WebCore::protocolIsValid):
platform/KURL.h: (WebCore::KURL::canSetHostOrPort): (WebCore::KURL::canSetPathname): (WebCore::KURL::hasPort):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):

5:29 PM Changeset in webkit [50783] by mrowe@apple.com

3 edits in trunk/WebKitTools

<http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added

Reviewed by Sam Weinig.

The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
about the validity of the self-signed certificates used in the regression tests. We would then add the
host to the ignore list for SSL certificate errors and retry the request. If this happened during a test
that had enabled frame load delegate logging this would result in extra log messages being generated,
causing the test to fail.

We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
tests.

DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):

DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

5:24 PM Changeset in webkit [50782] by bweinstein@apple.com

3 edits in trunk/LayoutTests

Update getComputedStyle results for Windows to add -webkit-color-correction.

platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

5:14 PM Changeset in webkit [50781] by Nate Chapin

8 edits in trunk

2009-11-10 Nate Chapin <Nate Chapin>

Unreviewed, Chromium build fix for http://trac.webkit.org/changeset/50760.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::paintBorder): (WebCore::PopupListBox::paint): (WebCore::PopupListBox::paintRow):
platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::setupLayerForWhiteLayer):
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor):
rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): (WebCore::paintMediaVolumeSlider): (WebCore::paintMediaTimelineContainer):
rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMenuListButton):

5:00 PM QtWebKitPerformanceUtilities edited by zecke@selfish.org

(diff)

4:56 PM Changeset in webkit [50780] by eric@webkit.org

1 edit
2 adds
1 delete in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Modified WebKit.gyp to build the webkit api.

https://bugs.webkit.org/show_bug.cgi?id=31320

README: Added.
WebKit.gyp: Added.
webkit.gyp: Removed.

4:46 PM Changeset in webkit [50779] by beidson@apple.com

2 edits in trunk/LayoutTests

Made a small change to my test then didn't update the results before landing.

Reviewed by NOBODY (Fix my own layout-test snafu)

http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:

3:36 PM Changeset in webkit [50778] by beidson@apple.com

4 edits
3 adds in trunk

Repro crash saving pcmag.com article as a webarchive.
<rdar://problem/7381219> and https://webkit.org/b/31322

Reviewed by Sam Weinig.

WebCore:

Test: http/tests/webarchive/cross-origin-stylesheet-crash.html

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead

of creating a CSSRuleList (and subjecting ourselves to the security origin check)

LayoutTests:

http/tests/webarchive/cross-origin-stylesheet-crash.html: Added.
http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive: Added.
http/tests/webarchive/resources/localhost-stylesheet.css: Added.
platform/gtk/Skipped: Add this test to the gtk Skipped list which tracks all individual skipped tests instead of directories.

3:31 PM Changeset in webkit [50777] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add sanity checks to RunScript to ensure it doesn't run when the document hasn't yet
loaded nor when JavaScript is disabled.

https://bugs.webkit.org/show_bug.cgi?id=31309

3:16 PM Changeset in webkit [50776] by Beth Dakin

2 edits in trunk/WebCore

Attempt 2 to fix Tiger build. No review needed.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::deviceRGBColorSpaceRef):
(WebCore::sRGBColorSpaceRef):

3:16 PM Changeset in webkit [50775] by kevino@webkit.org

3 edits in trunk/WebCore

wx build fix. Changes needed after r50760.

3:03 PM Changeset in webkit [50774] by ap@apple.com

2 edits in trunk/WebCore

Qt build fix.

platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).

2:52 PM Changeset in webkit [50773] by Beth Dakin

2 edits in trunk/WebCore

Tiger build fix. No review needed.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):

2:38 PM Changeset in webkit [50772] by ap@apple.com

17 edits
1 add in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=31312
Decouple authentication panel callbacks from ResourceHandle

No change in functionality.

SocketStreamHandle also needs to request credentials, so it's not appropriate to store
ResourceHandle as delegate.

WebCore:

WebCore.vcproj/WebCore.vcproj:
platform/network/AuthenticationClient.h: Added. Added a new interface for listening to authentication panel notifications.

WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what it wants with the project file.

(WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
interface class.
(WebCore::AuthenticationClient::deref): Ditto.

platform/network/ResourceHandle.h: (WebCore::ResourceHandle::refAuthenticationClient): Ditto. (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.

platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient):
platform/network/chromium/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient):
platform/network/curl/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::authenticationClient): Keeping a reference to AuthenticationClient, not to ResourceHandle.

WebKit:

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): (WebURLAuthenticationChallenge::sender):
WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender): (WebURLAuthenticationChallengeSender::createInstance): (WebURLAuthenticationChallengeSender::authenticationClient):
WebURLAuthenticationChallengeSender.h:
WebURLAuthenticationChallengeSenderCFNet.cpp: (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): (WebURLAuthenticationChallengeSender::useCredential): Adjusted for WebCore changes.

2:35 PM Changeset in webkit [50771] by Beth Dakin

2 edits in trunk/WebCore

Second attempted gtk build fix. No review needed.

html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::applyStrokeColor):

2:28 PM Changeset in webkit [50770] by mrowe@apple.com

4 edits in trunk

Versioning.

2:27 PM Changeset in webkit [50769] by mrowe@apple.com

1 copy in tags/Safari-532.4

New tag.

2:22 PM Changeset in webkit [50768] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Anders Carlsson.

Add timing out test to Windows Skipped list.

platform/win/Skipped:

2:21 PM Changeset in webkit [50767] by barraclough@apple.com

6 edits in trunk/WebCore

Fix back/forwards cache with JSC isolated worlds.
https://bugs.webkit.org/show_bug.cgi?id=31310
<rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-10
Reviewed by Geoff Garen.

Store the global object for all worlds, not just the normal world.
Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
so we can forget global objects if a world goes away.

bindings/js/JSDOMBinding.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

bindings/js/JSDOMBinding.h:

(WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
(WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):

bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::forgetWorld):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

bindings/js/ScriptCachedFrameData.h:
bindings/js/ScriptController.h:

2:20 PM Changeset in webkit [50766] by Csaba Osztrogonác

2 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r50760.

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::GraphicsContext):

2:14 PM Changeset in webkit [50765] by Beth Dakin

2 edits in trunk/WebCore

Attempted build fix. (No review needed.)

GNUmakefile.am: Adding ColorSpace.h

2:05 PM Changeset in webkit [50764] by bweinstein@apple.com

9 edits in trunk

WebCore: Updated function calls to take a ColorSpace argument, passing
in DeviceColorSpace for now - this should be fixed. Also added
ColorSpace.h to WebCore project.

Reviewed by NOBODY - Build Fix.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::GraphicsContext):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::paint):

platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButton):

WebKit/win: Updated fillRoundedRect to take a ColorSpace argument.

Reviewed by NOBODY - Build Fix.

WebCoreSupport/WebDragClient.cpp:

(WebDragClient::createDragImageForLink):

2:03 PM Changeset in webkit [50763] by snej@chromium.org

4 edits in trunk/WebCore

Optimizations to Element::getAttribute
https://bugs.webkit.org/show_bug.cgi?id=30926

Reviewed by Darin Adler.

dom/Element.cpp:

(WebCore::Element::getAttribute): User case-insensitive compare instead of lowercasing the name.

dom/NamedAttrMap.cpp:

(WebCore::NamedNodeMap::getAttributeItem): Avoid redundant compares, and do fast/likely compares first.

platform/text/PlatformString.h:

(WebCore::equalPossiblyIgnoringCase): New inline method, used by both of the above.

1:52 PM Changeset in webkit [50762] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Put test into skiplist added in r50758 because
layoutTestController.showWebInspector() is unimplemented now.

platform/qt/Skipped: inspector/timeline-enum-stability.html added.

1:48 PM Changeset in webkit [50761] by kov@webkit.org

2 edits in trunk/LayoutTests

Unreviewed. Skip another test that requires implementing editing
callbacks.

1:44 PM Changeset in webkit [50760] by Beth Dakin

59 edits
21 adds in trunk

WebCore: Fix for <rdar://problem/7059710>
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
color-correction for CSS colors

Reviewed by Darin Adler.

New exported symbol for GraphicsContext::fillColor() which now
accepts a ColorSpace as an optional parameter.

WebCore.base.exp:

Added a new file, ColorSpace.h, to define the ColorSpace enum.

WebCore.xcodeproj/project.pbxproj:

Computed Style for -webkit-color-correction

css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Parse -webkit-color-correction

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

Map CSS identifiers to the appropriate values of the ColorSpace enum

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColorSpace):

New property -webkit-color-correction

css/CSSPropertyNames.in:

Map -webkit-color-correction into the RenderStyle.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add new value sRGB.

css/CSSValueKeywords.in:

Comment out the reference to sRGB since it will now be inherited as
a value from CSSValueKeywords.

css/SVGCSSValueKeywords.in:

Definition of the ColorSpace enum.

platform/graphics/ColorSpace.h: Added.

(WebCore::):

These functions all now take a ColorSpace as a parameter.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::drawHighlightForText):

Return the appropriate ColorSpace.
(WebCore::GraphicsContext::strokeColorSpace):
(WebCore::GraphicsContext::fillColorSpace):

These functions all call other functions which require a ColorSpace
as a parameter.
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):

All of the GraphicsContext functions that take a Color should now
also take a ColorSpace.

platform/graphics/GraphicsContext.h:

Added new member variables stokeColorSpace and fillColorSpace.

platform/graphics/GraphicsContextPrivate.h:

(WebCore::GraphicsContextState::GraphicsContextState):

Attempt to keep the Cairo port building with all of the massive
changes to GraphicsContext.

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::fillRoundedRect):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef): New static function that returns a
CGColorSpaceRef for the sRGB color space.
(WebCore::deviceRGBColorSpaceRef): New static function that returns
a CGColorSpaceRef for the device RGB color space.

(WebCore::setCGFillColor): Now takes a ColorSpace parameter and
sets the fill color to the specified color in the given ColorSpace.
(WebCore::setCGStrokeColor): Same, but for stroke.

(WebCore::setCGFillColorSpace): New static to set the
CGFillColorSpace to the given ColorSpace
(WebCore::setCGStrokeColorSpace): Same, but for stroke.

Send ColorSpaces when appropriate, set ColorSpaces when
appropriate, and check ColorSpaces when appropriate.
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Attempt to keep Haiku building.

platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Attempt to keep QT building.

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Attempt to keep Wince building.

platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):

Attempt to keep WX building.

platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):

Added functions colorSpace() and setColorSpace()

rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::colorSpace):
(WebCore::InheritedFlags::setColorSpace):

The ColorSpace is stored here.

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

rendering/style/StyleRareInheritedData.h:

All of these call sites call GraphicsContext functions which now
require ColorSpaces.

editing/SelectionController.cpp:

(WebCore::SelectionController::paintCaret):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

inspector/InspectorController.cpp:

(WebCore::drawOutlinedQuad):

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintScrollCorner):

platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintScrollCorner):

platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):

platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivate::paint):

rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintTextDecorations):

rendering/InlineTextBox.cpp:

(WebCore::updateGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

rendering/InlineTextBox.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::fillHorizontalSelectionGap):
(WebCore::RenderBlock::fillVerticalSelectionGap):
(WebCore::RenderBlock::fillLeftSelectionGap):
(WebCore::RenderBlock::fillRightSelectionGap):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBoxShadow):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintScrollCorner):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButton):

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelection):

svg/graphics/SVGPaintServerGradient.cpp:

(WebCore::SVGPaintServerGradient::setup):

svg/graphics/SVGPaintServerSolid.cpp:

(WebCore::SVGPaintServerSolid::setup):

WebKit/mac: Small WebKit part of:
Fix for <rdar://problem/7059710>
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
color-correction for CSS colors

Reviewed by Darin Adler.

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:]): setFillColor now
requires callers to pass a ColorSpace.

LayoutTests: Tests for <rdar://problem/7059710>
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
color-correction for CSS colors

Reviewed by Darin Adler.

New tests.

fast/css/color-correction-backgrounds-and-text.html: Added.
fast/css/color-correction-on-backgrounds.html: Added.
fast/css/color-correction-on-text.html: Added.
fast/css/color-correction.html: Added.
fast/css/parsing-color-correction-expected.txt: Added.
fast/css/parsing-color-correction.html: Added.
fast/css/resources/parsing-color-correction.js: Added.

(test):

fast/css/resources/purple-srgb.png: Added.
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum: Added.
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.txt: Added.
platform/mac/fast/css/color-correction-expected.checksum: Added.
platform/mac/fast/css/color-correction-expected.png: Added.
platform/mac/fast/css/color-correction-expected.txt: Added.
platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum: Added.
platform/mac/fast/css/color-correction-on-backgrounds-expected.png: Added.
platform/mac/fast/css/color-correction-on-backgrounds-expected.txt: Added.
platform/mac/fast/css/color-correction-on-text-expected.checksum: Added.
platform/mac/fast/css/color-correction-on-text-expected.png: Added.
platform/mac/fast/css/color-correction-on-text-expected.txt: Added.

New and improved results.

platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

1:37 PM Changeset in webkit [50759] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-11-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Skip new tests.

platform/gtk/Skipped:

1:20 PM Changeset in webkit [50758] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-11-10 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test to flag changes to values of the WebInspector Timeline record types.
Downstream apps depend on these mappings remaining stable.

https://bugs.webkit.org/show_bug.cgi?id=31303

inspector/timeline-enum-stability-expected.txt: Added.
inspector/timeline-enum-stability.html: Added.

1:12 PM Changeset in webkit [50757] by eric@webkit.org

106 edits in trunk

2009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Update outdated metrics in these tests after r50665 enabled the previously missing scrollbar.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31281.

platform/qt/css1/basic/class_as_selector-expected.txt:
platform/qt/css1/basic/comments-expected.txt:
platform/qt/css1/basic/containment-expected.txt:
platform/qt/css1/basic/id_as_selector-expected.txt:
platform/qt/css1/basic/inheritance-expected.txt:
platform/qt/css1/box_properties/border-expected.txt:
platform/qt/css1/box_properties/border_bottom-expected.txt:
platform/qt/css1/box_properties/border_bottom_width-expected.txt:
platform/qt/css1/box_properties/border_left-expected.txt:
platform/qt/css1/box_properties/border_left_width-expected.txt:
platform/qt/css1/box_properties/border_right_inline-expected.txt:
platform/qt/css1/box_properties/border_right_width-expected.txt:
platform/qt/css1/box_properties/border_style-expected.txt:
platform/qt/css1/box_properties/border_top-expected.txt:
platform/qt/css1/box_properties/border_top_width-expected.txt:
platform/qt/css1/box_properties/border_width-expected.txt:
platform/qt/css1/box_properties/clear-expected.txt:
platform/qt/css1/box_properties/clear_float-expected.txt:
platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
platform/qt/css1/box_properties/float_margin-expected.txt:
platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
platform/qt/css1/box_properties/height-expected.txt:
platform/qt/css1/box_properties/margin-expected.txt:
platform/qt/css1/box_properties/margin_bottom-expected.txt:
platform/qt/css1/box_properties/margin_inline-expected.txt:
platform/qt/css1/box_properties/margin_left-expected.txt:
platform/qt/css1/box_properties/margin_right-expected.txt:
platform/qt/css1/box_properties/margin_top-expected.txt:
platform/qt/css1/box_properties/padding-expected.txt:
platform/qt/css1/box_properties/padding_bottom-expected.txt:
platform/qt/css1/box_properties/padding_inline-expected.txt:
platform/qt/css1/box_properties/padding_left-expected.txt:
platform/qt/css1/box_properties/padding_right-expected.txt:
platform/qt/css1/box_properties/padding_top-expected.txt:
platform/qt/css1/box_properties/width-expected.txt:
platform/qt/css1/cascade/cascade_order-expected.txt:
platform/qt/css1/cascade/important-expected.txt:
platform/qt/css1/classification/display-expected.txt:
platform/qt/css1/classification/list_style_type-expected.txt:
platform/qt/css1/classification/white_space-expected.txt:
platform/qt/css1/color_and_background/background-expected.txt:
platform/qt/css1/color_and_background/background_attachment-expected.txt:
platform/qt/css1/color_and_background/background_color-expected.txt:
platform/qt/css1/color_and_background/background_image-expected.txt:
platform/qt/css1/color_and_background/background_position-expected.txt:
platform/qt/css1/color_and_background/background_repeat-expected.txt:
platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
platform/qt/css1/font_properties/font-expected.txt:
platform/qt/css1/font_properties/font_family-expected.txt:
platform/qt/css1/font_properties/font_size-expected.txt:
platform/qt/css1/font_properties/font_weight-expected.txt:
platform/qt/css1/formatting_model/floating_elements-expected.txt:
platform/qt/css1/formatting_model/height_of_lines-expected.txt:
platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
platform/qt/css1/formatting_model/inline_elements-expected.txt:
platform/qt/css1/formatting_model/replaced_elements-expected.txt:
platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
platform/qt/css1/pseudo/anchor-expected.txt:
platform/qt/css1/pseudo/firstletter-expected.txt:
platform/qt/css1/pseudo/firstline-expected.txt:
platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
platform/qt/css1/text_properties/letter_spacing-expected.txt:
platform/qt/css1/text_properties/line_height-expected.txt:
platform/qt/css1/text_properties/text_decoration-expected.txt:
platform/qt/css1/text_properties/text_indent-expected.txt:
platform/qt/css1/text_properties/text_transform-expected.txt:
platform/qt/css1/text_properties/vertical_align-expected.txt:
platform/qt/css1/text_properties/word_spacing-expected.txt:
platform/qt/css1/units/color_units-expected.txt:
platform/qt/css1/units/length_units-expected.txt:
platform/qt/css1/units/percentage_units-expected.txt:
platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
platform/qt/css2.1/t1202-counter-09-b-expected.txt:
platform/qt/css2.1/t1202-counters-08-b-expected.txt:
platform/qt/css2.1/t1202-counters-09-b-expected.txt:
platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
platform/qt/fast/block/float/008-expected.txt:
platform/qt/fast/block/float/019-expected.txt:
platform/qt/fast/block/float/033-expected.txt:
platform/qt/fast/block/float/035-expected.txt:
platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
platform/qt/fast/box-shadow/basic-shadows-expected.txt:
platform/qt/fast/canvas/canvas-bg-expected.txt:
platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
platform/qt/fast/css/nth-child-dynamic-expected.txt:
platform/qt/fast/css/text-rendering-expected.txt:
platform/qt/fast/dynamic/anchor-lock-expected.txt:
platform/qt/fast/flexbox/flex-hang-expected.txt:
platform/qt/fast/forms/search-vertical-alignment-expected.txt:
platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
platform/qt/fast/lists/ol-start-parsing-expected.txt:
platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
platform/qt/fast/table/height-percent-test-expected.txt:
platform/qt/fast/table/wide-colspan-expected.txt:
platform/qt/fast/table/wide-column-expected.txt:
platform/qt/fast/text/text-letter-spacing-expected.txt:
platform/qt/svg/css/stars-with-shadow-expected.txt:
platform/qt/tables/mozilla/bugs/bug29314-expected.txt:

2009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove obsolete scrollbar policy settings from DRT constructor.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

1:04 PM Changeset in webkit [50756] by Nate Chapin

2 edits in trunk/WebKit/chromium

2009-11-10 Nate Chapin <Nate Chapin>

Reviewed by Eric Seidel.

Update references to Canvas 3D classes to use the WebGL prefix
introduced in http://trac.webkit.org/changeset/50725.

https://bugs.webkit.org/show_bug.cgi?id=31276

1:04 PM Changeset in webkit [50755] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-10 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Speed up syntax highlighter
https://bugs.webkit.org/show_bug.cgi?id=31291

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node. (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter): (WebInspector.JavaScriptSourceSyntaxHighlighter):

12:52 PM Changeset in webkit [50754] by jorlow@chromium.org

4 edits in trunk/WebCore

2009-11-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Remove session storage setting
https://bugs.webkit.org/show_bug.cgi?id=31279

Remove session storage from Settings. It was added temporarily so we could
disable it by default at runtime in Chromium. We now disable these things in a
different way, so it's time to remove it. Qt also depended on this setting for
a short period of time, but after talking to them we agreed that it should be
removed.

This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602

page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage):
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h:

12:06 PM Changeset in webkit [50753] by mitz@apple.com

5 edits in trunk

WebCore: WebCore part of making full-screen video pause during scrubbing.

Reviewed by Eric Carlson and Darin Adler.

WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()

and HTMLMediaElement::endScrubbing().

WebKit/mac: WebKit part of making full-screen video pause during scrubbing.

Reviewed by Eric Carlson and Darin Adler.

WebView/WebVideoFullscreenHUDWindowController.h: Added _isScrubbing

ivar.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController dealloc]): Assert that
_isScrubbing is NO.
(-[WebVideoFullscreenHUDWindowController endScrubbing]): Call
HTMLMediaElement::endScrubbing().
(-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
If scrubbing has just begun, call HTMLMediaElement::beginScrubbing()
and schedule -endScrubbing to be called when mouse tracking ends.

12:00 PM Changeset in webkit [50752] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-10 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
https://bugs.webkit.org/show_bug.cgi?id=31051

bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue): (WebCore::V8GCController::checkMemoryUsage):
bindings/v8/V8GCController.h:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction):

11:52 AM Changeset in webkit [50751] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebWorker and friends.

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebWorkerBase.cpp: Added. (WebKit::WorkerWebFrameClient::didCreateDataSource): (WebKit::WorkerWebFrameClient::sharedInstance): (WebKit::WorkerWebFrameClient::WorkerWebFrameClient): (WebKit::initializeWebKitStaticValues): (WebKit::WebWorkerBase::WebWorkerBase): (WebKit::WebWorkerBase::~WebWorkerBase): (WebKit::WebWorkerBase::stopWorkerThread): (WebKit::WebWorkerBase::initializeLoader): (WebKit::WebWorkerBase::dispatchTaskToMainThread): (WebKit::WebWorkerBase::invokeTaskMethod): (WebKit::WebWorkerBase::postMessageToWorkerObject): (WebKit::WebWorkerBase::postMessageTask): (WebKit::WebWorkerBase::postExceptionToWorkerObject): (WebKit::WebWorkerBase::postExceptionTask): (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask): (WebKit::WebWorkerBase::confirmMessageFromWorkerObject): (WebKit::WebWorkerBase::confirmMessageTask): (WebKit::WebWorkerBase::reportPendingActivity): (WebKit::WebWorkerBase::reportPendingActivityTask): (WebKit::WebWorkerBase::workerContextClosed): (WebKit::WebWorkerBase::workerContextClosedTask): (WebKit::WebWorkerBase::workerContextDestroyed): (WebKit::WebWorkerBase::workerContextDestroyedTask): (WebKit::WebWorkerBase::postTaskToLoader): (WebKit::WebWorkerBase::postTaskForModeToWorkerContext):
src/WebWorkerBase.h: Added. (WebKit::WebWorkerBase::setWorkerThread): (WebKit::WebWorkerBase::workerThread):
src/WebWorkerClientImpl.cpp: Added. (WebKit::WebWorkerClientImpl::createWorkerContextProxy): (WebKit::WebWorkerClientImpl::WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::~WebWorkerClientImpl): (WebKit::WebWorkerClientImpl::setWebWorker): (WebKit::WebWorkerClientImpl::startWorkerContext): (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::hasPendingActivity): (WebKit::WebWorkerClientImpl::workerObjectDestroyed): (WebKit::WebWorkerClientImpl::postMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject): (WebKit::WebWorkerClientImpl::reportPendingActivity): (WebKit::WebWorkerClientImpl::workerContextDestroyed): (WebKit::WebWorkerClientImpl::workerContextClosed): (WebKit::WebWorkerClientImpl::startWorkerContextTask): (WebKit::WebWorkerClientImpl::terminateWorkerContextTask): (WebKit::WebWorkerClientImpl::postMessageToWorkerContextTask): (WebKit::WebWorkerClientImpl::workerObjectDestroyedTask): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask): (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask): (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): (WebKit::WebWorkerClientImpl::reportPendingActivityTask):
src/WebWorkerClientImpl.h: Added. (WebKit::WebWorkerClientImpl::createWorker): (WebKit::WebWorkerClientImpl::notificationPresenter):
src/WebWorkerImpl.cpp: Added. (WebKit::WebWorker::create): (WebKit::WebWorkerImpl::WebWorkerImpl): (WebKit::WebWorkerImpl::~WebWorkerImpl): (WebKit::WebWorkerImpl::commonClient): (WebKit::WebWorkerImpl::postMessageToWorkerContextTask): (WebKit::WebWorkerImpl::startWorkerContext): (WebKit::WebWorkerImpl::terminateWorkerContext): (WebKit::WebWorkerImpl::postMessageToWorkerContext): (WebKit::WebWorkerImpl::workerObjectDestroyed): (WebKit::WebWorkerImpl::clientDestroyed):
src/WebWorkerImpl.h: Added. (WebKit::WebWorkerImpl::client):

11:45 AM Changeset in webkit [50750] by eric@webkit.org

1 edit
14 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: Platform specific files.

https://bugs.webkit.org/show_bug.cgi?id=31276

src/gtk/WebFontInfo.cpp: Added. (WebKit::WebFontInfo::familyForChars):
src/gtk/WebInputEventFactory.cpp: Added. (WebKit::gdkEventTimeToWebEventTime): (WebKit::gdkStateToWebEventModifiers): (WebKit::gdkEventToWindowsKeyCode): (WebKit::getControlCharacter): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
src/gtk/WebScreenInfoFactory.cpp: Added. (WebKit::WebScreenInfoFactory::screenInfo):
src/linux/WebFontRendering.cpp: Added. (WebKit::WebFontRendering::setHinting): (WebKit::WebFontRendering::setAntiAlias): (WebKit::WebFontRendering::setSubpixelGlyphs): (WebKit::WebFontRendering::setLCDOrder): (WebKit::WebFontRendering::setLCDOrientation):
src/mac/WebInputEventFactory.mm: Added. (WebKit::isKeyUpEvent): (WebKit::isKeypadEvent): (WebKit::windowsKeyCodeForKeyEvent): (WebKit::textFromEvent): (WebKit::unmodifiedTextFromEvent): (WebKit::keyIdentifierForKeyEvent): (WebKit::modifiersFromEvent): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
src/mac/WebScreenInfoFactory.mm: Added. (WebKit::screenForWindow): (WebKit::toUserSpace): (WebKit::WebScreenInfoFactory::screenInfo):
src/win/WebInputEventFactory.cpp: Added. (WebKit::isKeyPad): (WebKit::WebInputEventFactory::keyboardEvent): (WebKit::GetRelativeCursorPos): (WebKit::WebInputEventFactory::resetLastClickState): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
src/win/WebScreenInfoFactory.cpp: Added. (WebKit::toWebRect): (WebKit::WebScreenInfoFactory::screenInfo):
src/x11/WebScreenInfoFactory.cpp: Added. (WebKit::WebScreenInfoFactory::screenInfo):

11:37 AM Changeset in webkit [50749] by eric@webkit.org

1 edit
2 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Up-streaming Chromium API src files: WrapperResourceRequest and Response

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WrappedResourceRequest.h: Added. (WebKit::WrappedResourceRequest::~WrappedResourceRequest): (WebKit::WrappedResourceRequest::WrappedResourceRequest): (WebKit::WrappedResourceRequest::bind): (WebKit::WrappedResourceRequest::Handle::dispose):
src/WrappedResourceResponse.h: Added. (WebKit::WrappedResourceResponse::~WrappedResourceResponse): (WebKit::WrappedResourceResponse::WrappedResourceResponse): (WebKit::WrappedResourceResponse::bind): (WebKit::WrappedResourceResponse::Handle::dispose):

11:24 AM Changeset in webkit [50748] by eric@webkit.org

9 edits in trunk/WebCore

2009-11-10 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for the part of loader directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31161

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169

Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.

ThreadableLoaderClient's inheriting has been changed to public.

loader/ImageLoader.cpp:
loader/ProgressTracker.cpp:
loader/RedirectScheduler.cpp:
loader/Request.h:
loader/ThreadableLoaderClient.h:
loader/WorkerThreadableLoader.h:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheStorage.h:

10:57 AM Changeset in webkit [50747] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed documentation fixes.

Added a few improvements from Jocelyn Turcotte to the
createWindow docs.

Api/qwebview.cpp:

10:56 AM Changeset in webkit [50746] by eric@webkit.org

1 edit
8 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: StorageStreamHandlers...StorageNamespaceProxy

https://bugs.webkit.org/show_bug.cgi?id=31276

src/SocketStreamHandle.cpp: Added. (WebCore::SocketStreamHandleInternal::create): (WebCore::SocketStreamHandleInternal::SocketStreamHandleInternal): (WebCore::SocketStreamHandleInternal::~SocketStreamHandleInternal): (WebCore::SocketStreamHandleInternal::connect): (WebCore::SocketStreamHandleInternal::send): (WebCore::SocketStreamHandleInternal::close): (WebCore::SocketStreamHandleInternal::willOpenStream): (WebCore::SocketStreamHandleInternal::didOpenStream): (WebCore::SocketStreamHandleInternal::didSendData): (WebCore::SocketStreamHandleInternal::didReceiveData): (WebCore::SocketStreamHandleInternal::didClose): (WebCore::SocketStreamHandleInternal::didFail): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
src/StorageAreaProxy.cpp: Added. (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::~StorageAreaProxy): (WebCore::StorageAreaProxy::length): (WebCore::StorageAreaProxy::key): (WebCore::StorageAreaProxy::getItem): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::contains):
src/StorageAreaProxy.h: Added.
src/StorageEventDispatcherChromium.cpp: Added. (WebCore::StorageEventDispatcher::dispatch):
src/StorageEventDispatcherImpl.cpp: Added. (WebCore::StorageEventDispatcherImpl::StorageEventDispatcherImpl): (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
src/StorageEventDispatcherImpl.h: Added.
src/StorageNamespaceProxy.cpp: Added. (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::~StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::copy): (WebCore::StorageNamespaceProxy::storageArea): (WebCore::StorageNamespaceProxy::close): (WebCore::StorageNamespaceProxy::unlock):
src/StorageNamespaceProxy.h: Added.

10:52 AM Changeset in webkit [50745] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed documentation fix.

[Qt] Make qwebpage's createWindow not qwebview dependent.
https://bugs.webkit.org/show_bug.cgi?id=30771

Update documentation to make it clear that a reimplementation
of the createWindow method of the associated QWebPage can
result in the QWebView::createWindow method to never be called.

Api/qwebview.cpp:

10:49 AM Changeset in webkit [50744] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: NotificationPresenterImpl...SharedWorkerRepository

https://bugs.webkit.org/show_bug.cgi?id=31276

src/NotificationPresenterImpl.cpp: Added. (WebKit::VoidCallbackClient::VoidCallbackClient): (WebKit::VoidCallbackClient::permissionRequestComplete): (WebKit::NotificationPresenterImpl::initialize): (WebKit::NotificationPresenterImpl::isInitialized): (WebKit::NotificationPresenterImpl::show): (WebKit::NotificationPresenterImpl::cancel): (WebKit::NotificationPresenterImpl::notificationObjectDestroyed): (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):
src/NotificationPresenterImpl.h: Added. (WebKit::NotificationPresenterImpl::NotificationPresenterImpl):
src/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::create): (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::MessagePortChannel): (WebCore::MessagePortChannel::~MessagePortChannel): (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::MessagePortChannel::locallyEntangledPort): (WebCore::PlatformMessagePortChannel::create): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::messageAvailable): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::webChannelRelease):
src/PlatformMessagePortChannel.h: Added.
src/ResourceHandle.cpp: Added. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::setDefersLoading): (WebCore::ResourceHandleInternal::allowStoredCredentials): (WebCore::ResourceHandleInternal::willSendRequest): (WebCore::ResourceHandleInternal::didSendData): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail): (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::request): (WebCore::ResourceHandle::client): (WebCore::ResourceHandle::setClient): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::clearAuthentication): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::ResourceHandle::willLoadFromCache):
src/SharedWorkerRepository.cpp: Added. (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): (WebCore::SharedWorkerScriptLoader::load): (WebCore::getWebPort): (WebCore::SharedWorkerScriptLoader::notifyFinished): (WebCore::SharedWorkerScriptLoader::sendConnect): (WebCore::SharedWorkerScriptLoader::contextDestroyed): (WebCore::SharedWorkerScriptLoader::connected): (WebCore::SharedWorkerRepository::isAvailable): (WebCore::getId): (WebCore::SharedWorkerRepository::connect): (WebCore::SharedWorkerRepository::documentDetached): (WebCore::SharedWorkerRepository::hasSharedWorkers):

10:34 AM Changeset in webkit [50743] by eric@webkit.org

1 edit
5 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: GraphicContext3D...MediaPlaterPrivateChromium

https://bugs.webkit.org/show_bug.cgi?id=31276

src/GraphicsContext3D.cpp: Added. (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::tryLoad): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::checkError): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::validateTextureTarget): (WebCore::GraphicsContext3DInternal::validateTextureParameter): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::checkError): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBoolean): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteri): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloat): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteri): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getInteger): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgrami): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteri): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderi): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterf): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteri): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformf): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformi): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribf): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribi): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::texImage2D): (WebCore::unmultiplyAlpha): (WebCore::texImage2DHelper): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
src/InspectorClientImpl.cpp: Added. (WebKit::InspectorClientImpl::InspectorClientImpl): (WebKit::InspectorClientImpl::~InspectorClientImpl): (WebKit::InspectorClientImpl::inspectorDestroyed): (WebKit::InspectorClientImpl::createPage): (WebKit::InspectorClientImpl::showWindow): (WebKit::InspectorClientImpl::closeWindow): (WebKit::InspectorClientImpl::windowVisible): (WebKit::InspectorClientImpl::attachWindow): (WebKit::InspectorClientImpl::detachWindow): (WebKit::InspectorClientImpl::setAttachedWindowHeight): (WebKit::invalidateNodeBoundingRect): (WebKit::InspectorClientImpl::highlight): (WebKit::InspectorClientImpl::hideHighlight): (WebKit::InspectorClientImpl::inspectedURLChanged): (WebKit::InspectorClientImpl::localizedStringsURL): (WebKit::InspectorClientImpl::hiddenPanels): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::removeSetting): (WebKit::InspectorClientImpl::inspectorWindowObjectCleared): (WebKit::InspectorClientImpl::loadSettings): (WebKit::InspectorClientImpl::saveSettings):
src/InspectorClientImpl.h: Added.
src/LocalizedStrings.cpp: Added. (WebCore::query): (WebCore::searchableIndexIntroduction): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::multipleFileUploadText): (WebCore::unknownFileSizeText): (WebCore::keygenMenuHighGradeKeySize): (WebCore::keygenMenuMediumGradeKeySize): (WebCore::imageTitle): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::mediaElementLiveBroadcastStateText): (WebCore::mediaElementLoadingStateText): (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
src/MediaPlayerPrivateChromium.cpp: Added. (WebCore::MediaPlayerPrivate::registerMediaEngine):

10:27 AM Changeset in webkit [50742] by eric@webkit.org

1 edit
8 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: DOMUtilities...FrameLoaderClientImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

src/DOMUtilitiesPrivate.cpp: Added. (WebCore::toHTMLElement): (WebKit::toHTMLInputElement): (WebKit::toHTMLLinkElement): (WebKit::toHTMLMetaElement): (WebKit::toHTMLOptionElement): (WebKit::nameOfInputElement):
src/DOMUtilitiesPrivate.h: Added.
src/DragClientImpl.cpp: Added. (WebKit::DragClientImpl::willPerformDragDestinationAction): (WebKit::DragClientImpl::willPerformDragSourceAction): (WebKit::DragClientImpl::actionMaskForDrag): (WebKit::DragClientImpl::dragSourceActionMaskForPoint): (WebKit::DragClientImpl::startDrag): (WebKit::DragClientImpl::createDragImageForLink): (WebKit::DragClientImpl::dragControllerDestroyed):
src/DragClientImpl.h: Added. (WebKit::DragClientImpl::DragClientImpl):
src/EditorClientImpl.cpp: Added. (WebKit::EditorClientImpl::EditorClientImpl): (WebKit::EditorClientImpl::~EditorClientImpl): (WebKit::EditorClientImpl::pageDestroyed): (WebKit::EditorClientImpl::shouldShowDeleteInterface): (WebKit::EditorClientImpl::smartInsertDeleteEnabled): (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): (WebKit::EditorClientImpl::shouldSpellcheckByDefault): (WebKit::EditorClientImpl::isContinuousSpellCheckingEnabled): (WebKit::EditorClientImpl::toggleContinuousSpellChecking): (WebKit::EditorClientImpl::isGrammarCheckingEnabled): (WebKit::EditorClientImpl::toggleGrammarChecking): (WebKit::EditorClientImpl::spellCheckerDocumentTag): (WebKit::EditorClientImpl::isEditable): (WebKit::EditorClientImpl::shouldBeginEditing): (WebKit::EditorClientImpl::shouldEndEditing): (WebKit::EditorClientImpl::shouldInsertNode): (WebKit::EditorClientImpl::shouldInsertText): (WebKit::EditorClientImpl::shouldDeleteRange): (WebKit::EditorClientImpl::shouldChangeSelectedRange): (WebKit::EditorClientImpl::shouldApplyStyle): (WebKit::EditorClientImpl::shouldMoveRangeAfterDelete): (WebKit::EditorClientImpl::didBeginEditing): (WebKit::EditorClientImpl::respondToChangedSelection): (WebKit::EditorClientImpl::respondToChangedContents): (WebKit::EditorClientImpl::didEndEditing): (WebKit::EditorClientImpl::didWriteSelectionToPasteboard): (WebKit::EditorClientImpl::didSetSelectionTypesForPasteboard): (WebKit::EditorClientImpl::registerCommandForUndo): (WebKit::EditorClientImpl::registerCommandForRedo): (WebKit::EditorClientImpl::clearUndoRedoOperations): (WebKit::EditorClientImpl::canUndo): (WebKit::EditorClientImpl::canRedo): (WebKit::EditorClientImpl::undo): (WebKit::EditorClientImpl::redo): (WebKit::): (WebKit::EditorClientImpl::interpretKeyEvent): (WebKit::EditorClientImpl::handleEditingKeyboardEvent): (WebKit::EditorClientImpl::handleKeyboardEvent): (WebKit::EditorClientImpl::handleInputMethodKeydown): (WebKit::EditorClientImpl::textFieldDidBeginEditing): (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::textDidChangeInTextField): (WebKit::EditorClientImpl::showFormAutofillForNode): (WebKit::EditorClientImpl::autofill): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::cancelPendingAutofill): (WebKit::EditorClientImpl::onAutofillSuggestionAccepted): (WebKit::EditorClientImpl::doTextFieldCommandFromEvent): (WebKit::EditorClientImpl::textWillBeDeletedInTextField): (WebKit::EditorClientImpl::textDidChangeInTextArea): (WebKit::EditorClientImpl::ignoreWordInSpellDocument): (WebKit::EditorClientImpl::learnWord): (WebKit::EditorClientImpl::checkSpellingOfString): (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord): (WebKit::EditorClientImpl::checkGrammarOfString): (WebKit::EditorClientImpl::updateSpellingUIWithGrammarString): (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord): (WebKit::EditorClientImpl::showSpellingUI): (WebKit::EditorClientImpl::spellingUIIsShowing): (WebKit::EditorClientImpl::getGuessesForWord): (WebKit::EditorClientImpl::setInputMethodState):
src/EditorClientImpl.h: Added. (WebKit::EditorClientImpl::):
src/FrameLoaderClientImpl.cpp: Added. (WebKit::): (WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl): (WebKit::FrameLoaderClientImpl::~FrameLoaderClientImpl): (WebKit::FrameLoaderClientImpl::frameLoaderDestroyed): (WebKit::FrameLoaderClientImpl::windowObjectCleared): (WebKit::FrameLoaderClientImpl::documentElementAvailable): (WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame): (WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame): (WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext): (WebKit::FrameLoaderClientImpl::didPerformFirstNavigation): (WebKit::FrameLoaderClientImpl::registerForIconNotification): (WebKit::FrameLoaderClientImpl::didChangeScrollOffset): (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::hasWebView): (WebKit::FrameLoaderClientImpl::hasFrameView): (WebKit::FrameLoaderClientImpl::makeDocumentView): (WebKit::FrameLoaderClientImpl::makeRepresentation): (WebKit::FrameLoaderClientImpl::forceLayout): (WebKit::FrameLoaderClientImpl::forceLayoutForNonHTML): (WebKit::FrameLoaderClientImpl::setCopiesOnScroll): (WebKit::FrameLoaderClientImpl::detachedFromParent2): (WebKit::FrameLoaderClientImpl::detachedFromParent3): (WebKit::FrameLoaderClientImpl::assignIdentifierToInitialRequest): (WebKit::determineTargetTypeFromLoader): (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest): (WebKit::FrameLoaderClientImpl::shouldUseCredentialStorage): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveAuthenticationChallenge): (WebKit::FrameLoaderClientImpl::dispatchDidCancelAuthenticationChallenge): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveResponse): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveContentLength): (WebKit::FrameLoaderClientImpl::dispatchDidFinishLoading): (WebKit::FrameLoaderClientImpl::dispatchDidFailLoading): (WebKit::FrameLoaderClientImpl::dispatchDidFinishDocumentLoad): (WebKit::FrameLoaderClientImpl::dispatchDidLoadResourceFromMemoryCache): (WebKit::FrameLoaderClientImpl::dispatchDidLoadResourceByXMLHttpRequest): (WebKit::FrameLoaderClientImpl::dispatchDidHandleOnloadEvents): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::FrameLoaderClientImpl::dispatchDidCancelClientRedirect): (WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect): (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClientImpl::dispatchWillClose): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveIcon): (WebKit::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad): (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle): (WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFailLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFinishLoad): (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout): (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout): (WebKit::FrameLoaderClientImpl::dispatchCreatePage): (WebKit::FrameLoaderClientImpl::dispatchShow): (WebKit::shouldTreatAsAttachment): (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClientImpl::cancelPolicyCheck): (WebKit::FrameLoaderClientImpl::dispatchUnableToImplementPolicy): (WebKit::FrameLoaderClientImpl::dispatchWillSubmitForm): (WebKit::FrameLoaderClientImpl::dispatchDidLoadMainResource): (WebKit::FrameLoaderClientImpl::revertToProvisionalState): (WebKit::FrameLoaderClientImpl::setMainDocumentError): (WebKit::FrameLoaderClientImpl::postProgressStartedNotification): (WebKit::FrameLoaderClientImpl::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClientImpl::postProgressFinishedNotification): (WebKit::FrameLoaderClientImpl::setMainFrameDocumentReady): (WebKit::FrameLoaderClientImpl::startDownload): (WebKit::FrameLoaderClientImpl::willChangeTitle): (WebKit::FrameLoaderClientImpl::didChangeTitle): (WebKit::FrameLoaderClientImpl::committedLoad): (WebKit::FrameLoaderClientImpl::finishedLoading): (WebKit::FrameLoaderClientImpl::updateGlobalHistory): (WebKit::FrameLoaderClientImpl::updateGlobalHistoryRedirectLinks): (WebKit::FrameLoaderClientImpl::shouldGoToHistoryItem): (WebKit::FrameLoaderClientImpl::didDisplayInsecureContent): (WebKit::FrameLoaderClientImpl::didRunInsecureContent): (WebKit::FrameLoaderClientImpl::blockedError): (WebKit::FrameLoaderClientImpl::cancelledError): (WebKit::FrameLoaderClientImpl::cannotShowURLError): (WebKit::FrameLoaderClientImpl::interruptForPolicyChangeError): (WebKit::FrameLoaderClientImpl::cannotShowMIMETypeError): (WebKit::FrameLoaderClientImpl::fileDoesNotExistError): (WebKit::FrameLoaderClientImpl::pluginWillHandleLoadError): (WebKit::FrameLoaderClientImpl::shouldFallBack): (WebKit::FrameLoaderClientImpl::canHandleRequest): (WebKit::FrameLoaderClientImpl::canShowMIMEType): (WebKit::FrameLoaderClientImpl::representationExistsForURLScheme): (WebKit::FrameLoaderClientImpl::generatedMIMETypeForURLScheme): (WebKit::FrameLoaderClientImpl::frameLoadCompleted): (WebKit::FrameLoaderClientImpl::saveViewStateToItem): (WebKit::FrameLoaderClientImpl::restoreViewState): (WebKit::FrameLoaderClientImpl::provisionalLoadStarted): (WebKit::FrameLoaderClientImpl::didFinishLoad): (WebKit::FrameLoaderClientImpl::prepareForDataSourceReplacement): (WebKit::FrameLoaderClientImpl::createDocumentLoader): (WebKit::FrameLoaderClientImpl::setTitle): (WebKit::FrameLoaderClientImpl::userAgent): (WebKit::FrameLoaderClientImpl::savePlatformDataToCachedFrame): (WebKit::FrameLoaderClientImpl::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClientImpl::transitionToCommittedForNewPage): (WebKit::FrameLoaderClientImpl::canCachePage): (WebKit::FrameLoaderClientImpl::download): (WebKit::FrameLoaderClientImpl::createFrame): (WebKit::FrameLoaderClientImpl::createPlugin): (WebKit::FrameLoaderClientImpl::redirectDataToPlugin): (WebKit::FrameLoaderClientImpl::createJavaAppletWidget): (WebKit::FrameLoaderClientImpl::objectContentType): (WebKit::FrameLoaderClientImpl::overrideMediaType): (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy): (WebKit::FrameLoaderClientImpl::handleBackForwardNavigation): (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
src/FrameLoaderClientImpl.h: Added. (WebKit::FrameLoaderClientImpl::webFrame): (WebKit::FrameLoaderClientImpl::willChangeEstimatedProgress): (WebKit::FrameLoaderClientImpl::didChangeEstimatedProgress):

10:19 AM Changeset in webkit [50741] by eric@webkit.org

1 edit
7 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: ChromeClientImpl...ContextMenuClientImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

src/ChromeClientImpl.cpp: Added. (WebKit::ChromeClientImpl::ChromeClientImpl): (WebKit::ChromeClientImpl::~ChromeClientImpl): (WebKit::ChromeClientImpl::chromeDestroyed): (WebKit::ChromeClientImpl::setWindowRect): (WebKit::ChromeClientImpl::windowRect): (WebKit::ChromeClientImpl::pageRect): (WebKit::ChromeClientImpl::scaleFactor): (WebKit::ChromeClientImpl::focus): (WebKit::ChromeClientImpl::unfocus): (WebKit::ChromeClientImpl::canTakeFocus): (WebKit::ChromeClientImpl::takeFocus): (WebKit::ChromeClientImpl::focusedNodeChanged): (WebKit::ChromeClientImpl::createWindow): (WebKit::currentEventShouldCauseBackgroundTab): (WebKit::ChromeClientImpl::show): (WebKit::ChromeClientImpl::canRunModal): (WebKit::ChromeClientImpl::runModal): (WebKit::ChromeClientImpl::setToolbarsVisible): (WebKit::ChromeClientImpl::toolbarsVisible): (WebKit::ChromeClientImpl::setStatusbarVisible): (WebKit::ChromeClientImpl::statusbarVisible): (WebKit::ChromeClientImpl::setScrollbarsVisible): (WebKit::ChromeClientImpl::scrollbarsVisible): (WebKit::ChromeClientImpl::setMenubarVisible): (WebKit::ChromeClientImpl::menubarVisible): (WebKit::ChromeClientImpl::setResizable): (WebKit::ChromeClientImpl::addMessageToConsole): (WebKit::ChromeClientImpl::canRunBeforeUnloadConfirmPanel): (WebKit::ChromeClientImpl::runBeforeUnloadConfirmPanel): (WebKit::ChromeClientImpl::closeWindowSoon): (WebKit::ChromeClientImpl::runJavaScriptAlert): (WebKit::ChromeClientImpl::runJavaScriptConfirm): (WebKit::ChromeClientImpl::runJavaScriptPrompt): (WebKit::ChromeClientImpl::setStatusbarText): (WebKit::ChromeClientImpl::shouldInterruptJavaScript): (WebKit::ChromeClientImpl::tabsToLinks): (WebKit::ChromeClientImpl::windowResizerRect): (WebKit::ChromeClientImpl::repaint): (WebKit::ChromeClientImpl::scroll): (WebKit::ChromeClientImpl::screenToWindow): (WebKit::ChromeClientImpl::windowToScreen): (WebKit::ChromeClientImpl::contentsSizeChanged): (WebKit::ChromeClientImpl::scrollbarsModeDidChange): (WebKit::ChromeClientImpl::mouseDidMoveOverElement): (WebKit::ChromeClientImpl::setToolTip): (WebKit::ChromeClientImpl::print): (WebKit::ChromeClientImpl::exceededDatabaseQuota): (WebKit::ChromeClientImpl::reachedMaxAppCacheSize): (WebKit::ChromeClientImpl::runOpenPanel): (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::setCursorForPlugin): (WebKit::ChromeClientImpl::formStateDidChange): (WebKit::ChromeClientImpl::getPopupMenuInfo): (WebKit::ChromeClientImpl::notificationPresenter):
src/ChromeClientImpl.h: Added. (WebKit::ChromeClientImpl::webView): (WebKit::ChromeClientImpl::platformPageClient): (WebKit::ChromeClientImpl::scrollRectIntoView): (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::createHTMLParserQuirks):
src/ChromiumBridge.cpp: Added. (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::ChromiumBridge::clipboardIsFormatAvailable): (WebCore::ChromiumBridge::clipboardReadPlainText): (WebCore::ChromiumBridge::clipboardReadHTML): (WebCore::ChromiumBridge::clipboardWriteSelection): (WebCore::ChromiumBridge::clipboardWritePlainText): (WebCore::ChromiumBridge::clipboardWriteURL): (WebCore::ChromiumBridge::clipboardWriteImage): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::prefetchDNS): (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::ensureFontLoaded): (WebCore::ChromiumBridge::getFontFamilyForCharacters): (WebCore::ChromiumBridge::databaseOpenFile): (WebCore::ChromiumBridge::databaseDeleteFile): (WebCore::ChromiumBridge::databaseGetFileAttributes): (WebCore::ChromiumBridge::databaseGetFileSize): (WebCore::ChromiumBridge::signedPublicKeyAndChallengeString): (WebCore::ChromiumBridge::computedDefaultLanguage): (WebCore::ChromiumBridge::layoutTestMode): (WebCore::ChromiumBridge::isSupportedImageMIMEType): (WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType): (WebCore::ChromiumBridge::isSupportedNonImageMIMEType): (WebCore::ChromiumBridge::mimeTypeForExtension): (WebCore::ChromiumBridge::mimeTypeFromFile): (WebCore::ChromiumBridge::preferredExtensionForMIMEType): (WebCore::ChromiumBridge::plugins): (WebCore::ChromiumBridge::pluginScriptableObject): (WebCore::ChromiumBridge::loadPlatformImageResource): (WebCore::ChromiumBridge::sandboxEnabled): (WebCore::ChromiumBridge::setSharedTimerFiredFunction): (WebCore::ChromiumBridge::setSharedTimerFireTime): (WebCore::ChromiumBridge::stopSharedTimer): (WebCore::ChromiumBridge::decrementStatsCounter): (WebCore::ChromiumBridge::incrementStatsCounter): (WebCore::ChromiumBridge::suddenTerminationChanged): (WebCore::ChromiumBridge::currentTime): (WebCore::ChromiumBridge::paintButton): (WebCore::ChromiumBridge::paintMenuList): (WebCore::ChromiumBridge::paintScrollbarArrow): (WebCore::ChromiumBridge::paintScrollbarThumb): (WebCore::ChromiumBridge::paintScrollbarTrack): (WebCore::ChromiumBridge::paintTextField): (WebCore::ChromiumBridge::paintTrackbar): (WebCore::ChromiumBridge::traceEventBegin): (WebCore::ChromiumBridge::traceEventEnd): (WebCore::ChromiumBridge::visitedLinkHash): (WebCore::ChromiumBridge::isLinkVisited): (WebCore::ChromiumBridge::notifyJSOutOfMemory): (WebCore::ChromiumBridge::memoryUsageMB): (WebCore::ChromiumBridge::screenDepth): (WebCore::ChromiumBridge::screenDepthPerComponent): (WebCore::ChromiumBridge::screenIsMonochrome): (WebCore::ChromiumBridge::screenRect): (WebCore::ChromiumBridge::screenAvailableRect): (WebCore::ChromiumBridge::popupsAllowed): (WebCore::ChromiumBridge::widgetSetCursor): (WebCore::ChromiumBridge::widgetSetFocus): (WebCore::WorkerContextProxy::create):
src/ChromiumCurrentTime.cpp: Added. (WTF::currentTime):
src/ChromiumThreading.cpp: Added. (WTF::ChromiumThreading::initializeMainThread): (WTF::ChromiumThreading::scheduleDispatchFunctionsOnMainThread):
src/ContextMenuClientImpl.cpp: Added. (WebKit::urlFromFrame): (WebKit::isASingleWord): (WebKit::selectMisspelledWord): (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/ContextMenuClientImpl.h: Added. (WebKit::ContextMenuClientImpl::ContextMenuClientImpl): (WebKit::ContextMenuClientImpl::~ContextMenuClientImpl): (WebKit::ContextMenuClientImpl::copyImageToClipboard): (WebKit::ContextMenuClientImpl::contextMenuDestroyed): (WebKit::ContextMenuClientImpl::contextMenuItemSelected): (WebKit::ContextMenuClientImpl::downloadURL): (WebKit::ContextMenuClientImpl::isSpeaking): (WebKit::ContextMenuClientImpl::lookUpInDictionary): (WebKit::ContextMenuClientImpl::searchWithGoogle): (WebKit::ContextMenuClientImpl::shouldIncludeInspectElementItem): (WebKit::ContextMenuClientImpl::speak): (WebKit::ContextMenuClientImpl::stopSpeaking):

10:12 AM Changeset in webkit [50740] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: AppCach...BackForwardListClientImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

src/ApplicationCacheHost.cpp: Added. (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal): (WebCore::ApplicationCacheHostInternal::notifyEventListener): (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::~ApplicationCacheHost): (WebCore::ApplicationCacheHost::maybeLoadMainResource): (WebCore::ApplicationCacheHost::selectCacheWithoutManifest): (WebCore::ApplicationCacheHost::selectCacheWithManifest): (WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse): (WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError): (WebCore::ApplicationCacheHost::mainResourceDataReceived): (WebCore::ApplicationCacheHost::failedLoadingMainResource): (WebCore::ApplicationCacheHost::finishedLoadingMainResource): (WebCore::ApplicationCacheHost::maybeLoadResource): (WebCore::ApplicationCacheHost::maybeLoadFallbackForRedirect): (WebCore::ApplicationCacheHost::maybeLoadFallbackForResponse): (WebCore::ApplicationCacheHost::maybeLoadFallbackForError): (WebCore::ApplicationCacheHost::maybeLoadSynchronously): (WebCore::ApplicationCacheHost::maybeLoadFallbackSynchronously): (WebCore::ApplicationCacheHost::canCacheInPageCache): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): (WebCore::ApplicationCacheHost::status): (WebCore::ApplicationCacheHost::update): (WebCore::ApplicationCacheHost::swapCache): (WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
src/AssertMatchingEnums.cpp: Added.
src/AutocompletePopupMenuClient.cpp: Added. (WebKit::AutocompletePopupMenuClient::AutocompletePopupMenuClient): (WebKit::AutocompletePopupMenuClient::~AutocompletePopupMenuClient): (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::valueChanged): (WebKit::AutocompletePopupMenuClient::itemText): (WebKit::AutocompletePopupMenuClient::itemStyle): (WebKit::AutocompletePopupMenuClient::menuStyle): (WebKit::AutocompletePopupMenuClient::clientPaddingLeft): (WebKit::AutocompletePopupMenuClient::clientPaddingRight): (WebKit::AutocompletePopupMenuClient::popupDidHide): (WebKit::AutocompletePopupMenuClient::setTextFromItem): (WebKit::AutocompletePopupMenuClient::fontSelector): (WebKit::AutocompletePopupMenuClient::hostWindow): (WebKit::AutocompletePopupMenuClient::createScrollbar): (WebKit::AutocompletePopupMenuClient::setSuggestions): (WebKit::AutocompletePopupMenuClient::removeItemAtIndex): (WebKit::AutocompletePopupMenuClient::textFieldStyle):
src/AutocompletePopupMenuClient.h: Added. (WebKit::AutocompletePopupMenuClient::textField): (WebKit::AutocompletePopupMenuClient::itemToolTip): (WebKit::AutocompletePopupMenuClient::itemIsEnabled): (WebKit::AutocompletePopupMenuClient::clientInsetLeft): (WebKit::AutocompletePopupMenuClient::clientInsetRight): (WebKit::AutocompletePopupMenuClient::listSize): (WebKit::AutocompletePopupMenuClient::selectedIndex): (WebKit::AutocompletePopupMenuClient::itemIsSeparator): (WebKit::AutocompletePopupMenuClient::itemIsLabel): (WebKit::AutocompletePopupMenuClient::itemIsSelected): (WebKit::AutocompletePopupMenuClient::shouldPopOver): (WebKit::AutocompletePopupMenuClient::valueShouldChangeOnHotTrack):
src/BackForwardListClientImpl.cpp: Added. (WebKit::BackForwardListClientImpl::BackForwardListClientImpl): (WebKit::BackForwardListClientImpl::~BackForwardListClientImpl): (WebKit::BackForwardListClientImpl::setCurrentHistoryItem): (WebKit::BackForwardListClientImpl::previousHistoryItem): (WebKit::BackForwardListClientImpl::addItem): (WebKit::BackForwardListClientImpl::goToItem): (WebKit::BackForwardListClientImpl::currentItem): (WebKit::BackForwardListClientImpl::itemAtIndex): (WebKit::BackForwardListClientImpl::backListCount): (WebKit::BackForwardListClientImpl::forwardListCount): (WebKit::BackForwardListClientImpl::close):
src/BackForwardListClientImpl.h: Added.

10:04 AM Changeset in webkit [50739] by eric@webkit.org

1 edit
9 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebString...WebViewImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebString.cpp: Added. (WebKit::WebString::reset): (WebKit::WebString::assign): (WebKit::WebString::length): (WebKit::WebString::data): (WebKit::WebString::utf8): (WebKit::WebString::fromUTF8): (WebKit::WebString::WebString): (WebKit::WebString::operator=): (WebKit::WebString::operator WebCore::String): (WebKit::WebString::operator WebCore::AtomicString):
src/WebURL.cpp: Added. (WebKit::WebURL::WebURL): (WebKit::WebURL::operator=): (WebKit::WebURL::operator WebCore::KURL):
src/WebURLError.cpp: Added. (WebKit::WebURLError::WebURLError): (WebKit::WebURLError::operator=): (WebKit::WebURLError::operator ResourceError):
src/WebURLRequest.cpp: Added. (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequestPrivateImpl::dispose): (WebKit::WebURLRequest::initialize): (WebKit::WebURLRequest::reset): (WebKit::WebURLRequest::assign): (WebKit::WebURLRequest::isNull): (WebKit::WebURLRequest::url): (WebKit::WebURLRequest::setURL): (WebKit::WebURLRequest::firstPartyForCookies): (WebKit::WebURLRequest::setFirstPartyForCookies): (WebKit::WebURLRequest::allowCookies): (WebKit::WebURLRequest::setAllowCookies): (WebKit::WebURLRequest::allowStoredCredentials): (WebKit::WebURLRequest::setAllowStoredCredentials): (WebKit::WebURLRequest::cachePolicy): (WebKit::WebURLRequest::setCachePolicy): (WebKit::WebURLRequest::httpMethod): (WebKit::WebURLRequest::setHTTPMethod): (WebKit::WebURLRequest::httpHeaderField): (WebKit::WebURLRequest::setHTTPHeaderField): (WebKit::WebURLRequest::addHTTPHeaderField): (WebKit::WebURLRequest::clearHTTPHeaderField): (WebKit::WebURLRequest::visitHTTPHeaderFields): (WebKit::WebURLRequest::httpBody): (WebKit::WebURLRequest::setHTTPBody): (WebKit::WebURLRequest::reportUploadProgress): (WebKit::WebURLRequest::setReportUploadProgress): (WebKit::WebURLRequest::targetType): (WebKit::WebURLRequest::setTargetType): (WebKit::WebURLRequest::requestorID): (WebKit::WebURLRequest::setRequestorID): (WebKit::WebURLRequest::requestorProcessID): (WebKit::WebURLRequest::setRequestorProcessID): (WebKit::WebURLRequest::appCacheHostID): (WebKit::WebURLRequest::setAppCacheHostID): (WebKit::WebURLRequest::toMutableResourceRequest): (WebKit::WebURLRequest::toResourceRequest):
src/WebURLRequestPrivate.h: Added. (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
src/WebURLResponse.cpp: Added. (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponsePrivateImpl::dispose): (WebKit::WebURLResponse::initialize): (WebKit::WebURLResponse::reset): (WebKit::WebURLResponse::assign): (WebKit::WebURLResponse::isNull): (WebKit::WebURLResponse::url): (WebKit::WebURLResponse::setURL): (WebKit::WebURLResponse::mimeType): (WebKit::WebURLResponse::setMIMEType): (WebKit::WebURLResponse::expectedContentLength): (WebKit::WebURLResponse::setExpectedContentLength): (WebKit::WebURLResponse::textEncodingName): (WebKit::WebURLResponse::setTextEncodingName): (WebKit::WebURLResponse::suggestedFileName): (WebKit::WebURLResponse::setSuggestedFileName): (WebKit::WebURLResponse::httpStatusCode): (WebKit::WebURLResponse::setHTTPStatusCode): (WebKit::WebURLResponse::httpStatusText): (WebKit::WebURLResponse::setHTTPStatusText): (WebKit::WebURLResponse::httpHeaderField): (WebKit::WebURLResponse::setHTTPHeaderField): (WebKit::WebURLResponse::addHTTPHeaderField): (WebKit::WebURLResponse::clearHTTPHeaderField): (WebKit::WebURLResponse::visitHTTPHeaderFields): (WebKit::WebURLResponse::lastModifiedDate): (WebKit::WebURLResponse::setLastModifiedDate): (WebKit::WebURLResponse::isContentFiltered): (WebKit::WebURLResponse::setIsContentFiltered): (WebKit::WebURLResponse::appCacheID): (WebKit::WebURLResponse::setAppCacheID): (WebKit::WebURLResponse::appCacheManifestURL): (WebKit::WebURLResponse::setAppCacheManifestURL): (WebKit::WebURLResponse::securityInfo): (WebKit::WebURLResponse::setSecurityInfo): (WebKit::WebURLResponse::toMutableResourceResponse): (WebKit::WebURLResponse::toResourceResponse):
src/WebURLResponsePrivate.h: Added. (WebKit::WebURLResponsePrivate::WebURLResponsePrivate):
src/WebViewImpl.cpp: Added. (WebKit::): (WebKit::WebView::create): (WebKit::WebView::updateVisitedLinkState): (WebKit::WebView::resetVisitedLinkState): (WebKit::WebViewImpl::initializeMainFrame): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::~WebViewImpl): (WebKit::WebViewImpl::theme): (WebKit::WebViewImpl::mainFrameImpl): (WebKit::WebViewImpl::tabKeyCyclesThroughElements): (WebKit::WebViewImpl::setTabKeyCyclesThroughElements): (WebKit::WebViewImpl::mouseMove): (WebKit::WebViewImpl::mouseLeave): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseContextMenu): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::mouseWheel): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::charEvent): (WebKit::WebViewImpl::sendContextMenuEvent): (WebKit::WebViewImpl::keyEventDefault): (WebKit::WebViewImpl::scrollViewWithKeyboard): (WebKit::WebViewImpl::propagateScroll): (WebKit::WebViewImpl::focusedWebCoreFrame): (WebKit::WebViewImpl::fromPage): (WebKit::WebViewImpl::close): (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::handleInputEvent): (WebKit::WebViewImpl::mouseCaptureLost): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::queryCompositionStatus): (WebKit::WebViewImpl::setTextDirection): (WebKit::WebViewImpl::settings): (WebKit::WebViewImpl::pageEncoding): (WebKit::WebViewImpl::setPageEncoding): (WebKit::WebViewImpl::dispatchBeforeUnloadEvent): (WebKit::WebViewImpl::dispatchUnloadEvent): (WebKit::WebViewImpl::mainFrame): (WebKit::WebViewImpl::findFrameByName): (WebKit::WebViewImpl::focusedFrame): (WebKit::WebViewImpl::setFocusedFrame): (WebKit::WebViewImpl::setInitialFocus): (WebKit::WebViewImpl::clearFocusedNode): (WebKit::WebViewImpl::zoomIn): (WebKit::WebViewImpl::zoomOut): (WebKit::WebViewImpl::zoomDefault): (WebKit::WebViewImpl::performMediaPlayerAction): (WebKit::WebViewImpl::copyImageAt): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragSourceSystemDragEnded): (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragLeave): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragIdentity): (WebKit::WebViewImpl::inspectElementAt): (WebKit::WebViewImpl::inspectorSettings): (WebKit::WebViewImpl::setInspectorSettings): (WebKit::WebViewImpl::devToolsAgent): (WebKit::WebViewImpl::setDevToolsAgent): (WebKit::WebViewImpl::accessibilityObject): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::setDropEffect): (WebKit::WebViewImpl::setIsTransparent): (WebKit::WebViewImpl::isTransparent): (WebKit::WebViewImpl::setIsActive): (WebKit::WebViewImpl::isActive): (WebKit::WebViewImpl::didCommitLoad): (WebKit::WebViewImpl::navigationPolicyFromMouseEvent): (WebKit::WebViewImpl::startDragging): (WebKit::WebViewImpl::setCurrentHistoryItem): (WebKit::WebViewImpl::previousHistoryItem): (WebKit::WebViewImpl::observeNewNavigation): (WebKit::WebViewImpl::hideAutoCompletePopup): (WebKit::WebViewImpl::autoCompletePopupDidHide): (WebKit::WebViewImpl::setIgnoreInputEvents): (WebKit::WebViewImpl::notificationPresenterImpl): (WebKit::WebViewImpl::refreshAutofillPopup): (WebKit::WebViewImpl::focusedWebCoreNode): (WebKit::WebViewImpl::hitTestResultForWindowPos): (WebKit::WebViewImpl::setTabsToLinks): (WebKit::WebViewImpl::tabsToLinks):
src/WebViewImpl.h: Added. (WebKit::WebViewImpl::size): (WebKit::WebViewImpl::devToolsAgentPrivate): (WebKit::WebViewImpl::lastMouseDownPoint): (WebKit::WebViewImpl::client): (WebKit::WebViewImpl::page): (WebKit::WebViewImpl::contextMenuAllowed): (WebKit::WebViewImpl::setInitialNavigationPolicy): (WebKit::WebViewImpl::initialNavigationPolicy): (WebKit::WebViewImpl::currentInputEvent): (WebKit::WebViewImpl::):

8:35 AM Changeset in webkit [50738] by Nate Chapin

1 edit in trunk/WebKit/chromium/ChangeLog

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

WebPa*.h and WebPl*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

4:38 AM QtWebKitContrib edited by Simon Hausmann

(diff)

3:42 AM Changeset in webkit [50737] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove WebSocket configuration from WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=31244

Follow-up of r50724. Don't set the enable-web-socket property
anymore.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):

3:34 AM Changeset in webkit [50736] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

WebKit coding style fixes.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::paint): (WebCore::mimeTypeCache):

3:27 AM Changeset in webkit [50735] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

platform/gtk/Skipped: Unskip fixed tests.

2:59 AM Changeset in webkit [50734] by oliver@apple.com

2 edits in trunk/WebCore

Remove build failure introduced by earlier build fix.

2:54 AM Changeset in webkit [50733] by oliver@apple.com

2 edits in trunk/WebCore

Is this the last build fix? grep tells me yes.

2:51 AM Changeset in webkit [50732] by oliver@apple.com

2 edits in trunk/WebCore

Hopefully the last chrome build fix

2:47 AM Changeset in webkit [50731] by oliver@apple.com

2 edits in trunk/WebCore

Another chrome build fix.

2:44 AM Changeset in webkit [50730] by oliver@apple.com

11 edits in trunk/WebCore

Yet another chrome buildfix

2:20 AM Changeset in webkit [50729] by oliver@apple.com

2 edits in trunk/WebCore

Chrome build fix

1:57 AM Changeset in webkit [50728] by oliver@apple.com

10 edits in trunk/WebKitSite

Fix WebGL demos to work with renamed WebGL primitives

Reviewed by Maciej Stachowiak

1:53 AM Changeset in webkit [50727] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-10 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30901
[Gtk] Need to de-lint the Atk a11y code

Removal of various and sundry style-violating nits.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

1:45 AM Changeset in webkit [50726] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html

Fix playback rate setter by remembering the rate was changed. Also
correctly handle reverse playback by doing a seek from end to
beginning of the media.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::updateStates):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

1:19 AM Changeset in webkit [50725] by oliver@apple.com

42 edits
3 copies
82 moves
3 deletes in trunk

Rename 3D Canvas related classes to use WebGL prefix
https://bugs.webkit.org/show_bug.cgi?id=29095

Reviewed by Maciej Stachowiak.

Automatic rename of all WebGL related types from Canvas* to
WebGL* per more recent version of the WebGL spec.

1:15 AM Changeset in webkit [50724] by eric@webkit.org

2 edits in trunk/WebKit/gtk

2009-11-10 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Remove WebSocket configuration from WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=31244

Remove non-functional enable-web-sockets property from WebKitWebSettings.

webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):

12:16 AM Changeset in webkit [50723] by eric@webkit.org

1 edit
14 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebScriptController...WebStorageNamespaceImpl

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebScriptController.cpp: Added. (WebKit::WebScriptController::registerExtension): (WebKit::WebScriptController::enableV8SingleThreadMode): (WebKit::WebScriptController::flushConsoleMessages):
src/WebSearchableFormData.cpp: Added. (WebCore::GetFormEncoding): (WebCore::IsHTTPFormSubmit): (WebCore::GetButtonToActivate): (WebCore::IsSelectInDefaultState): (WebCore::IsInDefaultState): (WebCore::HasSuitableTextElement): (WebKit::WebSearchableFormData::WebSearchableFormData):
src/WebSecurityOrigin.cpp: Added. (WebKit::WebSecurityOrigin::reset): (WebKit::WebSecurityOrigin::assign): (WebKit::WebSecurityOrigin::protocol): (WebKit::WebSecurityOrigin::host): (WebKit::WebSecurityOrigin::port): (WebKit::WebSecurityOrigin::isEmpty): (WebKit::WebSecurityOrigin::toString): (WebKit::WebSecurityOrigin::databaseIdentifier): (WebKit::WebSecurityOrigin::WebSecurityOrigin): (WebKit::WebSecurityOrigin::operator=): (WebKit::WebSecurityOrigin::operator WTF::PassRefPtr<WebCore::SecurityOrigin>):
src/WebSecurityPolicy.cpp: Added. (WebKit::WebSecurityPolicy::registerURLSchemeAsLocal): (WebKit::WebSecurityPolicy::registerURLSchemeAsNoAccess): (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin): (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
src/WebSettingsImpl.cpp: Added. (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setStandardFontFamily): (WebKit::WebSettingsImpl::setFixedFontFamily): (WebKit::WebSettingsImpl::setSerifFontFamily): (WebKit::WebSettingsImpl::setSansSerifFontFamily): (WebKit::WebSettingsImpl::setCursiveFontFamily): (WebKit::WebSettingsImpl::setFantasyFontFamily): (WebKit::WebSettingsImpl::setDefaultFontSize): (WebKit::WebSettingsImpl::setDefaultFixedFontSize): (WebKit::WebSettingsImpl::setMinimumFontSize): (WebKit::WebSettingsImpl::setMinimumLogicalFontSize): (WebKit::WebSettingsImpl::setDefaultTextEncodingName): (WebKit::WebSettingsImpl::setJavaScriptEnabled): (WebKit::WebSettingsImpl::setWebSecurityEnabled): (WebKit::WebSettingsImpl::setJavaScriptCanOpenWindowsAutomatically): (WebKit::WebSettingsImpl::setLoadsImagesAutomatically): (WebKit::WebSettingsImpl::setPluginsEnabled): (WebKit::WebSettingsImpl::setDOMPasteAllowed): (WebKit::WebSettingsImpl::setDeveloperExtrasEnabled): (WebKit::WebSettingsImpl::setShrinksStandaloneImagesToFit): (WebKit::WebSettingsImpl::setUsesEncodingDetector): (WebKit::WebSettingsImpl::setTextAreasAreResizable): (WebKit::WebSettingsImpl::setJavaEnabled): (WebKit::WebSettingsImpl::setAllowScriptsToCloseWindows): (WebKit::WebSettingsImpl::setUserStyleSheetLocation): (WebKit::WebSettingsImpl::setUsesPageCache): (WebKit::WebSettingsImpl::setDownloadableBinaryFontsEnabled): (WebKit::WebSettingsImpl::setXSSAuditorEnabled): (WebKit::WebSettingsImpl::setLocalStorageEnabled): (WebKit::WebSettingsImpl::setEditableLinkBehaviorNeverLive): (WebKit::WebSettingsImpl::setFontRenderingModeNormal): (WebKit::WebSettingsImpl::setShouldPaintCustomScrollbars): (WebKit::WebSettingsImpl::setDatabasesEnabled): (WebKit::WebSettingsImpl::setAllowUniversalAccessFromFileURLs): (WebKit::WebSettingsImpl::setTextDirectionSubmenuInclusionBehaviorNeverIncluded): (WebKit::WebSettingsImpl::setOfflineWebApplicationCacheEnabled): (WebKit::WebSettingsImpl::setExperimentalWebGLEnabled):
src/WebSettingsImpl.h: Added. (WebKit::WebSettingsImpl::~WebSettingsImpl):
src/WebSharedWorkerImpl.cpp: Added. (WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl): (WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl): (WebKit::WebSharedWorkerImpl::isStarted): (WebKit::WebSharedWorkerImpl::connect): (WebKit::WebSharedWorkerImpl::connectTask): (WebKit::WebSharedWorkerImpl::startWorkerContext): (WebKit::WebSharedWorkerImpl::terminateWorkerContext): (WebKit::WebSharedWorkerImpl::clientDestroyed): (WebKit::WebSharedWorkerImpl::client): (WebKit::WebSharedWorker::create):
src/WebSharedWorkerImpl.h: Added. (WebKit::WebSharedWorkerImpl::commonClient):
src/WebStorageAreaImpl.cpp: Added. (WebKit::WebStorageAreaImpl::WebStorageAreaImpl): (WebKit::WebStorageAreaImpl::~WebStorageAreaImpl): (WebKit::WebStorageAreaImpl::length): (WebKit::WebStorageAreaImpl::key): (WebKit::WebStorageAreaImpl::getItem): (WebKit::WebStorageAreaImpl::setItem): (WebKit::WebStorageAreaImpl::removeItem): (WebKit::WebStorageAreaImpl::clear):
src/WebStorageAreaImpl.h: Added. (WebKit::WebStorageAreaImpl::currentStorageEventURL): (WebKit::WebStorageAreaImpl::ScopedStorageEventURL::ScopedStorageEventURL): (WebKit::WebStorageAreaImpl::ScopedStorageEventURL::~ScopedStorageEventURL):
src/WebStorageEventDispatcherImpl.cpp: Added. (WebKit::WebStorageEventDispatcher::create): (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl): (WebKit::WebStorageEventDispatcherImpl::dispatchStorageEvent):
src/WebStorageEventDispatcherImpl.h: Added.
src/WebStorageNamespaceImpl.cpp: Added. (WebKit::WebStorageNamespace::createLocalStorageNamespace): (WebKit::WebStorageNamespace::createSessionStorageNamespace): (WebKit::WebStorageNamespaceImpl::WebStorageNamespaceImpl): (WebKit::WebStorageNamespaceImpl::~WebStorageNamespaceImpl): (WebKit::WebStorageNamespaceImpl::createStorageArea): (WebKit::WebStorageNamespaceImpl::copy): (WebKit::WebStorageNamespaceImpl::close):
src/WebStorageNamespaceImpl.h: Added.

12:09 AM Changeset in webkit [50722] by eric@webkit.org

1 edit
13 adds in trunk/WebKit/chromium

2009-11-10 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebPasswordFormData...WebRuntimeFeatures

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebPasswordFormData.cpp: Added. (WebKit::): (WebKit::WebPasswordFormData::WebPasswordFormData):
src/WebPasswordFormUtils.cpp: Added. (WebKit::findPasswordFormFields):
src/WebPasswordFormUtils.h: Added. (WebKit::PasswordFormFields::PasswordFormFields):
src/WebPluginContainerImpl.cpp: Added. (WebKit::WebPluginContainerImpl::setFrameRect): (WebKit::WebPluginContainerImpl::paint): (WebKit::WebPluginContainerImpl::invalidateRect): (WebKit::WebPluginContainerImpl::setFocus): (WebKit::WebPluginContainerImpl::show): (WebKit::WebPluginContainerImpl::hide): (WebKit::WebPluginContainerImpl::handleEvent): (WebKit::WebPluginContainerImpl::frameRectsChanged): (WebKit::WebPluginContainerImpl::setParentVisible): (WebKit::WebPluginContainerImpl::setParent): (WebKit::WebPluginContainerImpl::invalidate): (WebKit::WebPluginContainerImpl::reportGeometry): (WebKit::WebPluginContainerImpl::clearScriptObjects): (WebKit::WebPluginContainerImpl::scriptableObjectForElement): (WebKit::WebPluginContainerImpl::executeScriptURL): (WebKit::WebPluginContainerImpl::loadFrameRequest): (WebKit::WebPluginContainerImpl::didReceiveResponse): (WebKit::WebPluginContainerImpl::didReceiveData): (WebKit::WebPluginContainerImpl::didFinishLoading): (WebKit::WebPluginContainerImpl::didFailLoading): (WebKit::WebPluginContainerImpl::scriptableObject): (WebKit::WebPluginContainerImpl::willDestroyPluginLoadObserver): (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent): (WebKit::WebPluginContainerImpl::calculateGeometry): (WebKit::WebPluginContainerImpl::windowClipRect): (WebKit::getObjectStack): (WebKit::checkStackOnTop): (WebKit::WebPluginContainerImpl::windowCutOutRects):
src/WebPluginContainerImpl.h: Added. (WebKit::WebPluginContainerImpl::create): (WebKit::WebPluginContainerImpl::plugin): (WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
src/WebPluginListBuilderImpl.cpp: Added. (WebKit::WebPluginListBuilderImpl::addPlugin): (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin): (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):
src/WebPluginListBuilderImpl.h: Added. (WebKit::WebPluginListBuilderImpl::WebPluginListBuilderImpl):
src/WebPluginLoadObserver.cpp: Added. (WebKit::WebPluginLoadObserver::~WebPluginLoadObserver): (WebKit::WebPluginLoadObserver::didFinishLoading): (WebKit::WebPluginLoadObserver::didFailLoading):
src/WebPluginLoadObserver.h: Added. (WebKit::WebPluginLoadObserver::WebPluginLoadObserver): (WebKit::WebPluginLoadObserver::url): (WebKit::WebPluginLoadObserver::clearPluginContainer):
src/WebPopupMenuImpl.cpp: Added. (WebKit::WebPopupMenu::create): (WebKit::WebPopupMenuImpl::WebPopupMenuImpl): (WebKit::WebPopupMenuImpl::~WebPopupMenuImpl): (WebKit::WebPopupMenuImpl::Init): (WebKit::WebPopupMenuImpl::MouseMove): (WebKit::WebPopupMenuImpl::MouseLeave): (WebKit::WebPopupMenuImpl::MouseDown): (WebKit::WebPopupMenuImpl::MouseUp): (WebKit::WebPopupMenuImpl::MouseWheel): (WebKit::WebPopupMenuImpl::KeyEvent): (WebKit::WebPopupMenuImpl::close): (WebKit::WebPopupMenuImpl::resize): (WebKit::WebPopupMenuImpl::layout): (WebKit::WebPopupMenuImpl::paint): (WebKit::WebPopupMenuImpl::handleInputEvent): (WebKit::WebPopupMenuImpl::mouseCaptureLost): (WebKit::WebPopupMenuImpl::setFocus): (WebKit::WebPopupMenuImpl::handleCompositionEvent): (WebKit::WebPopupMenuImpl::queryCompositionStatus): (WebKit::WebPopupMenuImpl::setTextDirection): (WebKit::WebPopupMenuImpl::repaint): (WebKit::WebPopupMenuImpl::scroll): (WebKit::WebPopupMenuImpl::screenToWindow): (WebKit::WebPopupMenuImpl::windowToScreen): (WebKit::WebPopupMenuImpl::scrollRectIntoView): (WebKit::WebPopupMenuImpl::scrollbarsModeDidChange): (WebKit::WebPopupMenuImpl::popupClosed):
src/WebPopupMenuImpl.h: Added. (WebKit::WebPopupMenuImpl::size): (WebKit::WebPopupMenuImpl::client): (WebKit::WebPopupMenuImpl::platformPageClient):
src/WebRange.cpp: Added. (WebKit::WebRange::reset): (WebKit::WebRange::assign): (WebKit::WebRange::startOffset): (WebKit::WebRange::endOffset): (WebKit::WebRange::startContainer): (WebKit::WebRange::endContainer): (WebKit::WebRange::toHTMLText): (WebKit::WebRange::toPlainText): (WebKit::WebRange::WebRange): (WebKit::WebRange::operator=): (WebKit::WebRange::operator WTF::PassRefPtr<WebCore::Range>):
src/WebRuntimeFeatures.cpp: Added. (WebKit::WebRuntimeFeatures::enableDatabase): (WebKit::WebRuntimeFeatures::isDatabaseEnabled): (WebKit::WebRuntimeFeatures::enableLocalStorage): (WebKit::WebRuntimeFeatures::isLocalStorageEnabled): (WebKit::WebRuntimeFeatures::enableSessionStorage): (WebKit::WebRuntimeFeatures::isSessionStorageEnabled): (WebKit::WebRuntimeFeatures::enableMediaPlayer): (WebKit::WebRuntimeFeatures::isMediaPlayerEnabled): (WebKit::WebRuntimeFeatures::enableSockets): (WebKit::WebRuntimeFeatures::isSocketsEnabled): (WebKit::WebRuntimeFeatures::enableNotifications): (WebKit::WebRuntimeFeatures::isNotificationsEnabled): (WebKit::WebRuntimeFeatures::enableApplicationCache): (WebKit::WebRuntimeFeatures::isApplicationCacheEnabled):

12:01 AM Changeset in webkit [50721] by eric@webkit.org

1 edit
9 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebFileInputElement...WebNotifications

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebInputElement.cpp: Added. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator WTF::PassRefPtr<HTMLInputElement>): (WebKit::WebInputElement::setActivatedSubmit): (WebKit::WebInputElement::setValue): (WebKit::WebInputElement::value): (WebKit::WebInputElement::setAutofilled): (WebKit::WebInputElement::dispatchFormControlChangeEvent): (WebKit::WebInputElement::setSelectionRange):
src/WebInputEvent.cpp: Added. (WebKit::staticKeyIdentifiers): (WebKit::WebKeyboardEvent::setKeyIdentifierFromWindowsKeyCode):
src/WebInputEventConversion.cpp: Added. (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder): (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): (WebKit::toPlatformKeyboardEventType): (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): (WebKit::PlatformKeyboardEventBuilder::setKeyType): (WebKit::PlatformKeyboardEventBuilder::isCharacterKey): (WebKit::getWebInputModifiers): (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
src/WebInputEventConversion.h: Added.
src/WebKit.cpp: Added. (WebKit::initialize): (WebKit::shutdown): (WebKit::webKitClient): (WebKit::setLayoutTestMode): (WebKit::layoutTestMode): (WebKit::resetPluginCache):
src/WebMediaPlayerClientImpl.cpp: Added. (WebKit::createWebMediaPlayer): (WebKit::WebMediaPlayerClientImpl::isEnabled): (WebKit::WebMediaPlayerClientImpl::setIsEnabled): (WebKit::WebMediaPlayerClientImpl::registerSelf): (WebKit::WebMediaPlayerClientImpl::networkStateChanged): (WebKit::WebMediaPlayerClientImpl::readyStateChanged): (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::timeChanged): (WebKit::WebMediaPlayerClientImpl::repaint): (WebKit::WebMediaPlayerClientImpl::durationChanged): (WebKit::WebMediaPlayerClientImpl::rateChanged): (WebKit::WebMediaPlayerClientImpl::sizeChanged): (WebKit::WebMediaPlayerClientImpl::sawUnsupportedTracks): (WebKit::WebMediaPlayerClientImpl::load): (WebKit::WebMediaPlayerClientImpl::cancelLoad): (WebKit::WebMediaPlayerClientImpl::play): (WebKit::WebMediaPlayerClientImpl::pause): (WebKit::WebMediaPlayerClientImpl::naturalSize): (WebKit::WebMediaPlayerClientImpl::hasVideo): (WebKit::WebMediaPlayerClientImpl::hasAudio): (WebKit::WebMediaPlayerClientImpl::setVisible): (WebKit::WebMediaPlayerClientImpl::duration): (WebKit::WebMediaPlayerClientImpl::currentTime): (WebKit::WebMediaPlayerClientImpl::seek): (WebKit::WebMediaPlayerClientImpl::seeking): (WebKit::WebMediaPlayerClientImpl::setEndTime): (WebKit::WebMediaPlayerClientImpl::setRate): (WebKit::WebMediaPlayerClientImpl::paused): (WebKit::WebMediaPlayerClientImpl::supportsFullscreen): (WebKit::WebMediaPlayerClientImpl::supportsSave): (WebKit::WebMediaPlayerClientImpl::setVolume): (WebKit::WebMediaPlayerClientImpl::networkState): (WebKit::WebMediaPlayerClientImpl::readyState): (WebKit::WebMediaPlayerClientImpl::maxTimeSeekable): (WebKit::WebMediaPlayerClientImpl::buffered): (WebKit::WebMediaPlayerClientImpl::dataRate): (WebKit::WebMediaPlayerClientImpl::totalBytesKnown): (WebKit::WebMediaPlayerClientImpl::totalBytes): (WebKit::WebMediaPlayerClientImpl::bytesLoaded): (WebKit::WebMediaPlayerClientImpl::setSize): (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::setAutobuffer): (WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin): (WebKit::WebMediaPlayerClientImpl::movieLoadType): (WebKit::WebMediaPlayerClientImpl::create): (WebKit::WebMediaPlayerClientImpl::getSupportedTypes): (WebKit::WebMediaPlayerClientImpl::supportsType): (WebKit::WebMediaPlayerClientImpl::WebMediaPlayerClientImpl):
src/WebMediaPlayerClientImpl.h: Added.
src/WebNode.cpp: Added. (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::parentNode): (WebKit::WebNode::nodeName): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator WTF::PassRefPtr<WebCore::Node>): (WebKit::WebNode::frame):
src/WebNotification.cpp: Added. (WebKit::WebNotification::reset): (WebKit::WebNotification::assign): (WebKit::WebNotification::lessThan): (WebKit::WebNotification::isHTML): (WebKit::WebNotification::url): (WebKit::WebNotification::icon): (WebKit::WebNotification::title): (WebKit::WebNotification::body): (WebKit::WebNotification::dispatchDisplayEvent): (WebKit::WebNotification::dispatchErrorEvent): (WebKit::WebNotification::dispatchCloseEvent): (WebKit::WebNotification::WebNotification): (WebKit::WebNotification::operator=): (WebKit::WebNotification::operator WTF::PassRefPtr<Notification>):

Nov 9, 2009:

11:54 PM Changeset in webkit [50720] by eric@webkit.org

1 edit
10 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebFileChooser...WebImageSkia

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebFileChooserCompletionImpl.cpp: Added. (WebKit::WebFileChooserCompletionImpl::WebFileChooserCompletionImpl): (WebKit::WebFileChooserCompletionImpl::~WebFileChooserCompletionImpl): (WebKit::WebFileChooserCompletionImpl::didChooseFile):
src/WebFileChooserCompletionImpl.h: Added.
src/WebFontCache.cpp: Added. (WebKit::WebFontCache::fontDataCount): (WebKit::WebFontCache::inactiveFontDataCount): (WebKit::WebFontCache::clear):
src/WebFormElement.cpp: Added. (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator WTF::PassRefPtr<WebCore::HTMLFormElement>): (WebKit::WebFormElement::autoComplete): (WebKit::WebFormElement::action): (WebKit::WebFormElement::submit): (WebKit::WebFormElement::getNamedElements):
src/WebFrameImpl.cpp: Added. (WebKit::frameContentAsPlainText): (WebKit::ChromePrintContext::ChromePrintContext): (WebKit::ChromePrintContext::begin): (WebKit::ChromePrintContext::getPageShrink): (WebKit::ChromePrintContext::spoolPage): (WebKit::DataSourceForDocLoader): (WebKit::WebFrameImpl::DeferredScopeStringMatches::DeferredScopeStringMatches): (WebKit::WebFrameImpl::DeferredScopeStringMatches::doTimeout): (WebKit::WebFrame::frameForEnteredContext): (WebKit::WebFrame::frameForCurrentContext): (WebKit::WebFrameImpl::name): (WebKit::WebFrameImpl::url): (WebKit::WebFrameImpl::favIconURL): (WebKit::WebFrameImpl::openSearchDescriptionURL): (WebKit::WebFrameImpl::scrollOffset): (WebKit::WebFrameImpl::contentsSize): (WebKit::WebFrameImpl::contentsPreferredWidth): (WebKit::WebFrameImpl::hasVisibleContent): (WebKit::WebFrameImpl::view): (WebKit::WebFrameImpl::opener): (WebKit::WebFrameImpl::parent): (WebKit::WebFrameImpl::top): (WebKit::WebFrameImpl::firstChild): (WebKit::WebFrameImpl::lastChild): (WebKit::WebFrameImpl::nextSibling): (WebKit::WebFrameImpl::previousSibling): (WebKit::WebFrameImpl::traverseNext): (WebKit::WebFrameImpl::traversePrevious): (WebKit::WebFrameImpl::findChildByName): (WebKit::WebFrameImpl::findChildByExpression): (WebKit::WebFrameImpl::forms): (WebKit::WebFrameImpl::securityOrigin): (WebKit::WebFrameImpl::grantUniversalAccess): (WebKit::WebFrameImpl::windowObject): (WebKit::WebFrameImpl::bindToWindowObject): (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInNewContext): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::addMessageToConsole): (WebKit::WebFrameImpl::collectGarbage): (WebKit::WebFrameImpl::mainWorldScriptContext): (WebKit::WebFrameImpl::insertStyleText): (WebKit::WebFrameImpl::reload): (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::loadData): (WebKit::WebFrameImpl::loadHTMLString): (WebKit::WebFrameImpl::isLoading): (WebKit::WebFrameImpl::stopLoading): (WebKit::WebFrameImpl::provisionalDataSource): (WebKit::WebFrameImpl::dataSource): (WebKit::WebFrameImpl::previousHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::enableViewSourceMode): (WebKit::WebFrameImpl::isViewSourceModeEnabled): (WebKit::WebFrameImpl::setReferrerForRequest): (WebKit::WebFrameImpl::dispatchWillSendRequest): (WebKit::WebFrameImpl::commitDocumentData): (WebKit::WebFrameImpl::unloadListenerCount): (WebKit::WebFrameImpl::isProcessingUserGesture): (WebKit::WebFrameImpl::willSuppressOpenerInNewFrame): (WebKit::WebFrameImpl::replaceSelection): (WebKit::WebFrameImpl::insertText): (WebKit::WebFrameImpl::setMarkedText): (WebKit::WebFrameImpl::unmarkText): (WebKit::WebFrameImpl::hasMarkedText): (WebKit::WebFrameImpl::markedRange): (WebKit::WebFrameImpl::executeCommand): (WebKit::WebFrameImpl::isCommandEnabled): (WebKit::WebFrameImpl::enableContinuousSpellChecking): (WebKit::WebFrameImpl::isContinuousSpellCheckingEnabled): (WebKit::WebFrameImpl::hasSelection): (WebKit::WebFrameImpl::selectionRange): (WebKit::WebFrameImpl::selectionAsText): (WebKit::WebFrameImpl::selectionAsMarkup): (WebKit::WebFrameImpl::printBegin): (WebKit::WebFrameImpl::getPrintPageShrink): (WebKit::WebFrameImpl::printPage): (WebKit::WebFrameImpl::printEnd): (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::stopFinding): (WebKit::WebFrameImpl::scopeStringMatches): (WebKit::WebFrameImpl::cancelPendingScopingEffort): (WebKit::WebFrameImpl::increaseMatchCount): (WebKit::WebFrameImpl::reportFindInPageSelection): (WebKit::WebFrameImpl::resetMatchCount): (WebKit::WebFrameImpl::completeURL): (WebKit::WebFrameImpl::contentAsText): (WebKit::WebFrameImpl::contentAsMarkup): (WebKit::WebFrameImpl::create): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl): (WebKit::WebFrameImpl::initializeAsMainFrame): (WebKit::WebFrameImpl::createChildFrame): (WebKit::WebFrameImpl::layout): (WebKit::WebFrameImpl::paint): (WebKit::WebFrameImpl::createFrameView): (WebKit::WebFrameImpl::fromFrame): (WebKit::WebFrameImpl::viewImpl): (WebKit::WebFrameImpl::dataSourceImpl): (WebKit::WebFrameImpl::provisionalDataSourceImpl): (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): (WebKit::WebFrameImpl::didFail): (WebKit::WebFrameImpl::setAllowsScrolling): (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::getPasswordListener): (WebKit::WebFrameImpl::closing): (WebKit::WebFrameImpl::invalidateArea): (WebKit::WebFrameImpl::addMarker): (WebKit::WebFrameImpl::setMarkerActive): (WebKit::WebFrameImpl::ordinalOfFirstMatchForFrame): (WebKit::WebFrameImpl::shouldScopeMatches): (WebKit::WebFrameImpl::scopeStringMatchesSoon): (WebKit::WebFrameImpl::callScopeStringMatches): (WebKit::WebFrameImpl::invalidateIfNecessary): (WebKit::WebFrameImpl::clearPasswordListeners): (WebKit::WebFrameImpl::loadJavaScriptURL):
src/WebFrameImpl.h: Added. (WebKit::WebFrameImpl::liveObjectCount): (WebKit::WebFrameImpl::frame): (WebKit::WebFrameImpl::frameView): (WebKit::WebFrameImpl::activeMatchFrame): (WebKit::WebFrameImpl::client): (WebKit::WebFrameImpl::dropClient): (WebKit::WebFrameImpl::ClientHandle::create): (WebKit::WebFrameImpl::ClientHandle::client): (WebKit::WebFrameImpl::ClientHandle::dropClient): (WebKit::WebFrameImpl::ClientHandle::ClientHandle): (WebKit::WebFrameImpl::):
src/WebHTTPBody.cpp: Added. (WebKit::WebHTTPBody::initialize): (WebKit::WebHTTPBody::reset): (WebKit::WebHTTPBody::assign): (WebKit::WebHTTPBody::elementCount): (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendData): (WebKit::WebHTTPBody::appendFile): (WebKit::WebHTTPBody::identifier): (WebKit::WebHTTPBody::setIdentifier): (WebKit::WebHTTPBody::WebHTTPBody): (WebKit::WebHTTPBody::operator=): (WebKit::WebHTTPBody::operator PassRefPtr<FormData>): (WebKit::WebHTTPBody::ensureMutable):
src/WebHistoryItem.cpp: Added. (WebKit::WebHistoryItem::initialize): (WebKit::WebHistoryItem::reset): (WebKit::WebHistoryItem::assign): (WebKit::WebHistoryItem::urlString): (WebKit::WebHistoryItem::setURLString): (WebKit::WebHistoryItem::originalURLString): (WebKit::WebHistoryItem::setOriginalURLString): (WebKit::WebHistoryItem::referrer): (WebKit::WebHistoryItem::setReferrer): (WebKit::WebHistoryItem::target): (WebKit::WebHistoryItem::setTarget): (WebKit::WebHistoryItem::parent): (WebKit::WebHistoryItem::setParent): (WebKit::WebHistoryItem::title): (WebKit::WebHistoryItem::setTitle): (WebKit::WebHistoryItem::alternateTitle): (WebKit::WebHistoryItem::setAlternateTitle): (WebKit::WebHistoryItem::lastVisitedTime): (WebKit::WebHistoryItem::setLastVisitedTime): (WebKit::WebHistoryItem::scrollOffset): (WebKit::WebHistoryItem::setScrollOffset): (WebKit::WebHistoryItem::isTargetItem): (WebKit::WebHistoryItem::setIsTargetItem): (WebKit::WebHistoryItem::visitCount): (WebKit::WebHistoryItem::setVisitCount): (WebKit::WebHistoryItem::documentState): (WebKit::WebHistoryItem::setDocumentState): (WebKit::WebHistoryItem::httpContentType): (WebKit::WebHistoryItem::setHTTPContentType): (WebKit::WebHistoryItem::httpBody): (WebKit::WebHistoryItem::setHTTPBody): (WebKit::WebHistoryItem::children): (WebKit::WebHistoryItem::setChildren): (WebKit::WebHistoryItem::appendToChildren): (WebKit::WebHistoryItem::WebHistoryItem): (WebKit::WebHistoryItem::operator=): (WebKit::WebHistoryItem::operator PassRefPtr<HistoryItem>): (WebKit::WebHistoryItem::ensureMutable):
src/WebImageCG.cpp: Added. (WebKit::WebImage::fromData): (WebKit::WebImage::reset): (WebKit::WebImage::assign): (WebKit::WebImage::isNull): (WebKit::WebImage::size): (WebKit::WebImage::WebImage): (WebKit::WebImage::operator=):
src/WebImageSkia.cpp: Added. (WebKit::WebImage::fromData): (WebKit::WebImage::reset): (WebKit::WebImage::assign): (WebKit::WebImage::isNull): (WebKit::WebImage::size): (WebKit::WebImage::WebImage): (WebKit::WebImage::operator=):

11:46 PM Changeset in webkit [50719] by eric@webkit.org

1 edit
7 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.src>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebData...WebElement

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebData.cpp: Added. (WebKit::WebData::reset): (WebKit::WebData::assign): (WebKit::WebData::size): (WebKit::WebData::data): (WebKit::WebData::WebData): (WebKit::WebData::operator=): (WebKit::WebData::operator PassRefPtr<SharedBuffer>):
src/WebDataSourceImpl.cpp: Added. (WebKit::WebDataSourceImpl::create): (WebKit::WebDataSourceImpl::originalRequest): (WebKit::WebDataSourceImpl::request): (WebKit::WebDataSourceImpl::response): (WebKit::WebDataSourceImpl::hasUnreachableURL): (WebKit::WebDataSourceImpl::unreachableURL): (WebKit::WebDataSourceImpl::redirectChain): (WebKit::WebDataSourceImpl::pageTitle): (WebKit::WebDataSourceImpl::navigationType): (WebKit::WebDataSourceImpl::triggeringEventTime): (WebKit::WebDataSourceImpl::extraData): (WebKit::WebDataSourceImpl::setExtraData): (WebKit::WebDataSourceImpl::toWebNavigationType): (WebKit::WebDataSourceImpl::endOfRedirectChain): (WebKit::WebDataSourceImpl::clearRedirectChain): (WebKit::WebDataSourceImpl::appendRedirect): (WebKit::WebDataSourceImpl::setNextPluginLoadObserver): (WebKit::WebDataSourceImpl::WebDataSourceImpl): (WebKit::WebDataSourceImpl::~WebDataSourceImpl):
src/WebDataSourceImpl.h: Added. (WebKit::WebDataSourceImpl::fromDocumentLoader): (WebKit::WebDataSourceImpl::hasRedirectChain): (WebKit::WebDataSourceImpl::releasePluginLoadObserver):
src/WebDatabase.cpp: Added. (WebKit::WebDatabase::reset): (WebKit::WebDatabase::assign): (WebKit::WebDatabase::name): (WebKit::WebDatabase::displayName): (WebKit::WebDatabase::estimatedSize): (WebKit::WebDatabase::securityOrigin): (WebKit::WebDatabase::setObserver): (WebKit::WebDatabase::observer): (WebKit::WebDatabase::updateDatabaseSize): (WebKit::WebDatabase::WebDatabase): (WebKit::WebDatabase::operator=): (WebKit::WebDatabase::operator WTF::PassRefPtr<Database>):
src/WebDevToolsAgentPrivate.h: Added.
src/WebDragData.cpp: Added. (WebKit::WebDragData::initialize): (WebKit::WebDragData::reset): (WebKit::WebDragData::assign): (WebKit::WebDragData::url): (WebKit::WebDragData::setURL): (WebKit::WebDragData::urlTitle): (WebKit::WebDragData::setURLTitle): (WebKit::WebDragData::fileExtension): (WebKit::WebDragData::setFileExtension): (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::plainText): (WebKit::WebDragData::setPlainText): (WebKit::WebDragData::htmlText): (WebKit::WebDragData::setHTMLText): (WebKit::WebDragData::htmlBaseURL): (WebKit::WebDragData::setHTMLBaseURL): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName): (WebKit::WebDragData::fileContent): (WebKit::WebDragData::setFileContent): (WebKit::WebDragData::WebDragData): (WebKit::WebDragData::operator=): (WebKit::WebDragData::operator WTF::PassRefPtr<WebCore::ChromiumDataObject>): (WebKit::WebDragData::ensureMutable):
src/WebElement.cpp: Added. (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator WTF::PassRefPtr<Element>):

11:23 PM Changeset in webkit [50718] by krit@webkit.org

3 edits
4 adds in trunk

2009-11-09 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG feDisplacementMap is not implemented
https://bugs.webkit.org/show_bug.cgi?id=31255

This is the implementation of the SVG filter effect
feDisplacementMap.

Test: svg/filters/feDisplacementMap.svg

svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):

Test for SVG filter effect feDisplacementMap.

platform/mac/svg/filters/feDisplacementMap-expected.checksum: Added.
platform/mac/svg/filters/feDisplacementMap-expected.png: Added.
platform/mac/svg/filters/feDisplacementMap-expected.txt: Added.
svg/filters/feDisplacementMap.svg: Added.

9:05 PM Changeset in webkit [50717] by eric@webkit.org

1 edit
4 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

WebPo*.h and WebRunetimeFeatures.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebPoint.h: Added. (WebKit::WebPoint::WebPoint): (WebKit::WebPoint::operator=): (WebKit::WebPoint::operator WebCore::IntPoint): (WebKit::WebPoint::operator gfx::Point): (WebKit::operator==): (WebKit::operator!=):
public/WebPopupMenu.h: Added.
public/WebPopupMenuInfo.h: Added. (WebKit::WebPopupMenuInfo::Item::):
public/WebRuntimeFeatures.h: Added.

8:58 PM Changeset in webkit [50716] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

WebPa*.h and WebPl*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebPasswordAutocompleteListener.h: Added. (WebKit::WebPasswordAutocompleteListener::~WebPasswordAutocompleteListener):
public/WebPasswordFormData.h: Added. (WebKit::WebPasswordFormData::isValid):
public/WebPlugin.h: Added. (WebKit::WebPlugin::~WebPlugin):
public/WebPluginContainer.h: Added. (WebKit::WebPluginContainer::~WebPluginContainer):
public/WebPluginListBuilder.h: Added.
public/WebPluginParams.h: Added.

8:50 PM Changeset in webkit [50715] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebBindging ... WebCursorInfo

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebBindings.cpp: Added. (WebKit::WebBindings::construct): (WebKit::WebBindings::createObject): (WebKit::WebBindings::enumerate): (WebKit::WebBindings::evaluate): (WebKit::WebBindings::evaluateHelper): (WebKit::WebBindings::getIntIdentifier): (WebKit::WebBindings::getProperty): (WebKit::WebBindings::getStringIdentifier): (WebKit::WebBindings::getStringIdentifiers): (WebKit::WebBindings::hasMethod): (WebKit::WebBindings::hasProperty): (WebKit::WebBindings::identifierIsString): (WebKit::WebBindings::intFromIdentifier): (WebKit::WebBindings::initializeVariantWithStringCopy): (WebKit::WebBindings::invoke): (WebKit::WebBindings::invokeDefault): (WebKit::WebBindings::releaseObject): (WebKit::WebBindings::releaseVariantValue): (WebKit::WebBindings::removeProperty): (WebKit::WebBindings::retainObject): (WebKit::WebBindings::setException): (WebKit::WebBindings::setProperty): (WebKit::WebBindings::unregisterObject): (WebKit::WebBindings::utf8FromIdentifier): (WebKit::WebBindings::extractIdentifierData): (WebKit::getEvent): (WebKit::getDragDataImpl): (WebKit::getRangeImpl): (WebKit::WebBindings::getDragData): (WebKit::WebBindings::isDragEvent): (WebKit::WebBindings::getRange):
src/WebCString.cpp: Added. (WebKit::WebCString::reset): (WebKit::WebCString::assign): (WebKit::WebCString::length): (WebKit::WebCString::data): (WebKit::WebCString::utf16): (WebKit::WebCString::fromUTF16): (WebKit::WebCString::WebCString): (WebKit::WebCString::operator=): (WebKit::WebCString::operator WebCore::CString):
src/WebCache.cpp: Added. (WebKit::ToResourceTypeStat): (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):
src/WebColor.cpp: Added. (WebKit::toCSSValueKeyword): (WebKit::setNamedColors):
src/WebCrossOriginPreflightResultCache.cpp: Added. (WebKit::WebCrossOriginPreflightResultCache::clear):
src/WebCursorInfo.cpp: Added. (WebKit::WebCursorInfo::WebCursorInfo):

8:43 PM Changeset in webkit [50714] by eric@webkit.org

1 edit
5 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Up-streaming Chromium API src files: WebAccessibilty

https://bugs.webkit.org/show_bug.cgi?id=31276

src/WebAccessibilityCache.cpp: Added. (WebKit::WebAccessibilityCache::enableAccessibility):
src/WebAccessibilityCacheImpl.cpp: Added. (WebKit::toAccessibilityObject): (WebKit::WebAccessibilityCache::create): (WebKit::WebAccessibilityCacheImpl::WeakHandle::create): (WebKit::WebAccessibilityCacheImpl::WeakHandle::WeakHandle): (WebKit::WebAccessibilityCacheImpl::WeakHandle::detach): (WebKit::WebAccessibilityCacheImpl::WebAccessibilityCacheImpl): (WebKit::WebAccessibilityCacheImpl::~WebAccessibilityCacheImpl): (WebKit::WebAccessibilityCacheImpl::initialize): (WebKit::WebAccessibilityCacheImpl::getObjectById): (WebKit::WebAccessibilityCacheImpl::isValidId): (WebKit::WebAccessibilityCacheImpl::remove): (WebKit::WebAccessibilityCacheImpl::clear): (WebKit::WebAccessibilityCacheImpl::addOrGetId):
src/WebAccessibilityCacheImpl.h: Added. (WebKit::WebAccessibilityCacheImpl::isInitialized):
src/WebAccessibilityObject.cpp: Added. (WebKit::WebAccessibilityObject::reset): (WebKit::WebAccessibilityObject::assign): (WebKit::WebAccessibilityObject::accessibilityDescription): (WebKit::WebAccessibilityObject::actionVerb): (WebKit::WebAccessibilityObject::canSetFocusAttribute): (WebKit::WebAccessibilityObject::childCount): (WebKit::WebAccessibilityObject::childAt): (WebKit::WebAccessibilityObject::firstChild): (WebKit::WebAccessibilityObject::focusedChild): (WebKit::WebAccessibilityObject::lastChild): (WebKit::WebAccessibilityObject::nextSibling): (WebKit::WebAccessibilityObject::parentObject): (WebKit::WebAccessibilityObject::previousSibling): (WebKit::WebAccessibilityObject::isAnchor): (WebKit::WebAccessibilityObject::isChecked): (WebKit::WebAccessibilityObject::isFocused): (WebKit::WebAccessibilityObject::isEnabled): (WebKit::WebAccessibilityObject::isHovered): (WebKit::WebAccessibilityObject::isIndeterminate): (WebKit::WebAccessibilityObject::isMultiSelect): (WebKit::WebAccessibilityObject::isOffScreen): (WebKit::WebAccessibilityObject::isPasswordField): (WebKit::WebAccessibilityObject::isPressed): (WebKit::WebAccessibilityObject::isReadOnly): (WebKit::WebAccessibilityObject::isVisited): (WebKit::WebAccessibilityObject::boundingBoxRect): (WebKit::WebAccessibilityObject::helpText): (WebKit::WebAccessibilityObject::hitTest): (WebKit::WebAccessibilityObject::keyboardShortcut): (WebKit::WebAccessibilityObject::performDefaultAction): (WebKit::WebAccessibilityObject::roleValue): (WebKit::WebAccessibilityObject::stringValue): (WebKit::WebAccessibilityObject::title): (WebKit::WebAccessibilityObject::WebAccessibilityObject): (WebKit::WebAccessibilityObject::operator=): (WebKit::WebAccessibilityObject::operator WTF::PassRefPtr<WebCore::AccessibilityObject>):

8:25 PM Changeset in webkit [50713] by oliver@apple.com

2 edits in trunk/WebKitTools

Make do-webcore-rename work with git.

Reviewed by Geoff Garen.

8:25 PM Changeset in webkit [50712] by eric@webkit.org

1 edit
17 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming Chromium API: Platform specific files

https://bugs.webkit.org/show_bug.cgi?id=28394

public/gtk/WebFontInfo.h: Added.
public/gtk/WebInputEventFactory.h: Added.
public/gtk/WebScreenInfoFactory.h: Added.
public/linux/WebFontRendering.h: Added.
public/linux/WebSandboxSupport.h: Added.
public/mac/WebInputEventFactory.h: Added.
public/mac/WebScreenInfoFactory.h: Added.
public/win/WebInputEventFactory.h: Added.
public/win/WebSandboxSupport.h: Added.
public/win/WebScreenInfoFactory.h: Added.
public/win/WebThemeEngine.h: Added.
public/x11/WebScreenInfoFactory.h: Added.

8:14 PM Changeset in webkit [50711] by ggaren@apple.com

5 edits in trunk/JavaScriptCore

Imported the v8 DST cache.

Reviewed by Oliver Hunt.

SunSpider says 1.5% faster.

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache): Reset the DST cache when resetting
other date data.

runtime/JSGlobalData.h:

(JSC::DSTOffsetCache::DSTOffsetCache):
(JSC::DSTOffsetCache::reset): Added a struct for the DST cache.

wtf/DateMath.cpp:

(WTF::calculateDSTOffsetSimple):
(WTF::calculateDSTOffset):
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getDSTOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

wtf/DateMath.h: The imported code for probing and updating the cache.

8:06 PM Changeset in webkit [50710] by hamaji@chromium.org

4 edits in trunk/LayoutTests

2009-11-03 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

wrong expected images after Bug 8736
https://bugs.webkit.org/show_bug.cgi?id=31094

platform/mac/fast/borders/border-radius-huge-assert-expected.png:
platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
platform/mac/fast/box-shadow/border-radius-big-expected.png:

7:58 PM Changeset in webkit [50709] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Fixed an edge case that could cause the engine not to notice a timezone
change.

Reviewed by Oliver Hunt.

No test because this case would require manual intervention to change
the timezone during the test.

SunSpider reports no change.

runtime/DateInstanceCache.h:

(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::reset): Added a helper function for resetting
this cache. Also, shrank the cache, since we'll be resetting it often.

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache): Include resetting the DateInstanceCache
in resetting Date data. (Otherwise, a cache hit could bypass a necessary
timezone update check.)

7:39 PM Changeset in webkit [50708] by ggaren@apple.com

7 edits in trunk/JavaScriptCore

Some manual inlining and constant propogation in Date code.

Reviewed by Sam Weinig.

SunSpider reports a 0.4% speedup on date-*, no overall speedup. Shark
says some previously evident stalls are now gone.

runtime/DateConstructor.cpp:

(JSC::callDate):

runtime/DateConversion.cpp:

(JSC::formatTime):
(JSC::formatTimeUTC): Split formatTime into UTC and non-UTC variants.

runtime/DateConversion.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):

runtime/DateInstance.h:

(JSC::DateInstance::gregorianDateTime):
(JSC::DateInstance::gregorianDateTimeUTC): Split gregorianDateTime into
a UTC and non-UTC variant, and split each variant into a fast inline
case and a slow out-of-line case.

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Updated for the gregorianDateTime change above.

7:35 PM Changeset in webkit [50707] by hamaji@chromium.org

2 edits in trunk/LayoutTests

Reviewed by Oliver Hunt.

Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198

Fixed wrong expectation file committed.

fast/js/dictionary-prototype-caching-expected.txt:

7:31 PM Changeset in webkit [50706] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Build fix: export a new symbol.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

7:14 PM Changeset in webkit [50705] by ggaren@apple.com

7 edits in trunk/JavaScriptCore

Added a tiny cache for Date parsing.

Reviewed by Sam "Home Wrecker" Weinig.

SunSpider says 1.2% faster.

runtime/DateConversion.cpp:

(JSC::parseDate): Try to reuse the last parsed Date, if present.

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache):

runtime/JSGlobalData.h: Added storage for last parsed Date. Refactored

this code to make resetting the date cache easier.

runtime/JSGlobalObject.h:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
refactoring.

wtf/DateMath.cpp:

(JSC::parseDateFromNullTerminatedCharacters):

wtf/DateMath.h: Changed ExecState to be first parameter, as is the JSC custom.

6:50 PM WebKit Team edited by tonikitoo@webkit.org

(diff)

6:19 PM Changeset in webkit [50704] by oliver@apple.com

9 edits
3 adds in trunk

Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198

Reviewed by Gavin Barraclough.

Replace fromDictionaryTransition with flattenDictionaryObject and
flattenDictionaryStructure. This change is necessary as we need to
guarantee that our attempt to convert away from a dictionary structure
will definitely succeed, and in some cases this requires mutating the
object storage itself.

5:51 PM Changeset in webkit [50703] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Not reviewed, build fix.

Remove extra character from r50701.

JavaScriptCore.pri:

5:46 PM Changeset in webkit [50702] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add a comment about null strings and hash functions.
https://bugs.webkit.org/show_bug.cgi?id=29118

platform/text/StringHash.h:

5:39 PM Changeset in webkit [50701] by Laszlo Gombos

2 edits in trunk/JavaScriptCore

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Not reviewed, build fix.

Revert r50695 because it broke QtWebKit (clean builds).

JavaScriptCore.pri:

5:24 PM Changeset in webkit [50700] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Darin Adler.

Compiler warnings in InspectorResource.h
https://bugs.webkit.org/show_bug.cgi?id=29231

Fix compilation warnings by removing addition operation on an enum type.

inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::Changes::hasChange): (WebCore::InspectorResource::Changes::set): (WebCore::InspectorResource::Changes::setAll):

5:12 PM Changeset in webkit [50699] by eric@webkit.org

2 edits in trunk

2009-11-09 Priit Laes <plaes@plaes.org>

Reviewed by Oliver Hunt.

[Gtk] Build from tarball fails with --enable-introspection
https://bugs.webkit.org/show_bug.cgi?id=31261

We need to enable gobject-introspection during distcheck otherwise
some of the required files are missing in tarball.

GNUmakefile.am:

4:46 PM Changeset in webkit [50698] by andersca@apple.com

3 edits
2 adds in trunk

WebCore: <rdar://problem/7328395>
https://bugs.webkit.org/show_bug.cgi?id=31277

Reviewed by Darin Adler and Dan Bernstein.

When an object tag's style changes (for example when child nodes are added/removed),
reuse its Frame (if it has one) instead of creating multiple Frames.

Test: fast/dom/HTMLObjectElement/children-changed.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::requestObject):

LayoutTests: <rdar://problem/7328395>
https://bugs.webkit.org/show_bug.cgi?id=31277

Reviewed by Darin Adler and Dan Bernstein.

When an object tag's style changes (for example when child nodes are added/removed),
reuse its Frame (if it has one) instead of creating multiple Frames.

fast/dom/HTMLObjectElement/children-changed-expected.txt: Added.
fast/dom/HTMLObjectElement/children-changed.html: Added.

3:18 PM Changeset in webkit [50697] by levin@chromium.org

2 edits in trunk/WebKit/chromium

Change struct ResourceRequest to class ResourceRequest per
http://trac.webkit.org/changeset/50625.

Reviewed by Dmitry Titov.

public/WebURLRequest.h:

2:41 PM Changeset in webkit [50696] by Nate Chapin

1 edit
4 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream remaining Chromium API WebN*.h headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

2:34 PM Changeset in webkit [50695] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-09 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro.
Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore),
and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).

JavaScriptCore.pri:

2:34 PM Changeset in webkit [50694] by Nate Chapin

1 edit
5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream Chromium API headers WebMessage through WebNavigation.

https://bugs.webkit.org/show_bug.cgi?id=28394

2:27 PM Changeset in webkit [50693] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
since adjustment of RW-section base address will be needed for all new symbian
tool chains, specifically for arm and gcc compilation targets.
Also, change target address to 0xE00000 to be sufficient for all targets.

WebCore.pro:

2:19 PM Changeset in webkit [50692] by eric@webkit.org

1 edit
9 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebScreenInfo to WebSharedWorkerRepo.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebScreenInfo.h: Added. (WebKit::WebScreenInfo::WebScreenInfo):
public/WebScriptController.h: Added.
public/WebScriptSource.h: Added. (WebKit::WebScriptSource::WebScriptSource):
public/WebSearchableFormData.h: Added. (WebKit::WebSearchableFormData::isValid): (WebKit::WebSearchableFormData::url): (WebKit::WebSearchableFormData::encoding):
public/WebSecurityOrigin.h: Added. (WebKit::WebSecurityOrigin::~WebSecurityOrigin): (WebKit::WebSecurityOrigin::WebSecurityOrigin): (WebKit::WebSecurityOrigin::operator=): (WebKit::WebSecurityOrigin::isNull):
public/WebSecurityPolicy.h: Added.
public/WebSettings.h: Added. (WebKit::WebSettings::~WebSettings):
public/WebSharedWorker.h: Added. (WebKit::WebSharedWorker::~WebSharedWorker):
public/WebSharedWorkerRepository.h: Added.

2:11 PM Changeset in webkit [50691] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Crash when inspecting
WebCore\manual-tests\inspector\dom-mutation.html

https://bugs.webkit.org/show_bug.cgi?id=31259

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::handleEvent):

2:08 PM Changeset in webkit [50690] by Nate Chapin

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream Chromium API headers Webkit.h thru WebMediaPlayerClient.h.

https://bugs.webkit.org/show_bug.cgi?id=28394

2:00 PM Changeset in webkit [50689] by Nate Chapin

1 edit
5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream rest of WebH*.h and WebI*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

1:55 PM Changeset in webkit [50688] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Upstreaming the Chromium WebKit API: WebSockets and WebStorage.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebSocketStreamError.h: Added.
public/WebSocketStreamHandle.h: Added. (WebKit::WebSocketStreamHandle::~WebSocketStreamHandle):
public/WebSocketStreamHandleClient.h: Added.
public/WebStorageArea.h: Added. (WebKit::WebStorageArea::~WebStorageArea):
public/WebStorageEventDispatcher.h: Added. (WebKit::WebStorageEventDispatcher::~WebStorageEventDispatcher):
public/WebStorageNamespace.h: Added. (WebKit::WebStorageNamespace::~WebStorageNamespace):

1:47 PM Changeset in webkit [50687] by eric@webkit.org

1 edit
4 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebString and other basic objects.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebRange.h: Added. (WebKit::WebRange::~WebRange): (WebKit::WebRange::WebRange): (WebKit::WebRange::operator=): (WebKit::WebRange::isNull):
public/WebRect.h: Added. (WebKit::WebRect::isEmpty): (WebKit::WebRect::WebRect): (WebKit::WebRect::operator=): (WebKit::WebRect::operator WebCore::IntRect): (WebKit::WebRect::operator gfx::Rect): (WebKit::operator==): (WebKit::operator!=):
public/WebSize.h: Added. (WebKit::WebSize::isEmpty): (WebKit::WebSize::WebSize): (WebKit::WebSize::operator=): (WebKit::WebSize::operator WebCore::IntSize): (WebKit::WebSize::operator gfx::Size): (WebKit::operator==): (WebKit::operator!=):
public/WebString.h: Added. (WebKit::WebString::~WebString): (WebKit::WebString::WebString): (WebKit::WebString::operator=): (WebKit::WebString::isEmpty): (WebKit::WebString::isNull): (WebKit::WebString::operator string16): (WebKit::WebString::operator NullableString16): (WebKit::WebString::fromUTF8):

1:40 PM Changeset in webkit [50686] by eric@webkit.org

1 edit
2 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Upstreaming the Chromium WebKit API: WebText*

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebTextAffinity.h: Added. (WebKit::):
public/WebTextDirection.h: Added. (WebKit::):

1:28 PM Changeset in webkit [50685] by Nate Chapin

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream remainder of WebE*.h and WebF*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

1:27 PM Changeset in webkit [50684] by eric@webkit.org

4 edits in trunk

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Few classes have virtual functions but non-virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=31269

No new tests as there is no functional change.

platform/qt/QWebPageClient.h: (QWebPageClient::~QWebPageClient): Add virtual destructor.

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Few classes have virtual functions but non-virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=31269

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): Add virtual destructor.

1:19 PM Changeset in webkit [50683] by Nate Chapin

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream WebDevTools*.h and WebDrag*.h Chromium API headers.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebDevToolsAgent.h: Added. (WebKit::WebDevToolsAgent::~WebDevToolsAgent):
public/WebDevToolsAgentClient.h: Added. (WebKit::WebDevToolsAgentClient::~WebDevToolsAgentClient):
public/WebDevToolsFrontend.h: Added. (WebKit::WebDevToolsFrontend::~WebDevToolsFrontend):
public/WebDevToolsFrontendClient.h: Added. (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient): (WebKit::WebDevToolsFrontendClient::~WebDevToolsFrontendClient):
public/WebDragData.h: Added. (WebKit::WebDragData::~WebDragData): (WebKit::WebDragData::WebDragData): (WebKit::WebDragData::operator=): (WebKit::WebDragData::isNull):
public/WebDragOperation.h: Added.

1:14 PM Changeset in webkit [50682] by eric@webkit.org

1 edit
6 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebURL and friends.

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebURL.h: Added. (WebKit::WebURL::~WebURL): (WebKit::WebURL::WebURL): (WebKit::WebURL::operator=): (WebKit::WebURL::assign): (WebKit::WebURL::spec): (WebKit::WebURL::parsed): (WebKit::WebURL::isValid): (WebKit::WebURL::isEmpty): (WebKit::WebURL::isNull): (WebKit::WebURL::operator GURL):
public/WebURLError.h: Added. (WebKit::WebURLError::WebURLError):
public/WebURLLoader.h: Added. (WebKit::WebURLLoader::~WebURLLoader):
public/WebURLLoaderClient.h: Added. (WebKit::WebURLLoaderClient::~WebURLLoaderClient):
public/WebURLRequest.h: Added. (WebKit::WebURLRequest::): (WebKit::WebURLRequest::~WebURLRequest): (WebKit::WebURLRequest::WebURLRequest): (WebKit::WebURLRequest::operator=):
public/WebURLResponse.h: Added. (WebKit::WebURLResponse::~WebURLResponse): (WebKit::WebURLResponse::WebURLResponse): (WebKit::WebURLResponse::operator=):

1:06 PM Changeset in webkit [50681] by eric@webkit.org

1 edit
7 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebVector to WebWorkerClient

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebVector.h: Added. (WebKit::WebVector::~WebVector): (WebKit::WebVector::WebVector): (WebKit::WebVector::operator=): (WebKit::WebVector::assign): (WebKit::WebVector::size): (WebKit::WebVector::isEmpty): (WebKit::WebVector::operator[]): (WebKit::WebVector::data): (WebKit::WebVector::swap): (WebKit::WebVector::initialize): (WebKit::WebVector::initializeFrom): (WebKit::WebVector::destroy):
public/WebView.h: Added. (WebKit::WebView::~WebView):
public/WebViewClient.h: Added. (WebKit::WebViewClient::createView): (WebKit::WebViewClient::createPopupMenu): (WebKit::WebViewClient::didAddMessageToConsole): (WebKit::WebViewClient::printPage): (WebKit::WebViewClient::notificationPresenter): (WebKit::WebViewClient::didStartLoading): (WebKit::WebViewClient::didStopLoading): (WebKit::WebViewClient::shouldBeginEditing): (WebKit::WebViewClient::shouldEndEditing): (WebKit::WebViewClient::shouldInsertNode): (WebKit::WebViewClient::shouldInsertText): (WebKit::WebViewClient::shouldChangeSelectedRange): (WebKit::WebViewClient::shouldDeleteRange): (WebKit::WebViewClient::shouldApplyStyle): (WebKit::WebViewClient::isSmartInsertDeleteEnabled): (WebKit::WebViewClient::isSelectTrailingWhitespaceEnabled): (WebKit::WebViewClient::setInputMethodEnabled): (WebKit::WebViewClient::didBeginEditing): (WebKit::WebViewClient::didChangeSelection): (WebKit::WebViewClient::didChangeContents): (WebKit::WebViewClient::didExecuteCommand): (WebKit::WebViewClient::didEndEditing): (WebKit::WebViewClient::handleCurrentKeyboardEvent): (WebKit::WebViewClient::spellCheck): (WebKit::WebViewClient::autoCorrectWord): (WebKit::WebViewClient::showSpellingUI): (WebKit::WebViewClient::isShowingSpellingUI): (WebKit::WebViewClient::updateSpellingUIWithMisspelledWord): (WebKit::WebViewClient::runFileChooser): (WebKit::WebViewClient::runModalAlertDialog): (WebKit::WebViewClient::runModalConfirmDialog): (WebKit::WebViewClient::runModalPromptDialog): (WebKit::WebViewClient::runModalBeforeUnloadDialog): (WebKit::WebViewClient::setStatusText): (WebKit::WebViewClient::setMouseOverURL): (WebKit::WebViewClient::setKeyboardFocusURL): (WebKit::WebViewClient::setToolTipText): (WebKit::WebViewClient::showContextMenu): (WebKit::WebViewClient::startDragging): (WebKit::WebViewClient::acceptsLoadDrops): (WebKit::WebViewClient::focusNext): (WebKit::WebViewClient::focusPrevious): (WebKit::WebViewClient::navigateBackForwardSoon): (WebKit::WebViewClient::historyBackListCount): (WebKit::WebViewClient::historyForwardListCount): (WebKit::WebViewClient::didAddHistoryItem): (WebKit::WebViewClient::focusAccessibilityObject): (WebKit::WebViewClient::didUpdateInspectorSettings): (WebKit::WebViewClient::queryAutofillSuggestions): (WebKit::WebViewClient::removeAutofillSuggestions): (WebKit::WebViewClient::~WebViewClient):
public/WebWidget.h: Added. (WebKit::WebWidget::~WebWidget):
public/WebWidgetClient.h: Added. (WebKit::WebWidgetClient::didInvalidateRect): (WebKit::WebWidgetClient::didScrollRect): (WebKit::WebWidgetClient::didFocus): (WebKit::WebWidgetClient::didBlur): (WebKit::WebWidgetClient::didChangeCursor): (WebKit::WebWidgetClient::closeWidgetSoon): (WebKit::WebWidgetClient::show): (WebKit::WebWidgetClient::runModal): (WebKit::WebWidgetClient::windowRect): (WebKit::WebWidgetClient::setWindowRect): (WebKit::WebWidgetClient::windowResizerRect): (WebKit::WebWidgetClient::rootWindowRect): (WebKit::WebWidgetClient::screenInfo): (WebKit::WebWidgetClient::~WebWidgetClient):
public/WebWorker.h: Added. (WebKit::WebWorker::~WebWorker):
public/WebWorkerClient.h: Added. (WebKit::WebWorkerClient::~WebWorkerClient):

12:55 PM Changeset in webkit [50680] by Nate Chapin

1 edit
4 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream WebData*.h Chromium API files.

https://bugs.webkit.org/show_bug.cgi?id=28394

12:46 PM Changeset in webkit [50679] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
https://bugs.webkit.org/show_bug.cgi?id=31140

Test that XHR request can set http headers with no value.

http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value-expected.txt: Added.
http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html: Added.

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
https://bugs.webkit.org/show_bug.cgi?id=31140

QtNetwork interprets null string as request to remove the header, not add it.
Replace null values with empty values before passing them to QtNetwork.

Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html

platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):

12:43 PM Changeset in webkit [50678] by Nate Chapin

1 edit
5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Upstream the last of the Chromium API WebC*.h files.

https://bugs.webkit.org/show_bug.cgi?id=28394

12:32 PM Changeset in webkit [50677] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
simply ignored before resulting in transparent areas being black in PNG
images for example.

https://bugs.webkit.org/show_bug.cgi?id=30823

12:22 PM Changeset in webkit [50676] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=30628
Add an API to get all the attributes from a QWebElement.

Api/qwebelement.cpp: (QWebElement::attributesName):
Api/qwebelement.h:
tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::listAttributes):

12:04 PM Changeset in webkit [50675] by eric@webkit.org

19 edits in trunk

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040

interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040

No new tests as there is no functional change.

dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
editing/TextIterator.cpp: (WebCore::pushFullyClippedState):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::mustLockBackForwardList):
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::computeHash):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
svg/SVGAnimateElement.cpp: (WebCore::parseNumberValueAndUnit):
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::startedActiveInterval):
svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM):

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040

Api/qwebpage.cpp: (QWebPagePrivate::handleScrolling):

11:50 AM Changeset in webkit [50674] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

Win chromium is slow to draw transparent texts
https://bugs.webkit.org/show_bug.cgi?id=31258

Clip graphics context to reduce calculation.

No new tests because this change only affects performance.

platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):

11:43 AM Changeset in webkit [50673] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

showTree(CounterNode*) generates too little info and has too many spaces.
https://bugs.webkit.org/show_bug.cgi?id=31212

No new tests as the change has no functional effect it is just for
improved debugging.

rendering/CounterNode.cpp: (WebCore::showTreeAndMark): Changed to also show addresses of parent, next and previous siblings.

11:34 AM Changeset in webkit [50672] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-09 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).

https://bugs.webkit.org/show_bug.cgi?id=31083

No new tests; implementation is unchanged.

page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntry):
page/mac/FrameMac.mm:

11:32 AM Changeset in webkit [50671] by Nate Chapin

1 edit
5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

More WebC*.h upstreaming.

https://bugs.webkit.org/show_bug.cgi?id=28394

11:26 AM Changeset in webkit [50670] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Jan Alonzo.

Make XP_UNIX tests consistent
https://bugs.webkit.org/show_bug.cgi?id=31250

No new tests as there is no functional change.

plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined instead of the value of the macro

plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is defined instead of using the PLATFORM macro to be consistent (WebCore::PluginView::getValue): Ditto.

11:18 AM Changeset in webkit [50669] by eric@webkit.org

1 edit
4 adds in trunk/WebKit/chromium

2009-11-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Upstreaming the Chromium WebKit API: WebNode.h and friends are thin wrappers around WebCore::Nodes

https://bugs.webkit.org/show_bug.cgi?id=28394

public/WebElement.h: Added. (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::assign):
public/WebFormElement.h: Added. (WebKit::WebFormElement::~WebFormElement): (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::assign):
public/WebInputElement.h: Added. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
public/WebNode.h: Added. (WebKit::WebNode::~WebNode): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::isNull): (WebKit::WebNode::toElement): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):

11:08 AM Changeset in webkit [50668] by Nate Chapin

1 edit
5 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

WebKit Chromium API upstreaming, WebBindings.h through WebColor.h.

public/WebBindings.h: Added.
public/WebCache.h: Added.
public/WebCanvas.h: Added.
public/WebClipboard.h: Added. (WebKit::WebClipboard::): (WebKit::WebClipboard::~WebClipboard):
public/WebColor.h: Added.

10:48 AM Changeset in webkit [50667] by Nate Chapin

7 adds in trunk/WebKit/chromium

2009-11-09 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Starting upstreaming the Chromium WebKit API. public/ contains header files only.

https://bugs.webkit.org/show_bug.cgi?id=28394

ChangeLog: First!!
public: Added.
public/WebAccessibilityCache.h: Added. (WebKit::WebAccessibilityCache::WebAccessibilityCache): (WebKit::WebAccessibilityCache::~WebAccessibilityCache):
public/WebAccessibilityObject.h: Added. (WebKit::WebAccessibilityObject::~WebAccessibilityObject): (WebKit::WebAccessibilityObject::WebAccessibilityObject): (WebKit::WebAccessibilityObject::operator=): (WebKit::WebAccessibilityObject::isNull):
public/WebAccessibilityRole.h: Added. (WebKit::):
public/WebApplicationCacheHost.h: Added. (WebKit::WebApplicationCacheHost::): (WebKit::WebApplicationCacheHost::~WebApplicationCacheHost):
public/WebApplicationCacheHostClient.h: Added. (WebKit::WebApplicationCacheHostClient::~WebApplicationCacheHostClient):

10:23 AM Changeset in webkit [50666] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Darin Adler.

Thunk to the main thread from ~Database to deref Database's m_document.

If the Database was the Document's last referrer, then ~Document occurs on the
Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
ASSERT in debug builds.

storage/Database.cpp: (WebCore::derefDocument): (WebCore::Database::~Database):

9:54 AM Changeset in webkit [50665] by eric@webkit.org

10 edits
2 adds in trunk

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

fast/overflow/scrollbar-restored-expected.txt: Added.
fast/overflow/scrollbar-restored.html: Added.

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

Test: fast/overflow/scrollbar-restored.html

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::setCanHaveScrollbars): (WebCore::FrameView::updateCanHaveScrollbars): (WebCore::FrameView::layout):
page/FrameView.h:
platform/ScrollView.h:

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

Test: fast/overflow/scrollbar-restored.html

WebView/WebFrameView.mm: (-[WebFrameView _install]):

2009-11-09 Mark Mentovai <mark@chromium.org>

Reviewed by Dan Bernstein.

Track "can have scrollbar" state within FrameView independently of the
individual scrollbar states in ScrollView.

rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
REGRESSION (r48064): mint.com loses scrollbars after coming out of
edit mode.

rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

Test: fast/overflow/scrollbar-restored.html

Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):

9:44 AM Changeset in webkit [50664] by eric@webkit.org

5 edits in trunk

2009-11-09 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
https://bugs.webkit.org/show_bug.cgi?id=31257

inspector/syntax-highlight-css-expected.txt:
inspector/syntax-highlight-css.html:

2009-11-09 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
https://bugs.webkit.org/show_bug.cgi?id=31257

inspector/front-end/SourceFrame.js:

9:37 AM Changeset in webkit [50663] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2009-11-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
https://bugs.webkit.org/show_bug.cgi?id=31252

Route F1-F12 keypresses in the Console view to the current panel if there is one.

Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._promptKeyDown):
inspector/front-end/utilities.js: ():
manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.

9:26 AM Changeset in webkit [50662] by kenneth@webkit.org

2 edits in trunk/WebCore

2009-11-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Pass credentials provided by XMLHTTPRequest to the network request.
https://bugs.webkit.org/show_bug.cgi?id=31208

After r42483, the credentials are no longer passed to the network request
in the URL of the request.
Pass the credentials from XMLHTTPRequest to the network request, the same
way that other ports do.

After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.

platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):

9:22 AM Changeset in webkit [50661] by kenneth@webkit.org

3 edits in trunk/WebKit/qt

2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=30772
Add a non-const iterator to QWebElementCollection.
Move the two attributes of the iterator to private.

Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::constBegin): (const_iterator::constEnd): (const_iterator::iterator::iterator): (const_iterator::iterator::operator*): (const_iterator::iterator::operator==): (const_iterator::iterator::operator!=): (const_iterator::iterator::operator<): (const_iterator::iterator::operator<=): (const_iterator::iterator::operator>): (const_iterator::iterator::operator>=): (const_iterator::iterator::operator++): (const_iterator::iterator::operator--): (const_iterator::iterator::operator+=): (const_iterator::iterator::operator-=): (const_iterator::iterator::operator+): (const_iterator::iterator::operator-):
tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::nonConstIterator): (tst_QWebElement::constIterator):

9:11 AM ImprovingLifeOnWindows edited by Adam Roben

Added bug number for setting environment variables automatically (diff)

8:12 AM Changeset in webkit [50660] by Simon Hausmann

2 edits in trunk/WebKitTools

Adding Kenneth to the reviewers list.

Scripts/modules/committers.py:

7:38 AM Changeset in webkit [50659] by Laszlo Gombos

4 edits in trunk/WebKit/qt

2009-11-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Christiansen.

[Qt] Remove the sessionStorage setting (per Page)
https://bugs.webkit.org/show_bug.cgi?id=31249

This setting allows to run sessionStorage on/off on a per page
basis. Remove this prematurely exposed API.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database): (tst_QWebPage::testOptionalJSObjects):

7:34 AM Changeset in webkit [50658] by zoltan@webkit.org

10 edits in trunk/WebCore

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=31161

Roll back r50657 because it breaks the MAC builds.

loader/ImageLoader.cpp:
loader/ProgressTracker.cpp:
loader/RedirectScheduler.cpp:
loader/Request.h:
loader/ThreadableLoaderClient.h:
loader/WorkerThreadableLoader.h:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheStorage.h:
loader/icon/IconDatabaseClient.h:

7:22 AM Changeset in webkit [50657] by zoltan@webkit.org

10 edits in trunk/WebCore

Allow custom memory allocation control for the part of loader directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31161

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169

Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.

ThreadableLoaderClient's inheriting has been changed to public.

loader/ImageLoader.cpp:
loader/ProgressTracker.cpp:
loader/RedirectScheduler.cpp:
loader/Request.h:
loader/ThreadableLoaderClient.h:
loader/WorkerThreadableLoader.h:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheStorage.h:
loader/icon/IconDatabaseClient.h:

6:59 AM Changeset in webkit [50656] by Simon Hausmann

5 edits in trunk/WebKit/qt

[Qt] Remove the QWebPage:webInspectorTriggered signal.
User customization of the communication between QWebPage
and QWebInspector will be properly designed in the next version.
https://bugs.webkit.org/show_bug.cgi?id=30773

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-09
Reviewed by Simon Hausmann.

Api/qwebinspector.cpp:
Api/qwebpage.cpp:

(QWebPagePrivate::getOrCreateInspector):
(QWebPage::triggerAction):

Api/qwebpage.h:
QtLauncher/main.cpp:

(MainWindow::MainWindow):

6:27 AM Changeset in webkit [50655] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's DocLoader
https://bugs.webkit.org/show_bug.cgi?id=31163

Reviewed by Darin Adler.

Inherits DocLoader class from Noncopyable because it is
instantiated by 'new' in WebCore/dom/Document.cpp:370 and
it is no need to be copyable.

loader/DocLoader.h:

6:22 AM Changeset in webkit [50654] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=31162

Reviewed by Darin Adler.

Inherits Tokenizer class from Noncopyable because (its child class)
ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
and it is no need to be copyable.

dom/Tokenizer.h:

6:14 AM Changeset in webkit [50653] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's DeleteButtonController
https://bugs.webkit.org/show_bug.cgi?id=31105

Reviewed by Darin Adler.

Inherits DeleteButtonController class from Noncopyable because it is
instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
it is no need to be copyable.

editing/DeleteButtonController.h:

5:10 AM Changeset in webkit [50652] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

Added a missing re-implementation of QGraphicsItem::inputMethodQuery().

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05
Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::inputMethodQuery):

Api/qgraphicswebview.h:

5:09 AM Changeset in webkit [50651] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

Provide a dummy re-implementation of QGraphicsLayoutItem::sizeHint(),
similar to QWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::sizeHint):

Api/qgraphicswebview.h:

5:08 AM Changeset in webkit [50650] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

Removed zoomFactoryChanged() signal and added
linkClicked() to QGraphicsWebView, for consistency with
QWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::setPage):
(QGraphicsWebView::setZoomFactor):

Api/qgraphicswebview.h:

5:07 AM Changeset in webkit [50649] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

Added QGraphicsWebView::findText() for convenience and consistency
with QWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::findText):

Api/qgraphicswebview.h:

5:06 AM Changeset in webkit [50648] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

Added QGraphicsWebView::pageAction() and triggerPageAction(), for
consistency with QWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::pageAction):
(QGraphicsWebView::triggerPageAction):

Api/qgraphicswebview.h:

4:35 AM Changeset in webkit [50647] by vestbo@webkit.org

4 edits in trunk/WebKit/qt

Removed QGraphicsWebView::toHtml() after API review.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

That's consistent with QWebView and also based on the assumption that
toHtml() is called less frequently than setHtml().

Api/qgraphicswebview.cpp:
Api/qgraphicswebview.h:
tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

4:31 AM Changeset in webkit [50646] by vestbo@webkit.org

4 edits in trunk/WebKit/qt

Removed the interactive property of QGraphicsWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

There are clearly use-cases for this feature, but it will require
more work to make this fully work with an enum to have fine-grained
control over the interactivity levels. For now it is easy to achieve
in user-code what the boolean property did.

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::hoverMoveEvent):
(QGraphicsWebView::mouseMoveEvent):
(QGraphicsWebView::mousePressEvent):
(QGraphicsWebView::mouseReleaseEvent):
(QGraphicsWebView::mouseDoubleClickEvent):
(QGraphicsWebView::keyPressEvent):
(QGraphicsWebView::keyReleaseEvent):
(QGraphicsWebView::dragLeaveEvent):
(QGraphicsWebView::dragMoveEvent):
(QGraphicsWebView::dropEvent):
(QGraphicsWebView::wheelEvent):
(QGraphicsWebView::inputMethodEvent):

Api/qgraphicswebview.h:
tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

4:29 AM Changeset in webkit [50645] by vestbo@webkit.org

2 edits in trunk/WebKit/qt

Make the QGraphicsWebView constructor explicit.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Tor Arne Vestbø.

Api/qgraphicswebview.h:

3:08 AM Changeset in webkit [50644] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-09
[Qt] Skip new japanese ruby annotation tests because of missing japanese font support.

platform/qt/Skipped:

2:12 AM Changeset in webkit [50643] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed trivial fix.

Removed previously (r50589) deleted test case from skiplists.

platform/gtk/Skipped: fast/events/drag-and-drop-none.html removed.
platform/qt/Skipped: fast/events/drag-and-drop-none.html removed.

1:16 AM Changeset in webkit [50642] by eric@webkit.org

9 edits in trunk

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Unskip fast/events/keypress-insert-tab.html as it now passes.

platform/gtk/Skipped:

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Expose Page::tabKeyCyclesThroughElements as a property of
WebKitWebView.

No new tests; fast/events/keypress-insert-tab.html is no longer skipped.

platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses. (WebCore::singleCharacterString):

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Expose Page::tabKeyCyclesThroughElements as a property of
WebKitWebSettings.

webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property):
webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

LayoutTestControllerGtk now uses the exposed
Page::tabKeyCyclesThroughElements API

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTabKeyCyclesThroughElements):

12:18 AM Changeset in webkit [50641] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-09 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Fix a crasher that occurred with text which included newline
chars in the markup.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (convertUniCharToUTF8):

12:15 AM QtBackLog edited by zecke@selfish.org

Mention the ARM changes (diff)

Nov 8, 2009:

11:34 PM Changeset in webkit [50640] by zecke@webkit.org

4 edits
1 add in trunk

The XML tokenizer reports a parse error twice if it occurs before the document element is found.

https://bugs.webkit.org/show_bug.cgi?id=31144

XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
documents that end prematurely but are not considered invalid by QXmlStream.
This is to stay compatible with the libxml2 implementation.
However, that code path would be also hit in situations when it should not,
i.e. the error would have already been caught and handled. As a result, the
same error would be reported twice.

No new tests, because the problem is already covered by
fast/parser/xml-declaration-missing-ending-mark.html.

Add the Qt-specific result for that test and unskip it.

10:39 PM Changeset in webkit [50639] by eric@webkit.org

5 edits in trunk/WebCore

2009-11-08 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Inspector should support copy() in the command line
https://bugs.webkit.org/show_bug.cgi?id=31238

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::copyText): Added.
inspector/InspectorBackend.h: Added copyText
inspector/InspectorBackend.idl: Added copyText
inspector/front-end/InjectedScript.js: (InjectedScript._copy): Added. (InjectedScript._ensureCommandLineAPIInstalled):

10:00 PM Changeset in webkit [50638] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-08 Drew Wilson <atwilson@chromium.org>

Reviewed by Dimitri Glazkov.

V8 WorkerContextExecutionProxy does not handle SharedWorkers
https://bugs.webkit.org/show_bug.cgi?id=31226

Now checks to see what type of context is active and creates the
appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).

Added support for converting to SharedWorkers and SharedWorkerContexts.

Test: Existing layout tests cover this case (start passing in Chrome).

bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Now generates the right type of DOMWrapper for SharedWorkerContexts. (WebCore::WorkerContextExecutionProxy::convertToV8Object): Added support for SHAREDWORKERCONTEXT. (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object): Added support for SharedWorker and SharedWorkerContext.

9:52 PM Changeset in webkit [50637] by eric@webkit.org

3 edits
4 adds in trunk

2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Added.
fast/dom/StyleSheet/get-stylesheet-byname.html: Added.
fast/dom/StyleSheet/script-tests: Added.
fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js: Added.

2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31224
[V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

Test: fast/dom/StyleSheet/get-stylesheet-byname.html

bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):

8:52 PM Changeset in webkit [50636] by mitz@apple.com

3 edits in trunk/WebKit/mac

Made the full-screen video HUD appear when playback stops, such as when
the end of the video is reached.

Reviewed by Eric Carlson.

WebView/WebVideoFullscreenHUDWindowController.h: Cleaned up.
WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Updated
for the renaming of -updateRate to -updatePlayButton.
(-[WebVideoFullscreenHUDWindowController updatePlayButton]): Renamed
-updateRate to this.
(-[WebVideoFullscreenHUDWindowController updateRate]): This method now
responds to changes to the playback rate by updating the play button
and showing or hiding the HUD as necessary.
(-[WebVideoFullscreenHUDWindowController togglePlaying:]): Now only
toggles playing. UI updates are driven by -updateRate being called.
(-[WebVideoFullscreenHUDWindowController playing]): Cleaned up.

8:46 PM Changeset in webkit [50635] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: "Search again" on scripts panel switches
to the script this search started with.

https://bugs.webkit.org/show_bug.cgi?id=31243

inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult):

6:43 PM Changeset in webkit [50634] by levin@chromium.org

3 edits in trunk/JavaScriptCore

wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

wtf/DateMath.h:

(JSC::GregorianDateTime::GregorianDateTime):

Reviewed by NOBODY (speculative snow leopard and windows build fixes).

6:33 PM Changeset in webkit [50633] by levin@chromium.org

9 edits in trunk

JavaScriptCore: Hopefully, the last build fix.

Reviewed by NOBODY (chromium build fix).

Create better separation in DateMath about the JSC
and non-JSC portions. Also, only expose the non-JSC
version in the exports.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getUTCOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

wtf/DateMath.h:

(JSC::gmtoffset):

JavaScriptGlue: Added the use jsc define for files that use
this config file and DateMath.h. This should
be able to go away when DateMath is properly
split into wtf and jsc portions which is this bug:
https://bugs.webkit.org/show_bug.cgi?id=31246

Reviewed by NOBODY (chromium build fix).

config.h:

WebCore: * platform/network/HTTPParsers.cpp:
(WebCore::parseDate): Changed this to not
use a date parser that needs ExecState passed.

Reviewed by NOBODY (chromium build fix).

5:28 PM Changeset in webkit [50632] by eric@webkit.org

14 edits in trunk/WebCore

2009-11-08 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Simplify Icon interface.
https://bugs.webkit.org/show_bug.cgi?id=31154

Remove Icon::createIconForFile(). createIconForFiles() covers createIconForFile()'s role.
Remove FileChooser::chooseIcon()
Change the parameter types of FileChooser constructor and the factory method, String -> const Vector<String>&, in order to support initialization with multiple files.
Remove the icon loading code in IconChromiumWin.cpp, which doesn't work because of the sandbox.

No tests because it's just a refactoring.

platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::create): (WebCore::FileChooser::chooseFile): (WebCore::FileChooser::chooseFiles):
platform/FileChooser.h:
platform/graphics/Icon.h:
platform/graphics/chromium/IconChromiumLinux.cpp:
platform/graphics/chromium/IconChromiumMac.cpp:
platform/graphics/chromium/IconChromiumWin.cpp: (WebCore::Icon::createIconForFiles):
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::createIconForFiles):
platform/graphics/haiku/IconHaiku.cpp:
platform/graphics/mac/IconMac.mm: (WebCore::Icon::createIconForFiles):
platform/graphics/qt/IconQt.cpp: (WebCore::Icon::createIconForFiles):
platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
platform/graphics/wx/IconWx.cpp:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl):

5:18 PM Changeset in webkit [50631] by dbates@webkit.org

4 edits
3 adds in trunk

2009-11-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31098

Allows same-origin plugin-based content to load.

Test: http/tests/security/xssAuditor/object-src-inject.html

page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource. (WebCore::XSSAuditor::canLoadObject): Ditto. (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. (WebCore::XSSAuditor::isSameOriginResource): Added.
page/XSSAuditor.h:

2009-11-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31098

Tests that the XSSAuditor prevents loading plugin-based content that is not
from the same-origin as the enclosing page.

http/tests/security/xssAuditor/object-src-inject-expected.txt: Added.
http/tests/security/xssAuditor/object-src-inject.html: Added.
http/tests/security/xssAuditor/resources/echo-object-src.pl: Added.

3:54 PM Changeset in webkit [50630] by levin@chromium.org

2 edits in trunk/WebCore

Unreviewed build fix for chromium.

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

3:42 PM Changeset in webkit [50629] by levin@chromium.org

2 edits in trunk/WebCore

Unreviewed build fix for chromium.

Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
Clean up GraphicsContext's current concept of ColorSpace

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

1:02 PM Changeset in webkit [50628] by levin@chromium.org

3 edits in trunk/JavaScriptCore

For the change in DateMath.

Reviewed by NOBODY (chromium build fix).

config.h:
wtf/DateMath.cpp:

11:47 AM Changeset in webkit [50627] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-11-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] committing style edit
clears elements panel selection.

https://bugs.webkit.org/show_bug.cgi?id=31242

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.update):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):

11:09 AM Changeset in webkit [50626] by eric@webkit.org

3 edits in trunk/LayoutTests

2009-11-08 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

Update texts in test description after test case change in r50579.
https://bugs.webkit.org/show_bug.cgi?id=31122

editing/selection/shrink-selection-after-shift-pagedown-expected.txt:
editing/selection/shrink-selection-after-shift-pagedown.html:

11:01 AM Changeset in webkit [50625] by eric@webkit.org

27 edits in trunk

2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Holger Freyther.

ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670

Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed all forward declarations of ResourceRequest to have class in the forward
declaration instead of struct and changed the definition of ResourceRequest to be class
and added access qualifiers where missing. Additionally two references of friend
struct ResourceRequestBase changed to class instead.

history/HistoryItem.h:
inspector/InspectorController.h:
inspector/InspectorResource.h:
loader/DocumentThreadableLoader.h:
loader/FrameLoaderClient.h:
loader/MainResourceLoader.h:
loader/ResourceLoadNotifier.h:
loader/SubresourceLoader.h:
loader/SubresourceLoaderClient.h:
loader/ThreadableLoader.h:
loader/WorkerThreadableLoader.h:
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheHost.h:
platform/CrossThreadCopier.h:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h:
platform/network/ResourceRequestBase.h:
platform/network/cf/ResourceRequest.h:
platform/network/cf/ResourceRequestCFNet.h:
platform/network/chromium/ResourceRequest.h:
platform/network/curl/ResourceRequest.h:
platform/network/qt/ResourceRequest.h:
platform/network/soup/ResourceRequest.h:
xml/XMLHttpRequest.h:

2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Holger Freyther.

ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670

Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed forward declaration of ResourceRequest to have class in the forward
declaration instead of struct.

WebDownload.h:

10:51 AM Changeset in webkit [50624] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-08 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] Added support for key code 8 (backspace) in EventSenderQt.
This helps to pass the test case below. Also replaced hardcoded
code numbers with defined constants.
https://bugs.webkit.org/show_bug.cgi?id=31185

Test: editing/undo/undo-deleteWord.html

DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):

9:32 AM Changeset in webkit [50623] by mitz@apple.com

6 edits
4 adds in trunk

<rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
below FrameView::layout
https://bugs.webkit.org/show_bug.cgi?id=31093

Reviewed by Simon Fraser.

WebCore:

Test: fast/block/positioning/relative-positioned-inline-container.html

In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
to mark the object for layout, doing so without marking its ancestors.
However, RenderBlock::skipLeadingWhitespace and
RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
positioned inline container, causing it to be marked for layout without
ever going back to give it layout, and thus layout could end with a
dirty object still in the tree, leading to all sorts of badness.

The fix is to revert setStaticY() to not marking the object dirty, and
instead do it in the call sites that require it, which are in
RenderBlock and RenderFlexibleBox.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

rendering/RenderLayer.cpp:
rendering/RenderLayer.h:

(WebCore::RenderLayer::setStaticY):

LayoutTests:

fast/block/positioning/relative-positioned-inline-container-expected.checksum: Added.
fast/block/positioning/relative-positioned-inline-container-expected.png: Added.
fast/block/positioning/relative-positioned-inline-container-expected.txt: Added.
fast/block/positioning/relative-positioned-inline-container.html: Added.

9:26 AM Changeset in webkit [50622] by tonikitoo@webkit.org

2 edits in trunk/WebKitTools

[Qt] [DRT] Fix wrong logic in LayoutTestController processWork
https://bugs.webkit.org/show_bug.cgi?id=31164

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-05
Reviewed by Holger Freyther.

Fixed wrong logic to assume WorkQueue is done in QT's DRT.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::processWork):

9:25 AM Changeset in webkit [50621] by tonikitoo@webkit.org

4 edits in trunk/WebKitTools

[Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
https://bugs.webkit.org/show_bug.cgi?id=31158

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-07
Reviewed by Holger Freyther.

By invoking a script queue'd by queueScript(), 'true' was beeing returned
always, which from WorkQueue prospective means that a load has been started
and the queue processing should stop and wait for the load to finish.
Spinning it off into a loading and a non-loading variants was the solution
adopted by Mac's DRT to work around this problem. The former keeps returning
'true' while the later executes the script synchronously and returns 'false'
making it possible to the WorkQueue to proceed right away.

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::processWork):
(LayoutTestController::queueLoadingScript):
(LayoutTestController::queueNonLoadingScript):

DumpRenderTree/qt/LayoutTestControllerQt.h:
DumpRenderTree/qt/WorkQueueItem.h:

(LoadingScriptItem::LoadingScriptItem):
(LoadingScriptItem::invoke):
(NonLoadingScriptItem::NonLoadingScriptItem):
(NonLoadingScriptItem::invoke):

Nov 7, 2009:

7:59 PM Changeset in webkit [50620] by mrowe@apple.com

2 edits in trunk/WebKitTools

Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.

Rubber-stamped by Cameron Zwarich.

Scripts/commit-log-editor:

7:59 PM Changeset in webkit [50619] by mrowe@apple.com

4 edits in trunk/WebKitTools

Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
commit-log-editor does not support all the email address configurations that prepare-Changelog supports

Reviewed by Darin Adler.

Move logic for determining the name and email address to use in a ChangeLog entry from
prepare-ChangeLog to VCSUtils so that commit-log-editor can use it. It wants to check
whether the author of the patch matches committer, and therefore needs access to the
email address that would be used in a ChangeLog entry.

Based on a patch by Pierre d'Herbemont.

Scripts/VCSUtils.pm:
Scripts/commit-log-editor:
Scripts/prepare-ChangeLog:
Scripts/webkitdirs.pm:

6:31 PM Changeset in webkit [50618] by dbates@webkit.org

2 edits
1 add in trunk/WebCore

2009-11-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20780

Fixes an issue where the onchange event handler is not fired when the
input field is autocompleted.

We cannot test this using DRT since DRT cannot emulate autocompletion.
So, a manual-test is included.

Tests: manual-tests/autocompletion-fire-onchange.html

manual-tests/autocompletion-fire-onchange.html: Added.
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):

2:40 PM Changeset in webkit [50617] by eric@webkit.org

1 edit
4 adds in trunk/LayoutTests

2009-11-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Add in missing expectations.

platform/mac/fast/forms/input-list-button-size-expected.checksum: Added.
platform/mac/fast/forms/input-list-button-size-expected.png: Added.
platform/mac/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
platform/mac/fast/text/text-letter-spacing-expected.png: Added.

12:06 PM Changeset in webkit [50616] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-07 Benjamin Otte <otte@gnome.org>

Reviewed by Holger Freyther.

Mark redrawn areas on image surfaces as dirty.

This is required to conform to the Cairo API, but is currently only
used by debugging tools like cairo-trace.

platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::platformTransformColorSpace): (WebCore::putImageData):

1:03 AM Changeset in webkit [50615] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30878
[Gtk] atk_text_get_text() fails in entries when the end_offset is -1

If the end_offset is -1, use the String length as the end_offset.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_text):

12:00 AM Changeset in webkit [50614] by Beth Dakin

8 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up
GraphicsContext's current concept of ColorSpace

Reviewed by Adele Peterson.

ColorSpace is now called ColorType. The variables on the state we
appropriately re-named as well. I removed strokeColorSpace() and
fillColorSpace() from GraphicsContext since they were never called.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):

platform/graphics/GraphicsContext.h:

(WebCore::):

platform/graphics/GraphicsContextPrivate.h:

(WebCore::GraphicsContextState::GraphicsContextState):

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::calculateDrawingMode):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):

platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):

Nov 6, 2009:

6:02 PM Changeset in webkit [50613] by bweinstein@apple.com

9 edits
1 delete in trunk/WebCore

Fixes <http://webkit.org/b/31177>.
Web Inspector: Bind backspace to delete cookies and DOM Storage.

Reviewed by Tim Hatcher.

Refactor editing code from DOMStorageDataGrid to DataGrid, so other
places in the inspector can use editing in DataGrid (added a FIXME for
some stuff that needs to be generalized).

Also added deleting functionality to DataGrid, and implemented it for
Cookies and DOM Storage. The reason this patch is so big is because of
the refactoring of editing code, which won't be used yet in a cross-datagrid
way, but should be able to.

Additionally, moved the callbacks members from DOMStorageDataGrid to
DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
make the architecture of DOM Storage look a lot more like the Cookies view.

Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
inspector from beeping at you when you delete an element.

WebCore.gypi: Removed DOMStorageDataGrid.
WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView.prototype.dataGridForCookies):
(WebInspector.CookieItemsView.prototype._deleteButtonClicked):
(WebInspector.CookieItemsView.prototype._deleteCookieCallback):

inspector/front-end/DOMStorageDataGrid.js: Removed.
inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._editingCancelled): Ditto.
(WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.

inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
inspector/front-end/inspector.html: Removed DOMStorageDataGrid.

4:05 PM Changeset in webkit [50612] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix: export some symbols.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:59 PM Changeset in webkit [50611] by ggaren@apple.com

2 edits in trunk/WebCore

Qt build fix: added an ExecState parameter.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

3:54 PM Changeset in webkit [50610] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: updated export file.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:48 PM Changeset in webkit [50609] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Build fix: added some #includes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06

wtf/CurrentTime.h:
wtf/DateMath.h:

3:33 PM Changeset in webkit [50608] by ggaren@apple.com

27 edits
1 add in trunk

Rolled back in r50590 with Windows build hopefully fixed.

3:00 PM Changeset in webkit [50607] by eric@webkit.org

9 edits
4 adds in trunk

2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

Added layout tests to test document.open and window.open calls issued
by NPAPI plugins without a calling javascript context. The associated
webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067, which
affects Chromium.

plugins/document-open-expected.txt: Added.
plugins/document-open.html: Added.
plugins/window-open-expected.txt: Added.
plugins/window-open.html: Added.

2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
which affects Chromium only.

Changes to V8HTMLDocumentCustom.cpp are as below:-

The HTMLDocumentOpen function would cause a crash in Chromium if there was no calling javascript context. We now check for this case and pass in NULL to the HTMLDocument::open function which can handle a NULL document parameter.
The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc had ASSERTS for a NULL caller frame, which was bogus as it would crash anyway. We now check for this case and return a failure.

Changes to V8DOMWindowCustom.cpp are as below:-

Instead of failing the window.open call made by NPAPI for lack of a calling javascript context, we now use the entered context as the calling context.

Tests: plugins/document-open.html

plugins/window-open.html

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Adam Barth.

Added functionality to the layout test plugin to invoke document.open and
window.open with default arguments. The associated webkit bug is
https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
work in Chromium (V8) if there is no calling javascript context. To achieve this
effect we invoke these functions in the layout test plugin in the NPP_SetWindow
for the window.open test case and in NPP_DestroyStream for the document.open test case.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testDocumentOpen): (testWindowOpen): (pluginAllocate):
DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetWindow): (NPP_DestroyStream):
DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream):

2:58 PM Changeset in webkit [50606] by krit@webkit.org

2 edits in trunk/WebKitSite

2009-11-06 Dirk Schulze <krit@webkit.org>

Rubber stamped by Eric Seidel.

Update SVG status page. We support feMorphology now.
Set lightning filters to unimplemented.

projects/svg/status.xml:

1:36 PM Changeset in webkit [50605] by eric@webkit.org

22 edits in trunk

2009-11-06 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Geolocation error code UNKNOWN_ERROR is deprecated.
https://bugs.webkit.org/show_bug.cgi?id=31184

Update test case of the value of the PositionError.UNKNOWN_ERROR constant in error.html.
Also remove redundant test cases of the value of all PositionError constants.

fast/dom/Geolocation/resources/error.js: Modified. Update test of value of PositionError.UNKNOWN_ERROR constant.
fast/dom/Geolocation/error-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied-already-error.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/permission-denied-already-error-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied-already-success.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/permission-denied-already-success-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/permission-denied-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/reentrant-error.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/timeout-zero.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/watch.js: Modified. Remove tests of the value of PositionError constants.
fast/dom/Geolocation/watch-expected.txt: Modified. Expected result for above test.

2009-11-06 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Geolocation error code UNKNOWN_ERROR is deprecated.
https://bugs.webkit.org/show_bug.cgi?id=31184

Remove this error code from PositionError, both for use from C++ code and from the JS object.

Updated fast/dom/Geolocation/error.html to test this.

page/PositionError.h: Modified. (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
page/Geolocation.cpp: Modified. (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
platform/gtk/GeolocationServiceGtk.cpp: Modified. (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.

1:08 PM Changeset in webkit [50604] by krit@webkit.org

2 edits in trunk/WebCore

2009-11-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863

The Implementation of feMorphology.

Test: We have allready a test for feMorphology

svg/W3C-SVG-1.1/filters-morph-01-f.svg

svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):

12:01 PM Changeset in webkit [50603] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-06 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
https://bugs.webkit.org/show_bug.cgi?id=31209

Build fix only. No new tests possible.

bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.

11:53 AM Changeset in webkit [50602] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool crashed with exception
https://bugs.webkit.org/show_bug.cgi?id=31092

Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.

10:32 AM Changeset in webkit [50601] by eric@webkit.org

2 edits in trunk/WebKitSite

2009-11-06 Jeff Schiller <codedread@gmail.com>

Reviewed by Darin Adler.

SVG Status page update
https://bugs.webkit.org/show_bug.cgi?id=31179

projects/svg/status.xml:

8:18 AM Changeset in webkit [50600] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-06 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

V8 bindings do not support SharedWorkers as event targets
https://bugs.webkit.org/show_bug.cgi?id=31199

No new tests because existing layout tests suffice (they currently
crash on Chromium)

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Added clause to create a DOM wrapper for SharedWorkers.

7:19 AM Changeset in webkit [50599] by zoltan@webkit.org

3 edits in trunk/JavaScriptCore

Unreviewed trivial buildfix after r50595.

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-06
Rename the remaining rshiftPtr calls to rshift32

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_rshift):

jit/JITInlineMethods.h:

(JSC::JIT::emitFastArithImmToInt):

5:49 AM Changeset in webkit [50598] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Do not unnecessarly synchronzie in weak reference callbacks.
https://bugs.webkit.org/show_bug.cgi?id=31191

bindings/v8/DOMData.h: (WebCore::DOMData::handleWeakObject):

5:41 AM Changeset in webkit [50597] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix resource content search.
https://bugs.webkit.org/show_bug.cgi?id=31202

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.removeItem):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelineGraph.prototype.refresh):

5:33 AM WebKit Team edited by xan@webkit.org

(diff)

5:28 AM WebKit Team edited by xan@webkit.org

(diff)

5:27 AM WebKit Team edited by xan@webkit.org

(diff)

5:25 AM WebKit Team edited by xan@webkit.org

(diff)

1:35 AM Changeset in webkit [50596] by hamaji@chromium.org

3 edits in trunk/LayoutTests

2009-11-04 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

css2.1/t040304-c64-uri-00-a-g.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23271

This test isn't failing now because this test was fixed in
http://trac.webkit.org/changeset/47884

platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.checksum:
platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.png:

1:35 AM Changeset in webkit [50595] by barraclough@apple.com

7 edits in trunk/JavaScriptCore

Tidy up the shift methods on the macro-assembler interface.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-06
Reviewed by Oliver Hunt.

Currently behaviour of shifts of a magnitude > 0x1f is undefined.
Instead defined that all shifts are masked to this range. This makes a lot of
practical sense, both since having undefined behaviour is not particularly
desirable, and because this behaviour is commonly required (particularly since
it is required bt ECMA-262 for shifts).

Update the ARM assemblers to provide this behaviour. Remove (now) redundant
masks from JITArithmetic, and remove rshiftPtr (this was used in case that
could be rewritten in a simpler form using rshift32, only optimized JSVALUE32
on x86-64, which uses JSVALUE64!)

assembler/MacroAssembler.h:
assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::rshift32):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::lshift32):
(JSC::MacroAssemblerARMv7::rshift32):

assembler/MacroAssemblerX86_64.h:
jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):

12:47 AM Changeset in webkit [50594] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

Rubber Stamped by Oliver Hunt.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-05
Remove a magic number (1) from the JIT, instead compute the value with OBJECT_OFFSET.

jit/JITInlineMethods.h:

(JSC::JIT::emitPutJITStubArg):
(JSC::JIT::emitPutJITStubArgConstant):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):

jit/JITStubCall.h:

(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::getArgument):

jit/JITStubs.h:

Nov 5, 2009:

11:28 PM Changeset in webkit [50593] by Csaba Osztrogonác

3 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=31159
Fix branchDouble behaviour on ARM THUMB2 JIT.

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.

The x86 branchDouble behaviour is reworked, and all JIT
ports should follow the x86 port. See bug 31104 and 31151

This patch contains a fix for the traditional ARM port

assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::fmrs_r):
(JSC::ARMAssembler::ftosid_r):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

11:26 PM Changeset in webkit [50592] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-05 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Fix ASSERT(currentStyle = renderStyle()).
https://bugs.webkit.org/show_bug.cgi?id=31152

dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".

10:52 PM Maintenance and architecture list edited by chris.jerdonek@gmail.com

Changeset 50583 removed the "this is part of the KDE project" code … (diff)

10:52 PM Changeset in webkit [50591] by ggaren@apple.com

19 edits in trunk

Rolled out r50590 because it doesn't build on Windows.

10:26 PM Changeset in webkit [50590] by ggaren@apple.com

19 edits in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-05
Reviewed by Oliver Hunt.

If the VM calculates the local timezone offset from UTC, it caches the
result until the end of the current VM invocation. (We don't want to cache
forever, because the user's timezone may change over time.)

This removes notify_* overhead on Mac, and, more significantly, removes
OS time and date call overhead on non-Mac platforms.

~8% speedup on Date microbenchmark on Mac. SunSpider reports maybe a tiny
speedup on Mac. (Speedup on non-Mac platforms should be even more noticeable.)

JavaScriptCore.exp:

interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

runtime/JSGlobalObject.h:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Made the
DynamicGlobalObjectScope constructor responsible for checking whether a
dynamicGlobalObject has already been set. This eliminated some duplicate
client code, and allowed me to avoid adding even more duplicate client
code. Made DynamicGlobalObjectScope responsible for resetting the
local timezone cache upon first entry to the VM.

runtime/DateConstructor.cpp:

(JSC::constructDate):
(JSC::callDate):
(JSC::dateParse):
(JSC::dateUTC):

runtime/DateConversion.cpp:

(JSC::parseDate):

runtime/DateConversion.h:
runtime/DateInstance.cpp:

(JSC::DateInstance::gregorianDateTime):

runtime/DateInstance.h:
runtime/DateInstanceCache.h:
runtime/DatePrototype.cpp:

(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:
wtf/DateMath.cpp:

(WTF::getCurrentUTCTime):
(WTF::getCurrentUTCTimeWithMicroseconds):
(WTF::getLocalTime):
(JSC::getUTCOffset): Use the new cache. Also, see below.
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::initializeDates):
(JSC::parseDateFromNullTerminatedCharacters): Simplified the way this function
accounts for the local timezone offset, to accomodate our new caching API,
and a (possibly misguided) caller in WebCore. Also, see below.

wtf/DateMath.h:

(JSC::GregorianDateTime::GregorianDateTime): Moved most of the code in
DateMath.* into the JSC namespace. The code needed to move so it could
naturally interact with ExecState and JSGlobalData to support caching.
Logically, it seemed right to move it, too, since this code is not really
as low-level as the WTF namespace might imply -- it implements a set of
date parsing and conversion quirks that are finely tuned to the JavaScript
language. Also removed the Mac OS X notify_* infrastructure.

WebCore: https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-05
Updated for JavaScriptCore internal API change.

platform/network/HTTPParsers.cpp:

(WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
(This function probably shouldn't be using a JavaScript date parser
to begin with, but oh well.)

10:25 PM Changeset in webkit [50589] by dbates@webkit.org

2 edits
2 deletes in trunk/LayoutTests

2009-11-05 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=31193

Removed obsolete test case which was included in the patch for bug #30107.
This test case is already covered by the test case fast/events/drag-and-drop.html,
which was included in the patch for bug #24731.

fast/events/drag-and-drop-none-expected.txt: Removed.
fast/events/drag-and-drop-none.html: Removed.
platform/win/Skipped: Removed entry for drag-and-drop-none.html.

10:19 PM Changeset in webkit [50588] by hclam@chromium.org

4 edits in trunk/WebCore

Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.

Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05

bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcEpilogue):

bindings/v8/V8GCController.h:
bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):

10:05 PM Changeset in webkit [50587] by abarth@webkit.org

3 edits
4 adds in trunk

2009-11-05 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Cross-domain access to stylesheet text should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=20527

Test that a script cannot read cross-origin cssRules.

http/tests/security/cannot-read-cssrules-expected.txt: Added.
http/tests/security/cannot-read-cssrules-redirect-expected.txt: Added.
http/tests/security/cannot-read-cssrules-redirect.html: Added.
http/tests/security/cannot-read-cssrules.html: Added.

2009-11-05 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Cross-domain access to stylesheet text should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=20527

Check whether whether the current document can read the cssRules from
the style sheet. Firefox throws a security error here, but we return
null instead because that's what we usually do in these cases.

Test: http/tests/security/cannot-read-cssrules-redirect.html

http/tests/security/cannot-read-cssrules.html

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):

7:27 PM Changeset in webkit [50586] by jparent@chromium.org

1 edit in trunk/WebCore/WebCore.gyp

Rubber stamped by Mark Rowe.

Adds some GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=31194

*.vcproj
*.rules
*.mk
*.scons
SConstruct

6:46 PM Changeset in webkit [50585] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-05 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

If the Geolocation service fails to start, invoke the error callback asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=28276

All Geolocation callbacks must be invoked asynchronously.
See http://www.w3.org/TR/geolocation-API/#geolocation_interface

No new tests possible with current LayoutTestController.

page/Geolocation.cpp: (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier. (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier. (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.

4:05 PM Changeset in webkit [50584] by alice.liu@apple.com

1 edit
1 add in trunk/LayoutTests

Adding a resource that seems to be missing. Without it, several tests in
fast/dom/beforeload aren't really testing if the default event handling is
prevented, but instead are only testing if the beforeload event fires.

Rubber-stamped by Gavin Barraclough.

fast/dom/beforeload/resources/fail.js: Added.

3:53 PM Changeset in webkit [50583] by eric@webkit.org

253 edits in trunk

2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.

https://bugs.webkit.org/show_bug.cgi?id=31167

The maintenance and architecture page in the project wiki lists
this as a task.

This change includes no changes or additions to test cases
since the change affects only comments.

wtf/wince/FastMallocWince.h:

2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.

https://bugs.webkit.org/show_bug.cgi?id=31167

The maintenance and architecture page in the project wiki lists
this as a task.

This change includes no changes or additions to test cases
since the change affects only comments.

bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/IDLParser.pm:
bindings/scripts/IDLStructure.pm:
css/CSSInheritedValue.cpp:
css/CSSInitialValue.cpp:
css/CSSMediaRule.cpp:
css/CSSNamespace.h:
css/CSSProperty.cpp:
css/CSSProperty.h:
css/CSSRuleList.cpp:
css/CSSRuleList.h:
css/CSSSelector.h:
css/CSSValueList.cpp:
css/FontValue.cpp:
css/MediaFeatureNames.cpp:
css/MediaFeatureNames.h:
css/Pair.h:
css/SVGCSSStyleSelector.cpp:
css/ShadowValue.cpp:
css/StyleSheet.cpp:
css/StyleSheetList.cpp:
css/maketokenizer:
dom/BeforeUnloadEvent.cpp:
dom/BeforeUnloadEvent.h:
dom/CSSMappedAttributeDeclaration.cpp:
dom/EventNames.cpp:
dom/EventTarget.cpp:
dom/MappedAttributeEntry.h:
dom/MouseRelatedEvent.h:
dom/RangeException.h:
dom/StyleElement.h:
dom/Tokenizer.h:
html/HTMLHeadElement.h:
html/HTMLHeadingElement.cpp:
html/HTMLHeadingElement.h:
html/HTMLHtmlElement.h:
html/HTMLImageLoader.h:
html/HTMLMetaElement.h:
html/HTMLModElement.cpp:
html/HTMLModElement.h:
html/HTMLOptionsCollection.cpp:
html/HTMLPlugInElement.cpp:
html/HTMLPreElement.cpp:
html/HTMLPreElement.h:
html/HTMLTableCellElement.cpp:
html/HTMLTableCellElement.h:
html/HTMLTableColElement.cpp:
html/HTMLTableColElement.h:
html/HTMLTablePartElement.cpp:
html/HTMLTablePartElement.h:
html/HTMLTitleElement.h:
page/MouseEventWithHitTestResults.h:
platform/StaticConstructors.h:
platform/text/AtomicStringImpl.h:
platform/text/qt/TextBreakIteratorQt.cpp:
rendering/AutoTableLayout.h:
rendering/CounterNode.cpp:
rendering/EllipsisBox.cpp:
rendering/EllipsisBox.h:
rendering/FixedTableLayout.cpp:
rendering/FixedTableLayout.h:
rendering/HitTestRequest.h:
rendering/HitTestResult.h:
rendering/InlineRunBox.h:
rendering/PointerEventsHitRules.cpp:
rendering/PointerEventsHitRules.h:
rendering/RenderBR.cpp:
rendering/RenderBR.h:
rendering/RenderButton.cpp:
rendering/RenderButton.h:
rendering/RenderFieldset.cpp:
rendering/RenderFrameSet.cpp:
rendering/RenderListItem.cpp:
rendering/RenderTableRow.cpp:
rendering/RenderView.h:
rendering/RootInlineBox.h:
rendering/SVGInlineTextBox.cpp:
rendering/SVGInlineTextBox.h:
rendering/TableLayout.h:
rendering/break_lines.h:
rendering/style/SVGRenderStyle.cpp:
rendering/style/SVGRenderStyle.h:
rendering/style/SVGRenderStyleDefs.cpp:
rendering/style/SVGRenderStyleDefs.h:
svg/GradientAttributes.h:
svg/LinearGradientAttributes.h:
svg/PatternAttributes.h:
svg/RadialGradientAttributes.h:
svg/SVGAElement.cpp:
svg/SVGAngle.idl:
svg/SVGAnimateColorElement.cpp:
svg/SVGAnimateColorElement.h:
svg/SVGAnimateElement.cpp:
svg/SVGAnimateElement.h:
svg/SVGAnimateTransformElement.h:
svg/SVGAnimatedPathData.cpp:
svg/SVGAnimatedPathData.h:
svg/SVGAnimatedPoints.cpp:
svg/SVGAnimatedPoints.h:
svg/SVGAnimationElement.cpp:
svg/SVGCircleElement.cpp:
svg/SVGClipPathElement.cpp:
svg/SVGColor.cpp:
svg/SVGColor.idl:
svg/SVGComponentTransferFunctionElement.cpp:
svg/SVGComponentTransferFunctionElement.h:
svg/SVGCursorElement.cpp:
svg/SVGDefsElement.cpp:
svg/SVGDescElement.cpp:
svg/SVGDescElement.h:
svg/SVGDocument.idl:
svg/SVGElement.idl:
svg/SVGElementInstanceList.cpp:
svg/SVGElementInstanceList.h:
svg/SVGEllipseElement.cpp:
svg/SVGExternalResourcesRequired.cpp:
svg/SVGFEBlendElement.cpp:
svg/SVGFEBlendElement.h:
svg/SVGFEColorMatrixElement.cpp:
svg/SVGFEColorMatrixElement.h:
svg/SVGFEComponentTransferElement.cpp:
svg/SVGFEComponentTransferElement.h:
svg/SVGFECompositeElement.cpp:
svg/SVGFECompositeElement.h:
svg/SVGFEFloodElement.cpp:
svg/SVGFEFloodElement.h:
svg/SVGFEFuncAElement.cpp:
svg/SVGFEFuncAElement.h:
svg/SVGFEFuncBElement.cpp:
svg/SVGFEFuncBElement.h:
svg/SVGFEFuncGElement.cpp:
svg/SVGFEFuncGElement.h:
svg/SVGFEFuncRElement.cpp:
svg/SVGFEFuncRElement.h:
svg/SVGFEGaussianBlurElement.cpp:
svg/SVGFEGaussianBlurElement.h:
svg/SVGFEImageElement.cpp:
svg/SVGFEMergeElement.cpp:
svg/SVGFEMergeElement.h:
svg/SVGFEMergeNodeElement.cpp:
svg/SVGFEOffsetElement.cpp:
svg/SVGFEOffsetElement.h:
svg/SVGFETileElement.cpp:
svg/SVGFETileElement.h:
svg/SVGFETurbulenceElement.cpp:
svg/SVGFETurbulenceElement.h:
svg/SVGFilterElement.cpp:
svg/SVGGElement.cpp:
svg/SVGGradientElement.cpp:
svg/SVGHKernElement.idl:
svg/SVGLangSpace.cpp:
svg/SVGLangSpace.h:
svg/SVGLength.cpp:
svg/SVGLength.h:
svg/SVGLength.idl:
svg/SVGLengthList.cpp:
svg/SVGLengthList.h:
svg/SVGLineElement.cpp:
svg/SVGLinearGradientElement.h:
svg/SVGList.h:
svg/SVGListTraits.h:
svg/SVGLocatable.h:
svg/SVGMaskElement.cpp:
svg/SVGMatrix.idl:
svg/SVGMetadataElement.cpp:
svg/SVGMetadataElement.h:
svg/SVGMetadataElement.idl:
svg/SVGNumber.idl:
svg/SVGNumberList.cpp:
svg/SVGNumberList.h:
svg/SVGPaint.cpp:
svg/SVGPathElement.cpp:
svg/SVGPathSeg.h:
svg/SVGPathSegArc.cpp:
svg/SVGPathSegArc.h:
svg/SVGPathSegClosePath.cpp:
svg/SVGPathSegClosePath.h:
svg/SVGPathSegCurvetoCubic.cpp:
svg/SVGPathSegCurvetoCubic.h:
svg/SVGPathSegCurvetoCubicSmooth.cpp:
svg/SVGPathSegCurvetoCubicSmooth.h:
svg/SVGPathSegCurvetoQuadratic.cpp:
svg/SVGPathSegCurvetoQuadratic.h:
svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
svg/SVGPathSegCurvetoQuadraticSmooth.h:
svg/SVGPathSegLineto.cpp:
svg/SVGPathSegLineto.h:
svg/SVGPathSegLinetoHorizontal.cpp:
svg/SVGPathSegLinetoHorizontal.h:
svg/SVGPathSegLinetoVertical.cpp:
svg/SVGPathSegLinetoVertical.h:
svg/SVGPathSegMoveto.cpp:
svg/SVGPathSegMoveto.h:
svg/SVGPatternElement.cpp:
svg/SVGPoint.idl:
svg/SVGPointList.cpp:
svg/SVGPointList.h:
svg/SVGPolyElement.cpp:
svg/SVGPolygonElement.cpp:
svg/SVGPolygonElement.h:
svg/SVGPolylineElement.cpp:
svg/SVGPolylineElement.h:
svg/SVGPreserveAspectRatio.cpp:
svg/SVGPreserveAspectRatio.h:
svg/SVGRadialGradientElement.h:
svg/SVGRect.idl:
svg/SVGRectElement.cpp:
svg/SVGRenderingIntent.h:
svg/SVGSVGElement.idl:
svg/SVGScriptElement.cpp:
svg/SVGSetElement.cpp:
svg/SVGSetElement.h:
svg/SVGStopElement.cpp:
svg/SVGStringList.cpp:
svg/SVGStringList.h:
svg/SVGStylable.cpp:
svg/SVGStylable.h:
svg/SVGStyleElement.cpp:
svg/SVGStyleElement.h:
svg/SVGStyledElement.h:
svg/SVGStyledLocatableElement.cpp:
svg/SVGStyledLocatableElement.h:
svg/SVGStyledTransformableElement.cpp:
svg/SVGStyledTransformableElement.h:
svg/SVGSwitchElement.cpp:
svg/SVGSymbolElement.cpp:
svg/SVGTRefElement.cpp:
svg/SVGTSpanElement.cpp:
svg/SVGTSpanElement.h:
svg/SVGTests.h:
svg/SVGTextElement.cpp:
svg/SVGTextElement.h:
svg/SVGTextPathElement.cpp:
svg/SVGTextPositioningElement.cpp:
svg/SVGTextPositioningElement.h:
svg/SVGTitleElement.cpp:
svg/SVGTitleElement.h:
svg/SVGTransform.cpp:
svg/SVGTransform.h:
svg/SVGTransform.idl:
svg/SVGTransformList.cpp:
svg/SVGTransformList.h:
svg/SVGTransformable.h:
svg/SVGURIReference.h:
svg/SVGUnitTypes.h:
svg/SVGUseElement.cpp:
svg/SVGViewElement.cpp:
svg/SVGZoomAndPan.cpp:
svg/SVGZoomAndPan.h:
svg/SVGZoomEvent.cpp:

3:28 PM Changeset in webkit [50582] by pfeldman@chromium.org

17 edits
3 moves
5 adds
2 deletes in trunk/LayoutTests

2009-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: beautify layout tests.

https://bugs.webkit.org/show_bug.cgi?id=31189

inspector/console-dir-expected.txt:
inspector/console-dir.html:
inspector/console-dirxml-expected.txt:
inspector/console-dirxml.html:
inspector/console-format-collections-expected.txt:
inspector/console-format-collections.html:
inspector/console-format-expected.txt:
inspector/console-format.html:
inspector/console-tests-expected.txt:
inspector/console-tests.html:
inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontendScript_dumpConsoleMessages):
inspector/css-syntax-highlight.html: Removed.
inspector/elements-panel-structure-expected.txt:
inspector/elements-panel-structure.html:
inspector/elements-tests.js: Added. (frontendScript_expandDOMSubtree.processChildren): (frontendScript_expandDOMSubtree):
inspector/evaluate-in-frontend.html:
inspector/evaluate-in-frontend.js: Removed.
inspector/inspector-test.js: Added. (): (evaluateInWebInspector): (notifyDone): (output): (window.didEvaluateForTestInFrontend):
inspector/javascript-syntax-highlight.html: Removed.
inspector/styles-iframe.html:
inspector/syntax-highlight-css-expected.txt: Renamed from LayoutTests/inspector/css-syntax-highlight-expected.txt.
inspector/syntax-highlight-css.html: Added.
inspector/syntax-highlight-javascript-expected.txt: Renamed from LayoutTests/inspector/javascript-syntax-highlight-expected.txt.
inspector/syntax-highlight-javascript.html: Added.
inspector/syntax-highlight.js: Added. (doit.callback): (doit): (frontendScript_dumpSyntaxHighlight):
inspector/timeline-trivial.html:
platform/qt/Skipped:

3:25 PM Changeset in webkit [50581] by jorlow@chromium.org

5 edits in trunk/WebCore

2009-11-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION Clean up security origin usage in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=31188

Clean up security origin usage in DOM Storage. This fixes a bug in my
refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149

Instead of having StorageAreaSync's constructor (which is called in the
constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
database identifier, simply have StorageAreaImpl pass the identifier into
StorageAreaSync.

No test because there's no change in externally observable behavior.

storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl):
storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
storage/StorageAreaSync.h:

3:08 PM Changeset in webkit [50580] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-05 Scott Violet <sky@google.com>

Reviewed by Dimitri Glazkov.

Need notification of scrolling frame
https://bugs.webkit.org/show_bug.cgi?id=31145

Adds FrameLoaderClient::didChangeScrollOffset that is called when
the frame scrolls. This will be used to know when history state
needs to be updated.

loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didChangeScrollOffset):
page/FrameView.cpp: (WebCore::FrameView::valueChanged):

2:46 PM Changeset in webkit [50579] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-05 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Adele Peterson.

The number of selected lines in textarea after a shift-PageDown
may differ. The test case is modified so that it will not depend
on the exact number of lines selected. This should resolve regression
on platforms like Qt and GTK.
https://bugs.webkit.org/show_bug.cgi?id=31122

editing/selection/shrink-selection-after-shift-pagedown.html:

2:17 PM Changeset in webkit [50578] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-05 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[V8] Update bindings to use new API for external arrays
https://bugs.webkit.org/show_bug.cgi?id=31181

No new tests; covered by existing WebGL tests.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object):
bindings/v8/V8DOMWrapper.h:
bindings/v8/custom/V8CanvasArrayCustom.h: (WebCore::constructCanvasArray):

1:59 PM Changeset in webkit [50577] by hclam@chromium.org

3 edits in trunk/WebCore

Not reviewed, Chromium build fix.

Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05
50561 introduces a custom method for SVGMatrix, we need to implement
this in V8.

bindings/v8/custom/V8CustomBinding.h:

Adding definition for V8SVGMatrixMultiply.

bindings/v8/custom/V8SVGMatrixCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL):
Implement V8SVGMatrixMultiply according to the same method in JSC.

1:09 PM Changeset in webkit [50576] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

2009-11-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: empty line in expectations build fix.

fast/events/event-listener-map-rehash-crash-expected.txt:

12:42 PM Changeset in webkit [50575] by jorlow@chromium.org

4 edits in trunk/WebCore

Revert 50569 since it broke QT. Build fix and just a revert, so no review.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-05

page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):

page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageEnabled):

page/Settings.h:

(WebCore::Settings::sessionStorageEnabled):

12:13 PM Changeset in webkit [50574] by pfeldman@chromium.org

16 edits
4 adds in trunk

2009-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

REGRESSION: Web Inspector doesn't show CSS rules properly for iframes

https://bugs.webkit.org/show_bug.cgi?id=30884

Test: inspector/styles-iframe.html

inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
inspector/front-end/InjectedScript.js: (InjectedScript.getStyles): (InjectedScript.getComputedStyle): (InjectedScript.addStyleSelector):
inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.evaluateForTestInFrontend.invokeMethod): (WebInspector.evaluateForTestInFrontend):

12:09 PM Changeset in webkit [50573] by Dimitri Glazkov

6 edits
2 adds in trunk

WebCore:

2009-11-05 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Geoffrey Garen and Dimitri Glazkov.

Rehashing of EventListenerMap leads to loss of EvenListenerList.
https://bugs.webkit.org/show_bug.cgi?id=31027

Tested by new fast/events/event-listener-map-rehash-crash.html.

EventListenerMap modified to store pointers to listener vectors:

dom/EventTarget.cpp: (WebCore::EventTargetData::~EventTargetData): (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener): (WebCore::EventTarget::fireEventListeners): (WebCore::EventTarget::getEventListeners): (WebCore::EventTarget::removeAllEventListeners):
dom/EventTarget.h:

Usages updated after interface changes:

inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::transferEventListenersToShadowTree):

LayoutTests:

2009-11-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Geoffrey Garen.

Rehashing of EventListenerMap leads to loss of EvenListenerList.
https://bugs.webkit.org/show_bug.cgi?id=31027

fast/events/event-listener-map-rehash-crash.html: Added.

12:05 PM Changeset in webkit [50572] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Add ruby tests and failing accessibility test to Windows Skipped list,
we should be able to re-add ruby tests, but not sure the correct course
of action yet.

platform/win/Skipped:

11:57 AM Changeset in webkit [50571] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-05 Dan Kegel <dank@chromium.org>

Reviewed by Dmitri Titov.

Add missing initialization for m_createdByParser.
https://bugs.webkit.org/show_bug.cgi?id=31089

Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction):

11:33 AM Changeset in webkit [50570] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <eric@webkit.org>

No review, just add a line which got left out of the patch uploaded for commit.

commit-queue is crashing when trying to reject patches after unknown failures
https://bugs.webkit.org/show_bug.cgi?id=31091

Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.

11:27 AM Changeset in webkit [50569] by jorlow@chromium.org

4 edits in trunk/WebCore

2009-11-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602

Part 2/2.

Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240

This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.

bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage):
page/DOMWindow.idl:
page/Settings.cpp: (WebCore::Settings::Settings):
page/Settings.h:
storage/Storage.cpp: (WebCore::Storage::setLocalStorageAvailable): (WebCore::Storage::localStorageAvailable): (WebCore::Storage::setSessionStorageAvailable): (WebCore::Storage::sessionStorageAvailable):
storage/Storage.h:

10:33 AM Changeset in webkit [50568] by jianli@chromium.org

3 edits in trunk/WebCore

Bug 31108 - [V8] REGRESSION: Pause on exception is broken
https://bugs.webkit.org/show_bug.cgi?id=31108

Reviewed by Pavel Feldman.

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

bindings/v8/V8Utilities.cpp:

(WebCore::reportException):

10:14 AM Changeset in webkit [50567] by Adam Roben

10 edits in trunk/WebKit/win

Make CFDictionaryPropertyBag::createInstance return a COMPtr

I also cleaned up CFDictionaryPropertyBag's class declaration a little
while I was at it.

Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
WebKit/win classes should return COMPtrs from their static constructor
members

Reviewed by Steve Falkenburg.

CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
initialize m_refCount to 0. m_refCount gets increased to 1 by
createInstance.
(CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.

CFDictionaryPropertyBag.h:
- Updated copyright years
- Fixed header guard to match current style
- Replaced #include of CoreFoundation.h with forward-declaration of CFMutableDictionaryRef
- Added #include of COMPtr.h
- Fixed opening brace placement in class declaration
- Made createInstance return a COMPtr
- Made constructor/destructor private
- Made QueryInterface and IPropertyBag functions private
- Removed unnecessary parameter names and MIDL comments

WebCache.cpp:

(WebCache::statistics): Updated for change to
CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
the IPropertyBag pointers into the s array.

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

WebDatabaseManager.cpp:

(WebDatabaseManager::dispatchDidModifyDatabase):

WebFrame.cpp:

(WebFrame::createJavaAppletWidget):
Updated for change to CFDictionaryPropertyBag::createInstance.

WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.

That function was also doing an unnecessary call to setDictionary(0).
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
Changed to return COMPtr.

(WebHistory::loadFromURL): Updated for change to
CFDictionaryPropertyBag::createInstance.

(WebHistory::removeAllItems): Updated for change to
CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
forgotten to call releaseUserInfo here.

(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):

WebIconDatabase.cpp:

(postDidAddIconNotification):
Updated for change to CFDictionaryPropertyBag::createInstance.

WebKitClassFactory.cpp:

(releaseRefFromCreateInstance): Added this overloaded function
template to abstract away the difference between createInstance
functions that return a ref'd pointer and createInstance functions
that return a COMPtr.
(WebKitClassFactory::CreateInstance): Changed to use
releaseRefFromCreateInstance.

9:59 AM Changeset in webkit [50566] by jianli@chromium.org

4 edits
2 adds in trunk

WebCore: We should not bubble up events if we drag something to an iframe that
has an invalid source.
https://bugs.webkit.org/show_bug.cgi?id=30469

Reviewed by Dmitri Titov.

Test: http/tests/misc/bubble-drag-events.html

page/EventHandler.cpp:

(WebCore::EventHandler::handleDragAndDropForTarget):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):

page/EventHandler.h:

(WebCore::EventHandler::):

LayoutTests: Tests the drag event bubbling on different targets:

iframe with invalid source
iframe with valid source
non-iframe droppable element

https://bugs.webkit.org/show_bug.cgi?id=30469

Reviewed by Dmitri Titov.

http/tests/misc/bubble-drag-events-expected.txt: Added.
http/tests/misc/bubble-drag-events.html: Added.

8:42 AM Changeset in webkit [50565] by Adam Roben

2 edits in trunk/WebKitTools

Remove bogus else clause in bugzilla-tool

Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
create-bug raises exception after entering bug description

Reviewed by David Kilzer.

Scripts/bugzilla-tool:

(CreateBug): else clauses are only hit if no exception is raised, so
it makes no sense to try to re-raise the exception in an else clause.
The exception will automatically be re-raised if it doesn't match any
of the except clauses, so we don't have to do anything special here at
all to get the desired behavior.

7:58 AM Changeset in webkit [50564] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up Timelines Clear by a factor of thousands.

https://bugs.webkit.org/show_bug.cgi?id=31160

inspector/front-end/utilities.js: (Element.prototype.removeChildren):

7:48 AM Changeset in webkit [50563] by eric@webkit.org

2 edits in trunk/WebKit/qt

2009-11-05 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Tor Arne Vestbø.

Add support for Shift-PageUp and Shift-PageDown key events.
https://bugs.webkit.org/show_bug.cgi?id=31166

Test: LayoutTests/editing/selection/shrink-selection-after-shift-pagedown.html

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

7:36 AM Changeset in webkit [50562] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-05 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

If high memory usage is detected, hint to V8 that it might be due
to external objects retained by V8 objects.
https://bugs.webkit.org/show_bug.cgi?id=31051

bindings/v8/V8GCController.cpp: (WebCore::GetMemoryUsageInMB): (WebCore::V8GCController::gcEpilogue): (WebCore::V8GCController::checkMemoryUsage):
bindings/v8/V8GCController.h:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction):

7:28 AM Changeset in webkit [50561] by eric@webkit.org

4 edits
2 adds in trunk

2009-11-05 Jeff Schiller <codedread@gmail.com>

Reviewed by Simon Fraser.

Added test to ensure proper order of matrix multiplication with SVGMatrix.
https://bugs.webkit.org/show_bug.cgi?id=16062

svg/dom/SVGMatrix-interface-expected.txt: Added.
svg/dom/SVGMatrix-interface.xhtml: Added.

2009-11-05 Jeff Schiller <codedread@gmail.com>

Reviewed by Simon Fraser.

Correct order of matrix multiplication for SVGMatrix.
https://bugs.webkit.org/show_bug.cgi?id=16062

Test: svg/dom/SVGMatrix-interface.xhtml

bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply):
svg/SVGMatrix.idl:

2:06 AM Changeset in webkit [50560] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-11-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Make resource-related records in timeline
actually take some time.

https://bugs.webkit.org/show_bug.cgi?id=31139

English.lproj/localizedStrings.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):

1:51 AM Changeset in webkit [50559] by eric@webkit.org

2 edits in trunk

2009-11-05 Priit Laes <plaes@plaes.org>

Reviewed by Jan Alonzo.

[Gtk] Build failure with --enable-introspection
https://bugs.webkit.org/show_bug.cgi?id=31102

Add search and include paths for JSCore-1.0.gir required by
gobject-introspection tools.

GNUmakefile.am:

1:31 AM Changeset in webkit [50558] by jorlow@chromium.org

6 edits in trunk/WebCore

2009-11-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Simplify LocalStorageThread
https://bugs.webkit.org/show_bug.cgi?id=30935

This is a re-submit of 50519. LocalStorageTask should have never been ref
counted. I've removed that and switched a PassRefPtr over to a PassOwnPtr.

On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.

No behavior should have changed.

storage/LocalStorageTask.h:
storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
storage/LocalStorageThread.h:
storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
storage/StorageSyncManager.h:

12:58 AM Changeset in webkit [50557] by jorlow@chromium.org

5 edits in trunk/WebCore

2009-11-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Calling databaseIdentifier on LocalStorage's background thread is not safe.
https://bugs.webkit.org/show_bug.cgi?id=31149

Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
is not safe. databaseIdentifier does a bunch of string concatenation which
ref-counts StringImpls in some cases. This was caught by valgrind thread
sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645

There's no way to test for such racyness, unfortunately.

storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::performImport):
storage/StorageAreaSync.h:
storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::fullDatabaseFilename):
storage/StorageSyncManager.h:

12:40 AM Changeset in webkit [50556] by Simon Hausmann

2 edits in trunk/WebKit/qt

Last Qt 4.5 build fix (*sigh*)

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05

tests/qwebpage/tst_qwebpage.cpp:

(inputMethodHints): inputMethodHints() is only used for
Qt 4.6, so guard the whole function.

12:36 AM Changeset in webkit [50555] by jorlow@chromium.org

4 edits in trunk/WebCore

2009-11-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Clean up StorageAreaSync
https://bugs.webkit.org/show_bug.cgi?id=31100

Major fixes: Break the ref count cycle for StorageArea on the main
thread, not the background thread since the latter is not safe.
Length() needs to block on the import completing.

Small fixes: setItem needs to handle the copy on write case even if it
has an exception. setItem and removeItem should just bail from the
the function if the value hasn't changed rather than wrapping the end
in an if block. Clear should only send an event if it wasn't already
cleared. StorageAreaSync should assert that the final sync was
scheduled.

storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): Forgot to block on the import. (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::setItem): Handle the copy on write case even when there's an exception. (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear):
storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::performImport): (WebCore::StorageAreaSync::markImported): (WebCore::StorageAreaSync::blockUntilImportComplete):
storage/StorageAreaSync.h:

12:34 AM Web Inspector edited by rik@webkit.org

Adding latest blog post (diff)

12:30 AM Changeset in webkit [50554] by Simon Hausmann

2 edits in trunk/WebKit/qt

Another prospective build fix against Qt 4.5 (build bot)

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05
Don't compile & run the QGraphicsWebView portion of the
input methods auto test with Qt 4.5.

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):

12:28 AM Changeset in webkit [50553] by zoltan@webkit.org

3 edits in trunk/JavaScriptCore

Use ARMv7 specific encoding for immediate constants on ARMv7 target
https://bugs.webkit.org/show_bug.cgi?id=31060

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.

assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::getOp2): Use INVALID_IMM
(JSC::ARMAssembler::getImm): Use encodeComplexImm for complex immediate
(JSC::ARMAssembler::moveImm): Ditto.
(JSC::ARMAssembler::encodeComplexImm): Encode a constant by one or two
instructions or a PC relative load.

assembler/ARMAssembler.h: Use INVALID_IMM if a constant cannot be

encoded as an immediate constant.
(JSC::ARMAssembler::):
(JSC::ARMAssembler::movw_r): 16-bit immediate load
(JSC::ARMAssembler::movt_r): High halfword 16-bit immediate load
(JSC::ARMAssembler::getImm16Op2): Encode immediate constant for
movw_r and mowt_r

12:23 AM Changeset in webkit [50552] by Simon Hausmann

2 edits in trunk/WebKit/qt

Prospective build fix against Qt 4.5 (build bot)

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::setInputMethodEnabled): Guard the
use of Qt 4.6 specific API with #ifdefs.

12:12 AM Changeset in webkit [50551] by Simon Hausmann

3 edits in trunk/WebKit/qt

[Qt] Fix enabling of input method support on QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=30605

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-01
Reviewed by Kenneth Christiansen.

Instead of setting the unsupported widget attribute on the
QGraphicsWidget in setInputMethodEnabled() set the
ItemAcceptsInputMethod GraphicsItem flag directly.

Changed the existing input method auto test to run once
on a QWebView and once on a QGraphicsWebView.

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::setInputMethodEnabled):

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):

12:11 AM Changeset in webkit [50550] by Simon Hausmann

4 edits in trunk/WebKit/qt

Added QGraphicsWebView::modified property, for consistency
with QWebView.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Kenneth Christiansen.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::isModified):

Api/qgraphicswebview.h:
tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

12:11 AM Changeset in webkit [50549] by Simon Hausmann

4 edits in trunk/WebKit/qt

Removed status and progress properties of QGraphicsWebView.
Added loadProgress and statusBarMessage signals instead,
after API review.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Kenneth Christiansen.

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::setPage):

Api/qgraphicswebview.h:
tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::qgraphicswebview):

Nov 4, 2009:

11:53 PM Changeset in webkit [50548] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CachedResource
https://bugs.webkit.org/show_bug.cgi?id=31114

Reviewed by Eric Seidel.

Inherits CachedResource class from Noncopyable because its (its child
class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
and it is no need to be copyable.

loader/CachedResource.h:

11:07 PM Changeset in webkit [50547] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

svn-apply's fixChangeLogPatch function seems broken
https://bugs.webkit.org/show_bug.cgi?id=30683

Update fixChangeLogPatch to be able to handle patches which
don't start at line 1.
Add unit tests for svn-apply to scm_unittest.py.

Scripts/VCSUtils.pm:
Scripts/modules/scm_unittest.py:

10:52 PM Changeset in webkit [50546] by eric@webkit.org

4 edits in trunk

2009-11-04 Mark Mentovai <mark@chromium.org>

Reviewed by Mark Rowe.

Provide TARGETING_TIGER and TARGETING_LEOPARD as analogues to
BUILDING_ON_TIGER and BUILDING_ON_LEOPARD. The TARGETING_ macros
consider the deployment target; the BUILDING_ON_ macros consider the
headers being built against.

wtf/Platform.h:

2009-11-04 Mark Mentovai <mark@chromium.org>

Reviewed by Mark Rowe.

Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
which is true when targeting 10.6 or later.

HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
is present in the CGInterpolationQuality enum, and must be handled
by a switch that has cases for each enumerated value.

USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
on 10.6 or later, and that CoreGraphics will understand when
InterpolationMedium is mapped to kCGInterpolationMedium at runtime.

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):

10:39 PM Changeset in webkit [50545] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Dan Kegel <dank@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
https://bugs.webkit.org/show_bug.cgi?id=31138

Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind

page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):

10:27 PM Changeset in webkit [50544] by timothy@apple.com

3 edits in trunk/WebCore

Update the Web Inspector Timeline panel to better match the mock-up.

https://bugs.webkit.org/show_bug.cgi?id=31150

Reviewed by Pavel Feldman.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelinePanel.prototype._dragWindow):
(WebInspector.TimelinePanel.prototype._resizeWindowLeft):
(WebInspector.TimelinePanel.prototype._resizeWindowRight):
(WebInspector.TimelineCategoryTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.refresh):
(WebInspector.TimelineCategoryGraph):

inspector/front-end/inspector.css:

9:33 PM Changeset in webkit [50543] by justin.garcia@apple.com

1 edit in trunk/WebCore/ChangeLog

Fixed typos.

9:25 PM Changeset in webkit [50542] by justin.garcia@apple.com

6 edits
6 adds in trunk

WebCore:

2009-11-02 Justin Garcia <justin.garcia@apple.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph

Added editing/deleting/25439-{1,2,3}.html

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot be made inline with other content. Instead of merging, just move the caret to just before the selection we deleted.
editing/htmlediting.cpp: (WebCore::firstInSpecialElement): Added a FIXME. This function begins iterating up from pos.node(), which doesn't necessarily contain pos (suppose pos was [img, 0]). (WebCore::lastInSpecialElement): Ditto. (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp. Added a check for non-inline images.
editing/htmlediting.h:
editing/visible_units.cpp: (WebCore::startOfParagraph): Use moved/renamed function. Removed FIXME. The problem causing 5027702 is now squarely in first/lastInSpecialElement (WebCore::endOfParagraph): Ditto.

LayoutTests:

2009-11-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph

editing/deleting/delete-before-block-image-1-expected.txt: Added.
editing/deleting/delete-before-block-image-1.html: Added.
editing/deleting/delete-before-block-image-2-expected.txt: Added.
editing/deleting/delete-before-block-image-2.html: Added.
editing/deleting/delete-before-block-table-expected.txt: Added.
editing/deleting/delete-before-block-table.html: Added.

9:02 PM Changeset in webkit [50541] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=31151
Fix branchDouble behaviour on ARM THUMB2 JIT.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

The ARMv7 JIT is currently using ARMv7Assembler::ConditionEQ to branch
for DoubleEqualOrUnordered, however this is incorrect – ConditionEQ won't
branch on unordered operands. Similarly, DoubleLessThanOrUnordered &
DoubleLessThanOrEqualOrUnordered use ARMv7Assembler::ConditionLO &
ARMv7Assembler::ConditionLS, whereas they should be using
ARMv7Assembler::ConditionLT & ARMv7Assembler::ConditionLE.

Fix these, and fill out the missing DoubleConditions.

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::):
(JSC::MacroAssemblerARMv7::branchDouble):

7:29 PM Changeset in webkit [50540] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

Rubber Stamped by Oliver Hunt.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Enable native call optimizations on ARMv7. (Existing ARM_TRADITIONAL
implementation was generic, worked perfectly, just needed turning on).

jit/JITOpcodes.cpp:
wtf/Platform.h:

7:04 PM Changeset in webkit [50539] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Rubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Add a missing assert to the ARMv7 JIT.

assembler/ARMv7Assembler.h:

(JSC::ARMThumbImmediate::ARMThumbImmediate):

6:22 PM Changeset in webkit [50538] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Remove bogus op_ prefix on dumped version of three opcodes.

Rubber-stamped by Oliver Hunt.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

6:22 PM Changeset in webkit [50537] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

Fix dumping of constants in bytecode so that they aren't printed as large positive register numbers.

Reviewed by Sam Weinig.

We do this by having the registerName function return information about the constant if the register
number corresponds to a constant. This requires that registerName, and several functions that call it,
be converted to member functions of CodeBlock so that the constant value can be retrieved. The
ExecState also needs to be threaded down through these functions so that it can be passed on to
constantName when needed.

bytecode/CodeBlock.cpp:

(JSC::constantName):
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):

bytecode/CodeBlock.h:

(JSC::CodeBlock::isConstantRegisterIndex):

5:42 PM Changeset in webkit [50536] by enrica@apple.com

4 edits
2 adds in trunk

WebCore: Hang in Mail on attempting to change indent level.
<rdar://problem/7131805>
https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

The hang was caused by an infinite loop inside outdentRegion.
The code did not account for the fact that, when a list item
cointains multiple paragraphs, outdent moves all paragraphs at
once, invalidating some of the position we keep track of in the loop.
Some code refactoring has also been done to minimize duplicate code.

Test: editing/execCommand/outdent-multiparagraph-list.html

editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
outdentRegion to doApply.
(WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
(WebCore::IndentOutdentCommand::doApply): Some code refactoring.

editing/IndentOutdentCommand.h: Added VisiblePosition parameters to

indentRegion and outdentRegion.

LayoutTests: Hang in Mail on attempting to change indent level
<rdar://problem/7131805>
https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

Added test to cover all the different code paths.

editing/execCommand/outdent-multiparagraph-list-expected.txt: Added.
editing/execCommand/outdent-multiparagraph-list.html: Added.

4:50 PM Changeset in webkit [50535] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Volume slider doesn't have a thumb
https://bugs.webkit.org/show_bug.cgi?id=31135

Fixed an incorrect if statement that prevents volume slider
being updated.

The statement checks if the slider value equals to the current
volume value of the media control to avoid updating the volume
slider. Updating the volume slider control shouldn't be within
this condition because we explicitly set them to be equals
during creation of the controls and also when mouse events are
received on the volume control.

No new tests because existing code breaks:
LayoutTests/media/video-volume-slider.html

It should now start passing on Chromium.

rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Update the volume slider regardless of the current volume value of the media control.

4:35 PM Changeset in webkit [50534] by levin@chromium.org

6 edits in trunk/WebCore

Need to properly disable applicationCache at runtime
https://bugs.webkit.org/show_bug.cgi?id=30417

Patch by Jenn Braithwaite <jennb@chromium.org> on 2009-11-04
Reviewed by David Levin.

Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.

No new exposed functionality, so no new tests.

bindings/v8/RuntimeEnabledFeatures.cpp:
bindings/v8/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):

bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::ACCESSOR_RUNTIME_ENABLER):

page/DOMWindow.idl:

4:12 PM Changeset in webkit [50533] by ap@apple.com

2 edits in trunk/JavaScriptCore

2009-11-04 Pavel Heimlich <tropikhajma@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=30647
Solaris build failure due to strnstr.

wtf/StringExtras.h: Enable strnstr on Solaris, too.

3:59 PM Changeset in webkit [50532] by dbates@webkit.org

3 edits in trunk/LayoutTests

2009-11-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30266

Changed data format type from "text" to "text/plain" to pass Chrome tests.

fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
fast/events/drag-and-drop-dataTransfer-types-nocrash.html:

3:59 PM Changeset in webkit [50531] by barraclough@apple.com

6 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=31104
Refactor x86-specific behaviour out of the JIT.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

Add explicit double branch conditions for ordered and unordered comparisons (presently the brehaviour is a mix).
Refactor double to int conversion out into the MacroAssembler.
Remove broken double to int conversion for !JSVALUE32_64 builds - this code was broken and slowing us down, fixing it showed it not to be an improvement.
Remove exclusion of double to int conversion from (1 % X) cases in JSVALUE32_64 builds - if this was of benefit this is no longer the case; simplify.

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):

jit/JITArithmetic.cpp:

(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jfalse):

3:48 PM Changeset in webkit [50530] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=31143
Assertion failure in CredentialStorage::set() when proxy credentials are being set

No test, cannot test proxy behavior.

platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the possibility of null url. Release mode changes are likely inconsequential - e.g. we used to add ":" to origin set, which is weird, but safe.

2:21 PM Changeset in webkit [50529] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Web Inspector: Leftover Breakpoints in the Sidebar Pane
https://bugs.webkit.org/show_bug.cgi?id=30659

No new tests.

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):

1:44 PM Changeset in webkit [50528] by eric@webkit.org

7 edits in trunk/WebCore

2009-11-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Timothy Hatcher.

WebInspector: Use a different method to identify the webkit port in
InspectorBackent::platform().
This corrects the inspector expected behavior with Qt on Windows.
https://bugs.webkit.org/show_bug.cgi?id=31116

inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::platform): (WebCore::InspectorBackend::port):
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/front-end/InspectorControllerStub.js: (.WebInspector.InspectorControllerStub.prototype.port):
inspector/front-end/inspector.css:
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.toolbarDragStart):

1:00 PM Changeset in webkit [50527] by eric@webkit.org

7 edits in trunk

2009-11-04 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Update Cairo requirement to 1.6.

https://bugs.webkit.org/show_bug.cgi?id=19266

configure.ac:

2009-11-04 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Update Cairo requirement to 1.6.

Also remove all conditional code and workarounds for older versions of
Cairo.
In particular, gain image quality by removing the use of
CAIRO_FILTER_NEAREST when rendering images and use the default
bilinear filter instead.
https://bugs.webkit.org/show_bug.cgi?id=19266

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawPattern):
platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty): (WebCore::Path::boundingRect):
platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):

12:46 PM Changeset in webkit [50526] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix. Restore removed string conversion after cleanup.

12:22 PM Changeset in webkit [50525] by eric@webkit.org

15 edits
2 adds in trunk

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
https://bugs.webkit.org/show_bug.cgi?id=31096

accessibility/aria-combobox.html: Added.
platform/gtk/Skipped:
platform/mac/accessibility/aria-combobox-expected.txt: Added.
platform/win/Skipped:

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
https://bugs.webkit.org/show_bug.cgi?id=31096

Test: accessibility/aria-combobox.html

accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isComboBox): (WebCore::AccessibilityObject::isExpanded): (WebCore::AccessibilityObject::expandObject): (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::expandObject): (WebCore::AccessibilityRenderObject::isExpanded): (WebCore::createARIARoleMap):
accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
html/HTMLAttributeNames.in:

2009-11-04 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Need to implement ARIA role="combobox"
https://bugs.webkit.org/show_bug.cgi?id=31096

DumpRenderTree/AccessibilityUIElement.cpp: (showMenuCallback): (getIsExpandedCallback): (AccessibilityUIElement::getJSClass):
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):

12:12 PM Changeset in webkit [50524] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-04 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Fixes naming inconsistencies in TimelineRecordFactory.
https://bugs.webkit.org/show_bug.cgi?id=31132

inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord): (WebCore::TimelineRecordFactory::createXHRLoadRecord): (WebCore::TimelineRecordFactory::createEvaluateScriptRecord): (WebCore::TimelineRecordFactory::createMarkTimelineRecord): (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord): (WebCore::TimelineRecordFactory::createPaintRecord):
inspector/TimelineRecordFactory.h:

12:04 PM Changeset in webkit [50523] by eric@webkit.org

9 edits in trunk/WebCore

2009-11-04 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Followon to bug 31080, which protects Timeline
instrumentation in the case where InspectorTimelineAgent
is enabled or disabled during an event dispatch.

https://bugs.webkit.org/show_bug.cgi?id=31121

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
dom/Document.cpp: (WebCore::Document::recalcStyle):
dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
page/DOMWindow.cpp: (WebCore::DOMWindow::inspectorTimelineAgent): (WebCore::DOMWindow::dispatchEvent):
page/DOMWindow.h:
page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):

11:55 AM Changeset in webkit [50522] by kevino@webkit.org

2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix an assert on shutdown when wxWebView has captured the mouse,
and make sure wxWebView's right click handling is only active when
the WebCore popup menu is used.

https://bugs.webkit.org/show_bug.cgi?id=31131

11:35 AM Changeset in webkit [50521] by jorlow@chromium.org

5 edits in trunk/WebCore

Revert 50519 while I work out what went wrong.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-04

storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::create):
(WebCore::LocalStorageThread::LocalStorageThread):
(WebCore::LocalStorageThread::start):
(WebCore::LocalStorageThread::localStorageThreadStart):
(WebCore::LocalStorageThread::localStorageThread):
(WebCore::LocalStorageThread::scheduleImport):
(WebCore::LocalStorageThread::scheduleSync):
(WebCore::LocalStorageThread::terminate):
(WebCore::LocalStorageThread::performTerminate):

storage/LocalStorageThread.h:
storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::~StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):

storage/StorageSyncManager.h:

11:32 AM Changeset in webkit [50520] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-11-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add basic support for resource events and marks.
Couple of drive-by fixes. Enabling the panel!

https://bugs.webkit.org/show_bug.cgi?id=31130

English.lproj/localizedStrings.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
inspector/front-end/inspector.js: (WebInspector._createPanels):

11:11 AM Changeset in webkit [50519] by jorlow@chromium.org

5 edits in trunk/WebCore

2009-11-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Simplify LocalStorageThread
https://bugs.webkit.org/show_bug.cgi?id=30935

On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.

No behavior should have changed.

storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
storage/LocalStorageThread.h:
storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
storage/StorageSyncManager.h:

10:28 AM Changeset in webkit [50518] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue is crashing when trying to reject patches after unknown failures
https://bugs.webkit.org/show_bug.cgi?id=31091

Scripts/bugzilla-tool:
- patchid was a copy/paste mistake. This code has no 'patch' variable so we have to find out what the current patch is by asking bugzilla again.
- Discovered that this code was also leaking file descriptors, so fixed that.

10:21 AM Changeset in webkit [50517] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-11-04 Mark Mentovai <mark@chromium.org>

Reviewed by Eric Seidel.

Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp. This is supposed
to be set as needed only in wtf/Platform.h.

JavaScriptCore.gyp/JavaScriptCore.gyp:

10:13 AM Changeset in webkit [50516] by eric@webkit.org

4 edits in trunk

2009-11-04 Vadim Zeitlin <vadim@wxwidgets.org>

Reviewed by Eric Seidel.

[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):

2009-11-04 Vadim Zeitlin <vadim@wxwidgets.org>

Reviewed by Eric Seidel.

[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

WebFrame.cpp: (wxWebFrame::SetPageSource): (wxWebFrame::LoadURL):

9:17 AM Changeset in webkit [50515] by eric@webkit.org

7 edits in trunk/WebCore

2009-11-04 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Adds lightweight network resources to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31065

inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord): (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:

9:08 AM Changeset in webkit [50514] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] ASSERT failure when receiving 401 HTTP Authentication response.
https://bugs.webkit.org/show_bug.cgi?id=31077

Allow sending the response body under the same conditions that we
allow it to finish without reporting an error.

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

8:58 AM Changeset in webkit [50513] by Adam Roben

2 edits in trunk/WebKitTools

Make run-webkit-tests work for the Debug_Internal Windows configuration

In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
suffix.

Fixes <http://webkit.org/b/31123>.

Reviewed by Sam Weinig.

Scripts/run-webkit-tests: Don't add the _debug suffix in

Debug_Internal, either.

8:13 AM Changeset in webkit [50512] by Adam Roben

2 edits in trunk/WebCore

Sort WebCore.base.exp

Rubber-stamped by Dan Bernstein.

WebCore.base.exp: Sorted.

4:12 AM Changeset in webkit [50511] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Put test into skiplist added in r50489 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04

platform/qt/Skipped: inspector/timeline-trivial.html added.

3:27 AM Changeset in webkit [50510] by Csaba Osztrogonác

6 edits
1 add
3 deletes in trunk

Unreviewed rollout.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04
Revert r50496 because it broke all layout tests on QtBuildBot.

WebCore:

WebCore.pro:
platform/graphics/qt/FontCacheQt.cpp:

(WebCore::fontCache):
(WebCore::FontCache::FontCache):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKey::hash):
(WebCore::FontPlatformDataCacheKey::computeHash):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontPlatformDataCacheKeyHash::equal):
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
(WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
(WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::addClient):
(WebCore::FontCache::removeClient):
(WebCore::FontCache::invalidate):

platform/graphics/qt/FontFallbackListQt.cpp: Added.

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::determinePitch):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::fontDataForCharacters):
(WebCore::FontFallbackList::setPlatformFont):

platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformData::pixelSize):

platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

svg/text/resources: Removed.
svg/text/resources/text-font-invalid.svg: Removed.
svg/text/text-font-invalid-expected.txt: Removed.
svg/text/text-font-invalid.html: Removed.

2:35 AM Changeset in webkit [50509] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31044
[Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkParentOfWebView): (webkit_accessible_get_index_in_parent): (webkit_accessible_get_parent):

2:28 AM Changeset in webkit [50508] by eric@webkit.org

5 edits
2 adds in trunk/WebCore

2009-11-04 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib

Initial version of this patch by Jürg Billeter and Naiem Shaik.
Patch 2/4 - Moving TextCodecs to GLib

Added probing for a hard-coded lists of text encodings.
The basis of this list is taken from the encodings supported by iconv,
then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
a number of Chinese ones.

Probing is necessary with the current design of text codecs
as iconv/GLib do not support enumerating available encodings.

GNUmakefile.am:
platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
platform/text/gtk/TextCodecGtk.cpp: Added. (WebCore::): (WebCore::newTextCodecGtk): (WebCore::TextCodecGtk::isEncodingAvailable): (WebCore::TextCodecGtk::registerEncodingNames): (WebCore::TextCodecGtk::registerCodecs): (WebCore::TextCodecGtk::registerBaseEncodingNames): (WebCore::TextCodecGtk::registerBaseCodecs): (WebCore::TextCodecGtk::registerExtendedEncodingNames): (WebCore::TextCodecGtk::registerExtendedCodecs): (WebCore::TextCodecGtk::TextCodecGtk): (WebCore::TextCodecGtk::~TextCodecGtk): (WebCore::TextCodecGtk::releaseIConv): (WebCore::TextCodecGtk::createIConvDecoder): (WebCore::TextCodecGtk::createIConvEncoder): (WebCore::TextCodecGtk::decode): (WebCore::TextCodecGtk::encode):
platform/text/gtk/TextCodecGtk.h: Added.

2:19 AM Changeset in webkit [50507] by eric@webkit.org

9 edits in trunk

2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Unify redudant methods which will always return the same value.

platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
platform/gtk/PasteboardHelper.h:

2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Jan Alonzo.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Move handling of target list to PasteboardHelperGtk.

WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::fullTargetList):
WebCoreSupport/PasteboardHelperGtk.h:
webkit/webkitprivate.cpp: (WebKit::pasteboardHelperInstance): (webkit_init):
webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_init): (webkit_web_view_get_copy_target_list): (webkit_web_view_get_paste_target_list):

1:31 AM Changeset in webkit [50506] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
Any app or AT can attempt to ref a child at a bogus index.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_ref_child):

1:15 AM Changeset in webkit [50505] by eric@webkit.org

4 edits in trunk/WebKitTools

2009-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

committers.py needs a way to store non-bugzilla email addresses
https://bugs.webkit.org/show_bug.cgi?id=31037

Make Committer and Reviewer constructors take a single email or a list of emails.
Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
Expose reviewers(), used by validate-committer-lists on bug 30970.

Scripts/modules/committers.py:
Scripts/modules/committers_unittest.py: Added tests for the new code.

12:58 AM Changeset in webkit [50504] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-04 Benjamin Otte <otte@gnome.org>

Reviewed by Jan Alonzo.

[gtk] Use gst_element_class_set_details_simple()

Cosmetic change, just code simplification

platform/graphics/gtk/VideoSinkGStreamer.cpp:

12:50 AM Changeset in webkit [50503] by eric@webkit.org

3 edits in trunk/WebKit/qt

2009-11-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

[Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView.
https://bugs.webkit.org/show_bug.cgi?id=30979

Decouple QWebViewPrivate from QWebPageClient, and automatically create
QWebPageWidgetClient whenever the view is QWidget based.

Api/qwebpage.cpp: (QWebPageWidgetClient::QWebPageWidgetClient): (QWebPageWidgetClient::scroll): (QWebPageWidgetClient::update): (QWebPageWidgetClient::setInputMethodEnabled): (QWebPageWidgetClient::setInputMethodHint): (QWebPageWidgetClient::cursor): (QWebPageWidgetClient::updateCursor): (QWebPageWidgetClient::palette): (QWebPageWidgetClient::screenNumber): (QWebPageWidgetClient::ownerWidget): (QWebPageWidgetClient::pluginParent): (QWebPage::setView):
Api/qwebview.cpp: (QWebView::~QWebView): (QWebView::setPage): (QWebView::event):

12:42 AM Changeset in webkit [50502] by eric@webkit.org

6 edits in trunk/WebCore

2009-11-04 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds paint rectangle information to TimelineAgent's didPaint callback.
https://bugs.webkit.org/show_bug.cgi?id=31087

inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint):
inspector/InspectorTimelineAgent.h:
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
inspector/TimelineRecordFactory.h:
page/FrameView.cpp: (WebCore::FrameView::paintContents):

12:33 AM Changeset in webkit [50501] by eric@webkit.org

12 edits in trunk

2009-11-04 Jaime Yap <jaimeyap@google.com>

Reviewed by Timothy Hatcher.

This patch adds API to the console object for annotating the
inspector timeline. This allows developers to mark logical
checkpoints in their apps and have them overlaid in the event
record tree.

tests updated: LayoutTests/fast/dom/Window/window-properties.html
https://bugs.webkit.org/show_bug.cgi?id=31082

inspector/InspectorController.cpp: (WebCore::InspectorController::markTimeline):
inspector/InspectorController.h:
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkTimeline):
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
page/Console.cpp: (WebCore::Console::markTimeline):
page/Console.h:
page/Console.idl:

Nov 3, 2009:

11:50 PM Changeset in webkit [50500] by ukai@chromium.org

2 edits in trunk/WebKitTools

2009-11-03 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Levin.

Start/Stop Web Socket and Web Socket Secure servers for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27491

The test path determination logic is changed to handle websocket and websocket/ssl cases.
The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.

Functions to start or stop Web Socket servers are added.

Scripts/run-webkit-tests:

10:09 PM Changeset in webkit [50499] by Simon Hausmann

2 edits in trunk/WebCore

Unreviewed build fix for WebInspector with Qt build.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

inspector/front-end/WebKit.qrc:

9:52 PM Changeset in webkit [50498] by rolandsteiner@chromium.org

2 edits in trunk/LayoutTests

(on IRC)

Reviewed by Mark Rowe.

add ruby layout tests to the Skipped list on mac, since they somehow cause
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html to fail.

no new tests.

platform/mac/Skipped:

8:29 PM Changeset in webkit [50497] by Darin Adler

190 edits in trunk/WebKitSite

Set the MIME type for all PNG files in this directory.

WebKitSite:

Patch by Darin Adler <Darin Adler> on 2009-11-03

blog-files/3d-transforms/mighty-cubes.png: Added property svn:mime-type.
blog-files/3d-transforms/poster-circle.png: Added property svn:mime-type.
blog-files/InspectorDatabaseBrowser.png: Modified property svn:mime-type.
blog-files/acid3-100.png: Modified property svn:mime-type.
blog-files/acid3-full-rendering-pass.png: Modified property svn:mime-type.
blog-files/acid3-rendering-reference.png: Modified property svn:mime-type.
blog-files/acid3-screenshot.png: Modified property svn:mime-type.
blog-files/acid3-timing-screenshot.png: Modified property svn:mime-type.
blog-files/acid3-timing.png: Modified property svn:mime-type.
blog-files/bounce.png: Added property svn:mime-type.
blog-files/gebcnwebkitonly.png: Modified property svn:mime-type.
blog-files/inspector-closure-scope.png: Added property svn:mime-type.
blog-files/inspector-console-autocomplete.png: Added property svn:mime-type.
blog-files/inspector-databases-panel-query-view.png: Added property svn:mime-type.
blog-files/inspector-databases-panel.png: Added property svn:mime-type.
blog-files/inspector-disabling-properties.png: Added property svn:mime-type.
blog-files/inspector-elements-panel.png: Added property svn:mime-type.
blog-files/inspector-event-scope.png: Added property svn:mime-type.
blog-files/inspector-profiles-panel.png: Added property svn:mime-type.
blog-files/inspector-resources-panel.png: Added property svn:mime-type.
blog-files/inspector-scripts-panel.png: Added property svn:mime-type.
blog-files/inspector-searching-elements.png: Added property svn:mime-type.
blog-files/inspector-searching-profiles.png: Added property svn:mime-type.
blog-files/inspector-status-bar-with-errors.png: Added property svn:mime-type.
blog-files/inspector-toolbar.png: Added property svn:mime-type.
blog-files/inspector-with-scope.png: Added property svn:mime-type.
blog-files/inspector/breakpoints.png: Added property svn:mime-type.
blog-files/inspector/colors.png: Added property svn:mime-type.
blog-files/inspector/cookies.png: Added property svn:mime-type.
blog-files/inspector/css_selectors.png: Added property svn:mime-type.
blog-files/inspector/css_syntax_highlight.png: Added property svn:mime-type.
blog-files/inspector/dom_storage.png: Added property svn:mime-type.
blog-files/inspector/edit_attributes.png: Added property svn:mime-type.
blog-files/inspector/enable.png: Added property svn:mime-type.
blog-files/inspector/event_listeners.png: Added property svn:mime-type.
blog-files/inspector/form_data.png: Added property svn:mime-type.
blog-files/inspector/inline_highlight.png: Added property svn:mime-type.
blog-files/inspector/inorder.png: Added property svn:mime-type.
blog-files/inspector/inspect_inspector.png: Added property svn:mime-type.
blog-files/inspector/inspect_inspector_small.png: Added property svn:mime-type.
blog-files/inspector/load_lines.png: Added property svn:mime-type.
blog-files/inspector/nodelist.png: Added property svn:mime-type.
blog-files/inspector/scope_bar.png: Added property svn:mime-type.
blog-files/inspector/watched_expression.png: Added property svn:mime-type.
blog-files/kate-circle.png: Modified property svn:mime-type.
blog-files/kate-gradient-rounded.png: Modified property svn:mime-type.
blog-files/kate-gradient.png: Modified property svn:mime-type.
blog-files/kate-reflected.png: Modified property svn:mime-type.
blog-files/kate-vignette-mask.png: Modified property svn:mime-type.
blog-files/kate.png: Modified property svn:mime-type.
blog-files/leaves/images/apple-touch-icon.png: Added property svn:mime-type.
blog-files/leaves/images/realLeaf1.png: Added property svn:mime-type.
blog-files/leaves/images/realLeaf2.png: Added property svn:mime-type.
blog-files/leaves/images/realLeaf3.png: Added property svn:mime-type.
blog-files/leaves/images/realLeaf4.png: Added property svn:mime-type.
blog-files/leaves/images/textBackground.png: Added property svn:mime-type.
blog-files/maskspeedracer.png: Modified property svn:mime-type.
blog-files/pulse.png: Added property svn:mime-type.
blog-files/scrollbarpicture.png: Modified property svn:mime-type.
blog-files/sfx-perf.png: Modified property svn:mime-type.
blog-files/squirrelfish-webkit-graph.png: Modified property svn:mime-type.
blog-files/squirrelfish.png: Modified property svn:mime-type.
blog-files/vignette-mask.png: Modified property svn:mime-type.
blog-files/webgl/resources/mars500x250.png: Modified property svn:mime-type.
blog-files/wsj-nopreload.png: Modified property svn:mime-type.
blog-files/wsj-preload.png: Modified property svn:mime-type.
blog-files/wsj-vs.png: Modified property svn:mime-type.
blog/wp-admin/images/align-center.png: Added property svn:mime-type.
blog/wp-admin/images/align-left.png: Added property svn:mime-type.
blog/wp-admin/images/align-none.png: Added property svn:mime-type.
blog/wp-admin/images/align-right.png: Added property svn:mime-type.
blog/wp-admin/images/archive-link.png: Added property svn:mime-type.
blog/wp-admin/images/blue-grad.png: Added property svn:mime-type.
blog/wp-admin/images/button-grad-active-vs.png: Added property svn:mime-type.
blog/wp-admin/images/button-grad-active.png: Added property svn:mime-type.
blog/wp-admin/images/button-grad-vs.png: Added property svn:mime-type.
blog/wp-admin/images/button-grad.png: Added property svn:mime-type.
blog/wp-admin/images/comment-grey-bubble.png: Added property svn:mime-type.
blog/wp-admin/images/fade-butt.png: Modified property svn:mime-type.
blog/wp-admin/images/fav-top.png: Added property svn:mime-type.
blog/wp-admin/images/fav-vs.png: Added property svn:mime-type.
blog/wp-admin/images/fav.png: Added property svn:mime-type.
blog/wp-admin/images/generic.png: Added property svn:mime-type.
blog/wp-admin/images/gray-grad.png: Added property svn:mime-type.
blog/wp-admin/images/icons32-vs.png: Added property svn:mime-type.
blog/wp-admin/images/icons32.png: Added property svn:mime-type.
blog/wp-admin/images/list-vs.png: Added property svn:mime-type.
blog/wp-admin/images/list.png: Added property svn:mime-type.
blog/wp-admin/images/logo-ghost.png: Added property svn:mime-type.
blog/wp-admin/images/marker.png: Added property svn:mime-type.
blog/wp-admin/images/mask.png: Added property svn:mime-type.
blog/wp-admin/images/menu-vs.png: Added property svn:mime-type.
blog/wp-admin/images/menu.png: Added property svn:mime-type.
blog/wp-admin/images/no.png: Added property svn:mime-type.
blog/wp-admin/images/se.png: Added property svn:mime-type.
blog/wp-admin/images/wheel.png: Added property svn:mime-type.
blog/wp-admin/images/white-grad-active.png: Added property svn:mime-type.
blog/wp-admin/images/white-grad.png: Added property svn:mime-type.
blog/wp-admin/images/wordpress-logo.png: Modified property svn:mime-type.
blog/wp-admin/images/yes.png: Added property svn:mime-type.
blog/wp-content/Picture9.png: Modified property svn:mime-type.
blog/wp-content/chucknorris.png: Modified property svn:mime-type.
blog/wp-content/databaseexample.png: Modified property svn:mime-type.
blog/wp-content/drosera.png: Modified property svn:mime-type.
blog/wp-content/hitlist.png: Modified property svn:mime-type.
blog/wp-content/rotate.png: Modified property svn:mime-type.
blog/wp-content/svgtext.png: Modified property svn:mime-type.
blog/wp-content/svgtextmini.png: Modified property svn:mime-type.
blog/wp-content/svgtextmini_01.png: Modified property svn:mime-type.
blog/wp-content/themes/classic/screenshot.png: Modified property svn:mime-type.
blog/wp-content/themes/default/screenshot.png: Modified property svn:mime-type.
blog/wp-content/uploads/2007/06/newinspector.png: Modified property svn:mime-type.
blog/wp-content/webInspector.png: Modified property svn:mime-type.
blog/wp-includes/images/crystal/archive.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/audio.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/code.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/default.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/document.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/interactive.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/spreadsheet.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/text.png: Added property svn:mime-type.
blog/wp-includes/images/crystal/video.png: Added property svn:mime-type.
blog/wp-includes/images/rss.png: Modified property svn:mime-type.
blog/wp-includes/images/upload.png: Added property svn:mime-type.
blog/wp-includes/images/wlw/wp-comments.png: Added property svn:mime-type.
blog/wp-includes/images/wlw/wp-icon.png: Added property svn:mime-type.
blog/wp-includes/images/wlw/wp-watermark.png: Added property svn:mime-type.
blog/wp-includes/js/codepress/images/line-numbers.png: Added property svn:mime-type.
blog/wp-includes/js/thickbox/macFFBgHack.png: Added property svn:mime-type.
blog/wp-includes/js/thickbox/tb-close.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/plugins/wpeditimage/img/delete.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/plugins/wpeditimage/img/image.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/plugins/wpgallery/img/delete.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/plugins/wpgallery/img/edit.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/plugins/wpgallery/img/gallery.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/img/gotmoxie.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/img/sflogo.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/skins/default/img/buttons.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_black.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_silver.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/butt2.png: Added property svn:mime-type.
blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/button_bg.png: Added property svn:mime-type.
demos/calendar/Images/AirPort4.png: Modified property svn:mime-type.
demos/calendar/Images/AirPortError.png: Modified property svn:mime-type.
demos/calendar/Images/disclosureTriangleSmallDown.png: Modified property svn:mime-type.
demos/calendar/Images/disclosureTriangleSmallRight.png: Modified property svn:mime-type.
demos/calendar/Images/statusbarBackground.png: Modified property svn:mime-type.
demos/calendar/Images/statusbarResizerVertical.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/button.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/buttonRight.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/camera.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/link.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/textAlign.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Modified property svn:mime-type.
demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Modified property svn:mime-type.
demos/editingToolbar/images/safari.png: Modified property svn:mime-type.
demos/sticky-notes/deleteButton.png: Added property svn:mime-type.
demos/sticky-notes/deleteButtonPressed.png: Added property svn:mime-type.
demos/transitions-and-transforms/Horsehead.png: Modified property svn:mime-type.
demos/transitions-and-transforms/Spaces.png: Modified property svn:mime-type.
demos/transitions-and-transforms/Stacks.png: Modified property svn:mime-type.
images/DroseraPic.png: Modified property svn:mime-type.
misc/drosera/drosera.png: Modified property svn:mime-type.
perf/slickspeed/logo.png: Modified property svn:mime-type.

WebKitSite/specs/CSSVisualEffects:

Patch by Darin Adler <Darin Adler> on 2009-11-03

css3-2d-transforms/compound_transform.png: Modified property svn:mime-type.
css3-2d-transforms/transform1.png: Modified property svn:mime-type.
css3-2d-transforms/transform2.png: Modified property svn:mime-type.
css3-3d-transforms/compound_transform.png: Modified property svn:mime-type.
css3-3d-transforms/transform1.png: Modified property svn:mime-type.
css3-3d-transforms/transform2.png: Modified property svn:mime-type.
css3-animations/animation1.png: Modified property svn:mime-type.
css3-animations/sandwich.png: Modified property svn:mime-type.
css3-transitions/TimingFunction.png: Modified property svn:mime-type.
css3-transitions/transition1.png: Modified property svn:mime-type.

7:37 PM Changeset in webkit [50496] by Simon Hausmann

6 edits
4 adds
1 delete in trunk

WebCore: [Qt] Handle fonts like the other ports

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

https://bugs.webkit.org/show_bug.cgi?id=29856

Test: svg/text/text-font-invalid.html

WebCore.pro:
platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):

platform/graphics/qt/FontFallbackListQt.cpp:

Removed. We now use the implementation from FontFallbackList.cpp

platform/graphics/qt/FontPlatformData.h:

Add hashing capabilities to be able to use the data with the FontCache.
This was previously done in FontCacheQt.cpp
(WebCore::FontPlatformData::FontPlatformData):
Added a boolean to identify deleted value in the hash table.
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

LayoutTests: Add a new test to reproduce 29856. The bug only happen
when the SVG file is used as an image.
https://bugs.webkit.org/show_bug.cgi?id=29856

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

svg/text/text-font-invalid-expected.txt: Added.
svg/text/resources/text-font-invalid.svg: Added.
svg/text/text-font-invalid.html: Added.

7:26 PM Changeset in webkit [50495] by rolandsteiner@chromium.org

1 edit
65 adds in trunk/LayoutTests

Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support - layout tests.

New layout tests: basic rendering:

fast/ruby/ruby-empty-rt.html: Added.
fast/ruby/ruby-length.html: Added.
fast/ruby/ruby-run-break.html: Added.
fast/ruby/ruby-runs-spans.html: Added.
fast/ruby/ruby-runs.html: Added.
fast/ruby/ruby-simple-rp.html: Added.
fast/ruby/ruby-simple.html: Added.
fast/ruby/ruby-trailing.html: Added.

New layout tests: DOM manipulation within <ruby>

fast/ruby/rubyDOM-insert-rt.html: Added.
fast/ruby/rubyDOM-insert-text1.html: Added.
fast/ruby/rubyDOM-insert-text2.html: Added.
fast/ruby/rubyDOM-insert-text3.html: Added.
fast/ruby/rubyDOM-remove-rt1.html: Added.
fast/ruby/rubyDOM-remove-rt2.html: Added.
fast/ruby/rubyDOM-remove-text1.html: Added.
fast/ruby/rubyDOM-remove-text2.html: Added.

New layout tests results:

platform/mac/fast/ruby: Added.
platform/mac/fast/ruby/ruby-empty-rt-expected.checksum: Added.
platform/mac/fast/ruby/ruby-empty-rt-expected.png: Added.
platform/mac/fast/ruby/ruby-empty-rt-expected.txt: Added.
platform/mac/fast/ruby/ruby-length-expected.checksum: Added.
platform/mac/fast/ruby/ruby-length-expected.png: Added.
platform/mac/fast/ruby/ruby-length-expected.txt: Added.
platform/mac/fast/ruby/ruby-run-break-expected.checksum: Added.
platform/mac/fast/ruby/ruby-run-break-expected.png: Added.
platform/mac/fast/ruby/ruby-run-break-expected.txt: Added.
platform/mac/fast/ruby/ruby-runs-expected.checksum: Added.
platform/mac/fast/ruby/ruby-runs-expected.png: Added.
platform/mac/fast/ruby/ruby-runs-expected.txt: Added.
platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: Added.
platform/mac/fast/ruby/ruby-runs-spans-expected.png: Added.
platform/mac/fast/ruby/ruby-runs-spans-expected.txt: Added.
platform/mac/fast/ruby/ruby-simple-expected.checksum: Added.
platform/mac/fast/ruby/ruby-simple-expected.png: Added.
platform/mac/fast/ruby/ruby-simple-expected.txt: Added.
platform/mac/fast/ruby/ruby-simple-rp-expected.checksum: Added.
platform/mac/fast/ruby/ruby-simple-rp-expected.png: Added.
platform/mac/fast/ruby/ruby-simple-rp-expected.txt: Added.
platform/mac/fast/ruby/ruby-trailing-expected.checksum: Added.
platform/mac/fast/ruby/ruby-trailing-expected.png: Added.
platform/mac/fast/ruby/ruby-trailing-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.

6:18 PM Web Inspector Update.ja created by casey.hattori@gmail.com

6:09 PM Changeset in webkit [50494] by Joseph Pecoraro

1 edit
19 adds in trunk/WebKitSite

2009-11-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Adding images for an upcoming blog post.

blog-files/inspector/breakpoints.png: Added.
blog-files/inspector/colors.png: Added.
blog-files/inspector/cookies.png: Added.
blog-files/inspector/css_selectors.png: Added.
blog-files/inspector/css_syntax_highlight.png: Added.
blog-files/inspector/dom_storage.png: Added.
blog-files/inspector/edit_attributes.png: Added.
blog-files/inspector/enable.png: Added.
blog-files/inspector/event_listeners.png: Added.
blog-files/inspector/form_data.png: Added.
blog-files/inspector/inline_highlight.png: Added.
blog-files/inspector/inorder.png: Added.
blog-files/inspector/inspect_inspector.png: Added.
blog-files/inspector/inspect_inspector_small.png: Added.
blog-files/inspector/load_lines.png: Added.
blog-files/inspector/nodelist.png: Added.
blog-files/inspector/scope_bar.png: Added.
blog-files/inspector/watched_expression.png: Added.

5:34 PM Changeset in webkit [50493] by mitz@apple.com

2 edits in trunk/WebCore

Leopard build fix

platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
(WebCore::core):

5:25 PM Changeset in webkit [50492] by oliver@apple.com

6 edits
1 move in trunk/LayoutTests

2009-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Add overridePreference call to all WebGL layout tests
https://bugs.webkit.org/show_bug.cgi?id=31088

fast/canvas/webgl/array-unit-tests.html:
fast/canvas/webgl/getActiveTest.html:
fast/canvas/webgl/gl-get-calls.html:
fast/canvas/webgl/incorrect-context-object-behaviour.html:
fast/canvas/webgl/null-object-behaviour.html:
fast/canvas/webgl/resources/shader-test.js: Removed.
fast/canvas/webgl/resources/webgl-test.js: Copied from LayoutTests/fast/canvas/webgl/resources/shader-test.js.

5:11 PM Changeset in webkit [50491] by bweinstein@apple.com

2 edits in trunk/WebKit/win

WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.

Reviewed by Steve Falkenburg.

WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

5:02 PM Changeset in webkit [50490] by mitz@apple.com

2 edits in trunk/WebCore

Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
authentication in AuthenticationMac

Reviewed by Alexey Proskuryakov.

platform/network/mac/AuthenticationMac.mm:

4:00 PM Changeset in webkit [50489] by eric@webkit.org

5 edits
2 adds in trunk

2009-11-03 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Adds a test for turning on the timeline profiler. This caused
a crash because profiling was enabled in the middle of processing
an event.

https://bugs.webkit.org/show_bug.cgi?id=31080

inspector/timeline-trivial-expected.txt: Added.
inspector/timeline-trivial.html: Added.

2009-11-03 Eric Z. Ayers <zundel@google.com>

Reviewed by Timothy Hatcher.

Fixes a problem where the timeline instrumentation crashes if
timeline profiling is enabled or disabled in the middle of an
event dispatch.

https://bugs.webkit.org/show_bug.cgi?id=31080

Test: inspector/timeline-trivial.html

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::processingUserGestureEvent):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
page/DOMTimer.cpp: (WebCore::DOMTimer::fired):

3:34 PM Changeset in webkit [50488] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <eric@webkit.org>

No review, just changing wording of log message.

Change log string to say "failed" instead of "rejected"
when a commit fails due to an out of date checkout.
This makes grepping the commit-queue log for rejected patches easier.

Scripts/bugzilla-tool:

2:14 PM Changeset in webkit [50487] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <eric@webkit.org>

No review, adding commonly known committers missing from the file.

Scripts/modules/committers.py: Add committers found by looking at SVN records.

2:07 PM Changeset in webkit [50486] by mitz@apple.com

4 edits in trunk/WebCore

Allow a frame to go back to copy-on-scroll when it ceases being overlapped

Reviewed by Dave Hyatt.

The code was not testing slow-scrolling frames for overlappedness, thinking the answer
would not matter. That is not the case if the only reason for the slow-scrolling is
being overlapped.

page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
reason besides being overlapped that the frame would need to fully repaint on scroll.

page/FrameView.h:
rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().

2:04 PM Changeset in webkit [50485] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-03 Eric Seidel <eric@webkit.org>

No review, just sort-order cleanup.

Scripts/modules/committers.py: Sort committers/reviewers alphabetically.

2:04 PM Changeset in webkit [50484] by bweinstein@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to try and fix Windows nightlies.

1:39 PM Changeset in webkit [50483] by dimich@chromium.org

2 edits in trunk/WebCore

Not reviewed, Qt build fix.

Need to use right capitalization for include file.

page/Navigator.cpp:

1:34 PM Changeset in webkit [50482] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate from top bar filters to check boxes in Timeline.

https://bugs.webkit.org/show_bug.cgi?id=31081

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
inspector/front-end/inspector.css:

1:30 PM Changeset in webkit [50481] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clear overview on Clear action and panel reset.

https://bugs.webkit.org/show_bug.cgi?id=31078

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):

1:24 PM Changeset in webkit [50480] by eric@webkit.org

2 edits
9 adds in trunk/WebCore

2009-11-03 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

Imported action and rules python files that WebCore.gyp depends on.
These files used to live in chromium.org and deal mostly with auto-generation
of code by wrapping existing webkit perl scripts.

https://bugs.webkit.org/show_bug.cgi?id=31071

WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
WebCore.gyp/scripts/action_csspropertynames.py: Added.
WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
WebCore.gyp/scripts/action_makenames.py: Added.
WebCore.gyp/scripts/action_maketokenizer.py: Added.
WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
WebCore.gyp/scripts/rule_binding.py: Added.
WebCore.gyp/scripts/rule_bison.py: Added.
WebCore.gyp/scripts/rule_gperf.py: Added.

1:18 PM Changeset in webkit [50479] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

1:18 PM Changeset in webkit [50478] by mrowe@apple.com

1 copy in tags/Safari-6531.21.9

New tag.

1:12 PM Changeset in webkit [50477] by dimich@chromium.org

14 edits
4 adds in trunk

WebCore: Implement window.navigator.registerProtocolHandler in webkit,
https://bugs.webkit.org/b/29651

Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

Also implemented its sister API window.navigator.registerContentHandler.

These methods are as described in the HTML5 specification which can be
found here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler

As specified in the document, the behavior of the browser is determined
by the current registered handler. The state of a registered handler
can change at any time, with the user clearing a registered handler,
registering a different page as handler, or deferring the hander to the
OS. If webkit was to track the state of the currently registered
handlers, it would need more APIs and complexity to keep in sync with
user actions reported to webkit from the UA. For simplicity, the state
of protocol handlers should be kept isolated from webkit and webkit only
notifies the UA that a page has made the call. The UA is then
responsible for correctly handling the registerProtocolHandler call and
the redirects which result from registration.

We do however follow the specification in insuring that the reserved
schemes and mimeTypes are not passed to the UA as custom handler
registration tests. We also insure that the "%s" token is present as
required by the specification.

Updated test expectations for window.clientInformation and navigator
objects.

Tests: fast/dom/registerContentHandler.html

fast/dom/registerProtocolHandler.html

page/Chrome.cpp:

(WebCore::Chrome::registerProtocolHandler):
(WebCore::Chrome::registerContentHandler):

page/Chrome.h:
page/ChromeClient.h:

(WebCore::ChromeClient::registerProtocolHandler):
(WebCore::ChromeClient::registerContentHandler):

page/Navigator.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
(WebCore::verifyProtocolHandlerMimeType):
(WebCore::Navigator::registerContentHandler):

page/Navigator.h:
page/Navigator.idl:

LayoutTests: Updating test expectations for implementation of
window.navigator.registerProtocolHandler and
window.navigator.registerContentHandler.

Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.

There is a default implimentation for these APIs, hence all platforms
with the navigator-detached-no-crash-expect and
window-properties-expected tests needed to be updated. While
isolatedWorlds has a window-properties-expected test, it has no window
object and hence does not need to be updaetd.

We add two fast/dom tests to insure that the proper exceptions are
thrown when bad syntax or security violations are made by calling the
methods.

fast/dom/Window/window-properties-expected.txt:
fast/dom/navigator-detached-no-crash-expected.txt:
fast/dom/navigator-detached-no-crash.html:
fast/dom/registerContentHandler-expected.txt: Added.
fast/dom/registerContentHandler.html: Added.
fast/dom/registerProtocolHandler-expected.txt: Added.
fast/dom/registerProtocolHandler.html: Added.
platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:

1:06 PM Changeset in webkit [50476] by beidson@apple.com

8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h

Reviewed by Darin Adler.

No new tests. (No change in functionality)

dom/Document.cpp:

(WebCore::Document::inspectorTimelineAgent): Moved from Document.h

dom/Document.h:

Include "Page.h" directly:

html/HTMLVideoElement.cpp:
loader/RedirectScheduler.cpp:
page/History.cpp:
rendering/MediaControlElements.cpp:
storage/StorageAreaImpl.cpp:

12:59 PM Changeset in webkit [50475] by senorblanco@chromium.org

2 edits in trunk/WebKitTools

(Unreviewed).

Add myself to committers.py.

Scripts/modules/committers.py:

12:56 PM Changeset in webkit [50474] by mrowe@apple.com

6 edits in branches/safari-4-branch

Merge r50443.

12:04 PM Changeset in webkit [50473] by kevino@webkit.org

1 edit
8 adds in trunk/WebKitTools

Reviewed by Kevin Ollviier.

Add packaging scripts for Debian-based Linux distros.

https://bugs.webkit.org/show_bug.cgi?id=31075

11:38 AM Changeset in webkit [50472] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-03 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: hover over JS "things" in source and see their values
https://bugs.webkit.org/show_bug.cgi?id=30913

inspector/front-end/SourceFrame.js:

11:24 AM Changeset in webkit [50471] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: update timeline content boundaries on timer.

https://bugs.webkit.org/show_bug.cgi?id=31072

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._setWindowPosition):

11:07 AM Changeset in webkit [50470] by mitz@apple.com

10 edits
4 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=31070
Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

Tests: plugins/attach-during-destroy.html

plugins/destroy-reentry.html

These crashes were caused by plug-in code running during detach(),
causing re-entry into RenderWidget::destroy() in one case and a call
into attach() in the other. The fix is to prevent plug-in code from
being called at certain unsafe times (during attach(), detach(), and
recalcStyle()) by deferring changes to the widget hierarchy.

dom/Document.cpp:

(WebCore::Document::recalcStyle): Suspend widget hierarchy updates

during style recalculation.

dom/Element.cpp:

(WebCore::Element::attach): Suspend widget hierarchy updates during

attach().

(WebCore::Element::detach): Suspend widget hierarchy updates during

detach().

rendering/RenderWidget.cpp:

(WebCore::widgetNewParentMap): Returns a static map of pending changes

to the widget hierarchy.

(WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the

suspend count.

(WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the

suspend count. If the count is going to be zero, updates the widget
hierarchy by executing the pending changes stored in the map.

(WebCore::moveWidgetToParentSoon): Updates the widget hierarchy

immediately or makes or updates an entry in the map, depending on
whether updates are suspended.

(WebCore::RenderWidget::destroy): Removed earlier bandaid fix for

<rdar://problem/6937089>.

(WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates

are not suspended, because this function updates the widget’s
bounds, which can result in arbitrary native and JavaScript code
execution. I think this assertion is true thanks to some deferred-
update mechanisms that have already been deployed in other places
in the code.

(WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead

of changing the widget hierarchy directly.

rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()

and resumeWidgetHierarchyUpdates().

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=31070

Reviewed by Anders Carlsson and Beth Dakin.

Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
destroyed, it executes the value of the 'ondestroy' parameter as a
script.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginAllocate): Initialize onDestroy.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define

onDestroy.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
specified.
(NPP_Destroy): Execute the value of 'ondestroy' as a script.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=31070
Test for <rdar://problem/7194735> Crashes at RenderText::RenderText()
Test for <rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Anders Carlsson and Beth Dakin.

plugins/attach-during-destroy-expected.txt: Added.
plugins/attach-during-destroy.html: Added.
plugins/destroy-reentry-expected.txt: Added.
plugins/destroy-reentry.html: Added.

11:06 AM Changeset in webkit [50469] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: only show timeline records that contribute
to the current window.

https://bugs.webkit.org/show_bug.cgi?id=31069

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.refresh):

10:45 AM Changeset in webkit [50468] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-03 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Watch expression editor should stay open after Add button was clicked
https://bugs.webkit.org/show_bug.cgi?id=31049

No new tests, was a regression, use existing manual test.

inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression):

10:37 AM Changeset in webkit [50467] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-03 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

A test that reproduces a hard-to-trigger memory corruption in the
CSS lexer.

https://bugs.webkit.org/show_bug.cgi?id=30827

fast/css/end-of-buffer-crash.html: Added.

2009-11-03 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Fix an off-by-one in the CSS lexer that causes memory corruption in
hard-to-trigger circumstances.

https://bugs.webkit.org/show_bug.cgi?id=30827

Test: fast/css/end-of-buffer-crash.html

css/maketokenizer: Add comments, fix off-by-one.

10:23 AM Changeset in webkit [50466] by Darin Adler

4 edits
2 adds in trunk

Crash due to double-destroy related to CSS run-in property
https://bugs.webkit.org/show_bug.cgi?id=31034
rdar://problem/7328458

Patch by Darin Adler <Darin Adler> on 2009-11-02
Reviewed by Dan Bernstein.

WebCore:

Test: fast/css/run-in-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy): Reorder destruction so the
continuation is destroyed after anonymous children. See comment
in the code for more details of why this is right.

rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy): Ditto.

LayoutTests:

fast/css/run-in-crash-expected.txt: Added.
fast/css/run-in-crash.html: Added.

10:22 AM Changeset in webkit [50465] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix exception in ElementsPanel.js when moving pointer out of crumbs and window

There might be no new node under mouse if the pointer is moved out of the window
in which case we get an exception.
https://bugs.webkit.org/show_bug.cgi?id=31061

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):

10:09 AM Changeset in webkit [50464] by zoltan@webkit.org

7 edits in trunk/WebCore

Allow custom memory allocation control for the dom directory of WebCore
https://bugs.webkit.org/show_bug.cgi?id=31053

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are
instantiated by 'new' and these are no need to be copyable:

class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51
struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552

Inherits QualifiedName class from FastAllocBase because it is
instantiated by 'new' in WebCore/editing/markup.cpp:319

dom/Document.cpp:
dom/EventNames.h:
dom/EventTarget.h:
dom/MessagePortChannel.h:
dom/NodeRareData.h:
dom/QualifiedName.h:

9:59 AM Changeset in webkit [50463] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement timeline summary panel.

https://bugs.webkit.org/show_bug.cgi?id=31064

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineGraph.prototype.refresh):
inspector/front-end/inspector.css:

9:56 AM Changeset in webkit [50462] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Toggle off 'Search for node' when the Inspector window is closing

Searching for node should be toggled off when the Inspector window is closed,
in a platform-independent manner.
https://bugs.webkit.org/show_bug.cgi?id=31059

inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):

9:49 AM Changeset in webkit [50461] by Nate Chapin

1 edit
2 deletes in trunk/LayoutTests

2009-11-03 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

"http://trac.webkit.org/changeset/50315" makes links mouse
focusable only on GTK and QT, so win has same behavior as mac now
Remove the win specific expected results for tests failed
due to the patch.

https://bugs.webkit.org/show_bug.cgi?id=30968

platform/win/fast/events/click-focus-anchor-expected.txt: Removed.
platform/win/fast/inline: Removed.
platform/win/fast/inline/dirtyLinesForInline-expected.txt: Removed.

9:47 AM Changeset in webkit [50460] by eric@webkit.org

5 edits in trunk/WebCore

2009-11-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Prepare for heap profiles upstreaming:

pass profile type id from InspectorController;
this makes WebInspector.CPUProfile redundant---removed;
support multiple profile types when populating profiles.

https://bugs.webkit.org/show_bug.cgi?id=31052

inspector/InspectorController.cpp: (WebCore::InspectorController::createProfileHeader):
inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData):
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
inspector/front-end/inspector.js: (WebInspector.addProfileHeader):

9:26 AM Changeset in webkit [50459] by darin@chromium.org

2 edits in trunk/WebCore

2009-11-03 Dan Kegel <dank@chromium.org>

Reviewed by Dimitri Glazkov.

UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
https://bugs.webkit.org/show_bug.cgi?id=31063

accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

9:06 AM Changeset in webkit [50458] by pfeldman@chromium.org

6 edits in trunk/WebCore

2009-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement Timeline Window, wire it to the bottom timeline.

https://bugs.webkit.org/show_bug.cgi?id=31056

English.lproj/localizedStrings.js:
inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.get items): (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider): (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addExtraDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.get _resources):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._resizeWindow): (WebInspector.TimelinePanel.prototype._windowResizeDragging): (WebInspector.TimelinePanel.prototype._dragWindow): (WebInspector.TimelinePanel.prototype._windowDragging): (WebInspector.TimelinePanel.prototype._resizeWindowLeft): (WebInspector.TimelinePanel.prototype._resizeWindowRight): (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelinePanel.prototype._endWindowDragging): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue):
inspector/front-end/inspector.css:

8:13 AM Changeset in webkit [50457] by Simon Hausmann

2 edits in trunk/WebKit/qt

[Qt] Fix build of unit-test after r50454.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-03
Reviewed by Simon Hausmann.

tests/qwebpage/tst_qwebpage.cpp:

7:54 AM Changeset in webkit [50456] by Simon Hausmann

9 edits
1 move in trunk

Make QWebPluginDatabase private API for now.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=30775

WebCore:

WebCore.pro:

WebKit/qt:

Api/headers.pri:
Api/qwebplugindatabase.cpp:
Api/qwebplugindatabase_p.h: Renamed from WebKit/qt/Api/qwebplugindatabase.h.
Api/qwebsettings.cpp:
Api/qwebsettings.h:
QtLauncher/main.cpp:

(MainWindow::setupUI):

tests/tests.pro:

7:06 AM Changeset in webkit [50455] by Simon Hausmann

2 edits in trunk/WebKit/qt

Rubber-stamped by Tor Arne Vestbø.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Oops, also remove the API docs of the removed networkRequestStarted() signal.

Api/qwebpage.cpp:

6:50 AM Changeset in webkit [50454] by Simon Hausmann

8 edits in trunk

WebCore: Extended the conversion of the WebCore ResourceRequest to the
QNetworkRequest with a mandatory originating object argument,
which is meant to be the QWebFrame the request belongs to.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29975

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):

platform/network/qt/ResourceRequest.h:
platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

WebKit/qt: Replace the QWebPage::networkRequestStarted() signal with the originatingObject
property set to the QWebFrame that belongs to the request.

Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29975

Api/qwebpage.h:
WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadFinished):
(TestNetworkManager::createRequest):
(tst_QWebPage::originatingObjectInNetworkRequests):

6:48 AM Changeset in webkit [50453] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-03 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: monitorEvent should be monitorEvents
https://bugs.webkit.org/show_bug.cgi?id=31042

inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):

5:04 AM Changeset in webkit [50452] by vestbo@webkit.org

1 edit in trunk/WebCore/plugins/PluginDatabase.cpp

[Qt] Windows CE build fix

4:32 AM Changeset in webkit [50451] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Add files to skiplist depend on phonon support,
which is disabled on the Qt buildbot for now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03

platform/qt/Skipped:

4:12 AM Changeset in webkit [50450] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03
Remove now passing tests from skiplist.

platform/qt/Skipped:

3:56 AM Changeset in webkit [50449] by vestbo@webkit.org

2 edits in trunk/WebCore

[Qt] Build fix for Windows CE

Rubber-stamped by Antti Koivisto.

plugins/PluginDatabase.cpp:

3:50 AM Changeset in webkit [50448] by vestbo@webkit.org

1 edit in trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.pro

[Qt] Build fix for Mac OS X when building as framework

WTFReportAssertionFailure is not exported, so building DRT in debug
mode against QtWebKit built as a framework failes to link.

2:40 AM Changeset in webkit [50447] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Put test into skiplist added in r50411 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03

platform/qt/Skipped: inspector/css-syntax-highlight.html added

2:00 AM Changeset in webkit [50446] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Chris Fleizach <Chris Fleizach>

Reviewed by David Levin.

fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672

accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::platformGenerateAXID): (WebCore::AXObjectCache::removeAXID):
accessibility/AXObjectCache.h: (WebCore::AXObjectCache::enableAccessibility): (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility): (WebCore::AXObjectCache::accessibilityEnabled): (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled): (WebCore::AXObjectCache::isIDinUse): (WebCore::AXObjectCache::objectFromAXID): (WebCore::AXObjectCache::): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
accessibility/AccessibilityAllInOne.cpp:
accessibility/AccessibilityImageMapLink.cpp:
accessibility/AccessibilityList.h: (WebCore::AccessibilityList::isList):
accessibility/AccessibilityListBox.cpp:
accessibility/AccessibilityListBox.h: (WebCore::AccessibilityListBox::isListBox):
accessibility/AccessibilityListBoxOption.cpp:
accessibility/AccessibilityListBoxOption.h: (WebCore::AccessibilityListBoxOption::isListBoxOption):
accessibility/AccessibilityMediaControls.h: (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl): (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline): (WebCore::AccessibilityMediaTimeline::isMediaTimeline): (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer): (WebCore::AccessibilityMediaControlsContainer::roleValue): (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored): (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay): (WebCore::AccessibilityMediaTimeDisplay::roleValue):
accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::parentObjectUnignored): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::replacedNodeNeedsCharacter): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::actionVerb):
accessibility/AccessibilityObject.h: (WebCore::PlainTextRange::isNull): (WebCore::AccessibilityObject::isAccessibilityRenderObject): (WebCore::AccessibilityObject::isAnchor): (WebCore::AccessibilityObject::isAttachment): (WebCore::AccessibilityObject::isHeading): (WebCore::AccessibilityObject::isLink): (WebCore::AccessibilityObject::isImage): (WebCore::AccessibilityObject::isNativeImage): (WebCore::AccessibilityObject::isImageButton): (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::isTextControl): (WebCore::AccessibilityObject::isNativeTextControl): (WebCore::AccessibilityObject::isWebArea): (WebCore::AccessibilityObject::isCheckboxOrRadio): (WebCore::AccessibilityObject::isListBox): (WebCore::AccessibilityObject::isFileUploadButton): (WebCore::AccessibilityObject::isProgressIndicator): (WebCore::AccessibilityObject::isSlider): (WebCore::AccessibilityObject::isControl): (WebCore::AccessibilityObject::isList): (WebCore::AccessibilityObject::isDataTable): (WebCore::AccessibilityObject::isTableRow): (WebCore::AccessibilityObject::isTableColumn): (WebCore::AccessibilityObject::isTableCell): (WebCore::AccessibilityObject::isFieldset): (WebCore::AccessibilityObject::isGroup): (WebCore::AccessibilityObject::isChecked): (WebCore::AccessibilityObject::isEnabled): (WebCore::AccessibilityObject::isSelected): (WebCore::AccessibilityObject::isFocused): (WebCore::AccessibilityObject::isHovered): (WebCore::AccessibilityObject::isIndeterminate): (WebCore::AccessibilityObject::isLoaded): (WebCore::AccessibilityObject::isMultiSelect): (WebCore::AccessibilityObject::isOffScreen): (WebCore::AccessibilityObject::isPressed): (WebCore::AccessibilityObject::isReadOnly): (WebCore::AccessibilityObject::isVisited): (WebCore::AccessibilityObject::isRequired): (WebCore::AccessibilityObject::canSetFocusAttribute): (WebCore::AccessibilityObject::canSetTextRangeAttributes): (WebCore::AccessibilityObject::canSetValueAttribute): (WebCore::AccessibilityObject::hasIntValue): (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId): (WebCore::AccessibilityObject::accessibilityIsIgnored):
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObjectIfExists): (WebCore::AccessibilityRenderObject::parentObject): (WebCore::AccessibilityRenderObject::isMenuRelated): (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::doAXRangeForLine): (WebCore::AccessibilityRenderObject::doAXStringForRange): (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityRenderObject::canSetFocusAttribute): (WebCore::AccessibilityRenderObject::canHaveChildren): (WebCore::AccessibilityRenderObject::actionVerb): (WebCore::shouldReturnTagNameAsRoleForMSAA):
accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
accessibility/AccessibilitySlider.h: (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
accessibility/AccessibilityTableColumn.cpp:
accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren):
accessibility/AccessibilityTableRow.cpp:
accessibility/mac/AccessibilityObjectWrapper.h:

1:44 AM CommitterTips edited by Csaba Osztrogonác

(diff)

12:52 AM CommitterTips edited by eric@webkit.org

(diff)

12:50 AM CommitterTips created by eric@webkit.org

12:27 AM WikiStart edited by eric@webkit.org

(diff)

Nov 2, 2009:

11:51 PM Changeset in webkit [50445] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds

Get the correct Gtk+ object before attempting to turn it into an AtkObject.

DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::rootElement):

11:01 PM Changeset in webkit [50444] by Chris Fleizach

23 edits in trunk/WebCore

fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672

Reviewed by David Levin.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::platformGenerateAXID):
(WebCore::AXObjectCache::removeAXID):

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::isIDinUse):
(WebCore::AXObjectCache::objectFromAXID):
(WebCore::AXObjectCache::):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

accessibility/AccessibilityAllInOne.cpp:
accessibility/AccessibilityImageMapLink.cpp:
accessibility/AccessibilityList.h:

(WebCore::AccessibilityList::isList):

accessibility/AccessibilityListBox.cpp:
accessibility/AccessibilityListBox.h:

(WebCore::AccessibilityListBox::isListBox):

accessibility/AccessibilityListBoxOption.cpp:
accessibility/AccessibilityListBoxOption.h:

(WebCore::AccessibilityListBoxOption::isListBoxOption):

accessibility/AccessibilityMediaControls.h:

(WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
(WebCore::AccessibilityMediaTimeline::isMediaTimeline):
(WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
(WebCore::AccessibilityMediaControlsContainer::roleValue):
(WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
(WebCore::AccessibilityMediaTimeDisplay::roleValue):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::rightLineVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):
(WebCore::AccessibilityObject::actionVerb):

accessibility/AccessibilityObject.h:

(WebCore::PlainTextRange::isNull):
(WebCore::AccessibilityObject::isAccessibilityRenderObject):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::isLink):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isNativeImage):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isNativeTextControl):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
(WebCore::AccessibilityObject::isListBox):
(WebCore::AccessibilityObject::isFileUploadButton):
(WebCore::AccessibilityObject::isProgressIndicator):
(WebCore::AccessibilityObject::isSlider):
(WebCore::AccessibilityObject::isControl):
(WebCore::AccessibilityObject::isList):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
(WebCore::AccessibilityObject::isFieldset):
(WebCore::AccessibilityObject::isGroup):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::isSelected):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::isHovered):
(WebCore::AccessibilityObject::isIndeterminate):
(WebCore::AccessibilityObject::isLoaded):
(WebCore::AccessibilityObject::isMultiSelect):
(WebCore::AccessibilityObject::isOffScreen):
(WebCore::AccessibilityObject::isPressed):
(WebCore::AccessibilityObject::isReadOnly):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isRequired):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXRangeForLine):
(WebCore::AccessibilityRenderObject::doAXStringForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::actionVerb):
(WebCore::shouldReturnTagNameAsRoleForMSAA):

accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):

accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation):

accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::~AccessibilitySlider):
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
(WebCore::AccessibilitySlider::isSlider):
(WebCore::AccessibilitySlider::canSetValueAttribute):
(WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::setParentObject):
(WebCore::AccessibilitySliderThumb::parentObject):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

accessibility/AccessibilityTableColumn.cpp:
accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

accessibility/AccessibilityTableRow.cpp:
accessibility/mac/AccessibilityObjectWrapper.h:

10:49 PM Changeset in webkit [50443] by oliver@apple.com

6 edits in trunk

REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
https://bugs.webkit.org/show_bug.cgi?id=31045

Reviewed by Gavin Barraclough.

Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain. Also add a few tighter assertions to cached prototype lookups
to catch this in future.

9:51 PM Changeset in webkit [50442] by darin@chromium.org

2 edits in trunk/WebCore

2009-11-02 Darin Fisher <darin@chromium.org>

Fixing JSC build bustage.

bindings/js/ScriptController.cpp: Added missing #include

9:47 PM Changeset in webkit [50441] by darin@chromium.org

7 edits in trunk/WebCore

2009-10-30 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
https://bugs.webkit.org/show_bug.cgi?id=30967

bindings/js/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
bindings/v8/V8Proxy.h: Ditto
loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowJavaScript):
platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function

8:40 PM Changeset in webkit [50440] by beidson@apple.com

2 edits in trunk/WebCore

Rubberstamped by Mark Rowe.

Fix a typo in Mark's last commit.

loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

8:00 PM Changeset in webkit [50439] by mrowe@apple.com

2 edits in trunk/WebCore

Re-enable support for web archives on Windows. It was mistakenly disabled in r50438.

Rubber-stamped by Brady Eidson.

loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

7:24 PM Changeset in webkit [50438] by eric@webkit.org

10 edits in trunk

2009-11-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

wtf/Platform.h: Turn on CF support if both QT and DARWIN platforms are defined.

2009-11-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp to the Darwin build.
loader/archive/ArchiveFactory.cpp: Change the support for legacy WebArchive from all CF platforms to Mac and Chromium CF platforms. (WebCore::archiveMIMETypes):
platform/text/AtomicString.h: Remove PLATFORM(QT) && PLATFORM(DARWIN) test as it is redundant now.
platform/text/PlatformString.h: Ditto.
platform/text/StringImpl.h: Ditto.
platform/text/cf/StringCF.cpp: Ditto.
platform/text/cf/StringImplCF.cpp: Ditto.

6:35 PM Changeset in webkit [50437] by eric@webkit.org

5 edits
1 add in trunk/WebCore

2009-11-02 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
https://bugs.webkit.org/show_bug.cgi?id=30985

Our current code does not conform to our style guide.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/chromium/MIMETypeRegistryChromium.cpp:
plugins/chromium/PluginDataChromium.cpp:
plugins/chromium/PluginDataChromium.h: Added.

6:07 PM Changeset in webkit [50436] by adele@apple.com

3 edits in trunk/WebCore

Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)

Reviewed by Darin Adler.

This bug is timing dependent, and not always reproducible. I could not think of a way to add a
layout test that would demonstrate the problem and fix.

platform/mac/ThemeMac.mm:

(WebCore::checkbox): Update style.
(WebCore::paintCheckbox): ditto.
(WebCore::radio): ditto.
(WebCore::paintRadio): ditto.
(WebCore::setupButtonCell): Added convenience method.
(WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
(WebCore::paintButton): Don't check for the key window here. Consider that when deciding if the button should have the default style in RenderTheme.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active. This fixes

a problem I noticed where the button would flicker crazily if the page with the default button was in the background.

5:44 PM Changeset in webkit [50435] by mitz@apple.com

3 edits in trunk/WebCore

Minor RenderWidget clean-up in preparation for deferring widget tree
mutation when it is not safe.

Reviewed by Anders Carlsson.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
instead of calling ref().
(WebCore::RenderWidget::destroy): Call setWidget(0) instead of
repeating what it does.
(WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
indicating whether the bounds have changed.
(WebCore::RenderWidget::setWidget): Replaced all-encompassing if
statement with an early return.
(WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().

rendering/RenderWidget.h:

5:39 PM QtBackLog edited by zecke@selfish.org

Mention #31009 (diff)

5:38 PM Changeset in webkit [50434] by dumi@chromium.org

1 edit
6 adds in trunk/WebCore

Adding Chromium's DatabaseTracker and SQLTransactionClient
implementations.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-11-02
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30701

storage/chromium: Added.
storage/chromium/DatabaseObserver.h: Added.
storage/chromium/DatabaseTrackerChromium.cpp: Added.
storage/chromium/QuotaTracker.cpp: Added.
storage/chromium/QuotaTracker.h: Added.
storage/chromium/SQLTransactionClientChromium.cpp: Added.

5:06 PM Changeset in webkit [50433] by enrica@apple.com

4 edits
2 adds in trunk

Safari crashes when calling execCommand on formatted html in special case
<rdar://problem/7318656>
https://bugs.webkit.org/show_bug.cgi?id=31023

Reviewed by Adele Peterson and Dan Bernstein.

WebCore:

Test: editing/execCommand/align-in-span.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.

rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
since it is possible when dealing with orphaned trees.

LayoutTests:

editing/execCommand/align-in-span-expected.txt: Added.
editing/execCommand/align-in-span.html: Added.

4:04 PM Changeset in webkit [50432] by cmarrin@apple.com

8 edits in trunk

Exception checks were being too aggressive
https://bugs.webkit.org/show_bug.cgi?id=31005

Several calls in CanvasRenderingContext3D are allowed to
have a null value passed, which indicated that the
object is being unbound. Handle this case and the corresponding
null handling in GraphicsContext3DMac.

2:53 PM Changeset in webkit [50431] by eric@webkit.org

2 edits
1 add in trunk/WebCore

2009-11-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Each JS execution in console adds extra item into "scripts" combo
https://bugs.webkit.org/show_bug.cgi?id=30212

Added manual test

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
manual-tests/inspector/hidden-evals.html: Added.

2:26 PM Changeset in webkit [50430] by eric@webkit.org

2 edits in trunk

2009-11-02 Estêvão Samuel Procópio <tevaum@gmail.com>

Reviewed by Gustavo Noronha.

[Build] make install ignores --prefix option for gobject-introspection.
https://bugs.webkit.org/show_bug.cgi?id=31025

Make the build system use the --prefix path also when installing
gobject-introspection files.

configure.ac: use --prefix path in GITDIR and GIRTYPELIBDIR

2:03 PM Changeset in webkit [50429] by eric.carlson@apple.com

6 edits in trunk/WebKit

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

Fix localized strings for media controller time values.

English.lproj/Localizable.strings:

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaTimeDescription:]):

2009-11-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan and Mark Rowe.

<rdar://problem/7356733> Voiceover does not read correct media controller time values

WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):

2:02 PM Changeset in webkit [50428] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
https://bugs.webkit.org/show_bug.cgi?id=31030

dom/Node.cpp: (WebCore::eventHasListeners): Checks DOMWindow for listeners. (WebCore::Node::dispatchGenericEvent):

1:31 PM Changeset in webkit [50427] by dimich@chromium.org

29 edits in trunk

Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
https://bugs.webkit.org/show_bug.cgi?id=30612

Reviewed by David Levin.

JavaScriptCore:

wtf/MessageQueue.h:

(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.

wtf/Threading.cpp:

(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for https://bugs.webkit.org/show_bug.cgi?id=30890

WebCore:

No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.

There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
OwnPtr and PassOwnPtr when dealing with Tasks.

ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
threadsafe refcounted, but simply Noncopyable.

dom/Document.cpp:

(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):

dom/Document.h:
dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::create):

dom/ScriptExecutionContext.h:
dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):

dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):

loader/FrameLoader.cpp:

(WebCore::HashChangeEventTask::create):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::create):

storage/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::tableNames):

storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):

storage/DatabaseThread.h:
storage/LocalStorageTask.h:

(WebCore::LocalStorageTask::createImport):
(WebCore::LocalStorageTask::createSync):
(WebCore::LocalStorageTask::createTerminate):

storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::localStorageThread):

storage/LocalStorageThread.h:
websockets/WebSocket.cpp:

(WebCore::ProcessWebSocketEventTask::create):

workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
(WebCore::SharedWorkerConnectTask::create):

workers/GenericWorkerTask.h:

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask8::create):
(WebCore::createCallbackTask):

workers/WorkerContext.cpp:

(WebCore::WorkerContext::postTask):

workers/WorkerContext.h:
workers/WorkerLoaderProxy.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::workerThreadCreated):

workers/WorkerMessagingProxy.h:
workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):

workers/WorkerRunLoop.h:

(WebCore::WorkerRunLoop::Task::~Task):
(WebCore::WorkerRunLoop::Task::mode):

1:14 PM Changeset in webkit [50426] by mitz@apple.com

3 edits in trunk/WebKit/mac

Made the remaining time display show negative zero at the end of the
video.

Reviewed by Anders Carlsson.

Made other cleanup.

WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of

_timeline and _volumeSlider to the more generic NSControl.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.

12:14 PM Changeset in webkit [50425] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589

platform/gtk/Skipped: Unskip fixed test.

11:34 AM Changeset in webkit [50424] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589

new m_seekTime attribute to keep track of the seek position

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

11:25 AM Changeset in webkit [50423] by xan@webkit.org

2 edits in trunk/WebCore

2009-11-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] Remove Referer when redirecting to non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31021

Remove referer from HTTP headers when redirecting to a non-secure
site.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

11:10 AM Changeset in webkit [50422] by xan@webkit.org

2 edits in trunk

2009-11-02 Xan Lopez <xlopez@igalia.com>

Bump version before release (or post-release, depending on your
point of view) so that we can make applications depending on
unreleased APIs in WebKit svn fail at configure time when the
requirements are not met.

configure.ac:

11:00 AM Changeset in webkit [50421] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=18539
multipart/form-data not being parsed correctly on server due to '+' in boundary string

No test - the characters that the boundary is made of are not deterministic.

platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as they cause problems on many web sites.

10:52 AM Changeset in webkit [50420] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-11-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.

Also fix call to logResult() as parameters were reversed, resulting in
printing an error message of "false".

https://bugs.webkit.org/show_bug.cgi?id=31017

media/video-currentTime-set.html: Timeout increased to 2000ms.

10:41 AM Changeset in webkit [50419] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30969
A no-prefix XPath node test should not match no-namespace elements in HTML document

Test: fast/xpath/null-namespace-in-html.html

xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements in HTML documents (as these are the ones that can have null namespace).

10:32 AM Changeset in webkit [50418] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] No timeline marks on resources panel.

https://bugs.webkit.org/show_bug.cgi?id=31013

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):

10:26 AM Changeset in webkit [50417] by levin@chromium.org

2 edits in trunk/WebCore

Possible crash in RenderSlider::layout.
https://bugs.webkit.org/show_bug.cgi?id=31016

Patch by David Levin <levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.

Fix out of place line of code.

Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.

rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

10:17 AM Changeset in webkit [50416] by eric@webkit.org

4 edits in trunk/WebCore

2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix Qt build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=30905

WebCore.pro:
platform/graphics/BitmapImage.h:
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::create):

10:09 AM Changeset in webkit [50415] by eric@webkit.org

5 edits
4 adds in trunk

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

https://bugs.webkit.org/show_bug.cgi?id=29425

loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):

2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Adam Barth.

QWebView crash fix.

The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.

A null pointer protection was added in the ProgressTracker::incrementProgress.

New autotest was created.

https://bugs.webkit.org/show_bug.cgi?id=29425

tests/qwebview/tst_qwebview.cpp: (WebViewCrashTest::WebViewCrashTest): (WebViewCrashTest::loading): (tst_QWebView::crashTests):

10:01 AM Changeset in webkit [50414] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix a leftover from profiles panel generalization.

https://bugs.webkit.org/show_bug.cgi?id=31010

inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get searchableViews):

9:53 AM Changeset in webkit [50413] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Kai Koehne <kai.koehne@nokia.com>

Reviewed by Holger Freyther.

Remove implementation of ImageDecocerQt::clearFrameBufferCache.
The implementation was buggy, and will visually break repeating
animations anyway.

https://bugs.webkit.org/show_bug.cgi?id=31009

platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::clearFrameBufferCache):

9:35 AM Changeset in webkit [50412] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Provides access to the reported content language.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_document_get_locale):

9:27 AM Changeset in webkit [50411] by eric@webkit.org

6 edits
2 adds in trunk

2009-11-02 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907

inspector/css-syntax-highlight-expected.txt: Added.
inspector/css-syntax-highlight.html: Added.
inspector/javascript-syntax-highlight-expected.txt:

2009-11-02 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907

Test: inspector/css-syntax-highlight.html

inspector/front-end/ElementsTreeOutline.js:
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightCSS): (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter):
inspector/front-end/inspectorSyntaxHighlight.css:

9:03 AM Changeset in webkit [50410] by mitz@apple.com

7 edits in trunk

WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary

#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.

WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import

statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.

WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.

Reviewed by John Sullivan.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

8:57 AM Changeset in webkit [50409] by Chris Fleizach

21 edits
4 adds in trunk

Support ARIA "tab" roles
https://bugs.webkit.org/show_bug.cgi?id=30842

Reviewed by Beth Dakin.

WebCore:

Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.

Tests: accessibility/aria-controls-with-tabs.html

accessibility/aria-tab-roles.html

accessibility/AXObjectCache.cpp:
accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:
accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:
html/HTMLAttributeNames.in:

WebKit:

Add a localizable string for tab panel.

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt:

WebKit/mac:

WebCoreSupport/WebViewFactory.mm:

(-[WebViewFactory AXARIAContentGroupText:]):

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:
DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
DumpRenderTree/mac/AccessibilityUIElementMac.mm:
DumpRenderTree/win/AccessibilityUIElementWin.cpp:

LayoutTests:

accessibility/aria-controls-with-tabs-expected.txt: Added.
accessibility/aria-controls-with-tabs.html: Added.
accessibility/aria-tab-roles.html: Added.
platform/gtk/Skipped:
platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
platform/win/Skipped:

7:27 AM Changeset in webkit [50408] by senorblanco@chromium.org

2 edits in trunk/WebCore

This is the WebKit-side change needed to fix canvas.getImageData() for
Chromium. The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not. In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test. This change brings Chromium in line with
the CG path.
https://bugs.webkit.org/show_bug.cgi?id=30825

Reviewed by Dmitry Titov.

Covered by LayoutTests/fast/canvas/canvas-getImageData.html

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

4:36 AM BuildingQtOnOSX edited by vestbo@webkit.org

(diff)

1:37 AM Changeset in webkit [50407] by pfeldman@chromium.org

10 edits in trunk/WebCore

2009-11-01 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds window event dispatches to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31002

English.lproj/localizedStrings.js:
dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent. (WebCore::Node::dispatchGenericEvent):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed. (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):

1:25 AM Surfin' Safari Translations edited by casey.hattori@gmail.com

(diff)

1:25 AM Changeset in webkit [50406] by pfeldman@chromium.org

10 edits in trunk/WebCore

2009-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Convert script tag event into a more generic
script eval event in timeline.

https://bugs.webkit.org/show_bug.cgi?id=30999

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript):
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):

1:22 AM Surfin' Safari Translations created by casey.hattori@gmail.com

Nov 1, 2009:

10:36 PM newpage edited by casey.hattori@gmail.com

(diff)

10:34 PM newpage created by casey.hattori@gmail.com

10:21 PM Changeset in webkit [50405] by bweinstein@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Mark Rowe.

Fix for loop to use an size_t instead of unsigned and some spacing
style fixes.

dom/Node.cpp:

(WebCore::eventHasListeners):

10:07 PM QtBackLog edited by zecke@selfish.org

(diff)

10:03 PM Changeset in webkit [50404] by bweinstein@apple.com

1 edit in trunk/WebCore/dom/Node.cpp

Re-fix the Mac build. Sorry :-(.

9:57 PM Changeset in webkit [50403] by bweinstein@apple.com

1 edit in trunk/WebCore/dom/Node.cpp

Change ssize_t to unsigned to try and fix Windows build.

7:53 PM Changeset in webkit [50402] by mitz@apple.com

2 edits in trunk/WebKit/mac

Made the space bar toggle playing state in full-screen video when
modifier keys are down. Made it do so without highlighting the
Play/Pause button.

Reviewed by Mark Rowe.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]):

7:30 PM Changeset in webkit [50401] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-11-01 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

buildbots should use --exit-after-N-failures
https://bugs.webkit.org/show_bug.cgi?id=30809

Make the bots exit after 20 failures to prevent never-ending
test runs where every test spends a minute crashing.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

7:23 PM Changeset in webkit [50400] by eric@webkit.org

3 edits in trunk/WebCore

2009-11-01 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Does not send DOM dispatches to the InspectorTimelineAgent if there
are no event listeners.
https://bugs.webkit.org/show_bug.cgi?id=30995

dom/Node.cpp: (WebCore::eventHasListeners): (WebCore::Node::dispatchGenericEvent):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):

7:14 PM Changeset in webkit [50399] by mitz@apple.com

2 edits in trunk/WebKit/mac

Made the full-screen video HUD respond to the up and down arrow keys by
increasing and decreasing the volume by 1/10 of the range or, when
combined with the Option key, all the way up or down.

Reviewed by Mark Rowe.

Made the volume buttons in the full-screen video HUD match the behavior
of their equivalents in the QuickTime Player HUD by turning the volume
all the way up or down.

Made the volume slider update immediately when the keyboard or volume
buttons are used to change the volume, rather than at the nearest 1/4
second interval.

Made the elapsed and remaining time displays update immediately when the
play head is dragged across the timeline, rather than at 1/4 second
intervals.

WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController keyDown:]): Handle the up and
down arrow keys.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
actions of the volume up and volume down buttons.
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]): Call
-updateTime.
(-[WebVideoFullscreenHUDWindowController setVolumeToZero:]): Added this
action for the volume down button.
(-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]): Added
this action for the volume up button.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): No longer
and action method.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Call
-updateVolume.

6:50 PM Changeset in webkit [50398] by rolandsteiner@chromium.org

2 edits in trunk/WebCore

No review (build fix).

Add missing files for Ruby implementation to WebCore.vcproj
(Fix build break after 50397)
https://bugs.webkit.org/show_bug.cgi?id=31001

No new tests. (No functional change)

WebCore.vcproj/WebCore.vcproj:

5:52 PM Changeset in webkit [50397] by rolandsteiner@chromium.org

12 edits
8 adds in trunk

Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support.

WebCore:

Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
bases with their respective ruby texts looks as follows:

1 RenderRuby object, corresponding to the whole <ruby> HTML element

1+ RenderRubyRun (anonymous)

0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting

0-n inline object(s)

0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base

1-n inline object(s)

Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.

New layout tests will be committed in a follow-up patch under fast/ruby.

Makefiles, etc.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:

CSS

css/html.css: Added <ruby> and <rt>

Existing render files:

rendering/RenderBlock.cpp: make moveChild a member function moveChildTo

(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeChild):

rendering/RenderBlock.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): instantiate ruby renderers based on element name

rendering/RenderObject.h: add query methods for ruby renderers

(WebCore::RenderObject::isRuby):
(WebCore::RenderObject::isRubyBase):
(WebCore::RenderObject::isRubyRun):
(WebCore::RenderObject::isRubyText):

New ruby renderers:

rendering/RenderRuby.cpp: Added.

(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsInline::~RenderRubyAsInline):
(WebCore::RenderRubyAsInline::isChildAllowed):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
(WebCore::RenderRubyAsBlock::isChildAllowed):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

rendering/RenderRuby.h: Added.

(WebCore::RenderRubyAsInline::renderName):
(WebCore::RenderRubyAsInline::isRuby):
(WebCore::RenderRubyAsBlock::renderName):
(WebCore::RenderRubyAsBlock::isRuby):

rendering/RenderRubyBase.cpp: Added.

(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::~RenderRubyBase):
(WebCore::RenderRubyBase::isChildAllowed):
(WebCore::RenderRubyBase::splitToLeft):
(WebCore::RenderRubyBase::mergeWithRight):

rendering/RenderRubyBase.h: Added.

(WebCore::RenderRubyBase::renderName):
(WebCore::RenderRubyBase::isRubyBase):

rendering/RenderRubyRun.cpp: Added.

(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::~RenderRubyRun):
(WebCore::RenderRubyRun::hasRubyText):
(WebCore::RenderRubyRun::hasRubyBase):
(WebCore::RenderRubyRun::isEmpty):
(WebCore::RenderRubyRun::rubyText):
(WebCore::RenderRubyRun::rubyBase):
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::firstLineBlock):
(WebCore::RenderRubyRun::updateFirstLetter):
(WebCore::RenderRubyRun::isChildAllowed):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

rendering/RenderRubyRun.h: Added.

(WebCore::RenderRubyRun::renderName):
(WebCore::RenderRubyRun::isRubyRun):

rendering/RenderRubyText.cpp: Added.

(WebCore::RenderRubyText::RenderRubyText):
(WebCore::RenderRubyText::~RenderRubyText):
(WebCore::RenderRubyText::isChildAllowed):

rendering/RenderRubyText.h: Added.

(WebCore::RenderRubyText::renderName):
(WebCore::RenderRubyText::isRubyText):

LayoutTests:

Further layout tests will be committed in a follow-up patch under fast/ruby.

fast/ruby/parse-rp-expected.txt: result changed due to <rt> being rendered as block within <ruby>

5:00 PM Changeset in webkit [50396] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=30992
Node.isDefaultNamespace doesn't convert empty strings to null

Test: fast/dom/Node/default-namespace-empty-argument.html

dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input as null.

1:38 PM Changeset in webkit [50395] by eric@webkit.org

4 edits in trunk

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Updating the expected result to reflect the change.

fast/loader/url-parse-1-expected.txt:

2009-11-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Don't add '/' to the URL path if the it does not include '/' after the protocol component
https://bugs.webkit.org/show_bug.cgi?id=30971

Match IE8 behaviour, that does not add '/' if there is none after the protocol component.

platform/KURL.cpp: (WebCore::KURL::parse):

1:30 PM Changeset in webkit [50394] by oliver@apple.com

4 edits in trunk/WebCore

Fix layering violations in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=30986

Reviewed by Darin Adler.

Remove uses of HTMLImageElement and HTMLCanvasElement

1:22 PM Changeset in webkit [50393] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument

Implements what has been implemented in AT-SPI.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (GetAtkInterfaceTypeFromWAIType): (getInterfaceMaskFromObject): (atk_document_interface_init): (webkit_accessible_document_get_document_attribute_value): (webkit_accessible_document_get_document_attributes): (webkit_accessible_document_get_locale):

12:49 PM Changeset in webkit [50392] by eric@webkit.org

9 edits in trunk

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

WebKit.pri: Turn on warnings for the GCC compiler

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

No new tests as there is no functional change.

platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder initialization list to fix compiler warnings.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Reorder initialization list to fix compiler warnings.
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Ditto.

2009-11-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Turn on warnings for QtWebKit for gcc
https://bugs.webkit.org/show_bug.cgi?id=30958

DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN

12:41 PM Changeset in webkit [50391] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

[Regression] monitorEvent doesn't work

inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):

12:33 PM Changeset in webkit [50390] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
https://bugs.webkit.org/show_bug.cgi?id=30990

inspector/front-end/SourceFrame.js:

12:04 PM Changeset in webkit [50389] by ap@apple.com

3 edits
2 adds in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=30982
createHTMLDocument doesn't escape ampersand and less-than in title

Test: fast/dom/DOMImplementation/createHTMLDocument-title.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): Set document title after creating the document, avoiding parser intricacies.

8:18 AM Changeset in webkit [50388] by eric@webkit.org

4 edits
2 adds in trunk/LayoutTests

2009-11-01 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

Bug 30902: Need a layout test for Bug 28284
This change just adds a simple test that calls TextInputController.firstRectForCharacterRange()
before and after inserting a Thai character and compare their results.
https://bugs.webkit.org/show_bug.cgi?id=30902

fast/text/international/thai-cursor-position-expected.txt: Added.
fast/text/international/thai-cursor-position.html: Added.
platform/gtk/Skipped: Skip this test because TextInputController is not implemented.
platform/qt/Skipped: ditto.
platform/win/Skipped: ditto.

8:11 AM Changeset in webkit [50387] by eric@webkit.org

2 edits in trunk/WebCore

2009-11-01 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Double clicking on a breakpoints should not select text
https://bugs.webkit.org/show_bug.cgi?id=30950

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):

8:03 AM Changeset in webkit [50386] by eric@webkit.org

3 edits
2 adds in trunk

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

fast/css/list-item-pseudo-nocrash-expected.txt: Added.
fast/css/list-item-pseudo-nocrash.html: Added.

2009-11-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().

[Crash (debug)] Combination of list-item and :after causes assertion failure
https://bugs.webkit.org/show_bug.cgi?id=30944

Test: fast/css/list-item-pseudo-nocrash.html

rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):

7:54 AM Changeset in webkit [50385] by eric@webkit.org

4 edits in trunk

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

platform/gtk/Skipped: Unskip fixed test.

2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

Correctly set network/ready state depending on GStreamer errors
received on the bus.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback):

7:25 AM Changeset in webkit [50384] by jberlin@webkit.org

2 edits in trunk/WebKitTools

2009-11-01 Jessie Berlin <jberlin@webkit.org>

Adding myself to the committers list.

Scripts/modules/committers.py:

Oct 31, 2009:

4:22 PM Changeset in webkit [50383] by oliver@apple.com

2 edits in trunk/WebCore

Build fix

4:10 PM Changeset in webkit [50382] by oliver@apple.com

2 edits in trunk/WebCore

Remove obsolete null checks from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983

Reviewed by Darin Adler

3:19 PM Changeset in webkit [50381] by oliver@apple.com

6 edits
6 adds in trunk

WebGL allows objects to be used with the wrong context
https://bugs.webkit.org/show_bug.cgi?id=30981

Reviewed by Jon Honeycutt.

Simply add null checks and a few context guards to ensure we don't
deref null or attempt to use an object from a different context.

Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html

fast/canvas/webgl/null-object-behaviour.html

2:54 PM BuildingOnWindows edited by jberlin@webkit.org

(diff)

Oct 30, 2009:

8:48 PM Changeset in webkit [50380] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

8:48 PM Changeset in webkit [50379] by mrowe@apple.com

1 copy in tags/Safari-6531.21.8

New tag.

8:47 PM Changeset in webkit [50378] by mrowe@apple.com

2 edits in branches/safari-4-branch/WebCore

Fix the build.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):

7:11 PM Changeset in webkit [50377] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Fixed failing layout test: restore a special case I accidentally deleted.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30
Reviewed by Oliver Hunt.

runtime/DatePrototype.cpp:

(JSC::setNewValueFromDateArgs): In the case of applying a change to a date
that is NaN, reset the date to 0 *and* then apply the change; don't just
reset the date to 0.

5:51 PM Changeset in webkit [50376] by jhoneycutt@apple.com

2 edits in trunk/WebKitTools

Fix an issue that Adam noticed in DRT.

Reviewed by Darin Adler.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::role):
Get the length of the role text, and create a buffer dynamically.

5:26 PM Changeset in webkit [50375] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

5:25 PM Changeset in webkit [50374] by mrowe@apple.com

1 copy in tags/Safari-6531.21.7

New tag.

5:23 PM Changeset in webkit [50373] by mrowe@apple.com

3 edits
2 adds in branches/safari-4-branch

Merge r50356.

5:23 PM Changeset in webkit [50372] by mrowe@apple.com

6 edits
2 adds in branches/safari-4-branch

Merge r50355.

5:23 PM Changeset in webkit [50371] by mrowe@apple.com

7 edits in branches/safari-4-branch

Merge r50354.

5:23 PM Changeset in webkit [50370] by mrowe@apple.com

8 edits in branches/safari-4-branch

Merge r50353.

4:18 PM Changeset in webkit [50369] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryResult
https://bugs.webkit.org/show_bug.cgi?id=30857

Reviewed by Darin Adler.

Inherits MediaQueryResult class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
it is no need to be copyable.

css/CSSStyleSelector.h:

4:16 PM Changeset in webkit [50368] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854

Reviewed by Darin Adler.

Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.

css/MediaQueryEvaluator.h:

4:10 PM Changeset in webkit [50367] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=30854

Reviewed by Darin Adler.

Inherits MediaQueryEvaluator class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and
it is no need to be copyable.

css/MediaQueryEvaluator.h:

4:08 PM Changeset in webkit [50366] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleSet
https://bugs.webkit.org/show_bug.cgi?id=30852

Reviewed by Darin Adler.

Inherits CSSRuleSet class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
it is no need to be copyable.

css/CSSStyleSelector.cpp:

4:06 PM Changeset in webkit [50365] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleData
https://bugs.webkit.org/show_bug.cgi?id=30851

Reviewed by Darin Adler.

Inherits CSSRuleData class from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
it is no need to be copyable.

css/CSSStyleSelector.h:

4:02 PM Changeset in webkit [50364] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSRuleDataList
https://bugs.webkit.org/show_bug.cgi?id=30850

Reviewed by Darin Adler.

Inherits CSSRuleDataList class from Noncopyable because it has been
instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
it is no need to be copyable.

css/CSSStyleSelector.h:

3:59 PM Changeset in webkit [50363] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CSSNamespace
https://bugs.webkit.org/show_bug.cgi?id=30849

Reviewed by Darin Adler.

Inherits CSSNamespace struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
it is no need to be copyable.

css/CSSNamespace.h:

3:41 PM Changeset in webkit [50362] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-30 Eric Seidel <eric@webkit.org>

No review, rolling out r50105.
http://trac.webkit.org/changeset/50105

This commit was causing:
https://bugs.webkit.org/show_bug.cgi?id=30869
We'll re-implement the feature a different way.

Scripts/bugzilla-tool:

3:35 PM Changeset in webkit [50361] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix: update for object-to-pointer change.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-30

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

3:26 PM Changeset in webkit [50360] by dimich@chromium.org

5 edits in trunk/WebCore

Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
Move the synchronizer object out of the DatabaseTask so there is no need to keep
the pointer to Databasetask around after passing it to MessageQueue.
Also pass the references to return parameters to the task so it can update them.
https://bugs.webkit.org/show_bug.cgi?id=30941

Reviewed by David Levin.

No new tests, since this is just moving the code around, no change in functionality.

storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
(WebCore::Database::markAsDeletedAndClose): Ditto.
(WebCore::Database::tableNames): Ditto.
(WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
(WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.

storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
storage/DatabaseTask.cpp:

(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
(WebCore::DatabaseTaskSynchronizer::taskCompleted):
(WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
(WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
(WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
(WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.

storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):

3:23 PM Changeset in webkit [50359] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=30942
Use pointers instead of copies to pass GregorianDateTime objects around.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-29
Reviewed by Darin Adler.

SunSpider reports a shocking 4.5% speedup on date-format-xparb, and 1.3%
speedup on date-format-tofte.

runtime/DateInstance.cpp:

(JSC::DateInstance::gregorianDateTime):

runtime/DateInstance.h:
runtime/DatePrototype.cpp:

3:09 PM Changeset in webkit [50358] by adele@apple.com

3 edits
2 adds in trunk

REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
https://bugs.webkit.org/show_bug.cgi?id=30955
<rdar://problem/7067033>

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-30
Reviewed by Darin Adler.

WebCore:

When the command is deleteWordBackward or deleteWordForward
we should not add to the open typing command, but
create a new one.

Test: editing/undo/undo-deleteWord.html

editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
not CharacterGranularity.

LayoutTests:

editing/undo/undo-deleteWord-expected.txt: Added.
editing/undo/undo-deleteWord.html: Added.

3:03 PM Changeset in webkit [50357] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-10-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Make MediaPlayer constructor private
https://bugs.webkit.org/show_bug.cgi?id=30965

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.

platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::create): New.

2:38 PM Changeset in webkit [50356] by jhoneycutt@apple.com

3 edits
2 adds in trunk

Test for MSAA: Accessibility of headings is not correct

https://bugs.webkit.org/show_bug.cgi?id=30937

Reviewed by Adam Roben.

WebKitTools:

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::role):
Allow the role returned to be a BSTR.
(AccessibilityUIElement::description):
Fix a copy/paste error.

LayoutTests:

platform/win/accessibility/heading-elements-expected.txt: Added.
platform/win/accessibility/heading-elements.html: Added.

2:38 PM Changeset in webkit [50355] by jhoneycutt@apple.com

7 edits
2 adds in trunk

Test for MSAA: Accessibility of links is wrong

https://bugs.webkit.org/show_bug.cgi?id=30928

Reviewed by Darin Adler.

WebKitTools:

DumpRenderTree/AccessibilityUIElement.cpp:

(getAccessibilityValueCallback):
Return the accessibility value.
(AccessibilityUIElement::getJSClass):
Added "accessibilityValue" value.

DumpRenderTree/AccessibilityUIElement.h:

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::accessibilityValue):
Stubbed.

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::accessibilityValue):
Stubbed.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::accessibilityValue):
Get the object's value, and return it as a JS string.

LayoutTests:

platform/win/accessibility/linked-elements-expected.txt: Added.
platform/win/accessibility/linked-elements.html: Added.

2:38 PM Changeset in webkit [50354] by jhoneycutt@apple.com

7 edits in trunk

MSAA: Accessibility of headings is not correct

https://bugs.webkit.org/show_bug.cgi?id=30937

Reviewed by Alice Liu.

WebCore:

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::stringRoleForMSAA):
(WebCore::AccessibilityObject::descriptionForMSAA):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::shouldReturnTagNameAsRoleForMSAA):
If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
true.
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):
If the element should return its tag name as the role, return the tag
name.
(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
If the object is a heading, return the string "L" followed by the
heading level.
(WebCore::AccessibilityRenderObject::descriptionForMSAA):
If the object has a positional description, return it. Otherwise, get
the accessibility description, and prefix it with "Description" so that
MSAA clients know that it's not a positional description.

accessibility/AccessibilityRenderObject.h:

WebKit/win:

AccessibleBase.cpp:

(AccessibleBase::get_accDescription):
Call the object's descriptionForMSAA(). Moved the comment to the
WebCore file.
(AccessibleBase::get_accRole):
If the object has a string role, return that. Otherwise, return the
integer role.

AccessibleBase.h:

Removed description(), as this was moved to WebCore.

2:37 PM Changeset in webkit [50353] by jhoneycutt@apple.com

8 edits in trunk

MSAA: Accessibility of links is wrong

https://bugs.webkit.org/show_bug.cgi?id=30928

Reviewed by Darin Adler.

WebCore:

accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::stringValueForMSAA):
Return the URL.
(WebCore::AccessibilityImageMapLink::nameForMSAA):
Return the alt text.

accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::isLinked):
Return true.

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isLinked):
(WebCore::AccessibilityObject::stringValueForMSAA):
(WebCore::AccessibilityObject::nameForMSAA):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::isLinkable):
Return true if the element is considered "linkable" with respect to
accessibility.
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
If the element is linkable, check whether it has a parent anchor
element. If so, return the anchor element's href.
(WebCore::AccessibilityRenderObject::isLinked):
Return true if the element is linkable and if it's parent anchor tag's
href is non-empty.
(WebCore::AccessibilityRenderObject::nameForMSAA):
For text nodes, return the text.

accessibility/AccessibilityRenderObject.h:

WebKit/win:

AccessibleBase.cpp:

(AccessibleBase::get_accState):
Check whether the element is linked, instead of whether the node is an
anchor, so the child "linkable" elements of anchor elements will also
be "linked".
(AccessibleBase::name):
Return the name for MSAA.
(AccessibleBase::value):
Return the string value for MSAA.

2:20 PM Changeset in webkit [50352] by bweinstein@apple.com

1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch WebKitPrefix to force rebuild of WebKit.

1:59 PM Changeset in webkit [50351] by levin@chromium.org

24 edits in trunk

Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832

Patch by Evan Stade <estade@chromium.org> on 2009-10-30
Reviewed by David Levin.

WebCore:

This is similar to AX code that is already in place, except that this also informs the
chrome when there stops being a focused node. This is needed for a browser to show the
anchor for links that have keyboard focus.

dom/Document.cpp:

(WebCore::Document::setFocusedNode):

loader/EmptyClients.h:

(WebCore::EmptyChromeClient::focusedNodeChanged):

page/Chrome.cpp:

(WebCore::Chrome::focusedNodeChanged):

page/Chrome.h:
page/ChromeClient.h:

WebKit/gtk:

Added stub implementation for new ChromeClient function.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::focusedNodeChanged):

WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku:

Added stub implementation for new ChromeClient function.

WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::focusedNodeChanged):

WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

Added stub implementation for new ChromeClient function.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedNodeChanged):

WebKit/qt:

Added stub implementation for new ChromeClient function.

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::focusedNodeChanged):

WebCoreSupport/ChromeClientQt.h:

WebKit/win:

Added stub implementation for new ChromeClient function.

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::focusedNodeChanged):

WebCoreSupport/WebChromeClient.h:

WebKit/wx:

Added stub implementation for new ChromeClient function.

WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::focusedNodeChanged):

WebKitSupport/ChromeClientWx.h:

1:20 PM Changeset in webkit [50350] by eric@webkit.org

3 edits
2 adds in trunk

2009-10-30 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer.

openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417

storage/open-database-set-empty-version-expected.txt: Added.
storage/open-database-set-empty-version.html: Added.

2009-10-30 Ben Murdoch <benm@google.com>

Reviewed by David Kilzer.

openDatabase() with empty version sets db version up incorrectly
https://bugs.webkit.org/show_bug.cgi?id=28417

Test: storage/open-database-set-empty-version.html

storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.

12:52 PM Changeset in webkit [50349] by kevino@webkit.org

2 edits in trunk/WebKitTools

Fix typo in command name used by wx build system.

12:37 PM Changeset in webkit [50348] by eric@webkit.org

8 edits in trunk/WebCore

2009-10-30 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Need to turn off notifications properly at runtime
https://bugs.webkit.org/show_bug.cgi?id=30409

Moving the notificationsEnabled bit from NotificationCenter
to the new V8 RuntimeEnabledFeatures object.

Just moving a bit around, so no new tests.

bindings/v8/RuntimeEnabledFeatures.cpp:
bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
notifications/NotificationCenter.cpp:
notifications/NotificationCenter.h:

11:31 AM Changeset in webkit [50347] by dimich@chromium.org

14 edits in trunk/WebCore

[V8] More cleanup after r49949: remove ListenerGuard.
ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
https://bugs.webkit.org/show_bug.cgi?id=30943

Reviewed by Dimitri Glazkov.

Covered by fast/events/add-event-without-document.html which will now pass in Chromium.

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::handleEvent):

bindings/v8/V8AbstractEventListener.h:
bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getEventListener):

bindings/v8/V8EventListenerList.h:

(WebCore::V8EventListenerList::findOrCreateWrapper):

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::V8Proxy):
(WebCore::V8Proxy::disconnectFrame):
(WebCore::V8Proxy::clearForNavigation):

bindings/v8/V8Proxy.h:
bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::reportError):

bindings/v8/V8WorkerContextEventListener.h:

(WebCore::V8WorkerContextEventListener::create):

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::dispose):
(WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):

bindings/v8/WorkerContextExecutionProxy.h:
bindings/v8/custom/V8CustomEventListener.cpp:

(WebCore::V8EventListener::V8EventListener):

bindings/v8/custom/V8CustomEventListener.h:

(WebCore::V8EventListener::create):

11:19 AM Changeset in webkit [50346] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-30 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Patch v1 is a dumb default name for patches
https://bugs.webkit.org/show_bug.cgi?id=30952

Let's use "Patch" instead.

Scripts/bugzilla-tool:

10:57 AM Changeset in webkit [50345] by hamaji@chromium.org

3 edits
2 adds in trunk

2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939

Test: fast/css/counters/counterValueForElementById.html

rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):

2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

counterValueForElementById should return space-separated string for multiple counters
https://bugs.webkit.org/show_bug.cgi?id=30939

fast/css/counters/counterValueForElementById-expected.txt: Added.
fast/css/counters/counterValueForElementById.html: Added.

10:50 AM Changeset in webkit [50344] by eric@webkit.org

4 edits in trunk/WebKit/qt

2009-10-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Remove the QWebInspector::windowTitleChanged signal,
QEvent::WindowTitleChange can be used to achieve the same.
https://bugs.webkit.org/show_bug.cgi?id=30927

Api/qwebinspector.cpp:
Api/qwebinspector.h:
WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::updateWindowTitle):

10:43 AM Changeset in webkit [50343] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-30 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Add some comments to explain what is happening here.

10:35 AM Changeset in webkit [50342] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Fix Web Inspector crash on the errors/warnings counter click

RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.

https://bugs.webkit.org/show_bug.cgi?id=30499

rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):

10:27 AM Changeset in webkit [50341] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Fix Web Inspector crash on the errors/warnings counter click

RenderObject::createVisiblePosition(const Position& position)
understands "null Positions", so we can construct such a Position manually.

https://bugs.webkit.org/show_bug.cgi?id=30499

rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):

10:26 AM Changeset in webkit [50340] by hamaji@chromium.org

3 edits in trunk/LayoutTests

2009-10-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Mark Rowe.

fast/css/counters/t1204* are not asynchronous anymore
https://bugs.webkit.org/show_bug.cgi?id=30940

fast/css/counters/t1204-increment-00-c-o.html:
fast/css/counters/t1204-increment-01-c-o.html:

10:19 AM Changeset in webkit [50339] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-30 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

Second part of the implementation of AtkTable.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (cellAtIndex): (webkit_accessible_table_get_column_at_index): (webkit_accessible_table_get_row_at_index): (webkit_accessible_table_get_caption): (atk_table_interface_init):

9:40 AM Changeset in webkit [50338] by bweinstein@apple.com

1 edit in trunk/WebCore/WebCorePrefix.cpp

Touch WebCorePrefix to try and force a clean build.

9:18 AM Changeset in webkit [50337] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-10-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add TimelinePanel into the panels enum.

https://bugs.webkit.org/show_bug.cgi?id=30915

inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
inspector/front-end/inspector.js: (WebInspector.showTimelinePanel):

8:48 AM Changeset in webkit [50336] by Csaba Osztrogonác

2 edits in trunk/WebKitTools

Unreviewed trivial buildfix.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
[Qt] Buildfix for r50333.

DumpRenderTree/qt/DumpRenderTree.pro:

8:00 AM Changeset in webkit [50335] by kenneth@webkit.org

7 edits in trunk/LayoutTests

Unreviewed layout test fixes.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
The existing excepted results were wrong, due to the visited links not
being reset between tests.

This was fixed in r50329, so updating the results.

platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:

7:13 AM Changeset in webkit [50334] by Csaba Osztrogonác

1 edit
9 adds in trunk/LayoutTests

[Qt] Add expected files for new svg tests we pass.
Compared to the Mac expected png files.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.

platform/qt/svg/css/arrow-with-shadow-expected.txt: Added.
platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
platform/qt/svg/css/clippath-with-shadow-expected.txt: Added.
platform/qt/svg/css/mask-with-shadow-expected.txt: Added.
platform/qt/svg/css/path-with-shadow-expected.txt: Added.
platform/qt/svg/css/stars-with-shadow-expected.txt: Added.
platform/qt/svg/filters/shadow-on-filter-expected.txt: Added.
platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.

7:02 AM Changeset in webkit [50333] by tonikitoo@webkit.org

2 edits
2 deletes in trunk/WebKitTools

[Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=30953

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-30
Reviewed by Holger Freyther.

DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
makes qt DRT to share this implementation (as gtk and mac ports do).

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/WorkQueue.cpp: Removed.
DumpRenderTree/qt/WorkQueue.h: Removed.

6:51 AM Changeset in webkit [50332] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Unreviewed potential buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Second try: Reset page history before running each test.

Apparently the QWebHistory::clear() keeps the current page
in history which is not what we want, so we not additionally
sets the history capacity to 0 (forces removing everything)
and then sets it back to its original value.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

6:38 AM Changeset in webkit [50331] by yurys@chromium.org

1 edit
2 adds in trunk/LayoutTests

changelog date

6:29 AM Changeset in webkit [50330] by kenneth@webkit.org

2 edits in trunk/WebCore

If the owner widget of the page has a palette set, we
should use that one. This was only working when the
owner was a QWebView. This patch fixes that.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reviewed by Holger Hans Peter Freyther.

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::applyTheme):

6:07 AM Changeset in webkit [50329] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Unreviewed potential buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-30
Reset page history before running each test.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

5:12 AM QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org

(diff)

3:50 AM Changeset in webkit [50328] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-10-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Wire CookieJarChromium to the cookies
backend. This is a final step of a 3-steps raw cookies
access implementation in Chromium.

platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):

3:32 AM Changeset in webkit [50327] by yurys@chromium.org

7 edits in trunk/WebCore

2009-10-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Fix Chromium crash in console.log in "deeply recursive" function

Check that result of 'frameSourceName' is not null handle
before casting it to String.

Allow V8Proxy::sourceName/sourceLineNumber() to report
that they have failed due to JavaScript stack overflow.

https://bugs.webkit.org/show_bug.cgi?id=30904

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
bindings/v8/ScriptCallStack.h:
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
bindings/v8/V8Proxy.h:
bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

2:27 AM Changeset in webkit [50326] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's MediaQueryExp
https://bugs.webkit.org/show_bug.cgi?id=30855

Reviewed by Darin Adler.

Inherits MediaQueryExp class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.

css/MediaQueryExp.h:

1:55 AM Changeset in webkit [50325] by abarth@webkit.org

1 edit
1 add in trunk

2009-10-30 Adam Barth <abarth@webkit.org>

Reviewed by Mark Rowe.

Teach git to ignore some files
https://bugs.webkit.org/show_bug.cgi?id=30951

Ignore WebKitBuild because we never want to version that directory.
Also, ignore the xcode project files so git clean doesn't blow away
your project settings. Finally, ignore the compiled python files in
WebKitTools/Script modules because they clutter up git status.

.gitignore: Added.

1:53 AM Changeset in webkit [50324] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

Allow custom memory allocation control for JavaScriptCore's ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=30853

Reviewed by Darin Adler.

Inherits ListHashSet class from FastAllocBase because it is
instantiated by 'new' in WebCore/rendering/RenderBlock.cpp:1813.

wtf/ListHashSet.h:

1:13 AM Changeset in webkit [50323] by oliver@apple.com

5 edits in trunk

Regression: crash enumerating properties of an object with getters or setters
https://bugs.webkit.org/show_bug.cgi?id=30948

Reviewed by Gavin Barraclough

Add a guard to prevent us trying to cache property enumeration on
objects with getters or setters.

12:55 AM Changeset in webkit [50322] by rolandsteiner@chromium.org

17 edits in trunk

Commit patch 1 of ruby implementation, reviewed by Eric Seidel. (see issue 28420)

12:24 AM Changeset in webkit [50321] by mitz@apple.com

2 edits in trunk/WebCore

Removed test for an impossible condition (a glyph in a right-to-left run not having
the RTL flag 0x800)

Reviewed by Adele Peterson.

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):

12:13 AM Changeset in webkit [50320] by oliver@apple.com

2 edits in trunk/JavaScriptCore

REGRESSION (r50218-r50262): E*TRADE accounts page is missing content
https://bugs.webkit.org/show_bug.cgi?id=30947
<rdar://problem/7348833>

Reviewed by Maciej Stachowiak

The logic for flagging that a structure has non-enumerable properties
was in addPropertyWithoutTransition, rather than in the core Structure::put
method. Despite this I was unable to produce a testcase that caused
the failure that etrade was experiencing, but the new assertion in
getEnumerablePropertyNames triggers on numerous layout tests without
the fix, so in effecti all for..in enumeration in any test ends up
doing the required consistency check.

Oct 29, 2009:

11:51 PM Changeset in webkit [50319] by abarth@webkit.org

4 edits in trunk/WebCore

2009-10-29 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906

We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.

bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):

11:29 PM QtBackLog edited by zecke@selfish.org

(diff)

11:26 PM QtBackLog edited by zecke@selfish.org

(diff)

11:12 PM Changeset in webkit [50318] by mitz@apple.com

4 edits in trunk/WebKitTools

Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
from the two scripts that define it but don’t use it to the script that uses it but doesn’t
define it.

Reviewed by Mark Rowe.

Scripts/VCSUtils.pm:
Scripts/svn-apply:
Scripts/svn-unapply:

10:57 PM Changeset in webkit [50317] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Validate the stopSpeaking: selector so that is not always enabled when a WebView is first responder.

Reviewed by Oliver Hunt.

WebView/WebHTMLView.mm:

(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):

9:07 PM Changeset in webkit [50316] by mrowe@apple.com

2 edits in trunk/WebKit/win

<http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
to IWebFramePrivate vtable ordering

Rubber-stamped by Dan Bernstein.

Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that

it doesn't affect the ordering of the vtable.

7:39 PM Changeset in webkit [50315] by eric@webkit.org

5 edits
3 adds
1 delete in trunk

2009-10-29 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make links mouse focusable only on GTK and QT.

Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.

https://bugs.webkit.org/show_bug.cgi?id=26856

fast/events/click-focus-anchor-expected.txt:
fast/events/click-focus-anchor.html:
platform/gtk/fast/events/click-focus-anchor-expected.txt: Added.
platform/mac/fast/events/click-focus-anchor-expected.txt: Removed.
platform/qt/fast/events/click-focus-anchor-expected.txt: Added.

2009-10-29 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Make links mouse focusable only on GTK and QT.

Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.

https://bugs.webkit.org/show_bug.cgi?id=26856

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isMouseFocusable):

7:30 PM Changeset in webkit [50314] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-10-29 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.

Add expected files for GTK and QT builds, for test text-input-webkit-radius.html
Expected fils collected from buildbot:
http://build.webkit.org/results/Qt%20Linux%20Release/r50286%20(3257)/fast/css/
http://build.webkit.org/results/GTK%20Linux%20Release/r50286%20(5308)/fast/css/

platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.

7:00 PM Changeset in webkit [50313] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated Tiger-specific result now that Tiger matches current behavior. A Tiger-specific
result is still needed because of the difference in Thai fonts.

platform/mac-tiger/fast/text/atsui-multiple-renderers-expected.txt:

5:49 PM Changeset in webkit [50312] by mitz@apple.com

6 edits
3 deletes in trunk

WebCore: Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
code path.

Reviewed by Sam Weinig.

platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
glyphs, but update indexes and advances correctly.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.

LayoutTests: Updated a test to account for font metric differences between Mac OS X versions. Removed
Leopard-specific results for another test now that Leopard matches current behavior.

Reviewed by Sam Weinig.

platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum: Removed.
platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Removed.
platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt: Removed.
platform/mac/fast/text/ligature-subdivision-expected.txt:
platform/mac/fast/text/script-tests/ligature-subdivision.js:

5:26 PM Changeset in webkit [50311] by adele@apple.com

2 edits in trunk

Updating Radar numbers

4:37 PM Changeset in webkit [50310] by adele@apple.com

6 edits
2 adds in trunk

REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
<rdar://problem/7067033>
https://bugs.webkit.org/show_bug.cgi?id=30892

WebCore:

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29
Reviewed by Darin Adler.

This problem shows in any scenario where it is necessary to split a text
node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
have member variables initialized in the constructor to keep reference to elements
they need to operate upon. These reference are not updated when reapplying the command.
For this reason it is necessary to guarantee that unapply doesn not delete the references
and that these commands implement doReapply to correctly reuse the existing
elements.

Test: editing/undo/redo-style.html

editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply): Added.
(WebCore::SplitElementCommand::doApply): Modified to call executeApply.
(WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
(WebCore::SplitElementCommand::doReapply): Added.

editing/SplitElementCommand.h: Added doReapply and executeApply.
editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
(WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
(WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
(WebCore::WrapContentsInDummySpanCommand::doReapply): Added.

editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.

LayoutTests:

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29

editing/undo/redo-style-expected.txt: Added.
editing/undo/redo-style.html: Added.

4:22 PM Changeset in webkit [50309] by jorlow@chromium.org

3 edits in trunk/WebCore

2009-10-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

DOM Storage's condition variable needs to handle spurious wakeups
https://bugs.webkit.org/show_bug.cgi?id=30920

Add a boolean to keep track of whether it's been terminated. Clean
up the locking code a tiny bit to make it easier to read. There's
no way to reproduce this reliably in a LayoutTest.

storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
storage/LocalStorageThread.h:

4:22 PM Changeset in webkit [50308] by andersca@apple.com

2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=30932
<rdar://problem/7350269>

Reviewed by Sam Weinig.

REGRESSION: Crash when turning on Private Browsing on site with flash.

Null check setValue.

Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView privateBrowsingModeDidChange]):

3:49 PM Changeset in webkit [50307] by kenneth@webkit.org

4 edits in trunk

WebKitTools: Implement the Qt version of DRT dumpBackForwardList().

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::dumpHistoryItem):
(WebCore::DumpRenderTree::dumpBackForwardList):

LayoutTests: Removed test that passes after implementing the Qt DRT version
of dumpBackForwardList().

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.

platform/qt/Skipped:

3:43 PM Changeset in webkit [50306] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-10-29 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Include ComplextTextController into Chromium Mac project.

WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.

3:32 PM Changeset in webkit [50305] by eric.carlson@apple.com

2 edits in trunk/WebKit/mac

2009-10-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Kevin Decker.

Refactor some duplicate plug-in clean up code into shared functions.

Plugins/WebPluginController.mm: (-[WebPluginController stopOnePlugin:]): New, stop a plug-in. (-[WebPluginController destroyOnePlugin:]): New, destroy plug-in. (-[WebPluginController stopAllPlugins]): Call stopOnePlugin. (-[WebPluginController destroyPlugin:]): Call stopOnePlugin and destroyOnePlugin. (-[WebPluginController destroyAllPlugins]): Call destroyOnePlugin.

3:32 PM Changeset in webkit [50304] by hamaji@chromium.org

2 edits
1 add
3 deletes in trunk/LayoutTests

2009-10-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

fast/css/counters/invalidate-cached-counter-node can be dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=30931

fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
fast/css/counters/invalidate-cached-counter-node.html:
platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Removed.
platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Removed.
platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Removed.

2:59 PM Changeset in webkit [50303] by timothy@apple.com

2 edits in trunk/WebCore

Fix tabbing through element attributes in the Web Insector.

https://bugs.webkit.org/show_bug.cgi?id=30429

Reviewed by Pavel Feldman.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
it is called for us when removeAttribute succeeds in the back-end.
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
(WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.

2:54 PM Changeset in webkit [50302] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Remove some tests that now pass.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-29

platform/qt/Skipped:

2:25 PM Changeset in webkit [50301] by mitz@apple.com

4 edits
1 copy
4 adds in trunk

Problem editing or selecting text containing ligatures
https://bugs.webkit.org/show_bug.cgi?id=30025

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/ligature-subdivision.html

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Initialize
m_characterInCurrentGlyph.
(WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
characters, compute the hit character based on dividing the glyph’s total advance into
a number of equal intervals equal to the number of characters and assigning the hit to the
character corresponding to the hit interval.
(WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
by a fraction of the glyph’s total advance.

platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.

LayoutTests:

platform/mac/fast/text/ligature-subdivision-expected.txt: Added.
platform/mac/fast/text/ligature-subdivision.html: Added.
platform/mac/fast/text/script-tests: Added.
platform/mac/fast/text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/script-tests/TEMPLATE.html.
platform/mac/fast/text/script-tests/ligature-subdivision.js: Added.

2:25 PM Changeset in webkit [50300] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30918>.
Web Inspector: Datagrid Rows on Windows not properly aligned.

Reviewed by Timothy Hatcher.

Use line-height for the table rows to make sure the height
of our text and the height of the table rows are consistent.

inspector/front-end/inspector.css:

1:33 PM Changeset in webkit [50299] by abarth@webkit.org

3 edits in trunk/WebCore

2009-10-29 Adam Barth <abarth@webkit.org>

No review, rolling out r50296.
http://trac.webkit.org/changeset/50296

bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):

1:25 PM Changeset in webkit [50298] by xan@webkit.org

2 edits in trunk/WebKitTools

2009-10-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Use the GTK+ main loop instead of rolling our own mini-version of
it.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (webViewLoadFinished):

1:21 PM Changeset in webkit [50297] by kenneth@webkit.org

2 edits in trunk/LayoutTests

Rubberstamped by Adam Roben.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove two tests that pass on the buildbot.

platform/qt/Skipped:

1:15 PM Changeset in webkit [50296] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-29 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906

We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.

bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):

1:05 PM Changeset in webkit [50295] by kov@webkit.org

2 edits in trunk/WebCore

Reviewed by Xan Lopez.

Remove build warning introduced by r50284.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):

1:05 PM Changeset in webkit [50294] by kenneth@webkit.org

2 edits in trunk/LayoutTests

Unreviewed Qt buildbot fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Add some files to skipped that depend on phonon support,
which is disabled on the Qt buildbot for now.

platform/qt/Skipped:

1:01 PM Changeset in webkit [50293] by Dimitri Glazkov

4 edits in trunk/WebCore

2009-10-29 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Remove random crashes by removing retrieval of V8 context during garbage collection.

https://bugs.webkit.org/show_bug.cgi?id=30919

Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
bindings/v8/V8DOMWrapper.h: Added getter decl.
bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.

12:43 PM Changeset in webkit [50292] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-10-29 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[Chromium] Adjust the project files to sync up with
http://trac.webkit.org/changeset/50259

WebCore.gypi: Renamed and added files.

12:41 PM Changeset in webkit [50291] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated expected result for Tiger

platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:

12:24 PM Changeset in webkit [50290] by kenneth@webkit.org

2 edits in trunk/LayoutTests

Rubberstamped by Adam Roben.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove tests that pass after the change introduced in r50289.

platform/qt/Skipped:

12:06 PM Changeset in webkit [50289] by kenneth@webkit.org

4 edits in trunk/WebKitTools

Implement DRT functionality for Qt introduced in
r28690 and r28705.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Adam Roben.

Implemented pathToLocalResource which exposes the functionality of

converting a given unix path to the correct location on Windows.

Implemented a way to remove machine-dependent information from paths

in layout test results.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::urlSuitableForTestResult):
(WebCore::WebPage::javaScriptConsoleMessage):

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::pathToLocalResource):

DumpRenderTree/qt/LayoutTestControllerQt.h:

11:29 AM Changeset in webkit [50288] by eric@webkit.org

4 edits in trunk

2009-10-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Tor Arne Vestbø.

[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894

No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):

2009-10-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Tor Arne Vestbø.

[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894

No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).

Api/qwebframe.cpp: (QWebFrame::load):

11:15 AM Changeset in webkit [50287] by bweinstein@apple.com

3 edits in trunk/WebCore

Part of <http://webkit.org/b/30483>.
Web Inspector: Always show the Local and Session Storage Views.

Reviewed by Timothy Hatcher.

Even if the length of the DOM Storage entry array is 0, still
generate the Datagrid because users can add things storage items
through the UI, so we should allow them to even if there isn't
anything there currently.

English.lproj/localizedStrings.js: Removed "This Storage is Empty".
inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):

10:58 AM Changeset in webkit [50286] by pfeldman@chromium.org

3 edits in trunk/WebCore

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add TimelinePanel into the panels enum.

https://bugs.webkit.org/show_bug.cgi?id=30915

inspector/InspectorController.cpp: (WebCore::InspectorController::specialPanelForJSName):
inspector/InspectorController.h: (WebCore::InspectorController::):

10:53 AM Changeset in webkit [50285] by xan@webkit.org

2 edits in trunk/WebCore

2009-10-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814

Create strings shared among threads with crossThreadString
constructor method.

storage/Database.cpp: (WebCore::Database::Database):

10:50 AM Changeset in webkit [50284] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-29 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=30308

Add support for ARGB videos.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Create the Cairo image surface for ARGB32 or RGB24 depending on the buffer's caps.

platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): Handle ARGB video and convert GStreamer's ARGB to Cairo's for displaying.

10:42 AM Changeset in webkit [50283] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-29 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[chromium] expose a method to access memory usage information in ChromiumBridge
Declare a static method to be implemented by http://codereview.chromium.org/332010/
https://bugs.webkit.org/show_bug.cgi?id=30829

platform/chromium/ChromiumBridge.h:

10:34 AM Changeset in webkit [50282] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-29 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Implements the AtkSelection interface and enables the corresponding
(and expected) object:selection-changed event.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (optionFromList): (optionFromSelection): (atk_selection_interface_init): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_ref_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_selection_select_all_selection): (GetAtkInterfaceTypeFromWAIType):
accessibility/gtk/AXObjectCacheAtk.cpp: (AXObjectCache::postPlatformNotification):

10:27 AM Changeset in webkit [50281] by sfalken@apple.com

1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

10:26 AM Changeset in webkit [50280] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Steve Falkenburg.

Windows Release bots are having problems in xmlhttprequest tests, Skipping them temporarily
to see if this eliminates the problem, and it is a test causing httpd problems.

platform/win/Skipped:

10:18 AM Changeset in webkit [50279] by jianli@chromium.org

2 edits in trunk/WebCore

Bug 30655 - Only plain text should be copied to clipboard for TextArea.
https://bugs.webkit.org/show_bug.cgi?id=30655

Reviewed by Darin Adler.

editing/Editor.cpp:

(WebCore::nodeIsInTextFormControl):
(WebCore::Editor::cut):
(WebCore::Editor::copy):

9:58 AM Changeset in webkit [50278] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: hide timeline for now - not yet ready.

https://bugs.webkit.org/show_bug.cgi?id=30912

inspector/front-end/inspector.js: (WebInspector._createPanels):

9:46 AM Changeset in webkit [50277] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: deploy Web Inspector's images in WebCore.gypi.

WebCore.gypi:

9:36 AM Changeset in webkit [50276] by pfeldman@chromium.org

7 edits in trunk/WebCore

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: get rid of timelineProfilerEnabled method.

https://bugs.webkit.org/show_bug.cgi?id=30911

inspector/InspectorBackend.cpp:
inspector/InspectorBackend.h:
inspector/InspectorBackend.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
inspector/InspectorController.h:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

9:12 AM Changeset in webkit [50275] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Create stub methods for raw cookies access in ChromiumBridge.h

https://bugs.webkit.org/show_bug.cgi?id=30910

platform/chromium/ChromiumBridge.h:

8:58 AM QtWebKitContrib edited by vestbo@webkit.org

(diff)

8:55 AM QtWebKitContrib edited by vestbo@webkit.org

(diff)

8:44 AM Changeset in webkit [50274] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's RareData
https://bugs.webkit.org/show_bug.cgi?id=30858

Reviewed by Darin Adler.

Inherits RareData struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSSelector.h:259 and
it is no need to be copyable.

css/CSSSelector.h:

8:41 AM Changeset in webkit [50273] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's ShorthandScope
https://bugs.webkit.org/show_bug.cgi?id=30859

Reviewed by Darin Adler.

Inherits ShorthandScope class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and
it is no need to be copyable.

css/CSSParser.h:

8:38 AM Changeset in webkit [50272] by zoltan@webkit.org

2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=30848

Reviewed by Darin Adler.

Inherits AXObjectCache class from FastAllocBase because it is
instantiated by 'new' in WebCore/dom/Document.cpp:1537 and
it is no need to be copyable.

accessibility/AXObjectCache.h:

8:18 AM Changeset in webkit [50271] by abarth@webkit.org

3 edits
2 adds in trunk

2009-10-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881

Test that we don't run JavaScript URLs in view source mode.

This test actually passes before this change. I don't know how to
actually run JavaScript URLs in view source frames using DRT, but it's
possible in an abitrary embedding of WebKit.

http/tests/security/view-source-no-javascript-url-expected.txt: Added.
http/tests/security/view-source-no-javascript-url.html: Added.

2009-10-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881

Just say no.

Test: http/tests/security/view-source-no-javascript-url.html

bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):

7:43 AM Changeset in webkit [50270] by kenneth@webkit.org

6 edits in trunk/WebKit/qt

Remove QWebView::guessUrlFromString() and replace its use
with the new QUrl::fromUserInput() if using Qt 4.6 or newer.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Tor Arne Vestbø.

Api/qwebview.cpp:
Api/qwebview.h:
QGVLauncher/main.cpp:

(urlFromUserInput):
(WebPage::applyProxy):
(MainWindow::load):

QtLauncher/main.cpp:

(urlFromUserInput):
(MainWindow::MainWindow):
(MainWindow::changeLocation):

tests/qwebview/tst_qwebview.cpp:

6:23 AM Changeset in webkit [50269] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Serialize directly to the stream, and not first to an QByteArray,
that is later serialized. That is slower and also uses more bytes.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.

Api/qwebhistory.cpp:

(operator<<):
(operator>>):

5:48 AM Changeset in webkit [50268] by kov@webkit.org

2 edits in trunk/WebCore

Unreviewed. Fixes style problems pointed out by Evan Martin.

5:46 AM Changeset in webkit [50267] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Unreviewed. Trivial fix - move public API declaration into the
public subsection of the doc.

docs/webkitgtk-sections.txt:

2:21 AM Changeset in webkit [50266] by mitz@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Mark Rowe.

64-bit Leopard build fix after r50259

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

Declared ATSUTextInserted in 64-bit.
(WebCore::fontHasMirroringInfo): Use %d format and cast to int.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.

12:32 AM Changeset in webkit [50265] by zoltan@webkit.org

2 edits in trunk/JavaScriptCore

Add cacheFlush support for Thumb-2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=30865

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-29
Reviewed by Gavin Barraclough.

jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

12:23 AM Changeset in webkit [50264] by mitz@apple.com

3 edits in trunk/WebCore

Tiger build fix after r50259

platform/graphics/mac/ComplexTextController.h:
platform/graphics/mac/ComplexTextControllerATSUI.cpp:

12:12 AM Changeset in webkit [50263] by mitz@apple.com

2 edits in trunk/WebCore

Tiger build fix after r50259

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

Oct 28, 2009:

11:07 PM Changeset in webkit [50262] by sfalken@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix changelog

11:06 PM Changeset in webkit [50261] by sfalken@apple.com

2 edits
1 add in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=30899
WebKit fails to build release on 32-bit Windows systems

Reviewed by Mark Rowe.

WebCore.vcproj/WebCore.vcproj: Excluded files from project.
bindings/js/JSBindingsAllInOne.cpp: Added.

11:04 PM Changeset in webkit [50260] by mitz@apple.com

2 edits in trunk/WebCore

Fixed typos in color names.

Reviewed by Jon Honeycutt.

inspector/front-end/Color.js:

10:35 PM Changeset in webkit [50259] by mitz@apple.com

3 edits
1 copy
3 moves
1 add
2 deletes in trunk

WebCore: Share code between the ATSUI- and Core Text-based Font implementations by doing the
following:

Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific parts in ComplexTextControllerCoreText.cpp.
Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
Remove FontMacATSUI.

Reviewed by Sam Weinig.

WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,

and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
FontComplexTextMac.cpp.

platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and

kept the non-Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
its own.
(WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
m_complexTextRuns holding references instead of objects.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
its own.
(WebCore::ComplexTextController::advance): Updated for renames.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
and advances() accessors.

platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and

renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
the latter RefCounted, added ATSUI-specific members to it, and made some other members
Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
rather than objects.
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::glyphs):
(WebCore::ComplexTextController::ComplexTextRun::advances):

platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific

parts of the ComplexTextController implementation.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
(WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
(WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
get the glyphs, advances and indices vectors populated.
(WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.

platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from

CoreTextController.cpp and kept the Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
this was done in adjustGlyphsAndAdvances().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
including its own.

platform/graphics/mac/CoreTextController.cpp: Removed.
platform/graphics/mac/CoreTextController.h: Removed.
platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.

(WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
of CoreTextController.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

platform/graphics/mac/FontMacATSUI.mm: Removed.
platform/graphics/mac/FontMacCoreText.cpp: Removed.

LayoutTests: Removed Leopard-specific result after changing ATSUI missing-glyph behavior to match the
Core Text and fast code paths' behavior.

platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Removed.

10:23 PM Changeset in webkit [50258] by rolandsteiner@chromium.org

2 edits in trunk/WebKitTools

2009-10-28 Roland Steiner <rolandsteiner@chromium.org>

Adding myself to the committers list.

Scripts/modules/committers.py:

9:20 PM Changeset in webkit [50257] by Chris Fleizach

2 edits in trunk/WebKitTools

Adding myself to the committers list.

7:48 PM Changeset in webkit [50256] by Chris Fleizach

6 edits
2 adds in trunk

WebCore: WAI-ARIA: add support for 'option' role
https://bugs.webkit.org/show_bug.cgi?id=30843

Reviewed by Darin Adler.

Test: accessibility/aria-option-role.html

accessibility/AccessibilityListBoxOption.h:

(WebCore::AccessibilityListBoxOption::canHaveChildren):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::RoleEntry::):
(WebCore::AccessibilityRenderObject::canHaveChildren):

LayoutTests: Fix video-pause-immediately.html to avoid using setTimeout().

Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-28
Reviewed by Eric Carlson.

This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.

https://bugs.webkit.org/show_bug.cgi?id=30889

media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.

6:40 PM Changeset in webkit [50255] by barraclough@apple.com

5 edits in trunk/JavaScriptCore

JSC JIT on ARMv7 cannot link jumps >16Mb range
https://bugs.webkit.org/show_bug.cgi?id=30891

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-28
Reviewed by Oliver Hunt.

Start planing all relative jumps as move-32-bit-immediate-to-register-BX.
In the cases where the jump would fall within a relative jump range, use a relative jump.

JavaScriptCore.xcodeproj/project.pbxproj:
assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::~ARMv7Assembler):
(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::executableCopy):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::isB):
(JSC::ARMv7Assembler::isBX):
(JSC::ARMv7Assembler::isMOV_imm_T3):
(JSC::ARMv7Assembler::isMOVT):
(JSC::ARMv7Assembler::isNOP_T1):
(JSC::ARMv7Assembler::isNOP_T2):
(JSC::ARMv7Assembler::linkJumpAbsolute):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmSecond):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):

jit/JIT.h:
wtf/Platform.h:

6:25 PM Changeset in webkit [50254] by oliver@apple.com

15 edits in trunk/JavaScriptCore

Improve for..in enumeration performance
https://bugs.webkit.org/show_bug.cgi?id=30887

Reviewed by Geoff Garen.

Improve indexing of an object with a for..in iterator by
identifying cases where get_by_val is being used with a iterator
as the subscript and replace it with a new get_by_pname
bytecode. get_by_pname then optimizes lookups that directly access
the base object.

5:54 PM Changeset in webkit [50253] by eric@webkit.org

12 edits in trunk/WebCore

2009-10-28 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=30716

WebCore.gyp/WebCore.gyp: Enable "chromium_code" flag, just on Mac build for now.
accessibility/AccessibilityRenderObject.cpp: (WebCore::createARIARoleMap): Fix struct visibiity warning.
bindings/v8/ScriptCallStack.h: Fix out-of-order member initialization warning.
bindings/v8/V8Collection.h: (WebCore::getV8Object): Function in header should not be 'static' (fixes unused-static warning.)
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Fix signed/unsigned comparison warning.
bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::applyGrouping): Fix unused-variable warning.
css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Enable ListButtonPart case to avoid

warning about missing cases in 'switch' statement.

editing/EditorCommand.cpp: (WebCore::createCommandMap): Fix struct visibiity warning.
platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): Fix out-of-order member initialization warning.
rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Add empty 'default' case in

'switch' statement to avoid missing-case warning.

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Ditto.

xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap): Fix struct visibiity warning.

5:45 PM Changeset in webkit [50252] by eric@webkit.org

2 edits in trunk/LayoutTests

2009-10-28 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson.

Fix video-pause-immediately.html to avoid using setTimeout().

This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.

https://bugs.webkit.org/show_bug.cgi?id=30889

media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.

5:22 PM Changeset in webkit [50251] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-28 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
https://bugs.webkit.org/show_bug.cgi?id=30839

Added null check for the case when the frame is detached from the page.

loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):

5:12 PM Changeset in webkit [50250] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30817
Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent

Also removes the hack I had originally added to solve bug 25411, because
the fix here is what I should have done in the first place.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):

5:08 PM Changeset in webkit [50249] by bweinstein@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Ada Chan.

Add accessibility test to the list of Windows Skipped tests.

platform/win/Skipped:

4:37 PM Changeset in webkit [50248] by dimich@chromium.org

2 edits in trunk/JavaScriptCore

Not reviewed, attemp to fix Windows build.

Touch the cpp file to cause recompile.

wtf/Threading.cpp:

(WTF::threadEntryPoint):

4:21 PM Changeset in webkit [50247] by dimich@chromium.org

4 edits in trunk

JavaScriptCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this since Database removes tasks when it is stopped.
https://bugs.webkit.org/show_bug.cgi?id=30805

Reviewed by David Levin.

wtf/MessageQueue.h:

(WTF::::removeIf):

WebCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this, no change in functionality.
https://bugs.webkit.org/show_bug.cgi?id=30805

Reviewed by David Levin.

storage/DatabaseThread.cpp:

(WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
(WebCore::SameDatabasePredicate::operator()):
(WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.

4:19 PM Changeset in webkit [50246] by pfeldman@chromium.org

4 edits in trunk/WebCore

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Glue subsequent timeline records with same category
and title together. Enable Timeline Panel!!!

https://bugs.webkit.org/show_bug.cgi?id=30885

English.lproj/localizedStrings.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype.refresh):

3:56 PM Changeset in webkit [50245] by kov@webkit.org

10 edits in trunk

LayoutTests

Reviewed by Jan Alonzo.

[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551

Unskip inspector tests that we are now able to run.

platform/gtk/Skipped:

WebKit/gtk

Reviewed by Jan Alonzo.

[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551

Provide a simple, coordinates-based API to start the inspector.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage): Use files from the source tree when running from the top of the source directory. (WebKit::InspectorClient::localizedStringsURL): Ditto.
webkit/webkitprivate.h:
webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_coordinates): (webkit_web_inspector_close): (webkit_web_inspector_execute_script):
webkit/webkitwebinspector.h:

WebKitTools

Reviewed by Jan Alonzo.

[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551

Use the new inspector API to implement the LayoutTestController
interfaces used to test the inspector.

DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorInspectWebView): (createWebView):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):

3:42 PM Changeset in webkit [50244] by kov@webkit.org

4 edits in trunk

LayoutTests

Reviewed by Xan Lopez.

[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440

Unskip the test that now passes.

platform/gtk/Skipped:

WebCore

Reviewed by Xan Lopez.

[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440

Reimplement WebCore::defaultLanguage to account for changes in
locale done by setLocale.

Already existing test: fast/js/navigator-language.html

platform/gtk/Language.cpp: (WebCore::defaultLanguage):

3:40 PM Changeset in webkit [50243] by sfalken@apple.com

5 edits
1 delete in trunk/WebKit/win

Should not generate/build COM DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=30880

Reviewed by Sam "Horatio" Weinig.

Interfaces/WebKit.idl: Remove generated interfaces.
WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.

3:36 PM Changeset in webkit [50242] by eric.carlson@apple.com

10 edits in trunk

2009-10-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::documentWillBecomeInactive):

Exit from fullscreen if necessary.

html/HTMLMediaElement.h:

2009-10-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.

WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController _requestExit]):

New, call media element's exitFullscreen method.

(-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):

Call mediaElement->exitFullscreen() after a delay as it turns around and calls
WebVideoFullscreenController:exitFullscreen.

WebView/WebVideoFullscreenHUDWindowController.h:
WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow resignFirstResponder]):

New, don't give up responder status.

(-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):

New, block all command key events.

(-[WebVideoFullscreenHUDWindowController exitFullscreen:]):

Remember when we are in the process of exiting fullscreen, don't allow recursion.

WebView/WebView.mm: (-[WebView _exitFullscreen]):

Early return if fullscreen controller is nil.

WebView/WebWindowAnimation.h:

Correct comment about _window retain status.

WebView/WebWindowAnimation.m: (-[WebWindowScaleAnimation dealloc]):

Don't release _window, we never reatained it.

3:19 PM Changeset in webkit [50241] by hamaji@chromium.org

5 edits in trunk

2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882

Api/qwebframe.cpp: (qt_drt_counterValueForElementById):
Api/qwebframe.h:

2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById):

2:45 PM Changeset in webkit [50240] by ap@apple.com

2 edits in trunk/WebCore

Unreviewed - a trivial fix to get Windows bots running.

https://bugs.webkit.org/show_bug.cgi?id=30841
<rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site

platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to access empty vector's data.

2:44 PM Changeset in webkit [50239] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2009-10-28 Afonso R. Costa Jr. <afonso.costa@openbossa.org>

Reviewed by Oliver Hunt.

[Qt] Enable YARR when YARR_JIT is enabled
https://bugs.webkit.org/show_bug.cgi?id=30730

When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should
be toggled also.

JavaScriptCore.pri:

2:36 PM Changeset in webkit [50238] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

Remove the extraneous object of ROLE_PANEL.

accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):

2:29 PM Changeset in webkit [50237] by eric@webkit.org

3 edits
4 adds in trunk

2009-10-28 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.

Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547

fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
fast/css/text-input-with-webkit-border-radius-expected.png: Added.
fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
fast/css/text-input-with-webkit-border-radius.html: Added.

2009-10-28 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.

Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547

Test: fast/css/text-input-with-webkit-border-radius.html

rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): Implemented rounded border rendering in Chromium Windows theme renderer.

2:17 PM Changeset in webkit [50236] by pfeldman@chromium.org

7 edits in trunk/WebCore

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Pull items collections from resources panel and
timeline panel into AbstractTimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30875

inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement): (WebInspector.AbstractTimelinePanel.prototype.createItemGraph): (WebInspector.AbstractTimelinePanel.prototype._showCategory): (WebInspector.AbstractTimelinePanel.prototype._hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.reset): (WebInspector.AbstractTimelinePanel.prototype.get calculator): (WebInspector.AbstractTimelinePanel.prototype.set calculator): (WebInspector.AbstractTimelinePanel.prototype.addItem): (WebInspector.AbstractTimelinePanel.prototype.removeItem): (WebInspector.AbstractTimelinePanel.prototype.refreshItem): (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem): (WebInspector.AbstractTimelinePanel.prototype.sortItems): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelineCategory): (WebInspector.AbstractTimelineCategory.prototype.toString):
inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.createItemTreeElement): (WebInspector.ResourcesPanel.prototype.createItemGraph): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction): (WebInspector.ResourcesPanel.prototype.searchMatchFound): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype.refresh): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.removeResource): (WebInspector.ResourcesPanel.prototype.addMessageToResource): (WebInspector.ResourcesPanel.prototype.clearMessages): (WebInspector.ResourcesPanel.prototype.refreshResource): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourceTimeCalculator.prototype._upperBound):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype.createItemTreeElement): (WebInspector.TimelinePanel.prototype.createItemGraph): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineCategory):
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:

2:05 PM Changeset in webkit [50235] by kenneth@webkit.org

2 edits in trunk/WebKitTools

Rubberstamped by Oliver Hunt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Fix the warning:

"warning: ignoring return value of 'char* getcwd(char*, size_t)',
declared with attribute warn_unused_result".

by actually checking the result. In the case it is null, an
error has occoured, so treat it as the other fatal errors.

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::initializeFonts):

1:45 PM Changeset in webkit [50234] by eric@webkit.org

4 edits in trunk/WebCore

2009-10-28 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so
that it remains active on refreshs and page transitions.
https://bugs.webkit.org/show_bug.cgi?id=30874

inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
inspector/InspectorTimelineAgent.h:

1:14 PM Changeset in webkit [50233] by hamaji@chromium.org

28 edits
2 adds
8 deletes in trunk

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Api/qwebframe.cpp: (QWebFrame::counterValueForElementById): (QWebHitTestResult::frame):
Api/qwebframe.h:

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

webkit/webkitprivate.h:
webkit/webkitwebframe.cpp: (webkit_web_frame_counter_value_for_element_by_id):

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp: (WebFrame::counterValueForElementById):
WebFrame.h:

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Add counterValueForElement in WebFrame to call WebCore::counterValueForElement.

Misc/WebCoreStatistics.h:
Misc/WebCoreStatistics.mm: (-[WebFrame counterValueForElement:]):

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Expose WebCore::counterValueForElement as a WebCore API.

WebCore.base.exp:
rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):
rendering/RenderTreeAsText.h:

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Convert two pixel tests to dumpAsText tests using counterValueForElementById.

fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
fast/css/counters/t1204-increment-00-c-o.html:
fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
fast/css/counters/t1204-increment-01-c-o.html:
platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Removed.
platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Removed.
platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Removed.
platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Removed.
platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.

2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555

Define layoutTestContoller.counterValueForElementById.

DumpRenderTree/LayoutTestController.cpp: (counterValueForElementByIdCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::counterValueForElementById):

1:07 PM Changeset in webkit [50232] by oliver@apple.com

2 edits in trunk/JavaScriptCore

2009-10-24 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Oliver Hunt.

Fix strict aliasing warning by switching reinterpret_cast to bitwise_cast.

strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869

runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::scopeChain): (JSC::JSFunction::setScopeChain): (JSC::JSFunction::setNativeFunction):

12:57 PM Changeset in webkit [50231] by Nate Chapin

2 edits in trunk/WebCore

2009-10-28 Nate Chapin <Nate Chapin>

Unreviewed, Chromium build fix for r50225.

loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):

12:52 PM Changeset in webkit [50230] by eric@webkit.org

8 edits in trunk/WebCore

2009-10-28 Eric Z. Ayers <zundel@google.com>

Reviewed by Pavel Feldman.

Adds InspectorTimelineAgent instrumentation for encountering a
<SCRIPT> tag when parsing an HTML document.

https://bugs.webkit.org/show_bug.cgi?id=30861

bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::url):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willScriptTag): (WebCore::InspectorTimelineAgent::didScriptTag):
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:

12:23 PM Changeset in webkit [50229] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-28 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Makes sure that Geolocation watch IDs remain positive on overflow.
https://bugs.webkit.org/show_bug.cgi?id=30122

No new tests possible.

page/Geolocation.cpp: Modified. (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow.

12:03 PM Changeset in webkit [50228] by staikos@webkit.org

2 edits in trunk/WebCore

2009-10-28 George Staikos <george.staikos@torchmobile.com>

Attempt to fix the Mac debug build after 50225.

loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):

11:35 AM Changeset in webkit [50227] by bweinstein@apple.com

1 edit in trunk/WebKit/win/WebFrame.cpp

Windows build fix, add missing #include.

11:15 AM Changeset in webkit [50226] by ap@apple.com

8 edits
8 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30841
<rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site

Tests: http/tests/ssl/referer-301.html

http/tests/ssl/referer-303.html

platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Remove Referer header if redirecting from https to another protocol.

platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is always done when changing or adding header fields. (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto.

platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are no longer inline, since they have non-trivial implementations.

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals. (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Match Mac changes.

11:12 AM Changeset in webkit [50225] by staikos@webkit.org

7 edits in trunk

2009-10-28 Joe Mason <jmason@rim.com>

Reviewed by Adam Treat.

Add FrameLoader::defaultObjectContentType, containing common code for
implementing FrameLoaderClient::objectContentType. (Currently the gtk
and win ports have copied this code, and the qt port uses similar code
with a few extra clauses. Moving this to a utility function cuts down
on copied code.) This causes no behavioural change.

https://bugs.webkit.org/show_bug.cgi?id=30868

11:00 AM Changeset in webkit [50224] by kenneth@webkit.org

5 edits in trunk

[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.

WebCore:

Enforce the versioning, by ignoring any version different
from 1.

history/qt/HistoryItemQt.cpp:

(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):

WebKit/qt:

Make the versioning internal and enforce it in the WebCore
part. Adjust the comments, as well as remove now dead code.

Api/qwebhistory.cpp:

(operator<<):
(operator>>):

Api/qwebhistory.h:

10:10 AM Changeset in webkit [50223] by eric@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-10-28 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Added special expected test result for Tiger to fix regression tests.
https://bugs.webkit.org/show_bug.cgi?id=30811

platform/mac-tiger/fast/js/navigator-language-expected.txt: Added.

10:09 AM Changeset in webkit [50222] by pfeldman@chromium.org

2 edits in trunk/WebCore

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up fix to InspectorControllerStub.
Define it after inspector.js due to namespace

https://bugs.webkit.org/show_bug.cgi?id=30866

inspector/front-end/inspector.html:

10:03 AM Changeset in webkit [50221] by pfeldman@chromium.org

5 edits
1 add in trunk/WebCore

2009-10-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add InspectorController stub in order to
support opening in standalone mode.

https://bugs.webkit.org/show_bug.cgi?id=30866

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/InspectorControllerStub.js: Added. (.WebInspector.InspectorControllerStub):

10:02 AM Changeset in webkit [50220] by eric@webkit.org

9 edits in trunk/WebCore

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

Expands upon the new funtionality which allows platforms to indicate
that a particular object should not be ignored, so that they can
specify that an object should be ignored or that it should be left up
to the default handling to decide.

accessibility/AccessibilityObject.h:
accessibility/chromium/AccessibilityObjectChromium.cpp:
accessibility/gtk/AccessibilityObjectAtk.cpp:
accessibility/mac/AccessibilityObjectMac.mm:
accessibility/qt/AccessibilityObjectQt.cpp:
accessibility/win/AccessibilityObjectWin.cpp:
accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):

9:53 AM Changeset in webkit [50219] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

Expose the table summary as the accessible description because there is no summary object.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_description):

9:14 AM Changeset in webkit [50218] by vestbo@webkit.org

2 edits in trunk/JavaScriptCore

Use JSVALUE64 on 64-bit Windows

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-10-28
Reviewed by Tor Arne Vestbø.

wtf/Platform.h: Make sure WTF_USE_JSVALUE64 is defined

8:10 AM Changeset in webkit [50217] by tonikitoo@webkit.org

1 edit
2 adds in trunk/WebKit/qt

Pushing missing WebKit/qt/tests/qwebframe/resources/ dir from bug 29248.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-28
[Qt] [API] Make it possible to have 'invisible' loads
https://bugs.webkit.org/show_bug.cgi?id=29248

tests/qwebframe/resources/image2.png: Copied from WebKit/qt/tests/qwebelement/image.png.

6:54 AM Changeset in webkit [50216] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Rubber-stamped by Holger Freyther.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-28
[Qt] Remove http/tests/security tests from
skiplist, and add only now failing tests.

platform/qt/Skipped:

6:54 AM Changeset in webkit [50215] by steveblock@google.com

7 edits in trunk/WebCore

Adds ScriptController::intializeThreading(), with both JSC and V8 implementations.
https://bugs.webkit.org/show_bug.cgi?id=30678

Reviewed by Eric Seidel.

This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly.

Build fix, no new tests required.

bindings/js/ScriptController.cpp: Modified.

(WebCore::ScriptController::initializeThreading): Added.

bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
bindings/v8/ScriptController.cpp: Modified.

(WebCore::ScriptController::initializeThreading): Added.

bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
loader/icon/IconDatabase.cpp: Modified.

(WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().

storage/Database.cpp: Modified.

(WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().

6:18 AM Changeset in webkit [50214] by kenneth@webkit.org

4 edits in trunk/WebKit/qt

[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Holger Freyther.

Remove the QWebHistory::saveState() and ::restoreState() as
they are inconsistent with the Qt API.

Update unittests to reflect the change.

Api/qwebhistory.cpp:

(operator<<):
(operator>>):

Api/qwebhistory.h:
tests/qwebhistory/tst_qwebhistory.cpp:

(saveHistory):
(restoreHistory):
(tst_QWebHistory::saveAndRestore_crash_1):
(tst_QWebHistory::saveAndRestore_crash_2):
(tst_QWebHistory::saveAndRestore_crash_3):
(tst_QWebHistory::clear):

4:44 AM Changeset in webkit [50213] by zecke@webkit.org

3 edits in trunk/WebCore

Document a feature of the m_liveDecodedResources list.

https://bugs.webkit.org/show_bug.cgi?id=30209
Reviewed by Darin Adler.

Document a feature of the m_liveDecodedResources list.
https://bugs.webkit.org/show_bug.cgi?id=30209

The code made the assumption that the list is sorted by
the m_lastDecodedAccessTime property of the CachedResource.
The above is not true when CachedResource::setDecodedSize
is called and the item is inserted the first time. In this
case the m_lastDecodedAccessTime is still zero and the
m_liveDecodedResources list becomes unsorted.

It is impossible that Cache::pruneLiveResources will
stop to process the list too early due this feature and
the alternatives of updating m_lastDecodedAccessTime in
CachedResource::setDecodedSize or changing the insert
to search the right position have a negative impact on
performance. The best solution for now is to document
this feature.

loader/Cache.cpp:

(WebCore::Cache::pruneLiveResources):

loader/CachedResource.cpp:

(WebCore::CachedResource::setDecodedSize):

4:24 AM Changeset in webkit [50212] by zecke@webkit.org

2 edits in trunk/WebKit/win

Speculative build-fix for WebElementPropertyBag.cpp

WebElementPropertyBag.cpp: Include RenderObject.h

4:06 AM Changeset in webkit [50211] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

jit/JIT.h:

Reviewed by NOBODY (build fix!).

4:05 AM Changeset in webkit [50210] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Remove http/tests/misc tests from
skiplist, and add only now failing tests.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-28

platform/qt/Skipped:

3:23 AM Changeset in webkit [50209] by tonikitoo@webkit.org

2 edits in trunk/WebKit/qt

Complementary fix to bug 30779.

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Holger Freyther.

By mistake I used QWeakPointer's toStrongRef() method which docs
explicitly say to not be used in this situation (when the tracked
pointer is devired from QObject). Instead QWeakPointer's data()
is recommended.

Api/qwebpage.cpp:

(QWebPage::view):

3:18 AM Changeset in webkit [50208] by xan@webkit.org

4 edits in trunk

WebCore:

2009-10-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Make text controls always implement the text interface, and the
editable text interface when they are not read only. This is what
ATK-users expect.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject):

WebKit/gtk:

2009-10-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Update test to also check that entries implement the AtkText
interface.

tests/testatk.c: (run_get_text_tests): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset): (main):

3:16 AM Changeset in webkit [50207] by zecke@webkit.org

7 edits in trunk

Fix assertion in SVGRenderBase::mapLocalToContainer resulting from HitTestResult::boundinBox()

https://bugs.webkit.org/show_bug.cgi?id=27347

The current HitTestResult methods are not using the (3d)
transformation aware routines. This can lead to an assertion
SVGRenderBase::mapLocalToContainer method.

Remove HitTestResult::boundingBox() as it is only used in
two places and conceptually doesn't belong into a HitTest
which is operating on points. Update the Qt and Win code
to determine the rect themselves in a (3d) transformation
fashion.

Change HitTestResult::imageRect to use the (3d) transformation
aware RenderBox::absoluteContentQuad to avoid running into
an assertion with SVG content.

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::imageRect):

rendering/HitTestResult.h:

WebElementPropertyBag.cpp:

(WebElementPropertyBag::Read):

Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

3:16 AM Changeset in webkit [50206] by zecke@webkit.org

2 edits in trunk/WebCore

[Qt] Custom Cursor doesn't use hotspot.

Cursors loaded from a QPixmap didn't specifiy the
hotspot. Take the hotspot values from the mac
implementation.

platform/qt/CursorQt.cpp:

3:16 AM Changeset in webkit [50205] by zecke@webkit.org

2 edits in trunk

Export fastMalloc, fastCalloc, fastRealloc and fastFree

Export the FastMalloc functions outside of the libwebkit library
to be able to instrument memory allocations. These are C++ symbols
but do not require the C++ runtime to be useful and should be of
no harm to plain C code.

autotools/symbols.filter:

3:14 AM Changeset in webkit [50204] by zecke@webkit.org

2 edits in trunk/JavaScriptCore

Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix

https://bugs.webkit.org/show_bug.cgi?id=30769

When using -fvisibility=hidden to hide all internal symbols by default
the malloc symbols will be hidden as well. For memory instrumentation
it is needed to provide an instrumented version of these symbols and
override the normal routines and by changing the visibility back to
default this becomes possible.

The only other solution would be to use system malloc instead of the
TCmalloc implementation but this will not allow to analyze memory
behavior with the default allocator.

wtf/FastMalloc.h: Define WTF_FAST_MALLOC_EXPORT for GCC and !darwin

2:59 AM Changeset in webkit [50203] by pfeldman@chromium.org

8 edits
9 adds in trunk/WebCore

2009-10-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by NOBODY (OOPS!).

Web Inspector: Initial revision of the Timeline grid.

https://bugs.webkit.org/show_bug.cgi?id=30834

English.lproj/localizedStrings.js:
WebCore.gypi:
inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelineCalculator):
inspector/front-end/Images/timelineBarBlue.png: Added.
inspector/front-end/Images/timelineBarGray.png: Added.
inspector/front-end/Images/timelineBarGreen.png: Added.
inspector/front-end/Images/timelineBarOrange.png: Added.
inspector/front-end/Images/timelineBarPurple.png: Added.
inspector/front-end/Images/timelineBarRed.png: Added.
inspector/front-end/Images/timelineBarYellow.png: Added.
inspector/front-end/Images/timelineCheckmarks.png: Added.
inspector/front-end/Images/timelineDots.png: Added.
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator):
inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.showCategory): (WebInspector.TimelinePanel.prototype.hideCategory): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.get graphElement): (WebInspector.TimelineGraph.prototype.refreshLabelPositions): (WebInspector.TimelineGraph.prototype.refresh):
inspector/front-end/inspector.css:

12:48 AM Changeset in webkit [50202] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Put tests into skiplist added in r50168 and r50162 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-28
Reviewed by Holger Freyther.

platform/qt/Skipped:

inspector/console-format-collections.html added
inspector/javascript-syntax-highlight.html added

12:13 AM Changeset in webkit [50201] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

Rubber Stamped by Samuel Q. Weinig.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-27
Make the asserts protecting the offsets in the JIT more descriptive.

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):

Oct 27, 2009:

11:50 PM Changeset in webkit [50200] by mitz@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

Changed this test to use -webkit-box-shadow instead of box-shadow after r49003.

fast/box-shadow/inset.html:

11:43 PM Changeset in webkit [50199] by Joseph Pecoraro

5 edits in trunk

2009-10-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Move runAfterPendingDispatches to TestController for Clarity
https://bugs.webkit.org/show_bug.cgi?id=30844

inspector/front-end/TestController.js: (WebInspector.TestController.prototype.runAfterPendingDispatches):
inspector/front-end/inspector.js: moved runAfterPendingDispatches

10:19 PM Changeset in webkit [50198] by darin@chromium.org

2 edits in trunk/WebCore

2009-10-27 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add missing forward declaration of FramelessScrollView.
https://bugs.webkit.org/show_bug.cgi?id=30824

platform/chromium/FramelessScrollViewClient.h:

8:44 PM Changeset in webkit [50197] by Chris Fleizach

2 edits in trunk/LayoutTests

No review.

ARIA menu/menu item need AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=30804

Layout test fix for Tiger/Leopard.

platform/mac-leopard/accessibility/table-with-aria-role-expected.txt:

8:39 PM Changeset in webkit [50196] by Chris Fleizach

4 edits
2 adds in trunk

WAI-ARIA: add support for 'presentation' role
https://bugs.webkit.org/show_bug.cgi?id=30806

Reviewed by Adele Peterson.

WebCore:

Test: accessibility/aria-presentational-role.html

accessibility/AccessibilityObject.h:

(WebCore::):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::RoleEntry::):

LayoutTests:

accessibility/aria-presentational-role-expected.txt: Added.
accessibility/aria-presentational-role.html: Added.

7:56 PM Changeset in webkit [50195] by Chris Fleizach

4 edits
2 adds in trunk

ARIA menu/menu item need AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=30804

Reviewed by Darin Adler.

WebCore:

Make sure that role descriptions will default to the system's first, before
returning an unknown role.

Test: platform/mac/accessibility/aria-menu-role-descriptions.html

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper roleDescription]):

LayoutTests:

platform/mac/accessibility/aria-menu-role-descriptions-expected.txt: Added.
platform/mac/accessibility/aria-menu-role-descriptions.html: Added.
platform/mac/accessibility/table-with-aria-role-expected.txt:

7:20 PM Changeset in webkit [50194] by ggaren@apple.com

2 edits in trunk/WebCore

Qt build fix: migrated away from API that no longer exists.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

6:37 PM Changeset in webkit [50193] by ggaren@apple.com

2 edits in trunk/WebCore

Qt build fix: migrated away from API that no longer exists.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

6:30 PM Changeset in webkit [50192] by oliver@apple.com

2 edits in trunk/WebCore

Fix wording in comment.

6:26 PM Changeset in webkit [50191] by oliver@apple.com

2 edits in trunk/WebCore

Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807

Reviewed by Darin Adler.

We allocate an autorelease pool but then store it off the stack. In a
GC environment this led to it being collected, and thus caused badness
to ensue. To work around this we simply avoid using a pool at all in
a GC environment as it would be a no-op anyway.

6:07 PM Changeset in webkit [50190] by eric@webkit.org

9 edits
6 adds in trunk

2009-10-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

When a Geolocation method is called, immediately calls the error calback asynchronously if permissions have already been denied.
https://bugs.webkit.org/show_bug.cgi?id=27944.

fast/dom/Geolocation/resources/permission-denied-already-error.js: Added. Tests that when permission has already been denied, the error callback is invoked with code PERMISSION_DENIED, when the Geolocation service reports an error.
fast/dom/Geolocation/permission-denied-already-error.html: Added. Wrapper for above test.
fast/dom/Geolocation/permission-denied-already-error-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied-already-success.js: Added. Tests that when permission has already been denied, the error callback is invoked with code PERMISSION_DENIED, when the Geolocation service has a good position fix.
fast/dom/Geolocation/permission-denied-already-success.html: Added. Wrapper for above test.
fast/dom/Geolocation/permission-denied-already-success-expected.txt: Added. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied.js: Modified. Updates error string.
fast/dom/Geolocation/permission-denied-expected.txt: Modified. Expected result for above test.
fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Updates error string.
fast/dom/Geolocation/permission-denied-expected-stops-watches.txt: Modified. Expected result for above test.
platform/gtk/Skipped: Modified. Adds above tests to skipped list.

2009-10-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

When a Geolocation method is called, immediately calls the error calback asynchronously if permissions
have already been denied.
https://bugs.webkit.org/show_bug.cgi?id=27944.

Tests: fast/dom/Geolocation/permission-denied-already-error.html

fast/dom/Geolocation/permission-denied-already-success.html

page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. GeoNotifier takes Geolocation object as constructor argument. (WebCore::Geolocation::GeoNotifier::setFatalError): Added. Sets a fatal error for this notifier, causing it to terminate immediately and call the error callback asynchronously. (WebCore::Geolocation::GeoNotifier::timerFired): Added. Used to call the error callback asynchronously on fatal error. (WebCore::Geolocation::getCurrentPosition): Modified. Calls startRequest. (WebCore::Geolocation::watchPosition): Modified. Calls startRequest. (WebCore::Geolocation::startRequest): Added. Common functionality for starting a one-shot or watch request. Sets a fatal error on the notifier if permissions have already been denied. (WebCore::Geolocation::fatalErrorOccurred): Added. Registers that a notifier has encountered a fatal error and should be destroyed. (WebCore::Geolocation::setIsAllowed): Modified. Uses a standard error message for the error callback when permissions are denied.
page/Geolocation.h: Modified. (WebCore::Geolocation::isDenied): Added. Determines whether permissions have been denied.

5:58 PM Changeset in webkit [50189] by mrowe@apple.com

4 edits in branches/safari-4-branch

Versioning.

5:58 PM Changeset in webkit [50188] by mrowe@apple.com

1 copy in tags/Safari-6531.21.6

New tag.

5:57 PM Changeset in webkit [50187] by mrowe@apple.com

3 edits
2 adds in branches/safari-4-branch

Merge r50165.

5:21 PM Changeset in webkit [50186] by Simon Fraser

2 edits in trunk/WebCore

2009-10-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Oliver Hunt.

Fixed a bug where I was using the wrong Canvas pointer to do a cross-domain check
https://bugs.webkit.org/show_bug.cgi?id=30840

html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):

5:18 PM Changeset in webkit [50185] by eric@webkit.org

3 edits
2 adds in trunk

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
https://bugs.webkit.org/show_bug.cgi?id=29620

svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Added.
svg/dom/getPresentationAttribute-cache-corruption.svg: Added.

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
https://bugs.webkit.org/show_bug.cgi?id=29620

SVG was modifying CSSValues cached of off CSSMappedAttributeDeclarations.
This patch fixes the check to make sure that a new CSSMappedAttributeDeclaration is
created before returning a CSSValue that JavaScript can modify.

Test: svg/dom/getPresentationAttribute-cache-corruption.svg

svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):

4:32 PM Changeset in webkit [50184] by mitz@apple.com

5 edits
4 adds in trunk

Incomplete repaint of text field in relative positioned inline at imdb.com
https://bugs.webkit.org/show_bug.cgi?id=30047

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/inline-relative-positioned.html

Implemented offsetFromContainer(), mapLocalToContainer() and
mapAbsoluteToLocalPoint() in RenderInline.

rendering/RenderBox.h: Fixed argument names in the declaration of

mapLocalToContainer().

rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::mapAbsoluteToLocalPoint):

rendering/RenderInline.h:

LayoutTests:

fast/repaint/inline-relative-positioned-expected.checksum: Added.
fast/repaint/inline-relative-positioned-expected.png: Added.
fast/repaint/inline-relative-positioned-expected.txt: Added.
fast/repaint/inline-relative-positioned.html: Added.

4:29 PM Changeset in webkit [50183] by ggaren@apple.com

9 edits in trunk

JavaScriptCore: A little bit of refactoring in the date code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Sam Weinig.

JavaScriptCore.exp: Don't export this unused symbol.

runtime/DateConstructor.cpp:

(JSC::constructDate):

runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):

runtime/DateInstance.h: Removed some unused functions. Changed the default

constructor to ensure that a DateInstance is always initialized.

runtime/DatePrototype.cpp:

(JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
since it now requires one.

wtf/DateMath.cpp:

(WTF::msToGregorianDateTime): Only compute our offset from UTC if our
output will require it. Otherwise, our offset is 0.

WebKit/mac: Updated for refactoring in the date code.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Sam Weinig.

WebView/WebView.mm:

(aeDescFromJSValue): Since we just want a number of milliseconds, do that
instead of something more complicated.

4:22 PM Changeset in webkit [50182] by jorlow@chromium.org

2 edits in trunk/WebCore

Speculative build fix for Chromium.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-10-27

platform/graphics/GraphicsContext3D.h:

3:41 PM Changeset in webkit [50181] by cmarrin@apple.com

9 edits in trunk/WebCore

Make WebGL context failure more robust and make it succeed in more cases
https://bugs.webkit.org/show_bug.cgi?id=30349

Bubble a failure to get a CGLContext up to HTMLContextElement so it can
return null from getContext. Also added a more robust pixel format choosing
mechanism and can render correctly when a SW renderer is chosen.

3:20 PM Changeset in webkit [50180] by ggaren@apple.com

1 edit
1 add in trunk/WebCore

Mac build fix: a forwarding header.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

ForwardingHeaders/wtf/DateInstanceCache.h: Added.

3:12 PM Changeset in webkit [50179] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: Mark DateInstaceCache.h private, so other frameworks can see it.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

JavaScriptCore.xcodeproj/project.pbxproj:

3:09 PM Changeset in webkit [50178] by ggaren@apple.com

1 edit
1 add in trunk/JavaScriptGlue

Build fix: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

ForwardingHeaders/wtf/DateInstanceCache.h: Added.

3:09 PM Changeset in webkit [50177] by rniwa@webkit.org

2 edits in trunk/WebCore

No Review.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-27
Making fontWeightIsBold static to fix Snow Leopard build.

editing/ApplyStyleCommand.cpp:

(WebCore::fontWeightIsBold):

3:04 PM Changeset in webkit [50176] by eric@webkit.org

3 edits in trunk/LayoutTests

2009-10-27 Kinuko Yasuda <kinuko@google.com>

Reviewed by Darin Adler.

Fixing a test case that yields FAIL results. Also updating
the corresponding expected results.
https://bugs.webkit.org/show_bug.cgi?id=30821

storage/domstorage/complex-values-expected.txt:
storage/domstorage/script-tests/complex-values.js:

3:04 PM Changeset in webkit [50175] by ggaren@apple.com

1 edit
1 add in trunk/JavaScriptCore

Build fix: re-readded this file.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27

runtime/DateInstanceCache.h: Added.

(JSC::DateInstanceData::create):
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::add):
(JSC::DateInstanceCache::lookup):

3:01 PM Changeset in webkit [50174] by ggaren@apple.com

10 edits
1 add in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=30800
Cache recently computed date data.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Darin Adler and Oliver Hunt.

SunSpider reports a ~0.5% speedup, mostly from date-format-tofte.js.

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj: Added new file.

runtime/DateInstance.cpp:

(JSC::DateInstance::DateInstance):
(JSC::DateInstance::getGregorianDateTime): Use the shared cache.

runtime/DateInstance.h: Renamed m_cache to m_data, to avoid the confusion

of a "cache cache".

runtime/DatePrototype.cpp:

runtime/JSGlobalData.h: Keep a DateInstanceCache.

JavaScriptGlue: Updated for JavaScriptCore export changes.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-27
Reviewed by Oliver Hunt.

ForwardingHeaders/wtf/DateMath.h: Added.

2:51 PM Changeset in webkit [50173] by darin@chromium.org

3 edits in trunk/JavaScriptCore

2009-10-27 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.

Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.

https://bugs.webkit.org/show_bug.cgi?id=30833

JavaScriptCore.gyp/JavaScriptCore.gyp:
wtf/CurrentTime.cpp:

2:50 PM Changeset in webkit [50172] by rniwa@webkit.org

5 edits in trunk

WebKit cannot remove nested bold tags
https://bugs.webkit.org/show_bug.cgi?id=30784

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-27
Reviewed by Eric Seidel.

WebCore:

This patch modifies getPropertiesNotInComputedStyle so that it compares font-weight
more flexibly. Instead of comparing cssText, it uses fontWeightIsBold which converts
all font weights to either bold or unbold state.

editing/ApplyStyleCommand.cpp:

(WebCore::fontWeightIsBold):
(WebCore::getPropertiesNotInComputedStyle): Removes font-weight property
if two style have the same value under getFontWeightValue

LayoutTests:

Adds two more edge cases to remove-nested-inline-styles.js:
<b><b><b>12</b></b></b> and <b><b><b>1</b></b>2</b>
WebKit now passes the one existing test used to fail.

editing/style/remove-nested-inline-styles-expected.txt: Added two tests.
editing/style/script-tests/remove-nested-inline-styles.js: Added two tests.

2:04 PM Changeset in webkit [50171] by eric@webkit.org

2 edits in trunk

2009-10-27 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

Give an ability to WebKit to free statically allocated pointers
before quit.
https://bugs.webkit.org/show_bug.cgi?id=27980

No new tests for this as the change does not affect WebKit
functionality, but only memory usage.

JavaScriptCore/wtf/StdLibExtras.h: Allowed for the override of DEFINE_STATIC_LOCAL via compiler commandline options or elsewhere in the code. Useful for implementing custom builds that free resources allocated via DEFINE_STATIC_LOCAL.

2:02 PM WebKit Team edited by Joseph Pecoraro

Added Myself (diff)

1:42 PM Changeset in webkit [50170] by dumi@chromium.org

2 edits in trunk/WebCore

Build fix, no review needed.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-27
Fixing the BUILD. m_estimatedSize in Database.h should be of type
'unsigned long' instead of 'unsigned long long'.

No tests required.

storage/Database.h:

1:14 PM Changeset in webkit [50169] by dumi@chromium.org

9 edits in trunk/WebCore

Refactoring the Database class to not depend on
OriginQuotaManager. Also, adding a SecurityOrigin copy to each
Database instance, that is safe to use on the file
thread. Finally, adding new simple fields and getters to the
Database object for storing/getting the display name and estimated
size specified by the user in the openDatabase() call.

Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-10-27
Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=30548

page/SecurityOrigin.h:
storage/Database.cpp:

(WebCore::Database::openDatabase): Storing the display name and
the estimated size in the Database object.
(WebCore::Database::Database): Storing the display name and the
estimated size in the Database object, as well as a SecurityOrigin
instance that is safe to use on the DB thread.
(WebCore::Database::maximumSize): Delegate the call to
DatabaseTracker::getMaxSizeForDatabase().
(WebCore::Database::databaseThreadSecurityOrigin): Return the
SecurityOrigin instance that's safe to use on the DB thread.
(WebCore::Database::threadSafeSecurityOrigin): Return the
SecurityOrigin instance that's safe to use on the current thread.
(WebCore::Database::displayName): Return the display name
specified by the user in the openDatabase() call.
(WebCore::Database::estimatedSize): Return the estimated size
specified by the user in the openDatabase() call.
(WebCore::Database::fileName): Return the name of the file where
the current Database is tored.

storage/Database.h:
storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase): Returns the
maximum size for a DB file based on the current size of that file
and the space available for that origin.

storage/DatabaseTracker.h:
storage/SQLTransaction.cpp:
storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitTransaction): Use the
correct SecurityOrigin instance.

12:37 PM Changeset in webkit [50168] by Joseph Pecoraro

5 edits
2 adds in trunk

2009-10-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList
https://bugs.webkit.org/show_bug.cgi?id=30709

Test: inspector/console-format-collections.html

inspector/front-end/InjectedScript.js: (Object.type): check for instances of HTMLCollection like we do for NodeList
inspector/front-end/inspector.js: added WebInspector.pendingDispatches counter (WebInspector.dispatch): increment and decrement dispatch counter (WebInspector.runAfterPendingDispatches): run when there are no more dispatches

12:30 PM Changeset in webkit [50167] by eric@webkit.org

7 edits in trunk/WebCore

2009-10-27 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds XMLHttpRequest support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30578

inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR):
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeTimelineRecord): (WebCore::TimelineRecordFactory::createXHRLoadTimelineRecord):
inspector/TimelineRecordFactory.h:
inspector/front-end/TimelineAgent.js:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):

12:23 PM Changeset in webkit [50166] by kenneth@webkit.org

6 edits in trunk

Rubberstamped by Oliver Hunt.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Change two methods to be internal for DRT use only.

Part of [Qt] Review all new API in Qt 4.6
https://bugs.webkit.org/show_bug.cgi?id=29843#c11

WebKit/qt:

Api/qwebsecurityorigin.cpp:

(qt_drt_whiteListAccessFromOrigin):
(qt_drt_resetOriginAccessWhiteLists):
(QWebSecurityOrigin::localSchemes):

Api/qwebsecurityorigin.h:

WebKitTools:

DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::whiteListAccessFromOrigin):

11:54 AM Changeset in webkit [50165] by adele@apple.com

3 edits
2 adds in trunk

WebCore: REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up
extends the top of the selection upwards (but should shrink the selection instead)
<rdar://problem/7269075>
https://bugs.webkit.org/show_bug.cgi?id=29981

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-27
Reviewed by Adele Peterson.

editing/SelectionController.cpp:

(WebCore::SelectionController::modify): Added setting m_lastChangeWasHorizontalExtension.

LayoutTests: Test for <rdar://problem/7269075> REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up
extends the top of the selection upwards (but should shrink the selection instead)
https://bugs.webkit.org/show_bug.cgi?id=29981

editing/selection/shrink-selection-after-shift-pagedown-expected.txt: Added.
editing/selection/shrink-selection-after-shift-pagedown.html: Added.

11:45 AM Changeset in webkit [50164] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Make sure that initiating a rotation while rotating won't make
it end up at rotation positions that are not a multiply of
180 degrees.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Reviewed by Tor Arne Vestbø.

QGVLauncher/main.cpp:

(MainView::animatedFlip):

11:37 AM Changeset in webkit [50163] by bweinstein@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Tim Hatcher.

Removed an extra console.log from ElementsTreeOutline.

inspector/front-end/ElementsTreeOutline.js:

11:26 AM Changeset in webkit [50162] by timothy@apple.com

4 edits
2 adds in trunk

WebCore: Rewrote JavaScriptSourceSyntaxHighlighter to be more accurate
https://bugs.webkit.org/show_bug.cgi?id=27147

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-27
Reviewed by Timothy Hatcher.

Tests: LayoutTests/inspector/javascript-syntax-highlight.html

inspector/front-end/ElementsTreeOutline.js:
inspector/front-end/SourceFrame.js:

(WebInspector.JavaScriptSourceSyntaxHighlighter.process): Added. Processes 100 tokens at a time.
(WebInspector.JavaScriptSourceSyntaxHighlighter.lex): Added. Scans for a token.
(WebInspector.JavaScriptSourceSyntaxHighlighter.appendNonToken): Added. Appends the non-token characters that lex ignored.
(WebInspector.JavaScriptSourceSyntaxHighlighter.syntaxHighlightNode): Added. To syntax highlight node in ElementsTreeOutline.

LayoutTests: Tests for JavaScript syntax highlighter.
https://bugs.webkit.org/show_bug.cgi?id=27147

Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-27
Reviewed by Timothy Hatcher.

inspector/javascript-syntax-highlight-expected.txt: Added.
inspector/javascript-syntax-highlight.html: Added.

11:21 AM Changeset in webkit [50161] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-27 Xan Lopez <xlopez@igalia.com>

Skip a few more tests that are failing on and off.

platform/gtk/Skipped:

11:03 AM Changeset in webkit [50160] by eric@webkit.org

3 edits
2 adds in trunk

2009-10-27 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Missing null check after string conversion in error reporting
https://bugs.webkit.org/show_bug.cgi?id=30774

Test case for toString conversion failure on an error object in
stack overflow situations. Test passes if it doesn't crash.

fast/dom/error-to-string-stack-overflow-expected.txt: Added.
fast/dom/error-to-string-stack-overflow.html: Added.

2009-10-27 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] Missing null check after string conversion in error reporting
https://bugs.webkit.org/show_bug.cgi?id=30774

Add null check after string conversion in error reporting code.
ToString conversion can fail for instance when an exception is
thrown during conversion.

Test: fast/dom/error-to-string-stack-overflow.html

bindings/v8/V8Utilities.cpp: (WebCore::reportException):

10:54 AM Changeset in webkit [50159] by steveblock@google.com

3 edits in trunk/WebCore

Use a pair of maps to store Geolocation watchers.
https://bugs.webkit.org/show_bug.cgi?id=29178

Reviewed by Darin Adler.

The pair of maps allows us to look up a watcher either by its ID or by its GeoNotifier object.
The ability to look up by a watcher by its GeoNotifier object will be required when implementing
Geolocation::fatalErrorOccurred. See https://bugs.webkit.org/show_bug.cgi?id=27944

page/Geolocation.cpp: Modified.

(WebCore::Geolocation::Watchers::set): Added. Adds a watcher with the given ID.
(WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by ID.
(WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by GeoNotifier object.
(WebCore::Geolocation::Watchers::clear): Added. Removes all watchers.
(WebCore::Geolocation::Watchers::isEmpty): Added. Determines if there are no watchers.
(WebCore::Geolocation::Watchers::getNotifiersVector): Added. Gets a vector of the GeoNotifier objects.
(WebCore::Geolocation::watchPosition): Modified. Rename watcher identifier static variable.
(WebCore::Geolocation::stopTimersForWatchers): Modified. Use Watchers::getNotifiersVector.
(WebCore::Geolocation::handleError): Modified. Use Watchers::getNotifiersVector.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Use Watchers::getNotifiersVector.

page/Geolocation.h: Modified. Adds Geolocation::Watchers class.

10:45 AM Changeset in webkit [50158] by jorlow@chromium.org

2 edits in trunk/WebCore

2009-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] DOM Storage runtime flag should default to on
https://bugs.webkit.org/show_bug.cgi?id=30828

The DOM Storage runtime flag was supposed to default to on. I accidentally
changed the logic to default to false when I moved the flag.

bindings/v8/RuntimeEnabledFeatures.cpp:

10:38 AM Changeset in webkit [50157] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: svn-apply exits(1) when applying a patch with a file add
https://bugs.webkit.org/show_bug.cgi?id=30826

Scripts/svn-apply:
- Add () around all system() calls.
- Use the correct system() == 0 or die instead of system() or die
- Add descriptive messages to all die statements.

10:35 AM Changeset in webkit [50156] by steveblock@google.com

2 edits in trunk/WebKitTools

Adds steveblock@google.com to list of committers.

Reviewed by NOBODY.

Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.

10:00 AM Changeset in webkit [50155] by eric@webkit.org

4 edits in trunk/WebCore

2009-10-27 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Dimitri Glazkov.

Fix crash found in chromium test_shell.
https://bugs.webkit.org/show_bug.cgi?id=30808

When WebSocket is deleted without close, webkit would crash
when it handles didClose.

Check scriptExecutionContext before post task for event.
Use WebSocketChannel::disconnect() instead of close() in WebSocket
destructor, so that WebSocketChannel should not call deleted WebSocket
back in didClose().
To make sure WebSocketChannel alive while it is processing WebSocket
protocol over SocketStreamHandle, ref() in connect() and deref() in
didClose().

websockets/WebSocket.cpp: (WebCore::WebSocket::~WebSocket): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):
websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::didReceiveData):
websockets/WebSocketChannel.h:

9:49 AM Changeset in webkit [50154] by mitz@apple.com

6 edits in trunk

JavaScriptGlue: Updated license

Reviewed by Darin Adler.

LICENSE:

WebCore: Updated Apple license

Reviewed by Darin Adler.

LICENSE-APPLE:

WebKit: Updated license

Reviewed by Darin Adler.

LICENSE:

9:43 AM Changeset in webkit [50153] by beidson@apple.com

5 edits in trunk

Rubberstamped by Sam Weinig.

Re-enable the check that disallows pages with unload handlers in the page cache.

<rdar://problem/7196485> and http://webkit.org/b/29021

WebCore:

loader/FrameLoader.cpp:

(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

platform/mac/Skipped:
platform/win/Skipped:

9:30 AM Changeset in webkit [50152] by timothy@apple.com

1 edit
2 deletes in trunk/WebCore

Remove more empty files that didn't get removed earlier.

inspector/DOMDispatchTimelineItem.cpp: Removed.
inspector/DOMDispatchTimelineItem.h: Removed.

8:34 AM Changeset in webkit [50151] by Csaba Osztrogonác

2 edits in trunk/WebCore

[Qt] Fix assertion crashes introduced by changes made in r50110.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-27
Reviewed by Tor Arne Vestbø.

dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.

8:27 AM Changeset in webkit [50150] by timothy@apple.com

1 edit
2 deletes in trunk/WebCore

Remove empty files that didn't get removed earlier.

inspector/TimelineItem.cpp: Removed.
inspector/TimelineItem.h: Removed.

7:44 AM Changeset in webkit [50149] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed Qt build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
Update the tests as well to the new API change.

tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::clear):

7:28 AM Changeset in webkit [50148] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-27 Xan Lopez <xlopez@igalia.com>

Another typo.

platform/gtk/Skipped:

7:22 AM Changeset in webkit [50147] by kenneth@webkit.org

3 edits in trunk/WebKit/qt

Rubberstamped by Tor Arne Vestbø.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-27
[Qt] QWebElement::removeChildren() should be
QWebElement::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=30630

Api/qwebelement.cpp:

(QWebElement::removeAllChildren):

Api/qwebelement.h:

7:18 AM Changeset in webkit [50146] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-27 Xan Lopez <xlopez@igalia.com>

Fix typo in test names.

platform/gtk/Skipped:

7:02 AM Changeset in webkit [50145] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-27 Xan Lopez <xlopez@igalia.com>

Skip a few tests with links to their tracking bugs.

platform/gtk/Skipped:

6:57 AM Changeset in webkit [50144] by tonikitoo@webkit.org

1 edit in trunk/WebCore/ChangeLog

This reverts commit r50141 that wrongly messed up the WebCore/ChangeLog

6:51 AM Changeset in webkit [50143] by Csaba Osztrogonác

3 edits in trunk/JavaScriptCore

Rubber-stamped by Tor Arne Vestbø.

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2009-10-27
Fix typo in RegexInterpreter.cpp and RegexJIT.cpp alterantive to
alternative.

yarr/RegexInterpreter.cpp:

(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):

yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

6:38 AM Changeset in webkit [50142] by tonikitoo@webkit.org

5 edits in trunk/WebKit/qt

Make QWebPagePrivate's (QWidget) view to be a QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=30779

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Antti Koivisto and Holger Freyther.

The fact that it was been set from external objects of qwebpage
and not being deleted internally can lead to dangling references.

Api/qgraphicswebview.cpp:

(QGraphicsWebView::~QGraphicsWebView):

Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::createContextMenu):
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::keyPressEvent):
(QWebPage::setView):
(QWebPage::view):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::shouldInterruptJavaScript):
(QWebPage::createWindow):
(QWebPage::extension):
(QWebPage::chooseFile):
(QWebPage::userAgentForUrl):

Api/qwebpage_p.h:
Api/qwebview.cpp:

(QWebView::~QWebView):

6:37 AM Changeset in webkit [50141] by tonikitoo@webkit.org

1 edit in trunk/WebCore/ChangeLog

2009-10-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: populate child nodes before sorting them.

https://bugs.webkit.org/show_bug.cgi?id=29673

inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):

5:20 AM Changeset in webkit [50140] by xan@webkit.org

2 edits in trunk/WebCore

2009-10-27 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface

First part of the implementation of AtkTable.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getCell): (getCellIndex): (webkit_accessible_table_ref_at): (webkit_accessible_table_get_index_at): (webkit_accessible_table_get_n_columns): (webkit_accessible_table_get_n_rows): (webkit_accessible_table_get_column_extent_at): (webkit_accessible_table_get_row_extent_at): (webkit_accessible_table_get_row_header): (atk_table_interface_init): (AtkInterfacesInitFunctions): (GetAtkInterfaceTypeFromWAIType):

4:33 AM Changeset in webkit [50139] by vestbo@webkit.org

2 edits in trunk/WebCore

[Qt] Don't lose remainder when computing wheel event deltas

Reviewed by Lars Knoll.

platform/qt/WheelEventQt.cpp:

3:17 AM Changeset in webkit [50138] by eric@webkit.org

4 edits in trunk/WebCore

2009-10-27 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antti Koivisto.

Fix QtWebKit build for WIN_OS if Netscape plug-in support
is turned off and refactor some related code
https://bugs.webkit.org/show_bug.cgi?id=30786

No new tests as there is no new functionality introduced.

platform/FileSystem.h: Refactor to make sure that each different type definition is only repeated once.

plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion): Move it out from the ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the function body from PluginPackageWin.

plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as it is now in PluginPackage.cpp.

3:09 AM Changeset in webkit [50137] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

svn-apply can exit(0) even on patch failure
https://bugs.webkit.org/show_bug.cgi?id=29622

Scripts/svn-apply:
- Add a bunch of "or die" statements, hopefully catching all possible cases where failure could still exit(0).

3:01 AM Changeset in webkit [50136] by eric@webkit.org

8 edits in trunk/WebKitTools

2009-10-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

svn-* scripts should share code through VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=30791

Just moving code into a shared location.

Scripts/VCSUtils.pm:
Scripts/prepare-ChangeLog:
Scripts/resolve-ChangeLogs:
Scripts/svn-apply:
Scripts/svn-create-patch:
Scripts/svn-unapply:
Scripts/update-webkit:

2:54 AM Changeset in webkit [50135] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-27 Vadim Zeitlin <vadim@wxwidgets.org>

Suppress a huge number of MSVC warnings when building wxWebKit.

wx/build/settings.py:

2:20 AM Changeset in webkit [50134] by xan@webkit.org

2 edits in trunk/WebCore

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=27011
[Gtk] Implement support for get_index_in_parent

Implement atk_object_get_index_in_parent.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_index_in_parent):

2:07 AM Changeset in webkit [50133] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-27 Eric Seidel <eric@webkit.org>

No review, rolling out r50131.
http://trac.webkit.org/changeset/50131

bridge/objc/objc_instance.h:
bridge/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::virtualEnd):

12:12 AM Changeset in webkit [50132] by dbates@webkit.org

4 edits
6 adds in trunk

2009-10-26 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30491

Fixes an issue where pressing return/enter on the keyboard
in <isindex> does not submit it if is not within a <form>.

According to the HTML 2.0 thru HTML 4.01 spec
(http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the
<isindex> element does not need to be within a <form> element in
order to submit it. It can submitted on its own. Also, if present,
the href property of the <base> element will dictate where to submit
the value of the <isindex> element (this is analogous to the action
property of the <form> element).

Tests: http/tests/misc/isindex-with-no-form-base-href.html

http/tests/misc/isindex-with-no-form.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex() to create a <form> if none is present and we are an <isindex> element. (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
html/HTMLInputElement.h:

2009-10-26 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30491

Test that the <isindex> element can be submitted without being enclosed
within a <form> element. Also tests that the href property of the <base>
element can be used to direct where the submission is sent.

http/tests/misc/isindex-with-no-form-base-href-expected.txt: Added.
http/tests/misc/isindex-with-no-form-base-href.html: Added.
http/tests/misc/isindex-with-no-form-expected.txt: Added.
http/tests/misc/isindex-with-no-form.html: Added.
http/tests/misc/resources/isindex-with-no-form-base-href-submit.html: Added.
http/tests/misc/resources/isindex-with-no-form-base-href.html: Added.

12:10 AM Changeset in webkit [50131] by oliver@apple.com

3 edits in trunk/WebCore

Crash occurs after launching Newsfire 1.6 for the first time
https://bugs.webkit.org/show_bug.cgi?id=30807

Reviewed by Maciej Stachowiak.

Use a RetainPtr in ObjcBinding to ensure that we adequately
protect the autorelease pool from GC in GC'd applications.

Oct 26, 2009:

9:48 PM Changeset in webkit [50130] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-26 Eric Seidel <eric@webkit.org>

No review, just adding Mike Belshe to the committers list.

Scripts/modules/committers.py:

9:48 PM Changeset in webkit [50129] by mrowe@apple.com

4 edits in trunk

Versioning.

9:47 PM Changeset in webkit [50128] by mrowe@apple.com

1 copy in tags/Safari-532.3

New tag.

8:57 PM Changeset in webkit [50127] by Laszlo Gombos

2 edits in trunk/WebCore

2009-10-26 Laszlo Gombos <Laszlo Gombos>

Unreviewed.

[Qt] Build fix for QtWebKit after r50125.

WebCore.pro: Rename TimelineItem to TimelineRecord.

8:38 PM Changeset in webkit [50126] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-26 Matt Mueller <mattm@chromium.org>

Reviewed by Darin Adler.

Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.

Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.

https://bugs.webkit.org/show_bug.cgi?id=30658

Covered by running various svg tests under valgrind, ex:
LayoutTests/svg/custom/js-late-mask-and-object-creation.svg

svg/SynchronizablePropertyController.cpp: (WebCore::SynchronizableProperties::addProperty): (WebCore::SynchronizableProperties::synchronize): (WebCore::SynchronizableProperties::startAnimation): (WebCore::SynchronizableProperties::stopAnimation): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
svg/SynchronizablePropertyController.h: (WebCore::SynchronizableProperties::SynchronizableProperties): (WebCore::SynchronizableProperties::setNeedsSynchronization):

8:24 PM Changeset in webkit [50125] by eric@webkit.org

11 edits
2 moves in trunk/WebCore

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Renames TimelineItem to TimelineRecord and updates all call sites.
https://bugs.webkit.org/show_bug.cgi?id=30785

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addRecordToTimeline):
inspector/InspectorFrontend.h:
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
inspector/TimelineItemFactory.cpp: Removed.
inspector/TimelineItemFactory.h: Removed.
inspector/TimelineRecordFactory.cpp: Added. (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createDOMDispatchRecord): (WebCore::TimelineRecordFactory::createGenericTimerRecord): (WebCore::TimelineRecordFactory::createTimerInstallRecord):
inspector/TimelineRecordFactory.h: Added. (WebCore::TimelineRecordFactory::TimelineRecordFactory):
inspector/front-end/TimelineAgent.js: (WebInspector.addRecordToTimeline):
inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype.getRecordTypeName): (WebInspector.TimelineRecordTreeElement.prototype.onattach):

7:56 PM Changeset in webkit [50124] by zecke@webkit.org

1 edit in trunk/WebCore/plugins/qt/PluginViewQt.cpp

Unreviewed spelling fix in the PluginViewQt.cpp

This error was pointed out in the bug report and it was agreed to
do the spelling fix when landing the patch. Fix it now.

7:50 PM Changeset in webkit [50123] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Antti Koivisto.

[Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled

When printing, QPrinter's preview mode uses a QPicture to capture the output. The
QPicture holds a reference to the X Pixmap. As a result, the print preview would
update itself when the X Pixmap changes. To prevent the print preview from updating
whenever m_drawable is updated (i.e when the view updates), we create a copy.

We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
regardless of the graphicssystem. This is taken care of by
commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)

The beauty of this patch is that the newly created X Pixmap is managed by Qt and
it will free the Pixmap whenever the user closes the print preview dialog and
handles the case of displaying multiple preview dialogs nicely.

All credit to Samuel Rødal for suggesting usage of QPixmap::copy().

https://bugs.webkit.org/show_bug.cgi?id=30714

plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::paint):

7:42 PM Changeset in webkit [50122] by eric@webkit.org

3 edits in trunk/WebCore

2009-10-26 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Don't store properties in the MediaPlayerPrivate class

Access them via the MediaPlayer class instead.
https://bugs.webkit.org/show_bug.cgi?id=30462

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

7:27 PM Changeset in webkit [50121] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30801>.
Web Inspector: Control + ]/[ on Windows doesn't change Panels.

Reviewed by Timothy Hatcher.

In my testing, Windows uses "U+00DB" and "U+00DD" to represent
[ and ], so we should honor those as well.

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

7:10 PM Changeset in webkit [50120] by Laszlo Gombos

9 edits in trunk

2009-10-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use winresrc.h because it exists even when MFC is not installed, and is all that's needed here.

WebCore.vcproj/QTMovieWin.rc: Ditto.

WebKit.vcproj/WebKit.rc: Ditto.

DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use windows.h instead of afxres.h because it exists even when MFC is not installed, and is all that's needed here.

FindSafari/FindSafari.rc: Ditto

6:56 PM Changeset in webkit [50119] by bweinstein@apple.com

3 edits in trunk/LayoutTests

Unreviewed - Updating getComputedStyle results for Windows.

Updating getComputedStyle results for Windows.

platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

6:09 PM Changeset in webkit [50118] by bfulgham@webkit.org

4 edits in trunk/WebCore

Build corrections for ENABLE_FILTERS in Windows.
https://bugs.webkit.org/show_bug.cgi?id=30797

Reviewed by Darin Adler.

Build correction for ENABLE_FILTERS feature. No new tests needed.

platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and its piDouble constant.
platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and its piDouble constant. Remove unnecessary call to floor used in the division of an unsigned, converting to int.
platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include style for MathExtras.h.

6:04 PM WikiStart edited by timothy@apple.com

Remove some other old pages. (diff)

6:01 PM WikiStart edited by timothy@apple.com

Remove some old pages for Developer Tools. (diff)

5:53 PM Changeset in webkit [50117] by mitz@apple.com

2 edits in trunk/WebKitSite

Updated BSD License

Reviewed by Adele Peterson.

coding/bsd-license.html: Updated to the latest version.

5:19 PM Changeset in webkit [50116] by beidson@apple.com

3 edits
4 adds in trunk

<rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/grandparent-completion-starts-redirect.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.

LayoutTests:

fast/loader/grandparent-completion-starts-redirect-expected.txt: Added.
fast/loader/grandparent-completion-starts-redirect.html: Added.
fast/loader/resources/meta-redirect-to-notify-done.html: Added.
fast/loader/resources/parent-of-redirect.html: Added.

4:56 PM Changeset in webkit [50115] by mitz@apple.com

4 edits in trunk

WebCore: Re-add CSSPropertyWebkitBackgroundSize in one more place

Reviewed by Beth Dakin.

Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html

page/animation/AnimationBase.cpp:

(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):

LayoutTests: Use -webkit-background-size as the transition property in this test now
that it is distinct from background-size.

Reviewed by Sam Weinig.

transitions/multiple-background-size-transitions.html:

4:56 PM Changeset in webkit [50114] by mrowe@apple.com

2 edits in trunk/WebKitLibraries

Clean up the regex madness in auto-version.sh to make it obvious what the script is doing.

Reviewed by Adam Roben.

Also teaches auto-version.sh to handle RC_PROJECTSOURCEVERSION that has more than three digits
in the major component of the version number.

win/tools/scripts/auto-version.sh:

4:44 PM Changeset in webkit [50113] by jorlow@chromium.org

6 edits in trunk/WebCore

2009-10-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Tidy up the DOM Storage runtime flag stuff
https://bugs.webkit.org/show_bug.cgi?id=30794

Clean up the DOM Storage runtime flag stuff to match the new way of doing
things. No behavioral changes.

bindings/v8/RuntimeEnabledFeatures.cpp:
bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::databaseEnabled): (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
storage/Storage.cpp:
storage/Storage.h:

4:27 PM Changeset in webkit [50112] by mitz@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Beth Dakin.

Update expedted results after r50108.

svg/css/getComputedStyle-basic-expected.txt:

4:20 PM Changeset in webkit [50111] by beidson@apple.com

3 edits
2 adds in trunk

<rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/history-forward-in-head.html

loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.

This restores the side effect of an invalid history navigation canceling previous scheduled redirects
and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.

(WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before

the redirect is scheduled.

LayoutTests:

fast/loader/history-forward-in-head-expected.txt: Added.
fast/loader/history-forward-in-head.html: Added.

4:11 PM Changeset in webkit [50110] by ap@apple.com

6 edits
4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30049
<rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash

Tests: fast/parser/remove-current-node-parent-x-2.xhtml

fast/parser/remove-current-node-parent-x.xhtml

dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is unreliable after DOM manipulation.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack. (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when exiting a node. (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This replaces setCurrentNode(0). (WebCore::XMLTokenizer::enterText): Call pushCurrentNode(). (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME (not sure if it was ever practical though - how can a parent become null while adding text?)

dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack(). (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode(). (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also added a check fo script element still being in document - Firefox parses those that aren't, but doesn't execute them.

dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::parseStartElement): (WebCore::XMLTokenizer::parseEndElement): Match libxml2 version changes.

3:49 PM Changeset in webkit [50109] by eric@webkit.org

8 edits in trunk/JavaScriptCore

2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782

Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.

assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::ret): Return with link register (JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
jit/JIT.h: Remove unused ctiReturnRegister
jit/JITInlineMethods.h: Same as ARMv7 (JSC::JIT::restoreArgumentReference): Ditto. (JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use small trampoline functions which handle return addresses for each CTI_STUB_FUNCTION.
jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame (JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction

3:41 PM Changeset in webkit [50108] by mitz@apple.com

13 edits in trunk

background-size: X treated as background-size: X X, not background-size: X auto
https://bugs.webkit.org/show_bug.cgi?id=28440

Reviewed by Beth Dakin.

WebCore:

Updated fast/backgrounds/size/resources/parsing-background-size-values.js
and fast/backgrounds/size/resources/parsing-inherit.js

Reinstated -webkit-background-size and kept its behavior of filling in
the second value with the first one; and changed background-size to have
the behavior of filling in the second value with 'auto'.

css/CSSComputedStyleDeclaration.cpp:

(computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.
(WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
(WebCore::CSSParser::parseFillProperty): Re-added
CSSPropertyWebkitBackgroundSize.
(WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
background-size.

css/CSSParser.h:
css/CSSPropertyNames.in: Re-added -webkit-background-size.
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Re-added
CSSPropertyWebkitBackgroundSize.

LayoutTests:

fast/backgrounds/size/parsing-background-size-values-expected.txt:
fast/backgrounds/size/parsing-inherit-expected.txt:
fast/backgrounds/size/resources/parsing-background-size-values.js:

(test):

fast/backgrounds/size/resources/parsing-inherit.js:
platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

3:41 PM Changeset in webkit [50107] by eric@webkit.org

3 edits in trunk/WebKitTools

2009-10-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool post-diff should know how to mark commit-queue=?
https://bugs.webkit.org/show_bug.cgi?id=29202

Scripts/bugzilla-tool:
- Add --commit-queue option to post-diff, post-commits and create-bug.
Scripts/modules/bugzilla.py:
- Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
- Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.

3:37 PM Changeset in webkit [50106] by weinig@apple.com

5 edits
1 add in trunk/WebKit

Move some WebView event handling code into its own file, WebViewEventHandling.mm

Reviewed by Anders Carlsson.

WebKit:

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

WebView/WebView.mm:

(-[WebView _close]):
(-[WebView _selectedOrMainFrame]):

WebView/WebViewEventHandling.mm: Added.

(-[WebView _closingEventHandling]):
(-[WebView _setMouseDownEvent:]):
(-[WebView mouseDown:]):
(-[WebView mouseUp:]):
(+[WebView _updateMouseoverWithEvent:]):
(-[WebView _updateMouseoverWithFakeEvent]):
(_updateMouseoverWithEvent:fakeEvent::if):
(-[WebView _stopAutoscrollTimer]):
(-[WebView _setToolTip:]):

WebView/WebViewInternal.h:

3:34 PM Changeset in webkit [50105] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool commit-queue does not notice modifications to committers.py
https://bugs.webkit.org/show_bug.cgi?id=30084

Scripts/bugzilla-tool:
- Make commit-queue re-exec itself instead of using while(1).
- Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
- Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).

3:32 PM Changeset in webkit [50104] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue will get stuck on patches if land-patches terminates unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=30634

Scripts/bugzilla-tool:
- Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
- Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.

3:22 PM Changeset in webkit [50103] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
https://bugs.webkit.org/show_bug.cgi?id=30777

No new tests as the crash can be reproduced by existing storage
LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).

platform/text/String.cpp: (WebCore::String::number): Qt's QString::vsprintf does not understand the "%I64u" format string. Always use the "%lli" format string for Qt port.

3:10 PM Changeset in webkit [50102] by eric@webkit.org

7 edits in trunk/WebKitTools

2009-10-26 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.

https://bugs.webkit.org/show_bug.cgi?id=30763

pywebsocket/mod_pywebsocket/init.py:
pywebsocket/mod_pywebsocket/dispatch.py:
pywebsocket/mod_pywebsocket/headerparserhandler.py:
pywebsocket/mod_pywebsocket/standalone.py:
pywebsocket/setup.py:
pywebsocket/test/test_dispatch.py:

3:04 PM Changeset in webkit [50101] by tony@chromium.org

6 edits in trunk/WebCore

2009-10-26 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Roll back r50073 because r50041-50043 were reverted. r50073 was
a chromium side fix for r50041.
https://bugs.webkit.org/show_bug.cgi?id=30789

bindings/v8/V8Collection.h:
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

3:02 PM Changeset in webkit [50100] by ggaren@apple.com

5 edits
3 adds in trunk

WebCore: Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-26
Reviewed by Dimitri Glazkov.

and related bugs.

If the event listener being removed is prior to the current firing event
iterator, we need to decrement the current firing event iterator in
addition to the endpoint. (Otherwise, shrinking the event listener vector
by one implicity moves the current firing event iterator forward by one.
It's like relativity, only without the planets.)

Also took the opportunity to change some pointers to references, since
they can't be null.

dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
to end, if need be.
(WebCore::EventTarget::fireEventListeners): Updated for interface changes.
Added a comment to explain a behavior that was implicit enough to be
confusing.

dom/EventTarget.h:

(WebCore::FiringEventIterator::FiringEventIterator):
(WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=30765
REGRESSION (r48701): Removing an event listener causes one added after it to not fire

Patch by Dimitri Glazkov <Dimitri Glazkov> on 2009-10-26
Reviewed by Geoffrey Garen.

fast/events/event-listener-list-mutation-expected.txt: Added.
fast/events/event-listener-list-mutation.html: Added.
fast/events/script-tests/event-listener-list-mutation.js: Added.

(TestMutation.listeners):
(TestMutation.mutateList):

2:52 PM Changeset in webkit [50099] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Removes the check around the RenderHints property documentation
that was clearly added to synchronize the source and header files
when the #if !defined(Q_OS_SYMBIAN) guards was added to the
property.

The documentation has also been updated to ensure that Symbian
users know that there is no actual RenderHints property on their
platform.

Api/qwebview.cpp:

2:50 PM Changeset in webkit [50098] by bweinstein@apple.com

2 edits in trunk/WebCore

Fixes <http://webkit.org/b/30792>.
Web Inspector: When changing resource scope, resource graph can get in weird state.

Reviewed by Timothy Hatcher.

If the user was scrolled down while looking at All resources, and then just
selects Fonts, or something that doesn't have many resources, then the graph
will stay scrolled down, even when there is no content there.

When the filter is updated, scroll to the top of the graph view, so this won't
happen.

inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

2:46 PM Changeset in webkit [50097] by weinig@apple.com

2 edits in trunk/WebCore

Fix mac clean build.

html/HTMLOptionsCollection.idl:

2:42 PM Changeset in webkit [50096] by kenneth@webkit.org

2 edits in trunk/WebKit/qt

Unreviewed documentation fix from David Boddie (Qt Doc Team)

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-26
Ensure that qdoc will always see the RenderHints property.

The property was only defined in the header file if the Q_OS_SYMBIAN
symbol was not defined, resulting in the property not showing up
in the Qt documentation just because one platform doesn't support it.

A follow up commit will improve the documentation for the property
and note that it is not supported on the Symbiam platform.

Api/qwebview.h:

2:35 PM Changeset in webkit [50095] by pfeldman@chromium.org

9 edits
1 add in trunk/WebCore

2009-10-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.

https://bugs.webkit.org/show_bug.cgi?id=30776

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/AbstractTimelinePanel.js: Added. (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.get categories): (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement): (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._updateFilter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh): (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded): (WebInspector.AbstractTimelinePanel.prototype.show): (WebInspector.AbstractTimelinePanel.prototype.resize): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeSummaryValues): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.get boundarySpan): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype._value): (WebInspector.TimelineCalculator.prototype.formatValue):
inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.get categories): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.createPanelEnabler): (WebInspector.ResourcesPanel.prototype.createStatusbarButtons): (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime): (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype.update):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.loaded):

2:09 PM Changeset in webkit [50094] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Avi Drissman <avi@google.com>

Reviewed by Darin Adler.

Use Helvetica in the Inspector as intended.
https://bugs.webkit.org/show_bug.cgi?id=30787

inspector/front-end/inspector.css:

2:05 PM Changeset in webkit [50093] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-10-26 Xan Lopez <xlopez@igalia.com>

Skip test fast/loader/opaque-base-url.html with a reference to the
bug tracking it, https://bugs.webkit.org/show_bug.cgi?id=30724

platform/gtk/Skipped:

2:02 PM Changeset in webkit [50092] by eric@webkit.org

5 edits in trunk

2009-10-26 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Update no-referrer-reset for https://bugs.webkit.org/show_bug.cgi?id=30781.

http/tests/navigation/no-referrer-reset-expected.txt: Expect window.opener to still be set.
http/tests/navigation/no-referrer-reset.html: Update text to reflect what the test actually does.

2009-10-26 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
https://bugs.webkit.org/show_bug.cgi?id=30781

loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.

1:53 PM Changeset in webkit [50091] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Levin.

REGRESSION: 2 failures in run-webkit-unittests
https://bugs.webkit.org/show_bug.cgi?id=30645

Scripts/modules/cpp_style_unittest.py: Fixed a few test scenarios which apparently lost some spaces from text literals.

1:48 PM Changeset in webkit [50090] by rniwa@webkit.org

3 edits
3 adds in trunk

Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-10-26
Reviewed by Eric Seidel.

WebCore:

Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
to a temporary valuable. It was originally calling nextSibling() after appending the child
to new parent, in which case, nextSibling is always 0.

Test: editing/style/unbolding-nested-b.html

editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

Adds a test to make sure WebKit can remove nested b, i, & s tags properly
without loosing the content of inner elements.

editing/style/remove-nested-inline-styles-expected.txt: Added.
editing/style/remove-nested-inline-styles.html: Added.
editing/style/script-tests/remove-nested-inline-styles.js: Added.

(removeStyleAndExpect):

1:16 PM Changeset in webkit [50089] by kov@webkit.org

2 edits in trunk

Reviewed by Jan Alonzo.

Alternative solution to regression introduced in r48672.

1:11 PM Changeset in webkit [50088] by jorlow@chromium.org

4 edits
3 adds in trunk

2009-10-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Storage events should use Document::url() rather than documentURI()
https://bugs.webkit.org/show_bug.cgi?id=30535

Storage events should use Document::url() rather than Document::documentURI()
per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html

Test: storage/domstorage/documentURI.html

storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2009-10-26 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

fast/dom/wrapper-classes-expected.txt:

1:04 PM Changeset in webkit [50087] by weinig@apple.com

19 edits
1 delete in trunk

Rubber-stamped by Darin Adler.

Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.

WebCore:

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):

bindings/js/JSHTMLCollectionFunctions.h: Removed.
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::length):
(WebCore::JSHTMLOptionsCollection::indexSetter):

bindings/objc/DOMHTML.mm:

(kitClass):

bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLCollection.idl:
html/HTMLOptionsCollection.idl:

WebKit/win:

DOMCreateInstance.cpp:

LayoutTests:

fast/dom/wrapper-classes-expected.txt:

12:46 PM Changeset in webkit [50086] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.

12:34 PM Changeset in webkit [50085] by bfulgham@webkit.org

3 edits in trunk/WebCore

Build fix for ENABLE_FILTERS under Windows.
https://bugs.webkit.org/show_bug.cgi?id=30762

Reviewed by Adam Roben.

Build correction for ENABLE_FILTERS feature. No new tests needed.

WebCore.vcproj/WebCore.vcproj: Make the following changes: (1) Create a new 'filters' sub-folder of the platform/graphics

folder to properly show the sources held in this directory.

(2) Move the files that are currently shown in svn/graphics/filters

to platform/graphics/filters (where they actually live on disk).

(3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to

the project so they are built.

(4) Remove SVGFEFloodElement.cpp from the build, since it is already

being compiled by SVGAllInOne.cpp. Its presence as a separate
entity is causing a linker warning for duplicate symbols.

(5) Add ImageBuffer.cpp to the build to support color space

calculations for non-CG builds.

WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters path to the search paths in the project.

12:30 PM Changeset in webkit [50084] by eric@webkit.org

5 edits in trunk/WebCore

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135

English.lproj/localizedStrings.js:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType. (WebInspector.ConsoleMessage.prototype.toString):
page/Console.cpp: (WebCore::Console::assertCondition): Use AssertMessageType.
page/Console.h: (WebCore::MessageType): Added AssertMessageType.

12:19 PM Changeset in webkit [50083] by eric@webkit.org

3 edits
2 adds in trunk

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty.

https://bugs.webkit.org/show_bug.cgi?id=30365

fast/forms/select-empty-optgroup-expected.txt: Added.
fast/forms/select-empty-optgroup.html: Added.

2009-10-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Prevent crash when optgroup element is empty by adding a NULL check.

https://bugs.webkit.org/show_bug.cgi?id=30365

Test: fast/forms/select-empty-optgroup.html

dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData):

12:11 PM Changeset in webkit [50082] by tony@chromium.org

3 edits in trunk/WebCore

2009-10-21 Steven Knight <sgk@chromium.org>

Reviewed by David Levin.

Refactor gyp for separate webcore_bindings{,_sources} targets.

https://bugs.webkit.org/show_bug.cgi?id=30447

Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.

Chrome should still build and test successfully.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:

12:10 PM Changeset in webkit [50081] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.16

Tagging 1.1.16.

11:57 AM Changeset in webkit [50080] by Csaba Osztrogonác

9 edits in trunk/WebKitTools

Unification of using null device in perl scripts.
https://bugs.webkit.org/show_bug.cgi?id=30572

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26
Reviewed by Darin Adler.

Scripts/VCSUtils.pm:
Scripts/bisect-builds:
Scripts/resolve-ChangeLogs:
Scripts/run-iexploder-tests:
Scripts/run-jsc:
Scripts/run-mangleme-tests:
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

Using File::Spec->devnull() instead of hard coded /dev/null.

11:40 AM Changeset in webkit [50079] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2009-10-26 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

Make the number of connections for chromium controlled by
chromium rather than by ResourceRequestBase.
https://bugs.webkit.org/show_bug.cgi?id=30661

platform/network/ResourceRequestBase.cpp:
platform/network/chromium/ResourceRequest.cpp:

11:38 AM Changeset in webkit [50078] by eric@webkit.org

2 edits in trunk/WebKitTools

2009-10-26 Eric Seidel <eric@webkit.org>

Reviewed by Holger Freyther.

Reviewers are missing from committers.py
https://bugs.webkit.org/show_bug.cgi?id=30733

Scripts/modules/committers.py:

11:38 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

11:33 AM Changeset in webkit [50077] by eric@webkit.org

2 edits in trunk/BugsSite

2009-10-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

PrettyPatch should show images even when they have the wrong mime type
https://bugs.webkit.org/show_bug.cgi?id=29506

PrettyPatch/PrettyPatch.rb:

10:55 AM HackingGtk edited by kov@webkit.org

(diff)

10:54 AM Changeset in webkit [50076] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed typo fix.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26

platform/qt/Skipped: shared-workers-close.html replaced with shared-worker-close.html

10:45 AM Changeset in webkit [50075] by kov@webkit.org

2 edits in trunk/WebCore

Unreviewed. make distcheck build fixes.

10:44 AM Changeset in webkit [50074] by kov@webkit.org

2 edits in trunk

Unreviewed. Fix make dist regression introduced by r48672.

10:35 AM Changeset in webkit [50073] by eric@webkit.org

6 edits in trunk/WebCore

2009-10-26 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Unbreak Chromium build: that requires adding custom implementations
for HTMLOptionsCollection's item and namedItem. Keep v8 binding
close to JSC bindings as well.
https://bugs.webkit.org/show_bug.cgi?id=30780

bindings/v8/V8Collection.h: (WebCore::getNamedItemsFromCollection): (WebCore::getItemFromCollection):
bindings/v8/custom/V8CustomBinding.h:
bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

10:26 AM Changeset in webkit [50072] by ap@apple.com

3 edits
3 adds in trunk

Reviewed by Adam Barth and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=30723
<rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.

Test: http/tests/security/escape-form-data-field-names.html

platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): (WebCore::FormDataBuilder::beginMultiPartHeader): (WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Percent-escape line breaks and quotation marks.

10:10 AM Changeset in webkit [50071] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skip two flakey tests because of sporadic timeouts.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/Skipped:

10:06 AM Changeset in webkit [50070] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Skipping two other tests because of missing features on our platform.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/Skipped:

10:00 AM Changeset in webkit [50069] by Csaba Osztrogonác

1 edit
1 add in trunk/LayoutTests

[Qt] Add platform-dependent expected file for test added in r49875.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.

9:46 AM Changeset in webkit [50068] by eric@webkit.org

8 edits in trunk/WebCore

2009-10-26 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Adds DOMTimer support to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=30467

inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names. (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): Added. (WebCore::InspectorTimelineAgent::didRemoveTimer): Added. (WebCore::InspectorTimelineAgent::willFireTimer): Added. (WebCore::InspectorTimelineAgent::didFireTimer): Added. (WebCore::InspectorTimelineAgent::addItemToTimeline): Added. (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
inspector/InspectorTimelineAgent.h: (WebCore::):
inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects. (WebCore::TimelineItemFactory::createGenericTimerTimelineItem): (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
inspector/TimelineItemFactory.h:
page/DOMTimer.cpp: Added instrumentation points. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):

9:31 AM Changeset in webkit [50067] by Simon Fraser

6 edits in trunk

2009-10-26 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/6988966> Hardware layers do not show up in page snapshots

WebView/WebHTMLViewPrivate.h:
WebView/WebHTMLView.mm: (-[WebHTMLView _compositingLayersHostingView]): Add a private method that returns the NSView used to host compositing layers.

platform/graphics/mac/Canvas3DLayer.h:
platform/graphics/mac/Canvas3DLayer.mm: (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]): Add a method that gets called when snapshotting Canvas3DLayers for page snapshots, that allows the layer to return a CGImageRef of its contents.

9:22 AM Changeset in webkit [50066] by Csaba Osztrogonác

7 edits in trunk/LayoutTests

[Qt] Update outdated expected files which expected wrong color values.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
Reviewed by Ariya Hidayat.

platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:

9:17 AM Changeset in webkit [50065] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Pass "console" as object group when evaluating selection.

https://bugs.webkit.org/show_bug.cgi?id=30738

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

9:10 AM Changeset in webkit [50064] by eric@webkit.org

10 edits in trunk

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

inspector/console-tests-expected.txt:

2009-10-26 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Pavel Feldman.

Fix for Console not showing repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
inspector/ConsoleMessage.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
inspector/InspectorFrontend.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual. (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added. (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count. (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
inspector/front-end/inspector.js: (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole. (WebInspector.updateConsoleMessageRepeatCount): Added.

8:27 AM Changeset in webkit [50063] by eric.carlson@apple.com

63 edits in trunk/LayoutTests

2009-10-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464

Part 1, change layout tests to not use the event.

media/audio-constructor-autobuffer-expected.txt:
media/audio-constructor-autobuffer.html:
media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/audio-controls-rendering.html:
media/audio-data-url-expected.txt:
media/audio-data-url.html:
media/audio-mpeg-supported-expected.txt:
media/audio-mpeg-supported.html:
media/media-load-event-expected.txt:
media/media-load-event.html:
media/progress-event-expected.txt:
media/progress-event-total-expected.txt:
media/progress-event-total.html:
media/progress-event.html:
media/remove-from-document-expected.txt:
media/remove-from-document-no-load-expected.txt:
media/remove-from-document-no-load.html:
media/remove-from-document.html:
media/restore-from-page-cache-expected.txt:
media/restore-from-page-cache.html:
media/video-append-source-expected.txt:
media/video-append-source.html:
media/video-buffered-expected.txt:
media/video-buffered.html:
media/video-canvas-source-expected.txt:
media/video-canvas-source.html:
media/video-controls-expected.txt:
media/video-controls-transformed-expected.txt:
media/video-controls-transformed.html:
media/video-controls-zoomed-expected.txt:
media/video-controls-zoomed.html:
media/video-controls.html:
media/video-currentTime-expected.txt:
media/video-currentTime-set-expected.txt:
media/video-currentTime-set.html:
media/video-currentTime-set2-expected.txt:
media/video-currentTime-set2.html:
media/video-currentTime.html:
media/video-dom-src-expected.txt:
media/video-dom-src.html:
media/video-error-abort-expected.txt:
media/video-error-abort.html:
media/video-error-does-not-exist.html:
media/video-muted-expected.txt:
media/video-muted.html:
media/video-no-autoplay-expected.txt:
media/video-no-autoplay.html:
media/video-seek-past-end-paused-expected.txt:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing-expected.txt:
media/video-seek-past-end-playing.html:
media/video-seekable-expected.txt:
media/video-seekable.html:
media/video-seeking-expected.txt:
media/video-seeking.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-volume-expected.txt:
media/video-volume.html:

7:49 AM Changeset in webkit [50062] by Chris Fleizach

3 edits
2 adds in trunk

crash with AX on when an image map contains an anchor tag
https://bugs.webkit.org/show_bug.cgi?id=30739

Reviewed by Darin Adler.

WebCore:

Tests: accessibility/crashing-a-tag-in-map.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

accessibility/crashing-a-tag-in-map-expected.txt: Added.
accessibility/crashing-a-tag-in-map.html: Added.

6:51 AM Changeset in webkit [50061] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Update documentation control files for 1.1.16.

docs/webkitgtk-docs.sgml:
docs/webkitgtk-sections.txt:

6:49 AM Changeset in webkit [50060] by kov@webkit.org

3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30759
[GTK] Should use WebKitNetworkResponse, and expose it

WebKitDownload now uses our WebKitNetworkResponse instead of using
ResourceResponse directly. By exposing the response, like we do
with the request, we give our users the ability to look at the
response headers, status code, and so on, through the SoupMessage
object.

6:25 AM Changeset in webkit [50059] by xan@webkit.org

4 edits in trunk

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

configure.ac:

WebKit/gtk:

2009-10-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.16 release.

NEWS:

6:06 AM Changeset in webkit [50058] by eric@webkit.org

8 edits in trunk/WebKit/qt

2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Reintroduce QWebElementCollection

Revert the patch that has replaced QWebElementCollection
with QList<QWebElement>. Update the tests accordingly.

Remove the constness of the return type of QWebElement operator[].

https://bugs.webkit.org/show_bug.cgi?id=30767

Api/qwebelement.cpp: (QWebElement::findAll): (QWebElementCollectionPrivate::QWebElementCollectionPrivate): (QWebElementCollectionPrivate::create): (QWebElementCollection::QWebElementCollection): (QWebElementCollection::operator=): (QWebElementCollection::~QWebElementCollection): (QWebElementCollection::operator+): (QWebElementCollection::append): (QWebElementCollection::count): (QWebElementCollection::at): (QWebElementCollection::toList):
Api/qwebelement.h: (const_iterator::begin): (const_iterator::end): (const_iterator::operator[]):
Api/qwebframe.cpp: (QWebFrame::findAllElements):
Api/qwebframe.h:
QtLauncher/main.cpp: (MainWindow::selectElements):
tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::simpleCollection): (tst_QWebElement::iteration): (tst_QWebElement::emptyCollection): (tst_QWebElement::appendCollection): (tst_QWebElement::nullSelect): (tst_QWebElement::hasSetFocus): (tst_QWebElement::render):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

5:44 AM Changeset in webkit [50057] by benm@google.com

5 edits in trunk/WebCore

Adds feature ENABLE guards to V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30697

Patch by Steve Block <steveblock@google.com> on 2009-10-26
Reviewed by Eric Seidel.

This adds guards for the following features to the V8 bindings,
to allow builds with V8 to succeed when these features are not enabled.

DATABASE
WORKERS
SHARED_WORKERS
SVG
XPATH
XSLT
INSPECTOR

This is a build fix only, no new tests required.

bindings/v8/DOMObjectsInclude.h: Modified.
bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
bindings/v8/V8Index.cpp: Modified.
bindings/v8/V8Index.h: Modified.

5:32 AM Changeset in webkit [50056] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Rubber-stamped by Tor Arne Vestbø.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26
http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
http/tests/xmlhttprequest/workers/close.html added to flakey tests group.

platform/qt/Skipped:

4:58 AM Changeset in webkit [50055] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed trivial fix for r49854.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-26

platform/qt/Skipped: Missing html extension added.

4:42 AM Changeset in webkit [50054] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists

Fixes the issues with the Atk states exposed for ListBoxOption

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject):

4:35 AM Changeset in webkit [50053] by eric@webkit.org

9 edits in trunk/WebCore

2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=27085
[Gtk] Incorrect rendering of list

Adds a way for platforms to indicate that a particular object
should not be ignored.

accessibility/AccessibilityObject.h:
accessibility/chromium/AccessibilityObjectChromium.cpp:
accessibility/gtk/AccessibilityObjectAtk.cpp:
accessibility/mac/AccessibilityObjectMac.mm:
accessibility/qt/AccessibilityObjectQt.cpp:
accessibility/win/AccessibilityObjectWin.cpp:
accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):

3:46 AM Changeset in webkit [50052] by eric@webkit.org

4 edits in trunk/JavaScriptCore

2009-10-26 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
https://bugs.webkit.org/show_bug.cgi?id=30713

wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.

3:29 AM Changeset in webkit [50051] by eric@webkit.org

3 edits
1 add in trunk/WebCore

2009-10-26 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jan Alonzo.

Bug 30619: [Linux] Menu key doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30619

Test: manual-tests/keyboard-menukey-event.html
No new layout tests: testing this will require changes in the test
controller in a platform-specific way.

platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for GDK_Menu to return V_APPS instead of VK_MENU.

3:07 AM Changeset in webkit [50050] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] Reenable mod_rewrite in Fedora's httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=30741

http/conf/fedora-httpd.conf:

1:52 AM QtBackLog edited by zecke@selfish.org

(diff)

1:45 AM QtBackLog edited by zecke@selfish.org

(diff)

Oct 25, 2009:

9:33 PM Changeset in webkit [50049] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-25 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Reuse already fetched proxy.
https://bugs.webkit.org/show_bug.cgi?id=30747

bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

9:14 PM QtBackLog edited by zecke@selfish.org

(diff)

9:07 PM QtBackLog edited by zecke@selfish.org

(diff)

9:03 PM QtBackLog edited by zecke@selfish.org

Mention the bug report and commits of this work (diff)

5:45 PM Changeset in webkit [50048] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-10-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline test after 49998.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

3:39 PM Changeset in webkit [50047] by Laszlo Gombos

2 edits in trunk/WebCore

2009-10-25 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Build fix for WIN_OS if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30753

plugins/PluginDatabase.cpp:

1:15 PM Changeset in webkit [50046] by eric@webkit.org

3 edits
4 adds in trunk

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

fast/forms/listbox-typeahead-cyrillic-expected.txt: Added.
fast/forms/listbox-typeahead-cyrillic.html: Added.
fast/forms/listbox-typeahead-greek-expected.txt: Added.
fast/forms/listbox-typeahead-greek.html: Added.

2009-10-25 Hironori Bono <hbono@chromium.org>

Reviewed by Darin Adler.

A quick fix for Bug 29103.
Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
and the option string before calling String::startsWith().
https://bugs.webkit.org/show_bug.cgi?id=29103

Tests: fast/forms/listbox-typeahead-cyrillic.html

fast/forms/listbox-typeahead-greek.html

dom/SelectElement.cpp: (WebCore::SelectElement::typeAheadFind):

10:28 AM Changeset in webkit [50045] by mitz@apple.com

3 edits in trunk/WebKit/win

Add contextForWorldID to the IWebFramePrivate interface.

Reviewed by John Sullivan.

Interfaces/IWebFramePrivate.idl:
WebFrame.h:

8:06 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

6:56 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

6:54 AM Web Inspector edited by casey.hattori@gmail.com

(diff)

1:54 AM Changeset in webkit [50044] by eric@webkit.org

2 edits in trunk/WebCore

2009-10-25 Keishi Hattori <casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Web Inspector: Expanding a node in the Console should not show the element in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=30749

inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.

1:22 AM Changeset in webkit [50043] by weinig@apple.com

2 edits in trunk/WebKit/win

Another try at fixing windows.

DOMCreateInstance.cpp:

12:52 AM Changeset in webkit [50042] by weinig@apple.com

2 edits in trunk/WebKit/win

Touch WebKit.idl in an effort to try and regenerate the COM bindings.

Interfaces/WebKit.idl:

12:52 AM Changeset in webkit [50041] by weinig@apple.com

18 edits
1 add in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added JSHTMLCollectionFunctions.h

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::callHTMLCollection):
(WebCore::JSHTMLOptionsCollection::getCallData):
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::item):
(WebCore::JSHTMLOptionsCollection::namedItem):
Refactor to use generic implementation of HTMLCollection bindings functions
from JSHTMLCollectionFunctions.h

bindings/js/JSHTMLCollectionFunctions.h: Added.

(WebCore::getCollectionNamedItems):
(WebCore::getCollectionItems):
(WebCore::callHTMLCollectionGeneric):
Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
JSHTMLOptionsCollection can all use.

bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h

for toJS on document.all.

bindings/objc/DOMHTML.mm:
bindings/objc/DOMUtility.mm:

(JSC::createDOMWrapper):
Remove special cases for HTMLOptionsCollection.

bindings/scripts/CodeGeneratorJS.pm:
html/HTMLAllCollection.idl:
html/HTMLCollection.idl:
html/HTMLOptionsCollection.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
HTMLOptionsCollection should not inherit from HTMLCollection

Reviewed by Dan Bernstein.

fast/dom/wrapper-classes-expected.txt:

12:08 AM Changeset in webkit [50040] by bweinstein@apple.com

18 edits
1 delete in trunk

Roll out r50037 as it broke the Windows build.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed