Context Navigation

← Previous Period
Next Period →

Timeline

Apr 17, 2012:

11:39 PM Changeset in webkit [114488] by commit-queue@webkit.org

5 edits in trunk

[BlackBerry] Viewport metatag doesn't disable double-tap zoom
https://bugs.webkit.org/show_bug.cgi?id=84199

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
Reviewed by George Staikos.

Source/WebKit/blackberry:

PR: 148279
When we set "user-scalable=no" in viewport meta-tag and change any
other WebSettings, the WebPage can turn to be scalable.
This is a regression of the change master_32/SHA:fa0f8ee9. In that
change, we used setUserScalable(webSettings->isUserScalable())
in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
case, as webSettings->isUserScalable() would always return true by
default.
Create a new API WebPage::setUserScalable which will be used in
DumpRenderTree.cpp.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setUserScalable):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

Api/WebPage.h:

Tools:

Revert a part of the change master_32/SHA:fa0f8ee9 and use
WebPage::setUserScalable instead.

DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

11:36 PM Changeset in webkit [114487] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::shouldCacheResampling):

10:54 PM Changeset in webkit [114486] by toyoshim@chromium.org

3 edits in trunk/LayoutTests

Unreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .

platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:

10:47 PM Changeset in webkit [114485] by jer.noble@apple.com

2 edits in trunk/LayoutTests

WebKitTestRunner needs textInputController
https://bugs.webkit.org/show_bug.cgi?id=42337

Update wk2 Skipped list to skip new failing test.

platform/wk2/Skipped:

10:34 PM Changeset in webkit [114484] by jer.noble@apple.com

2 edits in trunk/LayoutTests

[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
https://bugs.webkit.org/show_bug.cgi?id=84227

Update wk2 Skipped list to skip new failing test.

platform/wk2/Skipped:

10:27 PM Changeset in webkit [114483] by toyoshim@chromium.org

1 edit
1 move
2 adds in trunk/LayoutTests

Unreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .

platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png: Added.
platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Added.
svg/as-background-image/svg-as-background-6-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-6-expected.txt.

10:18 PM Changeset in webkit [114482] by sfalken@apple.com

3 edits in branches/safari-534.57-branch/WebKitLibraries

Merge r97323.

9:52 PM Changeset in webkit [114481] by morrita@google.com

3 edits
2 adds in trunk

ShadowRoot shouldn't be adopted by any Document.
https://bugs.webkit.org/show_bug.cgi?id=84127

Reviewed by Dimitri Glazkov.

Source/WebCore:

ShadowRoot cannot cannot be removed from its host, which means
ShadowRoot cannot be adopted by any Document directly because the
adoptNode() tries to remove it from its parent but it doesn't make
sense for ShadowRoot.

This change adds a guard to check such a case.

Test: fast/dom/shadow/adopt-node-with-shadow-root.html

dom/Document.cpp:

(WebCore::Document::adoptNode):

LayoutTests:

fast/dom/shadow/adopt-node-with-shadow-root-expected.txt: Added.
fast/dom/shadow/adopt-node-with-shadow-root.html: Added.

9:40 PM Changeset in webkit [114480] by jer.noble@apple.com

1 edit
1 delete in trunk/LayoutTests

REGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84226

Remove expected failing results ﬅor media/video-playing-and-pause.html.

platform/mac-wk2/media/video-playing-and-pause-expected.txt: Removed.

9:04 PM Changeset in webkit [114479] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, revert temporal expectation changeset (114248)
https://bugs.webkit.org/show_bug.cgi?id=84024

platform/chromium/test_expectations.txt:

8:54 PM Changeset in webkit [114478] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG should not attempt to get rare case counts for op_mod on ARM
https://bugs.webkit.org/show_bug.cgi?id=84218

Reviewed by Geoff Garen.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

dfg/DFGCommon.h:

(JSC::DFG::isX86):
(DFG):

8:42 PM Changeset in webkit [114477] by commit-queue@webkit.org

2 edits in trunk/Source

BumpPointerAllocator assumes page size is less than MINIMUM_BUMP_POOL_SIZE
https://bugs.webkit.org/show_bug.cgi?id=80912

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-17
Reviewed by Hajime Morita.

wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::create):

8:34 PM Changeset in webkit [114476] by ap@apple.com

9 edits
1 move
2 adds in trunk/Source/WebKit2

[Mac] USPS Shipping label prints without barcode
https://bugs.webkit.org/show_bug.cgi?id=84099
<rdar://problem/11133877>

Reviewed by Sam Weinig.

Use PDFDocuemnt instead of CGPDFDocument when printing PDFs, because PDFKit knows
how to draw PDF buttons, and CG does not.

Shared/mac/PDFKitImports.h: Added.
Shared/mac/PDFKitImports.mm: Added.
UIProcess/API/mac/WKPrintingView.mm:

Moved code for dealing with dynamically loaded PDFKit from WKPrintingView, as we
now also need it elsewhere.

WebKit2.xcodeproj/project.pbxproj: Added
WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Rebamed to .mm.

WebProcess/Plugins/PDF/BuiltInPDFView.h: Changed m_pdfDocument to PDFDocument.

WebProcess/Plugins/PDF/BuiltInPDFView.mm: Copied from Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp.

(WebKit::BuiltInPDFView::pdfDocumentDidLoad):
(WebKit::BuiltInPDFView::calculateSizes):
(WebKit::BuiltInPDFView::paintContent):
Changed m_pdfDocument to PDFDocument, and updated for the changes. We still use
CGPDF when drawing to screen though, because that doesn't affect USPS.

WebProcess/Plugins/Plugin.h: (WebKit::Plugin::pdfDocumentForPrinting): Updated

the type, and changed ifsed from CG to MAC, as we're now fully dependent on Cocoa.

WebProcess/Plugins/PluginView.h: (WebKit::PluginView::pdfDocumentForPrinting):

Ditto.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pdfDocumentForPrintingFrame):
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::computePagesForPrinting):
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):

WebProcess/WebPage/WebPage.h:

Moved PDF document printing code to WebPageMac.mm, as it's now Objective C.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::computePagesForPrintingPDFDocument):
(WebKit::roundCGFloat):
(WebKit::drawPDFPage): While moving, also fixed a logic error in calculating the box
(it used to intersect with an empty box).
(WebKit::WebPage::drawRectToPDFFromPDFDocument):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):

7:57 PM Changeset in webkit [114475] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

[chromium] Ensure RateLimiter waits for Swapbuffers completion
https://bugs.webkit.org/show_bug.cgi?id=83649

Patch by John Bauman <jbauman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

We were waiting only on the canvas context, which with the new GPU
scheduling was causing the RateLimiter not to ratelimit enough. We
need to insert no-op commands in the compositor context, so that we'll
wait for the canvas context and SwapBuffers as well.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::doNoOp):
(WebCore):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/RateLimiter.cpp:

(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::rateLimitContext):

platform/graphics/chromium/RateLimiter.h:

(RateLimiterClient):
(WebCore):
(RateLimiter):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::forceNoOpCommand):
(WebCore):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::forceNoOpCommand):
(WebCore):
(WebCore::CCThreadProxy::forceNoOpCommandOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

7:49 PM Changeset in webkit [114474] by kling@webkit.org

3 edits in trunk/Source/WebCore

CSSValuePool: Made identifier value cache a fixed-size array.
<http://webkit.org/b/84219>

Reviewed by Antti Koivisto.

Change the identifier CSSPrimitiveValue cache in CSSValuePool from a HashMap to a
fixed-size array of RefPtr<CSSPrimitiveValue>s.

We have ~700 values total, so this is quite space efficient now that the CSSValuePool
is globally shared. More importantly it avoids a hash lookup every time we need an
identifier value.

css/CSSValuePool.h:
css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createIdentifierValue):

7:48 PM April 2012 Meeting edited by rniwa@webkit.org

For logistical reasons, test importing session needs to take place … (diff)

6:13 PM April 2012 Meeting edited by skyul@company100.net

(diff)

6:10 PM April 2012 Meeting edited by skyul@company100.net

(diff)

6:08 PM April 2012 Meeting edited by skyul@company100.net

(diff)

5:52 PM Changeset in webkit [114473] by piman@chromium.org

7 edits in trunk/Source

[Chromium] Clean up texture ids on the impl side when losing the context
https://bugs.webkit.org/show_bug.cgi?id=84122

Reviewed by James Robinson.

Tested by CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext.

platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::didLoseContext):

platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::didLoseContext):
(WebCore):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::didLoseContext):
(WebCore):

platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

5:33 PM Changeset in webkit [114472] by fpizlo@apple.com

12 edits in branches/dfgopt/Source/JavaScriptCore

DFG should have out-of-line slow paths
https://bugs.webkit.org/show_bug.cgi?id=83992

Reviewed by Oliver Hunt.

Introduces the notion of slow path code generation closures in the DFG.
These are defined in DFGSlowPathGenerator.h, though they are fairly
extensible so DFGSpeculativeJIT64.cpp and DFGSpeculativeJIT32_64.cpp
define a couple special-purpose ones. A slow path generation closure
(DFG::SlowPathGenerator) is executed after the main speculative path is
generated. This makes them great for scheduling slow path code out of
the way of the hot paths.

This patch also converts most - but not all - of the DFG to use slow
path generators instead of inline slow paths.

The result is a sub-1% improvement on SunSpider and V8, and a miniscule
regression on Kraken.

JavaScriptCore.xcodeproj/project.pbxproj:
assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
(TrustedImmPtr):
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

bytecode/StructureStubInfo.h:
dfg/DFGCommon.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGJITCompiler.h:

(DFG):
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
(JITCompiler):

dfg/DFGSilentRegisterSavePlan.h: Added.

(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):

dfg/DFGSlowPathGenerator.h: Added.

(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

dfg/DFGSpeculativeJIT.h:

(DFG):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

5:31 PM Changeset in webkit [114471] by eae@chromium.org

3 edits in trunk/Source/WebCore

Change RenderThemeChromiumSkia paint methods to use pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=84175

Reviewed by Eric Seidel.

No new tests, no change in functionality.

Change RenderThemeChromiumSkia to use subpixel types and pixel snap
values just before painting.

rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

rendering/RenderThemeChromiumSkia.h:

2012-04-17 Levi Weintraub <leviw@chromium.org>

Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209

Reviewed by Eric Seidel.

Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.

platform/graphics/FractionalLayoutPoint.h:

(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.

rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.

rendering/RenderText.h:

(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.

5:30 PM Changeset in webkit [114470] by leviw@chromium.org

8 edits in trunk/Source/WebCore

2012-04-17 Levi Weintraub <leviw@chromium.org>

Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209

Reviewed by Eric Seidel.

Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.

platform/graphics/FractionalLayoutPoint.h:

(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.

rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
rendering/RenderTable.cpp:

rendering/RenderText.h:

(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.

5:29 PM Changeset in webkit [114469] by dpranke@chromium.org

2 edits in trunk/Tools

build-webkit: make ninja work with chromium linux
https://bugs.webkit.org/show_bug.cgi?id=84213

Reviewed by Eric Seidel.

Fix typos so that build-webkit will use ninja to
build chromium if a build.ninja file exists and is up-to-date.

Scripts/webkitdirs.pm:

(determineIsChromiumNinja):

5:24 PM Changeset in webkit [114468] by macpherson@chromium.org

2 edits in trunk/Source/WebCore

Ensure CSSParser member variables are initialized.
https://bugs.webkit.org/show_bug.cgi?id=84205

Reviewed by Andreas Kling.

No new tests / code cleanup only.

css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):

5:19 PM Changeset in webkit [114467] by Alexandru Chiculita

2 edits in trunk/Source/WebCore

Regression(114172): Use after free in CustomFilterProgram::notifyClients
https://bugs.webkit.org/show_bug.cgi?id=84000

Reviewed by Dean Jackson.

The function returned early and the shaders didn't have a chance to be saved. Moving
those two lines before the return false just to make sure that FilterEffectRenderer never adds
itself as a client for a shader without keeping track of that.

No new tests. The problem reproduces with existing tests.
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/effect-custom-combined-missing.html

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

4:44 PM Changeset in webkit [114466] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Re-enable W3C canPlayType() tests on Chromium
https://bugs.webkit.org/show_bug.cgi?id=84164

They use the new expectations override from changeset 112937 and pass after http://crrev.com/132463.

Unreviewed, layout test expectations update.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-17

platform/chromium/test_expectations.txt:

4:26 PM Changeset in webkit [114465] by jer.noble@apple.com

1 edit
1 delete in trunk/LayoutTests

REGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84206

Remove expected failing test results for fast/harness/use-page-cache.html.

platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Removed.

4:26 PM Changeset in webkit [114464] by commit-queue@webkit.org

3 edits
5 adds in trunk

IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
https://bugs.webkit.org/show_bug.cgi?id=60746

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Ojan Vafai.

Source/WebCore:

When iterating backwards with PREV_NO_DUPLICATE, keep walking past
the 'prev' key until it changes, then walk forward one time. This
covers the object store and index cases.

Test: storage/indexeddb/mozilla/index-prev-no-duplicate.html

Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

LayoutTests:

Test for PREV_NO_DUPLICATE.

storage/indexeddb/cursor-prev-no-duplicate.html: Added.
storage/indexeddb/cursor-prev-no-duplicate.txt: Added.
storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: Added.
storage/indexeddb/mozilla/index-prev-no-duplicate.html: Added.
storage/indexeddb/resources/cursor-prev-no-duplicate.js: Added.

(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(runAllTests):
(waitFor):
(complete.fireCallback):
(complete):
(testFarRangeCursor):
(makeOpenKeyCursor):
(runTest.trans.oncomplete):
(runTest.testFunction):
(runTest):

4:20 PM Changeset in webkit [114463] by yutak@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, unskip some WebSocket worker tests that should not be skipped.

platform/chromium/test_expectations.txt:

4:17 PM Changeset in webkit [114462] by reed@google.com

2 edits in trunk/LayoutTests

need to rebaseline after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84184

Unreviewed. expectations change only.

platform/chromium/test_expectations.txt:

4:12 PM April 2012 Meeting edited by ojan@chromium.org

(diff)

4:10 PM Changeset in webkit [114461] by yi.4.shen@nokia.com

3 edits
2 adds in trunk

Caret is not rendered properly inside an input element with text-indent
https://bugs.webkit.org/show_bug.cgi?id=82688

Reviewed by Ryosuke Niwa.

For an empty input element, there is no RenderText. Instead, RenderBlock::localCaretRect provides
the caret position for rendering the caret in the empty input element. To get correct caret rect,
textIndentOffset() should be used to adjust the caret's position.

Source/WebCore:

Test: editing/style/text-indent.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):

LayoutTests:

editing/style/text-indent-expected.txt: Added.
editing/style/text-indent.html: Added.

4:08 PM Changeset in webkit [114460] by ojan@chromium.org

2 edits in trunk/Tools

Add caching to the flakiness dashboard json files
https://bugs.webkit.org/show_bug.cgi?id=84198

Reviewed by Dirk Pranke.

TestResultServer/handlers/testfilehandler.py:

(GetFile._get_file_list):
(GetFile._get_file_content):
(GetFile._get_file_content_from_key):
(GetFile._get_test_list_json):
(GetFile._serve_json):
Add a Last-Modified header and handle If-Modified-Since headers.
(GetFile.get):

4:03 PM Changeset in webkit [114459] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Attempt to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

4:02 PM Changeset in webkit [114458] by rafaelw@chromium.org

2 edits in trunk/Source/WebKit/chromium

[MutationObservers] enable V8RecursionScope debug ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=84094

Reviewed by Ojan Vafai.

This patch enables the ASSERT() which enforces usage of
V8RecursionScope.

src/WebKit.cpp:

(WebKit::assertV8RecursionScope):

4:01 PM Changeset in webkit [114457] by fpizlo@apple.com

7 edits in trunk/Source

It should be possible to create an inheritorID for the global this object without crashing
https://bugs.webkit.org/show_bug.cgi?id=84200
<rdar://problem/11251082>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

runtime/JSGlobalThis.h:

(JSC::JSGlobalThis::unwrappedObject):
(JSGlobalThis):

runtime/JSObject.cpp:

(JSC::JSObject::createInheritorID):

runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID):

Source/WebCore:

No new tests, because the circumstances necessary to make this happen are rather hairy.

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):

3:57 PM Changeset in webkit [114456] by Lucas Forschler

5 edits
4 copies in branches/safari-534.57-branch

Merge 109480.

3:56 PM Changeset in webkit [114455] by macpherson@chromium.org

2 edits in trunk/Source/WebCore

Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
https://bugs.webkit.org/show_bug.cgi?id=83544

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

The code as it stands appears to be correct, but static analysis was concerned that value could become null.
This patch adds a null check and ASSERT_NOT_REACHED() to make the code more obviously correct.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

3:54 PM Changeset in webkit [114454] by fpizlo@apple.com

1 copy in branches/dfgopt

New branch for JSC DFG work

3:51 PM Changeset in webkit [114453] by Lucas Forschler

4 edits in branches/safari-534.57-branch/Source/WebCore

Fix for 11238384.

3:48 PM Changeset in webkit [114452] by danakj@chromium.org

4 edits in trunk/Source

[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
https://bugs.webkit.org/show_bug.cgi?id=84182

Reviewed by James Robinson.

Source/Platform:

Platform.gypi:

Source/WebKit/chromium:

WebKit.gyp:

3:43 PM Changeset in webkit [114451] by andersca@apple.com

13 edits in trunk

Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
fires while it's already unresponsive.

UIProcess/API/C/WKPage.h:
UIProcess/ResponsivenessTimer.cpp:

(WebKit):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):

UIProcess/ResponsivenessTimer.h:

(Client):

UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):

UIProcess/WebLoaderClient.h:

(WebLoaderClient):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit):

UIProcess/WebPageProxy.h:

(WebPageProxy):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit):

UIProcess/WebProcessProxy.h:

(WebProcessProxy):

Tools: Need a client callback for when the user tries to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add new client functions.

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

3:42 PM Changeset in webkit [114450] by commit-queue@webkit.org

12 edits
2 adds in trunk/Source

[Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=83972

Patch by David Reveman <reveman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

Source/WebCore:

Add TextureUploader class that allows us to add persistent GC3D state to the upload machinery.

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::textureUploader):
(LayerRendererChromium):

platform/graphics/chromium/TextureUploader.cpp: Added.

(WebCore):
(WebCore::AcceleratedTextureUploader::AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::~AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::uploadTexture):

platform/graphics/chromium/TextureUploader.h: Added.

(WebCore):
(TextureUploader):
(WebCore::TextureUploader::~TextureUploader):
(AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::create):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

platform/graphics/chromium/cc/CCTextureUpdater.h:

(WebCore):
(CCTextureUpdater):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

tests/CCTiledLayerTestCommon.h:

(FakeTextureUploader):
(WebKitTests::FakeTextureUploader::uploadTexture):
(WebKitTests):

tests/Canvas2DLayerChromiumTest.cpp:
tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

3:37 PM Changeset in webkit [114449] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property.xhtml

Unreviewed.

platform/chromium/test_expectations.txt:

3:32 PM Changeset in webkit [114448] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merged r107647.

3:29 PM Changeset in webkit [114447] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merged r112966.

3:23 PM Changeset in webkit [114446] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r111977.

3:17 PM Changeset in webkit [114445] by Lucas Forschler

4 edits in branches/safari-534.57-branch/WebKitLibraries

Merged r113649.

3:16 PM Changeset in webkit [114444] by macpherson@chromium.org

2 edits in trunk/Source/WebCore

Clean up CSSParser::parseFillRepeat().
https://bugs.webkit.org/show_bug.cgi?id=83547

Reviewed by Kentaro Hara.

Removed multiple unnecessary calls to m_valueList->current().
Restructured logic for parsing second value to make it clearer.

No new tests / code cleanup only.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFillRepeat):

3:15 PM Changeset in webkit [114443] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r113528.

3:09 PM Changeset in webkit [114442] by dpranke@chromium.org

2 edits in trunk/Tools

nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84190

Reviewed by Ojan Vafai.

LayoutTestHelper would exit when the user typed ctrl-c, but we
would attempt to write to it to shut it down, generating an
IOError.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.stop_helper):

3:04 PM Changeset in webkit [114441] by dpranke@chromium.org

3 edits in trunk/Tools

rename --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=84188

Reviewed by Ojan Vafai.

I thought this was done long ago; rename
--experimental-fully-parallel to just --fully-parallel and
remove the --no- switch that AFAIK no one uses.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

3:03 PM Changeset in webkit [114440] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

3:03 PM Changeset in webkit [114439] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r111108.

2:59 PM Changeset in webkit [114438] by Lucas Forschler

7 edits in branches/safari-534.57-branch

Merge 112023.

2:51 PM Changeset in webkit [114437] by jchaffraix@webkit.org

16 edits in trunk/Source/WebCore

Fix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83816

Reviewed by James Robinson.

No change in behavior expected.

This code adds several functions on RenderBoxModelObject to forward
to the associated layer. This removes the RenderLayer dependencies
at the call sites.

Currently only RenderBoxModelObject can be hardware accelerated as
we need a RenderLayer, this looks like the best place to put those
new functions.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::contentChanged):
(WebCore::RenderBoxModelObject::hasAcceleratedCompositing):
(WebCore::RenderBoxModelObject::startTransition):
(WebCore::RenderBoxModelObject::transitionPaused):
(WebCore::RenderBoxModelObject::transitionFinished):
(WebCore::RenderBoxModelObject::startAnimation):
(WebCore::RenderBoxModelObject::animationPaused):
(WebCore::RenderBoxModelObject::animationFinished):
(WebCore::RenderBoxModelObject::suspendAnimations):

rendering/RenderBoxModelObject.h:

Added the previous functions to hide the layer need.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasAcceleratedCompositing):

rendering/RenderLayer.h:

Removed the previous method as it was superseeded by the
one on RenderBoxModelObject. Also moved the ContentChangeType
enumaration.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentChanged):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):
Updated after the ContentChangeType enumaration move.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::reshape):

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::startAnimation):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::endAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):

rendering/RenderBox.cpp:

(WebCore::RenderBox::imageChanged):

rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):

rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):
Updated all those call sites to use the new functions. Also
removed unneeded RenderLayer.h include as we went.

2:49 PM Changeset in webkit [114436] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r110150.

2:43 PM Changeset in webkit [114435] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r110139.

2:41 PM Changeset in webkit [114434] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG and LLInt should not clobber the frame pointer on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84185
<rdar://problem/10767252>

Reviewed by Gavin Barraclough.

Changed LLInt to use a different register. Changed DFG to use one fewer
registers. We should revisit this and switch the DFG to use a different
register instead of r7, but we can do that in a subsequent step since
the performance effect is tiny.

dfg/DFGGPRInfo.h:

(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):

offlineasm/armv7.rb:

2:32 PM Changeset in webkit [114433] by aestes@apple.com

3 edits in trunk/Source/WebCore

-webkit-mask-box-image does not draw when layer tree flattening is enabled
https://bugs.webkit.org/show_bug.cgi?id=84111

Reviewed by Simon Fraser.

No new tests since taking pixel test results with
PaintBehaviorFlattenCompositingLayers set is not currently supported.
<https://bugs.webkit.org/show_bug.cgi?id=84110> tracks fixing this.

When painting mask images, we should take the non-composited path if
layers are being flattened.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintMask):

rendering/RenderBox.cpp:

(WebCore::RenderBox::paintMaskImages):

2:28 PM Changeset in webkit [114432] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/WebCore

Merge 114142.

1:56 PM Changeset in webkit [114431] by eae@chromium.org

2 edits in trunk/Source/WebCore

Rollout r114404 as it broke a couple of chromium builds.

platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):

1:48 PM Changeset in webkit [114430] by Lucas Forschler

5 edits in branches/safari-534.57-branch/Source

Versioning.

1:45 PM Changeset in webkit [114429] by Lucas Forschler

1 copy in branches/safari-534.57-branch

New Branch.

1:44 PM Changeset in webkit [114428] by Lucas Forschler

1 delete in branches/safari-534.57-branch

Remove branch.

1:32 PM Changeset in webkit [114427] by benm@google.com

4 edits
3 adds in trunk

localStorage.setItem can overwrite localStorage methods
https://bugs.webkit.org/show_bug.cgi?id=30996

Source/WebCore:

Update the JSC and V8 bindings such that if the name of the DOM
Storage property being retrieved is a match for a property in the
prototype, always return the prototype version. If there is a DOM
Storage key of the same name, it can still be retrieved via the
getItem method. This prevents storage methods from being
accidentally hidden. This brings WebKit behavior in line with the
de facto standard implemented by FireFox and IE.

Reviewed by Kentaro Hara.

Test: storage/domstorage/storage-functions-not-overwritten.html

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::V8Storage::namedPropertyGetter):

LayoutTests:

Add a test to verify that setting a DOM Storage key with the same name
as a function on the Storage object does not prevent that function
being called, but also that it can still be retrieved via the getItem
function.

Reviewed by Kentaro Hara.

storage/domstorage/script-tests/storage-functions-not-overwritten.js: Added.

(doWedgeThySelf):
(testStorage):
(runTest):

storage/domstorage/storage-functions-not-overwritten-expected.txt: Added.
storage/domstorage/storage-functions-not-overwritten.html: Added.

1:25 PM Changeset in webkit [114426] by scheib@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.

Unreviewed.

platform/chromium-mac-leopard/fast/text/international/bidi-menulist-expected.png: Added.

1:21 PM Changeset in webkit [114425] by eae@chromium.org

2 edits in trunk/Source/WebCore

Fix Chromium/Windows build broken by r114404.

platform/FractionalLayoutUnit.h:

1:17 PM Changeset in webkit [114424] by leviw@chromium.org

12 edits in branches/subpixellayout/Source/WebCore

Reverting ShadowData to integers, and applying the refactoring from Bug 84098. Also fixing a bug that only showed up in Mac WebKit2 related to the GraphicsContext function roundToDevicePixels, which doesn't when there's no transform (whoops).

1:08 PM Changeset in webkit [114423] by schenney@chromium.org

2 edits in trunk/LayoutTests

Reorganise Chromium test_expectations to group SVG expectations.

Unreviewed Chromium expectations change.

This is done to make future maintenance easier.

platform/chromium/test_expectations.txt:

1:05 PM Changeset in webkit [114422] by commit-queue@webkit.org

7 edits in trunk

EFL's LayoutTestController does not implement callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Martin Robinson.

Source/WebKit/efl:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related
test to be removed from the skip list.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::callShouldCloseOnWebView):

LayoutTests:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

platform/efl/Skipped:

1:05 PM Changeset in webkit [114421] by haraken@chromium.org

7 edits in trunk/Source/WebCore

[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103

Reviewed by Nate Chapin.

This patch improves the performance of a lot of DOM attribute
getters that return a string.

Improves the performance of Dromaeo/dom-attr.html(element.property) by 27.7%.
Improves the performance of Dromaeo/dom-attr.html(getAttribute) by 10.6%.
Improves the performance of div.id, div.className, div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.

The followings are the test results in my Linux desktop.

Performance test: Dromaeo/dom-attr.html
Total: 674.64runs/s -> 707.03runs/s (+ 4.8%)
getAttribute: 1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property: 1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute: 538.88runs/s -> 548.87runs/s (+ 1.9%)
element.property = value: 644.07runs/s -> 656.67runs/s (+ 2.0%)
element.expando = value: 219.76runs/s -> 207.14runs/s (- 6.8%)
element.expando: 578.77runs/s -> 554.67runs/s (- 4.2%)

Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id: 30.70ns -> 26.70ns (+15%)
div.className: 31.10ns -> 26.40ns (+18%)
div.nodeName: 37.70ns -> 33.00ns (+14%)
text.nodeValue: 31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)

Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/v8/V8Binding.cpp:

(WebCore::getElementStringAttr):

bindings/v8/V8Binding.h:

(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.

bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

1:01 PM Changeset in webkit [114420] by commit-queue@webkit.org

4 edits in trunk

[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
postProgressFinishedNotification() in order to send notifications all frames,
not just the main one.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

LayoutTests:

Unskip EFL test cases which rely on the DumpRenderTree support for
LayoutTestController's dumpFrameLoadCallbacks() and expect notifications for other
frame than the main one.

platform/efl/Skipped:

12:56 PM Changeset in webkit [114419] by commit-queue@webkit.org

13 edits in trunk

[EFL] Add setting API to enable/disable XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=83281

Source/WebKit/efl:

Add setting API to enable or disable WebKit's XSSAuditor to protect
from reflective cross-site scripting attacks. Also, emit the signal
'xss,detected' and provide addition information received from
XSSAuditor when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didDetectXSS):

ewk/ewk_frame.cpp:

(ewk_frame_xss_detected):

ewk/ewk_frame.h:
ewk/ewk_private.h:
ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_xss_auditor_get):
(ewk_view_setting_enable_xss_auditor_set):

ewk/ewk_view.h:

Tools:

Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
'xss,detected' in DRT to enable a test, which is expecting a line containing
'didDetectXSS' in the output when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onDidDetectXSS):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

Unskip tests in http/tests/security/xssAuditor

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

platform/efl/Skipped:

12:48 PM Changeset in webkit [114418] by Chris Fleizach

3 edits
2 adds in trunk

Crash in invalid index for _textMarkerForIndex
https://bugs.webkit.org/show_bug.cgi?id=84104

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):

LayoutTests:

platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Added.
platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html: Added.

12:44 PM Changeset in webkit [114417] by jer.noble@apple.com

15 edits in trunk

HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests; updated platform results which were previously rebaselined.

Use the correct CSS keyword for the -webkit-appearance of the full screen button.

css/mediaControls.css:

(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

platform/mac/media/controls-after-reload-expected.png:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-strict-expected.png:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-controls-rendering-expected.txt:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-display-toggle-expected.txt:
platform/mac/media/video-no-audio-expected.png:
platform/mac/media/video-no-audio-expected.txt:
platform/mac/media/video-playing-and-pause-expected.png:
platform/mac/media/video-playing-and-pause-expected.txt:

12:33 PM Changeset in webkit [114416] by schenney@chromium.org

2 edits
2 adds in trunk/LayoutTests

SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Unreviewed Chromium expectations update.

platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Added.
platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Added.
platform/chromium/test_expectations.txt:

12:30 PM Changeset in webkit [114415] by schenney@chromium.org

7 edits
1 add in trunk/LayoutTests

Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Unreviewed Chromium expectations update.

platform/chromium-linux/svg/custom/circle-move-invalidation-expected.png:
platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
platform/chromium-mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
platform/chromium-mac/svg/custom/circle-move-invalidation-expected.png: Added.
platform/chromium-win/svg/custom/circle-move-invalidation-expected.png:
platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
platform/chromium/test_expectations.txt:

12:24 PM Changeset in webkit [114414] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Make sure that the layer hosting mode is kept up to date if it changes before the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=84180
<rdar://problem/11265113>

Reviewed by Andreas Kling.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setLayerHostingMode):

12:23 PM Changeset in webkit [114413] by schenney@chromium.org

5 edits
1 add
1 delete in trunk/LayoutTests

onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Unreviewed Chromium expectations update.

platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
platform/chromium/test_expectations.txt:

12:22 PM Changeset in webkit [114412] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

use after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
https://bugs.webkit.org/show_bug.cgi?id=83942
<rdar://problem/11247370>

Reviewed by Gavin Barraclough.

Don't use references to the graph after resizing the graph.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushArgument):

12:19 PM Changeset in webkit [114411] by schenney@chromium.org

3 edits
4 adds in trunk/LayoutTests

getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Unreviewed Chromium expectations update.

platform/chromium-linux/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
platform/chromium-mac-leopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
platform/chromium-mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
platform/chromium-win/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
platform/chromium/test_expectations.txt:

12:15 PM Changeset in webkit [114410] by schenney@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed Chromium expectations update.

platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
platform/chromium/test_expectations.txt:

12:11 PM Changeset in webkit [114409] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

IndexedDB: stub getKey/getObject interfaces for IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=84089

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Dimitri Glazkov.

Added stub methods on WebIDBIndex.h to cleanly land
https://bugs.webkit.org/show_bug.cgi?id=83638

public/WebIDBIndex.h:

(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::getKey):

src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::getObject):
(WebKit):
(WebKit::WebIDBIndexImpl::getKey):

src/WebIDBIndexImpl.h:

(WebIDBIndexImpl):

12:10 PM Changeset in webkit [114408] by eae@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Fix pixel snapping in RenderThemeChromiumSkia on branch.

12:09 PM Changeset in webkit [114407] by schenney@chromium.org

4 edits
3 adds
2 deletes in trunk/LayoutTests

[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=53378

Unreviewed expectations update after the fix went in.

platform/chromium-linux-x86/svg/zoom: Removed.
platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
platform/chromium-win-xp/svg/zoom: Removed.
platform/chromium/test_expectations.txt:

12:03 PM Changeset in webkit [114406] by tsepez@chromium.org

19 edits
4 adds in trunk

Framesniffing defense is too aggressive.
https://bugs.webkit.org/show_bug.cgi?id=83721

Reviewed by James Robinson.

Source/WebCore:

The RenderLayer code currently propagates scroll position to parent frames
without any cross-origin checks. This gives it a quick origin boundary check
that is set by FrameLoader only when performing a fragment navigation. This
allows us to safely relax the restriction on not scrolling at load time in
FrameLoader since the safe thing will happen later on at scroll time.

Test: http/tests/navigation/anchor-frames-same-origin.html

dom/Document.cpp:

(WebCore::Document::findUnsafeParentScrollPropagationBoundary):

dom/Document.h:

(Document):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):

loader/FrameLoader.h:

(FrameLoader):

page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):

page/FrameView.h:

(WebCore::FrameView::safeToPropagateScrollToParent):
(WebCore::FrameView::setSafeToPropagateScrollToParent):
(FrameView):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests:

http/tests/inspector/resource-parameters-expected.txt:
http/tests/navigation/anchor-frames-cross-origin-expected.txt:
http/tests/navigation/anchor-frames-cross-origin.html:
http/tests/navigation/anchor-frames-same-origin-expected.txt: Added.
http/tests/navigation/anchor-frames-same-origin.html: Added.
http/tests/navigation/resources/frame-with-anchor-cross-origin.html:
http/tests/navigation/resources/frame-with-anchor-same-origin.html: Added.
http/tests/navigation/resources/grandchild-with-anchor.html: Added.
http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:

11:59 AM April 2012 Meeting edited by kov@webkit.org

(diff)

11:58 AM Changeset in webkit [114405] by barraclough@apple.com

8 edits in trunk

Array.prototype.toString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Reviewed by Sam Weinig.

Source/JavaScriptCore:

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

check for join function, use fast case if base object is array & join is present & default.

runtime/CommonIdentifiers.h:
- added 'join'.

LayoutTests:

fast/js/array-functions-non-arrays-expected.txt:
- check in new results
fast/js/array-prototype-properties-expected.txt:
- new more detailed error message.
fast/js/script-tests/array-functions-non-arrays.js:
- added new test cases, fix incorrect one.
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.2_Array_prototype_toString/S15.4.4.2_A2_T1-expected.txt:
- check in failing result (test is wrong)

11:51 AM Changeset in webkit [114404] by eae@chromium.org

2 edits in trunk/Source/WebCore

Add size_t versions of multiplication and division operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848

Reviewed by Julien Chaffraix.

Add size_t versions of operator* and operator/ for platforms where there
is no ambiguity between unsigned int and size_t.

No new tests, no new functionality.

platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):
(WebCore::operator*):
(WebCore::operator/):

11:45 AM Changeset in webkit [114403] by schenney@chromium.org

7 edits in trunk/LayoutTests

Update long-failing Chromium expectations.

Unreviewed Chromium expectation update.

There is some chance that the background test is flaky, as many others are.

platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
platform/chromium/test_expectations.txt:

11:35 AM Changeset in webkit [114402] by jer.noble@apple.com

4 edits in trunk/Source

Exiting full screen video brings the wrong Safari window to the foreground
https://bugs.webkit.org/show_bug.cgi?id=83936

Reviewed by Adele Peterson.

Tell the original webView's window to makeKeyAndOrderFront once the exit
animation completes.

Source/WebKit/mac:

WebView/WebFullScreenController.mm:

(-[WebFullScreenController finishedExitFullScreenAnimation:]):

Source/WebKit2:

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

11:21 AM Changeset in webkit [114401] by haraken@chromium.org

51 edits in trunk/Source/WebCore

[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

Modified as described above.
(GenerateHeader):
(NativeToJSValue):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

bindings/scripts/test/V8/V8Float64Array.h:

Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

11:20 AM Changeset in webkit [114400] by schenney@chromium.org

3 edits
4 adds
2 deletes in trunk/LayoutTests

Update Chromium test expectations for long failing tests.

Unreviewed Chromium test expectations update.

platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
platform/chromium-linux/svg/carto.net/combobox-expected.png: Added.
platform/chromium-linux/svg/carto.net/combobox-expected.txt: Removed.
platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
platform/chromium/test_expectations.txt:

11:19 AM Changeset in webkit [114399] by commit-queue@webkit.org

2 edits
7 adds in trunk/LayoutTests

[EFL] Create baselines for tests related to caret behaviour
https://bugs.webkit.org/show_bug.cgi?id=83277

Unreviewed, EFL baselines for tests related to cursor
positioning behaviour.

Adding baselines and unskipping tests related to cursor
positioning behaviour after r114250.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17

platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
platform/efl/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
platform/efl/test_expectations.txt:

11:11 AM Changeset in webkit [114398] by schenney@chromium.org

3 edits
1 add
2 deletes in trunk/LayoutTests

fill-opacity does not render properly on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=78624

Unreviewed expectations update after this change.

platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Removed.
platform/chromium-mac/svg/text/text-fill-opacity-expected.png: Added.
platform/chromium-win/svg/text/text-fill-opacity-expected.txt:
platform/chromium/test_expectations.txt:

11:01 AM Changeset in webkit [114397] by commit-queue@webkit.org

3 edits
1 add in trunk/Source/WebKit2

[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
https://bugs.webkit.org/show_bug.cgi?id=84142

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-04-17
Reviewed by Martin Robinson.

Create a cpp file needed to build EFL port with FULLSCREEN_API.

PlatformEfl.cmake: Added WebFullScreenManagerProxyEfl.cpp to build list.
UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

UIProcess/efl/WebFullScreenManagerProxyEfl.cpp: Added.

(WebKit):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

10:59 AM Changeset in webkit [114396] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
because it was fixed in r113808.

platform/chromium/test_expectations.txt: Removed flaky expectations.

10:57 AM Changeset in webkit [114395] by schenney@chromium.org

23 edits
6 adds
1 delete in trunk/LayoutTests

[Chromium] Rebaseline after Skia changes (CR105305)
https://bugs.webkit.org/show_bug.cgi?id=84165

Unreviewed Chromium expectations update.

platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
platform/chromium-linux/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
platform/chromium-linux/svg/text/selection-background-color-expected.png:
platform/chromium-linux/svg/text/selection-styles-expected.png:
platform/chromium-linux/svg/text/text-gradient-positioning-expected.png:
platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Modified property svn:mime-type.
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
platform/chromium-mac-leopard/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
platform/chromium-mac-leopard/svg/text/selection-styles-expected.png:
platform/chromium-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Modified property svn:mime-type.
platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
platform/chromium-mac/svg/css/composite-shadow-text-expected.png: Added.
platform/chromium-mac/svg/css/text-gradient-shadow-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/text/selection-styles-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/text/text-gradient-positioning-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Added.
platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png: Added.
platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Added.
platform/chromium-win/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
platform/chromium/test_expectations.txt:

10:51 AM April 2012 Meeting edited by stearns@adobe.com

(diff)

10:41 AM Changeset in webkit [114394] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp

Correct where we do our flooring for tables to be in setting the logical width, instead of at paint time. This avoids a bug where a 1 pixel gap would exist following a table that nothing could be placed in.

10:24 AM Changeset in webkit [114393] by schenney@chromium.org

6 edits
2 adds
8 deletes in trunk/LayoutTests

new baselines for crbug 104128
https://bugs.webkit.org/show_bug.cgi?id=72746

Unreviewed Chromium expectations update, just for SVG files.

platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png: Modified property svn:mime-type.
platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
platform/chromium/test_expectations.txt:
platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Removed.
platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Removed.
platform/mac/svg/css/shadow-with-large-radius-expected.txt: Removed.
platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Removed.
platform/qt/svg/css/shadow-with-large-radius-expected.txt: Removed.
platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Removed.
svg/css/shadow-with-large-radius-expected.txt: Added.
svg/css/shadow-with-negative-offset-expected.txt: Added.

10:17 AM Changeset in webkit [114392] by yurys@chromium.org

8 edits
1 add in trunk/Source/WebCore

Web Inspector: move heap snapshot data grids into their own file
https://bugs.webkit.org/show_bug.cgi?id=84160

Moved heap snapshot data grids into a separate file.

Reviewed by Pavel Feldman.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/DataGrid.js:
inspector/front-end/HeapSnapshotDataGrids.js: Added.

inspector/front-end/HeapSnapshotView.js:
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

10:12 AM Changeset in webkit [114391] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Script make_names.pl should generate consistent .h & .cpp files
https://bugs.webkit.org/show_bug.cgi?id=84140

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-17
Reviewed by Kentaro Hara.

Added a newline character and removed ';' after the DEFINE_GLOBAL

No test cases required for this change.

dom/make_names.pl:

(printNamesCppFile):

10:09 AM Changeset in webkit [114390] by commit-queue@webkit.org

14 edits
2 adds in trunk

Source/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
and propagate calls to the MediaPlayerPrivate interface.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

Test: http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html

html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::setSourceState):

html/HTMLMediaElement.h:

(HTMLMediaElement):

html/HTMLMediaElement.idl:
platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceAddId):
(WebCore::NullMediaPlayerPrivate::sourceRemoveId):
(WebCore):
(WebCore::MediaPlayer::sourceAddId):
(WebCore::MediaPlayer::sourceRemoveId):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceAddId):
(WebCore::MediaPlayerPrivateInterface::sourceRemoveId):

Source/WebKit/chromium: Add sourceAddId() & sourceRemoveId() stubs for Chromium.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceAddId):
(WebKit::WebMediaPlayer::sourceRemoveId):

src/AssertMatchingEnums.cpp:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceAddId):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceRemoveId):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests: Add LayoutTests for new webkitSourceAddId() & webkitSourceRemoveId() methods.
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added.
platform/chromium/test_expectations.txt:

10:04 AM April 2012 Meeting edited by dmazzoni@google.com

(diff)

10:03 AM April 2012 Meeting edited by Theresa O'Connor

i would attend several of these talks :) (diff)

10:02 AM April 2012 Meeting edited by enne@google.com

(diff)

10:02 AM April 2012 Meeting edited by enne@google.com

(diff)

9:41 AM Changeset in webkit [114389] by abecsi@webkit.org

10 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor the gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=83044

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

This patch implements a simple decision tree in the web page event handler
on the basis of how many active touch points the current touch event has.

Active touch points are pressed, moved or stationary and the number of these
fully determine which gesture recognizer should be updated, cancelled or
finished.

This new structure makes the internal states of the pinch and pan gesture
recognizers independent from the event type, thus makes it possible to handle
the transitions between these gestures in one centralized place which reduces
code duplication and complexity and fixes some issues regarding incorrectly
handled transitions.

UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit):
(WebKit::QtPanGestureRecognizer::cancel):

UIProcess/qt/QtPanGestureRecognizer.h:

(QtPanGestureRecognizer):

UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit):
(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):

UIProcess/qt/QtPinchGestureRecognizer.h:

(QtPinchGestureRecognizer):

UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit):

UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):

9:31 AM Changeset in webkit [114388] by apavlov@chromium.org

3 edits
2 adds in trunk

Web Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with open Inspector
https://bugs.webkit.org/show_bug.cgi?id=84154

Source/WebCore:

Check that a node inserted actually has a parent.

Reviewed by Yury Semikhatsky.

Test: inspector/elements/elements-panel-reload-assert.html

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didInsertDOMNode):

LayoutTests:

Reviewed by Yury Semikhatsky.

inspector/elements/elements-panel-reload-assert-expected.txt: Added.
inspector/elements/elements-panel-reload-assert.html: Added.

9:26 AM Changeset in webkit [114387] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
https://bugs.webkit.org/show_bug.cgi?id=77533

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-17
Reviewed by Simon Hausmann.

Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
the corresponding parameter to the buildQMakeProjects function.

Scripts/build-jsc:

9:13 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

9:13 AM Changeset in webkit [114386] by commit-queue@webkit.org

12 edits in trunk

[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit "load,started" and "onload,event" signals needed to support
LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

ewk/ewk_frame.cpp:

(ewk_frame_load_committed):
(ewk_frame_load_started):

ewk/ewk_frame.h:
ewk/ewk_private.h:
ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_load_started):
(ewk_view_onload_event):

ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. Make use of the new frame argument passed to
the "load,started" and "load,finished" signals.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

platform/efl/Skipped:

9:12 AM Changeset in webkit [114385] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149

Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.

Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.

Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.

webkit/webkitwebview.cpp:

(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)

9:10 AM Changeset in webkit [114384] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

REGRESSION(r113172) Wheel events are scrolling inversed.
https://bugs.webkit.org/show_bug.cgi?id=84156

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

8:50 AM Changeset in webkit [114383] by danakj@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

8:38 AM Changeset in webkit [114382] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148

Reviewed by Pavel Feldman.

TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.

inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):

8:37 AM Changeset in webkit [114381] by commit-queue@webkit.org

13 edits in trunk

Unreviewed, rolling out r114376.
http://trac.webkit.org/changeset/114376
https://bugs.webkit.org/show_bug.cgi?id=84155

Wrong patch version committed, asked by the patch author.
(Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-17

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

ewk/ewk_frame.cpp:
ewk/ewk_frame.h:
ewk/ewk_private.h:
ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):

ewk/ewk_view.h:

Tools:

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onWillSendRequest):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

platform/efl/Skipped:

8:20 AM Changeset in webkit [114380] by mifenton@rim.com

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pattern matching should be applied to numbers
https://bugs.webkit.org/show_bug.cgi?id=84152

Reviewed by Antonio Gomes.

PR 148906.

Add pattern matching for number based on [0-9] to trigger
input help matching number fields.

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
(BlackBerry::WebKit::DOMSupport::elementPatternMatches):

WebKitSupport/DOMSupport.h:
WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):

8:20 AM Changeset in webkit [114379] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION (r105453): Crash when handling touch events
https://bugs.webkit.org/show_bug.cgi?id=81958

Patch by Yong Li <yoli@rim.com> on 2012-04-17
Reviewed by Antonio Gomes.

Add a manual test for this issue because DumpRenderTree
currently cannot send a group of touch points with
different touch states in one shot.

ManualTests/resources/iframe-reloaded-on-touch.html: Added.
ManualTests/touch-stale-iframe-crash.html: Added.

Source/WebCore:

Always perform sanity checks when handling every touch point
because the node and document may have been destroyed or detached.

ManualTests/touch-stale-iframe-crash.html added.
(DumpRenderTree doesn't support transiting touch states in one shot yet)

page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

8:18 AM Changeset in webkit [114378] by schenney@chromium.org

2 edits
1 add
1 delete in trunk/LayoutTests

[Chromium] Rebaseline svg/carto.net/colourpicker.svg

Unreviewed Chromium test expectations update.

This test has been marked as failing for so long that its result is
always wrong. Rebaselining to review flakiness.

platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
platform/chromium/test_expectations.txt:

8:06 AM Changeset in webkit [114377] by schenney@chromium.org

36 edits
12 adds
5 deletes in trunk/LayoutTests

[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
https://bugs.webkit.org/show_bug.cgi?id=84150

Unreviewed Chromium test expectations update.

fast/repaint/background-misaligned-expected.txt: Added.
platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium-win-vista/fast/repaint: Added.
platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
platform/chromium-win-xp/svg/as-border-image: Removed.
platform/chromium-win/fast/repaint/background-misaligned-expected.png:
platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
platform/chromium/test_expectations.txt:
platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.

8:02 AM Changeset in webkit [114376] by commit-queue@webkit.org

13 edits in trunk

[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
from postProgressFinishedNotification() since it is already emitted
from dispatchDidFinishLoad(). This avoids unwanted extra signals we
prevent some tests from passing (e.g.
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).

WebCoreSupport/FrameLoaderClientEfl.cpp:

WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

ewk/ewk_frame.cpp:

(ewk_frame_load_committed):

ewk/ewk_frame.h:
ewk/ewk_private.h:
ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_onload_event):

ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

platform/efl/Skipped:

7:15 AM Changeset in webkit [114375] by kbalazs@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Unreviewed ARM build fix

PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::PluginProcessMain): Export this function.

7:02 AM Changeset in webkit [114374] by commit-queue@webkit.org

5 edits
3 adds in trunk

Asserts in XMLHttpRequestProgressEventThrottle
https://bugs.webkit.org/show_bug.cgi?id=81506

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Julien Chaffraix.

Source/WebCore:

The asserts were incorrectly triggered because suspending active DOM objects
(which suspends the XMLHttpRequestProgressEventThrottle) doesn't stop JavaScript
from running or suspend any running loader we may have. The previous code would
assume those 2 cases were impossible.

When XmlHttpRequest::open is called or data is received while the XmlHttpRequest object
is suspended the object may attempt to dispatch events. This patch defers these events
until the object is resumed.

Progress events are coalesced similar to normal throttling, and readystate-change events
are coalesced to avoid identical events emitted right after eachother.

On resume the events are dispatched after a timer to avoid interfering with
ScriptExecutionContext which is iterating over suspended objects.

Test: fast/events/pagehide-xhr-open.html

xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
(WebCore::XMLHttpRequestProgressEventThrottle::resume):

xml/XMLHttpRequestProgressEventThrottle.h:

(XMLHttpRequestProgressEventThrottle):

LayoutTests:

Tests that xmlhttprequest.open does not assert in when called from onpagehide.

fast/events/pagehide-xhr-open-expected.txt: Added.
fast/events/pagehide-xhr-open.html: Added.
fast/events/resources/subframe-xmlhttprequest.html: Added.
platform/chromium/test_expectations.txt:

6:44 AM Changeset in webkit [114373] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035

Reviewed by Pavel Feldman.

Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.

inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

6:35 AM Changeset in webkit [114372] by loislo@chromium.org

1 edit
1 move in trunk/PerformanceTests

Web Inspector: the fix for test after massive rename in r114271.
https://bugs.webkit.org/show_bug.cgi?id=84147

Drive by fix. The test was renamed to heap-snapshot.html

Reviewed by Yury Semikhatsky.

inspector/heap-snapshot.html: Renamed from PerformanceTests/inspector/detailed-heapshots-smoke-test.html.

6:30 AM WebKit Team edited by pilgrim@chromium.org

(diff)

6:29 AM Changeset in webkit [114371] by commit-queue@webkit.org

2 edits in trunk/Tools

[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
https://bugs.webkit.org/show_bug.cgi?id=83035

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

The force_static_libs_as_shared feature for the Qt port will remove
hide_symbols from Qt's CONFIG in order to make them visible to other
libraries again.

Due to an evaluation order problem in qmake, the flags for the C++ compiler
that are set by adding hide_symbols to the CONFIG variables get applied
to qmake's C++ compiler flags directly and hence trying to remove these
later will not work and cause build failures when using the force_static_libs_as_shared
feature of the Qt port.

This is fixed by removing the flags that hide the exports from the compiler flags directly.

qmake/mkspecs/features/force_static_libs_as_shared.prf:

6:14 AM Changeset in webkit [114370] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] Zoom out on second double-tap.
https://bugs.webkit.org/show_bug.cgi?id=84145

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

6:10 AM Changeset in webkit [114369] by reed@google.com

2 edits in trunk/LayoutTests

Need to rebaseline these images after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84144

Unreviewed. Expectations change only

platform/chromium/test_expectations.txt:

6:03 AM Changeset in webkit [114368] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [regression r112413]content scripts tree outline is not added to the tab.
https://bugs.webkit.org/show_bug.cgi?id=84146

Reviewed by Vsevolod Vlasov.

Adding the tree to the container.

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):

4:56 AM Changeset in webkit [114367] by commit-queue@webkit.org

31 edits in trunk/Source

[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=83285

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

platform/ContextMenuItem.h: Remove macro around enums - needed by InjectedBundle.

(WebCore):

platform/Widget.h: Remove namespace WebCore for PlatformPageClient typedef.

Source/WebKit/efl:

Remove WebCore namespace from PageClientEfl.

WebCoreSupport/PageClientEfl.cpp:

(WebCore):

WebCoreSupport/PageClientEfl.h:
ewk/ewk_private.h:

(EWKPrivate):

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(EWKPrivate::corePageClient):

Source/WebKit2:

Surround code related to context menu with ENABLE(CONTEXT_MENUS) macro.
Add dummy functions for public API implementation related to context menu.

Shared/API/c/WKContextMenuItem.cpp:

(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):

Shared/WebContextMenuItem.cpp:
Shared/WebContextMenuItem.h:
Shared/WebContextMenuItemData.cpp:
Shared/WebContextMenuItemData.h:
UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):

UIProcess/WebPageContextMenuClient.cpp:
UIProcess/WebPageContextMenuClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit):

UIProcess/WebPageProxy.h:

(WebPageProxy):

UIProcess/WebPageProxy.messages.in:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):

WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
WebProcess/WebCoreSupport/WebContextMenuClient.h:
WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:
WebProcess/WebPage/WebContextMenu.cpp:
WebProcess/WebPage/WebContextMenu.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebPage/WebPage.messages.in:

4:53 AM Changeset in webkit [114366] by mario@webkit.org

4 edits in trunk/LayoutTests

Unreviewed, fix wrong paths to JS resources in GTK tests.

platform/gtk/accessibility/aria-list-and-listitem.html:
platform/gtk/accessibility/aria-option-role.html:
platform/gtk/accessibility/aria-option-role-expected.txt: Fixed

typo in the expected output.

4:36 AM Changeset in webkit [114365] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.

Patch by JÃ¡nos Badics <János Badics> on 2012-04-17

platform/qt-5.0/Skipped:

4:35 AM Changeset in webkit [114364] by Csaba Osztrogonác

2 edits
4 adds in trunk/LayoutTests

[Qt] Rebaseline and add platform specific expectations, after r114283.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-04-17
Reviewed by Csaba Osztrogonác.

platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:

4:05 AM Changeset in webkit [114363] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update expectations for worker WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=84125

Add BUGWK84125 and mark as CRASH.

platform/chromium/test_expectations.txt:

3:58 AM Changeset in webkit [114362] by mario@webkit.org

2 edits
2 moves
5 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113981.

accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt.
accessibility/aria-labelledby-stay-within-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-stay-within-expected.txt.
platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Added.
platform/gtk/accessibility/aria-list-and-listitem.html: Added.
platform/gtk/accessibility/aria-option-role-expected.txt: Added.
platform/gtk/accessibility/aria-option-role.html: Added.
platform/gtk/accessibility/lists-expected.txt: Added.
platform/gtk/test_expectations.txt:

2:48 AM Changeset in webkit [114361] by staikos@webkit.org

2 edits in trunk/Source/WebKit/blackberry

Export the initialization function so it can be called earlier.
https://bugs.webkit.org/show_bug.cgi?id=84134

Reviewed by Nikolas Zimmermann.

Api/BlackBerryGlobal.h: export globalInitialize()

(WebKit):

1:37 AM April 2012 Meeting edited by rniwa@webkit.org

(diff)

1:36 AM Changeset in webkit [114360] by tkent@chromium.org

7 edits in trunk/Source/WebCore

Introduce an internal feature for a fixed placeholder
https://bugs.webkit.org/show_bug.cgi?id=84009

Reviewed by Hajime Morita.

This change adds a framework to support fixed placeholder string for
textfield-like <input> without the palceholder attribute support. This
doesn't change any behavior of input types which support the
'placeholder' attribute.

According to the standard, <input type=date> doesn't support the
'placeholder' attribute. However it is a kind of text field in WebKit
platforms with ENABLE_CALENDAR_PICKER, and we may show something useful
information as the default placeholder.

No new tests because of no behavior changes.

html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement): Make isPlaceholderEmpty() virtual.

html/HTMLInputElement.h:

(HTMLInputElement): Overrides isPlaceholderEmpty().

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isPlaceholderEmpty):
Check InputType::defaultPlaceholder() if InputType::usesFixedPlaceholder().

html/InputType.cpp:

(WebCore::InputType::usesFixedPlaceholder): Added. Returns false.
(WebCore::InputType::fixedPlaceholder): Added. Returns a null string.

html/InputType.h:

(InputType): Add usesFixedPlaceholder() and fixedPlaceholder().

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):
Uses fixedPlaceholder() instead of strippedPlaceholder() if usesFixedPlaceholder().

1:20 AM Changeset in webkit [114359] by tkent@chromium.org

4 edits
1 copy in trunk/Source/WebCore

Move some code of LocalizedNumberICU.cpp to ICULocale.cpp
https://bugs.webkit.org/show_bug.cgi?id=84128

Reviewed by Hajime Morita.

No new tests. No behavior change.

WebCore.gypi: Add ICULocale.cpp
platform/text/ICULocale.cpp:

Added. Move some code from LocalizedNumberICU.cpp

platform/text/ICULocale.h:

(ICULocale): Add currentLocale().

platform/text/LocalizedNumberICU.cpp:

(WebCore::convertToLocalizedNumber): Use ICULocale::currentLocale().
(WebCore::convertFromLocalizedNumber): ditto.

12:47 AM Changeset in webkit [114358] by Simon Hausmann

2 edits in trunk/Source/WebCore

[Plugins] delete ws_info regardless of window mode.
https://bugs.webkit.org/show_bug.cgi?id=83004

Patch by Bang Kwang min <justine.bang@samsung.com> on 2012-04-17
Reviewed by Simon Hausmann.

m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
Every plugin works well after this patch without any crash.
Additionally, change casting syntax to C++ style.

plugins/PluginView.cpp:

(WebCore::PluginView::stop):

12:40 AM Changeset in webkit [114357] by tkent@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Calendar Picker: Popup position is wrong when there are
no enough space below the target date field
https://bugs.webkit.org/show_bug.cgi?id=84007

Reviewed by Hajime Morita.

The popup was detached from the origin element because
calendarPicker.js resizes its window. To fix this bug, we move the
window position vertically when it is resized.

No new tests. This is not testable in WebKit.

src/WebPagePopupImpl.cpp:

(WebKit::PagePopupChromeClient::setWindowRect):
If this request is just a resize and m_isPutAboveOrigin is true,
update the vertical position so that the popup attaches to the
origin rectangle.
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_isPutAboveOrigin with false.
(WebKit::WebPagePopupImpl::init): Set m_isPutAboveOrigin true.

src/WebPagePopupImpl.h:

(WebPagePopupImpl): Add m_isPutAboveOrigin.

12:30 AM Changeset in webkit [114356] by tkent@chromium.org

5 edits in trunk

Calendar Picker: Support RTL layout
https://bugs.webkit.org/show_bug.cgi?id=83668

Reviewed by Hajime Morita.

ManualTests/forms/calendar-picker.html:

Add Arabic parameters.
Add <select> to select a locale.

Source/WebCore:

Manual test: ManualTests/forms/calendar-picker.html

Resources/calendarPicker.js:

(layout): If params.isRTL, add dir=rtl to the body.
(DaysTable.prototype._handleKey): Reverse Left and Right cursor keys if RTL.

html/shadow/CalendarPickerElement.cpp:

(WebCore::addProperty): Add addProperty() with a bool value.
(WebCore::CalendarPickerElement::writeDocument):
Check the direction of the first character of localized January label,
and pass it as isRTL property.

12:21 AM Changeset in webkit [114355] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.

platform/qt/Skipped:

12:18 AM Changeset in webkit [114354] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations.

platform/chromium/test_expectations.txt:

12:18 AM Changeset in webkit [114353] by rniwa@webkit.org

2 edits in trunk/Tools

Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
https://bugs.webkit.org/show_bug.cgi?id=84068

Reviewed by Eric Seidel.

Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
automatically creates the build directory if needed.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

Apr 16, 2012:

11:51 PM April 2012 Meeting edited by vestbo@webkit.org

(diff)

11:45 PM Changeset in webkit [114352] by Carlos Garcia Campos

4 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

GNUmakefile.list.am: Add missing files.

Source/WebCore:

GNUmakefile.list.am: Add missing files.

11:40 PM Changeset in webkit [114351] by commit-queue@webkit.org

106 edits
1 add in trunk/Source/WebCore

insertedIntoDocument and insertedIntoTree should be unitifed.
https://bugs.webkit.org/show_bug.cgi?id=82701

Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
served as lifecycle callbacks which are invoked when a node is
inserted into its new parent. There are also removedFromTree()
and removedFromDocument() respectively. Considering that this pair
of virtual functions are laid onto the hot path, it's worth
merging them into one, to gain some speedup. Such
unification could clarify the semantics as well.

This change makes following change to merge these functions.

pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
letting new Node::insertInto() do the job for its own, but not for its children and
Pass the parent of each insertion root as a parameter of insertedInto(). This root node can tell inserted node where it is inserted, specifically whetehr the insertion is to the document or not.

Same pattern is also applied to Node::removedFromDocument() and
Node::removedFromTree(), which are factored to Node::removedFrom()
and ChildNodeRemovalNotifier respectively.

Speed up on Dromaeo/dom-modify.html is about 2%.
Further speed-up by de-virtulization would be possible.

Caveat:

There is possible situation where a node need to invoke
insertedInto() after its children is nofitied, instead of before
that. It was represented naturally with previous
traversal-by-ContainerNode pattern, but is no longer simple with
this new external traversal. To support this scenario, we
introduced the InsertionNotificationRequest as a return value of insertedInto()
and a supplemental hook Node::didNotifyDescendantInseretions(). See for
example HTMLFormElement.cpp to learn how it works.

No new tests. Covered by existing tests.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
(WebCore::updateTreeAfterInsertion):

dom/ContainerNode.h:

(ContainerNode):
(WebCore::Node::highestAncestor):
(WebCore):

dom/ContainerNodeAlgorithms.cpp: Added.

(WebCore):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):

dom/ContainerNodeAlgorithms.h:

(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
(WebCore):
(ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(Private):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
(WebCore::ChildNodeRemovalNotifier::notify):

dom/DOMAllInOne.cpp:
dom/DocumentType.cpp:

(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):

dom/DocumentType.h:

(DocumentType):

dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):

dom/Element.h:

(Element):

dom/Node.cpp:

(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):

dom/Node.h:

(Node):
(WebCore::Node::didNotifyDescendantInseretions):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

dom/ProcessingInstruction.h:

(ProcessingInstruction):

dom/ScriptElement.cpp:

(WebCore::ScriptElement::insertedInto):

dom/ScriptElement.h:

(WebCore):
(ScriptElement):

dom/ShadowTree.cpp:

(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):

dom/ShadowTree.h:

(ShadowTree):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):

html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):

html/FormAssociatedElement.h:

(FormAssociatedElement):

html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):

html/HTMLBaseElement.h:

(HTMLBaseElement):

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):

html/HTMLBodyElement.h:

(HTMLBodyElement):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):

html/HTMLFormControlElement.h:

(HTMLFormControlElement):

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInseretions):
(WebCore::HTMLFormElement::removedFrom):

html/HTMLFormElement.h:

(HTMLFormElement):

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):

html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):

html/HTMLFrameSetElement.h:

(HTMLFrameSetElement):

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):

html/HTMLIFrameElement.h:

(HTMLIFrameElement):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

html/HTMLImageElement.h:

(HTMLImageElement):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):

html/HTMLInputElement.h:
html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):

html/HTMLLinkElement.h:

(HTMLLinkElement):

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):

html/HTMLMapElement.h:

(HTMLMapElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):

html/HTMLMediaElement.h:

(HTMLMediaElement):

html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::insertedInto):

html/HTMLMetaElement.h:

(HTMLMetaElement):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):

html/HTMLObjectElement.h:

(HTMLObjectElement):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::insertedInto):

html/HTMLOptionElement.h:

(HTMLOptionElement):

html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

html/HTMLQuoteElement.h:

(HTMLQuoteElement):

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::insertedInto):

html/HTMLScriptElement.h:

(HTMLScriptElement):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::insertedInto):

html/HTMLSelectElement.h:
html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):

html/HTMLSourceElement.h:

(HTMLSourceElement):

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):

html/HTMLStyleElement.h:

(HTMLStyleElement):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::insertedInto):

html/HTMLTextFormControlElement.h:
html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):

html/HTMLTitleElement.h:

(HTMLTitleElement):

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto):

html/HTMLTrackElement.h:

(HTMLTrackElement):

mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

mathml/MathMLMathElement.h:

(MathMLMathElement):

svg/SVGElement.cpp:

(WebCore::SVGElement::removedFrom):

svg/SVGElement.h:

(SVGElement):

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):

svg/SVGFEImageElement.h:

(SVGFEImageElement):

svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):

svg/SVGFontFaceElement.h:

(SVGFontFaceElement):

svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::insertedInto):

svg/SVGFontFaceUriElement.h:

(SVGFontFaceUriElement):

svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):

svg/SVGGlyphElement.h:

(SVGGlyphElement):

svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

svg/SVGHKernElement.h:

(SVGHKernElement):

svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::insertedInto):

svg/SVGImageElement.h:

(SVGImageElement):

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

svg/SVGSVGElement.h:

(SVGSVGElement):

svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::insertedInto):

svg/SVGScriptElement.h:

(SVGScriptElement):

svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):

svg/SVGStyleElement.h:

(SVGStyleElement):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):

svg/SVGStyledElement.h:

(SVGStyledElement):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):

svg/SVGTRefElement.h:

(SVGTRefElement):

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedInto):

svg/SVGTextPathElement.h:
svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):

svg/SVGTitleElement.h:

(SVGTitleElement):

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):

svg/SVGUseElement.h:

(SVGUseElement):

svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

svg/SVGVKernElement.h:

(SVGVKernElement):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):

svg/animation/SVGSMILElement.h:

(SVGSMILElement):

11:26 PM Changeset in webkit [114350] by commit-queue@webkit.org

3 edits
3 adds in trunk

Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/css/css-imports-redirect-cycle.html

css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

LayoutTests:

http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
http/tests/css/css-imports-redirect-cycle.css: Added.
http/tests/css/css-imports-redirect-cycle.html: Added.

11:22 PM Changeset in webkit [114349] by Lucas Forschler

5 edits in branches/safari-534.57-branch/Source

Versioning.

11:11 PM Changeset in webkit [114348] by tkent@chromium.org

2 edits in trunk/Source/Platform

[Chromium] Fix Chromium-Mac build
https://bugs.webkit.org/show_bug.cgi?id=80054

chromium/public/WebFilterOperations.h:

(WebKit): WebFilterOperation is a struct, not a class.

10:57 PM Changeset in webkit [114347] by tkent@chromium.org

5 edits
1 move in trunk/Source

Rename LocalizedNumberICU.h to ICULocale.h
https://bugs.webkit.org/show_bug.cgi?id=84119

Reviewed by Kentaro Hara.

Source/WebCore:

LocalizedNumberICU.h contains only ICULocale class. It should be
named as ICULocale.h. We're going to move some functions in
LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale,
and add unit tests for them.

WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h
platform/text/ICULocale.h:

Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h.

platform/text/LocalizedNumberICU.cpp:

Rename LocalizedNumberICU.h to ICULocale.h

Source/WebKit/chromium:

tests/LocalizedNumberICUTest.cpp: Rename LocalizedNumberICU.h to ICULocale.h

10:49 PM Changeset in webkit [114346] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, skip one more worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125

platform/chromium/test_expectations.txt:

10:46 PM Changeset in webkit [114345] by ryuan.choi@samsung.com

1 edit
2 adds in trunk/Source/WebKit2

[EFL][WK2] Add missing files to build webkit2/Efl.
https://bugs.webkit.org/show_bug.cgi?id=76139

Reviewed by Ryosuke Niwa.

Add missing files needed to build webkit2/Efl.

Shared/efl/PlatformCertificateInfo.h: Added.

(WebKit):
(PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):

UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Added.

(WebKit):
(WebKit::ThreadLauncher::createWebThread):

10:36 PM Changeset in webkit [114344] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=84066

Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.

WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
printing, etc), but this path no longer has any compositor interaction. This moves the code into
DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.

platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

platform/graphics/chromium/WebGLLayerChromium.cpp:
platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

10:28 PM Changeset in webkit [114343] by danakj@chromium.org

8 edits
4 adds in trunk/Source

[chromium] Expose compositor filters to Aura through WebLayer
https://bugs.webkit.org/show_bug.cgi?id=80054

Reviewed by James Robinson.

Source/Platform:

chromium/public/WebFilterOperation.h: Added.

(WebKit):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBlurFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebDropShadowFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):

chromium/public/WebFilterOperations.h: Added.

(WebKit):
(WebFilterOperations):

chromium/public/WebLayer.h:

(WebKit):
(WebLayer):

Source/WebCore:

Adds WebFilterOperation that wraps WebCore::FilterOperation and
WebFilterOperations that wraps WebCore::FilterOperations.

We add support for most of the FilterOperation subclasses, and
allow the user to set the WebFilterOperations for both layer
content filters and background filters.

WebCore.gypi:
platform/chromium/support/WebFilterOperation.cpp: Added.

(WebKit):
(WebKit::WebBasicColorMatrixFilterOperation::toFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::toFilterOperation):
(WebKit::WebBlurFilterOperation::toFilterOperation):
(WebKit::WebDropShadowFilterOperation::toFilterOperation):

platform/chromium/support/WebFilterOperations.cpp: Added.

(WebKit):
(WebKit::WebFilterOperations::WebFilterOperations):
(WebKit::WebFilterOperations::append):
(WebKit::WebFilterOperations::clear):
(WebKit::WebFilterOperations::toFilterOperations):

Source/WebKit/chromium:

WebKit.gyp:
src/WebLayer.cpp:

(WebKit::WebLayer::setFilters):
(WebKit):
(WebKit::WebLayer::setBackgroundFilters):

10:08 PM Changeset in webkit [114342] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.

No new tests. The repro steps require using Chrome notifications on Win.

page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

10:08 PM Changeset in webkit [114341] by toyoshim@chromium.org

1 edit
1 delete in trunk/LayoutTests

Unreviewed, remove invalid text expectation for Snow Leopard.

platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.

10:07 PM Changeset in webkit [114340] by Lucas Forschler

1 copy in tags/Safari-534.57.1

New tag.

9:32 PM Changeset in webkit [114339] by toyoshim@chromium.org

1 edit
1 delete in trunk/LayoutTests

Unreviewed, remove useless text expectation for WinXP

platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.

9:09 PM Changeset in webkit [114338] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, skip a worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125

platform/chromium/test_expectations.txt:

8:58 PM Changeset in webkit [114337] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

DEPS:

8:42 PM Changeset in webkit [114336] by tkent@chromium.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
https://bugs.webkit.org/show_bug.cgi?id=84116

Reviewed by Kentaro Hara.

This makes no behavior change. Just move some code.
To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
above the target element or below the target element.

src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().

src/WebPagePopupImpl.h:

(WebPagePopupImpl): Rename an argument name.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().

8:38 PM April 2012 Meeting edited by rniwa@webkit.org

(diff)

8:04 PM Changeset in webkit [114335] by jamesr@google.com

16 edits
2 copies
1 move in trunk/Source

[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
https://bugs.webkit.org/show_bug.cgi?id=83963

Reviewed by Adrienne Walker.

Source/Platform:

Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface.

Platform.gypi:
chromium/public/WebContentLayer.h:

(WebContentLayer):

chromium/public/WebLayer.h:

(WebLayer):
(WebKit::WebLayer::unwrap):

chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h.

(WebKit):
(WebVideoFrameProvider):
(WebKit::WebVideoFrameProvider::~WebVideoFrameProvider):
(Client):

chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.

(WebCore):
(WebKit):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::~WebVideoLayer):

Source/WebCore:

Converts VideoLayerChromium / CCVideoLayerImpl to use a Platform WebVideoFrameProvider interface instead of a
WebCore VideoFrameProvider.

WebCore.gypi:
platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):

platform/graphics/chromium/VideoLayerChromium.h:

(WebKit):
(WebCore):
(VideoLayerChromium):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):

platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore::CCVideoLayerImpl::create):
(CCVideoLayerImpl):

Source/WebKit/chromium:

Adds implementation of WebVideoLayer and ports WebMediaPlayerClientImpl over to using it.
WebMediaPlayerClientImpl still exposes a WebCore::VideoLayerChromium* to the compositor via the platformLayer()
interface, but this is temporary until we can change the PlatformLayer typedef over to WebLayer.

WebKit.gyp:
src/WebContentLayer.cpp:
src/WebLayer.cpp:

(WebKit::WebLayer::invalidate):
(WebKit):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

src/WebVideoLayer.cpp: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.

(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):

7:55 PM Changeset in webkit [114334] by commit-queue@webkit.org

6 edits in trunk

[Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010

Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-16
Reviewed by Hajime Morita.

This patch adds isActive public member function to InsertionPoint and
makes InsertionPoint elements consider whether active or not.
If an InsertionPoint is inactive, the element is not shadow boundary
and is needed to be rendered.
c.f. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point

Test: update existing tests, i.e.
LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html and
LayoutTests/fast/dom/shadow/shadow-contents-fallback.html

html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::isActive):
A new public method for checking whether an insertion point is active or inactive.
If active, returns true. Otherwise, false.
(WebCore::InsertionPoint::isShadowBoundary):
Make the method consider whether an insertin point is active or inactive.
(WebCore::InsertionPoint::rendererIsNeeded):
Changed to return true If an insertion point is inactive.
(WebCore::InsertionPoint::attach):
Changed to call only HTMLElement::attach If an insertion point is inactive.
(WebCore::InsertionPoint::detach):
Changed to call only HTMLElement::detach If an insertion point is inactive.

html/shadow/InsertionPoint.h:

(InsertionPoint):
Added isActive public method.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
Changed to take into account an insertion point's activeness when parent is an insertion point.
(WebCore::NodeRenderingContext::firstRendererOf):
(WebCore::NodeRenderingContext::lastRendererOf):
Changed to take into account an insertion point's activeness.

7:33 PM April 2012 Meeting edited by rniwa@webkit.org

(diff)

7:15 PM Changeset in webkit [114333] by morrita@google.com

3 edits in trunk/Source/WebCore

Type tags in NodeFlags could be compressed
https://bugs.webkit.org/show_bug.cgi?id=79299

Because existing node flags which indicate the class of each node
are mutually exclusive, these flags can be represented as a enum.
This patch introduces Node::NodeTypeTag to turn these flags into a
enum, and embeds it into Node::m_nodeFlags.

Reviewed by Antti Koivisto.

No new tests. No bahavior change.

dom/Node.cpp:

(WebCore):

dom/Node.h:

(WebCore):
(Node):
(WebCore::Node::typeTag):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
(WebCore::Node::isContainerNode):
(WebCore::Node::isElementNode):
(WebCore::Node::isStyledElement):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isShadowRoot):

7:02 PM Changeset in webkit [114332] by kov@webkit.org

2 edits in trunk/Tools

[GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112

Rubber-stamped by Martin Robinson.

gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;

we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball

6:06 PM Changeset in webkit [114331] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r110150

5:55 PM Changeset in webkit [114330] by commit-queue@webkit.org

6 edits
2 deletes in trunk

Unreviewed, rolling out r114285.
http://trac.webkit.org/changeset/114285
https://bugs.webkit.org/show_bug.cgi?id=84107

broke fast/media/media-query-list-08.html in Mac (Requested by
andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::styleSelectorChanged):

dom/Document.h:

(Document):

page/FrameView.cpp:

(WebCore::FrameView::layout):

LayoutTests:

fast/media/media-query-list-08-expected.txt: Removed.
fast/media/media-query-list-08.html: Removed.
platform/qt/Skipped:

5:48 PM Changeset in webkit [114329] by commit-queue@webkit.org

5 edits
1 add in trunk/Source/WebKit/chromium

Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=84046

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

WebKit.gyp:
public/WebMediaPlayer.h:

(WebKit):

public/WebMediaPlayerClient.h:
public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.

(WebKit):
(WebKit::WebTimeRange::WebTimeRange):
(WebTimeRange):

src/AssertMatchingEnums.cpp:

5:47 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

5:47 PM Changeset in webkit [114328] by Nate Chapin

3 edits in trunk/Source/WebCore

Remove unused variable CachedResourceLoader::m_loadFinishing
https://bugs.webkit.org/show_bug.cgi?id=84100

Reviewed by Alexey Proskuryakov.

No new tests, removing dead code.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::decrementRequestCount):

loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):
(WebCore::CachedResourceLoader::requestCount):

5:35 PM Changeset in webkit [114327] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Followup to http://trac.webkit.org/changeset/114323

For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.

Reviewed by Mark Rowe.

PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

5:35 PM Changeset in webkit [114326] by kov@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r114322.
http://trac.webkit.org/changeset/114322
https://bugs.webkit.org/show_bug.cgi?id=84096

Didn't make the debug bot happy, so back out

gtk/jhbuild.modules:

5:28 PM Changeset in webkit [114325] by kling@webkit.org

6 edits in trunk/Source/WebCore

Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
<http://webkit.org/b/83988>

Reviewed by Antti Koivisto.

Remove the 'context style sheet' argument to <font face> value parsing.
It was only ever used to grab at the CSSValuePool back when they were per-Document.

css/CSSParser.h:
css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

css/CSSValuePool.h:
css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

5:21 PM Changeset in webkit [114324] by danakj@chromium.org

1 edit in trunk/Source/WebCore/ChangeLog

[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

5:21 PM Changeset in webkit [114323] by beidson@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/11238965> Leak in Plugin Process when launched 32-bit

Reviewed by Jessie Berlin.

PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one.

5:18 PM Changeset in webkit [114322] by kov@webkit.org

2 edits in trunk/Tools

[GTK] Try to fix debug bot by adding gobject-introspection to the build
https://bugs.webkit.org/show_bug.cgi?id=84096

Unreviewed speculative build fix.

gtk/jhbuild.modules: Added gobject-introspection, since modules need

an up-to-date introspection m4 for running autogen.

5:17 PM Changeset in webkit [114321] by andersca@apple.com

2 edits in trunk/LayoutTests

Add two flaky tests in fast/profiler.

platform/mac/Skipped:

4:53 PM Changeset in webkit [114320] by arv@chromium.org

3 edits
2 adds in trunk

[V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/security/isolatedWorld/context-destroy.html

bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::destroy):

LayoutTests:

http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
http/tests/security/isolatedWorld/context-destroy.html: Added.

4:50 PM Changeset in webkit [114319] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Add V8 code generation support for MessagePortArray attributes.
https://bugs.webkit.org/show_bug.cgi?id=83943

Patch by Greg Billock <gbillock@google.com> on 2012-04-16
Reviewed by Kentaro Hara.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::ports):

bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_get_ports):

bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::jsTestSerializedScriptValueInterfacePorts):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore):

bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface ports]):

bindings/scripts/test/TestSerializedScriptValueInterface.idl:
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):

4:45 PM Changeset in webkit [114318] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html.

Unreviewed.

platform/chromium/test_expectations.txt:

4:37 PM Changeset in webkit [114317] by commit-queue@webkit.org

17 edits in trunk

Unreviewed, rolling out r114309.
http://trac.webkit.org/changeset/114309
https://bugs.webkit.org/show_bug.cgi?id=84097

it broke everything (Requested by olliej on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
bytecode/CodeBlock.h:
dfg/DFGOperations.cpp:
interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):

interpreter/Interpreter.h:

(Interpreter):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jsc.cpp:

(functionJSCStack):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

parser/Parser.h:

(JSC::::parse):

runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwError):

runtime/Error.h:

(JSC):

LayoutTests:

fast/js/exception-properties-expected.txt:
fast/js/script-tests/exception-properties.js:
fast/js/script-tests/stack-trace.js:

(selfRecursive1):

fast/js/stack-trace-expected.txt:

4:32 PM Changeset in webkit [114316] by xji@chromium.org

2 edits in trunk/Source/WebCore

platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521

Reviewed by David Levin.

No functionality change, so no new tests.

platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:

(WebCore::GlyphPage::fill):

4:24 PM Changeset in webkit [114315] by leviw@chromium.org

9 edits in trunk/Source/WebCore

Make borderBoxRect sub-pixel precise and add a pixel snapped version
https://bugs.webkit.org/show_bug.cgi?id=84063

Reviewed by Eric Seidel.

In an effort to prevent misuse, we previously decided to have borderBoxRect return a
pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned
at (0,0), and therefore won't snap to the same size as the element it's covering.

There are a couple uses of borderBoxRect that don't pixel snap the values and require
sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping
explicit, and moves uses that would otherwise pixel snap the rect to this version to
avoid producing a rect of the incorrect size. For details about pixel snapping with
LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addVisualOverflowFromTheme):

rendering/RenderBox.h:

(WebCore::RenderBox::borderBoxRect):
(WebCore::RenderBox::pixelSnappedBorderBoxRect):
(WebCore::RenderBox::borderBoundingBox):
(WebCore::RenderBox::hasVisualOverflow):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addOverflowFromChildren):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):

4:19 PM Changeset in webkit [114314] by scheib@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Rebaseline continued from xji's rebase after r114267.

Unreviewed.

platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added.

4:10 PM Changeset in webkit [114313] by tomz@codeaurora.org

6 edits
11 adds
11 deletes in trunk/LayoutTests

Unreviewed gardening for ietestcenter/grid. Adding reference tests
and removing gtk expected.txt

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-16

ietestcenter/css3/grid/display-grid-001-expected.htm: Added.
ietestcenter/css3/grid/display-grid-002-expected.htm: Added.
ietestcenter/css3/grid/grid-column-001-expected.htm: Added.
ietestcenter/css3/grid/grid-column-002-expected.htm: Added.
ietestcenter/css3/grid/grid-column-003-expected.htm: Added.
ietestcenter/css3/grid/grid-columns-001-expected.htm: Added.
ietestcenter/css3/grid/grid-items-001-expected.htm: Added.
ietestcenter/css3/grid/grid-items-002-expected.htm: Added.
ietestcenter/css3/grid/grid-items-003-expected.htm: Added.
ietestcenter/css3/grid/grid-items-004-expected.htm: Added.
ietestcenter/css3/grid/grid-items-005-expected.htm: Added.
platform/chromium/test_expectations.txt:
platform/efl/test_expectations.txt:
platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Removed.
platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Removed.
platform/gtk/test_expectations.txt:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:

3:54 PM Changeset in webkit [114312] by kov@webkit.org

2 edits in trunk/Tools

[GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086

Unreviewed build fix.

gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our

jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.

3:50 PM Changeset in webkit [114311] by andersca@apple.com

2 edits in trunk/Source/WebCore

Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091

Reviewed by Andreas Kling.

Null check triggeringEvent.

editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):

3:27 PM Changeset in webkit [114310] by leviw@chromium.org

15 edits in branches/subpixellayout

Reverting unnecessary changes to RenderRubyRun, and applying the patch from webkit.org/b/84063.

3:26 PM Changeset in webkit [114309] by oliver@apple.com

17 edits in trunk

Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.

bytecode/CodeBlock.h:

(JSC::CodeBlock::codeOriginIndexForReturn):
(CodeBlock):

dfg/DFGOperations.cpp:
interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):

interpreter/Interpreter.h:

(Interpreter):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jsc.cpp:

(functionJSCStack):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

parser/Parser.h:

(JSC::::parse):

runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwError):

runtime/Error.h:

(JSC):

LayoutTests:

Update tests to include new exception property ordering, and new functions

fast/js/exception-properties-expected.txt:
fast/js/script-tests/exception-properties.js:
fast/js/script-tests/stack-trace.js:

(selfRecursive1): Modified slightly so that we produce consistent traces

fast/js/stack-trace-expected.txt:

3:25 PM Changeset in webkit [114308] by kov@webkit.org

2 edits in trunk/Tools

[GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085

Rubber-stamped by Martin Robinson.

gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which

includes a phony clean target that should make warnings and errors go
away.

3:19 PM Changeset in webkit [114307] by andersca@apple.com

5 edits in trunk/Source/WebKit/mac

Use a MIG call when creating a plug-in property list file
https://bugs.webkit.org/show_bug.cgi?id=84084
<rdar://problem/11197341>

Reviewed by Sam Weinig.

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::createPropertyListFile):
Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.

Plugins/Hosted/WebKitPluginHost.defs:

Add PHCreatePluginMIMETypesPreferences.

Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage createPropertyListFile]):
NetscapePluginHostManager::createPropertyListFile is no longer a static member function.

3:14 PM Changeset in webkit [114306] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Update test_expectations for chromium
https://bugs.webkit.org/show_bug.cgi?id=83965

Patch by David Alcala <dalcala@adobe.com> on 2012-04-16
Reviewed by Dirk Schulze.

platform/chromium/test_expectations.txt:

3:09 PM Changeset in webkit [114305] by scheib@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Rebasing pixel tests for composited-document-element, tiny text difference.

Unreviewed.

platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:

3:05 PM Changeset in webkit [114304] by commit-queue@webkit.org

2 edits in trunk

Re-add GPU DEPS builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=84056

Patch by Dave Tu <dtu@chromium.org> on 2012-04-16
Reviewed by Ojan Vafai.

Tools/TestResultServer/static-dashboards/builders.js:

3:05 PM Changeset in webkit [114303] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Supressing test errors introduced by http://trac.webkit.org/changeset/114283.

Unreviewed.

platform/chromium/test_expectations.txt:

3:02 PM Changeset in webkit [114302] by Simon Fraser

3 edits in trunk/Source/WebCore

Rename to updateZOrderListsSlowCase to rebuildZOrderLists
https://bugs.webkit.org/show_bug.cgi?id=84071

Reviewed by Antti Koivisto.

Use a better name for updateZOrderListsSlowCase().

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::rebuildZOrderLists):

rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::updateZOrderLists):

2:50 PM Changeset in webkit [114301] by commit-queue@webkit.org

6 edits in trunk/Source

[chromium] Allow WebGestureEvent to store four floating point values
https://bugs.webkit.org/show_bug.cgi?id=84053

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

See bug description for an explanation of the changes made.

Source/WebCore:

platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
(WebCore::PlatformGestureEvent::gammaX):
(WebCore::PlatformGestureEvent::gammaY):

Source/WebKit/chromium:

public/WebInputEvent.h:

(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

2:44 PM Changeset in webkit [114300] by schenney@chromium.org

4 edits
1 add
1 delete in trunk/LayoutTests

[Chromium] Flaky layout test LayoutTests/svg/hixie/error/012.xml
https://bugs.webkit.org/show_bug.cgi?id=84082

Unreviewed Chromium test expectations update.

Results look right but the test maybe flaky.

platform/chromium-mac-leopard/svg/hixie/error/012-expected.png:
platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Removed.
platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png:
platform/chromium-mac/svg/hixie/error/012-expected.png: Added.
platform/chromium/test_expectations.txt:

2:33 PM Changeset in webkit [114299] by schenney@chromium.org

12 edits
3 deletes in trunk/LayoutTests

[Chromium] Rebaseline now that SK_IGNORE_HAIRLINE_CLIP_FIX is undefined
https://bugs.webkit.org/show_bug.cgi?id=84075

Unreviewed Chromium expectations update.

platform/chromium-linux-x86/svg/as-image: Removed.
platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
platform/chromium/test_expectations.txt:
svg/hixie/perf/001-expected.txt: Removed.
svg/hixie/perf/002-expected.txt: Removed.

2:19 PM Changeset in webkit [114298] by haraken@chromium.org

2 edits in trunk/Source/WebCore

[Refactoring][V8] Remove $indent from NativeToJSValue()
https://bugs.webkit.org/show_bug.cgi?id=84077

Reviewed by Nate Chapin.

$indent in NativeToJSValue() in CodeGeneratorV8.pm is not used.
This patch removes it.

No new tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

2:19 PM Changeset in webkit [114297] by kov@webkit.org

4 edits
1 delete in trunk

[GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060

Rubber-stamped by Martin Robinson.

configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we

already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.

Tools:

gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf

to their GNOME 3.4 versions.

gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch

is applied upstream.

2:02 PM Changeset in webkit [114296] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Marking failing test platform/chromium/compositing/filters/background-filter-blur-outsets.html.

Unreviewed.

platform/chromium/test_expectations.txt:

2:02 PM Changeset in webkit [114295] by andersca@apple.com

8 edits in trunk/Source/WebKit2

Nightly Back/Forward no longer calls plug-in's NPP_NewStream
https://bugs.webkit.org/show_bug.cgi?id=83805
<rdar://problem/11238748>

Reviewed by Simon Fraser.

When a page with a full-frame plug-in is restored from the page cache, it needs to re-fetch the plug-in stream.

Fix this by breaking the assumption that a plug-in will always get its data from WebCore if it's a full-frame plug-in;
instead it only get its data from WebCore if it's a full-frame plug-in that's not being restored from the page cache.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Rename m_loadManually to m_shouldUseManualLoader.

(WebKit::NetscapePlugin::initialize):
Get the mode from parameters.isFullFramePlugin instead.

(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
Rename m_loadManually to m_shouldUseManualLoader.

WebProcess/Plugins/Netscape/NetscapePlugin.h:

Rename m_loadManually to m_shouldUseManualLoader.

WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):

WebProcess/Plugins/Plugin.h:

(Parameters):
Add an extra isFullFramePlugin parameter, and rename loadManually to shouldUseManualLoader.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameCameFromPageCache.

(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Set m_frameCameFromPageCache to true.

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Set m_frameCameFromPageCache to false.

(WebKit::WebFrameLoaderClient::createPlugin):
Initialize isFullFramePlugin and shouldUseManualLoader.

1:57 PM Changeset in webkit [114294] by schenney@chromium.org

3 edits
2 adds in trunk/LayoutTests

[Chromium] Rebaseline svg/filters/sourceAlpha.svg on mac
https://bugs.webkit.org/show_bug.cgi?id=84069

Unreviewed Chromium test expectations update.

Finally closing out an expectations update from 2009.

platform/chromium-mac-leopard/svg/filters/sourceAlpha-expected.png: Added.
platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png:
platform/chromium-mac/svg/filters/sourceAlpha-expected.png: Added.
platform/chromium/test_expectations.txt:

1:32 PM Changeset in webkit [114293] by schenney@chromium.org

3 edits
10 adds
10 deletes in trunk/LayoutTests

[Chromium] Layout test svg/filters/shadow-on-rect-with-filter.svg fails
https://bugs.webkit.org/show_bug.cgi?id=84064

Unreviewed Chromium expectations update.

One of these results, for svg/filters/filter-source-position.svg, is
incorrect, but it should be updated regardless.

platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
platform/chromium-linux/svg/filters/filter-clip-expected.png: Added.
platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
platform/chromium-win/svg/filters/filter-clip-expected.png: Added.
platform/chromium-win/svg/filters/filter-source-position-expected.png: Added.
platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
platform/chromium/test_expectations.txt:
platform/efl/svg/filters/filter-source-position-expected.png: Removed.
platform/efl/svg/filters/filter-source-position-expected.txt: Removed.
platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
platform/gtk/svg/filters/filter-source-position-expected.png: Removed.
platform/gtk/svg/filters/filter-source-position-expected.txt: Removed.
platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
platform/mac/svg/filters/filter-source-position-expected.txt: Removed.
platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
platform/qt/svg/filters/filter-source-position-expected.txt: Removed.
platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
svg/filters/filter-source-position-expected.png: Added.
svg/filters/filter-source-position-expected.txt: Added.
svg/filters/shadow-on-rect-with-filter-expected.txt: Added.

1:26 PM Changeset in webkit [114292] by scheib@chromium.org

3 edits in trunk/LayoutTests

[Chromium] Rebaselining minor text difference in compositing/geometry/fixed-position-composited-page-scale-down.

Unreviewed.

platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:

1:14 PM Changeset in webkit [114291] by ap@apple.com

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove BlobRegistryProxy::createResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=84047

Reviewed by Nate Chapin.

src/BlobRegistryProxy.h: (BlobRegistryProxy::createResourceHandle): This function

is no longer used.

1:08 PM Changeset in webkit [114290] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

RenderImage ignores its percent width/height when setContainerSizeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=80431

Add a test case for Bug 80431. It renders a 1x1 svg as an image with percent
width/height specified.

Patch by Yong Li <yoli@rim.com> on 2012-04-16
Reviewed by Nikolas Zimmermann.

svg/as-image/resources/rect-1x1.svg: Added.
svg/as-image/svg-as-image-with-relative-size-expected.html: Added.
svg/as-image/svg-as-image-with-relative-size.html: Added.

1:05 PM Changeset in webkit [114289] by scheib@chromium.org

3 edits in trunk/LayoutTests

Reverting shader-precision-format.html reftest fix - it only fixed some DBG builders. Marking test failing for those.

Unreviewed.

fast/canvas/webgl/shader-precision-format-expected.txt:
platform/chromium/test_expectations.txt:

1:00 PM Changeset in webkit [114288] by tonikitoo@webkit.org

2 edits in trunk/Source/WebKit/blackberry

2012-04-16 Antonio Gomes <agomes@rim.com>

Screen shift down when VKB shows by clicking in a input box MKS_3601371
PR #149846

Reviewed by Rob Buis.

After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
we had a less restricted code path allowing/disallowing overscrolling. That caused
some webpages like google.com to get on overscroll when adjusting the scroll
position to ensure the focused input field is visible.

Patch restricts the way we allow overscrolling to the bottom, where the virtual
keyboard pops up from, clamping it to 0, 0 if it tries to
overscroll upwards, and to maximum scroll position if it overscrolls
downwards.

Internally reviewed by Mike Fenton.
PR #149846

WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

12:34 PM Changeset in webkit [114287] by xji@chromium.org

3 edits
7 adds in trunk/LayoutTests

Rebaseline after r114267.

platform/chromium-linux/fast/text/international/arabic-justify-expected.png: Added.
platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.png: Added.
platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
platform/chromium-mac/fast/text/international/arabic-justify-expected.png: Added.
platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Added.
platform/chromium-win/fast/text/international/arabic-justify-expected.png:
platform/chromium/test_expectations.txt:

11:52 AM Changeset in webkit [114286] by ap@apple.com

2 edits in trunk/Source/WebKit2

EndPrinting message should be sent synchronously when printing was initiated from DOM.
https://bugs.webkit.org/show_bug.cgi?id=84049
<rdar://problem/11096575>

Reviewed by Oliver Hunt.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame): When printing is initiated by WebProcess, all messages from UI process are sent synchronously to avoid being queued, and so should EndPrinting.

11:45 AM Changeset in webkit [114285] by Antti Koivisto

6 edits
2 adds in trunk

matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-16
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/media-query-list-08.html

Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.

The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.

dom/Document.cpp:

(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):

dom/Document.h:

(Document):

page/FrameView.cpp:

(WebCore::FrameView::layout):

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

fast/media/media-query-list-08-expected.txt: Added.
fast/media/media-query-list-08.html: Added.

Skipping the new test in Qt due to an issue in its DumpRenderTree.

platform/qt/Skipped:

11:41 AM Changeset in webkit [114284] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[chromium] Delete uncalled unreserveContentsTextures function
https://bugs.webkit.org/show_bug.cgi?id=84005

Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.

This is vestigal dead code.

platform/graphics/chromium/Canvas2DLayerChromium.cpp:
platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

11:32 AM Changeset in webkit [114283] by Simon Fraser

14 edits
7 adds in trunk

Avoid using backing store for compositing layers that just need to clip
https://bugs.webkit.org/show_bug.cgi?id=40547

Source/WebCore:

Reviewed by Dean Jackson.

If a layer becomes composited because it needs to clip composited
descendants, or if it has perspective, then it doesn't actually
needs its own backing store; its contents can be painted by an
ancestor, and we can just have an empty layer that does the clipping
or applies the perspective transform.

This saves backing store memory on some pages.

Tests: compositing/backing/no-backing-for-clip-overlap.html

compositing/backing/no-backing-for-clip.html
compositing/backing/no-backing-for-perspective.html

rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::paintLayer):

rendering/RenderLayer.h:

(RenderLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):
(WebCore::RenderLayerBacking::paintsIntoCompositedAncestor):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore):

rendering/RenderLayerCompositor.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

rendering/RenderTreeAsText.cpp:

(WebCore::write):

rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

Reviewed by Dean Jackson.

New tests for backing store elimination with clip or perspective.

New results for some tests that no longer have backing store on some
layers.

compositing/backing/no-backing-for-clip-expected.txt: Added.
compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
compositing/backing/no-backing-for-clip-overlap.html: Added.
compositing/backing/no-backing-for-clip.html: Added.
compositing/backing/no-backing-for-perspective-expected.txt: Added.
compositing/backing/no-backing-for-perspective.html: Added.
compositing/geometry/preserve-3d-switching-expected.txt:
compositing/visibility/layer-visible-content-expected.png:
compositing/visibility/layer-visible-content-expected.txt:

11:28 AM April 2012 Meeting edited by eae@chromium.org

(diff)

11:27 AM Changeset in webkit [114282] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Increase padding for text element
https://bugs.webkit.org/show_bug.cgi?id=83903

Patch by Yongxin Dai <yodai@rim.com> on 2012-04-16
Reviewed by Antonio Gomes.

PR 125888

Increase the padding value for focused text element to make selection handle
at least partially visible when the user is dragging at edge of viewport
in in-region scoll mode.

Reviewed internally by Mike Fenton.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

11:27 AM Changeset in webkit [114281] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Marking css3/filters/huge-region.html and composited version MISSING, CRASH.

Unreviewed.

platform/chromium/test_expectations.txt:

11:12 AM Changeset in webkit [114280] by scheib@chromium.org

2 edits in trunk/Tools

Adding Contributors Brian Salomon and Tom Hudson to committers.py.

Unreviewed.

Scripts/webkitpy/common/config/committers.py:

11:06 AM Changeset in webkit [114279] by andersca@apple.com

3 edits in trunk/LayoutTests

Try to fix a flaky JS test.

Use a URL that's allowed to load so the resource load delegate won't randomly complain about it depending on
if the load starts before the Audio object is garbage collected (that's my guess anyway).

fast/js/custom-constructors-expected.txt:
fast/js/script-tests/custom-constructors.js:

11:01 AM Changeset in webkit [114278] by beidson@apple.com

5 edits in trunk/Source

<rdar://problem/11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2 back/forward items in the page cache are never removed when the page is closed

Reviewed by Jessie Berlin and unofficially reviewed by Jon Lee.

Source/WebCore:

WebCore.exp.in: Export PageCache::remove()

Source/WebKit2:

Individual WebBackForwardListProxy's had no idea which items are associated with them.
This adds that association and makes sure the proxy removes all associated items from the PageCache when it closes.

WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem): Remove the item from the PageCache in case it was in it.
(WebKit::WebBackForwardListProxy::addItem): Add the item ID to this back/forward list's set of associated IDs.
(WebKit::WebBackForwardListProxy::close): Remove each associated item from the PageCache.

WebProcess/WebPage/WebBackForwardListProxy.h:

10:55 AM Changeset in webkit [114277] by eae@chromium.org

925 edits
198 copies
37 deletes in branches/subpixellayout

Merge trunk changes up until 114126 into subpixel branch.

10:55 AM April 2012 Meeting edited by jsbell@chromium.org

Added proposed IDB discussion (diff)

10:51 AM Changeset in webkit [114276] by Philippe Normand

2 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r114269.

GNUmakefile.list.am:

10:43 AM Changeset in webkit [114275] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606

Patch by Raymes Khoury <raymes@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

10:41 AM Changeset in webkit [114274] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix COMMANDLINE_TYPEDARRAYS build
https://bugs.webkit.org/show_bug.cgi?id=84051

Reviewed by Gavin Barraclough.

Update for new putByIndex API and wtf changes.

JSCTypedArrayStubs.h:

(JSC):

10:30 AM Changeset in webkit [114273] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Turns out those frame

flattening tests are still flaky.

10:25 AM Changeset in webkit [114272] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: timeline. Range selection works incorrect with right click
https://bugs.webkit.org/show_bug.cgi?id=83870

Reviewed by Pavel Feldman.

only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._dragWindow):

10:23 AM Changeset in webkit [114271] by yurys@chromium.org

13 edits
63 moves
1 delete in trunk

Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot*
https://bugs.webkit.org/show_bug.cgi?id=84038

A bunch of renames "detailed heapshot" -> "heap snapshot".

Reviewed by Pavel Feldman.

PerformanceTests:

inspector/detailed-heapshots-smoke-test.html:

Source/WebCore:

Tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html

inspector/profiler/heap-snapshot-comparison-show-all.html
inspector/profiler/heap-snapshot-comparison-show-next.html
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-sorting.html
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-show-all.html
inspector/profiler/heap-snapshot-containment-show-next.html
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-sorting.html
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-show-all.html
inspector/profiler/heap-snapshot-dominators-show-next.html
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-sorting.html
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-show-all.html
inspector/profiler/heap-snapshot-summary-show-next.html
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-sorting.html

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/HeapSnapshotGridNodes.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js.

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotGridNode.prototype.createCell):
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._emptyData):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffNode.prototype._signForDelta):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
(MixInSnapshotNodeFunctions):

inspector/front-end/HeapSnapshotView.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotView.js.

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get statusBarItems):
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback2):
(WebInspector.HeapSnapshotView.prototype.wasShown):
(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype.onResize):
(WebInspector.HeapSnapshotView.prototype.searchCanceled):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesById):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesQuery):
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToLastSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToNextSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToPreviousSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingLastSearchResult):
(WebInspector.HeapSnapshotView.prototype._jumpToSearchResult):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapSnapshotView.prototype._changeFilter):
(WebInspector.HeapSnapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.HeapSnapshotView.prototype._changeNameFilter):
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype._loadProfile):
(WebInspector.HeapSnapshotView.prototype._loadProfileByIndex):
(WebInspector.HeapSnapshotView.prototype.isDetailedSnapshot):
(WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
(WebInspector.HeapSnapshotView.prototype._selectionChanged):
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.HeapSnapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.HeapSnapshotView.prototype.changeView.sortingComplete):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
(WebInspector.HeapSnapshotView.prototype._resolveObjectForPopover):
(WebInspector.HeapSnapshotView.prototype._helpClicked.appendHelp):
(WebInspector.HeapSnapshotView.prototype._helpClicked):
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._retainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
(WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.get treeItemTitle):
(WebInspector.HeapSnapshotProfileType.prototype.get description):
(WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createView):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

inspector/front-end/WebKit.qrc:
inspector/front-end/heapProfiler.css:

(.heap-snapshot-view):
(.heap-snapshot-view.visible):
(.heap-snapshot-view .view):
(.heap-snapshot-view .view.visible):
(.heap-snapshot-view .data-grid tr:empty):
(.heap-snapshot-view .data-grid):
(.heap-snapshot-view .data-grid td.count-column):
(.heap-snapshot-view .data-grid td.addedCount-column):
(.heap-snapshot-view .data-grid td.removedCount-column):
(.heap-snapshot-view .data-grid td.countDelta-column):
(.heap-snapshot-view .data-grid td.addedSize-column):
(.heap-snapshot-view .data-grid td.removedSize-column):
(.heap-snapshot-view .data-grid td.sizeDelta-column):
(.heap-snapshot-view .data-grid td.shallowSize-column):
(.heap-snapshot-view .data-grid td.retainedSize-column):
(.heap-snapshot-view .data-grid td.distanceToWindow-column):
(.heap-snapshot-view .data-grid span.percent-column):
(.heap-snapshot-view .console-formatted-object, .console-formatted-node):
(.heap-snapshot-view .console-formatted-string):
(.heap-snapshot-view .console-formatted-id):
(.heap-snapshot-view .data-grid tr.selected *):
(.heap-snapshot-view .data-grid:focus tr.selected *):
(.heap-snapshot-view .delimiter):
(.heap-snapshot-view .views-container):
(.heap-snapshot-view .views-container .view):
(.heap-snapshot-view .retaining-paths-view):
(.heap-snapshot-view .class-view-grid):
(.heap-snapshot-view .class-view-toolbar):
(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):
(.heap-snapshot-view .retainers-view-header .title > span):
(.heap-snapshot-view tr:not(.selected) td.object-column span.highlight):
(.heap-snapshot-view td.object-column span.grayed):
(.heap-snapshot-help-status-bar-item .glyph):
(table.heap-snapshot-help):

inspector/front-end/inspector.html:

LayoutTests:

inspector/profiler/detailed-heapshots-test.js: Removed.
inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
inspector/profiler/heap-snapshot-comparison-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all.html.
inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
inspector/profiler/heap-snapshot-comparison-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next.html.
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
inspector/profiler/heap-snapshot-comparison-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting.html.
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
inspector/profiler/heap-snapshot-containment-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all.html.
inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
inspector/profiler/heap-snapshot-containment-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next.html.
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
inspector/profiler/heap-snapshot-containment-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting.html.
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
inspector/profiler/heap-snapshot-dominators-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all.html.
inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt.
inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
inspector/profiler/heap-snapshot-dominators-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next.html.
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
inspector/profiler/heap-snapshot-dominators-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting.html.
inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
inspector/profiler/heap-snapshot-summary-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all.html.
inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
inspector/profiler/heap-snapshot-summary-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next.html.
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html.
inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
inspector/profiler/heap-snapshot-summary-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting.html.
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
(initialize_HeapSnapshotTest.InspectorTest.completeProfilerTest):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite.runner):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):

platform/chromium/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
platform/chromium/inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.

10:18 AM Changeset in webkit [114270] by caseq@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling
https://bugs.webkit.org/show_bug.cgi?id=83946

Reviewed by Pavel Feldman.

Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables
support for moving overview window with horizontal swype over lower timeline pane, thus removing
an irritating situation when we try to both change overview window and scroll lower timeline pane
upon a single touchpad gesture. Those willing to move timeline window now would need to position
mouse over overview.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

10:14 AM Changeset in webkit [114269] by Philippe Normand

10 edits
2 adds in trunk/Source/WebCore

[GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=78095

Reviewed by Martin Robinson.

Moved the GStreamer initialization logic to a new
GStreamerUtilities module, used by the MediaPlayer and the
AudioContext. I also removed the static variables as
gst_init_check already handles cases where it's called multiple
times.

GNUmakefile.list.am:
Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::constructCommon):

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF):
(WTF::GstElementFactory):

platform/graphics/gstreamer/GRefPtrGStreamer.h:

(WTF):

platform/graphics/gstreamer/GStreamerUtilities.cpp: Added.

(WebCore):
(WebCore::initializeGStreamer):

platform/graphics/gstreamer/GStreamerUtilities.h: Added.

(WebCore):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::doGstInit):

10:06 AM Changeset in webkit [114268] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
https://bugs.webkit.org/show_bug.cgi?id=83982

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-04-16
Reviewed by Martin Robinson.

GL_BGRA is not defined in GLESv2, so it causes build-break at readRenderingResults.
To resolve this, a helper function readPixelsAndConvertToBGRAIfNecessary is added
in GC3DOpenGL.cpp & GC3DOpenGLES.cpp and it's used in GC3DOpenGLCommon.cpp.
And some other issues to build with GLES are gone with this patch.

No new tests, since no new feature.

platform/graphics/GraphicsContext3D.h:
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::readRenderingResults):

platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):

10:03 AM Changeset in webkit [114267] by xji@chromium.org

4 edits
8 adds in trunk

[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227

Reviewed by Kent Tamura.

Source/WebCore:

Disable kashida justification if using Skia to draw.

Test: fast/text/international/arabic-justify.html

platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

fast/text/international/arabic-justify.html: Added.
platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
platform/qt/fast/text/international/arabic-justify-expected.txt: Added.

9:59 AM Changeset in webkit [114266] by jpu@apple.com

4 edits in trunk/Source/WebCore

Build fix.

Change set 114220 broke OS X internal build. Change set 114231 attempted to fix it, but isn't entirely

correct. This patch amends change set 114231.

WebCore.exp.in:
editing/DictationAlternative.cpp:

(WebCore::DictationAlternative::DictationAlternative):

editing/DictationAlternative.h:

(DictationAlternative):

9:37 AM Changeset in webkit [114265] by Antti Koivisto

6 edits
2 adds in trunk

REGRESSION (r104445): Style is not recomputed on serenaandlily.com
https://bugs.webkit.org/show_bug.cgi?id=83663

Source/WebCore:

Reviewed by Andreas Kling.

CSS class and id selectors are case insensitive in non-strict modes. The code
that invalidated the scope elements used getElementByID() which is case
sensitive in all modes. As a result we would fail to invalidate elements
that would match a style rule but used different case in id.

The new code invalidates by crawling the DOM tree. This often (when there are classes)
actually faster than the existing code as we can now handle everything in a single pass.
Each class scope required a crawl with the old code.

The code uses the same functions as the selector matching code to get the same behavior.

The maximum class limit is lifted as number of classes does not affect complexity anymore.

Test: fast/css/id-or-class-before-stylesheet-strict.html

css/SelectorChecker.h:

(WebCore::SelectorChecker::elementMatchesSelectorScopes):
(WebCore):

dom/Document.cpp:

(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore):

LayoutTests:

Reviewed by Andreas Kling.

Update the existing test with case insensitive comparisons and add a strict mode test.

fast/css/id-or-class-before-stylesheet-expected.txt:
fast/css/id-or-class-before-stylesheet-strict-expected.txt: Added.
fast/css/id-or-class-before-stylesheet-strict.html: Added.
fast/css/id-or-class-before-stylesheet.html:

9:28 AM April 2012 Meeting edited by tomz@codeaurora.org

(diff)

8:56 AM Changeset in webkit [114264] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Unflag frame flattening

tests fixed in r114262.

8:53 AM Changeset in webkit [114263] by commit-queue@webkit.org

6 edits in trunk

[BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
https://bugs.webkit.org/show_bug.cgi?id=84031

Patch by Jonathan Dong <Jonathan Dong> on 2012-04-16
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.

Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html

Api/DumpRenderTreeClient.h:

(WebCore):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

Tools:

Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.

DumpRenderTree/blackberry/DumpRenderTree.cpp:

(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):

DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(WebCore):
(DumpRenderTree):

8:51 AM Changeset in webkit [114262] by commit-queue@webkit.org

16 edits in trunk/LayoutTests

[Qt] LayoutTest: Replace setTimeout with synchronous layout for frame flattening where possible.
https://bugs.webkit.org/show_bug.cgi?id=84028

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.

It's safer (and faster) to force synchronous layout, than expecting a layout before setTimout(0) hits.

fast/frames/flattening/crash-svg-document.html: Remove extra line so that non-svg builds don't report failure.
fast/frames/flattening/frameset-flattening-advanced.html:
fast/frames/flattening/frameset-flattening-grid.html:
fast/frames/flattening/frameset-flattening-subframesets.html:
fast/frames/flattening/iframe-flattening-fixed-height.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
fast/frames/flattening/iframe-flattening-fixed-width.html:
fast/frames/flattening/iframe-flattening-nested.html:
fast/frames/flattening/iframe-flattening-offscreen.html:
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
fast/frames/flattening/iframe-flattening-out-of-view.html:
fast/frames/flattening/iframe-flattening-selection-crash.html:
fast/frames/flattening/iframe-flattening-simple.html:

8:36 AM Changeset in webkit [114261] by commit-queue@webkit.org

3 edits
2 adds in trunk

CSS3 Selectors failures on css3test.com
https://bugs.webkit.org/show_bug.cgi?id=83885

Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16
Reviewed by Zoltan Herczeg.

Source/WebCore:

Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type()
with values -n-b and n-b as they are of valid form an+b where a and b are integers.
http://www.w3.org/TR/selectors/#structural-pseudos

Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers.
However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor.
The original code only checked this if the string was n- or -n- but this is not enough.
We need to check everything which starts with an n- or -n- prefix.

Test: css3/parsing-css3-nthchild.html

css/CSSParser.cpp:

(WebCore::CSSParser::lex):

LayoutTests:

css3/parsing-css3-nthchild-expected.txt: Added.
css3/parsing-css3-nthchild.html: Added.

8:35 AM Changeset in webkit [114260] by Philippe Normand

2 edits in trunk

[GTK] GStreamer 1.0 support in configure.ac
https://bugs.webkit.org/show_bug.cgi?id=84029

Reviewed by Martin Robinson.

The GStreamer version was recently changed to 1.0 in the git
repositories of the project so we need to reflect this change in
configure.ac.

configure.ac:

8:33 AM Changeset in webkit [114259] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt:

8:18 AM Changeset in webkit [114258] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

ASSERT in notifyChildInserted when HTMLMediaElement is removed from tree
https://bugs.webkit.org/show_bug.cgi?id=83949

Reviewed by Antti Koivisto.

No new tests. I was not able to create a reproducible test case, but I have been unable
to reproduce the ASSERT that occassionally fired in existing tests since I have been
living on these changes.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedIntoDocument): Call configureMediaControls.
(WebCore::HTMLMediaElement::removedFromDocument): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Don't show controls when the

media element is not in a Document.

8:15 AM Changeset in webkit [114257] by commit-queue@webkit.org

2 edits in trunk/Tools

build-webkit --gtk --no-webkit2 builds WK2
https://bugs.webkit.org/show_bug.cgi?id=83977

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-16
Reviewed by Martin Robinson.

Scripts/build-webkit: Fixup ./configure option to disable

WebKit2 build.

8:13 AM Changeset in webkit [114256] by eric.carlson@apple.com

5 edits in trunk

Layout Test media/track/track-delete-during-setup.html is hitting an ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=82269

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests, already tested by media/track/track-delete-during-setup.html.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoDocument): Don't notify the media element until/unless
the track element is inserted into the document.

html/HTMLTrackElement.h:

LayoutTests:

platform/chromium/test_expectations.txt:

8:10 AM Changeset in webkit [114255] by mhahnenberg@apple.com

7 edits in trunk/Source/JavaScriptCore

GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by Geoffrey Garen.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.

(JSC::DEFINE_STUB_FUNCTION):

runtime/JSObject.cpp:

(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.

runtime/JSObject.h:

(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.

runtime/Structure.cpp:

(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):

runtime/Structure.h:

(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):

7:49 AM Changeset in webkit [114254] by commit-queue@webkit.org

2 edits
16 adds in trunk/LayoutTests

[EFL][DRT] Create baselines for CSS cases related to Ahem font
https://bugs.webkit.org/show_bug.cgi?id=83265

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16

platform/efl/fast/css/caption-width-absolute-position-expected.png: Added.
platform/efl/fast/css/caption-width-absolute-position-expected.txt: Added.
platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
platform/efl/fast/css/caption-width-fixed-position-expected.png: Added.
platform/efl/fast/css/caption-width-fixed-position-expected.txt: Added.
platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
platform/efl/fast/css/caption-width-relative-position-expected.png: Added.
platform/efl/fast/css/caption-width-relative-position-expected.txt: Added.
platform/efl/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
platform/efl/fast/css/min-width-with-spanned-cell-expected.png: Added.
platform/efl/fast/css/min-width-with-spanned-cell-expected.txt: Added.
platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
platform/efl/test_expectations.txt:

7:43 AM Changeset in webkit [114253] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build break in PageClientImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?=id=84034

Reviewed by Kenneth Rohde Christiansen.

Fixes typo in didChangeViewportProperites definition.

UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::didChangeViewportProperties):

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-04-16

7:33 AM Changeset in webkit [114252] by commit-queue@webkit.org

53 edits
56 adds in trunk/LayoutTests

[EFL][DRT] SVG rebaseline for tests affected by SVGEllipse and SVG shadow root changes
https://bugs.webkit.org/show_bug.cgi?id=84027

Unreviewed, EFL gardening.

Updating txt baselines for tests affected by r109097 and r112806,
creating pixel test results.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16

platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
platform/efl/svg/batik/paints/patternRegionA-expected.png: Added.
platform/efl/svg/batik/paints/patternRegionA-expected.txt:
platform/efl/svg/batik/paints/patternRegions-expected.png: Added.
platform/efl/svg/batik/paints/patternRegions-expected.txt:
platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
platform/efl/svg/carto.net/button-expected.png: Added.
platform/efl/svg/carto.net/button-expected.txt:
platform/efl/svg/carto.net/colourpicker-expected.png: Added.
platform/efl/svg/carto.net/colourpicker-expected.txt:
platform/efl/svg/carto.net/slider-expected.png: Added.
platform/efl/svg/carto.net/slider-expected.txt:
platform/efl/svg/carto.net/window-expected.png: Added.
platform/efl/svg/carto.net/window-expected.txt:
platform/efl/svg/clip-path/clip-in-mask-expected.png: Added.
platform/efl/svg/clip-path/clip-in-mask-expected.txt:
platform/efl/svg/clip-path/clip-path-child-clipped-expected.png: Added.
platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt:
platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt:
platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt:
platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt:
platform/efl/svg/clip-path/clip-path-evenodd-expected.png: Added.
platform/efl/svg/clip-path/clip-path-evenodd-expected.txt:
platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
platform/efl/svg/clip-path/clip-path-nonzero-expected.png: Added.
platform/efl/svg/clip-path/clip-path-nonzero-expected.txt:
platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Added.
platform/efl/svg/clip-path/clip-path-pixelation-expected.txt:
platform/efl/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt:
platform/efl/svg/clip-path/clip-path-transform-1-expected.png: Added.
platform/efl/svg/clip-path/clip-path-transform-1-expected.txt:
platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt:
platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt:
platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt:
platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt:
platform/efl/svg/clip-path/clip-path-with-container-expected.png: Added.
platform/efl/svg/clip-path/clip-path-with-container-expected.txt:
platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt:
platform/efl/svg/clip-path/clipper-placement-issue-expected.png: Added.
platform/efl/svg/clip-path/clipper-placement-issue-expected.txt:
platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
platform/efl/svg/css/clippath-with-shadow-expected.png: Added.
platform/efl/svg/css/clippath-with-shadow-expected.txt:
platform/efl/svg/css/mask-with-shadow-expected.png: Added.
platform/efl/svg/css/mask-with-shadow-expected.txt:
platform/efl/svg/css/shadow-changes-expected.png: Added.
platform/efl/svg/css/shadow-changes-expected.txt:
platform/efl/svg/hixie/cascade/001-broken-expected.png: Added.
platform/efl/svg/hixie/cascade/001-broken-expected.txt:
platform/efl/svg/hixie/cascade/002-expected.png: Added.
platform/efl/svg/hixie/cascade/002-expected.txt:
platform/efl/svg/hixie/error/001-expected.png: Added.
platform/efl/svg/hixie/error/001-expected.txt:
platform/efl/svg/hixie/error/003-expected.png: Added.
platform/efl/svg/hixie/error/003-expected.txt:
platform/efl/svg/hixie/error/017-expected.png: Added.
platform/efl/svg/hixie/error/017-expected.txt:
platform/efl/svg/hixie/perf/001-expected.png: Added.
platform/efl/svg/hixie/perf/001-expected.txt: Added.
platform/efl/svg/hixie/perf/002-expected.png: Added.
platform/efl/svg/hixie/perf/002-expected.txt: Added.
platform/efl/svg/hixie/rendering-model/001-expected.png: Added.
platform/efl/svg/hixie/rendering-model/001-expected.txt:
platform/efl/svg/hixie/rendering-model/002-expected.png: Added.
platform/efl/svg/hixie/rendering-model/002-expected.txt:
platform/efl/svg/hixie/transform/001-expected.png: Added.
platform/efl/svg/hixie/transform/001-expected.txt:
platform/efl/svg/hixie/use/001-expected.png: Added.
platform/efl/svg/hixie/use/001-expected.txt:
platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:

7:30 AM WebKit Team edited by rafael.lobo@openbossa.org

Adding myself to the committers list. (diff)

7:20 AM Changeset in webkit [114251] by Lucas Forschler

2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merged r112966.

7:17 AM Changeset in webkit [114250] by commit-queue@webkit.org

4 edits in trunk

[EFL] [DRT] Feeding key events with invalid keyName
https://bugs.webkit.org/show_bug.cgi?id=83797

Tools:

Keep the keyName valid within scope of KeyEventInfo to avoid
feeding key events with invalid keyName.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.

DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):

LayoutTests:

Unskip fast/frames/iframe-window-focus.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.

platform/efl/Skipped:

7:05 AM Changeset in webkit [114249] by yael.aharon@nokia.com

8 edits
1 add in trunk

[Qt][WK2] Fixed elements position is wrong after zooming.
https://bugs.webkit.org/show_bug.cgi?id=83981

Reviewed by Kenneth Rohde Christiansen.

ManualTests/remove-add-fixed-position.html: Added.

Source/WebCore:

When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
In order to find these elements, RenderView maintains a list of fixed elements.
They are added and removed at the same time that they are added and removed from their parent RenderBlock.
The idea is taken from the iOS5.1 branch, at opensource.apple.com.
Added a manual test that allows removing and adding fixed elements at will.

page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):

rendering/RenderView.cpp:

(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
(WebCore):
(WebCore::RenderView::insertFixedPositionedObject):
(WebCore::RenderView::removeFixedPositionedObject):

rendering/RenderView.h:

(RenderView):

Source/WebKit2:

Turn on the flag setFixedElementsLayoutRelativeToFrame. This causes fixed elements position to be calculated based on
visibleWidth and visibleHeight. When zoom level grows, the visibleWidth and visibleHeight become smaller.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

6:59 AM Changeset in webkit [114248] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, skip crash test in chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=84024

platform/chromium/test_expectations.txt:

6:38 AM Changeset in webkit [114247] by kenneth@webkit.org

6 edits in trunk/Source/WebKit2

[Qt] Clean up how the interaction engine is making use of ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=83895

Reviewed by Simon Hausmann.

Refactor how the interaction engine is using the ViewportAttributes
and get rid of the Contraints subclass.

Push the ViewportAttributes through to the QQuickWebViewPrivate class
and add some default values in the case the Legacy view is used.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::setCSSScaleBounds):
(WebKit::QtViewportInteractionEngine::setCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):

UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::hadUserInteraction):
(WebKit::QtViewportInteractionEngine::setAllowsUserScaling):
(WebKit::QtViewportInteractionEngine::setContentToDevicePixelRatio):

6:19 AM Changeset in webkit [114246] by pierre.rossi@gmail.com

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after QRawFont change.

Missed this one earlier. We now use primaryFontHasGlyphForCharacter from
FontFastPath.cpp, resulting in a different DRT output.

platform/qt-5.0/Skipped: unskip
platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:

6:16 AM SelectiveTestEWS edited by beszedes@inf.u-szeged.hu

(diff)

6:09 AM SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu

(diff)

5:58 AM Changeset in webkit [114245] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820

Unreviewed gardening. Skip new failing tests after r114240 until fix.

platform/qt-5.0/Skipped:

5:53 AM Changeset in webkit [114244] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL][DRT] Gardening CSS Regions & Exclusions
https://bugs.webkit.org/show_bug.cgi?id=84011

Skipping CSS regions and exclusions tests for now,
waiting for feature to complete.

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16

platform/efl/Skipped:
platform/efl/test_expectations.txt:

5:41 AM Changeset in webkit [114243] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/test_expectations.txt: Flag two failing media tests.

4:58 AM Top100Invariant edited by beszedes@inf.u-szeged.hu

(diff)

4:57 AM RegressionTestResearch edited by beszedes@inf.u-szeged.hu

(diff)

4:51 AM SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu

(diff)

4:50 AM Changeset in webkit [114242] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
https://bugs.webkit.org/show_bug.cgi?id=83933

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-16
Reviewed by Adam Treat.

RIM PR: 149609
This was because I accidentally dropped an exclamation mark when
upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
the exclamation mark.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):

4:49 AM Improving Regression Tests edited by beszedes@inf.u-szeged.hu

(diff)

4:46 AM Changeset in webkit [114241] by pfeldman@chromium.org

26 edits
1 add in trunk

Web Inspector: extract ContentProvider into its own file, make NetworkRequest, Resoruce and others implement it.
https://bugs.webkit.org/show_bug.cgi?id=83922

Reviewed by Yury Semikhatsky.

Source/WebCore:

We have two different types of requestContent methods: one on the source mapping level and one on the resource level.
There are also adapters between the two. I'm aligning it all to a single requestContent method declared in ContentProvider.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):

inspector/front-end/ContentProvider.js: Added.

(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.contentURL):
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
(WebInspector.ContentProvider.SearchMatch):

inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.contentURL):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentURL):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.requestContent):

inspector/front-end/DebuggerPresentationModel.js:
inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._getResourceContent):

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.requestContent):

inspector/front-end/NetworkItemView.js:

(WebInspector.RequestContentView.prototype._ensureInnerViewShown.callback):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):

inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.contentURL):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.searchInContent):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):

inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.contentURL):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.contentURL):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.searchInContent):

inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):

inspector/front-end/ScriptFormatter.js:
inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

LayoutTests:

http/tests/inspector/compiler-script-mapping.html:
inspector/debugger/content-providers-expected.txt:
inspector/debugger/content-providers.html:
inspector/debugger/raw-source-code.html:
inspector/debugger/ui-source-code.html:

4:44 AM Changeset in webkit [114240] by kbalazs@webkit.org

3 edits
6 adds in trunk/Tools

[Qt] Replace QtXmlPatterns usage with libxslt dependency
<https://bugs.webkit.org/show_bug.cgi?id=76820>

Patch by Andras Piroska <pandras@inf.u-szeged.hu> on 2012-04-16
Reviewed by Simon Hausmann.

The features.prf file was modified, in order to use libxml and libxslt by default.
This modification only work at Qt5.

qmake/config.tests/libxml2/libxml2.cpp: Added.

(main):

qmake/config.tests/libxml2/libxml2.pro: Added.
qmake/config.tests/libxslt/libxslt.cpp: Added.

(main):

qmake/config.tests/libxslt/libxslt.pro: Added.
qmake/mkspecs/features/features.prf:
qmake/sync.profile:

4:32 AM Changeset in webkit [114239] by toyoshim@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, fix a wrong expected.txt
https://bugs.webkit.org/show_bug.cgi?id=84014

fast/canvas/webgl/shader-precision-format-expected.txt:

4:20 AM Changeset in webkit [114238] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
https://bugs.webkit.org/show_bug.cgi?id=83862

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.

EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
It doesn't work properly because of wrong parameter order in function call.

EWebLauncher/main.c:

3:13 AM Changeset in webkit [114237] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests, because less tests means less problems.

platform/qt-5.0/Skipped:
platform/qt/Skipped:

2:24 AM Changeset in webkit [114236] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r114200.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

2:04 AM Changeset in webkit [114235] by commit-queue@webkit.org

3 edits
2 adds in trunk

[BlackBerry] Missing readyState 2 when a XMLHttpRequest calls xmlhttp.open("HEAD","notExist.html",true).
https://bugs.webkit.org/show_bug.cgi?id=83866

Source/WebCore:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.

We receive 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case shouldn't be treated as a failure.

Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyClose):

LayoutTests:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.

http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404-expected.txt: Added.
http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html: Added.

1:56 AM Changeset in webkit [114234] by tkent@chromium.org

7 edits
2 deletes in trunk/LayoutTests

[Chromium] Rebaseline for date-appearance.html.

platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Removed.
platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
platform/chromium-win/fast/forms/date/date-appearance-expected.png:
platform/chromium-win/fast/forms/date/date-appearance-expected.txt:

1:42 AM Changeset in webkit [114233] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt]REGRESSION(r114217): It broke fast/repaint/line-flow-with-floats-in-regions.html
https://bugs.webkit.org/show_bug.cgi?id=84013

Unreviewed gardening, skip a failing test to paint the bot green. (Less tests, less problem.)

platform/qt/Skipped:

1:32 AM Changeset in webkit [114232] by Philippe Normand

1 edit
12 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests added in r114162.

platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.

1:16 AM Changeset in webkit [114231] by jonlee@apple.com

4 edits in trunk/Source/WebCore

Build fix.

WebCore.exp.in:
editing/DictationAlternative.cpp:

(WebCore::DictationAlternative::DictationAlternative):

editing/DictationAlternative.h:

(DictationAlternative):

1:11 AM Changeset in webkit [114230] by staikos@webkit.org

2 edits in trunk/Source/WebCore

Fix signed/unsigned mismatch warning for BlackBerry debug builds.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Rob Buis.

platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeCookieAtIndex):

12:42 AM Changeset in webkit [114229] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/test_expectations.txt: Skip svg failures, unskip

ietestcenter for rebaseline and unflag a flaky media/track test.

12:26 AM Changeset in webkit [114228] by Philippe Normand

2 edits in trunk/Tools

Unreviewed, GTK gardening.

Scripts/run-gtk-tests:

(TestRunner): Skip /webkit/atk/textChangedNotifications.

12:14 AM Changeset in webkit [114227] by thakis@chromium.org

2 edits in trunk/Source/WTF

Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2
https://bugs.webkit.org/show_bug.cgi?id=83999

Reviewed by Sam Weinig.

Before this patch, NullPtr.h assumed that a working |nullptr| implied
a working |std::nullptr_t| as well. With clang and libstdc++4.2, this
is not true.

I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03)
with clang.

wtf/NullPtr.h:

(std):

Apr 15, 2012:

11:37 PM Changeset in webkit [114226] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Use GRefPtr to delete the default web context in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=83752

Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):

11:23 PM Changeset in webkit [114225] by Csaba Osztrogonác

8 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
platform/qt/Skipped: Skip a test after r114150, because of missing layoutTestController.setBackingScaleFactor().
platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114150.

11:12 PM Changeset in webkit [114224] by tkent@chromium.org

2 edits in trunk/Source/WebCore

WebCore::weekDayShortLabels() for ICU always returns the fallback labels
https://bugs.webkit.org/show_bug.cgi?id=83991

Reviewed by Hajime Morita.

We need to specfiy 1-based index to udat_getSymbols() with
UDAT_SHORT_WEEKDAYS. Also, udat_countSymbols() with UDAT_SHORT_WEEKDAYS
returns 8.

No new tests because this behavior depends on locale setting.

platform/text/LocalizedCalendarICU.cpp:

(WebCore::createLabelVector): Add startIndex argument.
(WebCore::createMonthLabels):
Pass UDAT_JANUARRY(0) as startIndex to createLabelVector().
(WebCore::createWeekDayShortLabels):
Pass UDAT_SUNDAY(1) as startIndex to createLabelVector().

10:32 PM PrefixedAPIs edited by Koji Ishii

(diff)

10:21 PM Changeset in webkit [114223] by keishi@webkit.org

7 edits in trunk/Source/WebKit/chromium

Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777

Introducing MenuItemIDs because we want to add multiple separators and
need to identify non-autofill menu items without resorting to the separator position.

Reviewed by Kent Tamura.

public/WebAutofillClient.h:

(WebKit::WebAutofillClient::didAcceptAutofillSuggestion): Changed uniqueID to itemID because they aren't unique.
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):

public/WebView.h:

(WebView):

src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):

src/AutofillPopupMenuClient.h: Removed m_separatorIndex because now we use itemID to identify separators.

Added m_useLegacyBehavior which is true when it is initialized with a valid separator index. This is to keep
the autofill working even when the chromium side hasn't been updated yet.
(AutofillPopupMenuClient):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

src/WebViewImpl.h:

(WebViewImpl):

9:13 PM Changeset in webkit [114222] by morrita@google.com

2 edits in trunk/Source/WebCore

Unreviewed attempt to chromium-win build fix.

editing/DictationAlternative.h:

8:54 PM Changeset in webkit [114221] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

Align JSC/V8 bindings canvas.toDataURL() code flows
https://bugs.webkit.org/show_bug.cgi?id=84003

Reviewed by Eric Seidel.

Align JSC/V8 bindings canvas.toDataURL() code flow so that the binding
code implementations read alike.

No new tests. Covered by existing cnavas toDataURL tests.

bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::toDataURL):

8:05 PM Changeset in webkit [114220] by jpu@apple.com

31 edits
3 copies
3 adds in trunk/Source/WebCore

Introducing DictationCommand.
https://bugs.webkit.org/show_bug.cgi?id=83549

Reviewed by Hajime Morita.

No new tests. This patch doesn't introduce any change of new functionality. It prepares for
additional changes which will inlude tests.

On OS X, alternative dictation results need to be stored as document markers. This patch introduces
following changes to achieve this:

Added DictationMarkDetails to store non-string type maker detail.
Introduce DictationCommand, which is similor to TypingCommand, but allows inserting text with attached markers.
Added Editor::insertDictatedText as interaface to WebKit and WebKit2.
Added struct DictationAlternative to pass dictation related info from WebKit to WebCore.

Several fragments of code in TypingCommand can be also used by DictationCommand. So this patch
introduced a new class, TextInsertionBaseCommand. It's a subclass of CompositeEditCommmand, and
base class of both TypingCommand and DictationCommand.

This patch also extends InsertTextCommand class. Its constructor will take an TextInsertionMarkerSupplier
object. After text is inserted to a node, InsertTextCommand would give marker supplier a chance to
add document markers to the inserted text.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::eventTargetNodeForDocument): Moved this function from EventHandler so that it can be used

by AlternativeTextController.

(WebCore):

dom/Document.h:

(WebCore):

dom/DocumentMarker.cpp:

(WebCore::DocumentMarker::DocumentMarker): New constructor that takes a pointer to DocumentMarkerDetails object.
(WebCore):

dom/DocumentMarker.h:

(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(DocumentMarker):

dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):
(WebCore):

dom/DocumentMarkerController.h:

(DocumentMarkerController):

dom/TextEvent.cpp:

(WebCore::TextEvent::createForDictation):
(WebCore):
(WebCore::TextEvent::TextEvent):

dom/TextEvent.h: Added member variable for dictation alternatives.

(TextEvent):
(WebCore::TextEvent::isDictation):
(WebCore::TextEvent::dictationAlternatives):

dom/TextEventInputType.h:
editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::insertDictatedText): Used by Editor::insertDictatedText().
(WebCore):

editing/AlternativeTextController.h:

(WebCore):
(DictationMarkerDetails):
(WebCore::DictationMarkerDetails::create):
(WebCore::DictationMarkerDetails::originalText):
(WebCore::DictationMarkerDetails::dictationContext):
(WebCore::DictationMarkerDetails::DictationMarkerDetails):
(AlternativeTextController):

editing/CompositeEditCommand.h:

(WebCore::CompositeEditCommand::isDictationCommand):

editing/DictationAlternative.cpp: Added.

(WebCore):
(WebCore::DictationAlternative::DictationAlternative):

editing/DictationAlternative.h: Added. Data structure for passing dictation related data from WebKit to WebCore.

(DictationAlternative):
(WebCore):

editing/DictationCommand.cpp: Added.

(WebCore):
(DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator()):
(DictationMarkerSupplier):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::addMarkersToTextNode):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):
(WebCore::DictationCommand::collectDictationAlternativesInRange):

editing/DictationCommand.h: Added.

(WebCore):
(DictationCommand):
(WebCore::DictationCommand::isDictationCommand):
(WebCore::DictationCommand::create):

editing/EditingAllInOne.cpp:
editing/Editor.cpp:

(WebCore::Editor::insertDictatedText): Main interface that allows WebKit passes in text with attached dictation information.
(WebCore):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

editing/Editor.h:

(Editor):

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand):
(WebCore):
(WebCore::InsertTextCommand::doApply):

editing/InsertTextCommand.h:

(WebCore):
(TextInsertionMarkerSupplier): Interface to allow caller of InsertTextCommand to add document markers to inserted text.
(WebCore::TextInsertionMarkerSupplier::~TextInsertionMarkerSupplier):
(WebCore::TextInsertionMarkerSupplier::TextInsertionMarkerSupplier):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
(InsertTextCommand):

editing/TextInsertionBaseCommand.cpp: Added. This class contains functions shared by TypingCommand and DictationCommand.

(WebCore):
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):

editing/TextInsertionBaseCommand.h: Added.

(WebCore):
(TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
(WebCore::forEachLineInString):

editing/TypingCommand.cpp:

(TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::operator()):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):

editing/TypingCommand.h:
page/EventHandler.cpp:
rendering/InlineTextBox.cpp:

(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarker): Renamed existing function to reflect new funcationality.
(WebCore::InlineTextBox::paintDocumentMarkers):

rendering/InlineTextBox.h:

(InlineTextBox):

testing/Internals.cpp:

(WebCore::markerTypesFrom):

7:49 PM Changeset in webkit [114219] by jamesr@google.com

33 edits
2 copies
4 adds
6 deletes in trunk/LayoutTests

[chromium] Unreviewed rebaselines for various compositing tests.

platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Removed.
platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Removed.
platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Added.
platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
platform/chromium-mac/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Removed.
platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Removed.
platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Removed.
platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Added.
platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
platform/chromium-win/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.

7:44 PM Changeset in webkit [114218] by commit-queue@webkit.org

16 edits in trunk/Source

[chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=83415

Patch by James Robinson <jamesr@chromium.org> on 2012-04-15
Reviewed by Adrienne Walker.

Source/WebCore:

This removes all knowledge of CCLayerImpl from LayerRendererChromium. The most significant move code-wise is
moving the HUD up to live on CCLayerTreeHostImpl, since it's aware of the layer tree. This involves two changes.
First, CCHeadsUpDisplay is in charge of populating a ManagedTexture but the actual drawing code now lives in
LayerRendererChromium. Second, since we don't recreate CCLayerTreeHostImpl on a lost context, the font atlas
ownership is much simpler. Now a CCFontAtlas is created on the main thread if needed and passed asynchronously
to the CCHeadsUpDisplay which takes ownership of the atlas.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::swapBuffers):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromiumClient):
(LayerRendererChromium):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::setFontAtlas):
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):

platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore::CCLayerTreeHostImpl::layerTreeAsText):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setFontAtlas):
(WebCore::CCLayerTreeHostImpl::dumpRenderSurfaces):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootLayer):

platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::setFontAtlas):
(WebCore):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:
platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::setFontAtlas):
(WebCore):
(WebCore::CCThreadProxy::setFontAtlasOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Add an explicit rootLayer getter to the test implementation of LayerRendererChromium since there isn't one on
the base class any more.

tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):

7:40 PM Changeset in webkit [114217] by Antti Koivisto

27 edits in trunk

Capture CSS parser context
https://bugs.webkit.org/show_bug.cgi?id=83998

Source/WebCore:

Reviewed by Andreas Kling.

Currently the CSS parser calls to the Document and StyleSheetInternal objects to get settings, base URL etc.
The required information should be passed in on parser construction instead. The parser should not need to
know about the document at all.

The patch adds CSSParserContext struct that captures the parsing context. StyleSheetInternal saves the
parsing context and reuses it for any further parsing.

If the same stylesheet source is parsed with an identical context then the resulting stylesheet structure will
be identical. This will allow sharing parsed stylesheets in the future.

css/CSSGrammar.y:
css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):

css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

css/CSSParser.cpp:

(WebCore):
(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::completeURL):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):

css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::inStrictMode):
(WebCore::CSSParser::inQuirksMode):
(WebCore::CSSParser::validUnit):

css/CSSParserMode.h:

(WebCore):
(CSSParserContext):

css/CSSRule.h:

(WebCore::CSSRule::parserContext):
(CSSRule):

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore):
(WebCore::StyleSheetInternal::updateBaseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::CSSStyleSheet::insertRule):

css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::parserContext):
(WebCore::StyleSheetInternal::charset):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::baseURL):

css/CSSValuePool.cpp:
css/StylePropertySet.cpp:

(WebCore::StylePropertySet::parseDeclaration):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

Reviewed by Andreas Kling.

Modify the tests so that they don't expect settings changes to apply to already existing stylesheets.

css3/filters/script-tests/custom-filter-property-parsing.js:
fast/regions/script-tests/css-regions-disabled.js:

7:14 PM Changeset in webkit [114216] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[Cairo] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83975

Reviewed by Martin Robinson.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests. Covered by existing canvas toDataURL tests.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Rename closure to output.
(WebCore::encodeImage): Output the encoded image to the provided Vector<char>.
PNG format is only supported per the Cairo encoding MIMETypeRegistry.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Refactor to use encodeImage().

6:43 PM Changeset in webkit [114215] by yutak@chromium.org

7 edits in trunk/Source

Leak in WebSocketChannel with workers/worker-reload.html (part 2)
https://bugs.webkit.org/show_bug.cgi?id=83749

Reviewed by David Levin.

Source/WebCore:

Second attempt to remove leaks around WorkerThreadableWebSocketChannel.

No new tests, as this patch does not impose any functional change.

Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::failedWebSocketChannelCreation):
(WebCore::ThreadableWebSocketChannelClientWrapper::setFailedWebSocketChannelCreation):

Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

Add a boolean flag indicating whether Bridge::initialize() has exited without receiving
a pointer to the peer object.

Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::performTask):
Kick mainThreadDestroy() to delete the peer if the bridge has failed to receive
a pointer to the peer (waitForMethodCompletion() exited due to message queue's
termination).
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):

Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
Make WorkerContextDidInitializeTask an inner class of WorkerThreadableWebSocketChannel
so it can refer WorkerThreadableWebSocketChannel's static member function (mainThreadDestroy()).

Source/WebKit/chromium:

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
Correctly propagate the return value of postTaskForModeToWorkerContext().

4:15 PM Changeset in webkit [114214] by rniwa@webkit.org

2 edits in trunk/Tools

Chromium perf bots should not build
https://bugs.webkit.org/show_bug.cgi?id=83641

Reviewed by Eric Seidel.

Don't build on perf bots to improve the cycle time.

BuildSlaveSupport/build.webkit.org-config/config.json:

8:23 AM Changeset in webkit [114213] by rakuco@webkit.org

1 delete in trunk/LayoutTests/platform/efl/fast/regions

Remove empty directory.

8:21 AM Changeset in webkit [114212] by rakuco@webkit.org

2 edits
50 deletes in trunk/LayoutTests

[EFL] Gardening. Skip fast/regions tests.

SVN r90067 skipped fast/regions for many ports, but EFL's skipped
list was added later. Skip all tests there and remove existing
baselines.

platform/efl/Skipped:
platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Removed.
platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Removed.
platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Removed.
platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Removed.
platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Removed.
platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.

Apr 14, 2012:

8:51 PM Changeset in webkit [114211] by eae@chromium.org

4 edits in trunk/Source/WebCore

Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
https://bugs.webkit.org/show_bug.cgi?id=83929

Reviewed by Eric Seidel.

Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.

No new tests, no change in functionality.

html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

html/shadow/MediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

8:31 PM Changeset in webkit [114210] by tkent@chromium.org

2 edits in trunk/Source/WebCore

Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
https://bugs.webkit.org/show_bug.cgi?id=83990

Reviewed by Kentaro Hara.

We passed the "weekStartDay" property value as a
string. CalendarPickerElement::writeDocument() created:

weekStartDay: "1",

and the JavaScript code used it in the following code:

dayLabels[(weekStartDay + i) % 7]

If weekStartDay was "1", the expression (weekStartDay + i)
produced "10", "11", "12", ... We expected "1", "2", "3", ...

We need to pass the "weekStartDay" property as a number.

No new tests because we have no ways to test this for now. We'll
introduce tests for the calendar picker later.

html/shadow/CalendarPickerElement.cpp:

(WebCore::addProperty): Add addProperty() function for a number.
(WebCore::CalendarPickerElement::writeDocument):
Pass a number, not a serialized number.

5:43 PM Changeset in webkit [114209] by weinig@apple.com

2 edits in trunk/Source/WTF

Harden WTF::ByteArray::create()
https://bugs.webkit.org/show_bug.cgi?id=83318

Reviewed by Maciej Stachowiak.

wtf/ByteArray.cpp:

(WTF::ByteArray::create):
Add overflow check. I don't believe there is anyway to trigger this currently,
hence no tests, so this should be considered hardening.

2:29 PM Changeset in webkit [114208] by commit-queue@webkit.org

4 edits
4 adds in trunk

Viewport-percentage Length units does not work for Replaced elements size
https://bugs.webkit.org/show_bug.cgi?id=83425

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added the support for viewport-percentage length units while calculating the width/height of replaced elements.

Source/WebCore:

Tests: css3/viewport-percentage-lengths/viewport-percentage-image-size.html

platform/Length.h:

(WebCore::Length::isSpecified):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

LayoutTests:

css3/viewport-percentage-lengths/resources: Added.
css3/viewport-percentage-lengths/resources/colorsquare.png: Added.
css3/viewport-percentage-lengths/viewport-percentage-image-size-expected.html: Added.
css3/viewport-percentage-lengths/viewport-percentage-image-size.html: Added.

2:05 PM Changeset in webkit [114207] by commit-queue@webkit.org

3 edits
2 adds in trunk

CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
https://bugs.webkit.org/show_bug.cgi?id=80736

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added support for fetching the value of 'border-radius' CSS property which was missing.

Source/WebCore:

Test: fast/css/border-radius-property-value.html

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

fast/css/border-radius-property-value-expected.txt: Added.
fast/css/border-radius-property-value.html: Added.

11:29 AM Changeset in webkit [114206] by commit-queue@webkit.org

4 edits in trunk

[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
https://bugs.webkit.org/show_bug.cgi?id=81945

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.

Tools:

WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.

platform/mac-wk2/Skipped:

11:15 AM Changeset in webkit [114205] by hyatt@apple.com

3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=83826

Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.

Reviewed by Dan Bernstein.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):

3:30 AM WebKitGTK edited by sh4.seo@samsung.com

Use internal link (diff)

2:34 AM Changeset in webkit [114204] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=83569

Reviewed by Eric Seidel.

No new tests. Covered by exiting fast/canvas/*toDataURL* tests.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.

Apr 13, 2012:

11:02 PM Changeset in webkit [114203] by commit-queue@webkit.org

7 edits in trunk/Source

[Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
https://bugs.webkit.org/show_bug.cgi?id=83804

Patch by David Reveman <reveman@chromium.org> on 2012-04-13
Reviewed by James Robinson.

Source/WebCore:

Cleanup code that determines if we need to use a buffered update and
avoid buffering of tiles that are not in use by the impl thread.

Tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread

TiledLayerChromiumTest.partialUpdates

platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::bufferedUpdates):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::setLayerPropertiesForTesting):
(WTF):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

8:32 PM Changeset in webkit [114202] by danakj@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
https://bugs.webkit.org/show_bug.cgi?id=83899

Reviewed by Adrienne Walker.

When a LTH becomes invisible, the texture eviction is spread out across
two different functions and is not entirely clear. We move all the logic
together into a single place in didBecomeInvisibleOnImplThread() and
make the consequences of the current code more clear.

Covered by existing tests.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

8:07 PM Changeset in webkit [114201] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it.
https://bugs.webkit.org/show_bug.cgi?id=83920

Reviewed by James Robinson.

Found by clang:

third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion]
EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f)));

tests/LayerChromiumTest.cpp:

8:06 PM Changeset in webkit [114200] by commit-queue@webkit.org

39 edits
6 deletes in trunk

Unreviewed, rolling out r114036.
http://trac.webkit.org/changeset/114036
https://bugs.webkit.org/show_bug.cgi?id=83969

Breaks gmail.com causing it to never finish loading (Requested
by danakj on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

bindings/v8/V8HiddenPropertyName.h:

(WebCore):

bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

dom/NodeList.idl:

LayoutTests:

fast/dom/HTMLSelectElement/named-options-expected.txt:
fast/dom/HTMLSelectElement/script-tests/named-options.js:
fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
fast/dom/NodeList/node-list-array-class.html: Removed.
fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
fast/dom/everything-to-string-expected.txt:
fast/dom/prototype-inheritance-2-expected.txt:
fast/js/recursion-limit-equal-expected.txt:
inspector/console/command-line-api-expected.txt:
inspector/console/console-dir-expected.txt:
inspector/console/console-format-collections-expected.txt:
jquery/traversing-expected.txt:
platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
platform/chromium/fast/dom/everything-to-string-expected.txt: Removed.
platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
platform/chromium/inspector/console/console-dir-expected.txt:
platform/chromium/inspector/console/console-format-collections-expected.txt:
platform/chromium/jquery/traversing-expected.txt: Removed.
platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

8:02 PM Changeset in webkit [114199] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Add null pointer check to animatePageScale
https://bugs.webkit.org/show_bug.cgi?id=83940

Patch by Alexandre Elias <aelias@google.com> on 2012-04-13
Reviewed by James Robinson.

Add null pointer check to startPageScaleAnimation.

If the root scroll layer goes away in the middle of a page scale
animation, there can be a null pointer access here.

No new tests.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animatePageScale):

7:33 PM Changeset in webkit [114198] by jchaffraix@webkit.org

5 edits in trunk/LayoutTests

Two lineboxcontain tests are failing
https://bugs.webkit.org/show_bug.cgi?id=82742

Reviewed by Ojan Vafai.

platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:

Rebaselined.

platform/mac/Skipped:
platform/mac/test_expectations.txt:

Unskip some tests that are either rebaselined or now passing due to
r112582 re-adding some of the RenderLayers removed by r110072.

6:58 PM Changeset in webkit [114197] by danakj@chromium.org

6 edits in trunk/Source

[chromium] Replicas should be included in the computed occlusion
https://bugs.webkit.org/show_bug.cgi?id=82262

Reviewed by Adrienne Walker.

Source/WebCore:

When merging a surface's occlusion up to its target, make a copy of it
where the replica will be as well, and make sure that occlusion from a
RenderSurface does not leave its clipRect.

Unit test: CCOcclusionTrackerTestReplicaDoesOcclude

CCOcclusionTrackerTestReplicaWithClipping
CCOcclusionTrackerTestSurfaceChildOfSurface

platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::hasReplica):
(WebCore):

platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):

Source/WebKit/chromium:

tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestReplicaDoesOcclude):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaWithClipping):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):

6:30 PM Changeset in webkit [114196] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add layout test case for JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=83747

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.

webaudio/javascriptaudionode-expected.txt: Added.
webaudio/javascriptaudionode.html: Added.

6:29 PM Changeset in webkit [114195] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r114185.
http://trac.webkit.org/changeset/114185
https://bugs.webkit.org/show_bug.cgi?id=83967

Broke a bunch of JavaScript related tests (Requested by
andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

runtime/CommonIdentifiers.h:
tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases):

6:27 PM Changeset in webkit [114194] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

convolution-mono-mono test passes now
https://bugs.webkit.org/show_bug.cgi?id=83793

Patch by Raymond Toy <Raymond Toy> on 2012-04-13
Reviewed by Eric Seidel.

platform/chromium/test_expectations.txt: Delete entry.

6:25 PM Changeset in webkit [114193] by commit-queue@webkit.org

7 edits
2 adds in trunk

AudioContext createChannelMerger() method should have optional argument for number of inputs.
https://bugs.webkit.org/show_bug.cgi?id=83759

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.

Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.

Source/WebCore:

Test: webaudio/audiochannelmerger-basic.html

Modules/webaudio/AudioChannelMerger.cpp:

(WebCore):
(WebCore::AudioChannelMerger::create):
(WebCore::AudioChannelMerger::AudioChannelMerger):

Modules/webaudio/AudioChannelMerger.h:

(AudioChannelMerger):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createChannelMerger):
(WebCore):

Modules/webaudio/AudioContext.h:

(AudioContext):

Modules/webaudio/AudioContext.idl:

LayoutTests:

webaudio/audiochannelmerger-basic-expected.txt: Added.
webaudio/audiochannelmerger-basic.html: Added.

6:20 PM Changeset in webkit [114192] by barraclough@apple.com

4 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch calls
https://bugs.webkit.org/show_bug.cgi?id=83966

Rubber stamped by Oliver Hunt.

These aren't being used anywhere!

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

5:42 PM Changeset in webkit [114191] by danakj@chromium.org

4 edits in trunk/Source/WebCore

[chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316

Reviewed by Adrienne Walker.

We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.

We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.

Covered by existing tests.

platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):

platform/graphics/chromium/TextureManager.h:

(TextureManager):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):

5:38 PM Changeset in webkit [114190] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Optimize tracking of intruding floats being removed from RenderBlock during layout
https://bugs.webkit.org/show_bug.cgi?id=82928

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-13
Reviewed by David Hyatt.

Performance tweaks in RenderBlock layout as a follow up to r112935.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

5:36 PM Changeset in webkit [114189] by mihnea@adobe.com

14 edits
2 adds in trunk

[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

Source/WebCore:

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).

Test: fast/regions/webkit-named-flow-content-nodes.html

dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::detach):

dom/Node.h:

(WebCore::Node::inNamedFlow):
(WebCore::Node::setInNamedFlow):
(WebCore::Node::clearInNamedFlow):
(Node):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):

dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

dom/WebKitNamedFlow.idl:
rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

rendering/FlowThreadController.h:

(FlowThreadController):

rendering/RenderNamedFlowThread.cpp:

(WebCore):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):

rendering/RenderNamedFlowThread.h:

(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::hasContentNode):

LayoutTests:

fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
fast/regions/webkit-named-flow-content-nodes.html: Added.

5:34 PM Changeset in webkit [114188] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Remove the calls to CRASH() from ResourceLoader.cpp.
https://bugs.webkit.org/show_bug.cgi?id=83962

Reviewed by Alexey Proskuryakov.

They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

5:33 PM Changeset in webkit [114187] by xji@chromium.org

2 edits in trunk/Source/WebCore

REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
when using certain fonts
https://bugs.webkit.org/show_bug.cgi?id=83523

Reviewed by Kent Tamura.

Revert r102190.
Convert characters being treatAsSpace to white space.

platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::fillRuns):
(WebCore::UniscribeHelper::adjustSpaceAdvances):

5:27 PM Changeset in webkit [114186] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove fallback code for "Missing plug-in" string.
https://bugs.webkit.org/show_bug.cgi?id=81907

Patch by Bernhard Bauer <bauerb@google.com> on 2012-04-13
Reviewed by Adam Barth.

src/LocalizedStrings.cpp:

(WebCore::missingPluginText):

5:26 PM Changeset in webkit [114185] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Array.prototype.toString and Array.prototype.toLocaleString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Patch by Hojong Han <hojong.han@samsung.com> on 2012-04-13
Reviewed by Gavin Barraclough.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

runtime/CommonIdentifiers.h:
tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases.array.item.new.TestCase):
(getTestCases):

5:11 PM Changeset in webkit [114184] by timothy@apple.com

2 edits in trunk/Source/WebCore

Change how the Web Insector is installed on Mac builds.

<rdar://problem/10857918>

Reviewed by Mark Rowe.

WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources

and Streamline Inspector Source build phases.

4:44 PM Changeset in webkit [114183] by barraclough@apple.com

6 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch method checks
https://bugs.webkit.org/show_bug.cgi?id=83958

Reviewed by Oliver Hunt.

bytecode/StructureStubInfo.h:
- Add fields for the method check info.
jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

Store the offsets on the stub info, instead of asserting.

jit/JIT.h:
- Delete all the method check related offsets.
jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

Use the offset from the stubInfo.

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

Pass the stubInfo to patchMethodCallProto.

4:44 PM Changeset in webkit [114182] by Simon Fraser

7 edits in trunk/LayoutTests

Rebaseline some compositing tests. Some were affected by the colorspace of
the sample image changing.

compositing/images/direct-pdf-image-expected.png:
compositing/repaint/newly-composited-repaint-rect-expected.png:
compositing/visibility/visibility-image-layers-expected.png:
compositing/visibility/visibility-simple-video-layer-expected.png:
platform/mac/compositing/reflections/reflection-in-composited-expected.png:
platform/mac/compositing/reflections/simple-composited-reflections-expected.png:

4:43 PM Changeset in webkit [114181] by abarth@webkit.org

1 edit
11 deletes in trunk/LayoutTests

fast/dom/Window/window-property-descriptors.html is too much work to maintain
https://bugs.webkit.org/show_bug.cgi?id=83915

Reviewed by Alexey Proskuryakov.

The goal of this test is to remind us whenever we add something to the
global scope. In practice, however, this test is a lot of work to
maintain because every port has different features enabled, which means
every port has a different list of things in the global scope. It's
very difficult to make changes without causing this test to go red on a
number of bots.

Rather than use this test to monitor the global scope, we're better off
paying attention to the IDL files. If folks are interested in changes
to what is exposed to JavaScript, they can subscribe to IDL changes
using a watchlist. (That's what I do, and it works pretty well.)

fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
fast/dom/Window/window-property-descriptors.html: Removed.
platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.

4:31 PM Changeset in webkit [114180] by jer.noble@apple.com

5 edits in trunk/Source

Video at apple.com gets standard controls in addition to custom controls after returning from full screen
https://bugs.webkit.org/show_bug.cgi?id=83939

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; DRT and WKTR don't have the infrastructure to test full-screen animation related bugs.

Instead of asking the media element whether it is in full screen or not, rely on when the media root element
was told that it enteredFullscreen() or exitedFullscreen(), which may occur at a different time than the
media element due to animations.

html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):

html/shadow/MediaControlRootElement.h:

(MediaControlRootElement): Added m_isFullscreen;

Source/WebKit2:

So that the media controls don't show up momentarily during full screen animations, call setAnimatingFullScreen(true)
before calling will{Enter,Exit}FullScreen(), so that the CSS rule for full screen animation will be in effect
immediately.

Similarly, call setAnimatingFullScreen(false) after calling did{Enter,Exit}FullScreen, so that the full screen media
controls don't momentarily appear at the end of an animation.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

4:27 PM Changeset in webkit [114179] by jer.noble@apple.com

5 edits
1 delete in trunk

fullscreen/video-controls-drag.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=81176

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Fixes fullscreen/video-controls-drag.html.

Regressed in r110409. When the -webkit-media-controls-panel were changed
from position:absolute to position:relative, this broke dragging of the
controls in fullscreen, which relies on the panel being absolutely positioned
to do its drag positioning. Change the way drag positioning is calculated to
accommodate position:relative.

css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel): Instead of bottom:50px,

use margin-bottom:50px to push panel up from the bottom of the screen.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag): Do not ask for the current renderer location.
(WebCore::MediaControlPanelElement::continueDrag): Use the delta between the event locations

only to calculate the new panel position.

html/shadow/MediaControlElements.h:

LayoutTests:

Removed expected failing results from platform/mac.

platform/mac/fullscreen/video-controls-drag-expected.txt: Removed.

4:25 PM Changeset in webkit [114178] by Simon Fraser

5 edits in trunk/LayoutTests

Fix two compositing animation tests to not have flakey pixel results
https://bugs.webkit.org/show_bug.cgi?id=83957

Reviewed by Dean Jackson.

Fix these tests to use the pause animation API by providing an animation
name in the expected data. There's no need to start the animations by hand.

compositing/reflections/animation-inside-reflection.html:
compositing/reflections/nested-reflection-animated.html:
platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
platform/mac/compositing/reflections/nested-reflection-animated-expected.png:

4:16 PM Changeset in webkit [114177] by andersca@apple.com

2 edits in trunk/LayoutTests

Rebaseline this since svg/custom/resources/green-checker.png changed.

svg/custom/image-with-prefix-in-webarchive-expected.webarchive:

3:51 PM Changeset in webkit [114176] by Simon Fraser

13 edits in trunk/LayoutTests

Avoid use of ::webkit-scrollbar to hide scrollbars, since it doesn't work in WK1
https://bugs.webkit.org/show_bug.cgi?id=83950

Reviewed by James Robinson.

Remove use of ::webkit-scrollbar from compositing tests, since this doesn't
affect WebKit1 scrollbars.

compositing/geometry/fixed-position-composited-page-scale-down.html:
compositing/geometry/fixed-position-composited-page-scale.html:
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
compositing/geometry/fixed-position-iframe-composited-page-scale.html:
compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
compositing/geometry/fixed-position-transform-composited-page-scale.html:
platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:

3:26 PM Changeset in webkit [114175] by Simon Fraser

5 edits
1 delete in trunk

Compositing layers not updated after scroll in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=83945

Source/WebCore:

Reviewed by James Robinson.

Fix the WebKit1 code path to correctly update compositing layers
after a scroll, by calling updateFixedElementsAfterScrolling() from
scrollPositionChangedViaPlatformWidget().

Covered by existing tests.

page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):

LayoutTests:

Reviewed by James Robinson.

Replace an incorrect Mac baseline with the correct result which was
already in place for WebKit2.

Remove a passing test from test-expectations.

compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
platform/mac/test_expectations.txt:

3:09 PM Changeset in webkit [114174] by scheib@chromium.org

2 edits in trunk/LayoutTests

Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html

Unreviewed.

platform/chromium/test_expectations.txt:

3:05 PM Changeset in webkit [114173] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Fix skipped list.

Skipped:

3:02 PM Changeset in webkit [114172] by dino@apple.com

6 edits
4 adds in trunk

Don't process filters if the input region is exceptionally large.
https://bugs.webkit.org/show_bug.cgi?id=83317

Reviewed by Simon Fraser.

Source/WebCore:

An extremely large element causes problems with filters, either by
taking too long to compute the output or using too much memory. The
filter engine already has some constants for maximum expected size.
Make sure the render tree checks them before deciding to apply
effects.

Tests: css3/filters/huge-region-composited.html

css3/filters/huge-region.html

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):

rendering/FilterEffectRenderer.cpp:

(WebCore):
(WebCore::isFilterSizeValid):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::updateBackingStore):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):

rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):

LayoutTests:

css3/filters/huge-region-composited-expected.txt: Added.
css3/filters/huge-region-composited.html: Added.
css3/filters/huge-region-expected.txt: Added.
css3/filters/huge-region.html: Added.

2:45 PM Changeset in webkit [114171] by annacc@chromium.org

11 edits in trunk

Queue the cuechange event on HTMLTrackElement for proper sorting.
https://bugs.webkit.org/show_bug.cgi?id=83858

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updates to media/track/track-cues-cuechange.html and
media/track/track-mode.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Add HTMLTrackElement's cuechange event to the event queue rather than
firing it synchronously.

html/track/LoadableTextTrack.cpp:

Remove fireCueChangeEvent() as it is no longer used.

html/track/LoadableTextTrack.h:

Ditto.

html/track/TextTrack.h:

(TextTrack):

Ditto.

LayoutTests:

media/track/captions-webvtt/captions-fast.vtt:

Captions were a wee bit too fast: they need to be at least 250ms apart
for accurate testing as timeupdate events are only fired every 250ms.

media/track/track-cues-cuechange-expected.txt:

Changes the order that cuechange events are fired.

media/track/track-cues-cuechange.html:

Ditto.

media/track/track-mode-expected.txt:

cuechange events are now fired at the proper times.
Test now checks for all cuechange events (both enter and exit of cues).

media/track/track-mode.html:

Ditto.

2:32 PM Changeset in webkit [114170] by tonikitoo@webkit.org

9 edits
48 adds in trunk

Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map
https://bugs.webkit.org/show_bug.cgi?id=79611

Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:

As of today, any FrameView attached to the Widget-tree or any
RenderLayer whose corresponding RenderBox's style has a 'overflow'
property set to 'auto' is cached in its containing scrollable areas set.
We could be more restrictive about what we in fact want to
cache as scrollable areas, by checking if the element as an overflow
(i.e. more content than its viewport).

page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

Whenever the viewport changes, check if we have an scrollable/overflowed
content, and update the cache accordingly.

(WebCore::FrameView::setContentsSize):

Whenever the contents size changes, check if we have a scrollable/overflowed
content, and update the cache accordingly.

(WebCore::FrameView::calculateScrollbarModesForLayout):

Introduces a way to query for the scrollbars by only
taking into account the "rules" set by the web author.
For that, a new enum was added called SrollbarModesCalculationStrategy,
which allows callers to discard for example client-side scrollbar policies
in order to verify if a given frameview is scrollable or not.

(WebCore::FrameView::updateScrollableAreaSet):

Take into account various factors before considering a FrameView as
scrollable. If in the end it is, it gets added to its parent FrameView
scrollable areas map, otherwise removed.

(WebCore):
(WebCore::FrameView::addScrollableArea):

Became unneeded, thus removed.

(WebCore::FrameView::removeScrollableArea):

Whenever a FrameView is removed from the Widget-tree,
remove it from the cache.

page/FrameView.h:

(FrameView):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):

Update scrollable area set after layout.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

Update scrollable area set after style changes.

(WebCore::RenderLayer::styleChanged):

Removed the scrollable areas logic detection from it.

(WebCore::RenderLayer::updateScrollableAreaSet):

Updates the containing FrameView scrollable areas cache
only when needed (i.e. an overflow exists).

(WebCore):

rendering/RenderLayer.h:

(RenderLayer):

testing/Internals.cpp:

(WebCore::Internals::numberOfScrollableAreas):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Tests: fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html

fast/scrolling/scrollable-area-frame-overflow-hidden.html
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-scrolling-no.html
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html
fast/scrolling/scrollable-area-frame-scrolling-yes.html
fast/scrolling/scrollable-area-frame-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-zero-size-and-border.html
fast/scrolling/scrollable-area-frame.html
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-display-none.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html
fast/scrolling/scrollable-area-overflow-auto-visibility-override.html
fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html
fast/scrolling/scrollable-area-overflow-auto.html
fast/scrolling/scrollable-area-overflow-not-set.html
fast/scrolling/scrollable-area-overflow-visible.html

LayoutTests:

Reviewed by NOBODY (OOPS!).

Added scrollable area set count tests to many situations observed
in real world sites.

fast/scrolling/resources/generic-scrollable-content.html: Added.
fast/scrolling/resources/hidden-generic-scrollable-content.html: Added.
fast/scrolling/resources/scrollable-area.js: Added.

(runTest):
(end):

fast/scrolling/resources/scrollable-style.css: Added.

(.inner):
(.offscreen):

fast/scrolling/scrollable-area-frame-expected.txt: Added.
fast/scrolling/scrollable-area-frame-inherited-visibility-hidden-expected.txt: Added.
fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html: Added.
fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt: Added.
fast/scrolling/scrollable-area-frame-overflow-hidden.html: Added.
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden-expected.txt: Added.
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html: Added.
fast/scrolling/scrollable-area-frame-scrolling-no-expected.txt: Added.
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden-expected.txt: Added.
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html: Added.
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child-expected.txt: Added.
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html: Added.
fast/scrolling/scrollable-area-frame-scrolling-no.html: Added.
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none-expected.txt: Added.
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html: Added.
fast/scrolling/scrollable-area-frame-scrolling-yes-expected.txt: Added.
fast/scrolling/scrollable-area-frame-scrolling-yes.html: Added.
fast/scrolling/scrollable-area-frame-visibility-hidden-child-expected.txt: Added.
fast/scrolling/scrollable-area-frame-visibility-hidden-child.html: Added.
fast/scrolling/scrollable-area-frame-zero-size-and-border-expected.txt: Added.
fast/scrolling/scrollable-area-frame-zero-size-and-border.html: Added.
fast/scrolling/scrollable-area-frame.html: Added.
fast/scrolling/scrollable-area-overflow-auto-display-none-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html: Added.
fast/scrolling/scrollable-area-overflow-auto-display-none.html: Added.
fast/scrolling/scrollable-area-overflow-auto-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-override-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-override.html: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-visible-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html: Added.
fast/scrolling/scrollable-area-overflow-auto.html: Added.
fast/scrolling/scrollable-area-overflow-not-set-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-not-set.html: Added.
fast/scrolling/scrollable-area-overflow-visible-expected.txt: Added.
fast/scrolling/scrollable-area-overflow-visible.html: Added.

2:32 PM April 2012 Meeting edited by jacobg@adobe.com

(diff)

2:29 PM Changeset in webkit [114169] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Make sure that we're using the right compiler for generating derived sources.

Rubber-stamped by Dan Bernstein.

WebKit2.xcodeproj/project.pbxproj:

2:23 PM Changeset in webkit [114168] by Antti Koivisto

6 edits in trunk/Source/WebCore

Track rem unit usage in StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=83923

Reviewed by Andreas Kling.

Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to
the stylesheet instead so parser does not need to know about the document. This also
avoids setting the flag unnecessarily when the stylesheet is not used.

css/CSSGrammar.y:
css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):

css/CSSStyleSheet.h:

(WebCore::StyleSheetInternal::parserSetUsesRemUnits):
(WebCore::StyleSheetInternal::usesRemUnits):
(StyleSheetInternal):

dom/Document.cpp:

(WebCore):
(WebCore::checkUsesRemUnits):
(WebCore::Document::updateActiveStylesheets):

dom/Document.h:

(WebCore::Document::usesRemUnits):

2:19 PM Changeset in webkit [114167] by scheib@chromium.org

2 edits in trunk/LayoutTests

Chromium test_expectations TIMOUT mask for fast/canvas/2d.imageDataHD.html

Unreviewed.

platform/chromium/test_expectations.txt:

2:01 PM Changeset in webkit [114166] by jamesr@google.com

18 edits in trunk

[chromium] Remove unused compositeToTexture / compositeOffscreen setting
https://bugs.webkit.org/show_bug.cgi?id=83733

Reviewed by Adrienne Walker.

Source/Platform:

Remove compositeOffscreen setting. This was an experiment that is no longer needed.

chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

Source/WebKit/chromium:

Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

public/WebSettings.h:
src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

src/WebSettingsImpl.h:

(WebSettingsImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Tools:

Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

DumpRenderTree/chromium/TestShell.h:

(TestShell):

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

1:57 PM Changeset in webkit [114165] by ap@apple.com

5 edits in trunk

REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached
https://bugs.webkit.org/show_bug.cgi?id=83925
<rdar://problem/11231790>

Reviewed by Antti Koivisto.

Added subtests to http/tests/cache/subresource-expiration-2.html.

platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::parseCacheControlDirectives): Honor first max-age instead of the last. New behavior matches both Firefox and IE.

1:43 PM Changeset in webkit [114164] by jamesr@google.com

18 edits
2 moves
2 deletes in trunk/Source

[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851

Reviewed by Adam Barth.

Source/Platform:

Move WebVideoFrame API into Platform.

Platform.gypi:
chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.

(WebKit):

Source/WebCore:

Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).

Covered by existing media/ and compositing/ layout tests.

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebKit):

Source/WebKit/chromium:

Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.

WebKit.gyp:
public/WebVideoFrame.h:
src/AssertMatchingEnums.cpp:
src/VideoFrameChromiumImpl.cpp: Removed.
src/VideoFrameChromiumImpl.h: Removed.
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

12:43 PM Changeset in webkit [114163] by scheib@chromium.org

6 edits
1 add in trunk

Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

WebCore.gypi:

Source/WebKit/chromium:

features.gypi:

LayoutTests:

platform/chromium/test_expectations.txt:

12:39 PM Changeset in webkit [114162] by tomz@codeaurora.org

6 edits
12 adds in trunk/LayoutTests

Integrate IETC CSS : grid layout tests
https://bugs.webkit.org/show_bug.cgi?id=83830

Patch by Dave Tharp < dtharp@codeaurora.org> on 2012-04-13
Reviewed by Adam Barth

ietestcenter/css3/grid/display-grid-001.htm: Added.
ietestcenter/css3/grid/display-grid-002.htm: Added.
ietestcenter/css3/grid/grid-column-001.htm: Added.
ietestcenter/css3/grid/grid-column-002.htm: Added.
ietestcenter/css3/grid/grid-column-003.htm: Added.
ietestcenter/css3/grid/grid-columns-001.htm: Added.
ietestcenter/css3/grid/grid-items-001.htm: Added.
ietestcenter/css3/grid/grid-items-002.htm: Added.
ietestcenter/css3/grid/grid-items-003.htm: Added.
ietestcenter/css3/grid/grid-items-004.htm: Added.
ietestcenter/css3/grid/grid-items-005.htm: Added.
platform/chromium/test_expectations.txt:
platform/efl/test_expectations.txt:
platform/gtk/test_expectations.txt:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:

12:34 PM Changeset in webkit [114161] by Lucas Forschler

3 edits
3 copies in tags/Safari-536.6.2

Merged r113941.

12:33 PM Changeset in webkit [114160] by Michael Nordman

12 edits
5 deletes in trunk/Source

[chromium] Now that the chromium port is using a different dom_storage backend
library in its main browser process, there are a handful of files that should no
longer be included in the build, and a few files than should be deleted
outright, and the webkit api should be modified to reflect the new (and smaller)
contract between the embedder and webkit/webcore.
https://bugs.webkit.org/show_bug.cgi?id=83807

Reviewed by Adam Barth.

Source/WebCore:

No new tests, existing tests apply.

WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
storage/StorageEventDispatcher.h: Delete a stale comment.

Source/WebKit/chromium:

WebKit.gyp: Delete a few files.
public/WebStorageNamespace.h: Remove some unused data members and methods, and annotate close() as deprecated.
public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
src/StorageAreaProxy.cpp: Remove the include of a deleted file.
src/StorageEventDispatcherChromium.cpp: Removed.
src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
src/StorageNamespaceProxy.h: Moved some blank lines around.
src/WebStorageAreaImpl.cpp: Removed.
src/WebStorageAreaImpl.h: Removed.
src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
src/WebStorageNamespaceImpl.cpp: Removed.
src/WebStorageNamespaceImpl.h: Removed.

12:32 PM Changeset in webkit [114159] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed, rebaselining after r114150.

platform/gtk/fast/dom/Window/window-properties-expected.txt:

12:26 PM Changeset in webkit [114158] by rniwa@webkit.org

3 edits in trunk/Tools

webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
and also rebaseline the test results since we ignore the first run now.

Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.run):

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPageLoadingPerfTest.test_run):

12:24 PM Changeset in webkit [114157] by barraclough@apple.com

7 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch get_by_id/put_by_id
https://bugs.webkit.org/show_bug.cgi?id=83924

Reviewed by Oliver Hunt.

Store offsets in the structure stub info, as we do for the DFG JIT.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::differenceBetween):

this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)

bytecode/StructureStubInfo.h:
- added new fields for baseline JIT offsets.
jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

moved out from JIT::privateCompile.

(JSC::JIT::privateCompile):

moved out code to PropertyStubCompilationInfo::copyToStubInfo.

jit/JIT.h:

(PropertyStubCompilationInfo):

added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
removed many offsets.

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

changed code generation to use new interface to store info on PropertyStubCompilationInfo.
changed repatch functions to read offsets from the structure stub info.

jit/JITPropertyAccess32_64.cpp:

changed code generation to use new interface to store info on PropertyStubCompilationInfo.
changed repatch functions to read offsets from the structure stub info.

12:21 PM Changeset in webkit [114156] by Lucas Forschler

4 edits in tags/Safari-536.6.2/Source

Versioning.

12:20 PM Changeset in webkit [114155] by Lucas Forschler

1 copy in tags/Safari-536.6.2

New Tag.

12:19 PM Changeset in webkit [114154] by andersca@apple.com

2 edits in trunk/LayoutTests

More rebaselining.

platform/mac/fast/dom/Window/window-properties-expected.txt:

12:02 PM Changeset in webkit [114153] by rwlbuis@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

Fix signed/unsigned comparison warning.

parser/Lexer.cpp:

(JSC::::record16):

11:49 AM Changeset in webkit [114152] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Include the error if we fail to initialize the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=83927

Reviewed by Alexey Proskuryakov.

WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

11:26 AM Changeset in webkit [114151] by scheib@chromium.org

6 edits
1 delete in trunk

Unreviewed, rolling out r114140.
http://trac.webkit.org/changeset/114140
https://bugs.webkit.org/show_bug.cgi?id=83921

Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

WebCore.gypi:

Source/WebKit/chromium:

features.gypi:

LayoutTests:

platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
platform/chromium/test_expectations.txt:

11:25 AM PrefixedAPIs edited by mitz@apple.com

Added CanvasRenderingContext2D extensions for high-resolution backing … (diff)

11:20 AM Changeset in webkit [114150] by mitz@apple.com

13 edits
4 adds in trunk

<rdar://problem/10912680> Pixel access canvas APIs do not operate at backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83836

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/2d.imageDataHD.html

Added getImageDataHD and putImageDataHD functions to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The functions
are prefixed with “webkit” for now.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData): Added this cover function that calls
through to getImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Added. Calls through to
getImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::getImageData): Added a CoordinateSystem parameter to this
now-private function. It is passed through to ImageBuffer::getUnmultipliedImageData().
(WebCore::CanvasRenderingContext2D::putImageData): Added this cover function that calls
through to putImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Added. Calls through to
putImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::putImageData): Added a CoordinateSystem parameter to this
function. It is passed through to ImageBuffer::putByteArray, and used to compute the rect to
invalidate after the drawing operation.

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.idl: Added webkitPutImageDataHD() and

webkitGetImageDataHD().

platform/graphics/ImageBuffer.h: Added a CoordinateSystem enum with the values

LogicalCoordinateSystem and BackingStoreCoordinateSystem. Added a CoordinateSystem parameter,
which defaults to LogicalCoordinateSystem, to getUnmultipliedImageData,
getPremultipliedImageData, and putByteArray.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData): Now uses the CoordinateSystem parameter to
decide whether to ask ImageBufferDaya::getData() to apply the resolution scale or not.
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Now uses the CoordinateSystem parameter to decide
whether to maintain the resolution scale while drawing or not.
(WebCore::ImageBuffer::toDataURL):

platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

LayoutTests:

fast/canvas/2d.imageDataHD-expected.txt: Added.
fast/canvas/2d.imageDataHD.html: Added.

11:16 AM Changeset in webkit [114149] by rniwa@webkit.org

6 edits
1 add in trunk

Enable SVG page loading performance tests
https://bugs.webkit.org/show_bug.cgi?id=83861

Reviewed by Adam Barth.

PerformanceTests:

Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
and the ones that take too long to load (more than 20s).

Skipped:

Tools:

Add support for page loading tests. These are tests without any test running harnesses, and we use
DriverOutput's test_timeout to measure the loading time.

Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.

Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.run):
(PerfTest):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest): Added.
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.

Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.

(MockPrinter):
(MockPrinter.init):
(MockPrinter.write):
(MainTest):
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.assertWritten):
(TestPageLoadingPerfTest.MockDriver):
(TestPageLoadingPerfTest.MockDriver.init):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests_with_page_load_svg):
(test_collect_tests_with_page_load_svg.add_file):

11:15 AM Changeset in webkit [114148] by andersca@apple.com

2 edits in trunk/LayoutTests

Rebaseline a test.

platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

11:06 AM Changeset in webkit [114147] by shawnsingh@chromium.org

12 edits
2 adds in trunk/Source/WebCore

[chromium] Support CCHeadsUpDisplay in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=67499

Reviewed by James Robinson.

No new tests because this code is debugging code itself.

The last item that was needed to make the CCHeadsUpDisplay work in
threaded compositing mode was to remove the font rendering code
used on the impl-side thread. To solve this, this patch adds a
CCFontAtlas that is initialized on the main thread (where the font
rendering takes place). Then, when the HUD draws text on the impl
thread, it uses the font atlas directly.

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):

platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

platform/graphics/chromium/cc/CCFontAtlas.cpp: Added.

(WebCore):
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::wrapPositionIfNeeded):
(WebCore::CCFontAtlas::generateAtlasForFont):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):

platform/graphics/chromium/cc/CCFontAtlas.h: Added.

(WebCore):
(CCFontAtlas):
(WebCore::CCFontAtlas::create):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):

platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(WebCore::CCLayerTreeHost::headsUpDisplayFontAtlas):
(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

11:06 AM Changeset in webkit [114146] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed - remove duplicate entries for two failing sputnik tests
from the test_expectations.txt file.

platform/gtk/test_expectations.txt:

11:03 AM Changeset in webkit [114145] by jchaffraix@webkit.org

11 edits
8 copies in branches/chromium/1084

Merge 112582 - REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
https://bugs.webkit.org/show_bug.cgi?id=82129

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html

fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html

This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.

rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.

LayoutTests:

fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.

Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.

platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:

Rebaselined those tests on Chromium linux (new layers).

platform/chromium/test_expectations.txt:
platform/efl/Skipped:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wk2/Skipped:

Skipped the previous tests on the other platforms.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10090001

10:47 AM Changeset in webkit [114144] by scheib@chromium.org

2 edits in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Previous clean up in r114137 dropped a WIN IMAGE failure suppression.

platform/chromium/test_expectations.txt:

10:46 AM Changeset in webkit [114143] by beidson@apple.com

18 edits
2 adds in trunk

<rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache

Source/WebKit2:

Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified of back/forward navigations (and deny them if it chooses)
Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.

Reviewed by Darin Adler.

Add the new WKBundleBackForwardListItem API:

WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemIsInPageCache):

WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::isInPageCache):

Update the UI page loader client to allow for a user data object to be passed from the bundle:

UIProcess/API/C/WKPage.h:
UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.

UIProcess/WebLoaderClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willGoToBackForwardListItem):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

Add the new callback to the bundle loader client:

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):

WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient):

Call the bundle client before doing anything else, possibly canceling the navigation:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.

Tools:

Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.

Reviewed by Darin Adler.

TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.

(ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::shouldGoToBackForwardListItemCallback):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.

10:43 AM Changeset in webkit [114142] by harrison@apple.com

2 edits in branches/safari-534.57-branch/Source/WebCore

<rdar://problem/10552398> Meringue: 11A390: CrashTracer: 56,187 crashes in WebProcess at com.apple.WebCore: WebCore::DocumentWriter::deprecatedFrameEncoding const + 12 (71828)

Reviewed by Darin Adler.

No new tests because this change is going only on the Safari Nectarine branch, not TOT.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
Nil check the activeDocumentLoader().

10:40 AM Changeset in webkit [114141] by abarth@webkit.org

2 edits
1 add in trunk/LayoutTests

Update baselines to make this test run again.

platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Replaced.
platform/chromium/test_expectations.txt:

10:20 AM Changeset in webkit [114140] by commit-queue@webkit.org

6 edits
1 add in trunk

Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

WebCore.gypi:

Source/WebKit/chromium:

features.gypi:

LayoutTests:

platform/chromium/test_expectations.txt:

9:16 AM Changeset in webkit [114139] by antonm@chromium.org

2 edits in trunk/LayoutTests

Mark test as even flakier: it can timeout.

Unreviewed.

platform/chromium/test_expectations.txt:

9:05 AM Changeset in webkit [114138] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Flag fast/regions

again. Only parts of it were passing, sigh.

8:49 AM Changeset in webkit [114137] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Consolidating common-cause flaky tests.

platform/chromium/test_expectations.txt:

8:42 AM Changeset in webkit [114136] by eae@chromium.org

1794 edits
1801 copies
80 deletes in branches/subpixellayout

Merge trunk changes up until 114126 into subpixel branch.

8:41 AM Changeset in webkit [114135] by pfeldman@chromium.org

5 edits in trunk

Web Inspector: do not attempt to load content from resource until request finished loading.
https://bugs.webkit.org/show_bug.cgi?id=83896

Reviewed by Yury Semikhatsky.

Source/WebCore:

When we stop in the inline script on reload, we should only show concatenated script content.
When we resume, we should replace UI source code with the actual HTML content. We should not attempt to
fetch resource content until request finished loading. I regressed it in the Request extraction
and now am bringing it back.

inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

inspector/debugger/raw-source-code.html:

8:40 AM Changeset in webkit [114134] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Unskip fast/regions and

svg/hixie/perf that seem to pass fine on GTK bots.

7:33 AM Changeset in webkit [114133] by pfeldman@chromium.org

4 edits in trunk

Web Inspector: follow up to r114116 - fixing QT test
https://bugs.webkit.org/show_bug.cgi?id=83892

Reviewed by Yury Semikhatsky.

Source/WebCore:

Requesting content for the scripts exclusively via the page agent now.

inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.requestContent):

LayoutTests:

inspector/debugger/raw-source-code.html:

7:30 AM Changeset in webkit [114132] by commit-queue@webkit.org

3 edits in trunk/Tools

Group EFL bots into a category on the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=82712

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-13
Reviewed by Adam Roben.

Creating a new category definition on the buildbot frontend.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig): Determine category for EFL bots

BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category

7:28 AM Changeset in webkit [114131] by yi.4.shen@nokia.com

5 edits in trunk

InsertHTML fails to insert h6 if the insertion point is before some text.
https://bugs.webkit.org/show_bug.cgi?id=82689

Reviewed by Ryosuke Niwa.

Added the missing h6 tag for the isHeaderElement.

Source/WebCore:

No new tests: updated existing test (editing/execCommand/4128080-1.html)

editing/ReplaceSelectionCommand.cpp:

(WebCore::isHeaderElement):

LayoutTests:

editing/execCommand/4128080-1-expected.txt:
editing/execCommand/4128080-1.html:

7:25 AM Changeset in webkit [114130] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

2012-04-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix after r114126.

WebKit.gyp:

7:23 AM Changeset in webkit [114129] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-13
Reviewed by Noam Rosenthal.

This fixes API tests broken by r113715.

UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:

7:18 AM Changeset in webkit [114128] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Marking some css2.1 tests flaky.

7:16 AM Changeset in webkit [114127] by antonm@chromium.org

2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

platform/chromium/test_expectations.txt:

6:50 AM Changeset in webkit [114126] by yurys@chromium.org

19 edits
1 add
2 deletes in trunk

Web Inspector: exception in heap profiler when expanding a class in summary view
https://bugs.webkit.org/show_bug.cgi?id=83883

Moved all DOM-specific inspector utilities into DOMExtension.js

Merged BinarySearch.js and PartialQuickSort.js into utilities.js, HeapSnapshotWorker.js now
imports utilities.js which contains all required routines.

Reviewed by Pavel Feldman.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/BinarySearch.js: Removed.
inspector/front-end/DOMExtension.js: Copied from Source/WebCore/inspector/front-end/utilities.js.

(Node.prototype.rangeOfWord):
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
(Element.prototype.removeStyleClass):
(Element.prototype.removeMatchingStyleClasses):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
(Element.prototype.positionAt):
(Element.prototype.pruneEmptyTextNodes):
(Element.prototype.isScrolledToBottom):
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray):
(Node.prototype.enclosingNodeOrSelfWithNodeName):
(Node.prototype.enclosingNodeOrSelfWithClass):
(Node.prototype.enclosingNodeWithClass):
(Element.prototype.query):
(Element.prototype.removeChildren):
(Element.prototype.isInsertionCaretInside):
(Element.prototype.createChild):
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):
(Element.prototype.boxInWindow):
(Element.prototype.setTextAndTitle):
(Event.prototype.consume):
(Text.prototype.select):
(Element.prototype.selectionLeftOffset):
(Node.prototype.isAncestor):
(Node.prototype.isDescendant):
(Node.prototype.isSelfOrAncestor):
(Node.prototype.isSelfOrDescendant):
(Node.prototype.traverseNextNode):
(Node.prototype.traversePreviousNode):
(HTMLTextAreaElement.prototype.moveCursorToEnd):
(isEnterKey):
(consumeEvent):
(highlightSearchResult):
(highlightSearchResults):
(highlightRangesWithStyleClass):
(applyDomChanges):
(revertDomChanges):

inspector/front-end/HeapSnapshot.js: Fixed a couple of js compiler warnings

by describing structure of heap snapshot header in the protocol.
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

inspector/front-end/HeapSnapshotWorker.js:
inspector/front-end/PartialQuickSort.js: Removed.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/utilities.js:

(.):

6:45 AM Changeset in webkit [114125] by antonm@chromium.org

2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

platform/chromium/test_expectations.txt:

6:26 AM Changeset in webkit [114124] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r113714.
http://trac.webkit.org/changeset/113714
https://bugs.webkit.org/show_bug.cgi?id=83887

It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebKit2:

UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

6:16 AM Changeset in webkit [114123] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Unreviewed, rolling out r114103.
http://trac.webkit.org/changeset/114103
https://bugs.webkit.org/show_bug.cgi?id=83884

New breakpoint UI looks bad / needs polish. (Requested by
pfeldman_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

inspector/front-end/Images/breakpointConditionalCounterBorder.png:
inspector/front-end/Images/breakpointCounterBorder.png:
inspector/front-end/Images/programCounterBorder.png:
inspector/front-end/textViewer.css:

(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

6:14 AM Changeset in webkit [114122] by commit-queue@webkit.org

3 edits
2 adds in trunk

[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
https://bugs.webkit.org/show_bug.cgi?id=83760

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-13
Reviewed by George Staikos.

ManualTests/blackberry/http-cookie-database-set.php: Added.
ManualTests/blackberry/http-cookie-database-update.php: Added.

Source/WebCore:

When we update cookies' database, protocol shouldn't be checked since it is not a cookie's key.
ESPN.com's https cookies should replace old http cookies if they have the same keys(name, path, domain).

We must restart the browser to test, so have to write a manual test case.

Test: ManualTests/blackberry/http-cookie-database-set.php

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::invokeOpen):

6:06 AM Changeset in webkit [114121] by antonm@chromium.org

2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

platform/chromium/test_expectations.txt:

6:01 AM Changeset in webkit [114120] by jocelyn.turcotte@nokia.com

2 edits in trunk/Tools

webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
https://bugs.webkit.org/show_bug.cgi?id=83690

Reviewed by Tor Arne Vestbø.

Typing part of an email and pressing <TAB> will bash-complete it using the list in
Tools/Scripts/webkitpy/common/config/committers.py

Scripts/webkit-tools-completion.sh:

5:57 AM Changeset in webkit [114119] by Csaba Osztrogonác

6 edits in trunk/LayoutTests

[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-04-13
Reviewed by Csaba Osztrogonác.

platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
platform/qt/Skipped:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

5:56 AM Changeset in webkit [114118] by jocelyn.turcotte@nokia.com

4 edits in trunk/Source

[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
https://bugs.webkit.org/show_bug.cgi?id=83770

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Revert the previous way of dealing with things. The problem is that different layers
would end up rounding in different directions, and would cause jittering between
layers or with the QQuickWebPage's background.

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

Source/WebKit2:

Do the alignment on the highest level as possible: the QQuickFlickable content item position. It already supports this with setPixelAligned which rounds the content item's position.
Also move the setClip(true) to the common constructor as this constructor is currently only used by WTR.
Remove setFlags(QQuickItem::ItemClipsChildrenToShape) as it is redundant with setClip(true).

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

5:25 AM Changeset in webkit [114117] by pfeldman@chromium.org

15 edits in trunk

Web Inspector: introduce ParsedURL type, clean up url and displayName mess in Resource and NetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=83871

Reviewed by Yury Semikhatsky.

Source/WebCore:

There is a number of random properties created on Resource and NetworkRequest that represent various url
fragments. Display name is being based on them and sometimes requires fake Resource instance to be created.
This change (officially) introduces WebInspector.ParsedURL as a type that encapsulates this complexity.

This change also moves documentURL property into the Resource and NetworkRequest constructors and brushes up
factory methods used to create the objects.

inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):

inspector/front-end/Database.js:

(WebInspector.Database.prototype.get displayDomain):

inspector/front-end/JavaScriptContextManager.js:

(WebInspector.FrameEvaluationContext.prototype.get displayName):

inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.get documentURL):
(WebInspector.NetworkRequest.prototype.get parsedURL):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):

inspector/front-end/RequestHeadersView.js:

(WebInspector.RequestHeadersView.prototype._refreshUrlFragment):

inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get parsedURL):
(WebInspector.Resource.prototype.get frameId):
(WebInspector.Resource.prototype.get loaderId):
(WebInspector.Resource.prototype.get displayName):

inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeFrame.prototype._addRequest):

inspector/front-end/ResourceUtils.js:

(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
(WebInspector.displayDomain):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):

inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):

inspector/front-end/utilities.js:

LayoutTests:

inspector/debugger/raw-source-code.html:

5:15 AM Changeset in webkit [114116] by pfeldman@chromium.org

11 edits in trunk

Web Inspector: extracting NetworkRequest from Resource (step 3)
https://bugs.webkit.org/show_bug.cgi?id=83802

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change extracts NetworkRequest from the Resource. It is now clear that these two
should have super class that would be responsible for parsing URL and would define the
requestContent signature. Corresponding patch will follow.

inspector/front-end/NetworkManager.js:
inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.get requestId):
(WebInspector.NetworkRequest.prototype.set requestId):
(WebInspector.NetworkRequest.prototype.get url):
(WebInspector.NetworkRequest.prototype.get frameId):
(WebInspector.NetworkRequest.prototype.get loaderId):
(WebInspector.NetworkRequest.prototype.get startTime):
(WebInspector.NetworkRequest.prototype.set startTime):
(WebInspector.NetworkRequest.prototype.get responseReceivedTime):
(WebInspector.NetworkRequest.prototype.set responseReceivedTime):
(WebInspector.NetworkRequest.prototype.get endTime):
(WebInspector.NetworkRequest.prototype.set endTime):
(WebInspector.NetworkRequest.prototype.get duration):
(WebInspector.NetworkRequest.prototype.get latency):
(WebInspector.NetworkRequest.prototype.get receiveDuration):
(WebInspector.NetworkRequest.prototype.get resourceSize):
(WebInspector.NetworkRequest.prototype.set resourceSize):
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.increaseTransferSize):
(WebInspector.NetworkRequest.prototype.get finished):
(WebInspector.NetworkRequest.prototype.set finished):
(WebInspector.NetworkRequest.prototype.get failed):
(WebInspector.NetworkRequest.prototype.set failed):
(WebInspector.NetworkRequest.prototype.get canceled):
(WebInspector.NetworkRequest.prototype.set canceled):
(WebInspector.NetworkRequest.prototype.get cached):
(WebInspector.NetworkRequest.prototype.set cached):
(WebInspector.NetworkRequest.prototype.get timing):
(WebInspector.NetworkRequest.prototype.set timing):
(WebInspector.NetworkRequest.prototype.get mimeType):
(WebInspector.NetworkRequest.prototype.set mimeType):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
(WebInspector.NetworkRequest.prototype.get displayDomain):
(WebInspector.NetworkRequest.prototype.get type):
(WebInspector.NetworkRequest.prototype.set type):
(WebInspector.NetworkRequest.prototype.get redirectSource):
(WebInspector.NetworkRequest.prototype.set redirectSource):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.set requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.set requestHeadersText):
(WebInspector.NetworkRequest.prototype.get requestHeadersSize):
(WebInspector.NetworkRequest.prototype.requestHeaderValue):
(WebInspector.NetworkRequest.prototype.get requestCookies):
(WebInspector.NetworkRequest.prototype.get requestFormData):
(WebInspector.NetworkRequest.prototype.set requestFormData):
(WebInspector.NetworkRequest.prototype.get requestHttpVersion):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.set responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype.set responseHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersSize):
(WebInspector.NetworkRequest.prototype.responseHeaderValue):
(WebInspector.NetworkRequest.prototype.get responseCookies):
(WebInspector.NetworkRequest.prototype.get queryParameters):
(WebInspector.NetworkRequest.prototype.get formParameters):
(WebInspector.NetworkRequest.prototype.get responseHttpVersion):
(WebInspector.NetworkRequest.prototype._parseParameters):
(WebInspector.NetworkRequest.prototype._headerValue):
(WebInspector.NetworkRequest.prototype.get content):
(WebInspector.NetworkRequest.prototype.get contentEncoded):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.isHttpFamily):
(WebInspector.NetworkRequest.prototype.requestContentType):
(WebInspector.NetworkRequest.prototype.isPingRequest):
(WebInspector.NetworkRequest.prototype.hasErrorStatusCode):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._contentURL):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
(WebInspector.NetworkRequest.prototype.setResource):
(WebInspector.NetworkRequest.prototype.resource):

inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._resourceAdded):
(WebInspector.RawSourceCode.prototype.forceUpdateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):

inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get type):
(WebInspector.Resource.prototype.get mimeType):
(WebInspector.Resource.prototype.set mimeType):
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

http/tests/inspector/network/network-request-revision-content.html:
inspector/debugger/raw-source-code.html:
inspector/debugger/set-breakpoint.html:
inspector/debugger/source-frame.html:

5:12 AM Changeset in webkit [114115] by reed@google.com

2 edits in trunk/Source/WebCore

use getClipDeviceBounds, rather than (deprecated) getTotalClip
https://bugs.webkit.org/show_bug.cgi?id=83808

Reviewed by Stephen White.

Equivalent functionality, existing tests apply.

platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::didDraw):

5:02 AM Changeset in webkit [114114] by antonm@chromium.org

2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

platform/chromium/test_expectations.txt:

4:44 AM Changeset in webkit [114113] by commit-queue@webkit.org

14 edits
2 adds in trunk

[EFL] Add API for color chooser
https://bugs.webkit.org/show_bug.cgi?id=83692

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

Source/cmake/OptionsEfl.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/WebCore:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

PlatformEfl.cmake:
platform/efl/ColorChooserEfl.cpp: Added.

(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):

platform/efl/ColorChooserEfl.h: Added.

(WebCore):
(ColorChooserEfl):

Source/WebKit/efl:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):
(WebCore::ChromeClientEfl::createColorChooser):
(WebCore::ChromeClientEfl::removeColorChooser):
(WebCore::ChromeClientEfl::updateColorChooser):

WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

ewk/ewk_private.h:

(WebCore):

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):

ewk/ewk_view.h:

Tools:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

Scripts/build-webkit:

4:25 AM Changeset in webkit [114112] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt:

4:19 AM Changeset in webkit [114111] by antonm@chromium.org

1 edit
3 adds in trunk/LayoutTests

Linux rebaselines.

Unreviewed.

platform/chromium-linux/platform/chromium/compositing/filters: Added.
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.

4:16 AM Changeset in webkit [114110] by vestbo@webkit.org

3 edits in trunk/Source/WebKit/qt

[Qt] Build fix with QT_NO_BEARERMANAGEMENT

Reviewed by Jocelyn Turcotte.

4:11 AM Changeset in webkit [114109] by commit-queue@webkit.org

3 edits
2 adds in trunk

Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
https://bugs.webkit.org/show_bug.cgi?id=83860

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.

Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html

page/FrameView.cpp:

(WebCore::FrameView::delegatesScrollingDidChange):

LayoutTests:

fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.

4:09 AM Changeset in webkit [114108] by keishi@webkit.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Add WebKit API to access <datalist> options
https://bugs.webkit.org/show_bug.cgi?id=83762

Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.

Reviewed by Kent Tamura.

public/WebInputElement.h:

(WebKit):
(WebInputElement):

src/WebInputElement.cpp:

(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.

4:00 AM April 2012 Meeting edited by zherczeg@inf.u-szeged.hu

(diff)

3:39 AM Changeset in webkit [114107] by Philippe Normand

2 edits
64 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.

platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
platform/gtk/fast/dom/gc-10-expected.txt: Added.
platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
platform/gtk/fast/images/exif-orientation-expected.txt: Added.
platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
platform/gtk/fast/text/hyphens-expected.txt: Added.
platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
platform/gtk/test_expectations.txt: Mark a media/track test flaky.

3:37 AM Changeset in webkit [114106] by vestbo@webkit.org

3 edits in trunk/Source/WebKit/qt

[Qt] Fix build on OS X

We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.

Reviewed by Simon Hausmann.

3:29 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org

(diff)

3:23 AM Changeset in webkit [114105] by antonm@chromium.org

2 edits in trunk/LayoutTests

New suppression.

Unreviewed.

platform/chromium/test_expectations.txt:

3:11 AM Changeset in webkit [114104] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.

3:10 AM Changeset in webkit [114103] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Web Inspector: Line number is not displayed while debugging javascript
https://bugs.webkit.org/show_bug.cgi?id=83786

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.

Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view

No additional test cases required for the above fix.

inspector/front-end/Images/breakpointConditionalCounterBorder.png:
inspector/front-end/Images/breakpointCounterBorder.png:
inspector/front-end/Images/programCounterBorder.png:
inspector/front-end/textViewer.css:

2:37 AM Changeset in webkit [114102] by antonm@chromium.org

2 edits in trunk/LayoutTests

Now test sometimes crashes in Debug on XP too.

Unreviewed.

platform/chromium/test_expectations.txt:

2:15 AM Changeset in webkit [114101] by tkent@chromium.org

7 edits in trunk/Source

Add a runtime flag for <input type=date>
https://bugs.webkit.org/show_bug.cgi?id=83853

Reviewed by Adam Barth.

Source/WebCore:

bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled): Added.

html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):
Don't register type=date if !RuntimeEnabledFeatures::inputTypeDateEnabled()

Source/WebKit/chromium:

public/WebRuntimeFeatures.h:

(WebRuntimeFeatures): Add enableInputTypeDate() and isInputTypeDateEnabled().

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDate): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateEnabled): Added.

2:12 AM Changeset in webkit [114100] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

platform/gtk/test_expectations.txt: Skip failing new

encrypted-media test.

1:58 AM Changeset in webkit [114099] by antonm@chromium.org

1 edit
3 adds in trunk/LayoutTests

Rebaselines.

Unreviewed.

platform/chromium-mac/fast/ruby/nested-ruby-expected.txt: Added.
platform/chromium-mac/fast/text/international/002-expected.png: Added.
platform/chromium-mac/fast/text/international/002-expected.txt: Added.

1:57 AM Changeset in webkit [114098] by abarth@webkit.org

2 edits in trunk/Source/WebCore

JSDocument::setLocation does too much bare-handed lifting
https://bugs.webkit.org/show_bug.cgi?id=83850

Reviewed by Sam Weinig.

As part of auditing all the ways of kicking off a navigation, I
happened to read JSDocument::setLocation, which uses very old patterns.
This patch updates it to do things the "modern" way. There shouldn't
be any behavior change.

bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

1:55 AM Changeset in webkit [114097] by antonm@chromium.org

1 edit
4 adds in trunk/LayoutTests

Rebaselines.

Unreviewed.

platform/chromium-win/platform/chromium/compositing/filters: Added.
platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.

1:44 AM Changeset in webkit [114096] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

1:39 AM Changeset in webkit [114095] by shinyak@chromium.org

5 edits
4 adds in trunk

Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.

Since CachedImage has already similar code, we moved it to IntSize and shared it.

Tests: fast/css/zoom-background-repeat-x-expected.html

fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

platform/graphics/IntSize.h:

(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

LayoutTests:

fast/css/zoom-background-repeat-x-expected.html: Added.
fast/css/zoom-background-repeat-x.html: Added.
fast/css/zoom-background-repeat-y-expected.html: Added.
fast/css/zoom-background-repeat-y.html: Added.

12:56 AM Changeset in webkit [114094] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

DEPS:

12:53 AM Changeset in webkit [114093] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838

Reviewed by Ryosuke Niwa.

Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately. This patch refactors this function
to call findFrameForNavigation, which does both checks.

This doesn't change any behavior today, but it prepares us to implement
seamless navigation. Once the seamless branch lands, this change will
be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless

For context, see:
https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32